Merge branch 'master' of bitbucket.org:bluetradesys/spark into fix2

Fix expired fill crash

.gitignore

@@ -1,34 +1,36 @@
-nohup.out
-build/
-cmake-build-debug/
-.idea/
-.dir-locals.el
-*.pyc
-.vscode/*
-!.vscode/*.json
-.vs
-obj/
-*.csproj.user
-*.vspx
-*.psess
-msbuild.log
-*.orig
-vcxproj.user
-src/client/spark/Properties/launchSettings.json
-compile_commands.json
-.cquery_cached_index/
-src/client/sparkcmd/Properties/launchSettings.json
-node_modules
-paket-files
-project.lock.json
-src/server/sparkd/orderman/perf_analysis/data
-src/server/sparkd/orderman/perf_analysis/logs/
-src/server/sparkd/orderman/perf_analysis/trace_data/
-.fake
-*.fsx.lock
-*.code-workspace
-src/lib/orderman/perf_analysis/logs/latency_data/
-trace_data/
-/src/lib/orderman/perf_analysis/last_pretty_log.csv
-/src/lib/orderman/perf_analysis/log.csv
-/doc/user/public/*
+nohup.out
+build/
+cmake-build-debug/
+.idea/
+.dir-locals.el
+*.pyc
+.vscode/*
+!.vscode/*.json
+.vs
+obj/
+*.csproj.user
+*.vspx
+*.psess
+msbuild.log
+*.orig
+vcxproj.user
+src/client/spark/Properties/launchSettings.json
+compile_commands.json
+.cquery_cached_index/
+src/client/sparkcmd/Properties/launchSettings.json
+node_modules
+paket-files
+project.lock.json
+src/server/sparkd/orderman/perf_analysis/data
+src/server/sparkd/orderman/perf_analysis/logs/
+src/server/sparkd/orderman/perf_analysis/trace_data/
+.fake
+*.fsx.lock
+*.code-workspace
+src/lib/orderman/perf_analysis/logs/latency_data/
+trace_data/
+/src/lib/orderman/perf_analysis/last_pretty_log.csv
+/src/lib/orderman/perf_analysis/log.csv
+/doc/user/public/*
+.ionide/*
+/.ignore

.vscode/launch.json

@@ -118,7 +118,7 @@
             "program": "${workspaceRoot}/build/Debug/bin/net471/sparkcmd.exe",
             "args": [
                 "test",
-                "test_filter"
+                "ApiUpdateTests"
             ],
             "cwd": "${workspaceRoot}",
             "stopAtEntry": false,
@@ -135,13 +135,13 @@
             "name": "Spreader Tests",
             "type": "cppdbg",
             "request": "launch",
-            "program": "/home/bts/spark/build/ninja_debug/src/server/sparkd/sparkd",
+            "program": "/home/bts/spark/build/ninja_debug/server/sparkd",
             "args": [
                 "test",
                 "[spreader]"
             ],
             "stopAtEntry": false,
-            "cwd": "/home/bts/spark/build/ninja_debug/src/server/sparkd/",
+            "cwd": "/home/bts/spark/build/ninja_debug/server/",
             "environment": [],
             "externalConsole": true,
             "MIMode": "gdb",
@@ -249,7 +249,7 @@
             "program": "/home/bts/spark/build/ninja_debug/server/sparkd",
             "args": [
                 "test",
-                "SingleWriterConcurrentVector"
+                "[algo]"
             ],
             "stopAtEntry": false,
             "cwd": "/home/bts/spark/build/ninja_debug/server/",

doc/user/CMakeDeps.cmake

@@ -1 +1 @@
-set(sources /home/ppinto/Dropbox/bts/spark/doc/user/build.sh;content/_index.md;content/bts_spark/Algos/_index.md;content/bts_spark/Glossary/index.md;content/bts_spark/Help/about_spark.png;content/bts_spark/Help/image39.png;content/bts_spark/Help/image58.png;content/bts_spark/Help/index.md;content/bts_spark/Launcher/image38.png;content/bts_spark/Launcher/image68.png;content/bts_spark/Launcher/index.md;content/bts_spark/Logging-In-to-the-System/image3.png;content/bts_spark/Logging-In-to-the-System/image64.png;content/bts_spark/Logging-In-to-the-System/index.md;content/bts_spark/Market/change_securities.png;content/bts_spark/Market/image11.png;content/bts_spark/Market/image14.png;content/bts_spark/Market/image20.png;content/bts_spark/Market/image21.png;content/bts_spark/Market/image23.png;content/bts_spark/Market/image24.png;content/bts_spark/Market/image34.png;content/bts_spark/Market/image49.png;content/bts_spark/Market/image53.png;content/bts_spark/Market/image66.png;content/bts_spark/Market/image69.png;content/bts_spark/Market/index.md;content/bts_spark/Market/market_view.png;content/bts_spark/Market/settings_icon.png;content/bts_spark/Market/time_and_sales.png;content/bts_spark/My-Windows/image15.png;content/bts_spark/My-Windows/image16.png;content/bts_spark/My-Windows/image37.png;content/bts_spark/My-Windows/index.md;content/bts_spark/Settings/image51.png;content/bts_spark/Settings/image9.png;content/bts_spark/Settings/index.md;content/bts_spark/Spreader/image10.png;content/bts_spark/Spreader/image13.png;content/bts_spark/Spreader/image18.png;content/bts_spark/Spreader/image19.png;content/bts_spark/Spreader/image28.png;content/bts_spark/Spreader/image29.png;content/bts_spark/Spreader/image31.png;content/bts_spark/Spreader/image35.png;content/bts_spark/Spreader/image40.png;content/bts_spark/Spreader/image43.png;content/bts_spark/Spreader/image54.png;content/bts_spark/Spreader/image55.png;content/bts_spark/Spreader/image56.png;content/bts_spark/Spreader/image6.png;content/bts_spark/Spreader/image7.png;content/bts_spark/Spreader/image70.png;content/bts_spark/Spreader/image72.png;content/bts_spark/Spreader/image8.png;content/bts_spark/Spreader/index.md;content/bts_spark/Trading/algo_studio.png;content/bts_spark/Trading/collapse_all_icon.png;content/bts_spark/Trading/cover_algo_control.png;content/bts_spark/Trading/expand_all_icon.png;content/bts_spark/Trading/image1.png;content/bts_spark/Trading/image17.png;content/bts_spark/Trading/image2.png;content/bts_spark/Trading/image25.png;content/bts_spark/Trading/image27.png;content/bts_spark/Trading/image33.png;content/bts_spark/Trading/image42.png;content/bts_spark/Trading/image44.png;content/bts_spark/Trading/image47.png;content/bts_spark/Trading/image48.png;content/bts_spark/Trading/image5.png;content/bts_spark/Trading/image50.png;content/bts_spark/Trading/image52.png;content/bts_spark/Trading/image57.png;content/bts_spark/Trading/image59.png;content/bts_spark/Trading/image60.png;content/bts_spark/Trading/image61.png;content/bts_spark/Trading/image62.png;content/bts_spark/Trading/image73.png;content/bts_spark/Trading/image74.png;content/bts_spark/Trading/index.md;content/bts_spark/Trading/join_algo_control.png;content/bts_spark/Trading/ladder.png;content/bts_spark/Trading/ladder_badges.png;content/bts_spark/Trading/ladder_main_part.png;content/bts_spark/Trading/lean_algo_control.png;content/bts_spark/Trading/mini_orderbook.png;content/bts_spark/Trading/oco_algo_control.png;content/bts_spark/Trading/offset_algo_control.png;content/bts_spark/Trading/pnl_calculation.png;content/bts_spark/Trading/pnl_window.png;content/bts_spark/Trading/recreate_icon.png;content/bts_spark/Trading/settings_icon.png;content/bts_spark/Trading/spark_menu_order_book.png;content/bts_spark/Trading/top_algo_control.png;content/bts_spark/Trading/trigger_algo_control.png;content/bts_spark/_index.md;content/release_notes/_index.md;static/book.js;static/favicon.ico;static/image.js;templates/index.html;templates/page.html;templates/section.html;templates/shortcodes/back_button.html)
+set(sources /home/ppinto/Dropbox/bts/spark/doc/user/build.sh;content/_index.md;content/bts_spark/Glossary/_index.md;content/bts_spark/Help/_index.md;content/bts_spark/Help/about_spark.png;content/bts_spark/Help/image39.png;content/bts_spark/Help/image58.png;content/bts_spark/Launcher/_index.md;content/bts_spark/Launcher/image38.png;content/bts_spark/Launcher/image68.png;content/bts_spark/Logging-In-to-the-System/_index.md;content/bts_spark/Logging-In-to-the-System/image3.png;content/bts_spark/Logging-In-to-the-System/image64.png;content/bts_spark/Market/_index.md;content/bts_spark/Market/change_securities.png;content/bts_spark/Market/image11.png;content/bts_spark/Market/image14.png;content/bts_spark/Market/image20.png;content/bts_spark/Market/image21.png;content/bts_spark/Market/image23.png;content/bts_spark/Market/image24.png;content/bts_spark/Market/image34.png;content/bts_spark/Market/image49.png;content/bts_spark/Market/image53.png;content/bts_spark/Market/image66.png;content/bts_spark/Market/image69.png;content/bts_spark/Market/market_view.png;content/bts_spark/Market/settings_icon.png;content/bts_spark/Market/time_and_sales.png;content/bts_spark/My-Windows/_index.md;content/bts_spark/My-Windows/image15.png;content/bts_spark/My-Windows/image16.png;content/bts_spark/My-Windows/image37.png;content/bts_spark/Settings/_index.md;content/bts_spark/Settings/image51.png;content/bts_spark/Settings/image9.png;content/bts_spark/Spreader/_index.md;content/bts_spark/Spreader/image10.png;content/bts_spark/Spreader/image13.png;content/bts_spark/Spreader/image18.png;content/bts_spark/Spreader/image19.png;content/bts_spark/Spreader/image28.png;content/bts_spark/Spreader/image29.png;content/bts_spark/Spreader/image31.png;content/bts_spark/Spreader/image35.png;content/bts_spark/Spreader/image40.png;content/bts_spark/Spreader/image43.png;content/bts_spark/Spreader/image54.png;content/bts_spark/Spreader/image55.png;content/bts_spark/Spreader/image56.png;content/bts_spark/Spreader/image6.png;content/bts_spark/Spreader/image7.png;content/bts_spark/Spreader/image70.png;content/bts_spark/Spreader/image72.png;content/bts_spark/Spreader/image8.png;content/bts_spark/Trading/OrderTypes/index.md;content/bts_spark/Trading/_index.md;content/bts_spark/Trading/algo_studio.png;content/bts_spark/Trading/collapse_all_icon.png;content/bts_spark/Trading/cover_algo_control.png;content/bts_spark/Trading/expand_all_icon.png;content/bts_spark/Trading/image1.png;content/bts_spark/Trading/image17.png;content/bts_spark/Trading/image2.png;content/bts_spark/Trading/image25.png;content/bts_spark/Trading/image27.png;content/bts_spark/Trading/image33.png;content/bts_spark/Trading/image42.png;content/bts_spark/Trading/image44.png;content/bts_spark/Trading/image47.png;content/bts_spark/Trading/image48.png;content/bts_spark/Trading/image5.png;content/bts_spark/Trading/image50.png;content/bts_spark/Trading/image52.png;content/bts_spark/Trading/image57.png;content/bts_spark/Trading/image59.png;content/bts_spark/Trading/image60.png;content/bts_spark/Trading/image61.png;content/bts_spark/Trading/image62.png;content/bts_spark/Trading/image73.png;content/bts_spark/Trading/image74.png;content/bts_spark/Trading/join_algo_control.png;content/bts_spark/Trading/ladder.png;content/bts_spark/Trading/ladder_badges.png;content/bts_spark/Trading/ladder_main_part.png;content/bts_spark/Trading/lean_algo_control.png;content/bts_spark/Trading/mini_orderbook.png;content/bts_spark/Trading/oco_algo_control.png;content/bts_spark/Trading/offset_algo_control.png;content/bts_spark/Trading/pnl_calculation.png;content/bts_spark/Trading/pnl_window.png;content/bts_spark/Trading/recreate_icon.png;content/bts_spark/Trading/settings_icon.png;content/bts_spark/Trading/spark_menu_order_book.png;content/bts_spark/Trading/top_algo_control.png;content/bts_spark/Trading/trigger_algo_control.png;content/bts_spark/_index.md;content/release_notes/_index.md;content/system_requirements/_index.md;static/book.js;static/favicon.ico;static/image.js;templates/index.html;templates/page.html;templates/section.html;templates/shortcodes/back_button.html)

doc/user/content/bts_spark/Algos/_index.md

@@ -1,46 +0,0 @@
-+++
-title = "BTS Basic Algos"
-weight = 10
-sort_by = "weight"
-insert_anchor_links = "right"
-+++
-
-
-## Lean
-
-The goal of the lean order is to watch the opposite-inside market size and cross when that size goes below the threshold (this also implies a cross if that size goes to zero and the market trades away from you) If the market trades toward you, you can opt into several different behaviors
-
-##### Parameters
-  * Cross Thresh - size thresh in absolute or ratio terms
-  * Max Chase Ticks - max levels to pay up, in ticks
-
-
-## Join
-The goal of the join order is to watch the opposite-inside market and join when the market flips (that is, when the best offer becomes the best bid) and has at least threshold size.
-
-##### Parameters
-  * Join Thresh - size thresh in absolute or ratio terms
-
-
-## Top
-
-The goal of the top order is to not trade by yourself, but the intent at the time of order entry is to get filled.If the order is on the market (say current bid price) AND the quantity on that bid price is below top thresh then cancel the order else remain working.
-
-##### Parameters
-  * Top Thresh - size thresh in absolute or ratio terms
-
-
-## Cover
-A Cover order’s purpose is to fire a hedge order (of any type) in response to fills from it’s child order on the opposite side of the market N ticks away
-
-##### Parameters
-  * Profit Ticks - ticks above or below fill price to place profit / cover order
-
-
-## OCO
-An OCO order creates a relationship between a child order and a 'stop' or 'other' order such that when one of these is cancelled, both cancel, or when one is filled, the other order's size is debited in the amount of the fill.
-
-Composing this order with Cover simulates scalping functionality
-
-##### Parameters
-  * Stop Ticks - ticks below or above main order to place stop / other order

doc/user/content/bts_spark/Trading/OrderTypes/index.md

@@ -0,0 +1,77 @@
++++
+title = "Basic Algos"
+weight = 1
+sort_by = "weight"
+insert_anchor_links = "right"
+aliases = ["./bts_spark/Algos/"]
++++
+
+## Lean
+
+The goal of the lean order is to watch the opposite-inside market size and cross when that size goes below the threshold (this also implies a cross if that size goes to zero and the market trades away from you) If the market trades toward you, you can opt into several different behaviors
+
+##### Parameters
+  * Cross Thresh - size thresh in absolute or ratio terms
+  * Max Chase Ticks - max levels to pay up, in ticks
+
+
+## Join
+The goal of the join order is to watch the opposite-inside market and join when the market flips (that is, when the best offer becomes the best bid) and has at least threshold size.
+
+##### Parameters
+  * Join Thresh - size thresh in absolute or ratio terms
+
+
+## Top
+
+The goal of the top order is to not trade by yourself, but the intent at the time of order entry is to get filled.If the order is on the market (say current bid price) AND the quantity on that bid price is below top thresh then cancel the order else remain working.
+
+##### Parameters
+  * Top Thresh - size thresh in absolute or ratio terms
+
+
+## Cover
+A Cover order’s purpose is to fire a hedge order (of any type) in response to fills from it’s child order on the opposite side of the market N ticks away
+
+##### Parameters
+  * Profit Ticks - ticks above or below fill price to place profit / cover order
+
+
+## OCO
+An OCO order creates a relationship between a child order and a 'stop' or 'other' order such that when one of these is cancelled, both cancel, or when one is filled, the other order's size is debited in the amount of the fill.
+
+Composing this order with Cover simulates scalping functionality
+
+##### Parameters
+  * Stop Ticks - ticks below or above main order to place stop / other order
+
+## Splitter
+The splitter is useful for pro-rata markets where you want to vary your exposure independent of the order quantity that you want to fill.  The splitter will complete when the number of fills reaches or exceeds the order quantity but it will put exposed_qty total size on the market. Splitter favors order size over queue position.
+
+If exposed_qty is set to 0 the splitter will continue to exist in the Order Book but will cancel all of its child orders.  This makes it a useful building block for custom algos that need to implement a 'paused' state.
+
+##### Parameters
+  * exposed_qty - The total quantity to expose on the market.
+  * max_order_qty - The maximum size of a single order.
+
+
+## Scratch
+The scratch algo is similar to Lean, but instead of watching the opposite inside market, it watches the same side market and pays up when this quantity recedes below the scratch_threshold
+
+##### Parameters
+  * scratch_threshold - The quantity on the same side market below which to scratch
+  * chase_ticks - The number of ticks through the opposite market to pay up
+
+
+## ProRata
+The prorata algo is a special case hedging algo for pro-rata markets.  Users can specify two hedge types-- normal hedge and overfill hedge, the latter is spawned when you receive more fills than your fill_limit.  Further, the algo attempts to scratch when in an overfilled state AND optionally the same side size falls below stay_in_threshold
+
+##### Parameters
+  * hedge_ticks - The amount of ticks better hedges are placed on the opposite side market as the fill
+  * chase_ticks - How many ticks through the opposite market on a scratch
+  * fill_limit - The limit after which the algo considers further fills to be 'overfills'
+  * stay_in_threshold - A same side size threshold that enables the algo to 'stay in' even if overfilled
+  * enable_scratch_on_overfill - When true, overfills are immediately scratched upon the algo exiting
+  * enable_stay_in - When true, the algo will 'stay in' so long as the same side size is above stay_in_threshold, when false the algo attempts to 'get out' (and potentially scratch overfills) as soon as it reaches overfill status
+  * hedge - Child order type to send for normal hedges
+  * overfill_hedge - Child order type to send for overfill hedges

doc/user/content/release_notes/_index.md

@@ -4,6 +4,182 @@ weight = 3
 sort_by = "weight"
 insert_anchor_links = "right"
 +++
+## 2.10.0
+### User Visible Changes
+  - Fills now include information about the algo that originated the fill
+  - A new, more powerful PnL form is now available
+### API Changes
+  - Added security state information (pre open, halted, normal, closed, etc) 
+### Bug Fixes
+  - Brought back the "select all" check box in the mini order book
+  - Fixed an issue in the market data subsystem that on rare occasions could result in a startup crash
+### Internal Changes
+  - Fixed an issue that was stopping us from interpreting SOD times as local rather than GMT 
+## 2.9.3
+### Internal Changes
+  - Fixed system test scripts
+## 2.9.2
+### Bug Fixes
+  - Fixed an issue with the exchange simulator that could lead to crossed markets
+## 2.9.1
+### Bug Fixes
+  - Fixed an issue with trade sound alerts, where in some cases the use of a "In Between" condition could lead to a UI failure.
+  - Fixed an issue with the display of the new raw position column in the market view window.
+  - Fixed the popup label that describes the raw position information in the ladder
+### Internal Changes
+  - Avoided shipping production configuration defaults that lead to trying to download a position file for the development sftp server.
+### Api
+  - C# API sample now uses synchronous calls.
+  
+## 2.9.0
+### User Visible Changes
+  - Improved Workspace management User Interface
+  - Added the ability to change grid background colors
+  - The Spark UI Window group now has a title in the Windows task bar
+  - Added sound alerts for trade events, see Launcher -> Settings -> Alerts
+  - Allowed composite algos that are attached to existing orders to identify fills that were already present prior to attachment
+  - Added import facilities for GMI position files 
+  - Added the ability for risk managers to enter manual fills
+  - Added "raw" P&L columns, that is columns that *do not* include spread legs in their accounting
+### Bug Fixes
+  - Fixed the settings action menu (Load/Save/Reset to Factory) 
+  - Fixed the method used to determine if a security is expired to take into account the start of day time
+### API Changes
+  - Fixed an issue in the Client SDK that could lead to occasional failures to connect to the spark server as well as excessive memory usage.
+  - Added the ability for algo orders to distinguish fills existing prior to launch
+### Internal Changes
+  - Changed how we packaged certain third-party components
+  - Added logging of entitlement status
+  - Tagged outgoing orders with sequence number of marketdata or FIX event that triggered them
+## 2.8.3
+### Bug Fixes
+  - Fixed a bug that could cause an OrderBook's Security column filter to be blank
+  - Fixed a bug that could cause a UI failure when clearing a filter selection on a filtering widget
+## 2.8.2
+### Bug Fixes
+  - Added proper display factors for SOM spreads
+  - Fixed a bug that could cause a UI failure when trying to change settings in a synthetic ladder
+## 2.8.1
+### Bug fixes
+  - Fixed an error in the UI grids filtering widget
+## 2.8.0
+### User Visible Changes
+  - Added ProRata and Scratch algos
+  - Ladder badge now grows/shrinks to fill the containing cell
+  - Attached algo parameters are now displayed in the update panel
+  - Fixed a bug where the update panel would show '-' values when only
+    1 order was selected
+  - Fixed a bug that cause cause a failure on startup if the user
+    loaded a workspace with a Ladder that had a dynamic order type
+    selected by default
+  - Increased width of login panel to better show login error messages
+  - Added optional 'Maker/Taker' pricing to Spreader algo
+  - Algo buttons in ladder can now be made to deactivate after launching an algo or remain 'sticky'
+### Internal changes
+  - Made it easier to generate simple UI's for new order types
+### API Changes
+  - Dynamic orders can now use QuantityMeasure parameter types
+  
+## 2.7.2
+### User Visible Changes
+  - Changed the login dialog to avoid leaking workspace names from other users. 
+  - Added new Splitter algo. From the manual: The splitter is useful
+    for pro-rata markets where you want to vary your exposure
+    independent of the order quantity that you want to fill.  The
+    splitter will complete when the number of fills reaches or exceeds
+    the order quantity but it will put exposed_qty total size on the
+    market. Splitter favors order size over queue position.
+### Internal Changes
+  - Made spark more resilient to lack of connectivity to the CME web site for downloading of templates. 
+  
+## 2.7.1
+### User Visible Changes
+  - Fixed some issues with the Cover algo, where in some circumstances
+    it would erroneously cancel launched hedges on completion.
+	
+## 2.7.0
+### User Visible Changes
+  - Allowed algos to process "in-flight" fills while shutting down
+  - Changed the cover algo to continue to hedge while shutting down
+### API Changes
+  - Changed the API so that algos do not fully terminate until all
+    their children are terminated. Algos that are in the process of
+    shutting down in response to a complete or cancel call will still
+    receive child updates, which they can use to calculate and report
+    an accurate fill count (during this shutdown stage algos cannot
+    create, cancel or update children). A new IAlgoServices method,
+    is_shutting_down(), can be used to determine if an algo is
+    shutting down.
+
+## 2.6.2
+### User Visible Changes
+  - Fixed an issue in the ladder where in some cases the mini order book could not be brought up from a badge
+  - Fixed a rare race condition that could lead to erroneous limit enforcement
+  - Fixed an issue with the margin limits where an error could occur if an account name with more than 12 chars was used  
+
+## 2.6.1
+### User Visible Changes
+  - Fixed an issue in the ladder where an error could occur when trying to change ladder settings for the first time
+  
+## 2.6.0
+### User Visible Changes
+  - In the ladder made last trade more distinctive when overlayed on the volumn column
+  - In the ladder, corrected display of volume tool tip 
+  - In the ladder, changed the consolidation of last trade to consider only the price ignoring aggressor changes
+  - Added an option for the Top Algo to delete itself if within N ticks from top of book
+  - Address a rare issue that could lead to an error report on UI exit
+  - Added margin risk limits
+  - Added the "Offset" algo. Offset prices a child algo at a parameterizable distance from the top of the book
+  - Avoided switching the current account and order type on open ladders when limits are changed 
+### Internal Changes
+  - Ensure that admin logins are always allowed to login, regardless of keycode status.
+  
+## 2.5.0
+### User Visible Changes
+  - Added loss limit risk check
+  - Made algos, synthetics and user names private so that multiple users can share a single system privately.
+  - Allowed the mini order book defaults for column widths to be changed from the mini order book
+  - Allowed the mini order book to shrink to the minimum size that will be needed to display the selected columns
+  - Improved accuracy of the directional arrow when displaying last trades in the volumn column
+## 2.4.0
+### User Visible Settings
+  - In the ladder, changed the last trade column to accumulate successive trades at the same price
+  - Fixed a bug in the order book where the right side ladder would display the top leve order's security rather then current row's
+  - Added OK, Cancel buttons to the security picker for ladder profiles or sounds
+  - Added ladder settings for the mini order book
+  - Added a safety check to guard against unintentional market crosses
+  - Improved the Queue Holder mode in the spreader:
+     - Added a Show Quantity, allowing the spreader to keep queue position of the trailing orders as Fills (of size Show Qty) happen
+     - Improved spreader performance when in Queue Holder mode
+### Internal changes
+  - Suppressed order callbacks for completed/canceled orders. This should eliminate some bogus error logs by spreader orders.
+  - Addressed a potential concurrency issues with service initialization.
+
+
+## 2.3.0
+### User Visible Changes
+  - Introduced multiple settings profiles for the ladder
+     - This allows multiple standard configuration for the ladder, optionally with security specific variations
+  - Made Cover order more independent from its hedging chidren:
+     - Cover continues to operate even if an hedging child is canceled
+	 - When a cover is canceled it will detach from any running hedging children, instead of canceling them
+  - Changed Lean, Join and Cover algos to hide themselves in the ladder once they have completed their work 
+  - Changed manual fills to appear in day PnL rather than in the SOD records
+  - Add buy/sell coloring to fill rows in fills window
+  - Streamlined the mini order book:
+    - Display of the mini order book popup is quicker
+    - Only exchange orders are displayed
+	- Update buttons are only displayed for orders that are under control of an algo with the update applying to the entire algo, not just the exchange order 
+    - We can now select multiple rows to attach, detach, update or cancel multiple orders in a batch
+    - A checkbox column has been added to make clearer which rows are selected
+### API Changes
+  - Enhanced the API to allow algos to implement custom cancel handling
+  - Allowed algos to control their visibility in the ladder through the API
+### Internal Changes
+  - Added system requirements to Spark documentation
+  - Implemented keycodes
+  - Temporarily rejected stop and stop limit orders, pending bug fixes
+  
 ## 2.2.0
 ### User Visible Changes
   - Made our orders easier to spot in MBO display
@@ -18,6 +194,9 @@ insert_anchor_links = "right"
   - Fixed a number of problems with filtering on the Fills form
   - On the Lean algo, OnToward and Away are now calculated with respect to the opposite inside market at time of the order launch
   - Iceberg Spreaders with queue holders are not erroneously cancelled after the first fill
+  - Added security symbol column to fills window
+  - Re-organized ladder settings dialog to make it clearer and easier to use
+  
 ## 2.1.4
 ### User Visible Changes
   - Fixed handling of cancel button in security picker
@@ -121,7 +300,7 @@ insert_anchor_links = "right"
   - Integrated stunnel into UI to make VPN setup unnecessary in unsecured environments.
 ## 1.5.7
 ### User Visible Changes
-  - New videos have been added to the manual describing the [Algo Studio](./bts_spark/Trading/index.md#algo-studio) and [Spreader](./bts_spark/Spreader/index.md)
+  - New videos have been added to the manual describing the [Algo Studio](./bts_spark/Trading/_index.md#algo-studio) and [Spreader](./bts_spark/Spreader/_index.md)
   - Fixed a bug that occasionally would cause windows to be position outside the visible screen on startup
   - Fixed a bug in the order book form that would occasionally cause the Recreate Order option to be unavailable
   - Added a confirmation step to Cancel All, Cancel Buys and Cancel Sells commands
@@ -245,6 +424,7 @@ insert_anchor_links = "right"
   - The zoom functionality can also be performed via hotkey and mouse wheel combinations
     - Zoom In = CTRL + Mouse wheel up
     - Zoom Out = CTRL + Mouse wheel down
+
     - Reset zoom = CTRL + Mouse wheel click or double click on the zoom slider
 ### Exchange simulator
   - Improved the exchange simulator to track real market data more closely
@@ -351,6 +531,7 @@ insert_anchor_links = "right"
  - All windows now contain a settings page where grid settings (font color, size, etc) are applied
  - These settings can be saved on a per-window basis or as a Default for newly-launched windows
 
+
 ## 1.3.1 Through 1.3.4
 
 ### Speed Enhancements

doc/user/content/system_requirements/_index.md

@@ -0,0 +1,55 @@
++++
+title = "System Requirements"
+weight = 4
+sort_by = "weight"
+insert_anchor_links = "right"
++++
+
+
+### Minimum Workstation
+* New XPS Tower
+* 8th Generation Intel® Core™ i7-8700 6-Core Processor (12M Cache, up to 4.6 GHz)
+* 16GB, 2666MHz, DDR4 up to 64GB
+* Windows 10 Professional 64-bit
+* NVIDIA® GeForce® GTX 1070 with 8GB GDDR5 Graphics Memory
+* 1 x 2.5" 256GB SATA Solid State Drive
+
+### Recommended Workstation
+* Similar or better than:
+* Dell Precision Tower 5820
+* Intel Xeon W-2145 3.7GHz, 4.5GHz Turbo, 8C, 11M Cache, HT, (140W) DDR4-2666
+* Windows 10 Professional 64-bit
+* NVIDIA® Quadro® P1000, 4GB, 4 mDP
+* 16GB (4x4GB) 2133MHz DDR4 RDIMM ECC
+* 2 x 2.5" 256GB SATA Solid State Drive running RAID1
+
+
+### BTS Recommended Server Specifications
+* Dell R640
+* 2x Intel Xeon Gold 6148 2.40GHz 20-Core Processors. For better performance BTS recommends Intel® Xeon® Platinum 8268 2.9G, 24 Core CPU
+* 192GB RAM 2666MHz DDR4
+* 3x 480GB SSD RAID 5 HBA Minicard
+* iDRAC 9 Enterprise
+* Embedded Broadcom NIC
+* Solarflare SFN8522-R2
+* Redundant Power Supply
+
+### BTS Minimum Server Specifications
+* Dell R620
+* Chassis with up to 8, 2.5” Hard Drives, up to 2 PCIe Slots (With Optional Riser)
+* 2 x Intel® E5-2670 (16 total cores/ 32 total threads)
+* 64GB total memory
+* RAID 1 for H330/H730/H730P
+* PERC H730 RAID Controller, 1GB NV Cache
+* 3 x 300GB 10K RPM SATA 6Gbps 2.5in Hot-plug Hard Drive (RAID 5)
+* iDRAC8 Enterprise, integrated Dell Remote Access Controller, Enterprise (varies by hosting company)
+* Solarflare Ultra SFN7122F Dual-Port 10GbE (10 GB connectivity requirements, copper vs optical, varies by hosting company).
+* Dual, Hot-plug, Redundant Power Supply (1+1), 750W
+* Performance BIOS Setting
+* ReadyRails Sliding Rails Without Cable Management Arm (varies by hosting company)
+
+### Edge Tablet Requirements
+* Similar or better than:
+* Microsoft Surface Pro 4 Or Motion R12
+* Intel i7
+* 8 GB DDR4 RAM

doc/user/deploy_to_web.sh

@@ -1,7 +1,6 @@
 #/bin/bash
 #python -m mkdocs build -d site
 
-cp -r ../../src/sdk/doc/* ./content/bts_spark_sdk/Server/
 ./run_zola.sh build
 
 scp -r ./public bts@bluetradesys.com:/home/bts/doc/
@@ -14,7 +13,3 @@ sudo mv ./public/* /var/www/documentation/
 EOF
 
 rm -r public
-cd ./content/bts_spark_sdk/server/
-find  . -not -name '_index.md' -delete
-cd ../..
-

src/client/spark/Admin/AdminModel.cs

@@ -7,12 +7,12 @@ using System.Linq;
 using System.Reactive.Linq;
 using System.Reactive.Subjects;
 using bts.api.core;
+using mbts.ui.shell;
 
 namespace mbts.spark {
    [Export]
    class AdminModel : IDisposable {
-      readonly string _user_name;
-      public string user_name => _user_name;
+      public readonly UserTuple user;
       
       readonly BehaviorSubject<IReadOnlyDictionary<uint, string>>
          _accounts_subject = new BehaviorSubject<IReadOnlyDictionary<uint, string>>(new Dictionary<uint, string>()),
@@ -24,14 +24,14 @@ namespace mbts.spark {
       IDisposable _dispose;      
 
       [ImportingConstructor]
-      AdminModel(AdminService service, [Import("username")]string user_name) {
-         _user_name = user_name;
+      AdminModel(AdminService service, [Import]UserTuple user) {
+         this.user = user;
          _dispose = service.subscribei_admin_data().Select(update => {
-            _wrapper_subject.OnNext(new AdminModelWrapper(update.all.TryFirst(), _user_name));
+            _wrapper_subject.OnNext(new AdminModelWrapper(update.all.TryFirst(), user.name));
             IEnumerable<BTSUserImmutable> active_users =
                from admin_data in update.all
                from bts_user in admin_data.Users
-               where bts_user.Name == user_name && bts_user.HasUserData && bts_user.UserData.HasAccountPermissions
+               where bts_user.Name == user.name && bts_user.HasUserData && bts_user.UserData.HasAccountPermissions
                select bts_user;
 
             IEnumerable<BTSAccountImmutable> active_accounts =
@@ -62,14 +62,6 @@ namespace mbts.spark {
       public IObservable<IReadOnlyList<AccountTuple>> on_account_tuples => on_accounts.Select(d => d.Select(kv => new AccountTuple(kv.Key, kv.Value)).ToList());
       public IObservable<AdminModelWrapper> on_admin_data => _wrapper_subject.AsObservable();
 
-      public UserTuple? get_current_user() {
-         foreach (var kv in _user_map) {
-            // just for good measure, there should never be > 1 element in _user_map, and it should always match _user_name
-            if (kv.Value == _user_name)
-               return new UserTuple(kv.Key, kv.Value);
-         }
-         return null;
-      }
       public AccountTuple? get_default_account() {
          foreach (var kv in _account_map) {
             return new AccountTuple(kv.Key, kv.Value);

src/client/spark/App.xaml.cs

@@ -70,7 +70,6 @@ namespace mbts.ui.shell
       {
          Log.Gen.info("Application.OnExit");
          if (_runtime != null) _runtime.Dispose();
-         utils.BTSNativeMethods.finit_spark_lib();
          base.OnExit(e);
          Environment.Exit(0);
       }

src/client/spark/Daemons/AboutDaemon.cs

@@ -3,6 +3,7 @@ using mbts;
 using mbts.config;
 using mbts.spark;
 using mbts.ui;
+using mbts.ui.shell;
 using System;
 using System.Collections.Generic;
 using System.ComponentModel.Composition;
@@ -22,7 +23,7 @@ namespace bts.ui {
       IDisposable _dispose;
 
       [ImportingConstructor]
-      public AboutDaemon(IBus bus, [Import("username")]string username) {
+      public AboutDaemon(IBus bus, [Import(LoginContainer.Exports.UserName)]string username) {
          _user = username;
          _bus = bus;
          _dispose = bus.subscribe(SparkTags.About).OnDispatcher().Subscribe(_ => show_about());

src/client/spark/Daemons/ErrorReporter.cs

@@ -10,6 +10,7 @@ using System.Reactive.Linq;
 using System.Windows.Threading;
 using System.Windows;
 using System.Threading.Tasks;
+using mbts.ui.shell;
 
 namespace bts.spark
 {
@@ -20,7 +21,7 @@ namespace bts.spark
       IDisposable _dispose;
 
       [ImportingConstructor]
-      public ErrorReporter(ErrorReportService svc, IBus bus, [Import("username")] string username) {
+      public ErrorReporter(ErrorReportService svc, IBus bus, [Import(LoginContainer.Exports.UserName)] string username) {
          _svc = svc;
          _username = username;
          _dispose = bus.subscribe(SparkTags.Support).OnDispatcher().Subscribe(msg => show_support_window(msg, "Report a problem"));
@@ -82,7 +83,6 @@ namespace bts.spark
          }
       }
 
-      //public static async Task<Result<T>>
       public static async Task<(T value, bool success)> safe_execute<T>(this ErrorReporter error_reporter, Func<Task<Result<T>>> execute, Func<T, bool> get_success, Func<T, string> get_error_msg, string desc) {
          try {
             var result = await execute();
@@ -101,5 +101,31 @@ namespace bts.spark
          void _report_error(string msg) =>
             error_reporter.report_error($"Error {desc}: {msg}", AlgoStudioWindow.NAME, MessageBoxImage.Warning);
       }
+
+      public static async Task<TResult> safe_execute<T, TResult>(
+         this ErrorReporter error_reporter,
+         Func<Task<Result<T>>> execute,
+         Func<T, bool> get_success,
+         Func<T, string> get_error_msg,
+         Func<T, bool, TResult> result_selector,
+         string desc) {
+         //
+         try {
+            var result = await execute();
+            if (!result.success) {
+               _report_error(result.error_message);
+            } else if (!get_success(result.value)) {
+               _report_error(get_error_msg(result.value));
+            } else {
+               return result_selector(result.value, true);
+            }
+         } catch (Exception ex) {
+            _report_error(ex.ToString());
+         }
+         return result_selector(default, false);
+         //
+         void _report_error(string msg) =>
+            error_reporter.report_error($"Error {desc}: {msg}", AlgoStudioWindow.NAME, MessageBoxImage.Warning);
+      }
    }
 }

src/client/spark/Daemons/GlobalAlertsDaemon.cs

@@ -0,0 +1,68 @@
+using bts.api;
+using bts.shell;
+using mbts;
+using mbts.persist;
+using mbts.spark;
+using mbts.ui;
+using mbts.ui.spark;
+using mbts.ui.utilities;
+using System;
+using System.ComponentModel.Composition;
+using System.Linq;
+using System.Reactive.Disposables;
+using System.Reactive.Linq;
+using System.Windows;
+using Disposable = mbts.Disposable;
+
+namespace bts {
+   [Export(typeof(IShellDaemon))]
+   class GlobalAlertsDaemon : IShellDaemon, IDisposable {
+      const string
+         // used for logging/diagnostic purposes
+         _window_name = "Global Alerts Dialog",
+         // actual window title
+         _window_title = "Alerts";
+
+      readonly ThreadedWindowLauncher _launcher;
+      readonly UserSettingsHub _hub;
+      readonly IBus _bus;
+      readonly INotificationService _notification_service;
+      IDisposable _dispose;
+
+      [ImportingConstructor]
+      public GlobalAlertsDaemon(IBus bus, UserSettingsHub hub, INotificationService notification_service) {
+         _bus = bus;
+         _hub = hub;
+         _notification_service = notification_service;
+         _launcher = new ThreadedWindowLauncher(_window_name);
+         _dispose = Disposable.Create(
+            bus.subscribe(SparkTags.ShowGlobalAlertsTag)
+            .Subscribe(_ => _launcher.show(_view_factory)),
+            _hub.subscribe_default_settings()
+            .SubscribeEach(s => new CompositeDisposable(
+               s.alerts.trade_alerts.Where(t => t.is_enabled).Select(
+                  a => _notification_service.link_to_trades(
+                     a.predicate.security_criteria, a.predicate.create(), a.sound)))));
+      }
+
+      Window _view_factory() {
+         var vm = new GlobalAlertsVM();
+         vm.load_from(_hub.current.alerts);
+         vm.request_commit += commit;
+         var sec_sub = _bus.subscribe(SparkTags.SecuritiesTag).OnDispatcher().Subscribe(m => vm.security_map = m);
+         var win = new GlobalAlertsDialog {
+            Title = "Alerts",
+            DataContext = vm
+         };
+         win.Closed += (s, e) => Disposable.dispose(ref sec_sub);
+         return win;
+         void commit() {
+            var s = _hub.current.with(alerts: vm.create());
+            _hub.save_default(s).ignore();
+         }
+      }
+
+      public void Dispose() =>
+         Disposable.dispose(ref _dispose);
+   }
+}

src/client/spark/Daemons/MDDaemon.cs

@@ -15,6 +15,7 @@ using System.Collections.Concurrent;
 using System.Threading;
 using bts.api.user;
 using bts.md;
+using mbts.ui.shell;
 
 namespace bts {
    [Export(typeof(IInitializable))]
@@ -27,8 +28,8 @@ namespace bts {
       static uint get_naggle() => mbts.config.Configuration.get<md.RelayOptions>().naggle_ms;
 
       [ImportingConstructor]
-      public MDDaemon(Lazy<IBus> bus, Lazy<AuthTokenImmutable> token, Lazy<SyntheticSecurityService> ss) : 
-         base(get_naggle(), MDSourceOptions.DeferInit) {
+      public MDDaemon(Lazy<IBus> bus, Lazy<AuthTokenImmutable> token, Lazy<SyntheticSecurityService> ss, [Import(LoginContainer.Exports.UserID)]uint user_id) : 
+         base(get_naggle(), MDSourceOptions.DeferInit, user_id) {
          _bus = bus;
          _token = token;
          _ss = ss;         

src/client/spark/Daemons/OrderTicketDaemon.cs

@@ -11,6 +11,7 @@ using System.Collections.Generic;
 using System.ComponentModel.Composition;
 using System.Reactive.Linq;
 using System.Windows;
+using LadderSettings = mbts.spark.LadderSettings;
 
 namespace bts.shell {
    [Export(typeof(IShellDaemon))]
@@ -48,14 +49,14 @@ namespace bts.shell {
       void _show_order_ticket(SecurityMD smd) =>
          _show_order_window(new OrderTicket {
             DataContext = new NewOrderTicketVM(_model, smd,
-               Observable.Return(_model.factory.default_ladder_settings(smd.security)))
+               Observable.Return(LadderSettings.Default))
          });
 
       void _show_order_ticket((OrderDefinitionImmutable def, double price, uint size) ops) {
          if (_md_map.TryGetValue(ops.def.SecurityKey, out SecurityMD smd))
             _show_order_window(new OrderTicket {
                DataContext = new NewOrderTicketVM(_model, smd, ops.def, ops.price, ops.size,
-                  Observable.Return(_model.factory.default_ladder_settings(smd.security).calculator_buttons))
+                  Observable.Return(LadderSettings.Default.calculator_buttons))
             });
       }
 
@@ -66,7 +67,7 @@ namespace bts.shell {
             _show_order_window(new OrderModificationDialog {
                DataContext = new ExistingOrderTicketVM(_model,
                   Observable.Return((md,ori.order)),
-                  Observable.Return(_model.factory.default_ladder_settings(ori.sec.Value).calculator_buttons)
+                  Observable.Return(LadderSettings.Default.calculator_buttons)
                )
             });
          }

src/client/spark/Daemons/SecurityPickerDaemon.cs

@@ -69,11 +69,11 @@ namespace bts {
          cpv.Width = double.NaN;
          cpv.Height = double.NaN;
 
-         vm.ok_action = () => {
+         vm.ok_action += () => {
             window.Close();
             message.complete(select_result(vm)).execute(_bus);
          };
-         vm.cancel_action = () => window.Close();
+         vm.cancel_action += () => window.Close();
          window.move_to_mouse();
          window.Show();
       }

src/client/spark/Daemons/ShellLatencyDaemon.cs

@@ -3,6 +3,7 @@ using bts.metrics;
 using mbts;
 using mbts.config;
 using mbts.ui;
+using mbts.ui.shell;
 using System;
 using System.Collections.Generic;
 using System.ComponentModel.Composition;
@@ -23,7 +24,7 @@ namespace bts.perf {
       Ping _pinger = new Ping();
 
       [ImportingConstructor]
-      public ShellLatencyDaemon(ShellLatencyService service, [Import("username")] string user) {
+      public ShellLatencyDaemon(ShellLatencyService service, [Import(LoginContainer.Exports.UserName)] string user) {
          _service = service;
          _version = Configuration.get<bts.config.System>().version;
          _username = user;

src/client/spark/Daemons/ShellServices.cs

@@ -2,6 +2,7 @@
 using bts.api.core;
 using bts.api.md.auxiliary;
 using bts.api.orderman;
+using bts.api.orderman.algo;
 using bts.api.persistence;
 using bts.api.position;
 using bts.api.synthetic;
@@ -45,41 +46,11 @@ namespace Spark {
 
       [Export]
       public MarketDataRelay md_replay => context.locate<MarketDataRelay>();
-      //[Export]
-      //public AlgoService algo_service => context.locate<AlgoService>();
 
-      AlgoServiceWrapper _algo_service_wrapper;
       [Export]
-      public AlgoServiceWrapper algo_service_wrapper => _algo_service_wrapper ?? (_algo_service_wrapper = new AlgoServiceWrapper(context));
+      public AlgoDefinitionService algo_definition_service => context.locate<AlgoDefinitionService>();
 
       [Export]
       public MBOService mbo_service => context.locate<MBOService>();
    }
-
-   class AlgoServiceWrapper {
-      public enum Mode {
-         None,
-         Hierarchical,
-         Flat
-      }
-
-      public AlgoServiceWrapper(ServiceContext context) {
-         var flat_model_options = mbts.config.Configuration.get<bts.config.AlgoStudioFlatDefinitionModelOptions>();
-         if (flat_model_options.enabled) {
-            flat = context.locate<bts.api.orderman.algo.AlgoDefinitionService>();
-         } else {
-            hierarhical = context.locate<AlgoService>();
-         }
-      }
-
-      public AlgoService hierarhical { get; }
-      public bts.api.orderman.algo.AlgoDefinitionService flat { get; }
-      public Mode mode {
-         get {
-            if (hierarhical != null) return Mode.Hierarchical;
-            if (flat != null) return Mode.Flat;
-            return Mode.None;
-         }
-      }
-   }
 }

src/client/spark/Images/Icons.cs

@@ -24,6 +24,7 @@ namespace mbts.ui {
          AddFileThinGeometryKey = nameof(AddFileThinGeometryKey),
          AttachAlgosKey = nameof(AttachAlgosKey),
          CheckMarkGeometryKey = nameof(CheckMarkGeometryKey),
+         CopyWFGeometryKey = nameof(CopyWFGeometryKey),
          DataEditGeometryKey = nameof(DataEditGeometryKey),
          DetachAlgosKey = nameof(DetachAlgosKey),
          DiskGeometryKey = nameof(DiskGeometryKey),
@@ -39,14 +40,18 @@ namespace mbts.ui {
          EditDocumentAltGeometryKey = nameof(EditDocumentAltGeometryKey),
          EditDocumentGeometryKey = nameof(EditDocumentGeometryKey),
          GearGeometryKey = nameof(GearGeometryKey),
+         HornGeometryKey = nameof(HornGeometryKey),
+         KeyGeometryKey = nameof(KeyGeometryKey),
          LetterAKey = nameof(LetterAKey),
          LetterDKey = nameof(LetterDKey),
          OrdersGeometryKey = nameof(OrdersGeometryKey),
+         PauseGeometryKey = nameof(PauseGeometryKey),
          PaymentGeometryKey = nameof(PaymentGeometryKey),
          PencilGeometryKey = nameof(PencilGeometryKey),
          PlayGeometryKey = nameof(PlayGeometryKey),
          ProhibitedGeometryKey = nameof(ProhibitedGeometryKey),
          RubberStampGeometryKey = nameof(RubberStampGeometryKey),
+         SpeakerGeometryKey = nameof(SpeakerGeometryKey),
          StarGeometryKey = nameof(StarGeometryKey),
          ToolsGeometryKey = nameof(ToolsGeometryKey),
          TrashGeometryKey = nameof(TrashGeometryKey),
@@ -147,7 +152,8 @@ namespace mbts.ui {
       public static ImageSource ModifyOrder { get { return load_resource_and_freeze("ModifyOrder"); } }
       public static ImageSource CheckMark => create_icon(CheckMarkGeometryKey);
       public static ImageSource Clock { get { return load_resource_and_freeze("Clock"); } }
-      public static ImageSource DataEdit => create_icon(DataEditGeometryKey, Brushes.White, new Pen(Brushes.Black, 1).frozen());
+      public static ImageSource CopyWF => create_icon(CopyWFGeometryKey);
+      public static ImageSource DataEdit => create_icon(DataEditGeometryKey);
       public static ImageSource Defrag { get { return load_resource_and_freeze("Defrag"); } }
       public static ImageSource DetachAlgos => create_icon_and_rotate(DetachAlgosKey, Brushes.Red);
       public static ImageSource Disk => create_icon(DiskGeometryKey);
@@ -166,14 +172,19 @@ namespace mbts.ui {
       public static ImageSource FilterActive { get { return load_resource_and_freeze("FilterActive"); } }
       public static ImageSource FilterError { get { return load_resource_and_freeze("FilterError"); } }
       public static ImageSource Gear => create_icon(GearGeometryKey);
+      public static ImageSource Horn => create_icon(HornGeometryKey);
       public static ImageSource Import => load_resource_and_freeze("Import");
+      public static ImageSource Key => create_icon(KeyGeometryKey);
       public static ImageSource Knight { get { return load_resource_and_freeze("Knight"); } }
+      public static ImageSource Pause => create_icon(PauseGeometryKey);
       public static ImageSource Payment => create_icon(PaymentGeometryKey);
       public static ImageSource Pencil => create_icon(PencilGeometryKey);
+      public static ImageSource Play => create_icon(PlayGeometryKey);
       public static ImageSource Prohibited => create_icon(ProhibitedGeometryKey);
       public static ImageSource RubberStamp => create_icon(RubberStampGeometryKey);
       public static ImageSource RedoCircular => create_icon(UndoCircularGeometryKey, Brushes.Black, null, new ScaleTransform(-1, 1));
       public static ImageSource Spawn { get { return load_resource_and_freeze("Spawn"); } }
+      public static ImageSource Speaker => create_icon(SpeakerGeometryKey);
       public static ImageSource Star => create_icon(StarGeometryKey);
       public static ImageSource Target { get { return load_resource_and_freeze("Target"); } }
       public static ImageSource Tetris { get { return load_resource_and_freeze("Tetris"); } }

src/client/spark/Images/Vector/Icons.xaml

@@ -1,7 +1,7 @@
 <ResourceDictionary
   xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
   xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-  xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" 
+  xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
   xmlns:mbts="clr-namespace:mbts.ui"
   xmlns:sys="clr-namespace:System;assembly=mscorlib"
 >
@@ -18,9 +18,7 @@
     Ttile: Add free icon
     Credit: Icon made by Gregor Cresnar from www.flaticon.com-->
   <sys:String x:Key="{x:Static mbts:Icons.AddBoxesGeometryKey}">
-    M393,480.3c0-5-4.1-9.1-9.1-9.1H18.2V105.5c0-5-4.1-9.1-9.1-9.1S0,100.5,0,105.5v374.8c0,5,4.1,9.1,9.1,9.1h374.8    C388.9,489.4,393,485.3,393,480.3z
-    M373.9,187.5H302v-71.9c0-5-4.1-9.1-9.1-9.1s-9.1,4.1-9.1,9.1v71.9h-71.9c-5,0-9.1,4.1-9.1,9.1s4.1,9.1,9.1,9.1h71.9v71.9    c0,5,4.1,9.1,9.1,9.1s9.1-4.1,9.1-9.1v-71.9h71.9c5,0,9.1-4.1,9.1-9.1C382.9,191.5,378.9,187.5,373.9,187.5z
-    M105.5,393h374.8c5,0,9.1-4.1,9.1-9.1V9.1c0-5-4.1-9.1-9.1-9.1H105.5c-5,0-9.1,4.1-9.1,9.1v374.8    C96.4,388.9,100.5,393,105.5,393z M114.5,18.2h356.7v356.7H114.5V18.2z
+    M 87.5 10 C 80.313542 10 74.400391 15.913151 74.400391 23.099609 V 397.90039 C 74.400391 405.08685 80.313541 411 87.5 411 h 374.80078 c 7.18646 0 13.09961 -5.91315 13.09961 -13.09961 V 23.099609 C 475.40039 15.913151 469.48724 10 462.30078 10 Z m 13 26.199219 H 449.19922 V 384.90039 H 100.5 Z M 21.099609 76.400391 C 13.912943 76.400391 8 82.313333 8 89.5 v 374.80078 c 0 7.18667 5.912943 13.09961 13.099609 13.09961 H 395.90039 c 7.18667 0 13.09961 -5.91294 13.09961 -13.09961 0 -7.18667 -5.91294 -13.10156 -13.09961 -13.10156 H 34.199219 V 89.5 c 0 -7.186667 -5.912943 -13.099609 -13.09961 -13.099609 z M 274.90039 116.5 c -7.18667 0 -13.09961 5.91294 -13.09961 13.09961 V 197.5 h -67.90039 c -7.18667 0 -13.09961 5.91294 -13.09961 13.09961 0 7.18667 5.91294 13.09961 13.09961 13.09961 h 67.90039 v 67.90039 c 0 7.18667 5.91294 13.09961 13.09961 13.09961 7.18667 0 13.09961 -5.91294 13.09961 -13.09961 v -67.90039 h 67.90039 c 7.18667 0 13.09961 -5.91294 13.09961 -13.09961 v -0.0391 -0.0391 C 368.85982 203.37217 363.03372 197.5 355.90039 197.5 H 288 V 129.59961 C 288 122.41294 282.08706 116.5 274.90039 116.5 Z
   </sys:String>
 
   <!--File (the icon is free to use if we include this information in our credit section)
@@ -48,6 +46,10 @@
     </sys:String>
   </x:Array>
 
+  <sys:String x:Key="{x:Static mbts:Icons.CopyWFGeometryKey}">
+    M14.733902,12.084991L9.751783,17.388992 12.982842,17.436005C13.569886,17.462997 14.5229,17.350998 14.876848,17.005005 14.954852,16.929993 15.031879,16.824005 15.02486,16.593002 14.986895,15.457993 14.838883,13.438004 14.733902,12.084991z M22.507753,11.134453C22.480678,11.134323,22.467085,11.135494,22.469961,11.136993L20.64694,11.145004 16.291904,11.192993C16.388891,12.405991 16.596901,15.100998 16.647928,16.539001 16.668924,17.177994 16.448888,17.742004 16.007904,18.168991 15.210897,18.947998 13.893864,19.065002 13.179865,19.065002L9.2818066,19.005005 9.3258129,25.522003 9.3728109,25.528 9.3278271,25.882996 9.3317944,26.395996 9.3107983,26.397995C9.3167797,26.789993,9.3378369,27.552994,9.3958212,29.065994L9.4068075,29.393005C9.4207855,29.819992 9.5648295,29.994995 9.6707884,30.089005 9.9807898,30.365997 10.539817,30.390991 10.717799,30.369003L10.717799,30.375C10.88284,30.354996 11.280855,30.356003 12.823844,30.365997 13.867863,30.371002 15.206869,30.376999 16.594886,30.376999 20.757965,30.376999 23.270998,30.354996 23.862007,30.311005 24.454971,30.268005 24.661029,29.154999 24.690021,28.729996 24.690021,28.729996 24.677997,27.876999 24.661029,26.582993 24.612016,22.671005 24.51198,14.697998 24.472002,12.802002 24.461013,12.302994 24.316969,11.929993 24.034008,11.662003 23.547475,11.200003 22.697284,11.13536 22.507753,11.134453z M8.8867823,2.8410034L2.5417312,10.296997 6.4037791,10.356995C6.8917614,10.390991 8.3258005,10.341003 8.9567896,9.7299957 9.1738335,9.5189972 9.2667919,9.2659912 9.2558046,8.9089966 9.2067934,7.3889923 9.0258213,4.7480011 8.8867823,2.8410034z M10.424826,1.6239929C10.551842,3.302002 10.816799,6.951004 10.876797,8.8560028 10.903836,9.6750031 10.636804,10.360992 10.083818,10.897995 9.0667769,11.882004 7.3527657,11.987991 6.6627546,11.987991 6.4657918,11.987991 6.3367616,11.979004 6.3177796,11.977005L1.6477377,11.905991C1.6387044,14.278992 1.6236895,20.283997 1.6496909,22.358994 1.651705,22.569992 1.6437093,22.780991 1.6366904,22.992004 1.6117265,23.593994 1.5926833,24.112991 1.8537338,24.386002 2.0716933,24.612991 2.6497034,24.886002 4.1457549,24.886002 6.0127832,24.886002 7.0867711,24.876999 7.6967641,24.867004L7.6457993,17.259995 14.853899,9.5849915 16.681924,9.5650024 16.681924,9.5429993 19.454908,9.5289917 19.406934,2.6210022C19.323925,2.3549957,18.960945,1.6239929,17.387928,1.6239929z M9.1738335,0L17.387928,0C19.94692,0,20.874971,1.5299988,21.022983,2.4329987L21.077976,9.5209961 22.446951,9.5139923C22.43395,9.5130005 24.031017,9.4250031 25.148035,10.481995 25.753999,11.054001 26.071996,11.822998 26.092992,12.766998 26.142006,15.065994 26.281044,26.268997 26.307047,28.412003L26.311014,28.764999C26.279029,29.817993 25.750032,31.802002 23.979013,31.931 23.342958,31.977005 20.887972,32 16.683878,32 13.798893,32 11.107818,31.988998 10.808803,31.987991 10.789821,31.990997 9.5147806,32.112 8.6008288,31.309006 8.0858074,30.854996 7.8107797,30.229004 7.7838017,29.444992L7.7728153,29.126999C7.721789,27.759995 7.6978022,26.970993 7.6898061,26.490005 7.0547882,26.5 5.9867817,26.509003 4.1457549,26.509003 2.4377257,26.509003 1.3387128,26.192001 0.68367504,25.509003 -0.055286743,24.742004 -0.017322397,23.742004 0.012707477,22.938004 0.020702986,22.744003 0.028698692,22.559998 0.026684528,22.378998 -0.00029337304,20.240997 0.016674615,13.856995 0.026684528,11.212997L0.026684528,10.867004 0.14167619,10.610992 8.7147823,0.54100037 8.7088009,0.45899963 8.8018194,0.43800354z
+  </sys:String>
+
   <sys:String x:Key="{x:Static mbts:Icons.DocumentAddGeometryKey}">
     M10.830011,12.05L13.334007,12.05 13.334007,16.535997 17.819998,16.535997 17.819998,19.03902 13.334007,19.03902 13.334007,23.525016 10.830988,23.525016 10.830988,19.03902 6.3460046,19.03902 6.3449975,16.53499 10.830988,16.535997z M2.2799975,2.4149805L2.2799975,29.580015 22.121998,29.580015 22.121998,8.500008 15.83599,8.500008 15.83599,2.4149805z M0,0L15.83599,0 17.125998,0 22.681996,5.439977 24.407,7.125007 24.407,32.000001 0,32.000001z
   </sys:String>
@@ -112,7 +114,7 @@
   </sys:String>
 
   <sys:String x:Key="{x:Static mbts:Icons.DataEditGeometryKey}">
-    M17.997977,17.396268C18.197928,17.396268,18.297904,17.496276,18.497975,17.596284L19.497972,18.295283C19.99797,18.595292,20.697919,19.195308,21.197917,19.495299L22.196937,20.195323C22.696935,20.495315,22.596959,20.995322,22.096961,21.195338L20.997966,21.695346C20.497968,21.89434,19.597947,22.294355,19.097949,22.494355L17.997977,22.994363C17.497979,23.194362,17.097957,22.894355,17.197932,22.394347L17.297908,21.195338C17.398005,20.595323,17.497979,19.695315,17.497979,19.195308L17.597955,17.995277C17.497979,17.695283,17.69793,17.396268,17.997977,17.396268z M1.799981,13.597213L19.697923,13.597213 17.997977,15.896244C17.797906,16.096259 17.69793,16.396253 17.69793,16.69626 17.197932,16.796268 16.79791,17.296275 16.697934,17.895284L16.597959,19.195308 1.799981,19.195308C0.79998477,19.195308,0,18.395291,0,17.396268L0,15.396237C0,14.396221,0.79998477,13.597213,1.799981,13.597213z M1.799981,6.7981106L21.796914,6.7981106C22.696935,6.7981106,23.49698,7.498118,23.596955,8.3981257L20.697919,12.397197 1.799981,12.397197C0.79998477,12.397197,0,11.597181,0,10.597165L0,8.5981418C0,7.598126,0.79998477,6.7981106,1.799981,6.7981106z M27.796891,4.3990708C27.996963,4.3990708,28.096938,4.3990708,28.296889,4.5990711L31.695924,7.0981179C31.995851,7.3981105,32.095948,7.7981258,31.895875,8.0981341L23.296908,19.795308C23.096957,20.095315,22.596959,20.195323,22.196937,19.895314L18.797902,17.396268C18.497975,17.096274,18.398002,16.69626,18.597951,16.396253L27.196918,4.6990786C27.396869,4.4990784,27.59694,4.3990708,27.796891,4.3990708z M1.799981,0L21.796914,0C22.79691,4.9549271E-08,23.596955,0.8000156,23.596955,1.800031L23.596955,3.7990554C23.596955,4.7990709,22.79691,5.5990864,21.796914,5.5990864L1.799981,5.5990864C0.79998477,5.4990941,0,4.6990786,0,3.6990629L0,1.7000236C0,0.8000156,0.79998477,4.9549271E-08,1.799981,0z
+    M 22.589844 14.470703 H 0.82421875 C 0.36896661 14.470586 -1.1747368e-4 14.83967 0 15.294922 v 4.669922 c -1.1747368e-4 0.455252 0.36896661 0.824336 0.82421875 0.824218 H 16.940231 l 0.425003 -1.09375 0.554688 -0.554687 H 1.6484375 V 16.119141 H 20.941406 Z M 27.462891 9.5976562 V 8.0742188 A 0.8240064 0.8240064 0 0 0 26.638672 7.25 H 0.82421875 A 0.8240064 0.8240064 0 0 0 0 8.0742188 v 4.6699222 a 0.8240064 0.8240064 0 0 0 0.82421875 0.824218 H 23.492188 l 1.648437 -1.648437 H 1.6484375 V 8.8984375 H 25.814453 V 11.246094 Z M 0.82421878 2.736881e-8 A 0.8240064 0.8240064 0 0 0 2.7433281e-8 0.82421879 V 5.4941406 A 0.8240064 0.8240064 0 0 0 0.82421878 6.3183594 H 26.638672 A 0.8240064 0.8240064 0 0 0 27.46289 5.4941406 V 0.82421879 A 0.8240064 0.8240064 0 0 0 26.638672 2.736881e-8 Z M 1.6484375 1.6484375 H 25.814453 V 4.6699219 H 1.6484375 Z M 31.628051 7.2558423 19.165575 19.718635 23.70324 24.256618 36.166032 11.793823 Z m -0.0013 3.5965607 0.941422 0.94142 -8.866233 8.866232 -0.94142 -0.94142 z m -13.240122 9.708458 -1.636234 6.110706 6.109329 -1.637606 z
   </sys:String>
   <sys:String x:Key="{x:Static mbts:Icons.DiskGeometryKey}">
     M403.213,20H0v472h512V128.787L403.213,20z M131,50h180v100h10h20h10V50h30v130H131V50z M381,462H131V315
@@ -270,10 +272,22 @@
     M16.000015,9.6000061C12.500012,9.6000061 9.5999844,12.5 9.5999844,16 9.5999844,19.5 12.500012,22.399994 16.000015,22.399994 19.500019,22.399994 22.400015,19.5 22.400015,16 22.400015,12.5 19.500019,9.6000061 16.000015,9.6000061z M14.199995,0L17.800005,0C18.199999,0,18.599993,0.29998779,18.599993,0.79998779L18.599993,4.7999878C19.900013,5.1000061,21.000019,5.6000061,22.099997,6.2999878L25.000023,3.3999939C25.099999,3.2999878 25.300011,3.1999817 25.500025,3.1999817 25.700007,3.1999817 25.900019,3.2999878 26.000025,3.3999939L28.600033,6C28.900021,6.2999878,28.900021,6.7999878,28.600033,7.1000061L25.700007,10C26.400019,11.100006,26.900019,12.299988,27.200007,13.5L31.20001,13.5C31.600037,13.5,31.999998,13.799988,31.999998,14.299988L31.999998,17.899994C31.999998,18.299988,31.700012,18.699982,31.20001,18.699982L27.200007,18.699982C26.900019,20,26.400019,21.100006,25.700007,22.199982L28.600033,25.100006C28.700009,25.199982 28.799984,25.399994 28.799984,25.600006 28.799984,25.799988 28.700009,26 28.600033,26.100006L26.000025,28.600006C25.900019,28.699982 25.700007,28.799988 25.500025,28.799988 25.300011,28.799988 25.099999,28.699982 25.000023,28.600006L22.099997,25.699982C21.000019,26.399994,19.800007,26.899994,18.599993,27.199982L18.599993,31.199982C18.599993,31.600006,18.300005,32,17.800005,32L14.199995,32C13.8,32,13.400006,31.699982,13.400006,31.199982L13.400006,27.199982C12.099987,26.899994,11.000011,26.399994,9.9000027,25.699982L7.0000064,28.600006C6.9000003,28.699982 6.6999881,28.799988 6.5000059,28.799988 6.2999937,28.799988 6.099981,28.699982 6.0000054,28.600006L3.3999967,26C3.0999784,25.699982,3.0999784,25.199982,3.3999967,24.899994L6.2999937,22C5.5999805,20.899994,5.0999801,19.699982,4.7999923,18.5L0.79998828,18.5C0.39999409,18.5,-1.933513E-07,18.199982,0,17.699982L0,14.100006C-1.933513E-07,13.699982,0.2999879,13.299988,0.79998828,13.299988L4.7999923,13.299988C5.0999801,12,5.5999805,10.899994,6.2999937,9.7999878L3.3999967,7C3.2999908,6.8999939 3.1999845,6.6999817 3.1999845,6.5 3.1999845,6.2999878 3.2999908,6.1000061 3.3999967,6L6.0000054,3.3999939C6.099981,3.2999878 6.2999937,3.1999817 6.5000059,3.1999817 6.6999881,3.1999817 6.9000003,3.2999878 7.0000064,3.3999939L9.9000027,6.2999878C11.000011,5.6000061,12.199993,5.1000061,13.400006,4.7999878L13.400006,0.79998779C13.400006,0.29998779,13.8,0,14.199995,0z
   </sys:String>
 
+  <sys:String x:Key="{x:Static mbts:Icons.HornGeometryKey}">
+    M4.0499969,7.0870913C2.9519978,7.0870913 2.0249984,8.4780906 2.0249987,10.125091 2.0249984,11.771091 2.9519978,13.162091 4.0499969,13.162091 5.1479961,13.162091 6.0749954,11.771091 6.0749955,10.125091 6.0749954,8.4780906 5.1479961,7.0870913 4.0499969,7.0870913z M29.975016,3.316155C23.883831,8.2016557,11.829888,8.9691842,8.1184387,9.0896781L8.0151367,9.0928462 8.0175586,9.1059306C8.0716033,9.4352315 8.0999939,9.7760909 8.0999942,10.125091 8.0999939,10.473966 8.0716033,10.814716 8.0175586,11.143921L8.0098858,11.185364 8.193316,11.195448C12.163719,11.420399,23.994581,12.458921,29.975016,17.005057z M31.176758,0.00019051835C31.280359,-0.0022594665 31.391857,0.01889403 31.514975,0.065146674 31.908983,0.21413228 31.999985,0.59114302 31.999985,1.0121596L31.999985,19.236969C31.999985,19.653958 31.913988,20.028956 31.525991,20.179955 31.405998,20.226952 31.450981,20.250023 31.32699,20.250023 31.050991,20.250023 30.778992,20.13601 30.583986,19.925928 25.229074,14.140572 9.6001122,13.269665 7.2865356,13.172559L7.2813506,13.172345 7.1739591,13.343056C6.4304952,14.468533 5.3060585,15.187091 4.0499969,15.187091 1.8169985,15.187091 0,12.916091 0,10.125091 0,7.3330911 1.8169985,5.0620912 4.0499969,5.0620912 5.3060585,5.0620912 6.4304952,5.78065 7.1739591,6.9063042L7.2852713,7.0832756 7.3087114,7.0828188C9.6077337,7.036146 25.141474,6.4939421 30.567997,0.34315929 30.75913,0.12521249 30.948835,0.005580858 31.176758,0.00019051835z
+  </sys:String>
+
+  <sys:String x:Key="{x:Static mbts:Icons.KeyGeometryKey}">
+    M22.399981,2.4000006C22.099982,2.4000006 21.899982,2.5 21.599982,2.6999998 21.199983,3.1000004 21.199983,3.8000002 21.599982,4.2000003L26.199979,8.9000001C26.599978,9.3000002 27.299977,9.3000002 27.699977,8.9000001 28.099977,8.5000002 28.099977,7.8000002 27.699977,7.4000006L23.099981,2.6999998C22.899981,2.5,22.699981,2.4000006,22.399981,2.4000006z M21.499982,0C22.299982,0,23.199981,0.30000019,23.79998,0.90000057L29.299976,6.4000001C30.599975,7.7000003,30.599975,9.7000003,29.299976,11L22.599981,17.7C21.299983,19,19.299984,19,17.999985,17.7L17.299985,17 12.699989,21.6 10.399991,20.900001 10.899991,23.400001 8.4999928,22.8 8.9999924,25.5 6.2999945,25.1 6.7999945,27.6 4.2999964,27 4.7999954,29.6 2.4999971,32 0,26.6 13.499989,13.1 16.999986,16.6 12.699989,12.3C11.399991,11,11.399991,9.0000002,12.699989,7.7000003L19.399984,1C19.899983,0.30000019,20.699983,0,21.499982,0z
+  </sys:String>
+
   <sys:String x:Key="{x:Static mbts:Icons.OrdersGeometryKey}">
     M50.14375,33.389126C50.416863,33.394688,50.653496,33.587773,50.705998,33.864617L50.015995,45.114388C49.810295,46.291462,49.130394,45.097489,49.130394,45.097489L47.65659,42.640538C42.747776,49.635197 34.633152,54.221001 25.433924,54.221001 14.884193,54.221001 5.7437552,48.204125 1.2449617,39.419205 0.80087067,38.552021 0.21358696,37.705738 0.052086769,36.736958 -0.49735315,33.490925 3.4507786,32.901036 4.8049124,34.432404 5.3674143,35.067692 6.034036,36.16407 6.5079177,37.026051 10.106778,43.799416 17.2321,48.413819 25.433924,48.413819 32.656544,48.413819 39.026364,44.826695 42.903977,39.351506L40.229367,38.854115C40.229367,38.854115,38.677464,38.647118,39.742466,37.996033L50.024895,33.398526C50.064972,33.391365,50.104733,33.388333,50.14375,33.389126z M23.030291,9.0310004L27.889918,9.0310004 27.889918,13.028299C30.539786,13.205498,32.324932,13.958096,33.464161,14.528294L33.964176,14.775793 32.417435,20.038878 31.706417,19.68068C30.579987,19.11958 28.839241,18.244583 26.149073,18.244583 24.006916,18.244583 22.723183,19.122181 22.723183,20.590876 22.723183,21.894272 23.943314,22.804369 27.551308,24.187165 32.706444,26.124659 34.911,28.702853 34.911,32.817341 34.911,36.892929 32.090527,40.05172 27.673611,40.989117L27.673611,45.540001 22.767485,45.540001 22.767485,41.330414C20.252919,41.155815,17.695551,40.424118,16.101811,39.404721L15.683999,39.137619 17.221739,33.731438 17.969059,34.180634C19.088988,34.851235 21.402748,35.97873 24.340325,35.97873 26.734886,35.97873 28.276728,34.921635 28.276728,33.291336 28.276728,31.986641 27.547409,30.853846 23.986016,29.57255 20.083815,28.144253 16.095511,26.04406 16.095511,21.239174 16.095511,17.280985 18.737379,14.291395 23.030291,13.329098z M25.268765,0C35.819447,2.7347414E-07 44.961449,6.0155495 49.458798,14.804573 49.902695,15.669173 50.490094,16.516972 50.651287,17.48427 51.198281,20.734265 47.255726,21.318962 45.901341,19.789065 45.336346,19.153567 44.669552,18.051968 44.19566,17.19517 40.5957,10.421881 33.473275,5.8072398 25.268765,5.8072393 18.047545,5.8072398 11.678013,9.3918336 7.8003562,14.867073L10.474627,15.367072C10.474627,15.367072,12.026909,15.574172,10.962921,16.223872L0.67933281,20.826762C0.36037083,20.880062,0.057029126,20.669165,0.00099972012,20.354063L0.69093342,9.1118043C0.89552094,7.9296158,1.5738537,9.124924,1.5738539,9.124924L3.0452772,11.583379C7.9566038,4.584462,16.073666,2.7347414E-07,25.268765,0z
   </sys:String>
 
+  <sys:String x:Key="{x:Static mbts:Icons.PauseGeometryKey}">
+    M17.94,0L29.150001,0 29.150001,32 17.94,32z M0,0L11.210002,0 11.210002,32 0,32z
+  </sys:String>
+
   <sys:String x:Key="{x:Static mbts:Icons.PaymentGeometryKey}">
     M28.000001,6.0000026L28.000001,15 6.0010006,15 6.0010006,17.000003 30.001,17.000003 30.001,6.0000026z M14.231,2.9540056L14.979999,2.9540056 14.979999,3.987005C15.704998,4.009005,16.200997,4.178005,16.550998,4.3600049L16.248998,5.0620046C15.994998,4.9340047 15.499998,4.7010047 14.725999,4.7010047 13.796,4.7010047 13.445001,5.1900046 13.445001,5.6160046 13.445001,6.1710043 13.893,6.4470041 14.943999,6.8310037 16.187998,7.2780037 16.816998,7.8320036 16.816998,8.7800031 16.816998,9.6210027 16.151998,10.409003 14.907999,10.591002L14.907999,11.698002 14.146,11.698002 14.146,10.622003C13.445001,10.611002,12.720001,10.420002,12.297002,10.154003L12.587001,9.4400029C13.022001,9.696003 13.651,9.8980026 14.328,9.8980026 15.185999,9.8980026 15.765998,9.4620028 15.765998,8.8540034 15.765998,8.2680035 15.293999,7.9060035 14.4,7.5870035 13.167001,7.1610038 12.406001,6.6710041 12.406001,5.7440041 12.406001,4.8600047 13.119,4.189005 14.231,4.0290052z M2,2.0000002L2,13 26.000001,13 26.000001,2.0000002z M0,0L28.000001,0 28.000001,4.0000031 32.001,4.0000031 32.001,19.000003 4.0010006,19.000003 4.0010006,15 0,15z
   </sys:String>
@@ -323,6 +337,11 @@
       M33.5,4h-6v10h6V4z M31.5,12h-2V6h2V12z
     </sys:String>
   </x:Array>
+
+  <sys:String x:Key="{x:Static mbts:Icons.SpeakerGeometryKey}">
+    M18,12.839666L18,19.159448 18.029955,19.131576C18.848108,18.314159 19.332083,17.192702 19.332083,15.999873 19.332083,14.806357 18.848108,13.684685 18.029955,12.867527z M21.738388,4.748316C21.868353,4.7515661 21.999973,4.7804414 22.126221,4.8376924 26.511095,6.8177201 29.344013,11.199782 29.344013,15.999849 29.344013,20.799915 26.511095,25.181977 22.126221,27.162004 21.992224,27.223004 21.853228,27.251006 21.715233,27.251006 21.333244,27.251006 20.970255,27.032003 20.803259,26.662997 20.575266,26.15899 20.799259,25.566981 21.302244,25.339978 24.973139,23.681956 27.34407,20.015905 27.34407,15.999849 27.34407,11.983792 24.973139,8.3177406 21.302244,6.6597177 20.799259,6.4327146 20.575266,5.8407065 20.803259,5.3366992 20.973503,4.9594442 21.348494,4.7385656 21.738388,4.748316z M16,3.1854247L6.6530151,11.257323C6.4719848,11.414303,6.2399902,11.500301,6,11.500301L1.9999998,11.500301 1.9999998,21.500148 6,21.500148C6.2219848,21.500148,6.4370117,21.573144,6.6110229,21.709129L16,28.964023z M17.000252,1.186163E-08C17.141373,-2.1778678E-05 17.283264,0.02997845 17.416016,0.091477852 17.770996,0.25450047 18,0.60843792 18,1.0004608L18,10.368904 18.170259,10.465408C20.111607,11.612996 21.331976,13.716092 21.331976,15.999873 21.331976,18.282748 20.111607,20.38576 18.170259,21.53334L18,21.629842 18,31.000003C18,31.382016 17.78302,31.728995 17.440002,31.896962 17.301025,31.965991 17.150024,31.99999 17,31.99999 16.78302,31.99999 16.567017,31.929982 16.388977,31.791007L5.65802,23.500117 0.99999966,23.500117C0.44702145,23.500117,-3.9348969E-08,23.053104,3.5527137E-15,22.500133L3.5527137E-15,10.500316C-3.9348969E-08,9.9473459,0.44702145,9.5003311,0.99999966,9.5003311L5.6279907,9.5003311 16.346985,0.24345344C16.531998,0.083467316,16.765053,3.6392792E-05,17.000252,1.186163E-08z
+  </sys:String>
+
   <sys:String x:Key="{x:Static mbts:Icons.StarGeometryKey}">
     M1540.22,2082.07L1546.95,2102.78 1568.73,2102.78 1551.11,2115.58 1557.84,2136.29 1540.22,2123.49 1522.6,2136.29 1529.33,2115.58 1511.71,2102.78 1533.49,2102.78 1540.22,2082.07z
   </sys:String>
@@ -332,7 +351,7 @@
   </sys:String>
 
   <sys:String x:Key="{x:Static mbts:Icons.TrashGeometryKey}">
-    M0,12.568994L23.662999,12.568994 20.910989,31.999999 2.7520113,31.999999z M8.0689915,1.6269979L8.0689915,4.6679968 15.594984,4.6679968 15.594984,1.6269979z M6.4420097,0L17.221997,0 17.221997,4.6679968 23.662999,4.6679968 23.662999,8.7949938 0,8.7949938 0,4.6679968 6.4420097,4.6679968z
+    M15.000001,8.0000272L17,8.0000272 17,27.000028 15.000001,27.000028z M11.000001,8.0000272L13.000001,8.0000272 13.000001,27.000028 11.000001,27.000028z M7.0000005,8.0000272L9.000001,8.0000272 9.000001,27.000028 7.0000005,27.000028z M3.0790101,5.0000274L4.9959994,29.922999 19.000006,30.000026 20.918949,5.0000274z M13.771989,1.9959999L10.198989,2.0000001C10.158989,2.025,9.9989892,2.241,9.9989892,2.6000001L9.9989892,3.0000258 13.998989,3.0000258 13.998989,2.6000001C13.998989,2.241,13.838988,2.025,13.771989,1.9959999z M10.198989,0L13.798988,0C15.031989,0,15.998989,1.142,15.998989,2.6000001L15.998989,3.0000258 23.07898,3.0000258 24,3.0000272 24,5.0000274 22.925121,5.0000274 20.995976,30.076991C20.999027,31.102992,20.100956,32.000026,18.999029,32.000026L4.9990512,32.000026C3.8960255,32.000026,2.9990543,31.102992,2.999054,30.000026L1.073059,5.0000274 0,5.0000274 0,3.0000272 0.91897895,3.0000272 7.9989887,3.0000258 7.9989887,2.6000001C7.9989887,1.142,8.9659892,0,10.198989,0z
   </sys:String>
 
   <!--UndoCircular (the icon is free to use if we include this information in our credit/about section)
@@ -392,10 +411,10 @@
       <DrawingGroup>
         <DrawingGroup.Children>
           <GeometryDrawing Geometry="
-M 32.868601,3.8869994 C31.026201,3.8869996 29.534,5.3791947 29.534,7.2190399 29.534,9.0588851 31.026201,10.553 32.868601,10.553 34.7085,10.553 36.202,9.0588851 36.202,7.2190399 36.202,5.3791947 34.7085,3.8869996 32.868601,3.8869994z 
-M 42.868601,3.8869994 C41.026201,3.8869996 39.534,5.3791947 39.534,7.2190399 39.534,9.0588851 41.026201,10.553 42.868601,10.553 44.7085,10.553 46.202,9.0588851 46.202,7.2190399 46.202,5.3791947 44.7085,3.8869996 42.868601,3.8869994z 
-M 52.868601,3.8869994 C51.026201,3.8869996 49.534,5.3791947 49.534,7.2190399 49.534,9.0588851 51.026201,10.553 52.868601,10.553 54.7085,10.553 56.202,9.0588851 56.202,7.2190399 56.202,5.3791947 54.7085,3.8869996 52.868601,3.8869994z 
-M5.2010002,14.812L5.2010002,43.573997 56.098,43.573997 56.098,14.812z 
+M 32.868601,3.8869994 C31.026201,3.8869996 29.534,5.3791947 29.534,7.2190399 29.534,9.0588851 31.026201,10.553 32.868601,10.553 34.7085,10.553 36.202,9.0588851 36.202,7.2190399 36.202,5.3791947 34.7085,3.8869996 32.868601,3.8869994z
+M 42.868601,3.8869994 C41.026201,3.8869996 39.534,5.3791947 39.534,7.2190399 39.534,9.0588851 41.026201,10.553 42.868601,10.553 44.7085,10.553 46.202,9.0588851 46.202,7.2190399 46.202,5.3791947 44.7085,3.8869996 42.868601,3.8869994z
+M 52.868601,3.8869994 C51.026201,3.8869996 49.534,5.3791947 49.534,7.2190399 49.534,9.0588851 51.026201,10.553 52.868601,10.553 54.7085,10.553 56.202,9.0588851 56.202,7.2190399 56.202,5.3791947 54.7085,3.8869996 52.868601,3.8869994z
+M5.2010002,14.812L5.2010002,43.573997 56.098,43.573997 56.098,14.812z
 M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
             <GeometryDrawing.Pen>
               <Pen Thickness="1" Brush="Black" />
@@ -411,10 +430,10 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
       <DrawingGroup>
         <DrawingGroup.Children>
           <GeometryDrawing Brush="Black" Geometry="
-M 32.868601,3.8869994 C31.026201,3.8869996 29.534,5.3791947 29.534,7.2190399 29.534,9.0588851 31.026201,10.553 32.868601,10.553 34.7085,10.553 36.202,9.0588851 36.202,7.2190399 36.202,5.3791947 34.7085,3.8869996 32.868601,3.8869994z 
-M 42.868601,3.8869994 C41.026201,3.8869996 39.534,5.3791947 39.534,7.2190399 39.534,9.0588851 41.026201,10.553 42.868601,10.553 44.7085,10.553 46.202,9.0588851 46.202,7.2190399 46.202,5.3791947 44.7085,3.8869996 42.868601,3.8869994z 
-M 52.868601,3.8869994 C51.026201,3.8869996 49.534,5.3791947 49.534,7.2190399 49.534,9.0588851 51.026201,10.553 52.868601,10.553 54.7085,10.553 56.202,9.0588851 56.202,7.2190399 56.202,5.3791947 54.7085,3.8869996 52.868601,3.8869994z 
-M5.2010002,14.812L5.2010002,43.573997 56.098,43.573997 56.098,14.812z 
+M 32.868601,3.8869994 C31.026201,3.8869996 29.534,5.3791947 29.534,7.2190399 29.534,9.0588851 31.026201,10.553 32.868601,10.553 34.7085,10.553 36.202,9.0588851 36.202,7.2190399 36.202,5.3791947 34.7085,3.8869996 32.868601,3.8869994z
+M 42.868601,3.8869994 C41.026201,3.8869996 39.534,5.3791947 39.534,7.2190399 39.534,9.0588851 41.026201,10.553 42.868601,10.553 44.7085,10.553 46.202,9.0588851 46.202,7.2190399 46.202,5.3791947 44.7085,3.8869996 42.868601,3.8869994z
+M 52.868601,3.8869994 C51.026201,3.8869996 49.534,5.3791947 49.534,7.2190399 49.534,9.0588851 51.026201,10.553 52.868601,10.553 54.7085,10.553 56.202,9.0588851 56.202,7.2190399 56.202,5.3791947 54.7085,3.8869996 52.868601,3.8869994z
+M5.2010002,14.812L5.2010002,43.573997 56.098,43.573997 56.098,14.812z
 M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
             <GeometryDrawing.Pen>
               <Pen Thickness="1" Brush="Black" />
@@ -830,7 +849,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="M23,14C24.10498,14 25,14.89502 25,16 25,17.10498 24.10498,18 23,18 21.89502,18 21,17.10498 21,16 21,14.89502 21.89502,14 23,14z M16,14C17.105,14 18,14.895 18,16 18,17.105 17.105,18 16,18 14.895,18 14,17.105 14,16 14,14.895 14.895,14 16,14z M9,14C10.105,14 11,14.895 11,16 11,17.105 10.105,18 9,18 7.8950005,18 7,17.105 7,16 7,14.895 7.8950005,14 9,14z M16,2C8.2799997,2 2,8.2800002 2,16 2,23.72 8.2799997,30 16,30 23.72,30 30,23.72 30,16 30,8.2800002 23.72,2 16,2z M16,0C24.822,0 32,7.178 32,16 32,24.822 24.822,32 16,32 7.1780005,32 0,24.822 0,16 0,7.178 7.1780005,0 16,0z" />
         </DrawingGroup.Children>
@@ -843,7 +862,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="M299.152955025434,0L496.426178902388,0 268.890046089888,280.247772216797 198.190201729536,367.407897949219 199.87503144145,369.495361328125 271.502137154341,457.706451416016 498.999970406294,738 301.717621773481,738 101.234124153852,491.008697509766 99.5304498374462,488.936553955078 98.6409082114697,490.003173828125 0,368.488952636719 98.6409082114697,246.945526123047z" />
         </DrawingGroup.Children>
@@ -855,7 +874,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="{mbts:BTSColor MarketData.bid}"
                         Geometry="m 24.706673 31.196264 -3.086182 3.086182 5.965481 5.963348 -5.965481 5.96548 3.086182 3.084049 5.963348 -5.963348 5.96548 5.963348 3.084049 -3.084049 -5.963347 -5.96548 5.963347 -5.963348 -3.084049 -3.086182 -5.96548 5.965481 z M 5.3507926 32.045363 H 17.816449 v 2.401501 H 5.3507926 Z m 0 -4.937233 H 24.132994 v 2.401501 H 5.3507926 Z m 0 9.874466 h 5.5381524 v 2.401501 H 5.3507926 Z M 1.3730469 0 A 1.3741374 1.3741374 0 0 0 0 1.3730469 V 45.630859 a 1.3741374 1.3741374 0 0 0 1.3730469 1.373047 H 16.853516 a 17.906029 17.906029 0 0 1 -0.05859 -1.373047 17.906029 17.906029 0 0 1 0.06836 -1.375 H 2.7480469 V 2.7480469 H 33.326172 V 27.783203 a 17.906029 17.906029 0 0 1 1.375 -0.05859 17.906029 17.906029 0 0 1 1.373047 0.06836 V 1.3730469 A 1.3741374 1.3741374 0 0 0 34.701172 0 Z M 10.662215 24.759265 V 5.1202697 h 7.148923 q 3.286862 0 5.05355 1.2051818 1.766687 1.2051838 1.766687 3.3964241 0 1.5886494 -1.081924 2.7801354 -1.068231 1.191488 -2.739053 1.657126 v 0.05479 q 2.095375 0.26021 3.341644 1.547564 1.259962 1.287354 1.259962 3.136214 0 2.697964 -1.93103 4.286613 -1.931032 1.574956 -5.272673 1.574956 z M 15.085783 8.3797408 v 4.6563852 h 1.944726 q 1.369526 0 2.150155 -0.657372 0.794325 -0.671068 0.794325 -1.835164 0 -2.1638492 -3.23208 -2.1638492 z m 0 7.9432472 v 5.176805 h 2.39667 q 1.533868 0 2.39667 -0.712152 0.876495 -0.712155 0.876495 -1.944728 0 -1.17779 -0.862802 -1.848858 -0.849105 -0.671067 -2.382974 -0.671067 z" />
         </DrawingGroup.Children>
@@ -867,7 +886,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="{mbts:BTSColor MarketData.ask}"
                         Geometry="m 19.060265 26.797642 v -2.144583 q 0.583058 0.489233 1.266644 0.737201 0.683586 0.241265 1.380576 0.241265 0.408811 0 0.710393 -0.07372 0.308284 -0.07372 0.509339 -0.201055 0.207756 -0.134036 0.308284 -0.308283 0.100527 -0.18095 0.100527 -0.388706 0 -0.281477 -0.160844 -0.502637 -0.160844 -0.22116 -0.44232 -0.408811 -0.274775 -0.187651 -0.656779 -0.361898 -0.382004 -0.174248 -0.824324 -0.355197 -1.125906 -0.469128 -1.682158 -1.146012 -0.549549 -0.676884 -0.549549 -1.635245 0 -0.750604 0.301582 -1.28675 0.301582 -0.542847 0.817622 -0.891342 0.522743 -0.348495 1.206328 -0.509339 0.683586 -0.167545 1.447594 -0.167545 0.750604 0 1.326961 0.09383 0.583059 0.08712 1.072292 0.274775 v 2.003845 q -0.241266 -0.167545 -0.529444 -0.29488 -0.281477 -0.127335 -0.583059 -0.207757 -0.301582 -0.08712 -0.603164 -0.127334 -0.29488 -0.04021 -0.562953 -0.04021 -0.3686 0 -0.670182 0.07372 -0.301582 0.06702 -0.509339 0.194353 -0.207756 0.127334 -0.321687 0.308284 -0.113931 0.174247 -0.113931 0.395407 0 0.241266 0.127334 0.435619 0.127335 0.187651 0.361899 0.361898 0.234564 0.167546 0.569655 0.335091 0.335091 0.160844 0.757306 0.335091 0.576356 0.241266 1.03208 0.516041 0.462426 0.268073 0.790816 0.609866 0.328389 0.341793 0.502636 0.784113 0.174248 0.435618 0.174248 1.018677 0 0.804219 -0.308284 1.353768 -0.301582 0.542848 -0.824324 0.884641 -0.522743 0.335091 -1.219732 0.482531 -0.690288 0.14744 -1.460998 0.14744 -0.790815 0 -1.50791 -0.134036 -0.710393 -0.134037 -1.233135 -0.40211 z m 6.620223 3.788289 -1.556212 1.556212 3.008102 3.007026 -3.008102 3.008101 1.556212 1.555136 3.007026 -3.007026 3.008101 3.007026 1.555136 -1.555136 -3.007026 -3.008101 3.007026 -3.007026 -1.555136 -1.556212 -3.008101 3.008102 z m -9.76023 2.917766 h 2.792621 v 1.21096 h -2.792621 z m 0 -2.489606 h 6.285825 v 1.21096 h -6.285825 z m 0 -2.489607 h 9.470951 v 1.210961 H 15.920258 Z M 13.914475 14.855173 a 0.69291063 0.69291063 0 0 0 -0.692361 0.692361 v 22.317061 a 0.69291063 0.69291063 0 0 0 0.692361 0.692361 h 7.806047 a 9.0291392 9.0291392 0 0 1 -0.02954 -0.692361 9.0291392 9.0291392 0 0 1 0.03447 -0.693345 H 14.60782 V 16.24088 h 15.419061 v 12.624011 a 9.0291392 9.0291392 0 0 1 0.693346 -0.02954 9.0291392 9.0291392 0 0 1 0.692361 0.03447 V 15.547534 a 0.69291063 0.69291063 0 0 0 -0.692361 -0.692361 z" />
         </DrawingGroup.Children>
@@ -880,7 +899,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="M 5.3507926 32.045363 H 17.81645 v 2.401501 H 5.3507926 Z m 0 -4.937233 H 24.132995 v 2.401501 H 5.3507926 Z M 18.799228 22.222041 v 2.32929 h -1.567173 v -2.264886 q -2.179014 -0.01073 -4.057475 -0.987533 v -2.973336 q 0.622575 0.504501 1.856993 0.933864 1.234417 0.429362 2.200482 0.493766 v -3.907198 q -2.511771 -0.933863 -3.4349 -2.018003 -0.912395 -1.094874 -0.912395 -2.662047 0 -1.685248 1.191482 -2.8659947 1.19148 -1.1914807 3.155813 -1.3846939 V 4.918734 h 1.567173 v 1.9535992 q 2.264887 0.1073411 3.38123 0.7299162 V 10.500446 Q 20.677689 9.5880506 18.799228 9.3841034 v 4.0682086 q 2.35076 0.847992 3.370495 1.942866 1.019736 1.08414 1.019736 2.629845 0 1.781854 -1.137811 2.876728 -1.13781 1.08414 -3.25242 1.32029 z M 17.232055 12.829737 V 9.4270397 q -1.492034 0.2683516 -1.492034 1.5564393 0 1.105608 1.492034 1.846258 z m 1.567173 3.628113 v 3.25242 q 1.53497 -0.236149 1.53497 -1.53497 0 -1.051939 -1.53497 -1.71745 z m 13.258587 13.65074 h -3.954117 l 0.0014 7.641804 -7.643169 -10e-7 0.0014 3.952751 h 7.640439 l 0.0014 7.641803 h 3.951385 l 0.0014 -7.641802 7.640437 -10e-7 0.0014 -3.952751 -7.643169 10e-7 z M 5.3507926 36.982596 h 5.5381524 v 2.401501 H 5.3507926 Z M 1.3730469 0 A 1.3741374 1.3741374 0 0 0 0 1.3730469 V 45.630859 a 1.3741374 1.3741374 0 0 0 1.3730469 1.373047 H 16.853516 a 17.906029 17.906029 0 0 1 -0.05859 -1.373047 17.906029 17.906029 0 0 1 0.06836 -1.375 H 2.7480469 V 2.7480469 H 33.326172 V 27.783203 a 17.906029 17.906029 0 0 1 1.375 -0.05859 17.906029 17.906029 0 0 1 1.373047 0.06836 V 1.3730469 A 1.3741374 1.3741374 0 0 0 34.701172 0 Z" />
         </DrawingGroup.Children>
@@ -892,7 +911,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="m 26.463403 27.963318 h -2.359042 l -0.683586 -2.137882 h -3.417929 l -0.676884 2.137882 h -2.345638 l 3.498351 -9.610414 h 2.566798 z M 22.92484 24.163384 21.89276 20.933106 q -0.113931 -0.361899 -0.160844 -0.864535 h -0.05361 q -0.03351 0.422214 -0.167545 0.837727 l -1.045485 3.257086 z m 2.065112 7.055953 -1.51223 1.51223 2.923087 2.922042 -2.923087 2.923086 1.51223 1.511185 2.922042 -2.922042 2.923086 2.922042 1.511185 -1.511185 -2.922041 -2.923086 2.922041 -2.922042 -1.511185 -1.51223 -2.923086 2.923087 z m -9.484387 0.416058 h 6.108175 v 1.176737 h -6.108175 z m 0 -2.419244 h 9.203284 v 1.176735 h -9.203284 z m 0 4.83849 h 2.713696 v 1.176736 H 15.505565 Z M 13.556469 15.93316 a 0.67332766 0.67332766 0 0 0 -0.672794 0.672793 v 21.686339 a 0.67332766 0.67332766 0 0 0 0.672794 0.672793 h 7.585433 a 8.7739586 8.7739586 0 0 1 -0.02871 -0.672793 8.7739586 8.7739586 0 0 1 0.0335 -0.673751 H 14.230219 V 17.279703 h 14.983289 v 12.267233 a 8.7739586 8.7739586 0 0 1 0.67375 -0.02871 8.7739586 8.7739586 0 0 1 0.672794 0.0335 V 16.605953 A 0.67332766 0.67332766 0 0 0 29.887258 15.93316 Z" />
         </DrawingGroup.Children>
@@ -904,7 +923,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="m 24.706673 31.196264 -3.086181 3.086182 5.96548 5.963348 -5.96548 5.96548 3.086181 3.084049 5.963348 -5.963348 5.96548 5.963348 3.084049 -3.084049 -5.963347 -5.96548 5.963347 -5.963348 -3.084049 -3.086182 -5.96548 5.965481 z M 5.3507926 32.045363 H 17.81645 v 2.401501 H 5.3507926 Z m 0 -4.937233 H 24.132994 v 2.401501 H 5.3507926 Z M 26.434166 6.0031559 14.993666 17.443656 9.6399578 12.089946 6.0100982 15.719802 c 2.9622322 2.959826 6.0772448 6.092263 8.9969908 8.970151 L 30.064121 9.6329208 Z M 5.3507926 36.982596 h 5.5381524 v 2.401501 H 5.3507926 Z M 1.3730469 0 A 1.3741374 1.3741374 0 0 0 0 1.3730469 V 45.630859 a 1.3741374 1.3741374 0 0 0 1.3730469 1.373047 H 16.853516 a 17.906029 17.906029 0 0 1 -0.05859 -1.373047 17.906029 17.906029 0 0 1 0.06836 -1.375 H 2.7480469 V 2.7480469 H 33.326172 V 27.783203 a 17.906029 17.906029 0 0 1 1.375 -0.05859 17.906029 17.906029 0 0 1 1.373047 0.06836 V 1.3730469 A 1.3741374 1.3741374 0 0 0 34.701172 0 Z" />
         </DrawingGroup.Children>
@@ -927,7 +946,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="{mbts:BTSColor MarketData.bid}"
                         Geometry="M 9.9417804 -0.02293875 1.9154138 8.0034278 17.4301 23.512569 1.9154138 39.027256 9.9417804 47.048077 25.450922 31.538936 40.965607 47.048077 48.986428 39.027256 33.47729 23.512569 48.986428 8.0034278 40.965607 -0.02293875 25.450922 15.491746 Z" />
         </DrawingGroup.Children>
@@ -939,7 +958,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="{mbts:BTSColor MarketData.ask}"
                         Geometry="M 9.9417804 -0.02293875 1.9154138 8.0034278 17.4301 23.512569 1.9154138 39.027256 9.9417804 47.048077 25.450922 31.538936 40.965607 47.048077 48.986428 39.027256 33.47729 23.512569 48.986428 8.0034278 40.965607 -0.02293875 25.450922 15.491746 Z" />
         </DrawingGroup.Children>
@@ -951,7 +970,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="M 9.9417804 -0.02293875 1.9154138 8.0034278 17.4301 23.512569 1.9154138 39.027256 9.9417804 47.048077 25.450922 31.538936 40.965607 47.048077 48.986428 39.027256 33.47729 23.512569 48.986428 8.0034278 40.965607 -0.02293875 25.450922 15.491746 Z" />
         </DrawingGroup.Children>
@@ -964,7 +983,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="m 69.641861 87.129943 a 36.813842 36.813842 0 0 0 -36.813776 36.813767 36.813842 36.813842 0 0 0 31.044618 36.31355 l 1.208194 21.35839 1.804543 31.90967 a 41.092964 41.092964 0 0 0 -29.828154 39.50509 41.092964 41.092964 0 0 0 41.09258 41.0931 41.092964 41.092964 0 0 0 41.093104 -41.0931 41.092964 41.092964 0 0 0 -0.10284 -2.9068 41.092964 41.092964 0 0 0 -38.048841 -38.03902 l -2.962092 -52.36321 a 36.813842 36.813842 0 0 0 20.093347 -12.61939 l 33.150946 15.70705 v 5.3e-4 a 27.542416 27.542416 0 0 0 -0.12557 2.49907 27.542416 27.542416 0 0 0 27.54251 27.54249 27.542416 27.542416 0 0 0 27.5425 -27.5425 27.542416 27.542416 0 0 0 -27.5425 -27.5425 27.542416 27.542416 0 0 0 -22.44618 11.61479 l -31.44563 -14.89935 a 36.813842 36.813842 0 0 0 1.55701 -10.53786 36.813842 36.813842 0 0 0 -36.813769 -36.813767 z" />
         </DrawingGroup.Children>
@@ -976,7 +995,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="M 36.50044 86.999995 A 36.813842 36.813842 0 0 0 -0.3133356 123.81377 36.813842 36.813842 0 0 0 30.731282 160.12732 l 1.208194 21.35839 1.804543 31.90967 a 41.092964 41.092964 0 0 0 -29.8281546 39.50509 41.092964 41.092964 0 0 0 41.0925806 41.0931 41.092964 41.092964 0 0 0 41.093099 -41.0931 41.092964 41.092964 0 0 0 -0.102836 -2.9068 41.092964 41.092964 0 0 0 -38.04884 -38.03902 l -2.962092 -52.36321 a 36.813842 36.813842 0 0 0 20.093347 -12.61939 l 33.150948 15.70705 v 5.3e-4 a 27.542416 27.542416 0 0 0 -0.125574 2.49907 27.542416 27.542416 0 0 0 27.542513 27.54249 27.542416 27.542416 0 0 0 27.5425 -27.5425 27.542416 27.542416 0 0 0 -27.5425 -27.5425 27.542416 27.542416 0 0 0 -22.44618 11.61479 L 71.757201 134.35163 A 36.813842 36.813842 0 0 0 73.314213 123.81377 36.813842 36.813842 0 0 0 36.50044 86.999995 Z m 116.60981 115.628085 0.007 37.48967 h -37.49716 l 0.007 19.39257 h 37.48344 L 153.11751 297 h 19.38493 l 0.007 -37.48968 h 37.48342 L 210 240.11775 h -37.49727 l 0.007 -37.48967 z" />
         </DrawingGroup.Children>
@@ -1001,7 +1020,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="M 37.03498 86.999995 A 36.813842 36.813842 0 0 0 0.2212037 123.81377 36.813842 36.813842 0 0 0 31.265822 160.12732 l 1.208194 21.35839 1.804543 31.90967 a 41.092964 41.092964 0 0 0 -29.8281553 39.50509 41.092964 41.092964 0 0 0 41.0925813 41.0931 41.092964 41.092964 0 0 0 41.093099 -41.0931 41.092964 41.092964 0 0 0 -0.102836 -2.9068 41.092964 41.092964 0 0 0 -38.04884 -38.03902 l -2.962092 -52.36321 a 36.813842 36.813842 0 0 0 20.093347 -12.61939 l 33.150948 15.70705 v 5.3e-4 a 27.542416 27.542416 0 0 0 -0.125574 2.49907 27.542416 27.542416 0 0 0 27.542503 27.54249 27.542416 27.542416 0 0 0 27.5425 -27.5425 27.542416 27.542416 0 0 0 -27.5425 -27.5425 27.542416 27.542416 0 0 0 -22.44618 11.61479 L 72.291741 134.35163 A 36.813842 36.813842 0 0 0 73.848753 123.81377 36.813842 36.813842 0 0 0 37.03498 86.999995 Z m 145.03189 90.486735 -76.71431 76.71435 27.93311 27.93293 L 210 205.41986 Z m -0.008 22.13769 5.79522 5.79544 -54.57645 54.57644 -5.7952 -5.79522 z m -81.50016 59.76108 -10.071854 37.61451 37.606034 -10.0803 z" />
         </DrawingGroup.Children>
@@ -1013,7 +1032,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
     <DrawingImage.Drawing>
       <DrawingGroup>
         <DrawingGroup.Children>
-          <GeometryDrawing 
+          <GeometryDrawing
                         Brush="Black"
                         Geometry="m 139.80129 180.78831 a 20.783495 20.783495 0 0 0 -20.78345 20.78346 20.783495 20.783495 0 0 0 17.52643 20.50105 l 0.68209 12.05803 1.01877 18.01482 a 23.1993 23.1993 0 0 0 -16.83968 22.30284 23.1993 23.1993 0 0 0 23.1991 23.19938 23.1993 23.1993 0 0 0 23.19935 -23.19938 23.1993 23.1993 0 0 0 -0.058 -1.64105 23.1993 23.1993 0 0 0 -21.4807 -21.47518 l -1.67225 -29.56198 a 20.783495 20.783495 0 0 0 11.34383 -7.12437 l 18.71558 8.86752 v 3.1e-4 a 15.549251 15.549251 0 0 0 -0.0708 1.41086 15.549251 15.549251 0 0 0 15.5493 15.54927 15.549251 15.549251 0 0 0 15.54931 -15.54927 15.549251 15.549251 0 0 0 -15.54931 -15.54932 15.549251 15.549251 0 0 0 -12.67213 6.5572 l -17.75282 -8.41152 a 20.783495 20.783495 0 0 0 0.87902 -5.94921 20.783495 20.783495 0 0 0 -20.78345 -20.78346 z M 31.983713 88.265691 A 30.676234 30.676234 0 0 0 1.3075339 118.94187 30.676234 30.676234 0 0 0 27.17639 149.20122 l 1.006764 17.79752 1.503689 26.58969 A 34.241941 34.241941 0 0 0 4.8316412 226.50722 34.241941 34.241941 0 0 0 39.073263 260.74928 34.241941 34.241941 0 0 0 73.315316 226.50722 34.241941 34.241941 0 0 0 73.229625 224.08505 34.241941 34.241941 0 0 0 41.524291 192.3879 L 39.05604 148.75469 A 30.676234 30.676234 0 0 0 55.799422 138.2392 l 27.624018 13.08837 v 4.4e-4 a 22.950541 22.950541 0 0 0 -0.104638 2.08242 22.950541 22.950541 0 0 0 22.950618 22.9506 22.950541 22.950541 0 0 0 22.95062 -22.9506 22.950541 22.950541 0 0 0 -22.95062 -22.95061 22.950541 22.950541 0 0 0 -18.703946 9.67837 L 61.362463 127.72286 A 30.676234 30.676234 0 0 0 62.65989 118.94187 30.676234 30.676234 0 0 0 31.983713 88.265691 Z" />
         </DrawingGroup.Children>
@@ -1137,7 +1156,7 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
         <DrawingGroup.Children>
           <GeometryDrawing
             Brush="Black"
-            Geometry="M17.740002,11.999007C17.254002,11.999007,16.859001,12.394008,16.859001,12.879008L16.859001,24.458791 16.860127,24.479386C16.861003,24.607261 16.813003,24.735511 16.716002,24.834012 16.667502,24.883012 16.611378,24.91995 16.551394,24.944762L16.521562,24.955436 16.507633,24.960536 16.506465,24.960837 16.50574,24.961097 16.49194,24.964574 16.459728,24.972863C16.42719,24.979527,16.393502,24.983027,16.359002,24.983027L16.316763,24.980893 16.315716,24.980851 16.307903,24.980445C16.223895,24.971904,16.146014,24.942538,16.07951,24.897597L16.067752,24.887895 16.047276,24.873078 16.015234,24.844558 16.005502,24.836528 16.001236,24.831357 13.737002,22.600011C13.267003,22.134011 12.502003,22.135011 12.031003,22.600011 11.805003,22.82301 11.680003,23.120011 11.680003,23.436011 11.680003,23.751012 11.805003,24.048011 12.031003,24.272012L16.842003,29.031013C19.311003,31.189013 21.546002,31.119014 22.656003,30.886014 23.939002,30.614013 25.015002,29.846013 25.464002,28.880013 25.857001,28.036012 26.301002,27.080012 26.263001,26.195012 26.262002,26.178012 26.268003,26.074012 26.269002,26.056012L26.268003,20.974011C26.268003,20.55601 25.922002,20.215011 25.496001,20.215011 25.335502,20.215011 25.239001,20.246511 25.179877,20.283135L25.144,20.309762 25.144,21.215013C25.144,21.491012 24.919999,21.715013 24.644,21.715013 24.367999,21.715013 24.144,21.491012 24.144,21.215013L24.144,19.278017C24.144,18.793018 23.749,18.399019 23.263,18.399019 22.808312,18.399019 22.432727,18.745308 22.387555,19.18822L22.383004,19.277944 22.383004,19.716007C22.383004,19.992006 22.159003,20.216004 21.883002,20.216004 21.607003,20.216004 21.383002,19.992006 21.383002,19.716007L21.383002,19.278054 21.383002,18.504013C21.383002,18.018016 20.988002,17.623017 20.502002,17.623017 20.016002,17.623017 19.621001,18.018016 19.621001,18.504013L19.621001,20.24402C19.621001,20.52102 19.397001,20.74402 19.121001,20.74402 18.844001,20.74402 18.621001,20.52102 18.621001,20.24402L18.621001,18.504035 18.621001,12.879008C18.621001,12.394008,18.226001,11.999007,17.740002,11.999007z M17.740002,10.999005C18.777001,10.999005,19.621001,11.843007,19.621001,12.879008L19.621001,16.842839 19.687315,16.808824C19.933955,16.689783 20.210345,16.623022 20.502002,16.623022 21.247346,16.623022 21.892987,17.059031 22.197202,17.689331L22.211675,17.721288 22.212884,17.720384C22.513,17.517568 22.874499,17.399021 23.263,17.399021 24.267594,17.399021 25.091062,18.190155 25.141547,19.181478L25.143222,19.247425 25.174827,19.241074C25.276639,19.223799 25.383876,19.21501 25.496001,19.21501 26.473002,19.21501 27.268003,20.00401 27.268003,20.974011L27.268003,26.087012C27.268003,26.098012 27.262002,26.194013 27.262002,26.205012 27.311002,27.281013 26.790002,28.401013 26.371001,29.302012 25.783002,30.566012 24.472001,31.523013 22.863002,31.864013 22.513001,31.938014 22.067002,31.999013 21.547002,31.999013 20.149003,31.999013 18.216002,31.561013 16.161002,29.763013L11.328003,24.983012C10.910003,24.570012 10.680003,24.020011 10.680003,23.436011 10.680003,22.85101 10.910003,22.302011 11.328003,21.88901 12.187003,21.040011 13.583003,21.041011 14.440002,21.88901L15.859002,23.287391 15.859002,12.879008C15.859002,11.843007,16.703002,10.999005,17.740002,10.999005z M6.8659983,4.0500388L19.083997,4.0500388C20.668996,4.0500388,21.957997,5.3460296,21.957997,6.9390478L21.957997,14.653042C21.957997,14.93005 21.734998,15.153042 21.457997,15.153042 21.181996,15.153042 20.957997,14.93005 20.957997,14.653042L20.957997,6.9390478C20.957997,5.8980318,20.116998,5.0500394,19.083997,5.0500394L6.8659983,5.0500394C5.8319979,5.0500394,4.9909983,5.8980318,4.9909984,6.9390478L4.9909984,26.116061C4.9909983,27.157046,5.8319979,28.00504,6.8659983,28.00504L11.696996,28.00504C11.972997,28.00504 12.196996,28.229039 12.196996,28.50504 12.196996,28.781041 11.972997,29.00504 11.696996,29.00504L6.8659983,29.00504C5.2809954,29.00504,3.9909983,27.70905,3.9909983,26.116061L3.9909983,6.9390478C3.9909983,5.3460296,5.2809954,4.0500388,6.8659983,4.0500388z M6.4360008,0L17.467001,0C17.743001,0 17.967001,0.22300029 17.967001,0.50000024 17.967001,0.77600098 17.743001,1.0000012 17.467001,1.0000012L6.4360008,1.0000012C3.4380004,1.0000012,1.0000002,3.4210042,1.0000002,6.3970079L1.0000002,20.617026C1.0000002,20.893025 0.77600026,21.117026 0.50000048,21.117026 0.22400022,21.117026 2.3841858E-07,20.893025 0,20.617026L0,6.3970079C2.3841858E-07,2.8700035,2.8870004,0,6.4360008,0z"
+            Geometry="M 0.814453 2e-6 C 0.365092 -7.56e-4 3.21e-4 0.36314 0 0.812502 v 23.945313 c 0.788895 1.126154 1.626953 -0.02112 1.626953 -0.02112 V 1.625002 h 16.241843 c 0 0 0.80538 -0.934678 -0.124651 -1.625002 z M 3.750875 3.43624 C 3.301514 3.435482 2.936743 3.799378 2.936422 4.24874 v 23.945313 c -7.6e-4 0.450124 0.364329 0.815213 0.814453 0.814453 h 7.439453 C 11.042745 28.716852 10.90913 28.418337 10.789937 28.113975 10.699431 27.872971 10.617994 27.628659 10.545796 27.381553 H 4.563375 V 5.06124 h 15.304687 v 7.039063 c 0.173002 -0.01023 0.346234 -0.01609 0.519531 -0.01758 0.343731 -2.6e-4 0.68726 0.01669 1.029297 0.05078 0.02606 0.0038 0.0521 0.0077 0.07813 0.01172 V 4.248738 C 21.494699 3.799376 21.129928 3.43548 20.680567 3.436238 Z m 13.332031 6.884766 c -1.226661 0 -2.230469 1.002456 -2.230469 2.228516 v 9.572265 l -0.824219 -0.8125 v 0.002 c -0.991917 -0.9815 -2.60964 -0.982302 -3.603515 0 -0.48293 0.477155 -0.751953 1.119962 -0.751953 1.796875 0 0.67607 0.269215 1.317958 0.751953 1.794922 l 4.841797 4.78711 0.0078 0.0078 c 2.115591 1.851014 4.144077 2.322266 5.615234 2.322266 0.547268 0 1.017683 -0.06414 1.388672 -0.142578 1.701281 -0.360558 3.108561 -1.372782 3.751954 -2.75586 0.419048 -0.9011 0.978455 -2.062137 0.923828 -3.261718 4.09e-4 -0.01025 0.0011 -0.0075 0.002 -0.02344 0.0015 -0.02655 0.0039 -0.01047 0.0039 -0.07813 v -5.113281 c 0 -1.161114 -0.955476 -2.109375 -2.121094 -2.109375 -0.04803 0 -0.09044 0.0088 -0.136719 0.01172 -0.207784 -1.015547 -1.021531 -1.826172 -2.095703 -1.826172 -0.343265 0 -0.63914 0.145124 -0.93164 0.285156 -0.397916 -0.616533 -1.045784 -1.0625 -1.830078 -1.0625 -0.189487 0 -0.354735 0.07615 -0.53125 0.121094 v -3.515625 c 0 -1.22606 -1.003809 -2.228516 -2.230469 -2.228516 z m 0 1.699219 c 0.148476 0 0.278642 0.05997 0.375 0.15625 0.09685 0.09678 0.15625 0.225142 0.15625 0.373047 v 5.625 1.740234 c 0 0.464846 0.384763 0.849609 0.849609 0.849609 0.464527 0 0.84961 -0.383921 0.84961 -0.849609 v -1.740234 c 0 -0.148598 0.05896 -0.275762 0.15625 -0.373047 0.09729 -0.09729 0.228277 -0.158203 0.375 -0.158203 0.146722 0 0.277709 0.06091 0.375 0.158203 0.09729 0.09729 0.15625 0.224449 0.15625 0.373047 v 0.77539 0.4375 c 0 0.465373 0.384236 0.84961 0.849609 0.84961 0.465373 0 0.849609 -0.384239 0.849609 -0.84961 v -0.425781 l 0.0059 -0.06836 c 0.0286 -0.265146 0.249414 -0.472657 0.52539 -0.472657 0.148238 0 0.278481 0.05996 0.375 0.15625 0.09649 0.09627 0.15625 0.225145 0.15625 0.373047 v 1.935547 c 0 0.465371 0.384237 0.84961 0.84961 0.84961 0.465372 0 0.849609 -0.384237 0.849609 -0.84961 v -0.65039 c 0.0016 -9e-6 2.95e-4 0 0.002 0 0.238806 0 0.421875 0.185008 0.421875 0.410156 l 0.002 5.0625 c -4.64e-4 0.0084 -0.0023 0.0401 -0.0039 0.07227 -0.0015 0.03041 -0.0059 0.02687 -0.002 0.101563 0.03253 0.757506 -0.372777 1.677807 -0.765625 2.521484 h -0.002 c -0.194342 0.418116 -0.532821 0.810028 -0.976563 1.126953 -0.443595 0.316821 -0.990203 0.55925 -1.585937 0.685547 -0.515602 0.10823 -1.298166 0.179402 -2.248047 -0.03125 -0.47546 -0.105441 -0.991926 -0.281044 -1.539063 -0.560547 -0.547306 -0.279588 -1.127683 -0.66381 -1.724609 -1.185547 L 11.620061 23.69601 c -0.162198 -0.160763 -0.248047 -0.365899 -0.248047 -0.587891 0 -0.223284 0.08648 -0.426518 0.248047 -0.585937 0.168295 -0.166151 0.386826 -0.249911 0.607422 -0.25 0.220595 -9e-5 0.437432 0.08144 0.605469 0.248047 l 2.240234 2.207031 0.01367 0.02148 0.04687 0.03516 0.03711 0.0332 0.02539 0.01758 0.01563 0.01367 0.01563 0.0098 c 0.114637 0.07747 0.248043 0.126397 0.388672 0.140625 l -0.04883 -0.0078 0.04102 0.0098 0.08594 0.0039 h 0.0078 c 0.06844 0 0.126002 -0.0085 0.169922 -0.01758 l 0.0059 -0.002 0.01953 -0.0039 h 0.02539 l 0.06641 -0.02734 0.02734 -0.0098 0.0098 -0.0039 c 0.102105 -0.04223 0.198238 -0.105586 0.28125 -0.189454 h 0.002 c 0.163006 -0.165519 0.243191 -0.385955 0.242188 -0.599609 v -0.002 -0.01953 -11.580078 c 0 -0.147904 0.0594 -0.276271 0.15625 -0.373047 0.09636 -0.09628 0.226522 -0.15625 0.375 -0.15625 z"
           />
         </DrawingGroup.Children>
       </DrawingGroup>
@@ -1145,10 +1164,10 @@ M0,0L63.999001,0 63.999001,48.792999 0,48.792999z">
   </DrawingImage>
 
 
-  <!-- Pin 
+  <!-- Pin
         <Path Data="F1M3,11L3,7 0,7 0,6 1,6 1,1 1,0 6,0 6,1 6,6 7,6 7,7 4,7 4,11 3,11z M2,1L2,6 4,6 4,1 2,1z" />
-        Unpin 
+        Unpin
         <Path Data="F1M0,3L4,3 4,0 5,0 5,1 10,1 11,1 11,6 10,6 5,6 5,7 4,7 4,4 0,4 0,3z M10,2L5,2 5,4 10,4 10,2z" />
      -->
 
-</ResourceDictionary>   
+</ResourceDictionary>

src/client/spark/Modules/Market/MarketShellModule.cs

@@ -5,6 +5,7 @@ using mbts.co2;
 using mbts.persist;
 using mbts.spark;
 using mbts.ui;
+using mbts.ui.shell;
 using System.Collections.Generic;
 using System.ComponentModel.Composition;
 using System.IO;
@@ -18,7 +19,7 @@ namespace bts.shell
    class MarketShellModule : IShellModule
    {
       [ImportingConstructor]
-      public MarketShellModule(IBus bus, MDConsumer consumer, UserSettingsHub settings_hub, OrdersModel orders_model, [Import("username")]string user_name) {
+      public MarketShellModule(IBus bus, MDConsumer consumer, UserSettingsHub settings_hub, OrdersModel orders_model, [Import(LoginContainer.Exports.UserName)]string user_name) {
          _tsf = new TimeAndSalesWindowFactory(this, bus, consumer, settings_hub);
          _mvf = new MarketViewWindowFactory(this, bus, settings_hub, orders_model);
       }

src/client/spark/Modules/Market/MarketView/MarketViewRow.cs

@@ -36,6 +36,7 @@ namespace mbts.spark {
          readonly MyOrderSummarizer _order_summarizer = new MyOrderSummarizer();
          readonly MDDisplayHelper.SizeFormatter _size_formatter = MDDisplayHelper.get_formatter(MarketSizeDisplay.get_default());
          Property<uint> _bid_direct_size, _bid_merged_size, _ask_direct_size, _ask_merged_size;
+         double _raw_day_position;
          string _bid_merged_size_text, _ask_merged_size_text;
          ulong _bbo_ref, _last_ref;
 
@@ -89,6 +90,10 @@ namespace mbts.spark {
             _dispose = Disposable.Create(
                _orders_model.on_security_root_orders(security.Id).OnDispatcher().Subscribe(_on_orders),
                _position.OnDispatcher().Subscribe(v => _animation.animate_position(v.newval > v.oldval)),
+               _orders_model.on_security_positions(security.Id).OnDispatcher().Subscribe(t => {
+                  if (Set(ref _raw_day_position, t.state.Values.Sum(p => p.Item2.raw_day_pos()), nameof(raw_day_position)))
+                     raise_invalidated();
+               }),
                _inside_bids.OnDispatcher().Subscribe(v => _animation.animate_working_bids_inside(v.newval)),
                _inside_asks.OnDispatcher().Subscribe(v => _animation.animate_working_asks_inside(v.newval)),
                _day_change.OnDispatcher().Subscribe(v => _animation.animate_day_change(v.newval > v.oldval)),
@@ -102,6 +107,7 @@ namespace mbts.spark {
          public bool inside_bids => _inside_bids.value;
          public bool inside_asks => _inside_asks.value;
          public int position => _position.value;
+         public double raw_day_position => _raw_day_position;
          public double last_price => _last_price.Value;
          public uint last_size => _last_size.value;
          public double bid_price => _bid_price.Value;

src/client/spark/Modules/Market/MarketView/MarketViewVM.cs

@@ -10,7 +10,6 @@ using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Reactive.Linq;
-using System.Reactive.Subjects;
 using System.Windows.Data;
 using System.Windows.Media;
 using static bts.shell.MarketViewWindowFactory;
@@ -27,8 +26,8 @@ namespace mbts.spark {
          : this(bus, orders_model, state, state.SelectManyInSeries(s => s.security_criteria.subscribe_md(bus)), settings_manager) { }
 
       // securities_connectable should NOT be connected already.
-      MarketViewVM(IBus bus, OrdersModel orders_model, IObservable<StartupData> state, IConnectableObservable<IEnumerable<SecurityMD>> securities_connectable, IWindowSettingsManager<GridSettings> settings_manager)
-         : base(RXCollection.Create(securities_connectable, SecurityDataHelper.EqualityComparer.MDComparer), null) {
+      MarketViewVM(IBus bus, OrdersModel orders_model, IObservable<StartupData> state, IObservable<IEnumerable<SecurityMD>> securities_source, IWindowSettingsManager<GridSettings> settings_manager)
+         : base(RXCollection.Create(securities_source, SecurityDataHelper.EqualityComparer.MDComparer), null) {
          _bus = bus;
          _orders_model = orders_model;
          security_filter = new RegexFilterVM<Row>(r => r.security.ToString(), nameof(Row.security));
@@ -42,12 +41,13 @@ namespace mbts.spark {
          add_col(Columns.Last, "Last", r => r.format_price(r.last_price), nameof(Row.last_price), DefaultColumnWidths.Price, last_price_filter, DataGridFilterKnownTemplates.DoubleMinMax);
          add_col(Columns.LastSize, merged_size_col_header, r => r.last_size.ToString(), nameof(Row.last_size), DefaultColumnWidths.Size, last_size_filter, DataGridFilterKnownTemplates.UIntMinMax, h_alignment: System.Windows.HorizontalAlignment.Right);
          add_col(Columns.Position, "Pos", r => r.position.ToString(), nameof(Row.position), DefaultColumnWidths.Size, position_filter, DataGridFilterKnownTemplates.IntMinMax, true, h_alignment: System.Windows.HorizontalAlignment.Right);
+         add_col(Columns.RawDayPosition, "Raw Day Pos", r => SparkUtils.fmt_position(r.raw_day_position), nameof(Row.raw_day_position), DefaultColumnWidths.Size, raw_day_position_filter, DataGridFilterKnownTemplates.DoubleMinMax, true, h_alignment: System.Windows.HorizontalAlignment.Right);
          add_hl_working_orders_col(Columns.WorkingBids, working_col_header, nameof(Row.working_bids_text), nameof(Row.working_best_bid), nameof(Row.working_bids_click), working_bid_volume_filter, BTSColors.MarketData.bid, System.Windows.HorizontalAlignment.Right);
          add_col(Columns.BidImpliedSize, implied_size_col_header, r => r.bid_implied_size.ToString(), nameof(Row.bid_implied_size), DefaultColumnWidths.ImpliedDirectMergedSize, bid_implied_size_filter, DataGridFilterKnownTemplates.UIntMinMax, font_color: BTSColors.MarketData.bid, h_alignment: System.Windows.HorizontalAlignment.Right);
          add_col(Columns.BidDirectSize, direct_size_col_header, r => r.bid_direct_size.ToString(), nameof(Row.bid_direct_size), DefaultColumnWidths.ImpliedDirectMergedSize, bid_direct_size_filter, DataGridFilterKnownTemplates.UIntMinMax, font_color: BTSColors.MarketData.bid, h_alignment: System.Windows.HorizontalAlignment.Right);
          add_hl_merged_size_col(Columns.BidMergedSize, merged_size_col_header, nameof(Row.bid_merged_size), nameof(Row.bid_merged_size_text), nameof(Row.bid_merged_size_click), bid_merged_size_filter, BTSColors.MarketData.bid, h_alignment: System.Windows.HorizontalAlignment.Right);
-         add_hl_price_col(Columns.Bid, "Bid", nameof(Row.bid_price), nameof(Row.bid_price_click), bid_price_filter, BTSColors.header_text, BTSColors.MarketData.bid_brush, h_alignment: System.Windows.HorizontalAlignment.Right);
-         add_hl_price_col(Columns.Ask, "Ask", nameof(Row.ask_price), nameof(Row.ask_price_click), ask_price_filter, BTSColors.header_text, BTSColors.MarketData.ask_brush, h_alignment: System.Windows.HorizontalAlignment.Right);
+         add_hl_price_col(Columns.Bid, "Bid", nameof(Row.bid_price), nameof(Row.bid_price_click), bid_price_filter, BTSColors.header_text, BTSColors.MarketData.bid, h_alignment: System.Windows.HorizontalAlignment.Right);
+         add_hl_price_col(Columns.Ask, "Ask", nameof(Row.ask_price), nameof(Row.ask_price_click), ask_price_filter, BTSColors.header_text, BTSColors.MarketData.ask, h_alignment: System.Windows.HorizontalAlignment.Right);
          add_hl_merged_size_col(Columns.AskMergedSize, merged_size_col_header, nameof(Row.ask_merged_size), nameof(Row.ask_merged_size_text), nameof(Row.ask_merged_size_click), ask_merged_size_filter, BTSColors.MarketData.ask, h_alignment: System.Windows.HorizontalAlignment.Right);
          add_col(Columns.AskDirectSize, direct_size_col_header, r => r.ask_direct_size.ToString(), nameof(Row.ask_direct_size), DefaultColumnWidths.ImpliedDirectMergedSize, ask_direct_size_filter, DataGridFilterKnownTemplates.UIntMinMax, font_color: BTSColors.MarketData.ask, h_alignment: System.Windows.HorizontalAlignment.Right);
          add_col(Columns.AskImpliedSize, implied_size_col_header, r => r.ask_implied_size.ToString(), nameof(Row.ask_implied_size), DefaultColumnWidths.ImpliedDirectMergedSize, ask_implied_size_filter, DataGridFilterKnownTemplates.UIntMinMax, font_color: BTSColors.MarketData.ask, h_alignment: System.Windows.HorizontalAlignment.Right);
@@ -77,18 +77,18 @@ namespace mbts.spark {
                horizontal_alignment = h_alignment
             });
 
-         void add_hl_price_col(Columns col_key, string header, string prop, string command_prop, IDataGridColumnFilter filter, Color foreground, Brush background, System.Windows.HorizontalAlignment h_alignment) =>
-            add_hl_col(col_key, header, price_binding(prop), prop, command_prop, filter, DataGridFilterKnownTemplates.DoubleMinMax, DefaultColumnWidths.MViewPrice, foreground, background, DefaultSelectionHighlight, h_alignment);
+         void add_hl_price_col(Columns col_key, string header, string prop, string command_prop, IDataGridColumnFilter filter, Color foreground, Color? background, System.Windows.HorizontalAlignment h_alignment) =>
+            add_hl_col(col_key, header, price_binding(prop), prop, command_prop, filter, DataGridFilterKnownTemplates.DoubleMinMax, DefaultColumnWidths.MViewPrice, foreground, background, h_alignment);
 
          void add_hl_merged_size_col(Columns col_key, string header, string sort_prop, string text_prop, string command_prop, IDataGridColumnFilter filter, Color foreground, System.Windows.HorizontalAlignment h_alignment) =>
-            add_hl_col(col_key, header, new Binding(text_prop), sort_prop, command_prop, filter, DataGridFilterKnownTemplates.UIntMinMax, DefaultColumnWidths.ImpliedDirectMergedSize, foreground, null, null, h_alignment);
+            add_hl_col(col_key, header, new Binding(text_prop), sort_prop, command_prop, filter, DataGridFilterKnownTemplates.UIntMinMax, DefaultColumnWidths.ImpliedDirectMergedSize, foreground, null, h_alignment);
 
          void add_hl_working_orders_col(Columns col_key, string header, string text_prop, string sort_prop, string command_prop, IDataGridColumnFilter filter, Color foreground, System.Windows.HorizontalAlignment h_alignment) =>
-            add_hl_col(col_key, header, new Binding(text_prop), sort_prop, command_prop, filter, DataGridFilterKnownTemplates.IntMinMax, working_orders_col_width, foreground, null, null, h_alignment);
+            add_hl_col(col_key, header, new Binding(text_prop), sort_prop, command_prop, filter, DataGridFilterKnownTemplates.IntMinMax, working_orders_col_width, foreground, null, h_alignment);
 
          void add_hl_col(
             Columns col_key, string header, BindingBase binding, string prop, string command_prop,
-            IDataGridColumnFilter filter, string filter_template, double width, Color foreground, Brush background, Brush background_overlay, System.Windows.HorizontalAlignment h_alignment = System.Windows.HorizontalAlignment.Left) =>
+            IDataGridColumnFilter filter, string filter_template, double width, Color foreground, Color? background, System.Windows.HorizontalAlignment h_alignment = System.Windows.HorizontalAlignment.Left) =>
          columns.Add(new HyperlinkElementColumn<Row, Columns>(
             col_key, binding, new Binding(command_prop), filter, filter_template) {
             // it's necessary to have this id populated for grid settings
@@ -96,8 +96,7 @@ namespace mbts.spark {
             Header = header,
             sort_member_path = prop,
             font_color_override = foreground,
-            background = background,
-            background_overlay = background_overlay,
+            background_color_override = background,
             Width = DefaultColumnWidths.Price,
             horizontal_alignment = h_alignment
          });
@@ -111,14 +110,8 @@ namespace mbts.spark {
          //
          // make font-color immutable for Side, Size, (the font-color rule is hard-coded: MarketData.bid for Buy orders, MarketData.ask for Sells)
          var col_settings_flags = new Dictionary<string, GridColumnSettingsFeatureFlags> {
-            { Columns.Bid.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
-            { Columns.Ask.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
-            { Columns.BidImpliedSize.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
-            { Columns.BidDirectSize.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
-            { Columns.BidMergedSize.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
-            { Columns.AskImpliedSize.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
-            { Columns.AskDirectSize.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
-            { Columns.AskMergedSize.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
+            { Columns.Bid.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor | GridColumnSettingsFeatureFlags.ImmutableBackgroundColor },
+            { Columns.Ask.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor | GridColumnSettingsFeatureFlags.ImmutableBackgroundColor},
             { Columns.WorkingAsks.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor },
             { Columns.WorkingBids.ToString(), GridColumnSettingsFeatureFlags.ImmutableFontColor }
          };
@@ -151,6 +144,7 @@ namespace mbts.spark {
                      session_low_filter.load_state(filters.session_low);
                      session_high_filter.load_state(filters.session_high);
                      position_filter.load_state(filters.position);
+                     raw_day_position_filter.load_state(filters.raw_day_position);
                      working_bid_volume_filter.load_state(filters.working_bid_volume);
                      working_ask_volume_filter.load_state(filters.working_ask_volume);
                      volume_filter.load_state(filters.volume);
@@ -162,8 +156,7 @@ namespace mbts.spark {
             bid_price_filter, bid_merged_size_filter, bid_direct_size_filter, bid_implied_size_filter,
             ask_price_filter, ask_merged_size_filter, ask_direct_size_filter, ask_implied_size_filter,
             last_price_filter, last_size_filter, day_change_filter, settlement_filter,
-            session_low_filter, session_high_filter, position_filter, working_bid_volume_filter, working_ask_volume_filter, volume_filter, security_key_filter),
-            securities_connectable.Connect(),
+            session_low_filter, session_high_filter, position_filter, raw_day_position_filter, working_bid_volume_filter, working_ask_volume_filter, volume_filter, security_key_filter),
             settings_manager.subscribe_current().OnDispatcher().Subscribe(grid_settings_manager),
             WorkLoop.Start("MarketView", _refresh)
          );
@@ -231,6 +224,7 @@ namespace mbts.spark {
       public IDataGridColumnPersistentFilter<Row, DoubleMinMaxState> session_low_filter { get; } = new DoubleMinMax<Row>(r => r.session_low, nameof(Row.session_low));
       public IDataGridColumnPersistentFilter<Row, DoubleMinMaxState> session_high_filter { get; } = new DoubleMinMax<Row>(r => r.session_high, nameof(Row.session_high));
       public IDataGridColumnPersistentFilter<Row, IntMinMaxState> position_filter { get; } = new IntMinMax<Row>(r => r.position, nameof(Row.position));
+      public IDataGridColumnPersistentFilter<Row, DoubleMinMaxState> raw_day_position_filter { get; } = new DoubleMinMax<Row>(r => r.raw_day_position, nameof(Row.raw_day_position));
       public IDataGridColumnPersistentFilter<Row, IntMinMaxState> working_bid_volume_filter { get; } = new IntMinMax<Row>(r => r.working_bid_volume, nameof(Row.working_bid_volume));
       public IDataGridColumnPersistentFilter<Row, IntMinMaxState> working_ask_volume_filter { get; } = new IntMinMax<Row>(r => r.working_ask_volume, nameof(Row.working_ask_volume));
       public IDataGridColumnPersistentFilter<Row, ULongMinMaxState> volume_filter { get; } = new ULongMinMax<Row>(r => r.volume, nameof(Row.volume));
@@ -262,6 +256,7 @@ namespace mbts.spark {
             session_low = session_low_filter.get_state(),
             session_high = session_high_filter.get_state(),
             position = position_filter.get_state(),
+            raw_day_position = raw_day_position_filter.get_state(),
             working_bid_volume = working_bid_volume_filter.get_state(),
             working_ask_volume = working_ask_volume_filter.get_state(),
             volume = volume_filter.get_state(),

src/client/spark/Modules/Market/MarketView/MarketViewView.xaml.cs

@@ -8,8 +8,34 @@ namespace mbts.ui.spark {
    /// Interaction logic for MarketSheetsView.xaml
    /// </summary>
    partial class MarketViewView : UserControl {
-      public enum Columns { Security, Volume, Last, LastSize, Position, WorkingBids, Bid, BidMergedSize, BidDirectSize, BidImpliedSize, Ask, AskMergedSize, AskDirectSize, AskImpliedSize, WorkingAsks, Settlement, DayChange, SessionLow, SessionHigh, SecurityKey,
-         MarketDescription, ClearedAlias, ProductDescription, HubAlias, StripName, MicCode
+      public enum Columns {
+         Security,
+         Volume,
+         Last,
+         LastSize,
+         Position,
+         RawDayPosition,
+         WorkingBids,
+         Bid,
+         BidMergedSize,
+         BidDirectSize,
+         BidImpliedSize,
+         Ask,
+         AskMergedSize,
+         AskDirectSize,
+         AskImpliedSize,
+         WorkingAsks,
+         Settlement,
+         DayChange,
+         SessionLow,
+         SessionHigh,
+         SecurityKey,
+         MarketDescription,
+         ClearedAlias,
+         ProductDescription,
+         HubAlias,
+         StripName,
+         MicCode
       }
 
       public MarketViewView() {

src/client/spark/Modules/Market/MarketView/MarketViewWindow.cs

@@ -7,6 +7,7 @@ using bts.utils;
 using mbts.persist;
 using mbts.ui;
 using mbts.ui.settings;
+using mbts.ui.shell;
 using mbts.ui.spark;
 using mbts.ui.utility;
 using mbts.utils;
@@ -32,7 +33,7 @@ namespace mbts.spark {
          _selected_security_criteria_backing,
          _sorted_selected_security_criteria_backing;
 
-      public MarketViewWindow(MarketViewWindowFactory factory, IBus bus, OrdersModel orders_model, MarketViewWindowFactory.StartupData state, WindowSettingsManager<GridSettings> settings_manager)
+      public MarketViewWindow(MarketViewWindowFactory factory, IBus bus, OrdersModel orders_model, MarketViewWindowFactory.StartupData state, IWindowSettingsManager<GridSettings> settings_manager)
          : base("Market View", bus, factory, SparkCommands.ShowMarketView.icon) {
          _orders_model = orders_model;
          _state = state;
@@ -135,6 +136,7 @@ namespace mbts.spark {
          var show_synth_create_cmd_wrapper = new SparkCommandCommand(show_synth_create_actual_cmd.title, show_synth_create_actual_cmd.icon, show_synth_create_cmd, SparkCommands.KeyGestures.ShowSyntheticCreate);
 
          var update_securities_cmd = SparkCommands.change_securities_callback(_window_type_display_name);
+         // commands
          _commands = new List<SparkCommand> {
             SparkCommands.ShowLadders(SparkCommands.KeyGestures.ShowLadder).complete(_vm.selected_security_mds_observable(), smds => smds.Count > 0),
             SparkCommands.ShowOrderTicketFromSecurity(SparkCommands.KeyGestures.ShowOrderTicket).complete(_vm.current_security_md, md => md.HasValue, ConvertUtils.ValueOrDefault),
@@ -144,19 +146,18 @@ namespace mbts.spark {
             SparkCommands.change_securities_command(() => (update_securities_cmd, _state.security_criteria)),
             // wrap the grid settings view factory in a dialogCommand here since the vm is destroyed/recreated when the security criteria changes
             SparkCommands.window_settings_command(new DialogCommand(() => {
-               var vm = new WindowSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
+               var vm = new ShellSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
                   _settings_manager,
                   us => us.market_view_grid,
                   UserSettings.FileExtensions.GRID,
                   s => _vm.grid_settings_manager.create_vm(
                      // we need to get the most up to date GridSettings when launching b/c users may
                      // have changed some settings on the grid directly, like column widths.
-                     s.with(_vm.columns.Select( c => c.create())), 
-                     this.observe_title()
+                     s.with(_vm.columns.Select(c => c.create()))
                   )
                );
-               // TODO: bind to main window's Title
-               var dialog = new SimpleGridSettingsDialog { Title = "Market View Grid Settings", DataContext = vm };
+               vm.SubscribeDisposed(literal_title_source.OnDispatcher().Subscribe(t => vm.title = t));
+               var dialog = new ShellSettingsDialog { DataContext = vm };
                vm.RequestClose += (s, e) => WindowUtilities.force_close(dialog);
                return dialog;
             }))

src/client/spark/Modules/Market/MarketView/MarketViewWindowFactory.cs

@@ -1,4 +1,6 @@
 using bts.api;
+using bts.proto;
+using bts.settings;
 using mbts.persist;
 using mbts.spark;
 using mbts.spark.filters;
@@ -7,6 +9,7 @@ using mbts.ui.settings;
 using ProtoBuf;
 using System;
 using System.Collections.Generic;
+using System.ComponentModel.Composition;
 using System.Linq;
 using System.Reactive.Linq;
 using System.Threading.Tasks;
@@ -35,13 +38,8 @@ namespace bts.shell {
       void _show(SecurityCriteria criteria) =>
          _bus.post(SparkTags.ShowWindow, _create(StartupData.Default(criteria)));
 
-      IShellWindow _create(StartupData state) {
-         var settings_manager = new WindowSettingsManager<GridSettings>(_settings_hub, 
-            state.grid, 
-            get: us => us.market_view_grid, 
-            set: (us, gs) => us.with(provided_market_view_gridsettings: gs));
-         return new MarketViewWindow(this, _bus, _orders_model, state, settings_manager);
-      }
+      IShellWindow _create(StartupData state) =>
+         new MarketViewWindow(this, _bus, _orders_model, state, _settings_hub.create_mview_settings_manager(state.grid));
 
       [ProtoContract]
       public class StartupData {
@@ -68,7 +66,29 @@ namespace bts.shell {
             _sorting_criteria = sort;
          }
 
-         public static GridSettings DefaultGridSettings => GridSettings.Default.with(DefaultColumns.all, DefaultColumns.default_sorting_criterion);
+         public static GridSettings sanitize(GridSettings s) {
+            if (s == null) {
+               return null;
+            }
+
+            // column upgrade
+            var columns = s.columns.ToList();
+            var bid_col_index = columns.FindIndex(x => x.id == col_id(Columns.Bid));
+            var ask_col_index = columns.FindIndex(x => x.id == col_id(Columns.Ask));
+            if (bid_col_index > -1 && ask_col_index > -1) {
+               if (!columns[bid_col_index].background_color_override.HasValue) {
+                  columns[bid_col_index] = columns[bid_col_index].with(background_color_override: new NullableColorProto(BTSColors.MarketData.bid.ToUint()));
+               }
+               if (!columns[ask_col_index].background_color_override.HasValue) {
+                  columns[ask_col_index] = columns[ask_col_index].with(background_color_override: new NullableColorProto(BTSColors.MarketData.ask.ToUint()));
+               }
+            }
+            // and enable background color upgrade
+            return s.with(columns, enable_background_color: true);
+         }
+
+
+         public static GridSettings DefaultGridSettings => GridSettings.Default.with(DefaultColumns.all, DefaultColumns.default_sorting_criterion, enable_background_color: true);
 
          public IReadOnlyList<SortingCriteria> sorting_criterion => _sorting_criteria ?? (_sorting_criteria = DefaultColumns.default_sorting_criterion.ToList());
 
@@ -82,12 +102,13 @@ namespace bts.shell {
             public static GridColumnSettings last => new GridColumnSettings(col_id(Columns.Last), DefaultColumnHeaders.Last, width: DefaultColumnWidths.Price);
             public static GridColumnSettings last_size => new GridColumnSettings(col_id(Columns.LastSize), DefaultColumnHeaders.Size, width: DefaultColumnWidths.Size, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
             public static GridColumnSettings position => new GridColumnSettings(col_id(Columns.Position), DefaultColumnHeaders.Pos, width: DefaultColumnWidths.Size, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
+            public static GridColumnSettings raw_day_position => new GridColumnSettings(col_id(Columns.RawDayPosition), DefaultColumnHeaders.RawDayPos, width: DefaultColumnWidths.Size, horizontal_alignment: System.Windows.HorizontalAlignment.Right, is_visible: false);
             public static GridColumnSettings working_bids => new GridColumnSettings(col_id(Columns.WorkingBids), DefaultColumnHeaders.Working, font_color_override: BTSColors.MarketData.bid, width: DefaultColumnWidths.Working, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
             public static GridColumnSettings bid_implied_size => new GridColumnSettings(col_id(Columns.BidImpliedSize), DefaultColumnHeaders.ImpliedSize, font_color_override: BTSColors.MarketData.bid, width: DefaultColumnWidths.ImpliedDirectMergedSize, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
             public static GridColumnSettings bid_direct_size => new GridColumnSettings(col_id(Columns.BidDirectSize), DefaultColumnHeaders.DirectSize, font_color_override: BTSColors.MarketData.bid, width: DefaultColumnWidths.ImpliedDirectMergedSize, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
             public static GridColumnSettings bid_merged_size => new GridColumnSettings(col_id(Columns.BidMergedSize), DefaultColumnHeaders.MergedSize, font_color_override: BTSColors.MarketData.bid, width: DefaultColumnWidths.ImpliedDirectMergedSize, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
-            public static GridColumnSettings bid => new GridColumnSettings(col_id(Columns.Bid), DefaultColumnHeaders.Bid, font_color_override: BTSColors.header_text, width:DefaultColumnWidths.MViewPrice, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
-            public static GridColumnSettings ask => new GridColumnSettings(col_id(Columns.Ask), DefaultColumnHeaders.Ask, font_color_override: BTSColors.header_text, width: DefaultColumnWidths.MViewPrice, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
+            public static GridColumnSettings bid => new GridColumnSettings(col_id(Columns.Bid), DefaultColumnHeaders.Bid, font_color_override: BTSColors.header_text, width:DefaultColumnWidths.MViewPrice, horizontal_alignment: System.Windows.HorizontalAlignment.Right, background_color_override: BTSColors.MarketData.bid);
+            public static GridColumnSettings ask => new GridColumnSettings(col_id(Columns.Ask), DefaultColumnHeaders.Ask, font_color_override: BTSColors.header_text, width: DefaultColumnWidths.MViewPrice, horizontal_alignment: System.Windows.HorizontalAlignment.Right, background_color_override: BTSColors.MarketData.ask);
             public static GridColumnSettings ask_merged_size => new GridColumnSettings(col_id(Columns.AskMergedSize), DefaultColumnHeaders.MergedSize, font_color_override: BTSColors.MarketData.ask, width: DefaultColumnWidths.ImpliedDirectMergedSize, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
             public static GridColumnSettings ask_direct_size => new GridColumnSettings(col_id(Columns.AskDirectSize), DefaultColumnHeaders.DirectSize, font_color_override: BTSColors.MarketData.ask, width: DefaultColumnWidths.ImpliedDirectMergedSize, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
             public static GridColumnSettings ask_implied_size => new GridColumnSettings(col_id(Columns.AskImpliedSize), DefaultColumnHeaders.ImpliedSize, font_color_override: BTSColors.MarketData.ask, width: DefaultColumnWidths.ImpliedDirectMergedSize, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
@@ -119,6 +140,7 @@ namespace bts.shell {
                   yield return last;
                   yield return last_size;
                   yield return position;
+                  yield return raw_day_position;
                   yield return working_bids;
                   yield return bid_implied_size;
                   yield return bid_direct_size;
@@ -173,6 +195,8 @@ namespace bts.shell {
          public DoubleMinMaxState session_high;
          [ProtoMember(12)]
          public IntMinMaxState position;
+         [ProtoMember(27)]
+         public DoubleMinMaxState raw_day_position;
          [ProtoMember(13)]
          public IntMinMaxState working_bid_volume;
          [ProtoMember(14)]
@@ -202,5 +226,46 @@ namespace bts.shell {
          [ProtoMember(26)]
          public string mic_code;
       }
+
+      // migration rules
+      [Export(typeof(IMarketViewGridSettingsMigrationRule))]
+      class AddMissingColumnsMigrationRule : IMarketViewGridSettingsMigrationRule {
+         public bool apply(GridSettings settings, out GridSettings new_settings) =>
+            settings.add_missing_columns(StartupData.DefaultGridSettings.columns, out new_settings);
+      }
+
+      [Export(typeof(IMarketViewGridSettingsMigrationRule))]
+      class InitBidAskBackgroundOverrideMigrationRule : IMarketViewGridSettingsMigrationRule {
+         public bool apply(GridSettings s, out GridSettings new_settings) {
+            var columns = s.columns.ToList();
+            var bid_col_index = columns.FindIndex(x => x.id == col_id(Columns.Bid));
+            var ask_col_index = columns.FindIndex(x => x.id == col_id(Columns.Ask));
+            bool applied = false;
+            if (bid_col_index > -1 && ask_col_index > -1) {
+               if (!columns[bid_col_index].background_color_override.HasValue) {
+                  columns[bid_col_index] = columns[bid_col_index].with(background_color_override: new NullableColorProto(BTSColors.MarketData.bid.ToUint()));
+                  applied = true;
+               }
+               if (!columns[ask_col_index].background_color_override.HasValue) {
+                  columns[ask_col_index] = columns[ask_col_index].with(background_color_override: new NullableColorProto(BTSColors.MarketData.ask.ToUint()));
+                  applied = true;
+               }
+            }
+            new_settings = applied ? s.with(columns) : default;
+            return applied;
+         }
+      }
+
+      [Export(typeof(IMarketViewGridSettingsMigrationRule))]
+      class InitBackgroundOverrideMigrationRule : IMarketViewGridSettingsMigrationRule {
+         public bool apply(GridSettings settings, out GridSettings new_settings) {
+            if (!settings.enable_background_color) {
+               new_settings = settings.with(enable_background_color: true);
+               return true;
+            }
+            new_settings = default;
+            return false;
+         }
+      }
    }
-}
+}

src/client/spark/Modules/Market/TimeAndSales/TimeAndSalesModel.cs

@@ -7,16 +7,6 @@ using System.Linq;
 using System.Reactive.Linq;
 
 namespace mbts.spark {
-   struct TradeInfo {
-      public readonly SecurityImmutable security;
-      public readonly TradeMessageImmutable trade;
-
-      public TradeInfo(SecurityImmutable security, TradeMessageImmutable trade) {
-         this.security = security;
-         this.trade = trade;
-      }
-   }
-
    class TimeAndSalesModel : IDisposable {
       internal readonly SecurityCriteria security_criteria;
 

src/client/spark/Modules/Market/TimeAndSales/TimeAndSalesVM.cs

@@ -49,13 +49,8 @@ namespace mbts.spark {
          add_column(TimeAndSalesView.Columns.Aggressor, DefaultColumnHeaders.Aggressor, DefaultColumnWidths.Aggressor, nameof(Row.aggressor_side), aggressor_filter, DataGridFilterKnownTemplates.EnumValues);
          add_column(TimeAndSalesView.Columns.SecurityKey, DefaultColumnHeaders.SecurityKey, DefaultColumnWidths.SecurityKey, nameof(Row.security_key), security_key_filter, DataGridFilterKnownTemplates.Regex);
          void add_column(TimeAndSalesView.Columns col_key, string header, double width, string sort_member_path, IDataGridColumnFilter filter, string filter_template, System.Windows.HorizontalAlignment h_alignment = System.Windows.HorizontalAlignment.Left) =>
-            columns.Add(new TimeAndSalesColumn(
-               col_key
-               , (r) => _get_aggressor_brush(r)
-               , filter
-               , filter_template
-            ) 
-            { Header = header, Width = width, sort_member_path = sort_member_path, horizontal_alignment = h_alignment  }
+            columns.Add(new RenderTextColumn<Row, TimeAndSalesView.Columns>(col_key, r => r[col_key], filter, filter_template, r => _get_aggressor_brush(r))
+            { id = col_id(col_key), Header = header, Width = width, sort_member_path = sort_member_path, horizontal_alignment = h_alignment  }
          );
          
          // be sure to load GridSettings AFTER the columns collection has been populated, the grid settings manager looks columns by id to apply the appropriate settings,
@@ -142,7 +137,7 @@ namespace mbts.spark {
          public Row(TimeAndSalesVM parent, SecurityImmutable security, TradeMessageImmutable trade) : base(security) {
             _trade_key = trade.Key;
             time = ((ulong)trade.Time).lldatetime().ToLocalTime();
-            price = trade.Mantissa * Math.Pow(10, trade.Exponent);
+            price = trade.price();
             size = trade.Size;
             aggressor_side = trade.AggressorSide;
             show_ladder = new DelegateCommand(() => parent._show_ladder_async(this).ignore());

src/client/spark/Modules/Market/TimeAndSales/TimeAndSalesWindow.cs

@@ -7,6 +7,7 @@ using mbts.co2;
 using mbts.persist;
 using mbts.ui;
 using mbts.ui.settings;
+using mbts.ui.shell;
 using mbts.ui.spark;
 using mbts.ui.utility;
 using mbts.utils;
@@ -17,7 +18,6 @@ using System.Reactive.Linq;
 using System.Windows;
 using System.Windows.Media;
 using static bts.shell.TimeAndSalesWindowFactory;
-using static mbts.ui.controls.DIYGrid;
 
 namespace mbts.spark {
    class TimeAndSalesWindow : SparkWindow<StartupData>, ISharedWindow {
@@ -70,19 +70,18 @@ namespace mbts.spark {
             SparkCommands.change_securities_command(() => (update_securities_cmd, _state.security_criteria)),
             // wrap the grid settings view factory in a dialogCommand here since the vm is destroyed/recreated when the security criteria changes
             SparkCommands.window_settings_command(new DialogCommand(() => {
-                   var vm = new WindowSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
+                   var vm = new ShellSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
                   _settings_manager,
                   s => s.time_and_sales_grid,
                   UserSettings.FileExtensions.GRID,
                   s => _vm.value.grid_settings_manager.create_vm(
                      // we need to get the most up to date GridSettings when launching b/c users may
                      // have changed some settings on the grid directly, like column widths.
-                     s.with(_vm.value.columns.Select( c => c.create())),
-                     this.observe_title()
+                     s.with(_vm.value.columns.Select(c => c.create()))
                   )
                );
-               // TODO: bind to main window's Title
-               var dialog = new SimpleGridSettingsDialog { Title = "Time and Sales Grid Settings", DataContext = vm };
+               vm.SubscribeDisposed(literal_title_source.OnDispatcher().Subscribe(t => vm.title = t));
+               var dialog = new ShellSettingsDialog { DataContext = vm };
                vm.RequestClose += (s, e) => WindowUtilities.force_close(dialog);
                return dialog;
             }))

src/client/spark/Modules/Settings/SettingsShellModule.cs

@@ -26,7 +26,10 @@ namespace bts.ui {
       public SettingsShellModule(IBus bus, UserSettingsHub settings_hub, WorkspacesModel ws) {
          // todo: settings dialog
          ws_model = ws;
-         var actions_list = new List<SparkCommand>(2) { SparkCommands.ShowWorkspaces };
+         var actions_list = new List<SparkCommand>(2) {
+            SparkCommands.ShowGlobalAlerts,
+            SparkCommands.ShowWorkspaces
+         };
          if (Configuration.get<bts.config.toggles.ToastNotifications>().enabled) {
             actions_list.Add(SparkCommands.ShowSettings);
          }

src/client/spark/Modules/Spreader/ExecutionStrategyEditor.xaml

@@ -59,6 +59,7 @@
     MarketDataTypeTemplate="{StaticResource SimpleValueTextTemplate}"
     MarketDataCalculationTemplate="{StaticResource SimpleValueTextTemplate}"
     ConditionalPriceTypeTemplate="{StaticResource SimpleValueTextTemplate}"
+    ShowQuantityTemplate="{StaticResource SimpleValueTextTemplate}"
   >
     <usp:DataGridParameterCellTemplateConverter.BooleanTemplate>
       <DataTemplate>
@@ -115,6 +116,16 @@
         <c:TickUpDownUInt Value="{Binding value}" IsEnabled="{Binding enabled}"/>
       </DataTemplate>
     </usp:DataGridParameterCellTemplateConverter.UIntTemplate>
+    <usp:DataGridParameterCellTemplateConverter.ShowQuantityTemplate>
+      <DataTemplate>
+        <!-- Note: the motivation for this Template was to enforce a Minimum via the TickUpDownUInt -->
+        <!-- As of 2019/06/17, we believe such a Minimum/Maximum is not actually getting enforced and -->
+        <!-- furthermore is not the appropriate way to go about enforcing said value. It is near the end -->
+        <!-- of the cycle though so that is why we are leaving this Template in here for now until we -->
+        <!-- can come up with a better solution. -->
+        <c:TickUpDownUInt Value="{Binding value}" IsEnabled="{Binding enabled}" />
+      </DataTemplate>
+    </usp:DataGridParameterCellTemplateConverter.ShowQuantityTemplate>
     <usp:DataGridParameterCellTemplateConverter.MarketDataTypeTemplate>
       <DataTemplate>
         <ComboBox SelectedItem="{Binding value}" ItemsSource="{u:EnumBindingSource {u:Nested sp:LegSpreaderParams.Types.MarketDataType}}" ItemTemplate="{StaticResource EnumDescriptionTemplate}"/>
@@ -363,6 +374,72 @@
       Height="{TemplateBinding Height}"
       Padding="{TemplateBinding Padding}"
     >
+      <Border.Resources>
+        <!--Leg Count States-->
+        <sys:String x:Key="LegCountStates">LegCountStates</sys:String>
+        <sys:String x:Key="LegCountStates.TwoOrFewer">TwoOrFewerLegsState</sys:String>
+        <sys:String x:Key="LegCountStates.ThreeOrMore">ThreeOrMoreLegsState</sys:String>
+        <cv:ValueConverterPipe x:Key="LegCountStateConverter">
+          <cv:IntGreaterThanConverter Value="2"/>
+          <cv:BooleanToObjectConverter ValueForFalse="{StaticResource LegCountStates.TwoOrFewer}" ValueForTrue="{StaticResource LegCountStates.ThreeOrMore}"/>
+        </cv:ValueConverterPipe>
+        <!--Persistance States-->
+        <sys:String x:Key="PersistanceStates">PersistanceStates</sys:String>
+        <sys:String x:Key="PersistanceStates.Unpersisted">UnpersistedState</sys:String>
+        <sys:String x:Key="PersistanceStates.Persisted">PersistedState</sys:String>
+        <cv:BooleanToObjectConverter x:Key="PersistanceStateConverter" ValueForFalse="{StaticResource PersistanceStates.Persisted}" ValueForTrue="{StaticResource PersistanceStates.Unpersisted}"/>
+      </Border.Resources>
+      <u:StateManager.Groups>
+        <u:StateGroupsManager AttachToMembers="True">
+          <u:StateDefinitionCollection>
+            <u:StateDefinition State="{Binding Group.Target.TemplatedParent.LegTuples.Count, RelativeSource={RelativeSource Self}, Converter={StaticResource LegCountStateConverter}}"/>
+            <u:StateDefinition State="{Binding Group.Target.TemplatedParent.IsNew, RelativeSource={RelativeSource Self}, Converter={StaticResource PersistanceStateConverter}}"/>
+          </u:StateDefinitionCollection>
+        </u:StateGroupsManager>
+      </u:StateManager.Groups>
+      <VisualStateManager.VisualStateGroups>
+        <VisualStateGroup Name="{StaticResource LegCountStates}">
+          <VisualState Name="{StaticResource LegCountStates.TwoOrFewer}"/>
+          <VisualState Name="{StaticResource LegCountStates.ThreeOrMore}">
+            <Storyboard>
+              <ObjectAnimationUsingKeyFrames Storyboard.TargetName="PART_HedgePricing_Label" Storyboard.TargetProperty="(UIElement.Visibility)">
+                <DiscreteObjectKeyFrame KeyTime="0" Value="{x:Static Visibility.Visible}"/>
+              </ObjectAnimationUsingKeyFrames>
+              <ObjectAnimationUsingKeyFrames Storyboard.TargetName="PART_HedgePricing_DropDown" Storyboard.TargetProperty="(UIElement.Visibility)">
+                <DiscreteObjectKeyFrame KeyTime="0" Value="{x:Static Visibility.Visible}"/>
+              </ObjectAnimationUsingKeyFrames>
+            </Storyboard>
+          </VisualState>
+        </VisualStateGroup>
+        <VisualStateGroup Name="{StaticResource PersistanceStates}">
+          <VisualState Name="{StaticResource PersistanceStates.Unpersisted}"/>
+          <VisualState Name="{StaticResource PersistanceStates.Persisted}">
+            <Storyboard>
+              <!--Name-->
+              <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Name_Label" Storyboard.TargetProperty="(UIElement.IsEnabled)">
+                <DiscreteBooleanKeyFrame KeyTime="0" Value="False"/>
+              </BooleanAnimationUsingKeyFrames>
+              <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Name_TextBox" Storyboard.TargetProperty="(UIElement.IsEnabled)">
+                <DiscreteBooleanKeyFrame KeyTime="0" Value="False"/>
+              </BooleanAnimationUsingKeyFrames>
+              <!--Tick Factors-->
+              <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_TickFactors_Label" Storyboard.TargetProperty="(UIElement.IsEnabled)">
+                <DiscreteBooleanKeyFrame KeyTime="0" Value="False"/>
+              </BooleanAnimationUsingKeyFrames>
+              <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_TickFactors_Picker" Storyboard.TargetProperty="(UIElement.IsEnabled)">
+                <DiscreteBooleanKeyFrame KeyTime="0" Value="False"/>
+              </BooleanAnimationUsingKeyFrames>
+              <!--Pricing-->
+              <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Pricing_Label" Storyboard.TargetProperty="(UIElement.IsEnabled)">
+                <DiscreteBooleanKeyFrame KeyTime="0" Value="False"/>
+              </BooleanAnimationUsingKeyFrames>
+              <BooleanAnimationUsingKeyFrames Storyboard.TargetName="PART_Pricing_DropDown" Storyboard.TargetProperty="(UIElement.IsEnabled)">
+                <DiscreteBooleanKeyFrame KeyTime="0" Value="False"/>
+              </BooleanAnimationUsingKeyFrames>
+            </Storyboard>
+          </VisualState>
+        </VisualStateGroup>
+      </VisualStateManager.VisualStateGroups>
       <Grid>
         <Grid.RowDefinitions>
           <RowDefinition Height="Auto"/>
@@ -377,8 +454,9 @@
             <ColumnDefinition Width="Auto"/>
             <ColumnDefinition Width="Auto"/>
             <ColumnDefinition Width="Auto"/>
+            <ColumnDefinition Width="Auto"/>
           </Grid.ColumnDefinitions>
-          <TextBlock VerticalAlignment="Center" IsEnabled="{TemplateBinding IsNew}">Name</TextBlock>
+          <TextBlock x:Name="PART_Name_Label" VerticalAlignment="Center" IsEnabled="{TemplateBinding IsNew}">Name</TextBlock>
           <TextBox
             x:Name="PART_Name_TextBox"
             Grid.Column="1"
@@ -397,20 +475,37 @@
             </u:Behavior.BindingUpdateGroups>
           </TextBox>
           <TextBlock
-            Grid.Column="2" VerticalAlignment="Center" Margin="{StaticResource Margin.LHeaderPanelItem}" Text="Ticks" IsEnabled="{TemplateBinding IsNew}"
+            x:Name="PART_TickFactors_Label"
+            Grid.Column="2"
+            VerticalAlignment="Center"
+            Margin="{StaticResource Margin.LHeaderPanelItem}"
+            Text="Ticks"
+            IsEnabled="True"
             Visibility="{Binding LegTuples.Count, RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource IntNotZeroVisibilityConverter}}"
           />
           <c:TickFactorsPicker
-            x:Name="PART_TickFactorsPicker" Grid.Column="3" Margin="{StaticResource Margin.LHeaderPanelItem}" IsEnabled="{TemplateBinding IsNew}" HorizontalAlignment="Stretch"
+            x:Name="PART_TickFactors_Picker"
+            Grid.Column="3"
+            Margin="{StaticResource Margin.LHeaderPanelItem}"
+            HorizontalAlignment="Stretch"
+            IsEnabled="True"
             SelectedTickFactors="{Binding TickFactors, RelativeSource={RelativeSource TemplatedParent}, Mode=TwoWay}"
             Visibility="{Binding LegTuples.Count, RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource IntNotZeroVisibilityConverter}}"
           />
-          <TextBlock Grid.Column="4" VerticalAlignment="Center" Margin="{StaticResource Margin.LHeaderPanelItem}" IsEnabled="{TemplateBinding IsNew}" >Pricing</TextBlock>
+          <TextBlock
+            x:Name="PART_Pricing_Label"
+            Grid.Column="4"
+            VerticalAlignment="Center"
+            Margin="{StaticResource Margin.LHeaderPanelItem}"
+            IsEnabled="True"
+            Text="Pricing"
+          />
           <ComboBox
+            x:Name="PART_Pricing_DropDown"
             Grid.Column="5"
             Margin="{StaticResource Margin.LHeaderPanelItem}"
             Width="90"
-            IsEnabled="{TemplateBinding IsNew}"
+            IsEnabled="True"
             ItemsSource="{x:Static usp:ExecutionStrategyEditor.PriceCalcItems}"
             SelectedItem="{Binding price_calc}"
           >
@@ -420,6 +515,24 @@
               </DataTemplate>
             </ComboBox.ItemTemplate>
           </ComboBox>
+          <TextBlock
+            Grid.Column="6"
+            x:Name="PART_HedgePricing_Label"
+            VerticalAlignment="Center"
+            Margin="{StaticResource Margin.LHeaderPanelItem}"
+            Text="Hedge"
+            Visibility="Collapsed"
+          />
+          <ComboBox
+            x:Name="PART_HedgePricing_DropDown"
+            Grid.Column="7"
+            HorizontalAlignment="Stretch"
+            Margin="{StaticResource Margin.LHeaderPanelItem}"
+            ItemsSource="{TemplateBinding HedgePricingItemsSource}"
+            ItemTemplate="{StaticResource EnumDescriptionTemplate}"
+            SelectedItem="{Binding HedgePricing, RelativeSource={RelativeSource TemplatedParent}}"
+            Visibility="Collapsed"
+          />
         </Grid>
         <c:DataGridEx
           x:Name="PART_DataGrid"

src/client/spark/Modules/Spreader/ExecutionStrategyEditor.xaml.cs

@@ -8,6 +8,7 @@ using mbts.ui.utility;
 using mbts.user.settings;
 using mbts.utils;
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Collections.Specialized;
@@ -183,6 +184,29 @@ namespace mbts.ui.spark {
       public mbts.spark.ContractPickerModel ContractPickerModel { get => GetValue(ContractPickerModelProperty) as mbts.spark.ContractPickerModel; set => SetValue(ContractPickerModelProperty, value); }
       #endregion
 
+      #region HedgePricingItemsSource
+      public static readonly DependencyProperty HedgePricingItemsSourceProperty =
+         WPFHelper.create_dp<IEnumerable, ExecutionStrategyEditor>(
+            nameof(HedgePricingItemsSource));
+
+      public IEnumerable HedgePricingItemsSource {
+         get => GetValue(HedgePricingItemsSourceProperty) as IEnumerable;
+         set => SetValue(HedgePricingItemsSourceProperty, value);
+      }
+      #endregion
+
+      #region HedgePricing
+      public static readonly DependencyProperty HedgePricingProperty =
+         WPFHelper.create_dp<object, ExecutionStrategyEditor>(
+            nameof(HedgePricing),
+            FrameworkPropertyMetadataOptions.BindsTwoWayByDefault);
+
+      public object HedgePricing {
+         get => GetValue(HedgePricingProperty);
+         set => SetValue(HedgePricingProperty, value);
+      }
+      #endregion
+
       public override void OnApplyTemplate() =>
          _connect_leg_tuples();
 
@@ -240,7 +264,7 @@ namespace mbts.ui.spark {
          FrameworkElement _generate_element(IValueConverter cell_template_converter) {
             var rv = new ContentControl();
             rv.SetBinding(ContentControl.ContentProperty, new Binding());
-            rv.SetBinding(ContentControl.ContentTemplateProperty, new Binding(nameof(ICell.data_type)) { Converter = cell_template_converter });
+            rv.SetBinding(ContentControl.ContentTemplateProperty, new Binding() { Converter = cell_template_converter });
             return rv;
          }
       }
@@ -251,7 +275,7 @@ namespace mbts.ui.spark {
 
          public ExecutionStrategyErrorAdorner(ExecutionStrategyEditor editor) : base(editor) {
             _name_text_box = child_property<TextBox>("PART_Name_TextBox");
-            _tick_factors_picker = child_property<TickFactorsPicker>("PART_TickFactorsPicker");
+            _tick_factors_picker = child_property<TickFactorsPicker>("PART_TickFactors_Picker");
          }
 
          protected override void OnRender(DrawingContext drawing_context) {
@@ -306,17 +330,23 @@ namespace mbts.ui.spark {
       public DataTemplate MarketDataTypeTemplate { get; set; }
       public DataTemplate MarketDataCalculationTemplate { get; set; }
       public DataTemplate ConditionalPriceTypeTemplate { get; set; }
+      public DataTemplate ShowQuantityTemplate { get; set; }
 
       public object Convert(object value, Type targetType, object parameter, CultureInfo culture) {
-         Type t = (Type)value;
-         if (t == typeof(double)) return DoubleTemplate;
-         else if (t == typeof(bool)) return BooleanTemplate;
-         else if (t == typeof(int)) return IntTemplate;
-         else if (t == typeof(uint)) return UIntTemplate;
-         else if (t == typeof(QuantityMeasure)) return QuantityMeasureTemplate;
-         else if (t == typeof(LegSpreaderParams.Types.MarketDataType)) return MarketDataTypeTemplate;
-         else if (t == typeof(ConditionalQuoting.Types.PriceType)) return ConditionalPriceTypeTemplate;
-         else return null;
+         if (value is ICell cell) {
+            if (cell.row is ShowQuantityQuantityModel) {
+               return ShowQuantityTemplate;
+            }
+            Type t = cell.data_type;
+            if (t == typeof(double)) return DoubleTemplate;
+            else if (t == typeof(bool)) return BooleanTemplate;
+            else if (t == typeof(int)) return IntTemplate;
+            else if (t == typeof(uint)) return UIntTemplate;
+            else if (t == typeof(QuantityMeasure)) return QuantityMeasureTemplate;
+            else if (t == typeof(LegSpreaderParams.Types.MarketDataType)) return MarketDataTypeTemplate;
+            else if (t == typeof(ConditionalQuoting.Types.PriceType)) return ConditionalPriceTypeTemplate;
+         }
+         return null;
       }
 
       public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture) =>

src/client/spark/Modules/Spreader/SpreaderModel.cs

@@ -1,6 +1,7 @@
 using bts.api;
 using bts.api.synthetic;
 using bts.spark;
+using mbts.ui.shell;
 using System;
 using System.Collections.Generic;
 using System.ComponentModel.Composition;
@@ -14,12 +15,14 @@ namespace mbts.spark {
       readonly IBus _bus;
       readonly SyntheticSecurityService _service;
       readonly ErrorReporter _error;
+      readonly uint _user_id;
 
       [ImportingConstructor]
-      public SpreaderModel(IBus bus, SyntheticSecurityService service, ErrorReporter error) {
+      public SpreaderModel(IBus bus, SyntheticSecurityService service, ErrorReporter error, [Import(LoginContainer.Exports.UserID)]uint user_id) {
          _bus = bus;
          _service = service;
          _error = error;
+         _user_id = user_id;
       }
 
       public IObservable<IReadOnlyDictionary<uint, ExecutionStrategyImmutable>> strategy => _bus.subscribe(SparkTags.SyntheticstrategiesTag);
@@ -39,29 +42,40 @@ namespace mbts.spark {
             return (result, success);
          });
 
-      public async Task<ExecutionStrategyImmutable?> lookup_strategy_async(SecurityImmutable security) =>
-         await lookup_strategy_async(security.Id);
+      public Task<ExecutionStrategyImmutable?> lookup_strategy_async(SecurityImmutable security) =>
+         lookup_strategy_async(security.Id);
 
-      public async Task<ExecutionStrategyImmutable?> lookup_strategy_async(uint id) {
-         var result = await _service.query_security_metadata_async(new MetadataQuery { SecurityKey = { id } });
-         if (result.success) {
-            var metadata = result.value.Data.FirstOrDefault(i => i.SecurityKey == id);
-            if (metadata != null) {
-               return metadata.Strategy;
-            }
+      public Task<ExecutionStrategyImmutable?> lookup_strategy_async(uint id) =>
+         _error.safe_execute(
+            () => _service.query_security_metadata_async(new MetadataQuery { SecurityKey = { id } }),
+            mdc => mdc.Data.Count == 1 && mdc.Data[0].SecurityKey == id,
+            mdc => $"did not find strategy for security id '{id}.'",
+            (mdc, success) => success ? mdc.Data[0].Strategy : (ExecutionStrategyImmutable?)null,
+            "lookup strategy");
+
+      public Task<uint?> create_synthetic(SecurityImmutable synthetic) {
+         if (synthetic.ContractCase != Security.ContractOneofCase.Synthetic)
+            return null;
+         if (synthetic.Synthetic.UserId != _user_id) {
+            var msynth = synthetic.CloneToMutable();
+            msynth.Synthetic.UserId = _user_id;
+            synthetic = new SecurityImmutable(msynth);
          }
-         return null;
+         return _error.safe_execute(
+            () => _service.create_synthetic_async(synthetic),
+            r => r.Error == CreateResult.Types.Error.Ok,
+            r => r.Error.ToString(),
+            (r, success) => success ? r.Key : (uint?)null,
+            "creating synthetic");
       }
 
-      public async Task<uint?> create_synthetic(SecurityImmutable? synthetic) {
-         var result = await _service.create_synthetic_async(synthetic.Value);
-         return _error.handle_error(result, "Error creating synthetic: {0}", r => r.Error, e => e == CreateResult.Types.Error.Ok, r => new uint?(r.Key), () => null).result;
-      }
-
-      public async Task<bool> save_strategy(uint synthetic, ExecutionStrategyImmutable strategy) {
-         var result = await _service.update_security_metadata_async(new Metadata { SecurityKey = synthetic, Strategy = strategy.CloneToMutable() });
-         return _error.handle_error(result, "Error saving execution strategy: {0}", r => r.Error, e => e == UpdateResult.Types.Error.Ok);
-      }
+      public Task<bool> save_strategy(uint synthetic, ExecutionStrategyImmutable strategy) =>
+         _error.safe_execute(
+            () => _service.update_security_metadata_async(new Metadata { SecurityKey = synthetic, Strategy = strategy.CloneToMutable() }),
+            r => r.Error == UpdateResult.Types.Error.Ok,
+            r => r.Error.ToString(),
+            (r, success) => success,
+            "saving strategy");
 
       public async Task<bool> verify_name_is_unique(string name) {
          var (result, success) = await strategy_tuple.FirstAsyncTask(SparkUtils.DefaultTimeOut);

src/client/spark/Modules/Spreader/SyntheticDataHelper.cs

@@ -108,6 +108,9 @@ namespace bts.shell {
             NTicks = 2, 
             PriceType = ConditionalQuoting.Types.PriceType.Leg
          };
+         public static NullableQuantity ShowQuantity => new NullableQuantity {
+            Quantity = 1
+         };
          public static QuoteInsideMarketDistanceWithTravel QuoteInsideMarketDistanceWithTravel => new QuoteInsideMarketDistanceWithTravel { Priority = RulePriority };
          public static QuoteInsideMarketDistance QuoteInsideMarketDistance => new QuoteInsideMarketDistance { Priority = RulePriority };
          #endregion

src/client/spark/Modules/Spreader/SyntheticEditorView.xaml

@@ -34,6 +34,8 @@
       LegTuples="{Binding leg_tuples}"
       RemoveLegCommand="{Binding remove_leg}"
       ContractPickerModel="{Binding contract_picker_model}"
+      HedgePricing="{Binding hedge_pricing}"
+      HedgePricingItemsSource="{Binding hedge_pricing_options}"
     />
     <c:DialogSkirtOKCancel Grid.Row="1" OKCommand="{Binding commit}" CloseOnOK="False"/>
   </Grid>

src/client/spark/Modules/Spreader/SyntheticManagementWindow.cs

@@ -75,19 +75,18 @@ namespace mbts.spark {
                };
                return ob_settings;
             }), SparkCommands.window_settings_command(new DialogCommand(() => {
-               var vm = new WindowSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
+               var vm = new ShellSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
                   _settings_manager,
                   us => us.synthetic_management_grid,
                   UserSettings.FileExtensions.GRID,
                   s => _vm.value.grid_settings_manager.create_vm(
                      // we need to get the most up to date GridSettings when launching b/c users may
                      // have changed some settings on the grid directly, like column widths.
-                     s.with(_vm.value.columns.Select( c => c.create())),
-                     this.observe_title()
+                     s.with(_vm.value.columns.Select(c => c.create()))
                   )
                );
-               // TODO: bind to main window's Title
-               var dialog = new SimpleGridSettingsDialog { Title = "Synthetic Management Grid Settings", DataContext = vm };
+               vm.SubscribeDisposed(literal_title_source.OnDispatcher().Subscribe(t => vm.title = t));
+               var dialog = new ShellSettingsDialog { Title = "Synthetic Management Grid Settings", DataContext = vm };
                vm.RequestClose += (s, e) => WindowUtilities.force_close(dialog);
                return dialog;
             }))

src/client/spark/Modules/Spreader/VM/Cell.cs

@@ -34,6 +34,8 @@ namespace mbts.spark {
 
          public virtual Type data_type { get; } = typeof(T);
 
+         public virtual IRowModel row { get => _model; }
+
          public T value {
             get => _model.get_value(_leg_tup);
             set {
@@ -64,6 +66,8 @@ namespace mbts.spark {
 
          public Type data_type { get; } = typeof(QuantityMeasure);
 
+         public virtual IRowModel row { get => _model; }
+
          public double ratio {
             get => _get_qm().Ratio;
             set {

src/client/spark/Modules/Spreader/VM/ParameterRows/Quote/ShowQuantity/ShowQuantityEnabledModel.cs

@@ -0,0 +1,36 @@
+using bts.shell;
+using mbts.ui.spark;
+
+namespace mbts.spark {
+   partial class SyntheticEditorVM {
+      class ShowQuantityEnabledModel : RowModelBase<bool> {
+         readonly ShowQuantityQuantityModel _quantity;
+
+         public ShowQuantityEnabledModel(ShowQuantityQuantityModel quantity) {
+            _quantity = quantity;
+         }
+
+         public override string display_name => string.Empty;
+         public override string help_text => string.Empty;
+         public override string man_page => string.Empty;
+
+         public override ParameterSection[] section_path { get; } = new[] { Sections.Quote, Subsections.ShowQuantity };
+
+         public override bool get_value(LegSpreaderParamsTuple leg_tup) =>
+            leg_tup.leg_params.QuoteParams.ShowQuantity != null;
+         
+
+         public override void set_value(LegSpreaderParamsTuple leg_tup, bool value) {
+            if (value) {
+               if (leg_tup.leg_params.QuoteParams.ShowQuantity == null) {
+                  leg_tup.leg_params.QuoteParams.ShowQuantity = SyntheticDataHelper.Defaults.ShowQuantity;
+                  _quantity.apply_value(leg_tup);
+               }
+            } else {
+               leg_tup.leg_params.QuoteParams.ShowQuantity = null;
+            }
+            _quantity.set_enabled(leg_tup, value);
+         }
+      }
+   }
+}

src/client/spark/Modules/Spreader/VM/ParameterRows/Quote/ShowQuantity/ShowQuantityQuantityModel.cs

@@ -0,0 +1,43 @@
+using bts.shell;
+using bts.spark;
+using mbts.ui.spark;
+using System.Collections.Generic;
+
+namespace mbts.spark {
+   partial class SyntheticEditorVM {
+      internal class ShowQuantityQuantityModel : RowModelBase<uint> {
+         IDictionary<uint, uint> _value_store = new Dictionary<uint, uint>();
+
+         public override string display_name => "Quantity";
+
+         public override string help_text => string.Empty;
+
+         public override string man_page => string.Empty;
+
+         public override ParameterSection[] section_path { get; } = new[] { Sections.Quote, Subsections.ShowQuantity };
+
+         public void apply_value(LegSpreaderParamsTuple leg_tup) =>
+            _get_value(leg_tup).Quantity = _value_from_store(leg_tup);
+
+
+         public override uint get_value(LegSpreaderParamsTuple leg_tup) =>
+            _get_value(leg_tup) is NullableQuantity show_quantity ? show_quantity.Quantity : _value_from_store(leg_tup);
+
+         public override void set_value(LegSpreaderParamsTuple leg_tup, uint value) {
+            _value_store[leg_tup.SecurityKey] = value;
+            if (_get_value(leg_tup) is NullableQuantity show_quantity) {
+               show_quantity.Quantity = value;
+            }
+         }
+
+         protected override bool _get_enabled(LegSpreaderParamsTuple leg_tup) =>
+            _get_value(leg_tup) != null;
+
+         NullableQuantity _get_value(LegSpreaderParamsTuple leg_tup) =>
+            leg_tup.leg_params.QuoteParams.ShowQuantity;
+
+         uint _value_from_store(LegSpreaderParamsTuple leg_tup) =>
+            _value_store.GetValueOrDefault(leg_tup.SecurityKey, _ => SyntheticDataHelper.Defaults.ShowQuantity.Quantity);
+      }
+   }
+}

src/client/spark/Modules/Spreader/VM/ParameterRows/RowModel.cs

@@ -32,6 +32,7 @@ namespace mbts.spark {
 
       internal interface ICell {
          event Action value_changed;
+         IRowModel row { get; }
          Type data_type { get; }
          bool enabled { get; }
       }
@@ -40,7 +41,7 @@ namespace mbts.spark {
          FontWeight font_weight { get; }
       }
 
-      abstract class RowModelBase<T> : ViewModelBase, IRowModel {
+      internal abstract class RowModelBase<T> : ViewModelBase, IRowModel {
          readonly Dictionary<uint, ReplaySubject<bool>> _enabled_store = new Dictionary<uint, ReplaySubject<bool>>();
          readonly Dictionary<uint, Subject<T>> _override_value_store = new Dictionary<uint, Subject<T>>();
 
@@ -98,6 +99,10 @@ namespace mbts.spark {
       }
 
       private static class Subsections {
+         public static ParameterSection ShowQuantity =>
+            new ParameterSection("Show Quantity", true,
+               "The quantity shown when the order is placed.");
+
          public static ParameterSection Throttle =>
             new ParameterSection("Throttle", true,
                "Reduces re-quoting updates by defining a region on either side " +

src/client/spark/Modules/Spreader/VM/SyntheticEditorVM.cs

@@ -17,6 +17,7 @@ using System.Reactive.Linq;
 using System.Threading.Tasks;
 using System.Windows.Input;
 using System.Windows.Media;
+using HedgePricing = bts.spark.ExecutionStrategy.Types.HedgePricing;
 
 namespace mbts.spark {
    /// <summary>
@@ -32,6 +33,7 @@ namespace mbts.spark {
       bool _set_name_automatically, _set_ticks_automatically, _set_quantities_automatically, _set_price_mults_automatically, _is_setting_quantities, _is_setting_price_mults;
       TickFactors _tick_factors;
       ExecutionStrategyImmutable _strategy;
+      HedgePricing _hedge_pricing;
 
       /// <summary>
       /// Inititalizes a new instance of SyntheticEditorVM class.  This constructor may only be used for already-existing synthetic securities (id must be non-zero).
@@ -76,8 +78,8 @@ namespace mbts.spark {
                exchanges = EnumHelper.get_values_except(Venue.Bts).ToArray()
             }
          }));
-         contract_picker_model.cancel_action = _close_new_leg_popup;
-         contract_picker_model.ok_action = () => {
+         contract_picker_model.cancel_action += _close_new_leg_popup;
+         contract_picker_model.ok_action += () => {
             if (!leg_tuples.Any(l => l.leg.Security.Id == contract_picker_model.result.security.Id)) {
                leg_tuples.Add(new LegSpreaderParamsTuple(
                   SyntheticDataHelper.Defaults.ContractLeg(contract_picker_model.result.security),
@@ -134,7 +136,7 @@ namespace mbts.spark {
                _synthetic.ContractSpec.PriceBreak = double.MaxValue;
                _synthetic.ContractSpec.MainFraction = (uint)MathUtils.factor_out(_tick_factors.tick_base, 10);
                _synthetic.ContractSpec.PriceDisplayFormat = (uint)_tick_factors.display_digits();
-               uint? id = await model.create_synthetic(_synthetic);
+               uint? id = await model.create_synthetic(new SecurityImmutable(_synthetic));
                if (id.HasValue && id != 0) {
                   if (await model.save_strategy(id.Value, get_strategy())) {
                      var (smd, success) = await SparkUtils.get_security_md_async(bus, id.Value);
@@ -177,6 +179,8 @@ namespace mbts.spark {
          } else {
             _can_add_leg = backing(nameof(can_add_leg), false);
          }
+         var show_quantity_quantity = new ShowQuantityQuantityModel();
+
          var quote_throttle_outside_ticks = new QuoteThrottleOutsideTicksModel();
          var quote_throttle_inside_ticks = new QuoteThrottleInsideTicksModel();
 
@@ -211,6 +215,8 @@ namespace mbts.spark {
             //new QuoteHiddenModel(),
             new QuoteQueueHolderModel(),
             new MarketDataTypeModel(),
+            new ShowQuantityEnabledModel(show_quantity_quantity),
+            show_quantity_quantity,
             new QuoteThrottleEnabledModel(quote_throttle_inside_ticks, quote_throttle_outside_ticks),
             quote_throttle_inside_ticks,
             quote_throttle_outside_ticks,
@@ -290,6 +296,9 @@ namespace mbts.spark {
       public IRaiseCanExecuteChangedCommand commit { get; }
       public ICommand remove_leg { get; }
       public ContractPickerModel contract_picker_model { get; }
+      // hedge pricing
+      public HedgePricing hedge_pricing { get => _hedge_pricing; set => Set(ref _hedge_pricing, value); }
+      public IEnumerable<HedgePricing> hedge_pricing_options => EnumHelper.get_values<HedgePricing>();
 
       public ExecutionStrategyImmutable get_strategy() {
          var mutable_strategy = _strategy.CloneToMutable();
@@ -297,6 +306,7 @@ namespace mbts.spark {
          foreach (var lt in leg_tuples) {
             mutable_strategy.LegParamsMap.Add(lt.leg.Security.Id, lt.leg_params);
          }
+         mutable_strategy.HedgePricing = hedge_pricing;
          return new ExecutionStrategyImmutable(mutable_strategy);
       }
 
@@ -304,6 +314,7 @@ namespace mbts.spark {
          _synthetic = synthetic.CloneToMutable();
          _synthetic.Exchange = Venue.Bts;
          _strategy = strategy;
+         hedge_pricing = strategy.HedgePricing;
          leg_tuples.SetItems(_get_legs(_synthetic, strategy));
          RaisePropertyChanged(nameof(name), nameof(tick_factors));
       }

src/client/spark/Modules/Support/Browser/BrowserWindow.cs

@@ -1,14 +1,9 @@
-using bts.api;
+using mbts;
 using mbts.config;
-using mbts.spark;
 using mbts.ui;
-using ProtoBuf;
+using mbts.ui.shell;
 using System;
-using System.Collections.Generic;
-using System.ComponentModel.Composition;
-using System.Threading.Tasks;
 using System.Windows.Controls;
-using mbts;
 
 namespace bts.shell {
    public class BrowserWindow : IShellWindow {
@@ -75,12 +70,15 @@ namespace bts.shell {
       public string window_type => _window_type;
 
       public IShellModule Owner {get; set; }
+
       public ShellWindowUI GetContent() { return new ShellWindowUI(_browser); }
 
       public void GetState(System.IO.Stream save_here) {
          _isw.save(new BrowserWindowState() { uri = uri.ToString() }, save_here);
       }
 
+      public void on_shell_window_vm(ShellWindowVM shell_window_vm) { }
+
       public void Dispose() {
          if (_browser != null) {
             _browser.Dispose();
@@ -102,5 +100,4 @@ namespace bts.shell {
       }
       #endregion
    }
-   
-}
+}

src/client/spark/Modules/Trading/AlgoStudio/AlgoPersistenceHelper.cs

@@ -1,112 +0,0 @@
-using bts.api.core;
-using bts.collections;
-using mbts.collections;
-using System.Collections.Generic;
-using System.Collections.ObjectModel;
-using System.Threading.Tasks;
-
-namespace mbts.spark {
-   /// <summary>
-   /// This class's primary purpose is to handle async AlgoService persistence calls for the AlgoStudioVM/OrderPropertiesEditorVM.
-   /// When a new definition/template item is persisted for the first time, it's corresponding viewmodel (<see cref="AlgoDefinitionVM"/>, <see cref="AlgoDefinitionTemplateVM"/>)
-   /// must be removed and replaced with a new one that has the brand new persisted id (<see cref="AlgoKey"/>).  As part of its duty, this class makes sure that the new persisted items are inserted into the same index as their unpersisted predecessor.
-   /// </summary>
-   static class AlgoPersistenceHelper {
-      public static (int? def_index, int? tmp_index) selection_snapshot(IList<AlgoDefinitionVM> definitions, AlgoDefinitionVM selected_definition, AlgoDefinitionTemplateVM selected_template) {
-         var def = selected_definition;
-         var tmp = selected_template;
-         int? def_index = def == null ? (int?)null : definitions.IndexOf(def);
-         int? tmp_index = tmp == null ? (int?)null : tmp.owner.templates.IndexOf(tmp);
-         return (def_index, tmp_index);
-      }
-
-      public static async Task<IReadOnlyDictionary<AlgoKey, AlgoKey>> persist_definition(OrdersModel model, IList<AlgoDefinitionVM> definitions, AlgoDefinitionVM definition) {
-         int def_index = definitions.IndexOf(definition);
-         return await persist(model, definitions.WrapSubRange(def_index, 1).WrapSelector(def => (def, definition.templates.AsList()), t => t.def));
-      }
-
-      public static async Task<IReadOnlyDictionary<AlgoKey, AlgoKey>> persist_template(OrdersModel model, IList<AlgoDefinitionVM> definitions, AlgoDefinitionTemplateVM template) {
-         switch (template.owner.key.mode) {
-            case AlgoKey.Mode.Unpersisted: return await persist_definition(model, definitions, template.owner);
-            case AlgoKey.Mode.Persisted:
-               int def_index = definitions.IndexOf(template.owner);
-               int tmp_index = template.owner.templates.IndexOf(template);
-               return await persist(model, definitions.WrapSubRange(def_index, 1).WrapSelector(def => (def, def.templates.WrapSubRange(tmp_index, 1)), t => t.def));
-            default: return DictionaryHelper.empty<AlgoKey, AlgoKey>();
-         }
-      }
-
-      public static async Task<IReadOnlyDictionary<AlgoKey, AlgoKey>> persist_all(OrdersModel model, ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey> definitions) =>
-         await persist(model, definitions.WrapSelector(def => (def, def.templates.AsList()), t => t.def));
-
-      /// <summary>
-      /// Persists each pair of definition/templates, then returns a map of non-persisted keys to persisted ones (<see cref="AlgoKey"/>, <see cref="AlgoDefinitionVM.key"/>, <see cref="AlgoDefinitionTemplateVM.key"/>).
-      /// The key-map gives callers the ability to replace unpersisted items with persisted ones before the next update arrives.
-      /// <para>Note: use a <see cref="mbts.utils.TableUpdateBuffer{T, TKey}"/> to suspend updates while awaiting this task; don't resume them until all unpersisted items have been replaced.
-      /// <see cref="AlgoDefinitionCollection"/> caters to this pre-emptive adding behavior, in it's <see cref="TableUpdate{T, TKey}"/> callback, it checks if added items are already present, and if so, treats them as changes instead.</para>
-      /// <para>PS: the reason for all this madness is so newly persisted items are inserted in the same index as their placeholder counterpart.  The only way to connect the non-persisted keys with their persisted counterparts
-      /// is to await each save-op individually, and build a map with the results..hence the returned key-map.</para>
-      /// </summary>
-      /// <param name="model"></param>
-      /// <param name="definition_templates"></param>
-      /// <returns>An AlgoKey->AlgoKey map of old placeholder ids to newly persisted ones.</returns>
-      public static async Task<IReadOnlyDictionary<AlgoKey, AlgoKey>> persist(OrdersModel model, IList<(AlgoDefinitionVM definition, IList<AlgoDefinitionTemplateVM> templates)> definition_templates) {
-         var placeholder_to_persisted_keys = new Dictionary<AlgoKey, AlgoKey>();
-         for (int i = 0; i < definition_templates.Count; i++) {
-            (var def, var templates) = definition_templates[i];
-            var persisted_def = def;
-            if (def.is_dirty) {
-               var def_record = await model.algo_model.save_definition(def.create_algo_def());
-               if (def_record.HasValue) {
-                  switch (def.key.mode) {
-                     case AlgoKey.Mode.Factory:
-                     case AlgoKey.Mode.Unpersisted:
-                        persisted_def = def.to_persisted(def_record.Value);
-                        foreach (var tmp in templates) {
-                           AlgoDefinitionTemplateVM persisted_tmp;
-                           var tmp_record = await model.algo_model.save_template(tmp.create(def_record.Value));
-                           if (tmp_record.HasValue) {
-                              persisted_def.templates.Add(persisted_tmp = tmp.to_persisted(persisted_def, new AlgoData(tmp_record.Value.value, tmp_record.Value.name, tmp_record.Value.key)));
-                           } else {
-                              /// If the save-op fails, the unpersisted template is cloned and added to the persisted def's template items, so the user may try to save it again without having to re-enter all the templated-values.
-                              /// Q: "why don't we just re-add the same template to the persisted def, the save-op failed, so nothing changed...why do we need a new one?"
-                              /// A: "A new template vm must be created because its owner has changed (it's a readonly prop, <see cref="AlgoDefinitionTemplateVM.owner"/>)."
-                              persisted_def.templates.Add(persisted_tmp = new AlgoDefinitionTemplateVM(persisted_def, model, tmp.create_def_data()));
-                           }
-                           placeholder_to_persisted_keys[tmp.key] = persisted_tmp.key;
-                        }
-                        persisted_def.connect();
-                        if (def.key.mode == AlgoKey.Mode.Unpersisted) {
-                           definition_templates[i] = (persisted_def, persisted_def.templates);
-                        } else {
-                           definition_templates.Add((persisted_def, persisted_def.templates));
-                        }
-                        placeholder_to_persisted_keys[def.key] = persisted_def.key;
-                        break;
-                  }
-               }
-            } else {
-               // so the def isn't dirty, but it still might have dirty templates
-               using (persisted_def.buffer_updates()) {
-                  for (int j = 0; j < templates.Count; j++) {
-                     var tmp = templates[j];
-                     if (!tmp.is_dirty)
-                        continue;
-                     var tmp_record = await model.algo_model.save_template(tmp.create());
-                     if (tmp_record.HasValue) {
-                        switch (tmp.key.mode) {
-                           case AlgoKey.Mode.Unpersisted:
-                              var persisted_tmp = tmp.to_persisted(persisted_def, new AlgoData(tmp_record.Value.value, tmp_record.Value.name, tmp_record.Value.key));
-                              templates[j] = persisted_tmp;
-                              placeholder_to_persisted_keys[tmp.key] = persisted_tmp.key;
-                              break;
-                        }
-                     }
-                  }
-               }
-            }
-         }
-         return placeholder_to_persisted_keys;
-      }
-   }
-}

src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioView.xaml

@@ -12,14 +12,11 @@
   xmlns:uag="clr-namespace:mbts.ui.spark.algo"
   xmlns:uspcv="clr-namespace:mbts.ui.spark.converters"
   xmlns:sys="clr-namespace:System;assembly=mscorlib"
-  u:StateManager.VisualState="{Binding content_source.algo_root, Converter={x:Static usp:AlgoStudioView.EditPaneVisualStateConverter}}"
+  u:StateManager.VisualState="{Binding selected_definition.algo_root, Converter={x:Static usp:AlgoStudioView.EditPaneVisualStateConverter}}"
   Background="{StaticResource CommonBackground}"
 >
   <UserControl.Resources>
     <ResourceDictionary>
-      <ResourceDictionary.MergedDictionaries>
-        <ResourceDictionary Source="/view/Controls/Order/AlgoTemplateTreeView.xaml"/>
-      </ResourceDictionary.MergedDictionaries>
       <!--Primitive Constants-->
       <sys:Double x:Key="HorizontalPush1">4</sys:Double>
       <sys:Double x:Key="HorizontalPush2">8</sys:Double>
@@ -33,9 +30,6 @@
       <Thickness x:Key="Margin.TP1" Top="{StaticResource VerticalPush1}"/>
       <Thickness x:Key="Margin.TP2" Top="{StaticResource VerticalPush2}"/>
       <!--Converters-->
-      <cv:ValueMap x:Key="AlgoTemplateFavoriteToggleButtonToolTipConverter" Default="Add to Favorites">
-        <cv:KeyValue Key="{u:True}" Value="Remove from Favorites"/>
-      </cv:ValueMap>
       <sys:String x:Key="AlgoAbbreviationActiveState">AbbreviationActive</sys:String>
       <sys:String x:Key="AlgoAbbreviationInactiveState">AbbreviationInactive</sys:String>
       <cv:ValueMap x:Key="AlgoAbbreviationVisualStateConverter" Default="{StaticResource AlgoAbbreviationActiveState}">
@@ -130,70 +124,8 @@
         </Setter>
       </Style>
 
-      <Style x:Key="AlgoTemplateFavoriteToggleButtonStyle" TargetType="ToggleButton">
-        <Setter Property="Background" Value="LightGray"/>
-        <Setter Property="BorderBrush" Value="Black"/>
-        <Setter Property="BorderThickness" Value="1"/>
-        <Setter Property="Foreground" Value="White"/>
-        <Setter Property="IsThreeState" Value="False"/>
-        <Setter Property="IsChecked" Value="{Binding is_favorite}"/>
-        <Setter Property="SnapsToDevicePixels" Value="True"/>
-        <Setter Property="UseLayoutRounding" Value="True"/>
-        <Setter Property="Width" Value="16"/>
-        <Setter Property="Height" Value="16"/>
-        <Setter Property="ToolTip" Value="{Binding IsChecked, RelativeSource={RelativeSource Self}, Converter={x:Static uag:AlgoTemplateToolBar.FavoriteToggleButtonToolTipConverter}}"/>
-        <Setter Property="Template">
-          <Setter.Value>
-            <ControlTemplate TargetType="ToggleButton">
-              <Grid UseLayoutRounding="{TemplateBinding UseLayoutRounding}">
-                <Ellipse x:Name="ellipse" HorizontalAlignment="Stretch" VerticalAlignment="Stretch" Fill="{TemplateBinding Background}" Width="0" Height="0"/>
-                <Image SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" UseLayoutRounding="{TemplateBinding UseLayoutRounding}" MaxHeight="13" MaxWidth="13">
-                  <Image.Source>
-                    <DrawingImage>
-                      <DrawingImage.Drawing>
-                        <GeometryDrawing Geometry="{Binding Source={StaticResource ResourceKey={x:Static u:Icons.StarGeometryKey}}}" Brush="{Binding Foreground, RelativeSource={RelativeSource TemplatedParent}}" >
-                          <GeometryDrawing.Pen>
-                            <Pen
-                              Brush="{Binding BorderBrush, RelativeSource={RelativeSource TemplatedParent}}"
-                              Thickness="{Binding BorderThickness.Left, RelativeSource={RelativeSource TemplatedParent}}"
-                            />
-                          </GeometryDrawing.Pen>
-                        </GeometryDrawing>
-                      </DrawingImage.Drawing>
-                    </DrawingImage>
-                  </Image.Source>
-                </Image>
-              </Grid>
-              <ControlTemplate.Triggers>
-                <Trigger Property="IsChecked" Value="True">
-                  <Setter Property="Foreground" Value="Gold"/>
-                </Trigger>
-                <Trigger Property="IsMouseOver" Value="True">
-                  <Trigger.EnterActions>
-                    <BeginStoryboard>
-                      <Storyboard>
-                        <DoubleAnimation Storyboard.TargetName="ellipse" Storyboard.TargetProperty="Width" To="16" Duration="0:0:0.03" />
-                        <DoubleAnimation Storyboard.TargetName="ellipse" Storyboard.TargetProperty="Height" To="16" Duration="0:0:0.03" />
-                      </Storyboard>
-                    </BeginStoryboard>
-                  </Trigger.EnterActions>
-                  <Trigger.ExitActions>
-                    <BeginStoryboard>
-                      <Storyboard>
-                        <DoubleAnimation Storyboard.TargetName="ellipse" Storyboard.TargetProperty="Width" To="0" Duration="0:0:0.0" />
-                        <DoubleAnimation Storyboard.TargetName="ellipse" Storyboard.TargetProperty="Height" To="0" Duration="0:0:0.0" />
-                      </Storyboard>
-                    </BeginStoryboard>
-                  </Trigger.ExitActions>
-                </Trigger>
-              </ControlTemplate.Triggers>
-            </ControlTemplate>
-          </Setter.Value>
-        </Setter>
-      </Style>
-
       <Style TargetType="uag:AlgoPickerNodeView" BasedOn="{StaticResource {x:Type uag:AlgoPickerNodeView}}">
-        <Setter Property="DropDownStyleKey" Value="{Binding DataContext.content_source, RelativeSource={RelativeSource AncestorType=usp:AlgoStudioView}, Converter={x:Static usp:AlgoContentTemplateSelector.AlgoDropDownStyleKeyConverter}}"/>
+        <Setter Property="DropDownStyleKey" Value="{x:Static usp:AlgoContentTemplateSelector.DefinitionDropDownStyleKey}"/>
       </Style>
     </ResourceDictionary>
   </UserControl.Resources>
@@ -221,94 +153,26 @@
         <ColumnDefinition Width="Auto"/>
         <ColumnDefinition Width="*"/>
       </Grid.ColumnDefinitions>
-      <TreeView
+      <ListBox
         x:Name="_tree_view"
-        u:TreeViewEx.SelectedItemChangedHandler="{Binding}"
         ItemsSource="{Binding definitions_view}"
         HorizontalAlignment="Stretch"
         VerticalAlignment="Stretch"
         MinWidth="180"
         Background="Transparent"
-        Style="{StaticResource AlgoTemplateTreeViewStyle}"
+        SelectedItem="{Binding selected_definition}"
       >
-        <TreeView.CommandBindings>
-          <CommandBinding Command="{x:Static u:EditableCollectionViewEx.AddNewItemCommand}" Executed="{x:Static u:EditableCollectionViewEx.AddNewItemExecuted}" CanExecute="{x:Static u:EditableCollectionViewEx.AddNewItemCanExecute}"/>
-          <CommandBinding Command="{x:Static u:EditableCollectionViewEx.CommitAnyCommand}" Executed="{x:Static u:EditableCollectionViewEx.CommitAnyExecuted}"/>
-        </TreeView.CommandBindings>
-        <TreeView.Resources>
-          <HierarchicalDataTemplate DataType="{x:Type sp:AlgoDefinitionVM}" ItemsSource="{Binding templates_view}">
-            <Grid u:StateManager.VisualStateCollection="{Binding tree_view_visual_states}">
-              <VisualStateManager.VisualStateGroups>
-                <VisualStateGroup Name="{x:Static GroupName, MemberType={u:Nested usp:AlgoStudioView.VisualStateNames.TreeViewBadge}}">
-                  <VisualState Name="{x:Static Active, MemberType={u:Nested usp:AlgoStudioView.VisualStateNames.TreeViewBadge}}"/>
-                  <VisualState Name="{x:Static Inactive, MemberType={u:Nested usp:AlgoStudioView.VisualStateNames.TreeViewBadge}}">
-                    <Storyboard>
-                      <ObjectAnimationUsingKeyFrames Storyboard.TargetName="badge" Storyboard.TargetProperty="(UIElement.Visibility)">
-                        <DiscreteObjectKeyFrame KeyTime="0" Value="{x:Static Visibility.Collapsed}"/>
-                      </ObjectAnimationUsingKeyFrames>
-                    </Storyboard>
-                  </VisualState>
-                </VisualStateGroup>
-              </VisualStateManager.VisualStateGroups>
-              <Grid.ColumnDefinitions>
-                <ColumnDefinition Width="Auto"/>
-                <ColumnDefinition Width="*"/>
-              </Grid.ColumnDefinitions>
-              <Rectangle
-                x:Name="badge"
-                Fill="{Binding badge_fill}"
-                Style="{StaticResource RectangleBadgeStyle}"
-                Visibility="{DynamicResource ResourceKey={x:Static usp:AlgoStudioView.BadgesInTreeViewVisibilityKey}}"
-              />
-              <TextBlock x:Name="text_view" Grid.Column="1" Margin="{StaticResource Margin.LP1}" Text="{Binding name}"/>
-            </Grid>
-            <HierarchicalDataTemplate.Triggers>
-              <DataTrigger Binding="{Binding is_dirty}" Value="True">
-                <Setter TargetName="text_view" Property="Text" Value="{Binding name, StringFormat='{}{0}*'}"/>
-              </DataTrigger>
-            </HierarchicalDataTemplate.Triggers>
-          </HierarchicalDataTemplate>
-          <DataTemplate DataType="{x:Type sp:AlgoDefinitionTemplateVM}">
-            <Grid u:StateManager.VisualStateCollection="{Binding tree_view_visual_states}" Margin="-6,0,0,0">
-              <VisualStateManager.VisualStateGroups>
-                <VisualStateGroup Name="{x:Static GroupName, MemberType={u:Nested usp:AlgoStudioView.VisualStateNames.FavoriteToggleButton}}">
-                  <VisualState Name="{x:Static Active, MemberType={u:Nested usp:AlgoStudioView.VisualStateNames.FavoriteToggleButton}}"/>
-                  <VisualState Name="{x:Static Inactive, MemberType={u:Nested usp:AlgoStudioView.VisualStateNames.FavoriteToggleButton}}">
-                    <Storyboard>
-                      <ObjectAnimationUsingKeyFrames Storyboard.TargetName="favorite_toggle" Storyboard.TargetProperty="(UIElement.Visibility)">
-                        <DiscreteObjectKeyFrame KeyTime="0" Value="{x:Static Visibility.Collapsed}"/>
-                      </ObjectAnimationUsingKeyFrames>
-                    </Storyboard>
-                  </VisualState>
-                </VisualStateGroup>
-              </VisualStateManager.VisualStateGroups>
-              <Grid.ColumnDefinitions>
-                <ColumnDefinition Width="Auto"/>
-                <ColumnDefinition Width="*"/>
-              </Grid.ColumnDefinitions>
-              <Grid>
-                <Grid.ColumnDefinitions>
-                  <ColumnDefinition Width="Auto"/>
-                  <ColumnDefinition Width="*"/>
-                </Grid.ColumnDefinitions>
-                <ToggleButton x:Name="favorite_toggle" Grid.Column="1" Margin="4,0,0,0" Style="{StaticResource AlgoTemplateFavoriteToggleButtonStyle}"/>
-              </Grid>
-              <TextBlock x:Name="text_view" Grid.Column="1" Margin="{StaticResource Margin.LP1}" Text="{Binding name}" ToolTip="Double click to set as default"/>
-            </Grid>
+        <ListBox.ItemTemplate>
+          <DataTemplate DataType="{x:Type sp:AlgoDefinitionVM}">
+            <TextBlock x:Name="text_view" Grid.Column="1" Margin="{StaticResource Margin.LP1}" Text="{Binding name}"/>
             <DataTemplate.Triggers>
-              <DataTrigger Value="{u:True}">
-                <DataTrigger.Binding>
-                  <MultiBinding Converter="{StaticResource OrConverter}">
-                    <Binding Path="is_dirty"/>
-                    <Binding Path="is_persisted" Converter="{StaticResource NotConverter}"/>
-                  </MultiBinding>
-                </DataTrigger.Binding>
+              <DataTrigger Binding="{Binding is_dirty}" Value="True">
                 <Setter TargetName="text_view" Property="Text" Value="{Binding name, StringFormat='{}{0}*'}"/>
               </DataTrigger>
             </DataTemplate.Triggers>
           </DataTemplate>
-        </TreeView.Resources>
-      </TreeView>
+        </ListBox.ItemTemplate>
+      </ListBox>
       <ScrollViewer Grid.Column="1" Grid.IsSharedSizeScope="True" Margin="8,4">
         <Grid x:Name="edit_pane">
           <Grid.RowDefinitions>
@@ -430,7 +294,7 @@
             Margin="{StaticResource Margin.LP1}"
             HorizontalAlignment="Stretch"
             VerticalAlignment="Center"
-            Text="{Binding content_source.name, UpdateSourceTrigger=PropertyChanged, Delay=25}"
+            Text="{Binding selected_definition.name, UpdateSourceTrigger=PropertyChanged, Delay=25}"
           />
             <Grid x:Name="abbreviation_root" Grid.Column="2">
               <Grid.ToolTip>
@@ -452,7 +316,7 @@
                 <ColumnDefinition Width="*"/>
               </Grid.ColumnDefinitions>
               <TextBlock x:Name="abbreviation_label" FontStyle="Italic" Margin="{StaticResource Margin.LP1}" VerticalAlignment="Center">Abbrev.</TextBlock>
-              <TextBox Grid.Column="1" Margin="{StaticResource Margin.LP1}" Text="{Binding content_source.abbreviation, UpdateSourceTrigger=PropertyChanged, Delay=25}"/>
+              <TextBox Grid.Column="1" Margin="{StaticResource Margin.LP1}" Text="{Binding selected_definition.abbreviation, UpdateSourceTrigger=PropertyChanged, Delay=25}"/>
             </Grid>
           </Grid>
           <Grid x:Name="badge_selector_radio_button_root" Grid.Row="1" Margin="{StaticResource Margin.TP2}">
@@ -478,8 +342,8 @@
                       <TextBlock>Hint: the default color is that of the algo-root (</TextBlock>
                       <usp:OrderTypeItem
                         Margin="2,0"
-                        BadgeFill="{Binding content_source.algo_root.meta.Color, Converter={StaticResource ColorToBrushConverter}}"
-                        DisplayName="{Binding content_source.algo_root.display_name}"
+                        BadgeFill="{Binding selected_definition.algo_root.meta.Color, Converter={StaticResource ColorToBrushConverter}}"
+                        DisplayName="{Binding selected_definition.algo_root.display_name}"
                       />
                       <TextBlock>).</TextBlock>
                     </StackPanel>
@@ -496,7 +360,7 @@
                   x:Name="default_badge"
                   Grid.Column="1"
                   Margin="{StaticResource Margin.LP1}"
-                  Fill="{Binding content_source.algo_root.meta.Color, Converter={StaticResource ColorToBrushConverter}}"
+                  Fill="{Binding selected_definition.algo_root.meta.Color, Converter={StaticResource ColorToBrushConverter}}"
                   Style="{StaticResource RectangleBadgeStyle}"
                 />
               </Grid>
@@ -506,7 +370,7 @@
               VerticalAlignment="Center"
               VerticalContentAlignment="Center"
               Margin="{StaticResource Margin.LP2}"
-              IsChecked="{Binding content_source.custom_badge_color.enabled}"
+              IsChecked="{Binding selected_definition.custom_badge_color.enabled}"
               GroupName="Badge"
             >
               <RadioButton.ToolTip>
@@ -526,7 +390,7 @@
                     Grid.Row="1"
                     Grid.Column="1"
                     Margin="3,0"
-                    Fill="{Binding content_source.custom_badge_color.value, Converter={StaticResource ColorToBrushConverter}}"
+                    Fill="{Binding selected_definition.custom_badge_color.value, Converter={StaticResource ColorToBrushConverter}}"
                     Style="{StaticResource RectangleBadgeStyle}"
                   />
                   <TextBlock Grid.Row="1" Grid.Column="2" FontStyle="Italic">to open the color picker popup.</TextBlock>
@@ -541,7 +405,7 @@
                 <Button
                   x:Name="custom_badge_color_picker_button"
                   Grid.Column="1"
-                  Background="{Binding content_source.custom_badge_color.value, Converter={StaticResource ColorToBrushConverter}}"
+                  Background="{Binding selected_definition.custom_badge_color.value, Converter={StaticResource ColorToBrushConverter}}"
                   Margin="{StaticResource Margin.LP1}"
                   Style="{StaticResource CustomBadgeColorPickerButtonStyle}"
                 />
@@ -549,8 +413,8 @@
                   <Border Style="{StaticResource CustomBadgeColorPickerPopupRootStyle}">
                     <cp:ColorPickerControl
                       Background="Transparent"
-                      Palettes="{Binding DataContext.content_source.custom_badge_color_palettes, RelativeSource={RelativeSource AncestorType=Popup}}"
-                      SelectedColor="{Binding DataContext.content_source.custom_badge_color.value, RelativeSource={RelativeSource AncestorType=Popup}, Mode=TwoWay}"
+                      Palettes="{Binding DataContext.selected_definition.custom_badge_color_palettes, RelativeSource={RelativeSource AncestorType=Popup}}"
+                      SelectedColor="{Binding DataContext.selected_definition.custom_badge_color.value, RelativeSource={RelativeSource AncestorType=Popup}, Mode=TwoWay}"
                     />
                   </Border>
                 </Popup>
@@ -559,7 +423,7 @@
           </Grid>
           <usp:AlgoEditorView
             Grid.Row="2"
-            DataContext="{Binding content_source}"
+            DataContext="{Binding selected_definition}"
             Background="Transparent"
             BorderBrush="{Binding algo_root, Converter={StaticResource OrderTypeBrushConverter}}"
             Margin="0,6,0,0"
@@ -569,10 +433,10 @@
             <StackPanel.Margin>
               <Thickness Left="{StaticResource DialogSkirtPadding.Left}" Top="{StaticResource VerticalPush2}" Right="{StaticResource DialogSkirtButtonPadding.Right}" Bottom="{StaticResource DialogSkirtPadding.Bottom}"/>
             </StackPanel.Margin>
-            <Button ToolTipService.ShowOnDisabled="True" Margin="{StaticResource DialogSkirtButtonMargin}" Command="{Binding save_cmd}" CommandParameter="{Binding content_source}" Width="100" ToolTip="{Binding save_cmd_tooltip}" IsDefault="True">
+            <Button ToolTipService.ShowOnDisabled="True" Margin="{StaticResource DialogSkirtButtonMargin}" Command="{Binding save_cmd}" CommandParameter="{Binding selected_definition}" Width="100" ToolTip="{Binding save_cmd_tooltip}" IsDefault="True">
               <TextBlock Text="{Binding selected_definition.name, StringFormat='{}Save {0}'}"/>
             </Button>
-            <Button ToolTipService.ShowOnDisabled="True" Margin="{StaticResource DialogSkirtButtonMargin}" Command="{Binding revert_cmd}" CommandParameter="{Binding content_source}" Width="100" ToolTip="{Binding revert_cmd_tooltip}">
+            <Button ToolTipService.ShowOnDisabled="True" Margin="{StaticResource DialogSkirtButtonMargin}" Command="{Binding revert_cmd}" CommandParameter="{Binding selected_definition}" Width="100" ToolTip="{Binding revert_cmd_tooltip}">
               <TextBlock Text="{Binding selected_definition.name, StringFormat='{}Revert {0}'}"/>
             </Button>
           </StackPanel>
@@ -580,4 +444,4 @@
       </ScrollViewer>
     </Grid>
   </AdornerDecorator>
-</UserControl>
+</UserControl>

src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioView.xaml.cs

@@ -1,43 +1,24 @@
 using mbts.spark;
+using mbts.ui.controls;
 using mbts.ui.converters;
-using System;
+using mbts.ui.extensions;
 using System.Windows.Controls;
 using System.Windows.Data;
 using System.Windows.Input;
 
 namespace mbts.ui.spark {
    partial class AlgoStudioView : UserControl {
-      public const string BadgesInTreeViewVisibilityKey = nameof(BadgesInTreeViewVisibilityKey);
       public static readonly IValueConverter EditPaneVisualStateConverter =
          ValueConverter.create(obj => obj == null ? VisualStates.Inactive : VisualStates.Active);
 
-      IAlgoStudioViewController _controller;
-
       public AlgoStudioView() {
          InitializeComponent();
-         DataContextChanged += (s, e) => set_controller();
-         set_controller();
-         // local methods
-         void set_controller() => Disposable.replace(ref _controller, AlgoStudioViewControllerFactory.create(DataContext, _tree_view, name_text_box, custom_badge_color_picker_button, custom_badge_color_picker_popup));
+         PopupViewController.attach(custom_badge_color_picker_popup, custom_badge_color_picker_button);
+         this.ConnectDataContext<AlgoStudioVM>(vm => vm.request_view_focus_name += focus_name, vm => vm.request_view_focus_name -= focus_name);
+         void focus_name(AlgoDefinitionVM target) =>
+            Dispatcher.InvokeAsync(() => Keyboard.Focus(name_text_box));
       }
 
-      public new AlgoStudioVM DataContext {
-         get => base.DataContext as AlgoStudioVM;
-         set => base.DataContext = value;
-      }
-
-      public void add_definition() => _controller.add_definition();
-      public void add_definition_clone(AlgoDefinitionVM src_definition) => _controller.add_definition_clone(src_definition);
-      public void add_template(AlgoDefinitionVM definition) => _controller.add_template(definition);
-      public void rename_definition(AlgoDefinitionVM definition) => _controller.rename_definition(definition);
-      public void rename_template(AlgoDefinitionTemplateVM template) => _controller.rename_template(template);
-      public void select_definition(AlgoDefinitionVM definition) => _controller.select_definition(definition);
-      public void select_template(AlgoDefinitionTemplateVM template) => _controller.select_template(template);
-      public IDisposable preserve_selected_definition() => _controller.preserve_selected_definition();
-
-      void _end_edit_executed(object s, ExecutedRoutedEventArgs e) =>
-         _controller.end_edit(e);
-
       public static class VisualStateNames {
          public static class EditPane {
             public const string GroupName = nameof(EditPane);
@@ -75,14 +56,6 @@ namespace mbts.ui.spark {
                Inactive = $"{GroupName}{VisualStates.Inactive}";
          }
 
-         public static class TreeViewBadge {
-            public const string GroupName = nameof(TreeViewBadge);
-
-            public static readonly string
-               Active = $"{GroupName}{VisualStates.Active}",
-               Inactive = $"{GroupName}{VisualStates.Inactive}";
-         }
-
          public static class FavoriteToggleButton {
             public const string GroupName = nameof(FavoriteToggleButton);
 

src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioViewController.cs

@@ -1,133 +0,0 @@
-using mbts.spark;
-using mbts.ui.controls;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Windows.Controls;
-using System.Windows.Controls.Primitives;
-using System.Windows.Input;
-
-namespace mbts.ui.spark {
-   interface IAlgoStudioViewController : IDisposable {
-      void add_definition();
-      void add_definition_clone(AlgoDefinitionVM src_definition);
-      void add_template(AlgoDefinitionVM definition);
-      void rename_definition(AlgoDefinitionVM definition);
-      void rename_template(AlgoDefinitionTemplateVM template);
-      void end_edit(ExecutedRoutedEventArgs e);
-      void select_definition(AlgoDefinitionVM definition);
-      void select_template(AlgoDefinitionTemplateVM template);
-      IDisposable preserve_selected_definition();
-   }
-
-   class AlgoStudioViewControllerFactory {
-      static readonly IAlgoStudioViewController _empty = new EmptyController();
-
-      public static IAlgoStudioViewController create(AlgoStudioVM vm, TreeView tree_view, TextBox name_text_box, Button color_picker_button, Popup color_picker_popup) =>
-         vm == null || tree_view == null || name_text_box == null || color_picker_button == null || color_picker_popup == null ?
-            _empty : new Controller(vm, tree_view, name_text_box, color_picker_button, color_picker_popup);
-
-      /// <summary>
-      /// This wrapper class is returned by <see cref="create(AlgoStudioVM, TreeView)"/> when the vm or tree_view is null.
-      /// This further separates the view from the controller-logic; it doesn't even need to check for null when accessing <see cref="IAlgoStudioViewController"/> methods.
-      /// </summary>
-      class EmptyController : IAlgoStudioViewController {
-         public void add_definition() { }
-         public void add_definition_clone(AlgoDefinitionVM src_definition) { }
-         public void add_template(AlgoDefinitionVM definition) { }
-         public void rename_definition(AlgoDefinitionVM definition) { }
-         public void rename_template(AlgoDefinitionTemplateVM template) { }
-         public void end_edit(ExecutedRoutedEventArgs e) { }
-         public void select_definition(AlgoDefinitionVM definition) { }
-         public void select_template(AlgoDefinitionTemplateVM template) { }
-         public IDisposable preserve_selected_definition() => Disposable.empty;
-         public void Dispose() { }
-      }
-
-      class Controller : IAlgoStudioViewController {
-         readonly AlgoStudioVM _vm;
-         readonly TreeView _tree_view;
-         readonly TextBox _name_text_box;
-         IDisposable _dispose;
-
-         public Controller(AlgoStudioVM vm, TreeView tree_view, TextBox name_text_box, Button color_picker_button, Popup color_picker_popup) {
-            _vm = vm;
-            _tree_view = tree_view;
-            _name_text_box = name_text_box;
-            _dispose = PopupViewController.attach(color_picker_popup, color_picker_button);
-         }
-
-         public void add_definition() {
-            _vm.add_new_definition();
-            _begin_edit();
-         }
-
-         public void add_definition_clone(AlgoDefinitionVM src_definition) {
-            _vm.add_new_definition_clone(src_definition);
-            _begin_edit();
-         }
-
-         public void add_template(AlgoDefinitionVM def) {
-            var new_tmp = def.template_factory();
-            def.templates.Add(new_tmp);
-            _begin_edit();
-         }
-
-         public void end_edit(ExecutedRoutedEventArgs e) {
-            if (e.OriginalSource is EditableTextBlock etb) {
-               etb.end_edit();
-               _get_container(etb.DataContext)?.SetCurrentValue(TreeViewItem.IsSelectedProperty, true);
-            }
-         }
-
-         public void rename_definition(AlgoDefinitionVM definition) {
-            if (_tree_view.ItemContainerGenerator.ContainerFromItem(definition) is TreeViewItem tvi) {
-               var etb = tvi.descendants_of_type<EditableTextBlock>().FirstOrDefault();
-               etb.SetCurrentValue(EditableTextBlock.IsEditingProperty, true);
-            }
-         }
-
-         public void rename_template(AlgoDefinitionTemplateVM template) {
-            if (_tree_view.ItemContainerGenerator.ContainerFromItem(template.owner) is TreeViewItem tvi) {
-               if (tvi.ItemContainerGenerator.ContainerFromItem(template) is TreeViewItem ttvi) {
-                  var etb = ttvi.descendants_of_type<EditableTextBlock>().FirstOrDefault();
-                  etb.SetCurrentValue(EditableTextBlock.IsEditingProperty, true);
-               }
-            }
-         }
-
-         public void select_definition(AlgoDefinitionVM definition) =>
-            _tree_view.ItemContainerGenerator.ContainerFromItem(definition)?.SetCurrentValue(TreeViewItem.IsSelectedProperty, true);
-
-         public void select_template(AlgoDefinitionTemplateVM template) {
-            if (_tree_view.ItemContainerGenerator.ContainerFromItem(template.owner) is TreeViewItem def_view) {
-               def_view.SetCurrentValue(TreeViewItem.IsSelectedProperty, true);
-               def_view.ItemContainerGenerator.ContainerFromItem(template)?.SetCurrentValue(TreeViewItem.IsSelectedProperty, true);
-            }
-         }
-
-         public IDisposable preserve_selected_definition() =>
-            Disposable.Create(() => {
-               var name = _vm.selected_definition.name;
-               if (_vm.definitions.TryGetFirst(d => d.name == name, out AlgoDefinitionVM def))
-                  _tree_view.ItemContainerGenerator.ContainerFromItem(def)?.SetCurrentValue(TreeViewItem.IsSelectedProperty, true);
-            });
-
-         public void Dispose() =>
-            Disposable.dispose(ref _dispose);
-
-         void _begin_edit() =>
-            WPFHelper.push_frame_until(() => Keyboard.Focus(_name_text_box) == _name_text_box);
-
-         TreeViewItem _get_container(object obj) =>
-            obj is AlgoDefinitionTemplateVM t ? _get_container(t) :
-               obj is AlgoDefinitionVM d ? _get_container(d) : null;
-
-         TreeViewItem _get_container(AlgoDefinitionVM d) =>
-            _tree_view.ItemContainerGenerator.ContainerFromItem(d) as TreeViewItem;
-
-         TreeViewItem _get_container(AlgoDefinitionTemplateVM t) =>
-            _get_container(t.owner) is TreeViewItem dview ? dview.ItemContainerGenerator.ContainerFromItem(t) as TreeViewItem : null;
-      }
-   }
-}

src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioWindow.cs

@@ -62,35 +62,19 @@ namespace mbts.spark {
          _vm = new AlgoStudioVM(_model);
          _vm.load_from(_state);
          _view = new AlgoStudioView { DataContext = _vm };
-         _view.Resources[AlgoStudioView.BadgesInTreeViewVisibilityKey] = _ui_configuration.show_badges_in_tree_view ? Visibility.Visible : Visibility.Collapsed;
          _resources = new CompositeDisposable();
-         // observable sources
-          var content_src = _vm.observe_selected().Select(_ => _vm.content_source);
          // add definition
-         _commands.Add(new SparkCommandCommand("Add Algo", Icons.AddBoxes, new DelegateCommand(_view.add_definition)));
-         // add definition clone
-         var add_definition_clone_spark_cmd = new ObservantSparkCommandCommand<AlgoDefinitionVM>(Icons.DocumentCopy, d => $"Clone '{d?.name}'", d => d != null, _view.add_definition_clone);
-         _commands.Add(add_definition_clone_spark_cmd);
-         // add template
-         var add_template_spark_cmd = new ObservantSparkCommandCommand<AlgoDefinitionVM>(Icons.AddFile, d => $"Add '{d?.name}' Template", d => d != null, _view.add_template) {
-            show_in_toolbar = (_ui_configuration.add_template_button & bts.config.AlgoStudioOptions.AddTemplateButton.MainToolBar) == bts.config.AlgoStudioOptions.AddTemplateButton.MainToolBar,
-            show_in_context_menu = (_ui_configuration.add_template_button & bts.config.AlgoStudioOptions.AddTemplateButton.DefinitionContextMenu) == bts.config.AlgoStudioOptions.AddTemplateButton.DefinitionContextMenu
-         };
-         _commands.Add(add_template_spark_cmd);
-         _resources.Add(_vm.subscribe_definition().OnDispatcher().Subscribe(add_definition_clone_spark_cmd, add_template_spark_cmd));
+         _commands.Add(new SparkCommandCommand("Add Algo", Icons.AddBoxes, _vm.add_definition_cmd));
+         // clone definition
+         var clone_selected_definition_spark_cmd = new SparkCommandCommand(string.Empty, Icons.DocumentCopy, _vm.clone_selected_definition_cmd);
+         _commands.Add(clone_selected_definition_spark_cmd);
+         _resources.Add(_vm.subscribe_definition().OnDispatcher().Subscribe(
+            def => clone_selected_definition_spark_cmd.title = def == null ? $"Clone (None Selected)" : $"Clone '{def.name}'"));
          // save
          if (_ui_configuration.can_save_specific) {
-            var content_is_dirty_src = _vm.observe_selected().SelectManyInSeries(t => {
-               if (t.template != null) {
-                  return t.template.observe_is_dirty();
-               } else if (t.definition != null) {
-                  return t.definition.subscribe_is_definition_dirty();
-               } else return Observable.Return(false);
-            }).RefCount();
-            _commands.Add(new ReactiveSparkCommand(content_src.OnDispatcher().Select(c => $"Save '{c?.name}'"), Icons.DiskFile, () => {
-               if (_vm.selected_template is AlgoDefinitionTemplateVM t)
-                  _vm.save_template(t).ignore();
-               else if (_vm.selected_definition is AlgoDefinitionVM d)
+            var content_is_dirty_src = _vm.subscribe_definition().SelectManyInSeries(def => def?.subscribe_is_definition_dirty() ?? Observable.Return(false));
+            _commands.Add(new ReactiveSparkCommand(_vm.subscribe_definition().OnDispatcher().Select(c => $"Save '{c?.name}'"), Icons.DiskFile, () => {
+               if (_vm.selected_definition is AlgoDefinitionVM d)
                   _vm.save_definition(d).ignore();
             }, content_is_dirty_src));
          }
@@ -101,50 +85,39 @@ namespace mbts.spark {
          // undo/redo
          if (_ui_configuration.can_undo_redo) {
             // undo
-            var undo_cmd = new ObservantCommand(() => _vm.content_source?.try_undo());
+            var undo_cmd = new ObservantCommand(() => _vm.selected_definition?.try_undo());
             var undo_spark_cmd = new SparkCommandCommand("Undo", Icons.UndoCircular, undo_cmd);
-            var can_undo_source = _vm.observe_selected().SelectManyInSeries(tup => {
-               IAlgoStudioContentVM content = (IAlgoStudioContentVM)tup.template ?? tup.definition;
-               return content != null ?
+            var can_undo_source = _vm.subscribe_definition().SelectManyInSeries(def =>
+               def != null ?
                   Observable.Create<bool>(o => {
-                     content.can_undo_changed += notify;
+                     def.can_undo_changed += notify;
                      notify();
-                     return Disposable.Create(() => content.can_undo_changed -= notify);
-                     void notify() => o.OnNext(content.can_undo);
+                     return Disposable.Create(() => def.can_undo_changed -= notify);
+                     void notify() => o.OnNext(def.can_undo);
                   }) :
-                  Observable.Return(false);
-            });
+                  Observable.Return(false));
             _commands.Add(undo_spark_cmd);
             _resources.Add(can_undo_source.Subscribe(undo_cmd));
-            _resources.Add(can_undo_source.Connect());
             // redo
-            var redo_cmd = new ObservantCommand(() => _vm.content_source?.try_redo());
+            var redo_cmd = new ObservantCommand(() => _vm.selected_definition?.try_redo());
             var redo_spark_cmd = new SparkCommandCommand("Redo", Icons.RedoCircular, redo_cmd);
-            var can_redo_source = _vm.observe_selected().SelectManyInSeries(tup => {
-               IAlgoStudioContentVM content = (IAlgoStudioContentVM)tup.template ?? tup.definition;
-               return content != null ?
+            var can_redo_source = _vm.subscribe_definition().SelectManyInSeries(def =>
+               def != null ?
                   Observable.Create<bool>(o => {
-                     content.can_redo_changed += notify;
+                     def.can_redo_changed += notify;
                      notify();
-                     return Disposable.Create(() => content.can_redo_changed -= notify);
-                     void notify() => o.OnNext(content.can_redo);
+                     return Disposable.Create(() => def.can_redo_changed -= notify);
+                     void notify() => o.OnNext(def.can_redo);
                   }) :
-                  Observable.Return(false);
-            });
+                  Observable.Return(false));
             _commands.Add(redo_spark_cmd);
             _resources.Add(can_redo_source.Subscribe(redo_cmd));
-            _resources.Add(can_redo_source.Connect());
          }
          // remove
          var remove_spark_cmd = new ObservantSparkCommandCommand<IAlgoStudioContentVM>(Icons.Trash, v => $"Remove '{v?.name}'", v => v != null, value => {
-            if (value is AlgoDefinitionTemplateVM t) {
-               _vm.remove_template(t).ignore();
-            } else if (value is AlgoDefinitionVM d) {
+            if (value is AlgoDefinitionVM d) {
                string prompt; MessageBoxImage icon;
-               if (_model.algo_model.templates_enabled() && d.templates.Count > 0) {
-                  prompt = $"Deleting this definition ({d.name}) will also delete its templates ({d.templates.Count}).\n\nDo you wan to Continue?";
-                  icon = MessageBoxImage.Warning;
-               } else if (d.key.mode == AlgoKey.Mode.Persisted) {
+               if (d.key.mode == AlgoKey.Mode.Persisted) {
                   prompt = $"Are you sure you want to delete '{d.name}?'";
                   icon = MessageBoxImage.Question;
                } else {
@@ -164,7 +137,7 @@ namespace mbts.spark {
             }
          });
          _commands.Add(remove_spark_cmd);
-         _resources.Add(content_src.OnDispatcher().Subscribe(remove_spark_cmd));
+         _resources.Add(_vm.subscribe_definition().OnDispatcher().Subscribe(remove_spark_cmd));
       }
 
       void _dispose_core() {

src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoData.cs

@@ -1,31 +1,59 @@
 using bts.api.orderman;
+using bts.api.orderman.algo;
 using bts.utils;
 using mbts.spark.utilities;
 using System;
 using System.Windows.Media;
 
 namespace mbts.spark {
+   // This is a core data type on the front end, so data validation is strict, as bad values may yield weird/difficult to track bugs.
+   // Descriptive factory methods are favored over public constructors, as they are less likely to be misused.
    struct AlgoData : IEquatable<AlgoData> {
       public readonly CustomOrderDefinitionImmutable value;
       public readonly string name;
       public readonly AlgoKey key;
 
-      public AlgoData(CustomOrderDefinitionImmutable value)
-         : this(value, value.display_name(), OrderDataHelper.get_shallow_factory_key(value)) { }
-
-      public AlgoData(CustomOrderDefinitionImmutable value, string name, AlgoKey key) {
+      AlgoData(CustomOrderDefinitionImmutable value, string name, AlgoKey key) {
          this.value = value;
          this.name = name;
          this.key = key;
       }
 
-      public AlgoData with(CustomOrderDefinitionImmutable? value = null, string name = null) =>
-         new AlgoData(value ?? this.value, name ?? this.name, key);
+      public static AlgoData empty => from_custom_def(new CustomOrderDefinitionImmutable(new CustomOrderDefinition()));
+
+      /// <summary>
+      /// This is the only <see cref="AlgoData"/> factory method that allows callers to explicitly specify a name.
+      /// It should only be used within the context of creating, or renaming, studio algos.
+      /// </summary>
+      public static AlgoData create(CustomOrderDefinitionImmutable def, string name, AlgoKey key) =>
+         new AlgoData(def, name, key);
+
+      /// <summary>
+      /// Reconstructs <see cref="AlgoData"/> from a <see cref="CustomOrderDefinitionImmutable"/>, with a special caveat in the case of <see cref="CompositeOrderDefinition"/>:
+      /// a fallback/default name is used instead of the composite algo's true name, which must be obtained from the <see cref="IAlgoStudioModel.definitions"/> stream.
+      /// </summary>
+      public static AlgoData from_custom_def(CustomOrderDefinitionImmutable def) {
+         switch (def.CustomCase) {
+            case CustomOrderDefinition.CustomOneofCase.Composite:
+               string name = $"({OrderDataHelper.abbreviate_algo_type(def.CustomCase)}){OrderDataHelper.abbreviate_algo_type(def.Composite.Definition.CustomCase)}";
+               return new AlgoData(def.Composite.Definition, name, AlgoKey.from_composite_key(def.Composite.AlgoTemplateKey));
+            case CustomOrderDefinition.CustomOneofCase.Dynamic:
+               return new AlgoData(def,def.Dynamic.DynamicOrderType, AlgoKey.from_dynamic_type(def.Dynamic.DynamicOrderType));
+            default:
+               return new AlgoData(def, def.CustomCase.display_name(), AlgoKey.from_known_type(def.CustomCase));
+         }
+      }
+
+      public static AlgoData from_record(AlgoDefinitionRecordImmutable record) =>
+         new AlgoData(record.Algo.Definition, record.Algo.Name, AlgoKey.from_composite_key(record.Key));
+
+      public static AlgoData create_unpersisted(CustomOrderDefinitionImmutable custom_def, string name) =>
+         new AlgoData(custom_def, name, AlgoKey.create_unpersisted());
 
       public bool Equals(AlgoData other) =>
          key == other.key &&
          name == other.name &&
-         OrderDataHelper.EqualsHelpers.custom_order_def_compareri.Equals(value, other.value);
+         OrderDataHelper.EqualsHelpers.custom_order_defi_comparer.Equals(value, other.value);
 
       public override bool Equals(object obj) => EqualityComparer.equals_obj(this, obj);
       public override int GetHashCode() =>
@@ -39,6 +67,8 @@ namespace mbts.spark {
    }
 
    struct AlgoDataVM : IEquatable<AlgoDataVM> {
+      public static readonly Func<AlgoDataVM, AlgoID> id_fn = vm => AlgoID.from_algo_key(vm.data.key);
+
       public readonly AlgoData data;
       public readonly AlgoDefinitionMetadata? meta;
 

src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoKey.cs

@@ -1,10 +1,13 @@
 using bts.api.orderman;
-using bts.persist.algo;
 using bts.utils;
+using mbts.utils;
 using ProtoBuf;
 using System;
+using System.Linq;
 
 namespace mbts.spark {
+   // This is a core data type on the front end, so data validation is strict, as bad values may yield weird/difficult to track bugs.
+   // Descriptive factory methods are favored over public constructors, as they are less likely to be misused.
    [ProtoContract]
    struct AlgoID : IEquatable<AlgoID> {
       [ProtoMember(1)]
@@ -14,6 +17,11 @@ namespace mbts.spark {
       [ProtoMember(3)]
       readonly uint? _persisted_key;
 
+      public static readonly AlgoID[] exchange_algo_keys = utilities.OrderDataHelper.outright_order_types
+         .Concat(new CustomOrderDefinition.CustomOneofCase[] { CustomOrderDefinition.CustomOneofCase.Spreader })
+         .Select(cooc => new AlgoID(cooc))
+         .ToArray();
+
       public AlgoID(CustomOrderDefinition.CustomOneofCase factory_key) {
          _factory_key = factory_key;
          _dynamic_key = null;
@@ -32,24 +40,31 @@ namespace mbts.spark {
          _persisted_key = persisted_key;
       }
 
-      public static AlgoID from_order_def(OrderDefinitionImmutable order_def) {
-         switch (order_def.CustomDef.CustomCase) {
-            case CustomOrderDefinition.CustomOneofCase.Composite: return new AlgoID(order_def.CustomDef.Composite.AlgoTemplateKey);
-            case CustomOrderDefinition.CustomOneofCase.Dynamic: return new AlgoID(order_def.CustomDef.Dynamic.DynamicOrderType);
-            default: return new AlgoID(order_def.CustomDef.CustomCase);
+      public static AlgoID from_custom_def(CustomOrderDefinitionImmutable custom_def) {
+         switch (custom_def.CustomCase) {
+            case CustomOrderDefinition.CustomOneofCase.Composite: return new AlgoID(custom_def.Composite.AlgoTemplateKey);
+            case CustomOrderDefinition.CustomOneofCase.Dynamic: return new AlgoID(custom_def.Dynamic.DynamicOrderType);
+            default: return new AlgoID(custom_def.CustomCase);
          }
       }
 
       public static AlgoID from_algo_key(AlgoKey key) {
          switch (key.mode) {
-            case AlgoKey.Mode.Factory:
-               if (key.factory.structure.structure.Count > 0)
-                  return new AlgoID((CustomOrderDefinition.CustomOneofCase)key.factory.structure.structure[0]);
-               break;
-            case AlgoKey.Mode.Persisted:
-               return new AlgoID(key.persisted.id_uint);
+            case AlgoKey.Mode.Factory: return new AlgoID(key.factory);
+            case AlgoKey.Mode.Dynamic: return new AlgoID(key.dynamic_type);
+            case AlgoKey.Mode.Persisted: return new AlgoID(key.persisted);
+            default: throw ExceptionBuilder.Argument.unexpected_case(key.mode, nameof(key));
          }
-         return new AlgoID(CustomOrderDefinition.CustomOneofCase.None);
+      }
+
+      public static AlgoKey to_algo_key(AlgoID id) {
+         if (id._factory_key.HasValue)
+            return AlgoKey.from_known_type(id._factory_key.Value);
+         if (id._persisted_key.HasValue)
+            return AlgoKey.from_composite_key(id._persisted_key.Value);
+         if (id._dynamic_key != null)
+            return AlgoKey.from_dynamic_type(id._dynamic_key);
+         throw new ArgumentException("ID is empty.", nameof(id));
       }
 
       public bool Equals(AlgoID other) =>
@@ -58,7 +73,7 @@ namespace mbts.spark {
          _persisted_key == other._persisted_key;
 
       public override bool Equals(object obj) =>
-         obj is AlgoID && Equals(obj);
+         obj is AlgoID other && Equals(other);
 
       public override int GetHashCode() =>
          EqualityComparer.aggregate_hash(
@@ -70,55 +85,93 @@ namespace mbts.spark {
       public static bool operator !=(AlgoID a, AlgoID b) => !a.Equals(b);
    }
 
-   /// TODO: Remove <see cref="AlgoKey"/>, and redirect references to <see cref="AlgoID"/>.
    struct AlgoKey : IEquatable<AlgoKey> {
-      readonly AlgoPersistedKey? _persisted_key;
-      readonly AlgoNameStructureKey? _factory_key;
+      readonly uint? _composite_key;
       readonly Guid? _unpersisted;
+      readonly string _dynamic_type;
+      readonly CustomOrderDefinition.CustomOneofCase? _factory_type;
 
-      public AlgoKey(Guid id_guid) {
-         _persisted_key = null;
-         _factory_key = null;
+      AlgoKey(Guid id_guid) {
+         _composite_key = null;
          _unpersisted = id_guid;
+         _dynamic_type = null;
+         _factory_type = null;
       }
 
-      public AlgoKey(CustomOrderDefinition.CustomOneofCase factory_root_algo_type)
-         : this(new AlgoNameStructureKey(factory_root_algo_type)) { }
-
-      public AlgoKey(AlgoNameStructureKey factory_key) {
-         _persisted_key = null;
-         _factory_key = factory_key;
+      public AlgoKey(uint composite_key) {
+         _composite_key = composite_key;
          _unpersisted = null;
+         _dynamic_type = null;
+         _factory_type = null;
       }
 
-      public AlgoKey(AlgoPersistedKey persisted_key) {
-         _persisted_key = persisted_key;
-         _factory_key = null;
+      public AlgoKey(string dynamic_type) {
+         _composite_key = null;
          _unpersisted = null;
+         _dynamic_type = dynamic_type;
+         _factory_type = null;
+      }
+
+      public AlgoKey(CustomOrderDefinition.CustomOneofCase factory_type) {
+         _composite_key = null;
+         _unpersisted = null;
+         _dynamic_type = null;
+         _factory_type = factory_type;
       }
 
       public enum Mode {
          None,
          Persisted,
          Unpersisted,
+         Dynamic,
          Factory
       }
 
       public bool is_persisted => mode == Mode.Persisted;
 
-      public AlgoPersistedKey persisted => _persisted_key.Value;
-      public AlgoNameStructureKey factory => _factory_key ?? new AlgoNameStructureKey(CustomOrderDefinition.CustomOneofCase.None);
+      public uint persisted => _composite_key.Value;
       public Guid unpersisted => _unpersisted.Value;
+      public CustomOrderDefinition.CustomOneofCase factory => _factory_type.Value;
+      public string dynamic_type => _dynamic_type;
 
       public Mode mode {
          get {
-            if (_persisted_key.HasValue) return Mode.Persisted;
+            if (_factory_type.HasValue) return Mode.Factory;
+            if (_composite_key.HasValue) return Mode.Persisted;
+            if (_dynamic_type != null) return Mode.Dynamic;
             if (_unpersisted.HasValue) return Mode.Unpersisted;
-            if (_factory_key.HasValue) return Mode.Factory;
             return Mode.None;
          }
       }
 
+      public static AlgoKey create_unpersisted() =>
+         new AlgoKey(Guid.NewGuid());
+
+      public static AlgoKey from_custom_def(CustomOrderDefinitionImmutable custom_def) {
+         switch (custom_def.CustomCase) {
+            case CustomOrderDefinition.CustomOneofCase.Dynamic: return new AlgoKey(custom_def.Dynamic.DynamicOrderType);
+            case CustomOrderDefinition.CustomOneofCase.Composite: return new AlgoKey(custom_def.Composite.AlgoTemplateKey);
+            default: return new AlgoKey(custom_def.CustomCase);
+         }
+      }
+
+      public static AlgoKey from_known_type(CustomOrderDefinition.CustomOneofCase known_type) {
+         if (known_type == CustomOrderDefinition.CustomOneofCase.Dynamic)
+            throw new ArgumentException(nameof(known_type), "Potential loss of data: no dynamic type name specified.");
+         if (known_type == CustomOrderDefinition.CustomOneofCase.Composite)
+            throw new ArgumentException(nameof(known_type), "Potential loss of data: no composite id specified.");
+         return new AlgoKey(known_type);
+      }
+
+      public static AlgoKey from_dynamic_type(string dynamic_type) {
+         if (string.IsNullOrEmpty(dynamic_type))
+            throw ExceptionBuilder.Argument.null_or_empty(nameof(dynamic_type));
+         return new AlgoKey(dynamic_type);
+      }
+
+      public static AlgoKey from_composite_key(uint composite_key) =>
+         new AlgoKey(composite_key);
+
       public bool Equals(AlgoKey other) {
          Mode m = mode;
          if (m == other.mode) {
@@ -126,6 +179,7 @@ namespace mbts.spark {
                case Mode.Persisted: return persisted == other.persisted;
                case Mode.Unpersisted: return unpersisted == other.unpersisted;
                case Mode.Factory: return factory == other.factory;
+               case Mode.Dynamic: return dynamic_type == other.dynamic_type;
                case Mode.None: return true;
             }
          }
@@ -140,6 +194,7 @@ namespace mbts.spark {
             case Mode.Persisted: hash = persisted.GetHashCode(); phase_mult = 2; break;
             case Mode.Unpersisted: hash = unpersisted.GetHashCode(); phase_mult = 4; break;
             case Mode.Factory: hash = factory.GetHashCode(); phase_mult = 3; break;
+            case Mode.Dynamic: hash = dynamic_type.GetHashCode(); phase_mult = 5; break;
             default: return 0;
          }
          return EqualityComparer.phase_hash(hash, phase_mult);
@@ -150,4 +205,4 @@ namespace mbts.spark {
 
       InvalidOperationException _unexpected_mode_ex() => new InvalidOperationException($"Unexpected Mode '{mode}.'");
    }
-}
+}

src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoPersistedKey.cs

@@ -40,7 +40,7 @@ namespace bts.persist.algo {
       public bool is_persisted => mode != Mode.None;
 
       public mbts.spark.AlgoKey to_algo_key() =>
-         new mbts.spark.AlgoKey(this);
+         new mbts.spark.AlgoKey(_id_uint ?? 0);
 
       public bool Equals(AlgoPersistedKey other) {
          Mode m = mode;

src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoStructureKey.cs

@@ -1,167 +0,0 @@
-using bts.api.orderman;
-using bts.utils;
-using mbts.spark.utilities;
-using mbts.ui.utility;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-
-namespace mbts.spark {
-   struct AlgoNameStructureKey : IEquatable<AlgoNameStructureKey> {
-      public readonly string name;
-      public readonly AlgoStructureKey structure;
-
-      public AlgoNameStructureKey(CustomOrderDefinition.CustomOneofCase base_type)
-         : this(base_type.type_id(), new AlgoStructureKey(base_type)) { }
-
-      public AlgoNameStructureKey(string name, AlgoStructureKey structure) {
-         this.name = name;
-         this.structure = structure;
-      }
-
-      public bool Equals(AlgoNameStructureKey other) => name == other.name && structure == other.structure;
-      public override bool Equals(object obj) => EqualityComparer.equals_obj(this, obj);
-      public override int GetHashCode() => EqualityComparer.aggregate_hash(EqualityComparer.safe_get_hash_code(name), structure.GetHashCode());
-      public static bool operator ==(AlgoNameStructureKey a, AlgoNameStructureKey b) => a.Equals(b);
-      public static bool operator !=(AlgoNameStructureKey a, AlgoNameStructureKey b) => !a.Equals(b);
-   }
-
-   struct AlgoStructureKey : IEquatable<AlgoStructureKey> {
-      readonly int[] _structure;
-
-      public AlgoStructureKey(CustomOrderDefinition.CustomOneofCase base_type)
-         : this(new[] { (int)base_type }) { }
-
-      public AlgoStructureKey(CustomOrderDefinitionImmutable definition, IMaskIndexInt32<string> dynamic_type_index) =>
-         _structure = AlgoStructureSerializer.to_array(definition, dynamic_type_index);
-
-      public AlgoStructureKey(int[] structure) =>
-         _structure = structure;
-
-      public IReadOnlyList<int> structure => _structure ?? Array.Empty<int>();
-
-      public bool Equals(AlgoStructureKey other) {
-         if (_structure == null) {
-            return other._structure == null;
-         } else {
-            /// <see cref="Enumerable.SequenceEqual{TSource}(IEnumerable{TSource}, IEnumerable{TSource})"/> is not optimized to check Count/Length, since the args are <see cref="IEnumerable{T}"/>.
-            return other._structure != null && _structure.Length == other._structure.Length && _structure.SequenceEqual(other._structure);
-         }
-      }
-
-      public override bool Equals(object obj) =>
-         obj is AlgoStructureKey other && Equals(other);
-
-      public override int GetHashCode() =>
-         _structure == null ? 0 : EqualityComparer.aggregate_hash(_structure);
-
-      public static bool operator ==(AlgoStructureKey a, AlgoStructureKey b) => a.Equals(b);
-      public static bool operator !=(AlgoStructureKey a, AlgoStructureKey b) => !a.Equals(b);
-   }
-
-   static class AlgoStructureSerializer {
-      const int
-         _dynamic_mask = 1 << 31,
-         _child_mask_offset = 30;
-
-      public static CustomOrderDefinitionImmutable build_algoi(this AlgoStructureKey structure_key, DynamicOrderHelper dynamic_helper) =>
-         parsei(structure_key.structure, dynamic_helper);
-
-      public static CustomOrderDefinitionImmutable build_algo(this AlgoStructureKey structure_key, DynamicOrderHelper dynamic_helper) =>
-         parsei(structure_key.structure, dynamic_helper);
-
-      public static CustomOrderDefinition.CustomOneofCase order_type(this AlgoStructureKey structure_key) =>
-         structure_key.structure.Count > 0 ? (CustomOrderDefinition.CustomOneofCase)structure_key.structure[0] : CustomOrderDefinition.CustomOneofCase.None;
-
-      public static AlgoStructureKey structure_key(CustomOrderDefinitionImmutable algo, IMaskIndexInt32<string> dynamic_type_index) =>
-         new AlgoStructureKey(to_array(algo, dynamic_type_index));
-
-      public static AlgoStructureKey structure_key(CustomOrderDefinition algo, IMaskIndexInt32<string> dynamic_type_index) =>
-         new AlgoStructureKey(to_array(algo, dynamic_type_index));
-
-      public static int[] to_array(CustomOrderDefinitionImmutable algo, IMaskIndexInt32<string> dynamic_type_index) =>
-         to_array(algo.CloneToMutable(), dynamic_type_index);
-
-      public static int[] to_array(CustomOrderDefinition algo, IMaskIndexInt32<string> dynamic_type_index) {
-         int[] s = new[] { (int)algo.CustomCase };
-         _build_structure(algo, ref s, dynamic_type_index);
-         return s;
-      }
-
-      public static CustomOrderDefinitionImmutable from_array(int[] structure, DynamicOrderHelper dynamic_helper) =>
-         parsei(structure, dynamic_helper);
-
-      public static CustomOrderDefinitionImmutable parsei(IReadOnlyList<int> structure, DynamicOrderHelper dynamic_helper) =>
-         new CustomOrderDefinitionImmutable(parse(structure, dynamic_helper));
-
-      public static CustomOrderDefinition parse(IReadOnlyList<int> structure, DynamicOrderHelper dynamic_helper) {
-         if (structure == null || structure.Count == 0)
-            return new CustomOrderDefinition();
-         int pos = 1;
-         var mdef = OrderDataHelper.create_algo((CustomOrderDefinition.CustomOneofCase)structure[0]);
-         _build_def(structure, ref pos, ref mdef, dynamic_helper);
-         return mdef;
-      }
-
-      static void _build_structure(CustomOrderDefinition algo, ref int[] structure, IMaskIndexInt32<string> dynamic_type_index) {
-         if (structure == null || structure.Length == 0)
-            structure = new int[1];
-         structure[0] = (int)algo.CustomCase;
-         int p = 1;
-         _build_structure(algo, ref structure, ref p, dynamic_type_index);
-         ArrayHelper.trim(ref structure, p);
-      }
-
-      static void _build_structure(CustomOrderDefinition algo, ref int[] structure, ref int pos, IMaskIndexInt32<string> dynamic_type_index) {
-         IEnumerable<(CustomOrderDefinition child_algo, int field_pos)> children;
-         if (algo.CustomCase == CustomOrderDefinition.CustomOneofCase.Dynamic) {
-            ArrayHelper.ensure_capacity(ref structure, pos + 1);
-            structure[pos++] = dynamic_type_index.to_int(algo.Dynamic.DynamicOrderType) | _dynamic_mask;
-            children = algo.Dynamic.OrderParams.Where(kv => kv.Value.ValueCase == DynamicOrderParam.ValueOneofCase.AsOrderDef).Select((kv, i) => (kv.Value.AsOrderDef, i));
-         } else {
-            var cad = OrderDataHelper.get_child_algo_data(algo);
-            children = cad.Select((c, i) => (c.get_child(algo), i));
-            children = children.Where(c => c.child_algo != null);
-         }
-         foreach ((var child, int field_pos) in children) {
-            ArrayHelper.ensure_capacity(ref structure, pos + 1);
-            structure[pos++] = EnumMaskIndexInt32<CustomOrderDefinition.CustomOneofCase>.to_int(child.CustomCase) | _child_algo_mask(field_pos);
-            _build_structure(child, ref structure, ref pos, dynamic_type_index);
-         }
-      }
-
-      /// <summary>
-      /// Gets a mask for a particular child-algo field of a particular algo definition.
-      /// </summary>
-      /// <param name="field_pos">The index wrt the deterministic enumeration of child algos for a particular definition (e.g., Hedge = 0, Child = 1).</param>
-      static int _child_algo_mask(int field_pos) => 1 << (_child_mask_offset - field_pos);
-
-      static void _build_def(IReadOnlyList<int> structure, ref int pos, ref CustomOrderDefinition algo, DynamicOrderHelper dynamic_helper) {
-         var local_algo = algo;
-         IEnumerable<(Action<CustomOrderDefinition> assign_child, int field_pos)> children;
-         if (algo.CustomCase == CustomOrderDefinition.CustomOneofCase.Dynamic) {
-            var dyn_def = algo.Dynamic;
-            dyn_def.DynamicOrderType = dynamic_helper.dynamic_type_index.from_int(structure[pos++] ^ _dynamic_mask);
-            dynamic_helper.add_dynamic_params(ref dyn_def);
-            children = dyn_def.OrderParams
-               .Where(kv => kv.Value.ValueCase == DynamicOrderParam.ValueOneofCase.AsOrderDef)
-               .Select((kv, i) => (new Action<CustomOrderDefinition>(child_algo => kv.Value.AsOrderDef = child_algo), i));
-         } else {
-            children = OrderDataHelper.get_child_algo_data(algo)
-               .Select((c, i) => (new Action<CustomOrderDefinition>(child_algo => c.assign_child(local_algo, child_algo)), i));
-         }
-         using (var children_en = children.GetEnumerator()) {
-            while (pos < structure.Count && children_en.MoveNext()) {
-               (var assign_child, int field_pos) = children_en.Current;
-               int mask = _child_algo_mask(field_pos);
-               if ((structure[pos] & mask) == mask) {
-                  var type = EnumMaskIndexInt32<CustomOrderDefinition.CustomOneofCase>.from_int(structure[pos++] ^ mask);
-                  var child_algo = OrderDataHelper.create_algo(type);
-                  _build_def(structure, ref pos, ref child_algo, dynamic_helper);
-                  assign_child(child_algo);
-               }
-            }
-         }
-      }
-   }
-}

src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoStudioDefinitionTemplateModel.cs

@@ -1,345 +0,0 @@
-using bts;
-using bts.api;
-using bts.api.core;
-using bts.api.orderman;
-using bts.persist.algo;
-using bts.spark;
-using mbts.utils;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Reactive.Disposables;
-using System.Reactive.Linq;
-using System.Threading.Tasks;
-
-namespace mbts.spark {
-   class AlgoStudioDefinitionTemplateModel : IAlgoStudioModel, IDisposable {
-      readonly AlgoService _service;
-      readonly AdminModel _admin_model;
-      readonly ErrorReporter _error_reporter;
-      readonly ObservableDemuxer<AlgoKey, AlgoDefinitionMetadata> _metadata_demuxer = new ObservableDemuxer<AlgoKey, AlgoDefinitionMetadata>();
-      readonly TableUpdateDemuxer<AlgoTemplateData, AlgoKey, AlgoKey> _definition_templates_demuxer;
-      IReadOnlyDictionary<AlgoKey, AlgoData> _algos = DictionaryHelper.empty<AlgoKey, AlgoData>();
-      IReadOnlyDictionary<AlgoKey, AlgoTemplateData> _algo_templates = DictionaryHelper.empty<AlgoKey, AlgoTemplateData>();
-      IDisposable _dispose;
-
-      public AlgoStudioDefinitionTemplateModel(AlgoService service, IAlgoDefinitionMetadataService meta, AdminModel admin_model, ErrorReporter error_reporter, bts.config.AlgoStudioOptions ui_configuration) {
-         _service = service;
-         metadata_service = meta;
-         _admin_model = admin_model;
-         _error_reporter = error_reporter;
-         this.ui_configuration = ui_configuration;
-         _definition_templates_demuxer = new TableUpdateDemuxer<AlgoTemplateData, AlgoKey, AlgoKey>(t => t.key, t => t.definition_key);
-         definitions = _service.subscribei_algos()
-            .Select(u => new Update<AlgoData, AlgoKey>(
-               u.all.Select(_Utils.definition_data).ToList(),
-               u.added.Select(_Utils.definition_data).ToList(),
-               u.changes.Select(ch => new Change<AlgoData>(_Utils.definition_data(ch.Old), _Utils.definition_data(ch.New))).ToList(),
-               u.removed.Select(d => _Utils.definition_data(d)).ToList(),
-               def => def.key))
-            .Table()
-            .Cache();
-         templates = _service.subscribei_algo_templates()
-            .Select(u => new Update<AlgoTemplateData, AlgoKey>(
-               u.all.Select(_Utils.template_data).ToList(),
-               u.added.Select(_Utils.template_data).ToList(),
-               u.changes.Select(ch => new Change<AlgoTemplateData>(_Utils.template_data(ch.Old), _Utils.template_data(ch.New))).ToList(),
-               u.removed.Select(_Utils.template_data).ToList(),
-               def => def.key))
-            .Table()
-            .Cache();
-         _dispose = new CompositeDisposable(
-            definitions.OnDispatcher().Subscribe(t => _algos = t.state),
-            templates.OnDispatcher().Subscribe(t => _algo_templates = t.state),
-            templates.Subscribe(_definition_templates_demuxer),
-            metadata_service.subscribe_metadata().Subscribe(_metadata_demuxer));
-      }
-
-      public IObservable<TableUpdate<AlgoData, AlgoKey>> definitions { get; }
-      public IObservable<TableUpdate<AlgoTemplateData, AlgoKey>> templates { get; }
-      public IAlgoDefinitionMetadataService metadata_service { get; }
-      public bts.config.AlgoStudioOptions ui_configuration { get; }
-
-      public IObservable<TableUpdate<AlgoTemplateData, AlgoKey>> subscribe_definition_templates(AlgoKey definition) =>
-         _definition_templates_demuxer.subscribe(definition);
-
-      public async Task<AlgoData?> save_definition(AlgoData definition_data) {
-         if (definition_data.key.is_persisted) {
-            // TODO: implement update op when backend ready
-         } else {
-            // create op
-            return await _create_definition(new CompositeAlgoDefinitionImmutable(_Utils.to_definition(definition_data)));
-         }
-         return null;
-      }
-      public async Task<AlgoTemplateData?> save_template(AlgoTemplateData template_data) {
-         if (template_data.key.is_persisted) {
-            // update op
-            return await _update_template(_Utils.to_recordi(template_data));
-         } else {
-            // create op
-            return await _create_template(_Utils.to_templatei(template_data));
-         }
-      }
-
-      /// <summary>
-      /// The api is not used here (there are some unresolved dependency issues with definitions on the backend).
-      /// The definition is marked as hidden in the AlgoMetadata stored on the server.
-      /// <para/>
-      /// For implementation details, see: <see cref="IAlgoDefinitionMetadataService"/>, <see cref="AlgoTemplateMetadataService"/>
-      /// </summary>
-      public async Task<bool> remove_definition(AlgoKey key) {
-         if (_algos.TryGetValue(key, out AlgoData curr)) {
-            if (_definition_templates_demuxer.try_get_values(key, out IReadOnlyDictionary<AlgoKey, AlgoTemplateData> tmps)) {
-               foreach (var t in tmps.Values)
-                  await remove_template(t.key);
-            }
-            await metadata_service.hide_definition(key);
-            return true;
-         }
-         return false;
-      }
-
-      public async Task<bool> remove_template(AlgoKey template_key) {
-         var req = new AlgoServiceRemoveRequest();
-         _Utils.set_key(ref req, template_key);
-         var reply = await _safe_execute(() => _service.remove_template_async(req), ActionMetadata.remove_template);
-         return reply.success && reply.value.Success;
-      }
-
-      public void Dispose() =>
-         Disposable.dispose(ref _dispose);
-
-      async Task<AlgoData?> _create_definition(CompositeAlgoDefinitionImmutable definition) {
-         if (_try_get_user(out uint user_id)) {
-            return await _create_definition(definition, user_id);
-         } else {
-            _report_no_user_id(ActionMetadata.CreateDefinition);
-         }
-         return null;
-      }
-
-      async Task<AlgoTemplateData?> _create_template(AlgoTemplateImmutable template) {
-         if (_try_get_user(out uint user_id)) {
-            var (value, success) = await _error_reporter.safe_execute(() => _service.create_template_async(
-               new TemplateCreateRequest { UserId = user_id, NewTemplate = template.CloneToMutable() }),
-               r => r.Success, r => r.ErrMsg, ActionMetadata.CreateTemplate);
-            if (success)
-               return _Utils.template_data(value.Record);
-         } else {
-            _report_no_user_id(ActionMetadata.CreateTemplate);
-         }
-         return null;
-      }
-
-      async Task<AlgoTemplateData?> _update_template(AlgoTemplateRecordImmutable template) {
-         if (_try_get_user(out uint user_id)) {
-            var (value, success) = await _error_reporter.safe_execute(() => _service.update_template_async(
-               new TemplateUpdateRequest { Key = template.Key, UpdatedTemplate = template.AlgoTemplate.CloneToMutable() }),
-               r => r.Success, r => r.ErrMsg.ToString(), ActionMetadata.UpdateTemplate);
-            if (success)
-               return _Utils.template_data(template);
-         } else {
-            _report_no_user_id(ActionMetadata.UpdateTemplate);
-         }
-         return null;
-      }
-
-      async Task<AlgoData?> _create_definition(CompositeAlgoDefinitionImmutable definition, uint user_id) {
-         (var result, var success) = await _error_reporter.safe_execute(() => _service.create_composite_algo_async(
-            new CompositeAlgoCreateRequest {
-               NewAlgo = definition.CloneToMutable(),
-               UserId = user_id
-            }), r => r.Success, r => r.ErrMsg, "create definition");
-         return success ? _Utils.definition_data(new CompositeAlgoRecordImmutable(result.Record)) : (AlgoData?)null;
-      }
-
-      async Task<Result<T>> _safe_execute<T>(Func<Task<Result<T>>> execute, IActionMetadata<T> am) {
-         try {
-            var result = await execute();
-            if (!result.success) {
-               _report_error(am.present_progressive_desc, result.error_message);
-            } else if (!am.get_success(result.value)) {
-               _report_error(am.present_progressive_desc, am.get_error_msg(result.value));
-            }
-            return result;
-         } catch (Exception ex) {
-            _report_error(am.present_progressive_desc, ex.ToString());
-         }
-         return new Result<T>(bts.api.ApiError.UnexpectedResponse);
-      }
-
-      void _report_error(string present_progressive_desc, string msg) =>
-         _error_reporter.report_error($"Error {present_progressive_desc}: {msg}", AlgoStudioWindow.NAME, System.Windows.MessageBoxImage.Warning);
-
-      void _report_no_user_id(string desc) =>
-         _error_reporter.report_error($"{desc} failed: did not find current user id");
-
-      bool _try_get_user(out uint id) {
-         var user = _admin_model.get_current_user();
-         if (user.HasValue) {
-            id = user.Value.id;
-            return true;
-         } else {
-            id = 0;
-            return false;
-         }
-      }
-
-      // used for error handling/reporting
-      interface IActionMetadata {
-         string desc { get; }
-         string present_progressive_desc { get; }
-      }
-
-      interface IActionMetadata<TReply> : IActionMetadata {
-         bool get_success(TReply reply);
-         string get_error_msg(TReply reply);
-      }
-
-      static class ActionMetadata {
-         public const string
-            CreateDefinition = "create definition",
-            UpdateDefinition = "update definition",
-            CreateTemplate = "create template",
-            UpdateTemplate = "update template";
-         public static readonly IActionMetadata<AlgoServiceReply> update_template = new Impl<AlgoServiceReply>(_update, _template, r => r.Success, r => r.ErrMsg.ToString());
-         public static readonly IActionMetadata<AlgoServiceReply> remove_template = new Impl<AlgoServiceReply>(_delete, _template, r => r.Success, r => r.ErrMsg.ToString());
-         public static readonly IActionMetadata<TemplateCreateResult> create_template = new Impl<TemplateCreateResult>(_create, _template, r => r.Success, r => r.ErrMsg);
-         public static readonly IActionMetadata<CompositeAlgoCreateResult> create_definition = new Impl<CompositeAlgoCreateResult>(_create, _definition, r => r.Success, r => r.ErrMsg);
-
-         static readonly DescTuple _create = new DescTuple("create", "creating"), _update = new DescTuple("update", "updating"), _delete = new DescTuple("delete", "deleting");
-         static readonly string _definition = "definition", _template = "template";
-
-         class Impl<T> : IActionMetadata<T> {
-            readonly DescTuple _desc;
-            readonly string _subject;
-            readonly Func<T, bool> _get_success;
-            readonly Func<T, string> _get_error_msg;
-
-            public Impl(DescTuple desc, string subject, Func<T, bool> get_success, Func<T, string> get_error_msg) {
-               _desc = desc;
-               _subject = subject;
-               _get_success = get_success;
-               _get_error_msg = get_error_msg;
-            }
-            public string desc => _desc.desc;
-            public string present_progressive_desc => _desc.present_progressive_desc;
-            public bool get_success(T reply) => _get_success(reply);
-            public string get_error_msg(T reply) => _get_error_msg(reply);
-         }
-
-         struct DescTuple {
-            public readonly string desc, present_progressive_desc;
-            public DescTuple(string desc, string present_progressive_desc) {
-               this.desc = desc;
-               this.present_progressive_desc = present_progressive_desc;
-            }
-         }
-      }
-
-      /// <summary>
-      /// The AlgoService protobuf types have been extracted out of the viewmodels (<see cref="AlgoStudioVM"/>, <see cref="OrderPropertiesEditorVM"/>, <see cref="AlgoDefinitionVM"/>, <see cref="AlgoDefinitionTemplateVM"/>).
-      /// The viewmodels instead use these types to represent the data: <see cref="AlgoData"/> is used in place of <see cref="CompositeAlgoRecordImmutable"/>, and <see cref="AlgoTemplateData"/> is used in place of <see cref="AlgoTemplateRecordImmutable"/>.
-      /// This thin abstraction isolates the server-side from the client-side, so if one day the server side types change, we won't need to change any client-side code except the methods below which handle the conversion from server type to corresponding client type.
-      /// There are a couple other methods in here as well (this is an extensions class afterall), but [John]I am going out of town soon (1/6/18) and did not get a chance to organize these methods beyond containing them in <see cref="Utils"/>.
-      /// </summary>
-      static class _Utils {
-         // AlgoTemplateImmutable custom_order_definition(i)
-         public static CustomOrderDefinitionImmutable custom_order_definitioni(AlgoTemplateImmutable templatei) {
-            switch (templatei.AlgoParamsCase) {
-               case AlgoTemplate.AlgoParamsOneofCase.CompositeAlgoParams: return templatei.CompositeAlgoParams.Algo;
-               case AlgoTemplate.AlgoParamsOneofCase.SystemAlgoParams: return templatei.SystemAlgoParams;
-               default: throw ExceptionBuilder.Argument.unexpected_case(templatei.AlgoParamsCase, nameof(templatei));
-            }
-         }
-
-         public static AlgoData definition_data(AlgoTemplateImmutable templatei) {
-            switch (templatei.AlgoParamsCase) {
-               case AlgoTemplate.AlgoParamsOneofCase.CompositeAlgoParams: return definition_data(templatei.CompositeAlgoParams);
-               case AlgoTemplate.AlgoParamsOneofCase.SystemAlgoParams:
-                  return new AlgoData(
-                     templatei.SystemAlgoParams,
-                     templatei.SystemAlgoParams.CustomCase.display_name(),
-                     get_key(templatei.SystemAlgoParams));
-               default: throw ExceptionBuilder.Argument.unexpected_case(templatei.AlgoParamsCase, nameof(templatei));
-            }
-         }
-
-         public static AlgoData definition_data(CompositeAlgoRecordImmutable recordi) => new AlgoData(recordi.AlgoDefinition.Algo, recordi.AlgoDefinition.Name, get_key(recordi));
-
-         public static AlgoData definition_data(CompositeAlgoDefinitionImmutable definitioni) =>
-            new AlgoData(definitioni.Algo, definitioni.Name, get_key(definitioni));
-
-         public static AlgoData? definition_data(Result<CompositeAlgoCreateResult> result) {
-            if (result.success && result.value.Success) {
-               var r = result.value.Record;
-               return new AlgoData(new CustomOrderDefinitionImmutable(r.AlgoDefinition.Algo), r.AlgoDefinition.Name, new AlgoKey(new AlgoPersistedKey(r.Key)));
-            } else return null;
-         }
-
-         // AlgoTemplateRecord(Immutable) template data
-         public static AlgoTemplateData template_data(AlgoTemplateRecord record) => template_data(new AlgoTemplateRecordImmutable(record));
-         public static AlgoTemplateData template_data(AlgoTemplateRecordImmutable recordi) => new AlgoTemplateData(custom_order_definitioni(recordi.AlgoTemplate), recordi.AlgoTemplate.Name, get_key(recordi), definition_data(recordi.AlgoTemplate));
-
-         public static CompositeAlgoDefinition to_definition(AlgoData definition_data) =>
-            new CompositeAlgoDefinition {
-               Name = definition_data.name,
-               Algo = definition_data.value.CloneToMutable()
-            };
-
-         // AlgoTemplateData to_record(i)
-         public static AlgoTemplateRecord to_record(AlgoTemplateData template) {
-            var record = new AlgoTemplateRecord {
-               AlgoTemplate = new AlgoTemplate {
-                  Name = template.name,
-                  CompositeAlgoParams = new CompositeAlgoDefinition {
-                     Name = template.definition.name,
-                     Algo = template.value.CloneToMutable()
-                  }
-               }
-            };
-            set_key(ref record, template.key);
-            return record;
-         }
-         public static AlgoTemplateRecordImmutable to_recordi(AlgoTemplateData template) => new AlgoTemplateRecordImmutable(to_record(template));
-
-         // AlgoTemplateData to_template(i)
-         public static AlgoTemplate to_template(AlgoTemplateData template) =>
-            new AlgoTemplate {
-               Name = template.name,
-               CompositeAlgoParams = new CompositeAlgoDefinition {
-                  Name = template.definition.name,
-                  Algo = template.value.CloneToMutable()
-               }
-            };
-         public static AlgoTemplateImmutable to_templatei(AlgoTemplateData template) => new AlgoTemplateImmutable(to_template(template));
-
-         public static AlgoKey get_key(CompositeAlgoRecordImmutable recordi) => new AlgoKey(new AlgoPersistedKey(recordi.Key));
-         public static AlgoKey get_key(AlgoTemplateRecordImmutable recordi) => new AlgoKey(new AlgoPersistedKey(recordi.Key));
-         public static AlgoKey get_key(CompositeAlgoDefinitionImmutable definitioni) => new AlgoKey(new AlgoPersistedKey(definitioni.Name));
-         public static AlgoKey get_key(CustomOrderDefinitionImmutable custom_order_definitioni) => new AlgoKey(custom_order_definitioni.CustomCase);
-
-         public static void set_key(ref AlgoTemplateRecord record, AlgoKey key) {
-            switch (key.mode) {
-               case AlgoKey.Mode.Persisted:
-                  switch (key.persisted.mode) {
-                     case AlgoPersistedKey.Mode.String:
-                        record.Key = key.persisted.id_string; break;
-                  }
-                  break;
-            }
-         }
-         public static void set_key(ref AlgoServiceRemoveRequest request, AlgoKey key) {
-            switch (key.mode) {
-               case AlgoKey.Mode.Persisted: 
-                  switch (key.persisted.mode) {
-                     case AlgoPersistedKey.Mode.String:
-                        request.Key = key.persisted.id_string; break;
-                  }
-                  break;
-            }
-         }
-      }
-   }
-}

src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoStudioFlatDefinitionModel.cs

@@ -1,18 +1,16 @@
 using bts;
-using bts.api;
 using bts.api.core;
 using bts.api.orderman.algo;
-using bts.persist.algo;
 using bts.spark;
-using mbts.spark.utilities;
 using mbts.utils;
 using System;
 using System.Collections.Generic;
-using System.Linq;
+using System.ComponentModel.Composition;
 using System.Reactive.Linq;
 using System.Threading.Tasks;
 
 namespace mbts.spark {
+   [Export(typeof(IAlgoStudioModel))]
    class AlgoStudioFlatDefinitionModel : IAlgoStudioModel, IDisposable {
       readonly AlgoDefinitionService _service;
       readonly AdminModel _admin_model;
@@ -21,33 +19,34 @@ namespace mbts.spark {
       IReadOnlyDictionary<AlgoKey, AlgoTemplateData> _algo_templates = DictionaryHelper.empty<AlgoKey, AlgoTemplateData>();
       IDisposable _dispose;
 
-      public AlgoStudioFlatDefinitionModel(AlgoDefinitionService service, IAlgoDefinitionMetadataService metadata_service, AdminModel admin_model, ErrorReporter error_reporter, bts.config.AlgoStudioOptions ui_configuration) {
+      [ImportingConstructor]
+      public AlgoStudioFlatDefinitionModel(AlgoDefinitionService service, IAlgoDefinitionMetadataService metadata_service, AdminModel admin_model, ErrorReporter error_reporter) {
          _service = service;
          this.metadata_service = metadata_service;
          _admin_model = admin_model;
          _error_reporter = error_reporter;
-         this.ui_configuration = ui_configuration;
-         definitions = service.subscribei_algo_definitions().Filter(r => r.Metadata.IsActive).SelectKeyValue(_definition_data, d => d.key).Table().Cache();
+         definitions =
+            service.subscribei_algo_definitions()
+            .Filter(r => r.Metadata.IsActive && r.Metadata.CreatorUserId == _admin_model.user.id)
+            .SelectKeyValue(_definition_data, d => d.key)
+            .Table()
+            .Cache();
       }
 
       public IObservable<TableUpdate<AlgoData, AlgoKey>> definitions { get; }
       public IObservable<TableUpdate<AlgoTemplateData, AlgoKey>> templates => Observable.Empty<TableUpdate<AlgoTemplateData, AlgoKey>>();
       public IAlgoDefinitionMetadataService metadata_service { get; }
-      public bts.config.AlgoStudioOptions ui_configuration { get; }
+      public bts.config.AlgoStudioOptions ui_configuration { get; } = config.Configuration.get<bts.config.AlgoStudioOptions>();
 
       public IObservable<TableUpdate<AlgoTemplateData, AlgoKey>> subscribe_definition_templates(AlgoKey definition_key) =>
          Observable.Return(TableUpdate<AlgoTemplateData, AlgoKey>.mk_empty(t => t.key));
 
       public async Task<AlgoData?> save_definition(AlgoData definition_data) {
-         if (_try_get_user(out uint user_id)) {
-            var (value, success) = await _error_reporter.safe_execute(() => _service.save_algo_definition_async(
-               _with_key(new AlgoDefinitionUpdateRequest { UserId = user_id, Algo = _template(definition_data) }, definition_data.key)),
-               r => r.Success, r => r.ErrorMessage, "saving template");
-            if (success)
-               return _definition_data(new AlgoDefinitionRecordImmutable(value.Record));
-         } else {
-            _report_no_user_id("save template");
-         }
+         var (value, success) = await _error_reporter.safe_execute(() => _service.save_algo_definition_async(
+            _with_key(new AlgoDefinitionUpdateRequest { UserId = _admin_model.user.id, Algo = _template(definition_data) }, definition_data.key)),
+            r => r.Success, r => r.ErrorMessage, "saving template");
+         if (success)
+            return _definition_data(new AlgoDefinitionRecordImmutable(value.Record));
          return null;
       }
 
@@ -73,10 +72,10 @@ namespace mbts.spark {
          new AlgoDefinitionImmutable(_template(definition_data));
 
       static AlgoData _definition_data(AlgoDefinitionRecordImmutable recordi) =>
-         new AlgoData(recordi.Algo.Definition, recordi.Algo.Name, _key(recordi));
+         AlgoData.from_record(recordi);
 
       static AlgoKey _key(AlgoDefinitionRecordImmutable recordi) =>
-         new AlgoKey(new AlgoPersistedKey(recordi.Key));
+         AlgoKey.from_composite_key(recordi.Key);
 
       static AlgoDefinitionUpdateRequest _with_key(AlgoDefinitionUpdateRequest request, AlgoKey key) {
          _set_key(ref request, key);
@@ -85,9 +84,10 @@ namespace mbts.spark {
 
       static void _set_key(ref AlgoDefinitionUpdateRequest request, AlgoKey key) {
          switch (key.mode) {
-            case AlgoKey.Mode.Persisted: request.Key = key.persisted.id_uint; break;
+            case AlgoKey.Mode.Persisted: request.Key = key.persisted; break;
             case AlgoKey.Mode.Unpersisted:
             case AlgoKey.Mode.Factory:
+            case AlgoKey.Mode.Dynamic:
             case AlgoKey.Mode.None: request.Key = 0; break;
             default: throw ExceptionBuilder.Argument.unexpected_case(key.mode, nameof(key));
          }
@@ -95,7 +95,7 @@ namespace mbts.spark {
 
       static void _set_key(ref AlgoDefinitionRemoveRequest request, AlgoKey key) {
          switch (key.mode) {
-            case AlgoKey.Mode.Persisted: request.Key = key.persisted.id_uint; break;
+            case AlgoKey.Mode.Persisted: request.Key = key.persisted; break;
             default: throw ExceptionBuilder.Argument.unexpected_case(key.mode, nameof(key));
          }
       }
@@ -105,16 +105,5 @@ namespace mbts.spark {
 
       void _report_no_user_id(string desc) =>
          _error_reporter.report_error($"{desc} failed: did not find current user id");
-
-      bool _try_get_user(out uint id) {
-         var user = _admin_model.get_current_user();
-         if (user.HasValue) {
-            id = user.Value.id;
-            return true;
-         } else {
-            id = 0;
-            return false;
-         }
-      }
    }
 }

src/client/spark/Modules/Trading/AlgoStudio/Model/IAlgoStudioModel.cs

@@ -1,10 +1,7 @@
 using bts;
-using bts.api;
 using bts.api.core;
-using bts.spark;
 using System;
 using System.Collections.Generic;
-using System.ComponentModel.Composition;
 using System.Threading.Tasks;
 
 namespace mbts.spark {
@@ -20,34 +17,13 @@ namespace mbts.spark {
       bts.config.AlgoStudioOptions ui_configuration { get; }
    }
 
-   class AlgoStudioModelExporter {
-      [ImportingConstructor]
-      AlgoStudioModelExporter(Spark.AlgoServiceWrapper service_wrapper, IAlgoDefinitionMetadataService meta, AdminModel admin_model, ErrorReporter error_reporter) {
-         var ui_configuration = config.Configuration.get<bts.config.AlgoStudioOptions>();
-         switch (service_wrapper.mode) {
-            case Spark.AlgoServiceWrapper.Mode.Flat: model = new AlgoStudioFlatDefinitionModel(service_wrapper.flat, meta, admin_model, error_reporter, ui_configuration); break;
-            case Spark.AlgoServiceWrapper.Mode.Hierarchical: model = new AlgoStudioDefinitionTemplateModel(service_wrapper.hierarhical, meta, admin_model, error_reporter, ui_configuration); break;
-         }
-      }
-
-      [Export]
-      public IAlgoStudioModel model { get; }
-   }
-
    static class AlgoStudioModelUtils {
-      public static bool templates_enabled(this IAlgoStudioModel model) =>
-         get_templates_enabled(model.ui_configuration);
-
-      public static bool get_templates_enabled(bts.config.AlgoStudioOptions ui_configuration) =>
-         ui_configuration.add_template_button != bts.config.AlgoStudioOptions.AddTemplateButton.None;
-
       public static IReadOnlyDictionary<object, object> get_dynamic_resources(bts.config.AlgoStudioOptions ui_configuration) =>
          new Dictionary<object, object> {
             { AlgoStudioWindow.ShowAlgoToolBarRenameDefinitionKey, ui_configuration.can_modify_definition_name && ui_configuration.show_algo_toolbar_rename },
             { AlgoStudioWindow.ShowAlgoToolBarSaveDefinitionKey, ui_configuration.can_modify_definition_values && ui_configuration.show_algo_toolbar_save },
             { AlgoStudioWindow.ShowAlgoToolBarRevertDefinitionKey, ui_configuration.show_algo_toolbar_revert },
-            { AlgoStudioWindow.ShowAlgoToolBarUndoRedoDefinitionKey, ui_configuration.show_algo_toolbar_undo_redo },
-            { AlgoStudioWindow.TemplatesEnabledKey, get_templates_enabled(ui_configuration) }
+            { AlgoStudioWindow.ShowAlgoToolBarUndoRedoDefinitionKey, ui_configuration.show_algo_toolbar_undo_redo }
          };
    }
 }

src/client/spark/Modules/Trading/AlgoStudio/Model/Metadata/AlgoDefinitionMetadata.cs

@@ -35,9 +35,9 @@ namespace mbts.spark {
       internal AlgoDefinitionPersistedMetadata to_persisted() =>
          id.mode != AlgoKey.Mode.Persisted ?
             throw new InvalidOperationException("Metadata does not have a persisted key.") :
-            new AlgoDefinitionPersistedMetadata(id.persisted,
-               default_template.mode == AlgoKey.Mode.Persisted ? default_template.persisted : default,
-               favorite_templates.Where(t => t.mode == AlgoKey.Mode.Persisted).Select(t => t.persisted).ToArray(),
+            new AlgoDefinitionPersistedMetadata(new AlgoPersistedKey(id.persisted),
+               default_template.mode == AlgoKey.Mode.Persisted ? new AlgoPersistedKey(default_template.persisted) : default,
+               favorite_templates.Where(t => t.mode == AlgoKey.Mode.Persisted).Select(t => new AlgoPersistedKey(t.persisted)).ToArray(),
                is_favorite, is_hidden, abbreviation, new NullableColorProto(badge_color));
 
       public AlgoDefinitionMetadata with(AlgoKey? id = null, AlgoKey? default_template = null, IEnumerable<AlgoKey> favorite_templates = null, bool? is_favorite = null, bool? is_hidden = null, string abbreviation = null, NullableColorProto? badge_color = null) =>

src/client/spark/Modules/Trading/AlgoStudio/Utils/AlgoCollectionHelper.cs

@@ -83,7 +83,8 @@ namespace mbts.spark {
 
       public static AlgoDisplayGroup display_group(this AlgoKey key) {
          switch (key.mode) {
-            case AlgoKey.Mode.Factory: return display_group(key.factory.structure.order_type());
+            case AlgoKey.Mode.Factory: return display_group(key.factory);
+            case AlgoKey.Mode.Dynamic: return AlgoDisplayGroup.API;
             case AlgoKey.Mode.Unpersisted:
             case AlgoKey.Mode.Persisted:
                return AlgoDisplayGroup.Studio;

src/client/spark/Modules/Trading/AlgoStudio/VM/AlgoDefinitionTemplateVM.cs

@@ -1,243 +0,0 @@
-using bts;
-using bts.api.orderman;
-using bts.utils;
-using mbts.spark.utilities;
-using mbts.ui;
-using mbts.ui.shell;
-using mbts.ui.utility;
-using mbts.utils;
-using System;
-using System.Collections.Generic;
-using System.Collections.ObjectModel;
-using System.Reactive.Linq;
-using System.Windows.Input;
-using VisualStateNames = mbts.ui.spark.AlgoStudioView.VisualStateNames;
-
-namespace mbts.spark {
-   class AlgoDefinitionTemplateVM : DisposableViewModelBase, IAlgoStudioContentVM, IEquatable<AlgoDefinitionTemplateVM> {
-      /// <see cref="CustomType"/> is referenced by an x:Static extension in OrderDetailsPopupControl.xaml <see cref="mbts.ui.spark.algo.OrderDetailsPopupControl"/>.
-      /// In most cases, <see cref="mbts.ui.NestedExtension"/> works just like <see cref="System.Windows.Markup.TypeExtension"/>, but for nested types, such as <see cref="CustomTemplatePlaceholderVM"/>.
-      /// However, when the former is used to denote the DataType of a DataTemplate, a strange XamlReader exception is thrown at runtime.
-      /// After spending ~15 minutes investigating what was happening, [John]I decided it was more trouble than it was worth and opted for this workaround.
-      public static readonly Type CustomType = typeof(CustomTemplatePlaceholderVM);
-      readonly OrdersModel _model;
-      readonly VisualStateModel _edit_pane_vs_model = new VisualStateModel(), _tree_view_vs_model = new VisualStateModel();
-      /// Note: the difference between <see cref="EditStack{T}"/> and <see cref="VersionContainer{T}"/> is that the former implements push/pop functionality so the user may undo/redo (like ctrl+z/ctrl+y in text editors),
-      /// while the latter is a lazy delegate-based container for the most recent value (<see cref="VersionContainer{T}.increment_version"/>).
-      readonly EditStack<Snapshot> _edit_stack = new EditStack<Snapshot>();
-      readonly VersionContainer<Snapshot> _version;
-      readonly DeferrableActionWrapper _refresh_on_local_change;
-      readonly Property<IAlgoVM> _algo_root;
-      readonly DelegateProperty<bool> _can_undo, _can_redo, _is_dirty;
-      readonly Property<bool> _is_default, _is_favorite, _is_selected;
-      readonly Property<string> _name, _abbreviation;
-      // maintains the state of each algo-root, so the user may change the definition root back and forth without any loss of state amongst the templates
-      Snapshot _committed;
-
-      public AlgoDefinitionTemplateVM(AlgoDefinitionVM owner, OrdersModel model, AlgoData data, AlgoEditingPermissions editing_permissions = AlgoEditingPermissions.AllowEditValues) {
-         // init core data
-         this.owner = owner;
-         _model = model;
-         key = data.key;
-         _version = new VersionContainer<Snapshot>(_snapshot);
-         // maintain states for different algo roots, so they aren't lost when the user changes the root algo type
-         var algo_map = new Dictionary<AlgoKey, IAlgoVM> {
-            { data.key, algo_vm_factory(data.value) }
-         };
-         // init backing props
-         _name = backing(nameof(this.name), name);
-         _abbreviation = backing(nameof(abbreviation), string.Empty);
-         _is_default = backing(nameof(is_default), false);
-         _is_favorite = backing(nameof(is_favorite), false);
-         _is_selected = backing(nameof(is_selected), false);
-         _algo_root = backing(nameof(algo_root), get_algo_root(owner.algo_root));
-         _committed = _version.value;
-         _can_redo = backing(nameof(can_redo), () => _edit_stack.get_can_redo(_version.value));
-         _can_undo = backing(nameof(can_undo), () => _edit_stack.get_can_undo(_version.value));
-         _is_dirty = backing(nameof(is_dirty), () => !_committed.Equals(_version.value));
-         _can_redo.Changed += on_can_redo_changed;
-         _can_undo.Changed += on_can_undo_changed;
-         set_as_default_cmd = new DelegateCommand(() => {
-            if (!is_default && key.mode == AlgoKey.Mode.Persisted)
-               _model.algo_model.metadata_service.set_as_default(owner.key, key).ignore();
-         });
-         // init visual states
-         // TODO: implement these features in IAlgoMetadataService; until then, set the appropriate visual states.
-         _edit_pane_vs_model.set_state(VisualStateNames.Abbreviation.GroupName, VisualStateNames.Abbreviation.NotSupportedForTemplates);
-         _tree_view_vs_model.set_state(VisualStateNames.FavoriteToggleButton.GroupName, VisualStateNames.FavoriteToggleButton.Inactive);
-         switch (key.mode) {
-            case AlgoKey.Mode.Persisted:
-               _edit_stack.push(_committed);
-               _edit_pane_vs_model.set_state(VisualStateNames.Name.GroupName, VisualStateNames.Name.Active);
-               break;
-            case AlgoKey.Mode.Unpersisted: _edit_pane_vs_model.set_state(VisualStateNames.Name.GroupName, VisualStateNames.Name.Active); break;
-            case AlgoKey.Mode.Factory: _edit_pane_vs_model.set_state(VisualStateNames.Name.GroupName, VisualStateNames.Name.Inactive); break;
-         }
-         // set hooks/subscriptions
-         _refresh_on_local_change = new DeferrableActionWrapper(on_local_changed);
-         _dispose = new System.Reactive.Disposables.CompositeDisposable(
-            as_demuxer().subscribe_many(_refresh_on_local_change.execute, nameof(name), nameof(abbreviation), nameof(is_default), nameof(is_favorite)),
-            owner.observe_algo_root().Subscribe(r => _algo_root.set(get_algo_root(r))),
-            _algo_root.observe_current(true).SelectManyInSeries(r => r?.subscribe_definition()).RefCount().Subscribe(_ => _refresh_on_local_change.execute()),
-            Disposable.wrap_collection(algo_map.Values)) {
-            () => {
-               _can_redo.Changed -= on_can_redo_changed;
-               _can_undo.Changed -= on_can_undo_changed;
-            }
-         };
-         // local methods
-         IAlgoVM algo_vm_factory(CustomOrderDefinitionImmutable def) => OrderTypeVMFactory.create(new AlgoData(def, def.CustomCase.display_name(), OrderDataHelper.get_shallow_factory_key(def)), editing_permissions);
-         IAlgoVM get_algo_root(IAlgoVM owner_root) {
-            var key = new AlgoKey(owner_root.order_type);
-            if (algo_map.TryGetValue(key, out IAlgoVM vm)) {
-               vm.load_structure(owner_root.definition);
-            } else {
-               vm = algo_map.GetOrAdd(key, ot => algo_vm_factory(owner_root.definition));
-            }
-            return vm;
-         }
-         void on_can_undo_changed(bool oldval, bool newval) => can_undo_changed?.Invoke();
-         void on_can_redo_changed(bool oldval, bool newval) => can_redo_changed?.Invoke();
-         void on_local_changed() {
-            _version.increment_version();
-            _edit_stack.push_distinct(_version.value);
-            _is_dirty.refresh();
-            _refresh_undo_redo();
-         }
-      }
-
-      public event Action can_redo_changed, can_undo_changed;
-      public event PropertyChange<IAlgoVM> algo_root_changed { add => _algo_root.Changed += value; remove => _algo_root.Changed -= value; }
-
-      public AlgoDefinitionVM owner { get; }
-      public AlgoKey owner_key => owner.key;
-      public AlgoKey key { get; }
-      public string name { get => _name.Value; set => _name.set(value); }
-      public string abbreviation { get => _abbreviation.Value; set => _abbreviation.set(value); }
-      public bool is_dirty => _is_dirty.Value;
-      public bool can_redo => _can_redo.Value;
-      public bool can_undo => _can_undo.Value;
-      public bool is_default => _is_default.Value;
-      public bool is_favorite { get => _is_favorite.Value; set => _is_favorite.set(value); }
-      public IAlgoVM algo_root => _algo_root.Value;
-      public virtual bool is_custom_placeholder => false;
-      public bool is_selected { get => _is_selected.Value; set => _is_selected.set(value); }
-      public bool is_expanded => false;
-      public bool is_persisted => key.mode == AlgoKey.Mode.Persisted;
-      public ObservableCollection<string> edit_pane_visual_states => _edit_pane_vs_model.states;
-      public ObservableCollection<string> tree_view_visual_states => _tree_view_vs_model.states;
-      public ICommand set_as_default_cmd { get; }
-
-      public IObservable<bool> observe_is_dirty() => _is_dirty.observe_current(true);
-      public void undo() => _restore(_edit_stack.try_undo);
-      public void redo() => _restore(_edit_stack.try_redo);
-    
-      public void on_meta(bool is_default, bool is_favorite) {
-         _is_default.set(is_default);
-         _is_favorite.set(is_favorite);
-      }
-
-      public AlgoData create_def_data() =>
-         new AlgoData(algo_root.definition, name, key);
-
-      public AlgoTemplateData create() =>
-         create(owner.create_algo_def());
-
-      public AlgoTemplateData create(AlgoData record) {
-         if (!OrderDataHelper.EqualsHelpers.structure_equals(algo_root.definition, record.value))
-            throw new InvalidOperationException("AlgoTemplate's algo structure does not match that of its parent.");
-         return new AlgoTemplateData(algo_root.definition, name, key, record);
-      }
-
-      public AlgoDefinitionTemplateVM to_persisted(AlgoDefinitionVM persisted_owner, AlgoData template) =>
-         new AlgoDefinitionTemplateVM(persisted_owner, _model, template);
-
-      public void load_committed() => _load_from(_committed.name, _committed.definition, true);
-
-      public void load_from(AlgoTemplateData value) {
-         if (key.mode != AlgoKey.Mode.Persisted)
-            throw new InvalidOperationException("AlgoStructure has not been saved yet.");
-         else if (value.key != key)
-            throw new InvalidOperationException("Value id does not match this id.");
-         _load_from(value.name, value.value, true);
-      }
-
-      public bool Equals(AlgoDefinitionTemplateVM other) => other != null && key == other.key;
-      public override bool Equals(object obj) => Equals(obj as AlgoDefinitionTemplateVM);
-      public override int GetHashCode() => key.GetHashCode();
-
-      void _load_from(string new_name, CustomOrderDefinitionImmutable new_def, bool update_committed) {
-         using (_refresh_on_local_change.defer_execution()) {
-            name = new_name;
-            algo_root.load_from(new_def);
-         }
-         if (update_committed) {
-            _committed = _version.value;
-            _is_dirty.refresh();
-         }
-      }
-
-      void _refresh_undo_redo() {
-         _can_redo.refresh();
-         _can_undo.refresh();
-      }
-
-      void _restore(TryGetValue<Snapshot> try_get_snapshot) {
-         while (try_get_snapshot(out Snapshot next_state)) {
-            if (!_version.value.Equals(next_state)) {
-               _load_from(next_state.name, next_state.definition, false);
-               break;
-            }
-         }
-      }
-
-      Snapshot _snapshot() =>
-         new Snapshot(name, abbreviation, algo_root?.definition ?? new CustomOrderDefinitionImmutable(new CustomOrderDefinition()), is_default, is_favorite);
-
-      struct Snapshot : IEquatable<Snapshot> {
-         public readonly string name, abbreviation;
-         public readonly CustomOrderDefinitionImmutable definition;
-         public readonly bool is_default, is_favorite;
-
-         public Snapshot(string name, string abbreviation, CustomOrderDefinitionImmutable definition, bool is_default, bool is_favorite) {
-            this.name = name;
-            this.abbreviation = abbreviation;
-            this.definition = definition;
-            this.is_default = is_default;
-            this.is_favorite = is_favorite;
-         }
-
-         public bool Equals(Snapshot other) =>
-            name == other.name &&
-            abbreviation == other.abbreviation &&
-            is_default == other.is_default &&
-            is_favorite == other.is_favorite &&
-            OrderDataHelper.EqualsHelpers.equals(definition, other.definition);
-
-         public override bool Equals(object obj) =>
-            EqualityComparer.equals_obj(this, obj);
-
-         public override int GetHashCode() =>
-            EqualityComparer.aggregate_hash(
-               EqualityComparer.safe_aggregate_hash(name),
-               EqualityComparer.safe_aggregate_hash(abbreviation),
-               is_default.GetHashCode(),
-               is_favorite.GetHashCode(),
-               OrderDataHelper.EqualsHelpers.custom_order_def_compareri.GetHashCode(definition));
-
-         public static bool operator ==(Snapshot a, Snapshot b) => a.Equals(b);
-         public static bool operator !=(Snapshot a, Snapshot b) => !a.Equals(b);
-      }
-
-      public class CustomTemplatePlaceholderVM : AlgoDefinitionTemplateVM {
-         const string _custom_name = "(Custom)";
-
-         public CustomTemplatePlaceholderVM(AlgoDefinitionVM owner, OrdersModel model, CustomOrderDefinitionImmutable definition)
-            : base(owner, model, new AlgoData(definition, _custom_name, new AlgoKey(Guid.NewGuid())), AlgoEditingPermissions.AllowEditStructure | AlgoEditingPermissions.AllowEditValues) {
-            _edit_stack.reset(_snapshot());
-         }
-
-         public override bool is_custom_placeholder => true;
-      }
-   }
-}

src/client/spark/Modules/Trading/AlgoStudio/VM/AlgoDefinitionVM.cs

@@ -1,4 +1,4 @@
-using bts.api.core;
+using bts;
 using bts.api.orderman;
 using bts.collections;
 using bts.proto;
@@ -6,7 +6,6 @@ using bts.utils;
 using mbts.collections;
 using mbts.spark.utilities;
 using mbts.ui;
-using mbts.ui.controls;
 using mbts.ui.controls.color_picker;
 using mbts.ui.shell;
 using mbts.ui.utility;
@@ -18,7 +17,6 @@ using System.Collections.Specialized;
 using System.Linq;
 using System.Reactive.Disposables;
 using System.Reactive.Linq;
-using System.Windows.Data;
 using System.Windows.Media;
 using VisualStateNames = mbts.ui.spark.AlgoStudioView.VisualStateNames;
 
@@ -36,18 +34,14 @@ namespace mbts.spark {
       public static readonly CustomOrderDefinitionImmutable new_algo_def = OrderDataHelper.Defaults.CustomOrderDefinitionImmutable(CustomOrderDefinition.CustomOneofCase.Iceberg);
       readonly OrdersModel _model;
       readonly VisualStateModel _edit_pane_vs_model = new VisualStateModel(), _tree_view_vs_model = new VisualStateModel();
-      readonly ObservableKeyedCollection<AlgoDefinitionTemplateVM, AlgoKey> _templates = new ObservableKeyedCollection<AlgoDefinitionTemplateVM, AlgoKey>(t => t.key);
       readonly EditStack<Snapshot> _edit_stack = new EditStack<Snapshot>();
       readonly VersionContainer<Snapshot> _version;
       readonly Property<bool> _is_expanded, _is_selected;
       readonly Property<IAlgoVM> _algo_root, _visible_algo_root;
-      readonly Property<AlgoDefinitionTemplateVM> _selected_template;
       readonly DelegateProperty<bool> _is_favorite, _is_dirty, _can_undo, _can_redo;
       readonly Property<string> _name, _abbreviation;
       readonly ObservableKeyedCollection<IAlgoVM, AlgoKey> _algo_roots = new ObservableKeyedCollection<IAlgoVM, AlgoKey>(vm => vm.id);
-      readonly ObservableAppendCollection<AlgoDefinitionTemplateVM> _templates_with_custom;
       readonly DeferrableActionWrapper _refresh_on_local_changes;
-      readonly ReactiveThresholdMonitor<AlgoDefinitionTemplateVM> _any_templates_dirty_monitor = new ReactiveThresholdMonitor<AlgoDefinitionTemplateVM>(t => t.observe_is_dirty());
       readonly Property<AlgoFormats> _selected_format;
       readonly EnumMaskInt32<AlgoEditingPermissions> _permissions_mask = new EnumMaskInt32<AlgoEditingPermissions>();
 
@@ -55,18 +49,12 @@ namespace mbts.spark {
       Brush _badge_fill;
       Snapshot? _committed;
       AlgoDefinitionMetadata _metadata;
-      TableUpdateBuffer<AlgoTemplateData, AlgoKey> _template_update_buffer;
-      bool _connected;
 
-      public static AlgoDefinitionVM create(OrdersModel model, AlgoData data, bool connect = false, AlgoFormats init_format = AlgoFormats.Exchange, AlgoEditingPermissions editing_permissions = (AlgoEditingPermissions)int.MaxValue) {
-         var rv = new AlgoDefinitionVM(model, data, init_format, editing_permissions);
-         if (connect)
-            rv.connect();
-         return rv;
-      }
+      public static AlgoDefinitionVM create(OrdersModel model, AlgoData data, AlgoFormats init_format = AlgoFormats.Exchange, AlgoEditingPermissions editing_permissions = (AlgoEditingPermissions)int.MaxValue) =>
+         new AlgoDefinitionVM(model, data, init_format, editing_permissions);
 
       public static AlgoDefinitionVM create_placeholder(OrdersModel model, CustomOrderDefinitionImmutable def, string name, AlgoFormats init_format) =>
-         new AlgoDefinitionVM(model, new AlgoData(def, name, new AlgoKey(Guid.NewGuid())), init_format, (AlgoEditingPermissions)int.MaxValue);
+         new AlgoDefinitionVM(model, AlgoData.create_unpersisted(def, name), init_format, (AlgoEditingPermissions)int.MaxValue);
 
       AlgoDefinitionVM(OrdersModel model, AlgoData def_data, AlgoFormats init_format, AlgoEditingPermissions init_permissions) {
          // init core data
@@ -78,20 +66,8 @@ namespace mbts.spark {
             editing_permissions_mask ^= (AlgoEditingPermissions.AllowEditValues | AlgoEditingPermissions.AllowSaveValues);
          if (!model.algo_model.ui_configuration.can_modify_definition_structure)
             editing_permissions_mask ^= (AlgoEditingPermissions.AllowEditStructure | AlgoEditingPermissions.AllowSaveStructure);
-         else if (model.algo_model.templates_enabled()) {
-            resources.Add(_templates.Subscribe((s, e) => {
-               if (_templates.Count == 0) {
-                  editing_permissions_mask |= AlgoEditingPermissions.AllowEditStructure | AlgoEditingPermissions.AllowSaveStructure;
-               } else {
-                  editing_permissions_mask ^= (AlgoEditingPermissions.AllowEditStructure | AlgoEditingPermissions.AllowSaveStructure);
-               }
-            }));
-         }
          key = def_data.key;
          algos_view = ObservableAutoWrapper.create_sorted_wrapper(_algo_roots, AlgoCollectionHelper.algo_vm_comparer);
-         _template_update_buffer = new TableUpdateBuffer<AlgoTemplateData, AlgoKey>(t => t.key);
-         _templates_with_custom = new ObservableAppendCollection<AlgoDefinitionTemplateVM>(templates);
-         templates_view = (ListCollectionView)CollectionViewSource.GetDefaultView(_templates_with_custom);
          custom_badge_color_palettes.AddRange(ColorPalette.all_presets(model.factory).Select(p => new ColorPaletteVM(p)));
          _version = new VersionContainer<Snapshot>(_snapshot);
          var conf = _model.algo_model.ui_configuration;
@@ -99,87 +75,80 @@ namespace mbts.spark {
          _name = backing(nameof(name), def_data.name);
          _abbreviation = backing(nameof(abbreviation), string.Empty);
          _selected_format = backing(nameof(selected_format), init_format);
-         _selected_template = backing<AlgoDefinitionTemplateVM>(nameof(selected_template));
          _is_favorite = backing(nameof(is_favorite), () => _favorite_index.HasValue);
          _is_expanded = backing(nameof(is_expanded), true);
          _is_selected = backing(nameof(is_selected), true);
          _is_dirty = backing(nameof(is_dirty), () => key.mode == AlgoKey.Mode.Unpersisted || !_committed.HasValue || !_committed.Value.Equals(_version.value));
-         var factory_def_data = def_data.key.mode == AlgoKey.Mode.Factory ? def_data : new AlgoData(def_data.value);
+         var factory_def_data = def_data.key.mode == AlgoKey.Mode.Factory ? def_data : AlgoData.from_custom_def(def_data.value);
          _algo_root = backing(nameof(algo_root), _algo_roots.GetOrAdd(factory_def_data.key, _ => OrderTypeVMFactory.create(factory_def_data)));
          _visible_algo_root = backing<IAlgoVM>(nameof(visible_algo_root));
+         // only composite/studio algos can change root
+         if (key.mode == AlgoKey.Mode.Factory || key.mode == AlgoKey.Mode.Dynamic) {
+            _algo_root.Changing += (oldval, newval) =>
+               Log.assert(newval != null && newval.id == key);
+         }
          _can_redo = backing(nameof(can_redo), () => _edit_stack.get_can_redo(_version.value));
          _can_undo = backing(nameof(can_undo), () => _edit_stack.get_can_undo(_version.value));
          _can_redo.Changed += on_can_redo_changed;
          _can_undo.Changed += on_can_undo_changed;
          _refresh_on_local_changes = new DeferrableActionWrapper(on_local_changed);
          // load initial state
-         init_async();
-         async void init_async() {
-            // visible_algo_root is selected_template.algo_root if user can add templates, otherwise algo_root
-            // - this behavior is configurable in 'AlgoStudioOptions' in UI.proto (01/28/2018)
-            if (_model.algo_model.templates_enabled()) {
-               resources.Add(_selected_template.observe_current(true).Subscribe(t => _visible_algo_root.set(t?.algo_root)));
-            } else {
-               resources.Add(_algo_root.observe_current(true).Subscribe(_visible_algo_root.set));
+         // visible_algo_root is selected_template.algo_root if user can add templates, otherwise algo_root
+         // - this behavior is configurable in 'AlgoStudioOptions' in UI.proto (01/28/2018)
+         resources.Add(_algo_root.observe_current(true).Subscribe(_visible_algo_root.set));
+         // set hooks/subscriptions
+         using (_refresh_on_local_changes.supress_execution()) {
+            resources.AddRange(
+               custom_badge_color.observe_nullable(true).Subscribe(v => Set(ref _badge_fill, (v ?? algo_root.safe_get_badge_color()).to_brush(), nameof(badge_fill))),
+               as_demuxer().subscribe_many(_refresh_on_local_changes.execute, nameof(this.name), nameof(abbreviation), nameof(badge_fill)),
+               _edit_pane_vs_model.add_source(VisualStateNames.BadgeSelector.GroupName, custom_badge_color.observe_nullable(true).Select(t => t.HasValue ? VisualStateNames.BadgeSelector.Active : VisualStateNames.BadgeSelector.Inactive)),
+               _edit_pane_vs_model.add_source(VisualStateNames.Abbreviation.GroupName, _abbreviation.observe_current(true).Select(a => string.IsNullOrEmpty(a) ? VisualStateNames.Abbreviation.Unpopulated : VisualStateNames.Abbreviation.Populated)),
+               _algo_root.observe_current(true).SubscribeEach(vm =>
+                  vm == null ? null :
+                     Disposable.Create(
+                        vm.subscribe_is_dirty().Subscribe(v => {
+                           if (!v) {
+                              _version.increment_version();
+                              _on_committed_changed();
+                           }
+                        }),
+                        vm.subscribe_definition().Subscribe(_ => _refresh_on_local_changes.execute()))),
+               ObservableAutoWrapper.connect_item_hooks(algo_roots, a => a as IDisposable ?? Disposable.empty, true),
+               Disposable.Create(() => {
+                  _can_redo.Changed -= on_can_redo_changed;
+                  _can_undo.Changed -= on_can_undo_changed;
+               }));
+            switch (key.mode) {
+               case AlgoKey.Mode.Persisted:
+                  _metadata = new AlgoDefinitionMetadata(key);
+                  resources.Add(model.algo_model.metadata_service.subscribe_metadata(key).OnDispatcher().Subscribe(_on_metadata));
+                  _edit_pane_vs_model.set_state(VisualStateNames.Name.GroupName, conf.can_modify_definition_name ? VisualStateNames.Name.Active : VisualStateNames.Name.CannotRenameDefinition);
+                  break;
+               case AlgoKey.Mode.Factory:
+                  _edit_pane_vs_model.set_state(VisualStateNames.Name.GroupName, VisualStateNames.Name.Inactive);
+                  break;
             }
-            // init tree view item visual state
-            _tree_view_vs_model.set_state(VisualStateNames.TreeViewBadge.GroupName, conf.show_badges_in_tree_view ? VisualStateNames.TreeViewBadge.Active : VisualStateNames.TreeViewBadge.Inactive);
-            // set hooks/subscriptions
-            using (_refresh_on_local_changes.supress_execution()) {
-               resources.AddRange(
-                  custom_badge_color.observe_nullable(true).Subscribe(v => Set(ref _badge_fill, (v ?? algo_root.safe_get_badge_color()).to_brush(), nameof(badge_fill))),
-                  as_demuxer().subscribe_many(_refresh_on_local_changes.execute, nameof(this.name), nameof(abbreviation), nameof(badge_fill)),
-                  _edit_pane_vs_model.add_source(VisualStateNames.BadgeSelector.GroupName, custom_badge_color.observe_nullable(true).Select(t => t.HasValue ? VisualStateNames.BadgeSelector.Active : VisualStateNames.BadgeSelector.Inactive)),
-                  _edit_pane_vs_model.add_source(VisualStateNames.Abbreviation.GroupName, _abbreviation.observe_current(true).Select(a => string.IsNullOrEmpty(a) ? VisualStateNames.Abbreviation.Unpopulated : VisualStateNames.Abbreviation.Populated)),
-                  _algo_root.observe_current(true).SubscribeEach(vm =>
-                     vm == null ? null :
-                        Disposable.Create(
-                           vm.subscribe_is_dirty().Subscribe(v => {
-                              if (!v) {
-                                 _version.increment_version();
-                                 _on_committed_changed();
-                              }
-                           }),
-                           vm.subscribe_definition().Subscribe(_ => _refresh_on_local_changes.execute()))),
-                  ObservableAutoWrapper.connect_item_hooks(algo_roots, a => a as IDisposable ?? Disposable.empty, true),
-                  ObservableAutoWrapper.connect_item_hooks(templates, t => new CompositeDisposable(_any_templates_dirty_monitor.join(t), t), true),
-                  Disposable.Create(() => {
-                     _can_redo.Changed -= on_can_redo_changed;
-                     _can_undo.Changed -= on_can_undo_changed;
-                  }));
-               switch (key.mode) {
-                  case AlgoKey.Mode.Persisted:
-                     _metadata = new AlgoDefinitionMetadata(key);
-                     resources.Add(_template_update_buffer.OnDispatcher().Subscribe(_on_templates));
-                     resources.Add(model.algo_model.metadata_service.subscribe_metadata(key).OnDispatcher().Subscribe(_on_metadata));
-                     _edit_pane_vs_model.set_state(VisualStateNames.Name.GroupName, conf.can_modify_definition_name ? VisualStateNames.Name.Active : VisualStateNames.Name.CannotRenameDefinition);
-                     break;
-                  case AlgoKey.Mode.Factory:
-                     _edit_pane_vs_model.set_state(VisualStateNames.Name.GroupName, VisualStateNames.Name.Inactive);
-                     break;
-               }
-               var permission_src = _permissions_mask.observe_result();
-               resources.Add(_selected_format.observe_current(true).CombineLatest(permission_src, (fmt, perms) => (fmt, perms))
-                  .SubscribeEach(t => {
-                     if ((t.perms & AlgoEditingPermissions.AllowEditStructure) != 0) {
-                        using (_refresh_on_local_changes.defer_execution()) {
-                           var algo_data = model.factory.default_algos(t.fmt);
-                           var default_algo = new AlgoKey(OrderDataHelper.get_default_algo(t.fmt));
-                           return this.load_algo_data_recursive(algo_data, default_algo);
-                        }
+            var permission_src = _permissions_mask.observe_result();
+            resources.Add(_selected_format.observe_current(true).CombineLatest(permission_src, (fmt, perms) => (fmt, perms))
+               .SubscribeEach(t => {
+                  if ((t.perms & AlgoEditingPermissions.AllowEditStructure) != 0) {
+                     using (_refresh_on_local_changes.defer_execution()) {
+                        var algo_data = model.factory.default_algos(t.fmt);
+                        var default_algo = AlgoKey.from_known_type(OrderDataHelper.get_default_algo(t.fmt));
+                        return this.load_algo_data_recursive(algo_data, default_algo);
                      }
-                     return Disposable.empty;
-                  }));
-               resources.Add(permission_src.Subscribe(_ => RaisePropertyChanged(nameof(editing_permissions))));
-               resources.Add(this.connect_data(permission_src));
-               resources.Add(this.connect_data(Observable.Return(model)));
-               resources.Add(_algo_root.Subscribe(_ => RaisePropertyChanged(nameof(IAlgoSelector.selected_algo), nameof(IAlgoParamVM.value), nameof(group))));
-               _dispose = resources;
-               await algo_root.load_from_async(def_data.value);
-               _version.increment_version();
-               _edit_stack.reset(_version.value);
-               _on_committed_changed();
-            }
+                  }
+                  return Disposable.empty;
+               }));
+            resources.Add(permission_src.Subscribe(_ => RaisePropertyChanged(nameof(editing_permissions))));
+            resources.Add(this.connect_data(permission_src));
+            resources.Add(this.connect_data(Observable.Return(model)));
+            resources.Add(_algo_root.Subscribe(_ => RaisePropertyChanged(nameof(IAlgoSelector.selected_algo), nameof(IAlgoParamVM.value), nameof(group))));
+            _dispose = resources;
+            algo_root.load_from(def_data.value);
+            _version.increment_version();
+            _edit_stack.reset(_version.value);
+            _on_committed_changed();
          }
          // local methods
          void on_can_redo_changed(bool oldval, bool newval) => can_redo_changed?.Invoke();
@@ -206,7 +175,6 @@ namespace mbts.spark {
       public IReadOnlyObservableCollection<IAlgoVM> algos_view { get; }
       public IAlgoVM algo_root { get => _algo_root.Value; set => _algo_root.set(value); }
       public IAlgoVM visible_algo_root => _visible_algo_root.Value;
-      public AlgoDefinitionTemplateVM selected_template { get => _selected_template.Value; set => _selected_template.set(value); }
       public int? favorite_index {
          get => _favorite_index;
          set {
@@ -219,34 +187,12 @@ namespace mbts.spark {
       public bool is_selected { get => _is_selected.Value; set => _is_selected.set(value); }
       public bool is_dirty => _is_dirty.Value;
       public bool is_factory_definition => key.mode == AlgoKey.Mode.Factory;
-      public AlgoDisplayGroup group {
-         get {
-            switch (key.mode) {
-               case AlgoKey.Mode.Factory:
-                  if (algo_root != null)
-                     return algo_root.group;
-                  break;
-               case AlgoKey.Mode.Unpersisted:
-               case AlgoKey.Mode.Persisted:
-                  return AlgoDisplayGroup.Studio;
-            }
-            return AlgoDisplayGroup.BTS;
-         }
-      }
+      public AlgoDisplayGroup group => key.display_group();
       public bool can_redo => _can_redo.Value;
       public bool can_undo => _can_undo.Value;
       public EnabledValueVM<Color> custom_badge_color { get; } = new EnabledValueVM<Color>();
       public ObservableCollection<ColorPaletteVM> custom_badge_color_palettes { get; } = new ObservableCollection<ColorPaletteVM>();
       public Brush badge_fill => _badge_fill;
-      public ObservableCollection<AlgoDefinitionTemplateVM> templates => _templates;
-      /// <see cref="templates_with_custom"/> has the same elements as <see cref="templates"/>, plus the custom-placeholder-item, which is always at index 0.
-      /// The custom-placeholder supports legacy behavior in the ladder/ticket algo popup by allowing the user to manipulate the algo-structure (e.g. change an iceberg-limit order to iceberg-lean-cover-offset etc.).
-      /// However, the custom-placeholder item cannot be used to create/save algo-templates.
-      /// Algo-templates are just a set of values used to populate a concrete algo-structure; the 'structures' can be created in the AlgoStudio (<see cref="AlgoStudioWindow"/>).
-      /// If we were to strictly follow this paradigm, the user would no longer be able to freely change the algo-structure in the ladder/ticket popup (they would be forced to open up a new <see cref="AlgoStudioWindow"/>, and we know how much they hate more clicks!).
-      /// Some users might consider this a regression.  The custom-placeholder-item addresses that concern.
-      public ObservableAppendCollection<AlgoDefinitionTemplateVM> templates_with_custom => _templates_with_custom;
-      public ListCollectionView templates_view { get; }
       // format
       public AlgoFormats selected_format { get => _selected_format.Value; set => _selected_format.set(value); }
       public ObservableCollection<AlgoFormats> formats { get; } = new ObservableCollection<AlgoFormats> { AlgoFormats.Exchange, AlgoFormats.Spreader, AlgoFormats.Exchange | AlgoFormats.Spreader };
@@ -321,24 +267,7 @@ namespace mbts.spark {
          }
       }
 
-      // idempotent
-      public void prepend_custom_template() {
-         if (_templates_with_custom.appended_front.Count == 0)
-            _templates_with_custom.insert_front(new AlgoDefinitionTemplateVM.CustomTemplatePlaceholderVM(this, _model, algo_root.definition));
-      }
-
-      public AlgoDefinitionTemplateVM template_factory() =>
-         new AlgoDefinitionTemplateVM(this, _model, algo_root.create_def_data().with(name: new_template_name)) {
-            is_selected = true
-         };
-
       public IObservable<bool> subscribe_is_definition_dirty() => _is_dirty.observe_current(true);
-      public IObservable<bool> subscribe_any_templates_dirty() => _any_templates_dirty_monitor;
-      public IObservable<bool> subscribe_is_definition_or_any_templates_dirty() =>
-         Observable.Merge(
-            subscribe_is_definition_dirty().Select(v => v || _any_templates_dirty_monitor.is_above_threshold),
-            subscribe_any_templates_dirty().Select(v => v || is_dirty))
-         .DistinctUntilChanged();
 
       public void undo() => _restore(_edit_stack.try_undo);
       public void redo() => _restore(_edit_stack.try_redo);
@@ -347,20 +276,9 @@ namespace mbts.spark {
             _assign_from_data(_committed.Value);
          _on_committed_changed();
       }
-      /// <summary>
-      /// Subscribes to the templates source for this definition if it has been persisted (subscription requires a persistant id); does nothing if this definition has not been persisted, or if it is already subscribed (idempotent). 
-      /// </summary>
-      public void connect() {
-         if (!_connected) {
-            _connected = true;
-            concat_disposable(_model.algo_model.subscribe_definition_templates(key).OnDispatcher().Subscribe(_template_update_buffer.OnNext));
-         }
-      }
-
-      public IDisposable buffer_updates() => _template_update_buffer.buffer_updates();
 
       public void load_def(CustomOrderDefinitionImmutable def) {
-         var key = OrderDataHelper.get_shallow_factory_key(def);
+         var key = AlgoKey.from_custom_def(def);
          if (algo_root?.id == key) {
             algo_root.load_from(def);
          } else if (_algo_roots.TryGetValue(key, out IAlgoVM vm)) {
@@ -384,7 +302,7 @@ namespace mbts.spark {
             case 1: load_def(def_list[0]); break;
             default:
                var def = def_list[0];
-               var key = OrderDataHelper.get_shallow_factory_key(def);
+               var key = AlgoKey.from_custom_def(def);
                if (algo_root?.id == key) {
                   algo_root.load_many(def_list);
                } else if (_algo_roots.TryGetValue(key, out IAlgoVM vm)) {
@@ -414,7 +332,7 @@ namespace mbts.spark {
          new AlgoDefinitionVM(_model, def, selected_format, editing_permissions_mask);
 
       public AlgoData create_algo_def() =>
-         new AlgoData(algo_root.definition, name, key);
+         AlgoData.create(algo_root == null ? new CustomOrderDefinitionImmutable(new CustomOrderDefinition()) : algo_root.definition, name, key);
 
       public AlgoDefinitionMetadata create_metadata() =>
          _metadata.with(abbreviation: abbreviation, badge_color: new NullableColorProto(custom_badge_color.get_nullable()));
@@ -443,7 +361,7 @@ namespace mbts.spark {
 
       void _assign_from_data(string name, CustomOrderDefinitionImmutable definition) {
          this.name = name;
-         algo_root = _algo_roots.GetOrAdd(OrderDataHelper.get_shallow_factory_key(definition), _ => _mk_algo_root(definition));
+         algo_root = _algo_roots.GetOrAdd(AlgoKey.from_custom_def(definition), _ => _mk_algo_root(definition));
          algo_root.load_from(definition);
       }
 
@@ -458,18 +376,12 @@ namespace mbts.spark {
       public Snapshot current_value => _version.value;
 
       IAlgoVM _mk_algo_root(CustomOrderDefinitionImmutable definition) =>
-         OrderTypeVMFactory.create(new AlgoData(definition), is_expanded: true);
+         OrderTypeVMFactory.create(AlgoData.from_custom_def(definition), is_expanded: true);
 
       void _on_metadata(AlgoDefinitionMetadata metadata) {
          using (_refresh_on_local_changes.supress_execution()) {
             _abbreviation.set(metadata.abbreviation);
             custom_badge_color.set_nullable(metadata.badge_color);
-            foreach (var t in templates) {
-               if (t.key.mode == AlgoKey.Mode.Persisted)
-                  t.on_meta(t.key == metadata.default_template, metadata.favorite_templates.Contains(t.key));
-               else
-                  t.on_meta(false, false);
-            }
             _version.increment_version();
             if (_edit_stack.size == 1 && _edit_stack.pos == 1) {
                // this is a hack to account for the metadata being part of the committed state,
@@ -482,22 +394,6 @@ namespace mbts.spark {
          }
       }
 
-      void _on_templates(TableUpdate<AlgoTemplateData, AlgoKey> table) {
-         foreach (var rec in table.removed)
-            _templates.Remove(rec.key);
-         foreach (var rec in table.changed)
-            _templates[rec.key].load_from(rec);
-         foreach (var rec in table.added) {
-            if (_templates.TryGetValue(rec.key, out AlgoDefinitionTemplateVM tmp)) {
-               tmp.load_from(rec);
-            } else {
-               tmp = new AlgoDefinitionTemplateVM(this, _model, new AlgoData(rec.value, rec.name, rec.key));
-               tmp.on_meta(tmp.key == _metadata.default_template, _metadata.favorite_templates.Contains(tmp.key));
-               _templates.Add(tmp);
-            }
-         }
-      }
-
       void _refresh_undo_redo() {
          _can_undo.refresh();
          _can_redo.refresh();

src/client/spark/Modules/Trading/AlgoStudio/VM/AlgoStudioVM.cs

@@ -1,6 +1,5 @@
 using bts;
 using bts.api.orderman;
-using bts.collections;
 using bts.utils;
 using mbts.collections;
 using mbts.ui;
@@ -14,6 +13,7 @@ using System.Linq;
 using System.Reactive.Disposables;
 using System.Reactive.Linq;
 using System.Threading.Tasks;
+using System.Windows;
 using System.Windows.Input;
 using StartupData = bts.shell.AlgoStudioWindowFactory.StartupData;
 
@@ -37,29 +37,30 @@ namespace mbts.spark {
          });
    }
 
-   class AlgoStudioVM : DisposableViewModelBase, IHandleSelectedItemChanged {
+   class AlgoStudioVM : DisposableViewModelBase {
       static readonly AlgoFormats _studio_formats = AlgoFormats.Exchange;
       readonly OrdersModel _model;
       readonly Property<AlgoDefinitionVM> _selected_definition;
-      readonly Property<AlgoDefinitionTemplateVM> _selected_template;
       readonly Property<IAlgoVM> _editable_content;
       readonly DelegateProperty<string> _save_cmd_tooltip, _revert_cmd_tooltip;
       readonly ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey> _definitions = new ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey>(d => d.key);
       readonly ListCollectionView<AlgoDefinitionVM> _definitions_view;
       readonly TableUpdateBuffer<AlgoData, AlgoKey> _definitions_update_buffer;
-      readonly ReactiveThresholdMonitor<AlgoDefinitionVM> _any_dirty_monitor = new ReactiveThresholdMonitor<AlgoDefinitionVM>(d => d.subscribe_is_definition_or_any_templates_dirty());
+      readonly ReactiveThresholdMonitor<AlgoDefinitionVM> _any_dirty_monitor = new ReactiveThresholdMonitor<AlgoDefinitionVM>(d => d.subscribe_is_definition_dirty());
       IReadOnlyDictionary<AlgoKey, AlgoDefinitionMetadata> _persisted_meta = new Dictionary<AlgoKey, AlgoDefinitionMetadata>();
 
       public AlgoStudioVM(OrdersModel model) {
          _model = model;
          _selected_definition = backing<AlgoDefinitionVM>(nameof(selected_definition));
-         _selected_template = backing<AlgoDefinitionTemplateVM>(nameof(selected_template));
-         _editable_content = backing(nameof(editable_content), observe_selected().SelectManyInSeries(tup => tup.template?.observe_algo_root() ?? tup.definition?.observe_algo_root()).RefCount().OnDispatcher());
+         _editable_content = backing(nameof(editable_content), subscribe_definition().SelectManyInSeries(def => def?.observe_algo_root()).OnDispatcher());
          _definitions_update_buffer = new TableUpdateBuffer<AlgoData, AlgoKey>(def => def.key);
          _definitions_view = new ListCollectionView<AlgoDefinitionVM>(definitions) {
             CustomSort = AlgoCollectionHelper.algo_definition_vm_comparer.to_non_generic()
          };
          definitions_view.Filter = d => !(d.key.mode == AlgoKey.Mode.Persisted && _persisted_meta.TryGetValue(d.key, out AlgoDefinitionMetadata meta) && meta.is_hidden);
+         // add/clone
+         add_definition_cmd = new DelegateCommand(add_definition);
+         clone_selected_definition_cmd = new DelegateCommand(clone_selected_definition);
          // save
          var save_cmd = new ObservantAsyncCommand<IAlgoStudioContentVM>(save_async);
          this.save_cmd = save_cmd;
@@ -71,13 +72,18 @@ namespace mbts.spark {
          //
          _dispose = new CompositeDisposable(
             _model.algo_model.definitions.Subscribe(_definitions_update_buffer),
-            _definitions_update_buffer.OnDispatcher().Subscribe(u => AlgoCollectionHelper.update_persisted_definitions(_definitions, u, d => AlgoDefinitionVM.create(model, d, true, _studio_formats))),
+            _definitions_update_buffer.OnDispatcher().Subscribe(u => {
+               var orig_selected_def = selected_definition;
+               AlgoCollectionHelper.update_persisted_definitions(_definitions, u, d => AlgoDefinitionVM.create(model, d, _studio_formats));
+               if (selected_definition == null)
+                  selected_definition = definitions.FirstOrDefault();
+            }),
             _model.algo_model.metadata_service.subscribe_metadata().OnDispatcher().Subscribe(meta => {
                _persisted_meta = meta;
                definitions_view.Refresh();
             }),
-            ObservableAutoWrapper.connect(observe_selected().Select(t => t.template?.edit_pane_visual_states ?? t.definition?.edit_pane_visual_states ?? new ObservableCollection<string>()), content_visual_states),
-            observe_selected().SelectManyInSeries(t => t.template?.observe_is_dirty() ?? t.definition?.subscribe_is_definition_or_any_templates_dirty() ?? Observable.Return(false)).RefCount().OnDispatcher()
+            ObservableAutoWrapper.connect(subscribe_definition().Select(def => def?.edit_pane_visual_states ?? new ObservableCollection<string>()), content_visual_states),
+            subscribe_definition().SelectManyInSeries(def => def?.subscribe_is_definition_dirty() ?? Observable.Return(false)).OnDispatcher()
             .Subscribe(new CompositeObserver<bool>(save_cmd, revert_cmd) { val => {
                _save_cmd_tooltip.refresh();
                _revert_cmd_tooltip.refresh();
@@ -85,77 +91,64 @@ namespace mbts.spark {
             ObservableAutoWrapper.connect_item_hooks(definitions, d => new CompositeDisposable(_any_dirty_monitor.join(d), d), true));
          // local methods
          string get_revert_tooltip() {
-            if (content_source is AlgoDefinitionTemplateVM tmp) {
-               switch (tmp.key.mode) {
-                  case AlgoKey.Mode.Persisted: return tmp.is_dirty ? $"Revert changes to '{tmp.name}'" : "No changes to revert";
-               }
-            } else if (content_source is AlgoDefinitionVM def) {
-               switch (def.key.mode) {
-                  case AlgoKey.Mode.Persisted: return def.is_dirty || def.templates.Any(t => t.is_dirty) ? $"Revert changes to '{def.name}' templates" : "No changes to revert";
-               }
-            }
-            return null;
+            var def = selected_definition;
+            return def != null && def.key.mode == AlgoKey.Mode.Persisted ?
+               (def.is_dirty ? $"Revert changes to '{def.name}' templates" : "No changes to revert") :
+               null;
          }
          async Task save_async(IAlgoStudioContentVM content) {
-            if (content is AlgoDefinitionTemplateVM tmp) {
-               await save_template(tmp);
-            } else if (content is AlgoDefinitionVM def) {
+            if (content is AlgoDefinitionVM def)
                await save_definition(def);
-            }
          }
          string get_save_tooltip() {
-            if (content_source is AlgoDefinitionTemplateVM tmp) {
-               switch (tmp.key.mode) {
-                  case AlgoKey.Mode.Unpersisted: return tmp.is_dirty ? $"Save '{tmp.name}'" : $"Cannot Save '{tmp.name}'";
-                  case AlgoKey.Mode.Persisted: return tmp.is_dirty ? $"Save changes to '{tmp.name}'" : "No changes to save";
-               }
-            } else if (content_source is AlgoDefinitionVM def) {
+            var def = selected_definition;
+            if (def != null) {
                switch (def.key.mode) {
-                  case AlgoKey.Mode.Unpersisted: return def.is_dirty || def.templates.Any(t => t.is_dirty) ? $"Save '{def.name}'" : $"Cannot Save '{def.name}'";
-                  case AlgoKey.Mode.Persisted: return def.is_dirty || def.templates.Any(t => t.is_dirty) ? $"Save changes to '{def.name}' templates" : "No changes to save";
+                  case AlgoKey.Mode.Unpersisted: return def.is_dirty ? $"Save '{def.name}'" : $"Cannot Save '{def.name}'";
+                  case AlgoKey.Mode.Persisted: return def.is_dirty ? $"Save changes to '{def.name}' templates" : "No changes to save";
                }
             }
             return null;
          }
+
+         void add_definition() =>
+            add_definition_common(AlgoDefinitionVM.new_algo_def, AlgoDefinitionVM.new_algo_name);
+
+         void clone_selected_definition() {
+            if (selected_definition == null || selected_definition.algo_root == null) {
+               add_definition();
+            } else {
+               add_definition_common(
+                  selected_definition.algo_root.definition,
+                  string.IsNullOrEmpty(selected_definition.name) ? AlgoDefinitionVM.new_algo_name : $"{selected_definition.name} - Copy");
+            }
+         }
+
+         void add_definition_common(CustomOrderDefinitionImmutable def, string name) {
+            var new_def = AlgoDefinitionVM.create_placeholder(_model, def, name, _studio_formats);
+            _definitions.Add(new_def);
+            selected_definition = new_def;
+            request_view_focus_name?.Invoke(new_def);
+         }
       }
 
-      event Action<(AlgoDefinitionVM definition, AlgoDefinitionTemplateVM template)> _selected_changed;
+      public event Action<AlgoDefinitionVM> request_view_focus_name;
 
       public ObservableCollection<AlgoDefinitionVM> definitions => _definitions;
       public ObservableCollection<string> content_visual_states { get; } = new ObservableCollection<string>();
       public AlgoDefinitionVM selected_definition { get => _selected_definition.Value; set => _selected_definition.set(value); }
-      public AlgoDefinitionTemplateVM selected_template { get => _selected_template.Value; set => _selected_template.set(value); }
-      public IAlgoStudioContentVM content_source => (IAlgoStudioContentVM)selected_template ?? selected_definition;
       public IAlgoVM editable_content => _editable_content.Value;
       public ICollectionView<AlgoDefinitionVM> definitions_view => _definitions_view;
+      public ICommand add_definition_cmd { get; }
+      public ICommand clone_selected_definition_cmd { get; }
       public ICommand save_cmd { get; }
       public ICommand revert_cmd { get; }
       public string save_cmd_tooltip => _save_cmd_tooltip.Value;
       public string revert_cmd_tooltip => _revert_cmd_tooltip.Value;
 
-      public void add_new_definition() =>
-         _add_new_definition(AlgoDefinitionVM.new_algo_def, AlgoDefinitionVM.new_algo_name);
-
-      public void add_new_definition_clone(AlgoDefinitionVM src_definition) {
-         if (src_definition == null || src_definition.algo_root == null) {
-            add_new_definition();
-         } else {
-            _add_new_definition(src_definition.algo_root.definition, string.IsNullOrEmpty(src_definition.name) ? AlgoDefinitionVM.new_algo_name : $"{src_definition.name} - Copy");
-         }
-      }
-
-      void _add_new_definition(CustomOrderDefinitionImmutable def, string name) =>
-         _definitions.Add(AlgoDefinitionVM.create_placeholder(_model, def, name, _studio_formats));
-
       public StartupData create() => new StartupData();
       public void load_from(StartupData state) { }
       public IObservable<AlgoDefinitionVM> subscribe_definition() => _selected_definition.observe_current(true);
-      public IObservable<AlgoDefinitionTemplateVM> subscribe_template() => _selected_template.observe_current(true);
-      public IObservable<(AlgoDefinitionVM definition, AlgoDefinitionTemplateVM template)> observe_selected() =>
-         Observable.Create<(AlgoDefinitionVM definition, AlgoDefinitionTemplateVM template)>(o => {
-            _selected_changed += o.OnNext;
-            return Disposable.Create(() => _selected_changed -= o.OnNext);
-         });
       public IObservable<bool> subscribe_dirty() => _any_dirty_monitor;
 
       public async Task remove_definition(AlgoDefinitionVM definition) {
@@ -163,87 +156,43 @@ namespace mbts.spark {
             await _model.algo_model.remove_definition(definition.key);
          } else {
             // This is a new definition, which hasn't been saved/persisted yet.  No need to call the server.
-            definition.templates.Clear();
             definitions.Remove(definition);
          }
       }
 
-      public async Task remove_template(AlgoDefinitionTemplateVM template) {
-         if (template.key.mode == AlgoKey.Mode.Persisted) {
-            await _model.algo_model.remove_template(template.key);
-         } else {
-            // This is a new template, which hasn't been saved/persisted yet.  No need to call the server.
-            template.owner.templates.Remove(template);
-         }
-      }
+      public Task save_definition(AlgoDefinitionVM definition) =>
+         _save(new[] { definition });
 
-      public async Task save_definition(AlgoDefinitionVM definition) {
-         using (_save_op()) {
-            var newly_persisted_keys = await AlgoPersistenceHelper.persist_definition(_model, _definitions, definition);
-            AlgoKey pkey;
-            switch (definition.key.mode) {
-               case AlgoKey.Mode.Unpersisted:
-                  if (!newly_persisted_keys.TryGetValue(definition.key, out pkey))
-                     return;
-                  break;
-               case AlgoKey.Mode.Persisted:
-                  pkey = definition.key;
-                  break;
-               default: return;
-            }
-            await _model.algo_model.metadata_service.update_metadata(pkey, _ => definition.create_metadata().with(id: pkey));
-         }
-      }
+      public Task save_all() =>
+         _save(definitions);
 
-      public async Task save_template(AlgoDefinitionTemplateVM template) {
-         using (_save_op())
-            await AlgoPersistenceHelper.persist_template(_model, _definitions, template);
-      }
-
-      public async Task save_all() =>
-         await _save(definitions.WrapSelector(def => (def, def.templates.AsList()), t => t.def));
-
-      async Task _save(IList<(AlgoDefinitionVM definition, IList<AlgoDefinitionTemplateVM> templates)> definition_templates) {
-         using (_save_op())
-            await AlgoPersistenceHelper.persist(_model, definition_templates);
-      }
-
-      IDisposable _save_op() {
-         int? def_index = selected_definition == null ? (int?)null : _definitions.IndexOf(selected_definition);
-         int? tmp_index = selected_template == null ? (int?)null : selected_definition.templates.IndexOf(selected_template);
-         return new CompositeDisposable(_definitions_update_buffer.buffer_updates()) {
-            () => {
-               if (def_index.HasValue) {
-                  var def = _definitions[def_index.Value];
-                  if (tmp_index.HasValue) {
-                     var tmp = def.templates[tmp_index.Value];
-                     tmp.is_selected = true;
-                  } else def.is_selected = true;
+      async Task _save(IEnumerable<AlgoDefinitionVM> definitions) {
+         var orig_selected = selected_definition;
+         var orig_selected_index = orig_selected == null ? -1 : this.definitions.IndexOf(orig_selected);
+         using (_definitions_update_buffer.buffer_updates()) {
+            var def_list = definitions as IList<AlgoDefinitionVM> ?? definitions.ToList();
+            await Task.WhenAll(definitions.Select(async d => {
+               var def = await _model.algo_model.save_definition(d.create_algo_def());
+               if (def.HasValue) {
+                  // don't forget to save metadata
+                  await _model.algo_model.metadata_service.update_metadata(def.Value.key, _ => d.create_metadata().with(def.Value.key));
                }
-            }
-         };
-      }
-
-      /// Despite the existence of these properties: <see cref="AlgoDefinitionVM.is_selected"/>, and <see cref="AlgoDefinitionTemplateVM.is_selected"/>,
-      /// <see cref="AlgoStudioVM"/> still implements <see cref="IHandleSelectedItemChanged"/> to update the properties that depend on the <see cref="System.Windows.Controls.TreeView.SelectedItem"/>.
-      /// [John]I am going to Uganda in 3 days (today is 1/3/2019), and decided against removing this legacy-dependency at the last minute.
-      /// Fwiw, <see cref="AlgoDefinitionVM.is_selected"/> and <see cref="AlgoDefinitionTemplateVM.is_selected"/> are bound to <see cref="System.Windows.Controls.TreeViewItem.IsSelected"/>.
-      /// They serve to prevent a quirky default behavior in TreeView: double clicking any TreeViewItem collapses the entire TreeView.
-      /// This behavior wasn't just quirky either, it actually conflicted with the double-click-to-set-template-as-default behavior.
-      /// (for details, <see cref="mbts.ui.spark.AlgoStudioView.EnableToggleDefaultOnDoubleClickProperty"/>)
-      void IHandleSelectedItemChanged.on_selected_item_changed(object old_value, object new_value) {
-         if (new_value is AlgoDefinitionVM def) {
-            selected_definition = def;
-            selected_template = null;
-         } else if (new_value is AlgoDefinitionTemplateVM templ) {
-            selected_definition = templ.owner;
-            selected_template = templ;
-         } else {
-            selected_definition = null;
-            selected_template = null;
+               return def;
+            })).ContinueOnDispatcher(t => {
+               if (t.Status != TaskStatus.RanToCompletion) {
+                  Log.Ui.debug_fatal($"Algo Studio error saving definitions: unexpected Task.Status '{t.Status}'.");
+                  return;
+               }
+               var persisted_data = t.Result;
+               Log.assert(persisted_data.Length == def_list.Count);
+               for (int i = 0; i < persisted_data.Length; i++) {
+                  if (!def_list[i].key.is_persisted && persisted_data[i].HasValue)
+                     _definitions.Replace(def_list[i].key, def_list[i].to_persisted(persisted_data[i].Value));
+               }
+               if (selected_definition != orig_selected && orig_selected_index >= 0 && orig_selected_index < this.definitions.Count)
+                  selected_definition = this.definitions[orig_selected_index];
+            });
          }
-         _selected_changed?.Invoke((selected_definition, selected_template));
-         RaisePropertyChanged(nameof(content_source));
       }
    }
 }

src/client/spark/Modules/Trading/AlgoStudio/VM/AlgoVMWrapper.cs

@@ -109,7 +109,6 @@ namespace mbts.spark {
       public bool key_match(KeyEventArgs e) => _algo_root?.key_match(e) ?? false;
       public void load_from(CustomOrderDefinitionImmutable value) => _algo_root?.load_from(value);
       public void load_many(IEnumerable<CustomOrderDefinitionImmutable> values) => _algo_root?.load_many(values);
-      public Task<CustomOrderDefinitionImmutable?> load_from_async(CustomOrderDefinitionImmutable definition) => _algo_root is IAlgoVM vm ? vm.load_from_async(definition) : Task.FromResult<CustomOrderDefinitionImmutable?>(null);
       void IAlgoVM.ensure_init() => _value?.algo_root?.ensure_init();
 
       IDisposable _set_hooks(AlgoDefinitionVM vm) {

src/client/spark/Modules/Trading/AlgoStudio/View/AlgoEditorGridView/AlgoEditorGridView.xaml

@@ -513,6 +513,9 @@
                       LegTuples="{Binding leg_tuples}"
                       RemoveLegCommand="{Binding remove_leg}"
                       ContractPickerModel="{Binding contract_picker_model}"
+                      IsEnabled="{Binding IsReadOnly, RelativeSource={RelativeSource AncestorType=usp:AlgoEditorGridView}, Converter={StaticResource NotConverter}}"
+                      HedgePricing="{Binding hedge_pricing}"
+                      HedgePricingItemsSource="{Binding hedge_pricing_options}"
                     />
                   </AdornerDecorator>
                 </DataTemplate>

src/client/spark/Modules/Trading/AlgoStudio/View/AlgoEditorGridView/AlgoParamRowsHelper.cs

@@ -10,7 +10,7 @@ using System.Reactive.Disposables;
 namespace mbts.spark {
    static class AlgoParamRowsHelper {
       public static IDisposable connect(AlgoDefinitionVM algo, ObservableAggregateCollection<AlgoParamRowVM> rows, bool include_algo_type_rows) =>
-         algo == null ? null : new CompositeDisposable(algo.observe_algo_root().SubscribeEach(a => {
+         algo == null ? null : new CompositeDisposable(algo.observe_algo_root().OnDispatcher().SubscribeEach(a => {
             rows.clear_collections();
             if (a == null)
                return Disposable.empty;
@@ -77,7 +77,7 @@ namespace mbts.spark {
                include_algo_type_rows ?
                   (ObservableCollection<AlgoParamRowVM>)new ObservableAppendCollection<AlgoParamRowVM>(child_rows, selector_wrapper) :
                   child_rows,
-               s.subscribe_selected_algo().SubscribeEach(a => {
+               s.subscribe_selected_algo().OnDispatcher().SubscribeEach(a => {
                   s.value = a;
                   child_rows.clear_collections();
                   return _wrap_rows(a, selector_wrapper, child_rows, include_algo_type_rows);

src/client/spark/Modules/Trading/AlgoStudio/View/AlgoEditorGridView/AlgoParamTemplateSelector.cs

@@ -21,7 +21,7 @@ namespace mbts.ui.spark {
    class AlgoParamTemplateSelector : DataTemplateSelector {
       public static readonly Type generic_algo_param_itype = typeof(IAlgoParamVM<>);
 
-      KeyedCollection<TemplateSelectorKeyValue, string> _keyed_templates = new KeyedCollection<TemplateSelectorKeyValue, string>(tsk => tsk.Key);
+      KeyedCollection<TemplateSelectorKeyValue, string> _keyed_templates = new KeyedCollection<TemplateSelectorKeyValue, string>(tsk => tsk.Key.ToString());
 
       public DataTemplate BoolTemplate { get; set; }
       public DataTemplate NullableBoolTemplate { get; set; }

src/client/spark/Modules/Trading/Fills/FillsVM.cs

@@ -22,7 +22,6 @@ using System.Collections.Specialized;
 using System.Linq;
 using System.Reactive.Disposables;
 using System.Reactive.Linq;
-using System.Reactive.Subjects;
 using System.Windows.Data;
 using System.Windows.Media;
 using static bts.api.orderman.Fill.Types;
@@ -61,13 +60,59 @@ namespace mbts.spark {
             equality_comparer: SecurityDataHelper.EqualityComparer.IDComparer,
             comparer: Comparer<SecurityImmutable>.Default
          ), DataGridFilterKnownTemplates.DiscreteValues, DefaultColumnWidths.Security);
+         // symbol
+         add_col(Columns.Symbol, DefaultColumnHeaders.Symbol, r => r.security.Symbol,
+            DiscreteValuesFilterVM.Create<FillTuple, string>(
+               co2.UserSymbol.get_all().Select(u => u.symbol).Distinct().ToList(),
+               ft => ft.security?.Symbol ?? string.Empty,
+               nameof(OrderBookRowVM.symbol)),
+               DataGridFilterKnownTemplates.DiscreteValues,
+               DefaultColumnWidths.Symbol);
+         // algo items view (common resources)
+         var algo_items_comp = AlgoCollectionHelper.algo_data_vm_comparer.to_non_generic();
+         var algo_items_group_desc = new PropertyGroupDescription(nameof(AlgoDataVM.group));
          // order type
-         var order_type_filter = dv_filter(OrderDataHelper.all_order_types, r => r.order?.order_type() ?? OrderType.None);
+         var order_type_filter = DiscreteValuesFilterVM.CreateTableUpdate<FillTuple, AlgoDataVM, AlgoID, OrderType[]>(
+               ft => new AlgoDataVM(ft.algo ?? AlgoData.empty),
+               AlgoDataVM.id_fn,
+               ots => Array.ConvertAll(ots ?? Array.Empty<OrderType>(), ot => AlgoID.from_algo_key(AlgoKey.from_known_type(ot))),
+               ids => ids.empty_if_null().Select(AlgoID.to_algo_key).Where(k => k.mode == AlgoKey.Mode.Factory).Select(k => k.factory).ToArray(),
+               out var order_type_observer,
+               out var order_type_items_view);
+
+         order_type_items_view.CustomSort = algo_items_comp;
+         order_type_items_view.GroupDescriptions.Add(algo_items_group_desc);
+         order_type_observer.OnNext(TableUpdate<AlgoDataVM, AlgoID>.mk_empty(AlgoDataVM.id_fn)
+            .with_added(OrderDataHelper.all_order_types
+               .Select(OrderDataHelper.Defaults.CustomOrderDefinitionImmutable)
+               .Select(AlgoData.from_custom_def)
+               .Select(d => new AlgoDataVM(d))));
+
          add_col_expl(Columns.OrderType,
             new OrderTypeColumn<Columns>(Columns.OrderType, new Binding(nameof(Row.badge_fill)), new Binding(nameof(Row.display_name)), order_type_filter) {
                id = col_id(Columns.OrderType),
                sort_member_path = nameof(Row.order_type)
             }, order_type_filter);
+         // root algo type
+         var root_algo_type_filter = DiscreteValuesFilterVM.CreateTableUpdate<FillTuple, AlgoDataVM, AlgoID>(
+               ft => new AlgoDataVM(ft.root_algo ?? AlgoData.empty),
+               AlgoDataVM.id_fn,
+               out var root_algo_type_observer,
+               out var root_algo_type_items_view);
+
+         root_algo_type_items_view.CustomSort = algo_items_comp;
+         root_algo_type_items_view.GroupDescriptions.Add(algo_items_group_desc);
+
+         add_col_expl(Columns.RootAlgoType,
+            new OrderTypeColumn<Columns>(
+               Columns.RootAlgoType,
+               new Binding(nameof(Row.root_algo_badge_color)) { Converter = new ui.converters.ColorToBrushConverter() },
+               new Binding(nameof(Row.root_algo_display_name)),
+               root_algo_type_filter,
+               DefaultColumnHeaders.RootAlgoType) {
+               id = col_id(Columns.RootAlgoType),
+               sort_member_path = nameof(Row.root_algo_order_type)
+            }, root_algo_type_filter);
          // side
          var side_filter = dv_filter(new[] { Side.Buy, Side.Sell }, r => r.fill.Side);
          add_col_expl(Columns.Side, new SideColumn<Row, Columns>(Columns.Side, r => r.side, side_filter) { id = col_id(Columns.Side) }, side_filter);
@@ -121,8 +166,8 @@ namespace mbts.spark {
                };
                _rows_manager.on_settings(fs, s.sorting_criterion);
             }),
-            settings_manager == null ? Disposable.empty : settings_manager.subscribe_current().OnDispatcher().Subscribe(grid_settings_manager),
-            (fills_source as IConnectableObservable<TableUpdate<FillTuple, string>>)?.Connect() ?? Disposable.empty
+            model.subscribe_all_algos().SelectKeyValue(AlgoDataVM.from_data, d => AlgoID.from_algo_key(d.data.key)).OnDispatcher().Subscribe(root_algo_type_observer),
+            settings_manager == null ? Disposable.empty : settings_manager.subscribe_current().OnDispatcher().Subscribe(grid_settings_manager)
          );
          // local methods
          void add_col<TFilter>(Columns col_key, string header, Func<Row, string> get_text, IDataGridColumnPersistentFilter<FillTuple, TFilter> filter, string filter_template, double width) =>
@@ -169,11 +214,11 @@ namespace mbts.spark {
       static IObservable<TableUpdate<FillTuple, string>> _get_observable(IBus bus, OrdersModel model, FillsSettings state) {
          if (!state.orders.is_null_or_empty()) {
             var orders_hash = new HashSet<uint>(state.orders);
-            return model.on_fill_tuples.Filter(f => orders_hash.Contains(f.fill.OrderKey));
-         } else return model.on_fill_tuples;
+            return model.on_fill_tuples_with_root.Filter(f => orders_hash.Contains(f.fill.OrderKey));
+         } else return model.on_fill_tuples_with_root;
       }
 
-      static IConnectableObservable<TableUpdate<FillTuple, string>> _get_observable(IBus bus, OrdersModel model, IObservable<FillsSettings> state) =>
+      static IObservable<TableUpdate<FillTuple, string>> _get_observable(IBus bus, OrdersModel model, IObservable<FillsSettings> state) =>
          state.SelectManyInSeries(s => _get_observable(bus, model, s));
 
       static IComparer<FillTuple> _get_column_comparer(Columns col) {
@@ -185,11 +230,13 @@ namespace mbts.spark {
             case Columns.FillTime: return wrap(ft => ft.fill.Timestamp.to_local_time());
             case Columns.OrderKey: return wrap(ft => ft.fill.OrderKey);
             case Columns.OrderType: return wrap_default(ft => ft.order?.order_type() ?? OrderType.None);
+            case Columns.RootAlgoType: return wrap_default(ft => ft.root_algo.HasValue ? ft.root_algo.Value.value.CustomCase : OrderType.None);
             case Columns.Price: return wrap(ft => ft.fill.LastPrice);
             case Columns.Security: return wrap(ft => ft.security ?? SecurityDataHelper.Defaults.SecurityImmutable);
             case Columns.SecurityKey: return wrap(ft => ft.fill.SecurityKey);
             case Columns.Side: return wrap_default(ft => ft.fill.Side);
             case Columns.Size: return wrap(ft => ft.fill.LastShares);
+            case Columns.Symbol: return wrap(ft => ft.security?.Symbol ?? string.Empty);
             case Columns.TimeInForce: return wrap_default(ft => ft.order?.time_in_force() ?? TimeInForce.Undefined);
             case Columns.User: return wrap(ft => ft.order?.user() ?? string.Empty);
             default: goto case Columns.FillTime;
@@ -217,7 +264,10 @@ namespace mbts.spark {
          readonly OrdersModel _model;
          readonly FillImmutable _fill;
          readonly OrderRecordImmutable _order;
+         AlgoData? _root_algo => fill_tuple.root_algo;
+         AlgoDefinitionMetadata? _root_algo_meta => fill_tuple.root_algo_meta;
          Brush _badge_fill;
+         Color? _root_algo_badge_color;
          OrderMetadata _order_metadata;
 
          public Row(FillTuple fill_tuple, OrdersModel model) : 
@@ -232,6 +282,7 @@ namespace mbts.spark {
          public DateTime fill_time => _fill.Timestamp.to_local_time();
          public TimeInForce time_in_force => _order.time_in_force();
          public OrderType order_type => _order.order_type();
+         //public OrderType root_algo_type => _or
          public string display_name => OrderUtils.display_name(_order, fill_tuple.algo);
          public OrderMetadata order_metadata => _order_metadata ?? (_order_metadata = _model.factory.get_metadata(_order.Def.CustomDef.CustomCase));
          public Brush badge_fill => _badge_fill ?? (_badge_fill = OrderUtils.badge_fill(fill_tuple.algo_meta, order_metadata));
@@ -245,6 +296,12 @@ namespace mbts.spark {
          public string fill_key => _fill.FillKey;
          public string order_key => _order.Key.ToString();
 
+         // Root Algo
+         public OrderType root_algo_order_type => _root_algo.HasValue ? _root_algo.Value.value.CustomCase : OrderType.None;
+         public OrderMetadata root_algo_order_metadata => _model.factory.get_metadata(root_algo_order_type);
+         public Color root_algo_badge_color => _root_algo_badge_color ??  (_root_algo_badge_color = OrderUtils.badge_color(_root_algo_meta, root_algo_order_metadata)).Value;
+         public string root_algo_display_name => _root_algo?.name ?? root_algo_order_type.display_name();
+
          public bool Equals(Row other) => other != null && other._fill.Equals(_fill) && other._order.Equals(_order);
          public override bool Equals(object obj) => Equals(obj as Row);
          public override int GetHashCode() => _fill.FillKey.GetHashCode() ^ _order.Key.GetHashCode();

src/client/spark/Modules/Trading/Fills/FillsView.xaml

@@ -6,6 +6,10 @@
   xmlns:c="clr-namespace:mbts.ui.controls"
   xmlns:usp="clr-namespace:mbts.ui.spark"
   xmlns:uspcv="clr-namespace:mbts.ui.spark.converters"
+  xmlns:cv="clr-namespace:mbts.ui.converters"
+  xmlns:u="clr-namespace:mbts.ui"
+  xmlns:api="clr-namespace:bts.api;assembly=spark_api"
+  xmlns:bts="clr-namespace:mbts.ui.controls"
   FocusManager.IsFocusScope="True"
   Background="{StaticResource CommonBackground}"
 >
@@ -15,6 +19,10 @@
         <ResourceDictionary Source="/view/Controls/DataGridEx/Filters/Views/FilterTemplates.xaml"/>
       </ResourceDictionary.MergedDictionaries>
       <uspcv:TickDisplayConverter x:Key="TickDisplayConverter"/>
+      <cv:ValueMap x:Key="SideToBrushConverter" Default="{u:Brush Transparent}">
+        <cv:KeyValue Key="{u:Enum Buy, Type=api:Side}" Value="{x:Static semi_transparent_bid_brush, MemberType={u:Nested u:BTSColors.MarketData}}"/>
+        <cv:KeyValue Key="{u:Enum Sell, Type=api:Side}" Value="{x:Static semi_transparent_ask_brush, MemberType={u:Nested u:BTSColors.MarketData}}"/>
+      </cv:ValueMap>
     </ResourceDictionary>
   </UserControl.Resources>
   <AdornerDecorator>
@@ -41,10 +49,10 @@
             CanExecute="{x:Static c:DIYGrid.DefaultRowActionCanExecute}"
           />
         </c:DIYGrid.CommandBindings>
-        <c:DIYGrid.RowTemplate>
-          <DataTemplate>
-            <usp:FillsRowView/>
-          </DataTemplate>
+        <c:DIYGrid.RowTemplate>
+          <DataTemplate>
+            <usp:FillsRowView Background="{Binding side, Converter={StaticResource SideToBrushConverter}}"/>
+          </DataTemplate>
         </c:DIYGrid.RowTemplate>
       </c:DIYGrid>
       <StatusBar Grid.Row="1" DockPanel.Dock="Bottom">

src/client/spark/Modules/Trading/Fills/FillsView.xaml.cs

@@ -7,7 +7,24 @@ namespace mbts.ui.spark {
    /// Interaction logic for FillsView.xaml
    /// </summary>
    partial class FillsView : UserControl {
-      public enum Columns { FillTime, User, Account, Exchange, Security, TimeInForce, OrderType, Side, Price, Size, FillKind, FillKey, OrderKey, SecurityKey }
+      public enum Columns {
+         FillTime,
+         User,
+         Account,
+         Exchange,
+         Security,
+         Symbol,
+         TimeInForce,
+         OrderType,
+         RootAlgoType,
+         Side,
+         Price,
+         Size,
+         FillKind,
+         FillKey,
+         OrderKey,
+         SecurityKey
+      }
 
       public FillsView() =>
          InitializeComponent();

src/client/spark/Modules/Trading/Fills/FillsWindow.cs

@@ -6,6 +6,7 @@ using bts.spark;
 using mbts.persist;
 using mbts.ui;
 using mbts.ui.settings;
+using mbts.ui.shell;
 using mbts.ui.spark;
 using mbts.ui.utility;
 using mbts.utils;
@@ -60,19 +61,18 @@ namespace mbts.spark {
          _commands = new List<SparkCommand> {
             // wrap the grid settings view factory in a dialogCommand here since the vm is destroyed/recreated when the security criteria changes
             SparkCommands.window_settings_command(new DialogCommand(() => {
-               var vm = new WindowSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
+               var vm = new ShellSettingsDialogVM<GridSettings, SimpleGridSettingsVM>(
                   _settings_manager, 
                   us => us.fills_grid, 
                   UserSettings.FileExtensions.GRID,
                   s => _vm.grid_settings_manager.create_vm(
                      // we need to get the most up to date GridSettings when launching b/c users may
                      // have changed some settings on the grid directly, like column widths.
-                     s.with(_vm.columns.Select( c => c.create())),
-                     this.observe_title()
+                     s.with(_vm.columns.Select(c => c.create()))
                   )
                );
-               // TODO: bind to main window's Title
-               var dialog = new SimpleGridSettingsDialog { Title = $"{window_type_name} Grid Settings", DataContext = vm };
+               vm.SubscribeDisposed(literal_title_source.OnDispatcher().Subscribe(t => vm.title = t));
+               var dialog = new ShellSettingsDialog { DataContext = vm };
                vm.RequestClose += (s, e) => WindowUtilities.force_close(dialog);
                return dialog;
             }))

src/client/spark/Modules/Trading/Fills/FillsWindowFactory.cs

@@ -1,19 +1,15 @@
 using bts.api;
-using bts.api.orderman;
+using bts.settings;
 using bts.shell.fills;
 using mbts.persist;
 using mbts.spark;
-using mbts.spark.filters;
 using mbts.ui;
-using mbts.ui.controls;
 using mbts.ui.settings;
-using ProtoBuf;
 using System;
 using System.Collections.Generic;
-using System.Linq;
+using System.ComponentModel.Composition;
 using System.Reactive.Linq;
 using System.Threading.Tasks;
-using static mbts.ui.controls.DIYGrid;
 using static mbts.ui.spark.FillsView;
 
 namespace bts.shell {
@@ -34,6 +30,7 @@ namespace bts.shell {
             { nameof(FillsVM.Row.fill_time), Columns.FillTime },
             { nameof(FillsVM.Row.order_key), Columns.OrderKey },
             { nameof(FillsVM.Row.order_type), Columns.OrderType },
+            { nameof(FillsVM.Row.root_algo_order_type), Columns.RootAlgoType },
             { nameof(FillsVM.Row.price), Columns.Price },
             { nameof(FillsVM.Row.security), Columns.Security },
             { nameof(FillsVM.Row.security_key), Columns.SecurityKey },
@@ -67,5 +64,12 @@ namespace bts.shell {
             set: (us, gs) => us.with(provided_fills_gridsettings: gs));
          return new FillsWindow(this, _bus, _orders_model, state, settings_manager);
       }
+
+      // migration rules
+      [Export(typeof(IFillsGridSettingsMigrationRule))]
+      class AddMissingColumnsMigrationRule : IFillsGridSettingsMigrationRule {
+         public bool apply(GridSettings settings, out GridSettings new_settings) =>
+            settings.add_missing_columns(FillsSettings.DefaultGridSettings.columns, out new_settings);
+      }
    }
 }

src/client/spark/Modules/Trading/Fills/Settings/FillsFilterStates.cs

@@ -23,6 +23,10 @@ namespace bts.shell.fills {
       [DIYGridColumnID(nameof(Columns.OrderType))]
       public CustomOrderDefinition.CustomOneofCase[] order_type { get; set; }
 
+      [ProtoMember(16)]
+      [DIYGridColumnID(nameof(Columns.RootAlgoType))]
+      public AlgoID[] root_algo_type { get; set; }
+
       [ProtoMember(4)]
       [DIYGridColumnID(nameof(Columns.Account))]
       public string[] account { get; set; }
@@ -66,6 +70,10 @@ namespace bts.shell.fills {
       [ProtoMember(14)]
       [DIYGridColumnID(nameof(Columns.FillKind))]
       public Fill.Types.FillKind[] fill_kind { get; set; }
+
+      [ProtoMember(15)]
+      [DIYGridColumnID(nameof(Columns.Symbol))]
+      public string[] symbol { get; set; }
    }
 
    static class FillsFilterStatesExtensions {
@@ -84,8 +92,10 @@ namespace bts.shell.fills {
          pb.add_discrete_values(fs.exchange, ft => ft.exchange());
          pb.add_discrete_values(fs.time_in_force, ft => ft.time_in_force());
          pb.add_discrete_values(fs.order_type, ft => ft.order_type());
+         pb.add_discrete_values(fs.root_algo_type, ft => AlgoID.from_algo_key((ft.root_algo ?? AlgoData.empty).key));
          pb.add_discrete_values(fs.side, ft => ft.fill.Side);
          pb.add_discrete_values(fs.fill_kind, ft => ft.fill.FillKind);
+         pb.add_discrete_values(fs.symbol, ft => ft.security?.Symbol ?? string.Empty);
          // numeric
          pb.add_numeric(fs.size, ft => ft.fill.LastShares);
          pb.add_numeric(fs.price, ft => ft.fill.LastPrice);

src/client/spark/Modules/Trading/Fills/Settings/FillsSettings.cs

@@ -40,12 +40,14 @@ namespace bts.shell.fills {
 
       static class DefaultColumns {
          public static GridColumnSettings security => new GridColumnSettings(col_id(Columns.Security), DefaultColumnHeaders.Security, width: DefaultColumnWidths.Security);
+         public static GridColumnSettings symbol => new GridColumnSettings(col_id(Columns.Symbol), DefaultColumnHeaders.Symbol, width: DefaultColumnWidths.Symbol);
          public static GridColumnSettings fill_time => new GridColumnSettings(col_id(Columns.FillTime), DefaultColumnHeaders.FillTime, width: DefaultColumnWidths.Time);
          public static GridColumnSettings user => new GridColumnSettings(col_id(Columns.User), DefaultColumnHeaders.User, width: DefaultColumnWidths.User);
          public static GridColumnSettings account => new GridColumnSettings(col_id(Columns.Account), DefaultColumnHeaders.Account, width: DefaultColumnWidths.Account);
          public static GridColumnSettings exchange => new GridColumnSettings(col_id(Columns.Exchange), DefaultColumnHeaders.Exchange, width: DefaultColumnWidths.Exchange);
          public static GridColumnSettings time_in_force => new GridColumnSettings(col_id(Columns.TimeInForce), DefaultColumnHeaders.TimeInForce, width: DefaultColumnWidths.TimeInForce);
          public static GridColumnSettings order_type => new GridColumnSettings(col_id(Columns.OrderType), DefaultColumnHeaders.OrderType, width: DefaultColumnWidths.OrderType);
+         public static GridColumnSettings root_algo_type => new GridColumnSettings(col_id(Columns.RootAlgoType), DefaultColumnHeaders.RootAlgoType, width: DefaultColumnWidths.OrderType);
          public static GridColumnSettings side => new GridColumnSettings(col_id(Columns.Side), DefaultColumnHeaders.Side, width: DefaultColumnWidths.Side);
          public static GridColumnSettings quantity => new GridColumnSettings(col_id(Columns.Size), DefaultColumnHeaders.Size, width: DefaultColumnWidths.Size, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
          public static GridColumnSettings price => new GridColumnSettings(col_id(Columns.Price), DefaultColumnHeaders.Price, width: DefaultColumnWidths.Price, horizontal_alignment: System.Windows.HorizontalAlignment.Right);
@@ -62,12 +64,14 @@ namespace bts.shell.fills {
          public static IEnumerable<GridColumnSettings> all {
             get {
                yield return security;
+               yield return symbol;
                yield return fill_time;
                yield return user;
                yield return account;
                yield return exchange;
                yield return time_in_force;
                yield return order_type;
+               yield return root_algo_type;
                yield return side;
                yield return quantity;
                yield return price;

src/client/spark/Modules/Trading/Ladder/LadderSettings.cs

@@ -9,6 +9,7 @@ using bts.proto;
 using mbts.ui.spark;
 using System.Collections.Generic;
 using System.ComponentModel;
+using mbts.ui.settings;
 
 namespace mbts.spark {
    // IMPORTANT: BE SURE TO ADD ANY NEW PROPERTIES TO THE EQUALS FUNCTION!
@@ -193,20 +194,27 @@ namespace mbts.spark {
       readonly bts.persist.algo.AlgoPersistedKey[] _favorite_algos;
       [ProtoMember(2)]
       public readonly int column_count;
+      [ProtoMember(3)]
+      readonly bts.persist.algo.AlgoPersistedKey[] _stickied_algos;
 
-      public LadderFavoriteAlgosSettings(AlgoKey[] favorite_algos, int column_count)
-         : this(ArrayHelper.safe_convert(favorite_algos, k => k.persisted), column_count) { }
+      public LadderFavoriteAlgosSettings(AlgoKey[] favorite_algos, int column_count, AlgoKey[] stickied_algos)
+         : this(ArrayHelper.safe_convert(favorite_algos, k => new bts.persist.algo.AlgoPersistedKey(k.persisted)),
+              column_count,
+              ArrayHelper.safe_convert(stickied_algos, k => new bts.persist.algo.AlgoPersistedKey(k.persisted))) { }
 
-      LadderFavoriteAlgosSettings(bts.persist.algo.AlgoPersistedKey[] favorite_algos, int column_count) {
+      LadderFavoriteAlgosSettings(bts.persist.algo.AlgoPersistedKey[] favorite_algos, int column_count, bts.persist.algo.AlgoPersistedKey[] stickied_algos) {
          _favorite_algos = favorite_algos;
          this.column_count = column_count;
+         _stickied_algos = stickied_algos;
       }
 
       public IReadOnlyList<AlgoKey> favorite_algos => ArrayHelper.safe_convert(_favorite_algos, k => k.to_algo_key());
+      public IReadOnlyList<AlgoKey> stickied_algos => ArrayHelper.safe_convert(_stickied_algos, k => k.to_algo_key());
 
       public bool Equals(LadderFavoriteAlgosSettings other) =>
          column_count == other.column_count &&
-         favorite_algos.SequenceEqual(other.favorite_algos);
+         favorite_algos.SequenceEqual(other.favorite_algos) &&
+         stickied_algos.SequenceEqual(other.stickied_algos);
 
       public override bool Equals(object obj) =>
          EqualityComparer.equals_obj(this, obj);
@@ -214,12 +222,30 @@ namespace mbts.spark {
       public override int GetHashCode() =>
          EqualityComparer.aggregate_hash(
             column_count,
-            EqualityComparer.aggregate_hash_limited(favorite_algos));
+            EqualityComparer.aggregate_hash_limited(favorite_algos),
+            EqualityComparer.aggregate_hash_limited(stickied_algos));
 
       public static bool operator ==(LadderFavoriteAlgosSettings a, LadderFavoriteAlgosSettings b) => a.Equals(b);
       public static bool operator !=(LadderFavoriteAlgosSettings a, LadderFavoriteAlgosSettings b) => !a.Equals(b);
    }
 
+   [ProtoContract]
+   readonly struct LadderMiniOrderBookSettings : IEquatable<LadderMiniOrderBookSettings> {
+      // this is the only member now, but more may be added later (that is why a GridSettings member wasn't added directly to LadderSettings).
+      [ProtoMember(1)]
+      public readonly GridSettings value;
+
+      public LadderMiniOrderBookSettings(GridSettings value) =>
+         this.value = value;
+
+      public bool Equals(LadderMiniOrderBookSettings other) => value == null ? other.value == null : value.Equals(other.value);
+      public override bool Equals(object obj) => obj is LadderMiniOrderBookSettings other && Equals(other);
+      public override int GetHashCode() => value.GetHashCode();
+
+      public static bool operator ==(LadderMiniOrderBookSettings a, LadderMiniOrderBookSettings b) => a.Equals(b);
+      public static bool operator !=(LadderMiniOrderBookSettings a, LadderMiniOrderBookSettings b) => !a.Equals(b);
+   }
+
    // IMPORTANT: BE SURE TO ADD ANY NEW PROPERTIES TO THE EQUALS FUNCTION!
    // 1 important reason at this time:
    // From the settings dialog, default settings will only be persisted when they are NOT EQUAL to the current default settings.
@@ -228,6 +254,7 @@ namespace mbts.spark {
    class LadderSettings : IEquatable<LadderSettings> {
       const double _default_order_entry_panel_width = 110.0;
       const double _default_zoom_factor = 1.0;
+      const bool _default_show_warn_on_cross = true;
 
       // Default proto constructor
       // Added this so that when clients upgrade to a version with new settings,
@@ -254,7 +281,8 @@ namespace mbts.spark {
          order_entry_panel_initial_width = _default_order_entry_panel_width;
          zoom_factor = _default_zoom_factor;
          use_defaults = true;
-         favorite_algos = new LadderFavoriteAlgosSettings(null, 2);
+         favorite_algos = new LadderFavoriteAlgosSettings(null, 2, null);
+         show_warn_on_cross = _default_show_warn_on_cross;
       }
 
       public static LadderSettings Default {
@@ -286,8 +314,8 @@ namespace mbts.spark {
                volume_column = VolumeColumnSettings.Default,
                calculator_buttons = new[] { 1, 5, 10, 25, 50, 100 },
                scroll_bar_visible = false,
-               default_order_type = CustomOrderDefinition.CustomOneofCase.Limit,
                default_time_in_force = TimeInForce.Day,
+               default_algo = new AlgoID(CustomOrderDefinition.CustomOneofCase.Limit),
                animate_recenter = true,
                badge_style = BadgeStyle.Normal,
                bid_break_line = new LadderMarketBreakLine { color = 0, show = true },
@@ -319,6 +347,7 @@ namespace mbts.spark {
                zoom_slider_visible = false,
                zoom_factor = _default_zoom_factor,
                net_change = NetChangeTerms.None,
+               mini_ob = new LadderMiniOrderBookSettings(bts.shell.orderbook.OrderBookStartupData.default_mini_grid.general),
             };
             rv.row_height = LadderRender.measure_row_height(rv);
             return rv;
@@ -327,7 +356,15 @@ namespace mbts.spark {
 
       public enum BadgeStyle { Normal, Alternate }
 
-      public enum NetChangeTerms { None, Dollars, Ticks }
+      // TODO: rename to PriceDisplayFormat (today is merge monday, since this isn't a functional change, it is not worth the potential merge headaches right now)
+      public enum NetChangeTerms {
+         [Description("Standard Ticks")]
+         None,
+         [Description("Net Change Dollars")]
+         Dollars,
+         [Description("Net Change Ticks")]
+         Ticks
+      }
 
       [ProtoMember(1)]
       public double row_height { get; set; }
@@ -354,6 +391,10 @@ namespace mbts.spark {
       public bool scroll_bar_visible { get; set; }
       // USED [ProtoMember(11)]
       // USED [ProtoMember(12)]
+      [ProtoMember(51)]
+      public uint default_account { get; set; }
+      [ProtoMember(52)]
+      public AlgoID default_algo { get; set; }
       [ProtoMember(13)]
       public CustomOrderDefinition.CustomOneofCase default_order_type { get; set; }
       [ProtoMember(14)]
@@ -364,6 +405,8 @@ namespace mbts.spark {
       public bool animate_recenter { get; set; } = true;
       [ProtoMember(17)]
       public BadgeStyle badge_style { get; set; }
+      [ProtoMember(53)]
+      public bool auto_clear { get; set; }
 
       [ProtoMember(18)]
       public LadderMarketBreakLine bid_break_line { get; set; }
@@ -407,6 +450,8 @@ namespace mbts.spark {
       public bool account_position_visible { get; set; }
       [ProtoMember(50), DefaultValue(true)]
       public bool day_position_visible { get; set; }
+      [ProtoMember(56)]
+      public bool raw_day_position_visible { get; set; }
       [ProtoMember(37), DefaultValue(true)]
       public bool size_presets_visible { get; set; }
       [ProtoMember(38), DefaultValue(true)]
@@ -446,6 +491,47 @@ namespace mbts.spark {
          get => _piq_column ?? (_piq_column = LadderSettings.Default.piq_column);
          set => _piq_column = value;
       }
+      [ProtoMember(54), DefaultValue(_default_show_warn_on_cross)]
+      public bool show_warn_on_cross { get; set; }
+
+      [ProtoMember(55)]
+      public LadderMiniOrderBookSettings mini_ob { get; set; }
+
+      public void sanitize() =>
+         sanitize(this);
+
+      // if there are new props, make sure they are not null, invalid, etc.
+      public static LadderSettings sanitize(LadderSettings s) {
+         if (s == null)
+            return null;
+         // these MarketBreakLines are new settings props, ensure they are not null
+         if (s.bid_break_line == null)
+            s.bid_break_line = Default.bid_break_line;
+         if (s.ask_break_line == null)
+            s.ask_break_line = Default.ask_break_line;
+         if (s.mid_break_line == null)
+            s.mid_break_line = Default.mid_break_line;
+         if (s.session_low_line == null)
+            s.session_low_line = Default.session_low_line;
+         if (s.session_high_line == null)
+            s.session_high_line = Default.session_high_line;
+         if (s.session_range_fill == null)
+            s.session_range_fill = Default.session_range_fill;
+         if (s.volume_column == null)
+            s.volume_column = Default.volume_column;
+         if (s.size_display == null)
+            s.size_display = MarketSizeDisplay.get_default();
+         if (s.size_display.normal == null)
+            s.size_display = s.size_display.with(MarketSizeDisplay.get_default().normal);
+         if (s.mini_ob.value == null)
+            s.mini_ob = new LadderMiniOrderBookSettings(bts.shell.orderbook.OrderBookStartupData.default_mini_grid.general);
+#pragma warning disable CS0612 // Type or member is obsolete
+         if (s.mini_ob.value.sorting_criterion.Count == 0)
+            s.mini_ob = new LadderMiniOrderBookSettings(s.mini_ob.value.with(sorting_criterion: bts.shell.orderbook.OrderBookStartupData.default_mini_grid.general.sorting_criterion));
+#pragma warning restore CS0612 // Type or member is obsolete
+         s.row_height = LadderRender.measure_row_height(s);
+         return s;
+      }
 
       public bool Equals(LadderSettings other) =>
          other != null &&
@@ -459,11 +545,13 @@ namespace mbts.spark {
          piq_column.safe_equals(other.piq_column) &&
          calculator_buttons.safe_equals(other.calculator_buttons, (a, b) => a.SequenceEqual(b)) &&
          scroll_bar_visible == other.scroll_bar_visible &&
-         default_order_type == other.default_order_type &&
+         default_account == other.default_account &&
+         default_algo == other.default_algo &&
          default_time_in_force == other.default_time_in_force &&
          size == other.size &&
          animate_recenter == other.animate_recenter &&
          badge_style == other.badge_style &&
+         auto_clear == other.auto_clear &&
          bid_break_line.safe_equals(other.bid_break_line) &&
          ask_break_line.safe_equals(other.ask_break_line) &&
          mid_break_line.safe_equals(other.mid_break_line) &&
@@ -484,6 +572,7 @@ namespace mbts.spark {
          order_type_visible == other.order_type_visible &&
          account_position_visible == other.account_position_visible &&
          day_position_visible == other.day_position_visible &&
+         raw_day_position_visible == other.raw_day_position_visible &&
          size_presets_visible == other.size_presets_visible &&
          cancel_buys_visible == other.cancel_buys_visible &&
          cancel_sells_visible == other.cancel_sells_visible &&
@@ -495,7 +584,9 @@ namespace mbts.spark {
          zoom_factor == other.zoom_factor &&
          use_defaults == other.use_defaults &&
          favorite_algos == other.favorite_algos &&
-         net_change == other.net_change;
+         net_change == other.net_change &&
+         show_warn_on_cross == other.show_warn_on_cross &&
+         mini_ob == other.mini_ob;
 
       public override bool Equals(object obj) => Equals(obj as LadderSettings);
 
@@ -512,7 +603,6 @@ namespace mbts.spark {
             EqualityComparer.safe_get_hash_code(piq_column),
             EqualityComparer.safe_get_hash_code(calculator_buttons),
             scroll_bar_visible.GetHashCode(),
-            default_order_type.GetHashCode(),
             default_time_in_force.GetHashCode(),
             size.GetHashCode(),
             animate_recenter.GetHashCode(),
@@ -547,7 +637,8 @@ namespace mbts.spark {
             zoom_factor.GetHashCode(),
             use_defaults.GetHashCode(),
             favorite_algos.GetHashCode(),
-            net_change.GetHashCode());
+            net_change.GetHashCode(),
+            show_warn_on_cross.GetHashCode());
 
       public struct WindowSpecifics {
          public readonly double order_entry_panel_width, zoom_factor;

src/client/spark/Modules/Trading/Ladder/LadderWindowFactory.cs

@@ -1,17 +1,20 @@
-using bts.api;
+using bts.api;
 using bts.md;
 using mbts;
 using mbts.config;
 using mbts.persist;
 using mbts.spark;
 using mbts.ui;
+using mbts.ui.shell;
 using mbts.ui.spark;
 using ProtoBuf;
 using System;
 using System.Collections.Generic;
+using System.Collections.Immutable;
+using System.IO;
 using System.Linq;
 using System.Reactive.Linq;
-using System.Threading;
+using System.Reactive.Subjects;
 using System.Threading.Tasks;
 using System.Windows;
 using LadderSettings = mbts.spark.LadderSettings;
@@ -19,28 +22,31 @@ using LadderSettings = mbts.spark.LadderSettings;
 namespace bts.shell {
    class LadderWindowFactory : ShellWindowFactory<LadderSaveState> {
       const string _window_type = "ladder";
+      const int _version_where_stickied_algos_introduced = 2;
       readonly LadderConfig _ladder_conf;
       readonly IBus _bus;
       readonly IWindowManager _wm;
       readonly MBOService _mbo;
       readonly UserSettingsHub _settings_hub;
       readonly OrdersModel _orders_model;
+      readonly IShellWindowThreadIDProvider _thread_id_provider;
       IReadOnlyDictionary<uint, SecurityMD> _securities = new Dictionary<uint, SecurityMD>();
 
       public LadderWindowFactory(
-         IShellModule owner, 
-         IBus bus, 
-         IWindowManager wm, 
-         UserSettingsHub settings_hub, 
+         IShellModule owner,
+         IBus bus,
+         IWindowManager wm,
+         UserSettingsHub settings_hub,
          OrdersModel orders_model,
          MBOService mbo)
 
-         : base(owner, "SparkLadder") {
+         : base(owner, "SparkLadder", 2) {
          _bus = bus;
          _wm = wm;
          _settings_hub = settings_hub;
          _orders_model = orders_model;
          _ladder_conf = new LadderConfig(Configuration.get<bts.config.LadderKnobs>(), Configuration.get<bts.config.MultiThreadedWindows>().ladder);
+         _thread_id_provider = ShellWindowThreadIDFactory.create("Ladder", _ladder_conf.ladders_on_threads);
          _mbo = mbo;
          _dispose = Disposable.Create(
             bus.subscribe(SparkTags.SecuritiesTag).Subscribe(s => _securities = s),
@@ -52,63 +58,219 @@ namespace bts.shell {
       public async override Task<IShellWindow> load(LadderSaveState state) {
          await Wait.until_true(() => _securities.ContainsKey(state.security_key), _ladder_conf.security_timeout);
          if (_securities.TryGetValue(state.security_key, out SecurityMD security)) {
-            return create_ladder_window(security, state.settings);
+            return create_ladder_window(security, state.settings, state.settings_id);
          }
          return null;
       }
 
-      static LadderSaveState _get_state(LadderVM vm) =>
-         new LadderSaveState { security_key = vm.security.Id, settings = vm.get_save_state() };
+      protected override Task<IShellWindow> try_upgrade_state(Stream load_stream, int version) {
+         var state = ProtoBuf.Serializer.DeserializeWithLengthPrefix<LadderSaveState>(load_stream, ProtoBuf.PrefixStyle.Fixed32);
+         if (version < _version_where_stickied_algos_introduced) {
+            // We want to assign any existing favorite algos to stickied algos upon setting upgrade
+            var favorite_algos_array = state.settings.favorite_algos.favorite_algos.ToArray();
+            state.settings.favorite_algos = new LadderFavoriteAlgosSettings(favorite_algos_array, state.settings.favorite_algos.column_count, favorite_algos_array);
+         }
+         return load(state);
+      }
 
-      int _ladder_count = 0;
-      IShellWindow create_ladder_window(SecurityMD md, LadderSettings state_settings) {
-         var id = Interlocked.Increment(ref _ladder_count) % Environment.ProcessorCount;
+      LadderSaveState _get_state(LadderVM vm, uint id) {
+         LadderSettings s = vm.get_save_state();
+         if (id != 0) {
+            if (!_settings_hub.current.ladder_profiles.TryGetFirst(lp => lp.id == id, out var result)) {
+               // profile was deleted
+               id = 0;
+            } else {
+               if (!s.Equals(result.value)) {
+                  // ladder's settings diverged from the profile (this happens when the user changes settings outside of the settings dialog, such as column widths, left panel width, etc.)
+                  id = 0;
+               }
+            }
+         }
+         return new LadderSaveState { security_key = vm.security.Id, settings = s, settings_id = id };
+      }
+
+      IShellWindow create_ladder_window(SecurityMD md, LadderSettings last_value, uint settings_id = 0) {
+         IDisposable active_settings_dialog = null;
+         // on_shell_window_vm should behave like an event (do not set to null)
+         Action<ShellWindowVM> on_shell_window_vm = _ => { };
+         ShellWindowVM shell_window_vm = null;
+         IShellWindow shell_window = null;
+         var title_source = new LazyObservable<string>(() => ShellWindowExtensions.literal_title_source(shell_window, shell_window_vm));
          var view = new Lazy<UIElement>(() => {
+            // resources
             var model = new LadderModel(md, _orders_model, _mbo);
-            var settings_manager = new WindowSettingsManager<LadderSettings>(
-               _settings_hub, state_settings == null || state_settings.use_defaults ? null : state_settings,
-               us => sanitize_ladder_settings(us.ladder),
-               (us, v) => us.with(sanitize_ladder_settings(v)));
-            var init = state_settings ?? settings_manager.default_settings;
-            init.use_defaults |= state_settings == null;
-            var vm = LadderVM.create(_bus, model, settings_manager, init);
+            var profile_service = new SettingsProfileService<LadderSettings>(_settings_hub,
+               us => ImmutableDictionary<uint, SettingsProfile<LadderSettings>>.Empty.AddRange(us.ladder_profiles.ToDictionary(
+                  lp => lp.id,
+                  lp => new SettingsProfile<LadderSettings>(lp.id, lp.name, LadderSettings.sanitize(lp.value), lp.security_criteria))),
+               (us, lps) => us.with(ladder_profiles: lps.Values.Select(lp => new LadderSettingsProfile(lp.id, lp.name, lp.value, lp.security_criteria)).ToArray()));
+            last_value?.sanitize();
+            /// When settings are adjusted outside of the settings dialog, the vm should raise the <see cref="LadderVM.settings_invalidated"/> event.
+            /// In response to that event, 'needs_resync' is set to true. This causes 'last_value' to be refreshed when the next caller requests the latest settings
+            /// (i.e., an IObserver subscribing to the settings_source, or the settings-dialog viewmodel).
+            bool initialized = false, needs_resync = false;
+            LadderVM vm = null;
+            var settings_subject = new Subject<LadderSettings>();
+            var settings_source = Observable.Create<LadderSettings>(o => {
+               ensure_synced();
+               if (last_value != null)
+                  o.OnNext(last_value);
+               return settings_subject.Subscribe(s => {
+                  if (s != null)
+                     o.OnNext(s);
+               });
+            });
+            // vm
+            vm = LadderVM.create(_bus, model, LadderSettings.sanitize(last_value ?? _settings_hub.current.ladder), settings_source);
+            vm.settings_invalidated += on_settings_invalidated;
             vm.order_properties_vm.open_algo_popup_on_select = _ladder_conf.open_algo_popup_on_select;
             vm.order_properties_vm.use_algo_param_grid = _ladder_conf.use_algo_param_grid;
+            vm.request_settings_dialog += open_settings_dialog;
+            var settings_subscription = _settings_hub.subscribe_default_settings().Subscribe(on_user_settings);
+            vm.OnDisposed += disposing => {
+               Disposable.dispose(ref settings_subscription);
+               Disposable.dispose(ref active_settings_dialog);
+               Disposable.dispose(ref settings_subject);
+            };
+            // view
             var lv = new LadderView(vm);
             foreach (var kv in AlgoStudioModelUtils.get_dynamic_resources(vm.model.order_gateway.algo_model.ui_configuration))
                lv.Resources[kv.Key] = kv.Value;
             return lv;
+            // local methods
+            void on_settings_invalidated() =>
+               needs_resync = true;
+
+            void ensure_synced() {
+               if (!needs_resync)
+                  return;
+               var curr = vm.get_save_state();
+               if (settings_id == 0) {
+                  last_value = curr;
+               } else if (!curr.Equals(last_value)) {
+                  settings_id = 0;
+                  last_value = curr;
+               }
+               needs_resync = false;
+            }
+
+            void on_user_settings(UserSettings us) {
+               if (initialized) {
+                  ensure_synced();
+                  if (settings_id == 0) {
+                     // not on a profile, don't respond to default settings changes
+                     return;
+                  } else if (us.ladder_profiles.TryGetFirst(p => p.id == settings_id, out var profile)) {
+                     if (!last_value.Equals(vm.get_save_state())) {
+                        settings_id = 0;
+                     } else {
+                        settings_subject.OnNext(last_value = profile.value);
+                     }
+                  } else {
+                     // profile was deleted; keep the current settings and switch to the 'Local' profile.
+                     settings_id = 0;
+                  }
+               } else if (_settings_hub.initialized) {
+                  initialized = true;
+                  if (settings_id != 0) {
+                     if (us.ladder_profiles.TryGetFirst(p => p.id == settings_id, out var profile)) {
+                        last_value = profile.value;
+                     } else {
+                        settings_id = 0;
+                     }
+                  }
+                  if (settings_id == 0 && last_value == null) {
+                     foreach (var lp in _settings_hub.current.ladder_profiles) {
+                        // TODO: Use a kind of 'match priority' to resolve conflicts when the security is included in more than 1 profile's security criteria.
+                        // In the meantime, simply use the first match.
+                        if (lp.security_criteria.includes(md.security)) {
+                           last_value = lp.value;
+                           settings_id = lp.id;
+                           break;
+                        }
+                     }
+                     if (last_value == null)
+                        last_value = _settings_hub.current.ladder;
+                  }
+                  settings_subject.OnNext(last_value);
+               }
+            }
+
+            void open_settings_dialog() {
+               // dialog vm
+               var dialog_vm = new ProfiledShellSettingsDialogVM<LadderSettings, LadderSettingsVM, LadderSettingsProfile>(
+                  profile_service,
+                  us => us.ladder ?? LadderSettings.Default,
+                  s => {
+                     var svm = new LadderSettingsVM(model.order_gateway, vm.security);
+                     svm.load(s);
+                     return svm;
+                  },
+                  _ => _,
+                  vm.get_save_state(),
+                  UserSettings.FileExtensions.LADDER,
+                  settings_id);
+               dialog_vm.applied += apply;
+               // dialog
+               var dialog = new ShellSettingsDialog { DataContext = dialog_vm };
+               dialog_vm.SubscribeDisposed(title_source.OnDispatcher().Subscribe(t => dialog_vm.title = t));
+               dialog.Resources[ShellSettingsDialog.SecurityMapKey] = _securities;
+               dialog_vm.RequestClose += on_request_close;
+               dialog.Closed += on_closed;
+               Disposable.replace(ref active_settings_dialog, Disposable.Create(destroy_all));
+               dialog.move_to_mouse(-500, -500);
+               dialog.Show();
+               // local methods
+               void apply(SettingsProfile<LadderSettings> profile) {
+                  settings_id = profile.id;
+                  last_value = profile.value;
+                  settings_subject.OnNext(profile.value);
+               }
+               // idempotent
+               void destroy_all() {
+                  destroy_window();
+                  destroy_vm();
+               }
+               // idempotent
+               void destroy_window() {
+                  if (dialog == null) return;
+                  try {
+                     var temp = dialog;
+                     dialog = null;
+                     temp.Closed -= on_closed;
+                     temp.Close();
+                  } catch (Exception ex) {
+                     on_error("closing window", ex);
+                  }
+               }
+               // idempotent
+               void destroy_vm() {
+                  if (dialog_vm == null) return;
+                  try {
+                     var temp = dialog_vm;
+                     dialog_vm = null;
+                     temp.applied -= apply;
+                     temp.RequestClose -= on_request_close;
+                     temp.Dispose();
+                  } catch (Exception ex) {
+                     on_error("disposing vm", ex);
+                  }
+               }
+               void on_closed(object sender, EventArgs e) => destroy_all();
+               void on_request_close(object sender, EventArgs e) => destroy_all();
+               void on_error(string action_desc, Exception error) =>
+                  Log.Ui.warn($"LadderSettingsDialog error {action_desc}: {error}.");
+            }
          });
-         string thread = _ladder_conf.ladders_on_threads ? $"Ladder{id:00}" : "";
-         return ShellWindow.create(
+         return shell_window = ShellWindow.create(
             module, md.security.ToString(), _window_type, view,
-            (v,s) => save(_get_state(((LadderView)v).vm), s), 
-            icon: Icons.Ladder, 
-            thread_id: thread);
-         // if there are new props, make sure they are not null, invalid, etc.
-         LadderSettings sanitize_ladder_settings(LadderSettings s) {
-            // these MarketBreakLines are new settings props, ensure they are not null
-            if (s.bid_break_line == null)
-               s.bid_break_line = LadderSettings.Default.bid_break_line;
-            if (s.ask_break_line == null)
-               s.ask_break_line = LadderSettings.Default.ask_break_line;
-            if (s.mid_break_line == null)
-               s.mid_break_line = LadderSettings.Default.mid_break_line;
-            if (s.session_low_line == null)
-               s.session_low_line = LadderSettings.Default.session_low_line;
-            if (s.session_high_line == null)
-               s.session_high_line = LadderSettings.Default.session_high_line;
-            if (s.session_range_fill == null)
-               s.session_range_fill = LadderSettings.Default.session_range_fill;
-            if (s.volume_column == null)
-               s.volume_column = LadderSettings.Default.volume_column;
-            if (s.size_display == null)
-               s.size_display = MarketSizeDisplay.get_default();
-            if (s.size_display.normal == null)
-               s.size_display = s.size_display.with(MarketSizeDisplay.get_default().normal);
-            s.row_height = LadderRender.measure_row_height(s);
-            return s;
-         }
+            (v, s) => save(_get_state(((LadderView)v).vm, settings_id), s),
+            icon: Icons.Ladder,
+            thread_id: _thread_id_provider.next_id(),
+            vm => {
+               shell_window_vm = vm;
+               title_source.connect();
+            });
       }
 
       void show_windows(IReadOnlyCollection<SecurityMD> securities) {
@@ -125,27 +287,6 @@ namespace bts.shell {
          }
       }
 
-      // TODO: whenever we re-implement the linked ladder, need to add some field to the LadderSaveState to indicate the owning window
-      //void show_linked(IObservable<SecurityMD> keystream) {
-      //   var view = new LadderView();
-      //   IDisposable sub = null;
-      //   var window =
-      //      ShellWindow.create(module, "loading", view,
-      //      Disposable.Create(() => {
-      //         (view.DataContext as LadderVM)?.Dispose();
-      //         sub?.Dispose();
-      //      }), s => {
-      //         var vm = view.DataContext as LadderVM;
-      //         if (vm != null) save(_get_state(vm), s);
-      //      }, Icons.Ladder);
-      //   sub =
-      //      keystream
-      //      .Select(smd => new LadderVM(_bus, new LadderModel(smd, _orders_model),
-      //         Observable.Return(_orders_model.factory.default_ladder_settings(smd.security)))
-      //      ).Aggregate((old, vm) => { old.Dispose(); return vm; })
-      //      .Subscribe(vm => { view.DataContext = vm; window.Title = vm.security.ToString(); });
-      //}
-
       readonly struct LadderConfig {
          public readonly uint max_open_ladders;
          public readonly bool ladders_on_threads, open_algo_popup_on_select, use_algo_param_grid;
@@ -167,5 +308,7 @@ namespace bts.shell {
       public UInt32 security_key;
       [ProtoMember(2)]
       public mbts.spark.LadderSettings settings;
+      [ProtoMember(3)]
+      public uint settings_id;
    }
 }

src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs

@@ -1,5 +1,7 @@
 using bts.api;
 using bts.api.orderman;
+using bts.shell.orderbook;
+using mbts.persist;
 using mbts.ui;
 using mbts.ui.shell;
 using System;
@@ -33,7 +35,7 @@ namespace mbts.spark {
       readonly IBus _bus;
       readonly Property<FontFamily> _font_family;
       readonly Property<FontWeight> _font_weight;
-      readonly Property<double> _font_size;
+      readonly Property<double> _font_size, _grid_row_height;
       readonly Property<Brush> _foreground, _background, _hoverbackground, _border;
       readonly Property<bool> _has_multiple_orders_at_same_level, _is_hedge_order;
       readonly Property<CustomOrderDefinition.CustomOneofCase> _algo_type;
@@ -62,6 +64,7 @@ namespace mbts.spark {
          _font_weight = backing(nameof(font_weight), owner.settings, get_font_weight, get_font_weight(fs));
          _font_size = backing(nameof(font_size), owner.settings, get_font_size, get_font_size(fs));
          _foreground = backing(nameof(foreground), owner.settings, get_foreground, get_foreground(fs));
+         _grid_row_height = backing(nameof(grid_row_height), owner.settings, get_row_height, get_row_height(fs));
          _background = backing(nameof(background), _color_bg_brush);
          _hoverbackground = backing(nameof(hoverbackground), _color_bg_brush);
          _border = backing(nameof(border), _color_bg_brush);
@@ -73,6 +76,7 @@ namespace mbts.spark {
          FontWeight get_font_weight(LadderSettings s) => ui.utility.text.TextUtils.from_open_type_weight_safe(s.orders_column.font_weight);
          double get_font_size(LadderSettings s) => s.orders_column.font_size;
          Brush get_foreground(LadderSettings s) => s.orders_column.foreground.rgb_brush();
+         double get_row_height(LadderSettings s) => s.row_height;
          //
          add_order(op);
 
@@ -244,6 +248,7 @@ namespace mbts.spark {
       public FontFamily font_family => _font_family.Value;
       public FontWeight font_weight => _font_weight.Value;
       public double font_size => _font_size.Value;
+      public double grid_row_height => _grid_row_height.Value;
       public Brush foreground => _foreground.Value;
       public Brush background { get => _background.Value; private set => _background.Value = value; }
       public Brush hoverbackground { get => _hoverbackground.Value; private set => _hoverbackground.Value = value; }
@@ -292,50 +297,29 @@ namespace mbts.spark {
          price_filter.minimum.value = real_price;
          price_filter.maximum.value = real_price;
 
-         var obvm = new OrderBookVM(null, _owner.bus, null, _owner.model.order_gateway, null, true);
          var state = new bts.shell.orderbook.OrderBookStartupData(
             new bts.shell.orderbook.FilterStates {
                security_criteria = new SecurityCriteria(_owner.security),
                price = price_filter,
-               statuses = new[] { OrderStatus.Working }
+               statuses = new[] { OrderStatus.Working },
+               order_types = AlgoID.exchange_algo_keys
             },
-            bts.shell.orderbook.OrderBookStartupData.default_mini_grid,
+            bts.shell.orderbook.OrderBookStartupData.default_mini_grid.with(_owner.current_settings.mini_ob.value),
             use_defaults: false
          );
-         // NOTE:
-         // we might need the ObservableAppend to InsertAt
-         // if these EditXXX ever support settings.
-
-         // The end result after this group of lines will be
-         //  ----------------------------------------------
-         //  | Cancel | Update | Qty | Price | Commit | Attach | Detach | ...
-         //  ----------------------------------------------
-         //
+         var settings_man = new WindowSettingsManager<OrderBookGridSettings>.DisconnectedImpl(state.orderbook_grid);
+         var obvm = new OrderBookVM(_owner.bus, null, _owner.model.order_gateway, settings_man, true);
+         _owner.settings.Subscribe(s => settings_man.instance_settings = settings_man.instance_settings.with(s.mini_ob.value));
          obvm.columns.Insert(0, new OrderBookVM.AttachDetachColumn(typeof(MiniOrderBookView)));
          obvm.columns.Insert(0, new OrderBookVM.CommitColumn());
-         var price_col = obvm.columns.FirstOrDefault(x => x.id == OrderBookGridView.ColumnKeys.Price.ToString());
-         var price_index = obvm.columns.indexOf(price_col);
-         if (price_index > -1) {
-            var existing_editprice_col = obvm.columns.FirstOrDefault(x => x.id == OrderBookGridView.ColumnKeys.EditablePrice.ToString());
-            var existing_editprice_index = obvm.columns.indexOf(existing_editprice_col);
-            if (existing_editprice_index == -1) {
-               // insert the edit price column at the beginning
-               obvm.columns.Insert(0, new OrderBookVM.EditablePriceColumn());
-            }
-         }
-         var qty_col = obvm.columns.FirstOrDefault(x => x.id == OrderBookGridView.ColumnKeys.Size.ToString());
-         var qty_index = obvm.columns.indexOf(qty_col);
-         if (qty_index > -1) {
-            var existing_editqty_col = obvm.columns.FirstOrDefault(x => x.id == OrderBookGridView.ColumnKeys.EditableQty.ToString());
-            var existing_editqty_index = obvm.columns.indexOf(existing_editqty_col);
-            if (existing_editqty_index == -1) {
-               // insert the edit quantity column at the beginning
-               obvm.columns.Insert(0, new OrderBookVM.EditableQtyColumn());
-            }
-         }
+         obvm.columns.Insert(0, new OrderBookVM.EditablePriceColumn());
+         obvm.columns.Insert(0, new OrderBookVM.EditableQtyColumn());
          obvm.columns.Insert(0, new OrderBookVM.UpdateColumn(typeof(MiniOrderBookView)));
          obvm.columns.Insert(0, new OrderBookVM.CancelColumn(nameof(OrderBookRowVM.cancel_command)));
-
+         // the CheckColumn must be inserted at the front of the ObservableAppendCollection,
+         // and not mixed with the other columns in said ObservableAppendCollection's underlying ObservableCollection (the settings dialog uses the underlying collection).
+         // The user cannot adjust this column in the settings dialog, and it should always be the left-most column.
+         obvm.columns.insert_front(new OrderBookVM.CheckColumn(nameof(OrderBookRowVM.is_selected)));
          obvm.load_from(state);
          return obvm;
       }

src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs

@@ -1,5 +1,9 @@
-using bts.api;
+using bts;
+using bts.api;
+using bts.api.orderman;
 using bts.collections;
+using bts.persist.algo;
+using bts.shell.orderbook;
 using bts.utils;
 using mbts.collections;
 using mbts.ui;
@@ -8,10 +12,14 @@ using mbts.ui.controls.color_picker;
 using mbts.ui.shell;
 using mbts.ui.spark;
 using mbts.ui.utility;
+using mbts.utils;
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
+using System.Collections.Specialized;
+using System.ComponentModel;
 using System.Linq;
+using System.Reactive.Disposables;
 using System.Reactive.Linq;
 using System.Windows;
 using System.Windows.Input;
@@ -19,19 +27,30 @@ using System.Windows.Media;
 using TextUtils = mbts.ui.utility.text.TextUtils;
 
 namespace mbts.spark {
-   class LadderSettingsVM : ViewModelBase, IWindowSettingsVM<LadderSettings>, ITemplateSelectorKey, IDisposable {
+   class LadderSettingsVM : DisposableViewModelBase, IWindowSettingsVM<LadderSettings>, IValueFactory<LadderSettings>, IObservable<LadderSettings>, ITemplateSelectorKey {
       readonly Property<LadderSettings.BadgeStyle> _badge_style;
       readonly Property<uint> _alternate_order_size;
       readonly DelegateProperty<double> _row_height;
-      Func<double> _get_order_entry_panel_width, _get_zoom_factor;
+      readonly UserProperty<AccountTuple?> _default_account;
+      readonly UserProperty<AlgoDefinitionVM> _default_algo;
+      readonly DeferrableActionWrapper _update;
+      readonly ObservableKeyedCollection<AccountTuple?, uint> _accounts = new ObservableKeyedCollection<AccountTuple?, uint>(AccountTuple.nullable_key_fn);
+      readonly ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey> _algo_definitions = new ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey>(d => d.key);
+      readonly OrdersModel _model;
+      uint? _desired_account;
+      AlgoID? _desired_algo;
+      TimeInForce _default_time_in_force;
+      LadderSettings.NetChangeTerms _price_format;
+      double _order_entry_panel_width, _zoom_factor;
+      bool _auto_clear, _show_warn_on_cross;
       LadderSettings _current;
       LadderColumnSettingsVM
          _orders = new OrdersColumnSettingsVM(),
          _bid = new LadderColumnSettingsVM("Bid"),
          _price = new LadderColumnSettingsVM("Price"),
          _ask = new LadderColumnSettingsVM("Ask"),
-         _last = new LadderColumnSettingsVM("Last", true),
-         _piq = new LadderColumnSettingsVM("PIQ", true);
+         _last = new LadderColumnSettingsVM("Last", LadderSettingsView.LastColumnTemplateKey, true),
+         _piq = new LadderColumnSettingsVM("PIQ", can_toggle_show: true);
       VolumeColumnVM _volume = new VolumeColumnVM();
       LadderMarketBreakLineVM
          _bid_mkt_line = new LadderMarketBreakLineVM("Bid"),
@@ -53,31 +72,25 @@ namespace mbts.spark {
          _order_type_visibility = new OrderEntryPanelItemVisibilityVM("Order Type"),
          _account_position_visibility = new OrderEntryPanelItemVisibilityVM("Account Position"),
          _day_position_visibility = new OrderEntryPanelItemVisibilityVM("Day Position"),
+         _raw_day_position_visibility = new OrderEntryPanelItemVisibilityVM("Raw Day Position"),
          _size_preset_visibility = new OrderEntryPanelItemVisibilityVM("Size Presets"),
          _auto_clear_visibility = new OrderEntryPanelItemVisibilityVM("Auto Clear"),
          _clear_visibility = new OrderEntryPanelItemVisibilityVM("Clear"),
          _cancel_buys_visibility = new OrderEntryPanelItemVisibilityVM("Cancel Buys"),
          _cancel_sells_visibility = new OrderEntryPanelItemVisibilityVM("Cancel Sells"),
          _cancel_all_visibility = new OrderEntryPanelItemVisibilityVM("Cancel All");
-      readonly Property<bool> 
-         _show_in_net_change,
-         _show_in_net_change_dollars,
-         _show_in_net_change_ticks;
 
-      public LadderSettingsVM(OrdersModel model, bool is_synthetic, Func<double> get_left_panel_width, Func<double> get_zoom_factor) {
-         this.is_synthetic = is_synthetic;
-         favorite_algos_vm = new FavoriteAlgosVM(model);
+      public LadderSettingsVM(OrdersModel model, SecurityImmutable security) {
+         _model = model;
+         is_synthetic = security.ContractCase == Security.ContractOneofCase.Synthetic;
+         favorite_algos_vm = new FavoriteAlgosVM(_algo_definitions);
          size_presets = new ObservableEditableCollection<IMutableValueWrapperVM<uint>>(_create_size_preset_vm);
          size_presets.CollectionChanged += (s, e) => RaisePropertyChanged(nameof(size_presets_text));
          _badge_style = backing<LadderSettings.BadgeStyle>(nameof(badge_style));
          _badge_style.Changed += _badge_style_Changed;
          _alternate_order_size = backing<uint>(nameof(alternate_order_size));
-         _get_order_entry_panel_width = get_left_panel_width;
-         _get_zoom_factor = get_zoom_factor;
-         _show_in_net_change = backing<bool>(nameof(show_in_net_change));
-         _show_in_net_change_dollars = backing<bool>(nameof(show_in_net_change_dollars));
-         _show_in_net_change_ticks = backing<bool>(nameof(show_in_net_change_ticks));
-         
+         _default_account = user_backing<AccountTuple?>(nameof(default_account));
+         _default_algo = user_backing<AlgoDefinitionVM>(nameof(default_algo));
          // be sure to initialize backings before this measure_row_height call
          _row_height = backing(nameof(row_height), () => LadderRender.measure_row_height(get_result()));
          _orders.font_size_changed += on_font_size_changed;
@@ -86,10 +99,50 @@ namespace mbts.spark {
          _ask.font_size_changed += on_font_size_changed;
          _last.font_size_changed += on_font_size_changed;
          _piq.font_size_changed += on_font_size_changed;
-
+         // accounts
+         accounts_view = new ListCollectionView<AccountTuple?>(_accounts) {
+            CustomSort = Comparer<AccountTuple>.Default.to_nullable().to_non_generic()
+         };
+         // update
+         _update = new DeferrableActionWrapper(() => result_changed?.Invoke());
+         mini_ob.result_changed += _update.execute;
+         foreach (var c in _observable_components)
+            c.PropertyChanged += on_prop_changed;
+         favorite_algos_vm.items.CollectionChanged += on_favorite_algo_items_CollectionChanged;
+         _algo_definitions.AddRange(_model.factory.default_algos(security).Values.Select(algo_factory));
+         _dispose = new CompositeDisposable(
+            _model.factory.subscribe_accounts().OnDispatcher().Subscribe(acc_map => {
+               _accounts.SyncWithDictionary(MappedDictionary.create(acc_map, account_factory));
+               _try_select_desired_account();
+            }),
+            ObservableAutoWrapper.connect_item_hooks(favorite_algos_vm.items, connect_favorite_algo),
+            _model.algo_model.definitions.OnDispatcher().Subscribe(update => {
+               AlgoCollectionHelper.update_persisted_definitions(_algo_definitions, update, algo_factory);
+               _try_select_desired_algo();
+            })
+         ) { dispose_resources };
+         // local methods
          void on_font_size_changed(double oldval, double newval) => _row_height.refresh();
+         void on_prop_changed(object sender, PropertyChangedEventArgs e) => _update.execute();
+         void on_favorite_algo_items_CollectionChanged(object sender, NotifyCollectionChangedEventArgs e) => _update.execute();
+         IDisposable connect_favorite_algo(FavoriteAlgoItem item) {
+            item.PropertyChanged += on_prop_changed;
+            return Disposable.Create(() => item.PropertyChanged -= on_prop_changed);
+         }
+         void dispose_resources() {
+            mini_ob.result_changed -= _update.execute;
+            mini_ob.Dispose();
+            favorite_algos_vm.items.CollectionChanged -= on_favorite_algo_items_CollectionChanged;
+            favorite_algos_vm.Dispose();
+            foreach (var c in _observable_components)
+               c.PropertyChanged -= on_prop_changed;
+         }
+         AccountTuple? account_factory(uint key, string name) => new AccountTuple(key, name);
+         AlgoDefinitionVM algo_factory(AlgoData data) => AlgoDefinitionVM.create(_model, data, is_synthetic ? AlgoFormats.Spreader : AlgoFormats.Exchange);
       }
 
+      public event Action result_changed;
+
       private void _badge_style_Changed(LadderSettings.BadgeStyle oldval, LadderSettings.BadgeStyle newval) {
          if (newval == LadderSettings.BadgeStyle.Alternate && _orders.font_size == 10) {
             _orders.font_size = 7;
@@ -110,6 +163,27 @@ namespace mbts.spark {
       }
 
       public MarketSizeDisplayVM size_display { get; } = new MarketSizeDisplayVM();
+      public SimpleGridSettingsVM mini_ob { get; } = new SimpleGridSettingsVM(OrderBookGridSettingsManager.hard_column_flags);
+      // price format
+      public LadderSettings.NetChangeTerms price_format { get => _price_format; set => Set(ref _price_format, value); }
+      public IEnumerable<LadderSettings.NetChangeTerms> price_format_options => EnumHelper.get_values<LadderSettings.NetChangeTerms>();
+      // time in force
+      public TimeInForce default_time_in_force { get => _default_time_in_force; set => Set(ref _default_time_in_force, value); }
+      public IEnumerable<TimeInForce> time_in_force_options => EnumHelper.get_values_except(TimeInForce.Undefined);
+      // account
+      public AccountTuple? default_account { get => _default_account.Value; set => _default_account.Value = value; }
+      public ICollectionView<AccountTuple?> accounts_view { get; }
+      // algo
+      public AlgoDefinitionVM default_algo { get => _default_algo.Value; set => _default_algo.Value = value; }
+      public IReadOnlyObservableCollection<AlgoDefinitionVM> algo_definitions => _algo_definitions;
+      // left-panel (components)
+      public bool auto_clear { get => _auto_clear; set => Set(ref _auto_clear, value); }
+      public double order_entry_panel_width { get => _order_entry_panel_width; set => Set(ref _order_entry_panel_width, value); }
+      public double zoom_factor { get => _zoom_factor; set => Set(ref _zoom_factor, value); }
+      // safety checks
+      public bool show_warn_on_cross { get => _show_warn_on_cross; set => Set(ref _show_warn_on_cross, value); }
+
+      // favorites
       public FavoriteAlgosVM favorite_algos_vm { get; }
 
       public double row_height => _row_height.Value;
@@ -166,6 +240,7 @@ namespace mbts.spark {
             yield return _order_type_visibility;
             yield return _account_position_visibility;
             yield return _day_position_visibility;
+            yield return _raw_day_position_visibility;
             yield return _size_preset_visibility;
             yield return _clear_visibility;
             yield return _auto_clear_visibility;
@@ -175,88 +250,135 @@ namespace mbts.spark {
          }
       }
 
-      public bool show_in_net_change {
-         get => _show_in_net_change.Value;
-         set {
-            // when unchecking, clear out dollars and ticks
-            if (!value) {
-               show_in_net_change_dollars = false;
-               show_in_net_change_ticks = false;
-            }
-            // when checking, by defalt check dollars
-            if (value) {
-               show_in_net_change_dollars = true;
-            }
-            _show_in_net_change.Value = value;
-         }
-      }
-      public bool show_in_net_change_dollars {
-         get => _show_in_net_change_dollars.Value;
-         set => _show_in_net_change_dollars.Value = value;
-      }
-
-      public bool show_in_net_change_ticks {
-         get => _show_in_net_change_ticks.Value;
-         set => _show_in_net_change_ticks.Value = value;
-      }
-
-
       public string key => GridSettingsTemplateKeys.Ladder;
 
+      IEnumerable<INotifyPropertyChanged> _observable_components {
+         get {
+            // columns
+            yield return _orders;
+            yield return _bid;
+            yield return _price;
+            yield return _ask;
+            yield return _last;
+            yield return _piq;
+            yield return _volume;
+            yield return _volume.general;
+            // market break lines
+            yield return _bid_mkt_line;
+            yield return _ask_mkt_line;
+            yield return _mid_mkt_line;
+            yield return _session_low_mkt_line;
+            yield return _session_high_mkt_line;
+            yield return _session_range_fill;
+            // left panel
+            yield return _zoom_slider_visbility;
+            yield return _day_visibility;
+            yield return _high_visibility;
+            yield return _low_visibility;
+            yield return _open_visibility;
+            yield return _settle_visibility;
+            yield return _volume_visibility;
+            yield return _account_visibility;
+            yield return _tif_visibility;
+            yield return _order_type_visibility;
+            yield return _account_position_visibility;
+            yield return _day_position_visibility;
+            yield return _raw_day_position_visibility;
+            yield return _size_preset_visibility;
+            yield return _auto_clear_visibility;
+            yield return _clear_visibility;
+            yield return _cancel_buys_visibility;
+            yield return _cancel_sells_visibility;
+            yield return _cancel_all_visibility;
+            // other
+            yield return size_display;
+            yield return favorite_algos_vm;
+            yield return this;
+         }
+      }
+
       public void load(LadderSettings settings) {
-         _current = settings;
-         badge_style = settings.badge_style;
-         alternate_order_size = settings.alternate_order_size;
-         favorite_algos_vm.load_from(settings.favorite_algos);
-         size_display.load_from(settings.size_display);
-         size_presets.SetItems(settings.calculator_buttons.empty_if_null().Select(s => _create_size_preset_vm((uint)s)));
-         _orders.assign_from(_current.orders_column);
-         _bid.assign_from(_current.bid_column);
-         _ask.assign_from(_current.ask_column);
-         _price.assign_from(_current.price_column);
-         _volume.assign_from(_current.volume_column);
-         _last.assign_from(_current.last_column);
-         _piq.assign_from(_current.piq_column);
-         _bid_mkt_line.assign_from(_current.bid_break_line);
-         _ask_mkt_line.assign_from(_current.ask_break_line);
-         _mid_mkt_line.assign_from(_current.mid_break_line);
-         _session_low_mkt_line.assign_from(_current.session_low_line);
-         _session_high_mkt_line.assign_from(_current.session_high_line);
-         _session_range_fill.assign_from(_current.session_range_fill);
-         _zoom_slider_visbility.show = settings.zoom_slider_visible;
-         _day_visibility.show = settings.day_visible;
-         _high_visibility.show = settings.high_visible;
-         _low_visibility.show = settings.low_visible;
-         _open_visibility.show = settings.open_visible;
-         _settle_visibility.show = settings.settle_visible;
-         _volume_visibility.show = settings.volume_visible;
-         _account_visibility.show = settings.account_visible;
-         _tif_visibility.show = settings.tif_visible;
-         _order_type_visibility.show = settings.order_type_visible;
-         _account_position_visibility.show = settings.account_position_visible;
-         _day_position_visibility.show = settings.day_position_visible;
-         _size_preset_visibility.show = settings.size_presets_visible;
-         _clear_visibility.show = settings.clear_visible;
-         _auto_clear_visibility.show = settings.auto_clear_visible;
-         _cancel_buys_visibility.show = settings.cancel_buys_visible;
-         _cancel_sells_visibility.show = settings.cancel_sells_visible;
-         _cancel_all_visibility.show = settings.cancel_all_visible;
-         // do not read the order entry panel width here from settings
-         // because it could have changed from the UI
-         // there might be a better way of doing this, like how
-         // does the widths of the ladder grid column pull this off?
-         show_in_net_change = settings.net_change != LadderSettings.NetChangeTerms.None;
-         show_in_net_change_dollars = settings.net_change == LadderSettings.NetChangeTerms.Dollars;
-         show_in_net_change_ticks = settings.net_change == LadderSettings.NetChangeTerms.Ticks;
+         using (_update.defer_execution()) {
+            _current = settings;
+            badge_style = settings.badge_style;
+            alternate_order_size = settings.alternate_order_size;
+            favorite_algos_vm.load_from(settings.favorite_algos);
+            size_display.load_from(settings.size_display);
+            size_presets.SetItems(settings.calculator_buttons.empty_if_null().Select(s => _create_size_preset_vm((uint)s)));
+            mini_ob.load_from(settings.mini_ob.value);
+            // columns
+            _orders.assign_from(_current.orders_column);
+            _bid.assign_from(_current.bid_column);
+            _ask.assign_from(_current.ask_column);
+            _price.assign_from(_current.price_column);
+            _volume.assign_from(_current.volume_column);
+            _last.assign_from(_current.last_column);
+            _piq.assign_from(_current.piq_column);
+            // market break lines
+            _bid_mkt_line.assign_from(_current.bid_break_line);
+            _ask_mkt_line.assign_from(_current.ask_break_line);
+            _mid_mkt_line.assign_from(_current.mid_break_line);
+            _session_low_mkt_line.assign_from(_current.session_low_line);
+            _session_high_mkt_line.assign_from(_current.session_high_line);
+            _session_range_fill.assign_from(_current.session_range_fill);
+            // left-panel (defaults)
+            default_time_in_force = settings.default_time_in_force;
+            // - account
+            _desired_account = settings.default_account;
+            _try_select_desired_account(true);
+            // - algo
+            _desired_algo = settings.default_algo;
+            _try_select_desired_algo(true);
+            // - components
+            auto_clear = settings.auto_clear;
+            order_entry_panel_width = settings.order_entry_panel_initial_width;
+            zoom_factor = settings.zoom_factor;
+            // left-panel (show/hide)
+            _zoom_slider_visbility.show = settings.zoom_slider_visible;
+            _day_visibility.show = settings.day_visible;
+            _high_visibility.show = settings.high_visible;
+            _low_visibility.show = settings.low_visible;
+            _open_visibility.show = settings.open_visible;
+            _settle_visibility.show = settings.settle_visible;
+            _volume_visibility.show = settings.volume_visible;
+            _account_visibility.show = settings.account_visible;
+            _tif_visibility.show = settings.tif_visible;
+            _order_type_visibility.show = settings.order_type_visible;
+            _account_position_visibility.show = settings.account_position_visible;
+            _day_position_visibility.show = settings.day_position_visible;
+            _raw_day_position_visibility.show = settings.raw_day_position_visible;
+            _size_preset_visibility.show = settings.size_presets_visible;
+            _clear_visibility.show = settings.clear_visible;
+            _auto_clear_visibility.show = settings.auto_clear_visible;
+            _cancel_buys_visibility.show = settings.cancel_buys_visible;
+            _cancel_sells_visibility.show = settings.cancel_sells_visible;
+            _cancel_all_visibility.show = settings.cancel_all_visible;
+            price_format = settings.net_change;
+            // safety checks
+            show_warn_on_cross = settings.show_warn_on_cross;
+         }
       }
 
       public LadderSettings get_result() {
-         var clone = SparkUtils.clone_proto(_current);
+         LadderSettings clone;
+         if (_current == null) {
+            clone = new LadderSettings {
+               mini_ob = new LadderMiniOrderBookSettings(mini_ob.create())
+            };
+         } else {
+            clone = SparkUtils.clone_proto(_current);
+#pragma warning disable CS0612 // Type or member is obsolete
+            clone.mini_ob = new LadderMiniOrderBookSettings(_current.mini_ob.value != null ? 
+               mini_ob.create().with(sorting_criterion: _current.mini_ob.value.sorting_criterion) :
+               mini_ob.create());
+#pragma warning restore CS0612 // Type or member is obsolete
+         }
          clone.badge_style = badge_style;
          clone.alternate_order_size = alternate_order_size;
          clone.favorite_algos = favorite_algos_vm.create();
          clone.size_display = size_display.create();
          clone.calculator_buttons = size_presets.Select(vm => (int)vm.value).ToArray();
+         // columns, row height (the latter determined by columns font size)
          clone.orders_column = _orders.get_settings();
          clone.bid_column = _bid.get_settings();
          clone.price_column = _price.get_settings();
@@ -264,13 +386,28 @@ namespace mbts.spark {
          clone.volume_column = _volume.get_settings();
          clone.last_column = _last.get_settings();
          clone.piq_column = _piq.get_settings();
+         clone.row_height = LadderRender.measure_row_height(clone);
+         // market break lines
          clone.bid_break_line = _bid_mkt_line.get_settings();
          clone.ask_break_line = _ask_mkt_line.get_settings();
          clone.mid_break_line = _mid_mkt_line.get_settings();
          clone.session_low_line = _session_low_mkt_line.get_settings();
          clone.session_high_line = _session_high_mkt_line.get_settings();
          clone.session_range_fill = _session_range_fill.get_settings();
-         clone.row_height = LadderRender.measure_row_height(clone);
+         // left-panel (defaults)
+         clone.default_time_in_force = default_time_in_force;
+         // - account
+         if (default_account.HasValue)
+            clone.default_account = default_account.Value.id;
+         // - algo
+         clone.default_algo = default_algo != null ?
+            AlgoID.from_algo_key(default_algo.key) :
+            (_desired_algo ?? LadderSettings.Default.default_algo);
+         // - components
+         clone.auto_clear = auto_clear;
+         clone.order_entry_panel_initial_width = _order_entry_panel_width;
+         clone.zoom_factor = zoom_factor;
+         // left-panel (components)
          clone.day_visible = _day_visibility.show;
          clone.high_visible = _high_visibility.show;
          clone.low_visible = _low_visibility.show;
@@ -282,31 +419,30 @@ namespace mbts.spark {
          clone.order_type_visible = _order_type_visibility.show;
          clone.account_position_visible = _account_position_visibility.show;
          clone.day_position_visible = _day_position_visibility.show;
+         clone.raw_day_position_visible = _raw_day_position_visibility.show;
          clone.size_presets_visible = _size_preset_visibility.show;
          clone.auto_clear_visible = _auto_clear_visibility.show;
          clone.clear_visible = _clear_visibility.show;
          clone.cancel_buys_visible = _cancel_buys_visibility.show;
          clone.cancel_sells_visible = _cancel_sells_visibility.show;
          clone.cancel_all_visible = _cancel_all_visibility.show;
-         clone.order_entry_panel_initial_width = _get_order_entry_panel_width();
          clone.zoom_slider_visible = _zoom_slider_visbility.show;
-         clone.zoom_factor = _get_zoom_factor();
-         clone.net_change = _create_net_change_terms(show_in_net_change_dollars, show_in_net_change_ticks);
+         clone.net_change = price_format;
+         // safety checks
+         clone.show_warn_on_cross = show_warn_on_cross;
          return clone;
-
-         LadderSettings.NetChangeTerms _create_net_change_terms(bool dollars, bool ticks) {
-            if (dollars) {
-               return LadderSettings.NetChangeTerms.Dollars;
-            }
-            if (ticks) {
-               return LadderSettings.NetChangeTerms.Ticks;
-            }
-            return LadderSettings.NetChangeTerms.None;
-         }
-
       }
 
-      public void Dispose() => favorite_algos_vm.Dispose();
+      public IDisposable defer_updates() => _update.defer_execution();
+
+      IDisposable IObservable<LadderSettings>.Subscribe(IObserver<LadderSettings> observer) {
+         result_changed += notify;
+         return Disposable.Create(() => result_changed -= notify);
+         void notify() => observer.OnNext(get_result());
+      }
+
+      LadderSettings IValueFactory<LadderSettings>.create() => get_result();
+      void IValueFactory<LadderSettings>.load_from(LadderSettings value) => load(value);
 
       IMutableValueWrapperVM<uint> _create_size_preset_vm() => _create_size_preset_vm(0);
       IMutableValueWrapperVM<uint> _create_size_preset_vm(uint init) {
@@ -314,6 +450,20 @@ namespace mbts.spark {
          vm.PropertyChanged += (s, e) => RaisePropertyChanged(nameof(size_presets_text));
          return vm;
       }
+
+      void _try_select_desired_account(bool bypass_setter = false) {
+         if (_desired_account.HasValue && (!_default_account.setter_called || bypass_setter) && _accounts.TryGetValue(_desired_account.Value, out var acc_tup)) {
+            _desired_account = null;
+            _default_account.bypass_setter(acc_tup);
+         }
+      }
+
+      void _try_select_desired_algo(bool bypass_setter = false) {
+         if (_desired_algo.HasValue && (!_default_algo.setter_called || bypass_setter) && _algo_definitions.TryGetValue(AlgoID.to_algo_key(_desired_algo.Value), out var vm)) {
+            _desired_algo = null;
+            _default_algo.bypass_setter(vm);
+         }
+      }
  
       public class LadderColumnSettingsVM : ViewModelBase, ITemplateSelectorKey {
          readonly Property<double> _font_size;
@@ -323,11 +473,13 @@ namespace mbts.spark {
          readonly DelegateProperty<FontWeight> _font_weight;
          readonly DelegateProperty<string> _font_display_name;
          readonly Property<bool> _show;
-         readonly bool _can_toggle_visibility;
+         readonly string _template_key;
+         uint _width;
 
-         public LadderColumnSettingsVM(string name, bool can_toggle_visibility = false) {
+         public LadderColumnSettingsVM(string name, string template_key = null, bool can_toggle_show = false) {
             this.name = name;
-            _can_toggle_visibility = can_toggle_visibility;
+            _template_key = template_key;
+            this.can_toggle_show = can_toggle_show;
             foreground_palettes = new ObservableCollection<ColorPaletteVM>(ColorPalette.all_presets().Select(p => new ColorPaletteVM(p)));
             background_palettes = new ObservableCollection<ColorPaletteVM>(ColorPalette.all_presets().Select(p => new ColorPaletteVM(p)));
             _show = backing(nameof(show), true);
@@ -338,26 +490,35 @@ namespace mbts.spark {
             _foreground = backing(nameof(foreground), Colors.Black);
             _background = backing(nameof(background), Colors.White);
             _font_display_name = backing(nameof(font_display_name),
-               () => TextUtils.display_name(font_family, font_weight, font_size), nameof(font_family), nameof(font_weight), nameof(font_size));
+               () => TextUtils.display_name(font_family, font_weight, font_size), new[] { nameof(font_family), nameof(font_weight), nameof(font_size) });
             _font_size.Changed += (oldval, newval) => font_size_changed?.Invoke(oldval, newval);
+            toggle_show_details_cmd = new DelegateCommand(() => {
+               show_details = !show_details;
+               RaisePropertyChanged(nameof(show_details));
+            });
          }
 
+         public event Action<double, double> font_size_changed;
+
          public string name { get; }
          public Typeface typeface { get => _typeface.Value; set => _typeface.Value = value; }
          public FontFamily font_family => _font_family.Value;
          public FontWeight font_weight => _font_weight.Value;
          public string font_display_name => _font_display_name.Value;
          public double font_size { get => _font_size.Value; set => _font_size.Value = value; }
-         public uint width { get; set; }
+         public uint width { get => _width; set => Set(ref _width, value); }
          public bool show { get => _show.Value; set => _show.Value = value; }
+         public bool can_toggle_show { get; }
+         public bool show_details { get; private set; }
          public Color foreground { get => _foreground.Value; set => _foreground.Value = value; }
          public Color background { get => _background.Value; set => _background.Value = value; }
          public ObservableCollection<ColorPaletteVM> foreground_palettes { get; }
          public ObservableCollection<ColorPaletteVM> background_palettes { get; }
-         public event Action<double, double> font_size_changed;
-
          public virtual string sample_text => "999-56789.01234";
-         string ITemplateSelectorKey.key => _can_toggle_visibility ? ui.spark.LadderSettingsView.ColumnVisibilityToggleTemplateKey : null;
+
+         public ICommand toggle_show_details_cmd { get; }
+
+         string ITemplateSelectorKey.key => _template_key;
 
          public void assign_from(LadderColumnSettings settings) {
             typeface = new Typeface(
@@ -370,7 +531,6 @@ namespace mbts.spark {
             show = settings.show;
             foreground = settings.foreground.rgb_color();
             background = settings.background.rgb_color();
-            RaisePropertyChanged(nameof(width), nameof(show));
          }
 
          public LadderColumnSettings get_settings() {
@@ -395,7 +555,7 @@ namespace mbts.spark {
          public Brush badge_border { get; } = new SolidColorBrush(BTSColors.MarketData.ask);
          public Brush badge_background { get; } = Brushes.White;
 
-         string ITemplateSelectorKey.key => ui.spark.LadderSettingsView.OrdersColumnSampleTemplateKey;
+         string ITemplateSelectorKey.key => ui.spark.LadderSettingsView.OrdersColumnTemplateKey;
       }
 
       public class LadderMarketBreakLineVM : ViewModelBase {
@@ -463,7 +623,7 @@ namespace mbts.spark {
             }
          }
 
-         public LadderColumnSettingsVM general { get; } = new LadderColumnSettingsVM("Volume", true);
+         public LadderColumnSettingsVM general { get; } = new LadderColumnSettingsVM("Volume", LadderSettingsView.VolumeColumnTemplateKey, true);
          public VolumeAtPriceAnimationVM buy { get; }
          public VolumeAtPriceAnimationVM sell { get; }
          public VolumeAtPriceAnimationVM passive { get; }
@@ -566,17 +726,18 @@ namespace mbts.spark {
       }
 
       public class FavoriteAlgosVM : DisposableViewModelBase, IValueFactoryVM<LadderFavoriteAlgosSettings> {
-         readonly ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey> _algo_definitions = new ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey>(d => d.key);
+         readonly IObservableCollection<AlgoDefinitionVM> _algo_definitions;
          readonly ObservableCollection<FavoriteAlgoItem> _raw_items = new ObservableCollection<FavoriteAlgoItem>();
          int _column_count = 2;
+         HashSet<AlgoPersistedKey> _sticky_algo_keys;
+         IDisposable _sticky_algos_hook;
 
-         public FavoriteAlgosVM(OrdersModel model) {
+         public FavoriteAlgosVM(IObservableCollection<AlgoDefinitionVM> algo_definitions) {
+            _algo_definitions = algo_definitions;
             items = new ObservableAggregateCollection<FavoriteAlgoItem>(_raw_items, new ObservableCollection<FavoriteAlgoItem> { FavoriteAlgoItem.AddButtonPlaceholderItem });
             add_item_cmd = new DelegateCommand(() => _raw_items.Add(_item_factory()));
             remove_item_cmd = new DelegateCommand<FavoriteAlgoItem>(fai => _raw_items.Remove(fai));
-            _dispose = model.algo_model.definitions.OnDispatcher().Subscribe(update => {
-               AlgoCollectionHelper.update_persisted_definitions(_algo_definitions, update, d => AlgoDefinitionVM.create(model, d, false));
-            });
+            _dispose = Disposable.Create(() => Disposable.dispose(ref _sticky_algos_hook));
          }
 
          public ObservableCollection<FavoriteAlgoItem> items { get; }
@@ -593,14 +754,37 @@ namespace mbts.spark {
                fai.selector.try_select(k);
                return fai;
             }));
+            _sticky_algo_keys = new HashSet<AlgoPersistedKey>(value.stickied_algos.Where(k => k.is_persisted).Select(x => new AlgoPersistedKey(x.persisted)));
+            Disposable.replace(ref _sticky_algos_hook,
+               ObservableAutoWrapper.connect_item_hooks(_raw_items, x =>
+                  x.selector.subscribe_value().Subscribe(algo => {
+                     if (algo != null &&
+                        algo.key.is_persisted &&
+                        (x.is_sticky = _sticky_algo_keys.Remove(new AlgoPersistedKey(algo.key.persisted))) &&
+                        _sticky_algo_keys.Count == 0)
+                        //
+                        Disposable.dispose(ref _sticky_algos_hook);
+                  })));
          }
 
          public LadderFavoriteAlgosSettings create() =>
-            new LadderFavoriteAlgosSettings(_raw_items.Where(fai => fai.algo_definition != null).Select(fai => fai.algo_definition.key).ToArray(), column_count);
+            new LadderFavoriteAlgosSettings(_raw_items
+               .Select(fai => fai.algo_definition?.key ?? fai.selector.desired_key)
+               .Where(k => k.HasValue && k.Value.is_persisted)
+               .Select(k => k.Value)
+               .ToArray(),
+               column_count,
+               _raw_items
+               .Where(fai => fai.is_sticky)
+               .Select(fai => fai.algo_definition?.key ?? fai.selector.desired_key)
+               .Where(k => k.HasValue && k.Value.is_persisted)
+               .Select(k => k.Value)
+               .ToArray());
 
          FavoriteAlgoItem _item_factory() =>
             new FavoriteAlgoItem(_algo_definitions, new ListCollectionView<AlgoDefinitionVM>(_algo_definitions) {
-               CustomSort = AlgoCollectionHelper.algo_definition_vm_comparer.to_non_generic()
+               CustomSort = AlgoCollectionHelper.algo_definition_vm_comparer.to_non_generic(),
+               Filter = obj => obj is AlgoDefinitionVM vm && vm.key.is_persisted
             });
       }
 
@@ -608,20 +792,22 @@ namespace mbts.spark {
          public static readonly FavoriteAlgoItem AddButtonPlaceholderItem = new _AddButtonPlaceholderItem();
 
          internal readonly KeyedItemSelector<AlgoDefinitionVM, AlgoKey> selector;
+         bool _is_sticky;
 
          protected FavoriteAlgoItem() { }
 
-         public FavoriteAlgoItem(ObservableKeyedCollection<AlgoDefinitionVM, AlgoKey> algo_definitions, ICollectionView<AlgoDefinitionVM> algo_definitions_view) {
+         public FavoriteAlgoItem(IObservableCollection<AlgoDefinitionVM> algo_definitions, ICollectionView<AlgoDefinitionVM> algo_definitions_view) {
             selector = new KeyedItemSelector<AlgoDefinitionVM, AlgoKey>(this, nameof(algo_definition), algo_definitions, d => d.key);
             this.algo_definitions_view = algo_definitions_view;
          }
 
          public ICollectionView<AlgoDefinitionVM> algo_definitions_view { get; }
          public AlgoDefinitionVM algo_definition { get => selector.value; set => selector.value = value; }
+         public bool is_sticky { get => _is_sticky; set => Set(ref _is_sticky, value); }
 
          class _AddButtonPlaceholderItem : FavoriteAlgoItem, ITemplateSelectorKey {
             public string key => LadderSettingsView.FavoriteAlgoAddButtonTemplateKey;
          }
       }
    }
-} 
+} 

src/client/spark/Modules/Trading/Ladder/VM/LadderVM.cs

@@ -1,13 +1,13 @@
-using bts.api;
+using bts.api;
 using bts.api.orderman;
+using bts.collections;
 using bts.shell;
 using bts.spark;
 using bts.utils;
 using mbts.co2;
-using mbts.persist;
+using mbts.spark.utilities;
 using mbts.ui;
 using mbts.ui.shell;
-using mbts.ui.utility;
 using mbts.utils;
 using System;
 using System.Collections.Generic;
@@ -34,34 +34,31 @@ namespace mbts.spark {
          _show_tif, _show_order_type, _show_size_preset, _show_auto_clear, _show_clear, _show_cancel_buys,
          _show_cancel_sells, _show_cancel_all, _show_zoom;
       readonly PropertyAutoWrapper<LadderSettings, Brush> _bid_background, _bid_foreground, _ask_background, _ask_foreground;
-      double _position, _day_position;
-      bool _show_account_position, _show_day_position;
-      IWindowSettingsManager<LadderSettings> _settings_manager;
+      readonly HashSet<AlgoKey> _sticky_algos = new HashSet<AlgoKey>();
+      double _position, _day_position, _raw_day_position;
+      bool _show_account_position, _show_day_position, _show_raw_day_position;
       ulong _misc_time = 0;
       ulong _last_trade_time = 0;
       IEqualityComparer<double> _equality;
       Dictionary<double, LadderOrderVM> _slot_price_vs_orders;
       IReadOnlyDictionary<uint, OrderSecurity> _cache = DictionaryHelper.empty<uint, OrderSecurity>();
 
-      public static LadderVM create(IBus bus, LadderModel model, IWindowSettingsManager<LadderSettings> settings_manager, LadderSettings init) {
-         var non_shared_wsm = settings_manager.as_non_shared();
-         return new LadderVM(bus, model, settings_manager, non_shared_wsm, init, new OrderPropertiesEditorVM(model.order_gateway, Observable.Return(model.security_md), settings_manager.subscribe_current().Select(s => new InlineOrderProperties(model.order_gateway, s))));
-      }
+      public static LadderVM create(IBus bus, LadderModel model, LadderSettings init, IObservable<LadderSettings> settings) =>
+         new LadderVM(bus, model, init, settings, new OrderPropertiesEditorVM(model.order_gateway, Observable.Return(model.security_md), settings.Select(s => new InlineOrderProperties(model.order_gateway, s))));
 
-      public static LadderVM create_readonly(IBus bus, LadderModel model) {
-         var default_settings = LadderSettings.Default;
-         return create_readonly(bus, model, new WindowSettingsManager<LadderSettings>.DisconnectedImpl(default_settings), default_settings);
-      }
+      public static LadderVM create_readonly(IBus bus, LadderModel model, IObservable<LadderSettings> settings) =>
+         create_readonly(bus, model, LadderSettings.Default, settings);
 
-      public static LadderVM create_readonly(IBus bus, LadderModel model, IWindowSettingsManager<LadderSettings> settings_manager, LadderSettings init) =>
-         new LadderVM(bus, model, settings_manager, settings_manager.as_non_shared(), init);
+      public static LadderVM create_readonly(IBus bus, LadderModel model, LadderSettings init, IObservable<LadderSettings> settings) =>
+         new LadderVM(bus, model, init, settings);
 
-      LadderVM(IBus bus, LadderModel model, IWindowSettingsManager<LadderSettings> settings_manager, IWindowSettingsManagerNonShared<LadderSettings> non_shared_wsm, LadderSettings init, OrderPropertiesEditorVM order_properties_vm = null) {
+      LadderVM(IBus bus, LadderModel model, LadderSettings init, IObservable<LadderSettings> settings, OrderPropertiesEditorVM order_properties_vm = null) {
          _bus = bus;
          _model = model;
+         current_settings = init;
+         this.settings = settings;
          _equality = TickUtils.tick_equality_comparer(_model.security.ContractSpec);
          _slot_price_vs_orders = new Dictionary<double, LadderOrderVM>(_equality);
-         _settings_manager = non_shared_wsm;
          this.order_properties_vm = order_properties_vm;
          _high = backing(nameof(high), double.NaN);
          _low = backing(nameof(low), double.NaN);
@@ -81,12 +78,14 @@ namespace mbts.spark {
          _zoom_factor = backing(nameof(zoom_factor), ws.zoom_factor);
          // remember: account_positions needs to subscribe to selected_account; both the sub and account_positions need to be disposed
          _volume = backing(nameof(volume), 0ul);
-         _auto_clear = backing(nameof(auto_clear), false);
+         _auto_clear = backing(nameof(auto_clear), init.auto_clear);
          _status = backing(nameof(status_message), "");
          _status_brush = backing(nameof(status_background), _transparent_status_brush);
          // All settings observers should be aggregated together, so they can all share the same subscription to the settings
          // (these subscriptions are not horribly expensive, but they're not free either - even more so with the .OnDispatcher() extension).
          var settings_observer = new CompositeObserver<LadderSettings> {
+            /// first things first: assign our <see cref="current_settings"/>
+            (s => current_settings = s),
             // brush props
             (_bid_background = brush_prop(nameof(bid_background), s => s.bid_column.background)).set,
             (_bid_foreground = brush_prop(nameof(bid_foreground), s => s.bid_column.foreground)).set,
@@ -110,9 +109,25 @@ namespace mbts.spark {
             (_show_cancel_all = bool_prop(nameof(show_cancel_all), s => s.cancel_all_visible)).set,
             (_show_zoom = bool_prop(nameof(show_zoom), s => s.zoom_slider_visible)).set,
             s => {
-               if (Set(ref _show_account_position, s.account_position_visible, nameof(show_account_position)) | Set(ref _show_day_position, s.day_position_visible, nameof(show_day_position))) {
+               if (
+                  Set(ref _show_account_position, s.account_position_visible, nameof(show_account_position)) |
+                  Set(ref _show_day_position, s.day_position_visible, nameof(show_day_position)) |
+                  Set(ref _show_raw_day_position, s.raw_day_position_visible, nameof(show_raw_day_position))) {
                   RaisePropertyChanged(nameof(position_display_text));
                }
+               size_calculator.buttons = s.calculator_buttons;
+               _auto_clear.set(s.auto_clear);
+               // column widths
+               _orders_column_width.set(s.orders_column.width);
+               _bid_column_width.set(s.bid_column.width);
+               _price_column_width.set(s.price_column.width);
+               _ask_column_width.set(s.ask_column.width);
+               _last_column_width.set(s.last_column.width);
+               _piq_column_width.set(s.piq_column.width);
+               _volume_column_width.set(s.volume_column.general.width);
+               // left panel/zoom
+               _left_panel_width.set(s.order_entry_panel_initial_width);
+               _zoom_factor.set(s.zoom_factor);
             }
          };
          PropertyAutoWrapper<LadderSettings, bool> bool_prop(string name, Func<LadderSettings, bool> get_bool) =>
@@ -123,35 +138,18 @@ namespace mbts.spark {
          //
          //_window_height = backing(nameof(window_height), settings_manager.subscribe_current().OnDispatcher().Select(s => s.zoom_factor), (scale) => scale * 600);
          //_window_width = backing(nameof(window_width), settings_manager.subscribe_current().OnDispatcher().Select(s => s.zoom_factor), (scale) => scale * 420);
-         position_click_command = new DelegateCommand(() => size_calculator.value = DoubleHelper.safe_convert_to_uint(Math.Abs(_show_day_position ? day_position : position)));
-         send_order_command = new DelegateCommand<(double price, Side? side, MouseButton button)>(send_order);
+         position_click_command = new DelegateCommand(() => size_calculator.value = DoubleHelper.safe_convert_to_uint(Math.Abs(_show_day_position ? day_position : (_show_raw_day_position ? _raw_day_position : position))));
+         send_order_command = new AsyncCommand<(double price, Side? side, MouseButton button)>(send_order_async);
          cancel_command = new AsyncCommand<LadderModel.CancelType>(_model.cancel_orders, true);
          show_book_command = new DelegateCommand(_show_book);
          show_ticket_command = new DelegateCommand(_show_ticket);
-         settings_command = new DialogCommand(() => {
-            var vm = new WindowSettingsDialogVM<LadderSettings, LadderSettingsVM>(
-               settings_manager, s => s.ladder, UserSettings.FileExtensions.LADDER,
-               s => {
-                  var svm = new LadderSettingsVM(model.order_gateway, security.ContractCase == Security.ContractOneofCase.Synthetic, () => left_panel_width, () => zoom_factor);
-                  svm.load(s);
-                  return svm;
-               }, s => s.with_window_specifics(get_save_state().get_window_specifics()));
-            var dialog = new ui.spark.SimpleGridSettingsDialog {
-               DataContext = vm,
-               Title = $"Ladder Settings - '{security}'"
-            };
-            vm.RequestClose += (s, e) => WindowUtilities.force_close(dialog);
-            return dialog;
-         }, -500, -500);
+         settings_command = new DelegateCommand(() => request_settings_dialog?.Invoke());
 
          orders = new ObservableCollection<LadderOrderVM>();
 
          _dispose = Disposable.Create(
-            settings_manager.subscribe_current().OnDispatcher().Subscribe(settings_observer),
-            settings_command,
-            non_shared_wsm,
+            settings.OnDispatcher().Subscribe(settings_observer),
             get_order_properties_editor_hooks(),
-            size_calculator = new CalculatorLogic(0, _settings_manager.subscribe_current().Select(s => s.calculator_buttons)),
             bus.subscribe(SparkTags.LogActivity).OnDispatcher().Subscribe(status_update),
             // we need to hook this up to model.orders which is filtered for just the security
             model.orders.OnDispatcher().Subscribe(working => {
@@ -176,7 +174,7 @@ namespace mbts.spark {
                   if (_slot_price_vs_orders.TryGetValue(slot_price_target, out LadderOrderVM slot_vm)) {
                      slot_vm.add_order((wo, os.piq, os.algo, os.meta));
                   } else {
-                     slot_vm = new LadderOrderVM((wo, os.piq, os.algo, os.meta), slot_price_target, this, _bus, _settings_manager.subscribe_current().Select(s => s.badge_style));
+                     slot_vm = new LadderOrderVM((wo, os.piq, os.algo, os.meta), slot_price_target, this, _bus, settings.Select(s => s.badge_style).OnDispatcher());
                      _slot_price_vs_orders[slot_price_target] = slot_vm;
                   }
 
@@ -231,26 +229,33 @@ namespace mbts.spark {
                .SelectManyInSeries(a => _model.order_gateway.on_security_positions(security.Id)
                   .Select(table => table.state.Values.FirstOrDefault(pos => pos.Item2.Account == a, tup => tup.Item2, (bts.api.position.PositionUnitImmutable?)null)));
             return Disposable.Create(
-               settings.OnDispatcher().Subscribe(s => order_properties_vm.on_favorite_algos(s.favorite_algos)),
+               settings.OnDispatcher().Subscribe(s => {
+                  _sticky_algos.SetItems(s.favorite_algos.stickied_algos);
+                  order_properties_vm.on_favorite_algos(s.favorite_algos);
+               }),
                order_properties_vm,
                position_src.OnDispatcher().Subscribe(pos => {
-                  double total, day;
+                  double total, day, raw_day;
                   if (pos.HasValue) {
                      total = pos.Value.total_pos();
                      day = pos.Value.day_pos();
+                     raw_day = pos.Value.raw_day_pos();
                   } else {
-                     total = day = double.NaN;
+                     total = day = raw_day = double.NaN;
                   }
-                  if ((Set(ref _position, total, nameof(position)) | Set(ref _day_position, day, nameof(day_position))) && (show_day_position || show_account_position))
+                  if ((
+                        Set(ref _position, total, nameof(position)) |
+                        Set(ref _day_position, day, nameof(day_position)) |
+                        Set(ref _raw_day_position, raw_day, nameof(raw_day_position))
+                     ) && (show_day_position || show_account_position || show_raw_day_position))
                      RaisePropertyChanged(nameof(position_display_text));
-               }),
-               position_src.Connect());
+               }));
          }
       }
 
       public IBus bus => _bus;
 
-      public event Action on_tick;
+      public event Action on_tick, request_settings_dialog, settings_invalidated;
 
       public MDConsumerHandle md => _model.md;
       // we return only entries who have piqs and whose piqs are not uint.Max
@@ -285,6 +290,7 @@ namespace mbts.spark {
          remove => _on_disposed_impl -= value;
       }
       public SecurityImmutable security => _model.security;
+      public LadderSettings current_settings { get; private set; }
       public double high => _high.Value;
       public double low => _low.Value;
       public double change => _change.Value;
@@ -292,9 +298,10 @@ namespace mbts.spark {
       public double settlement => _settlement.Value;
       public double position => _position;
       public double day_position => _day_position;
+      public double raw_day_position => _raw_day_position;
       public ulong volume => _volume.Value;
       public bool auto_clear { get => _auto_clear.Value; set => _auto_clear.set(value); }
-      public CalculatorLogic size_calculator { get; }
+      public CalculatorLogic size_calculator { get; } = new CalculatorLogic(0);
       /// Important: <see cref="order_properties_vm"/> can be null.
       public OrderPropertiesEditorVM order_properties_vm { get; }
       public ObservableCollection<LadderOrderVM> orders { get; }
@@ -302,11 +309,11 @@ namespace mbts.spark {
       public ICommand send_order_command { get; }
       public ICommand show_book_command { get; }
       public ICommand show_ticket_command { get; }
+      public ICommand settings_command { get; }
       public Brush bid_background => _bid_background.view;
       public Brush bid_foreground => _bid_foreground.view;
       public Brush ask_background => _ask_background.view;
       public Brush ask_foreground => _ask_foreground.view;
-      public DialogCommand settings_command { get; }
       public bool show_day => _show_day.view;
       public bool show_high => _show_high.view;
       public bool show_low => _show_low.view;
@@ -318,6 +325,7 @@ namespace mbts.spark {
       public bool show_order_type => _show_order_type.view;
       public bool show_account_position => _show_account_position;
       public bool show_day_position => _show_day_position;
+      public bool show_raw_day_position => _show_raw_day_position;
       public bool show_size_preset => _show_size_preset.view;
       public bool show_auto_clear => _show_auto_clear.view;
       public bool show_clear => _show_clear.view;
@@ -329,12 +337,18 @@ namespace mbts.spark {
       public double zoom_factor { get => _zoom_factor.Value; set => _zoom_factor.set(value); }
       public string position_display_text {
          get {
-            if (show_day_position) {
-               string day_pos_text = SparkUtils.fmt_position(day_position);
-               return show_account_position ? $"{day_pos_text} ({SparkUtils.fmt_position(position)})" : day_pos_text;
-            } else if (show_account_position) {
-               return SparkUtils.fmt_position(position);
-            } else return string.Empty;
+            string rv = null;
+            if (show_day_position)
+               rv = SparkUtils.fmt_position(day_position);
+            if (show_raw_day_position) {
+               var raw_day_text = SparkUtils.fmt_position(raw_day_position);
+               rv = rv == null ? raw_day_text : $"{rv} / {raw_day_text}";
+            }
+            if (show_account_position) {
+               var acc_text = SparkUtils.fmt_position(position);
+               rv = rv == null ? SparkUtils.fmt_position(position) : $"{rv} ({acc_text})";
+            }
+            return rv ?? "";
          }
       }
       //public double window_height { get => _window_height.Value; set => _window_height.set(value); }
@@ -346,8 +360,10 @@ namespace mbts.spark {
       public uint last_column_width { get => _last_column_width.Value; set => _last_column_width.set(value); }
       public uint piq_column_width { get => _piq_column_width.Value; set => _piq_column_width.set(value); }
       public uint volume_column_width { get => _volume_column_width.Value; set => _volume_column_width.set(value); }
+      public uint alternate_order_size_from_settings => current_settings.alternate_order_size;
+      public bool show_warn_on_cross_from_settings => current_settings.show_warn_on_cross;
       internal LadderModel model => _model;
-      internal IObservable<LadderSettings> settings => _settings_manager.subscribe_current();
+      internal IObservable<LadderSettings> settings { get; }
       internal OrderRecordImmutable get_root_at_price((OrderRecordImmutable order, uint? _, AlgoData? __, AlgoDefinitionMetadata? meta) op) {
          var order = op.order;
          double p = order.price();
@@ -366,10 +382,26 @@ namespace mbts.spark {
       }
 
       public LadderSettings get_save_state() {
-         var state = _settings_manager.current_settings();
-         state = state.with_window_specifics(new LadderSettings.WindowSpecifics(left_panel_width, orders_column_width, bid_column_width, price_column_width, ask_column_width, last_column_width, volume_column_width, zoom_factor, piq_column_width));
-         state.use_defaults = _settings_manager.instance_settings == null;
-         return state;
+         var rv = current_settings.with_window_specifics(
+            new LadderSettings.WindowSpecifics(
+               left_panel_width,
+               orders_column_width,
+               bid_column_width,
+               price_column_width,
+               ask_column_width,
+               last_column_width,
+               volume_column_width,
+               zoom_factor,
+               piq_column_width));
+         rv.auto_clear = auto_clear;
+         if (order_properties_vm != null) {
+            rv.default_time_in_force = order_properties_vm.selected_time_in_force;
+            if (order_properties_vm.selected_account.HasValue)
+               rv.default_account = order_properties_vm.selected_account.Value.id;
+            if (order_properties_vm.selected_algo_definition != null)
+               rv.default_algo = AlgoID.from_algo_key(order_properties_vm.selected_algo_definition.key);
+         }
+         return rv;
       }
 
       public void key_down(KeyEventArgs e) {
@@ -384,22 +416,25 @@ namespace mbts.spark {
          }
       }
 
-      public void send_order((double price, Side? side, MouseButton buton) args) {
-         if (args.buton == MouseButton.Middle) return;
-         var size_from_alternate = args.buton == MouseButton.Right;
-         if (order_properties_vm == null)
-            return;
-         var s = _settings_manager.current_settings();
-         if (DoubleHelper.IsNaNOrInfinity(args.price) || !args.side.HasValue || HasErrors || order_properties_vm.HasErrors || (size_from_alternate && s.alternate_order_size == 0)) {
-            return;
-         }
-         if (!size_from_alternate && (!size_calculator.value.HasValue || size_calculator.value.Value == 0)) {
-            size_calculator.flash_error();
-         }
-         else {
-            uint size = size_from_alternate ? s.alternate_order_size : (uint)Math.Abs(size_calculator.value ?? 0);
-            send_order_async(args.side.Value, size, args.price).ignore();
+      public void on_mini_orderbook_closed(bts.shell.orderbook.OrderBookStartupData ob_state) {
+         current_settings = SparkUtils.clone_proto(current_settings);
+         current_settings.mini_ob = new LadderMiniOrderBookSettings(ob_state.orderbook_grid.general);
+         settings_invalidated?.Invoke();
+      }
+
+      public Task send_order_async((double price, Side? side, MouseButton button) args) {
+         if (order_properties_vm != null && args.button != MouseButton.Middle) {
+            var size_from_alternate = args.button == MouseButton.Right;
+            if (!DoubleHelper.IsNaNOrInfinity(args.price) && args.side.HasValue && !HasErrors && !order_properties_vm.HasErrors && (!size_from_alternate || current_settings.alternate_order_size > 0)) {
+               if (!size_from_alternate && (!size_calculator.value.HasValue || size_calculator.value.Value == 0)) {
+                  size_calculator.flash_error();
+               } else {
+                  uint size = size_from_alternate ? current_settings.alternate_order_size : (uint)Math.Abs(size_calculator.value ?? 0);
+                  return send_order_async(args.side.Value, size, args.price);
+               }
+            }
          }
+         return Task.CompletedTask;
       }
 
       public async Task send_order_async(Side side, uint size, double price) {
@@ -416,9 +451,16 @@ namespace mbts.spark {
                price = temp_price;
             }
          }
-         await _model.order_gateway.send_order(order, price, size);
+         await _model.order_gateway.send_order(security, order, price, size);
          if (auto_clear)
             size_calculator.value = 0;
+         var fav_algo = order_properties_vm.selected_favorite_algo_definition;
+         if (fav_algo != null && !_sticky_algos.Contains(fav_algo.key) && !order_properties_vm.try_pop_selected_algo_definition()) {
+            var key = new AlgoKey(OrderDataHelper.get_default_algo(OrderDataHelper.get_algo_format(security.ContractCase)));
+            if (order_properties_vm.try_get_algo_definition(key, out var r)) {
+               order_properties_vm.selected_algo_definition = r;
+            }
+         }
       }
 
       void _update_header() {

src/client/spark/Modules/Trading/Ladder/VM/LadderVMContainer.cs

@@ -0,0 +1,58 @@
+using bts.api;
+using bts.api.orderman;
+using mbts.ui.shell;
+using System;
+using System.Collections.Generic;
+using System.Reactive.Linq;
+
+namespace mbts.spark {
+   class LadderVMContainer : ViewModelBase, IDisposable {
+      readonly IBus _bus;
+      readonly OrdersModel _model;
+      LadderVM _value;
+      SecurityMD? _security_md;
+      HashSet<uint> _selected_order_tree = new HashSet<uint>();
+
+      public LadderVMContainer(IBus bus, OrdersModel model) {
+         _bus = bus;
+         _model = model;
+      }
+
+      public SecurityMD? security_md {
+         get => _security_md;
+         set {
+            if (_security_md != value) {
+               _security_md = value;
+               _reset_ladder_vm();
+               RaisePropertyChanged(nameof(security_md), nameof(LadderVMContainer.value));
+            }
+         }
+      }
+      public LadderVM value => _value;
+
+      public void Dispose() {
+         if (_value != null) {
+            _value.Dispose();
+            _value = null;
+            RaisePropertyChanged(nameof(value));
+         }
+      }
+
+      public void set_orders(IEnumerable<uint> orders) {
+         _selected_order_tree = new HashSet<uint>(orders);
+         _reset_ladder_vm();
+      }
+
+      void _reset_ladder_vm() {
+         if (_value == null && !_security_md.HasValue)
+            return;
+         Disposable.replace(ref _value,
+            _security_md.HasValue ?
+               LadderVM.create_readonly(_bus,
+                  new LadderModel(security_md.Value, _model, _model.mbo_service,
+                  new Func<OrderSecurity, bool>(osec => _selected_order_tree.Contains(osec.order.Key))),
+                  Observable.Return(LadderSettings.sanitize(LadderSettings.Default))) : null);
+         RaisePropertyChanged(nameof(value));
+      }
+   }
+}

src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs

@@ -67,7 +67,8 @@ namespace mbts.spark {
       NativePriceSize _last_trade;
       Func<NativePriceSize, string> _fmt_size = MDDisplayHelper.get_formatter_nps(MarketSizeDisplay.get_default());
       int _old_tooltip_row = int.MaxValue;
-      double _old_last_trade_price = 0.0;
+      NativePriceSize? _old_last_trade;
+      string _direction_arrow = string.Empty;
       bool _tooltips_are_hooked_up = false;
       ToolTip tooltip_view = new ToolTip();
       IDisposable _parameterized_order_popup;
@@ -337,13 +338,28 @@ namespace mbts.spark {
          if (e.ChangedButton == MouseButton.Middle) {
             if (bs.HasValue) {
                _send_parameterized_order(point, bs.Value);
+               return;
             } else if (column.column_type == ColumnType.Price) {
-               if (Keyboard.IsKeyDown(Key.LeftShift) || Keyboard.IsKeyDown (Key.RightShift) ||
+               if (Keyboard.IsKeyDown(Key.LeftShift) || Keyboard.IsKeyDown(Key.RightShift) ||
                    Keyboard.IsKeyDown(Key.LeftAlt) || Keyboard.IsKeyDown(Key.RightAlt)) {
                   show_mbo_popup(point).ignore();
                } else {
                   _scroll_to_center();
                }
+               return;
+            }
+         } else if (_vm != null) {
+            uint size = e.ChangedButton == MouseButton.Right ? _vm.alternate_order_size_from_settings : _vm.size_calculator.value ?? 0;
+            // if warning enabled && (buy above opposite inside market || ask below opposite inside market)
+            // when 1-sided market, _get_top_price will return NaN, and so the price comparison is false
+            // meaning show no warning == correct
+            if (_vm.show_warn_on_cross_from_settings &&
+               (size > 0) &&
+               ((bs == Side.Buy && price >= _get_top_price(_asks)) || (bs == Side.Sell && price <= _get_top_price(_bids)))) {
+               string prompt = $"Are you sure you want to CROSS the market to {bs.ToString().ToUpper()} {size} @ {security.spec_or_default().format(price)} ?";
+               if (!BTSMessageBox.Confirm(prompt, "Cross Market Alert", MessageBoxImage.Warning)) {
+                  return;
+               }
             }
          }
          var pbs = (price, bs, e.ChangedButton);
@@ -678,12 +694,14 @@ namespace mbts.spark {
                   // At any rate, we need this part hiding the tooltip so that we don't leave random tooltips around
                   // and we have to reset to old row so that when we go back to what could be our preivous row, the tooltip gets drawn again
                   //System.Diagnostics.Debug.WriteLine("   Tooltip - Volume is 0");
+                  _old_tooltip_row = int.MaxValue;
                   _hide_tool_tip();
                   //_old_tooltip_row = Int32.MaxValue;
                }
             }
          } else {
             //System.Diagnostics.Debug.WriteLine("   Tooltip - not over Volume column");
+            _old_tooltip_row = int.MaxValue;
             _hide_tool_tip();
          }
       }
@@ -846,21 +864,43 @@ namespace mbts.spark {
       void _refresh_volume_at_price() {
          if (!_settings.volume_column.general.show)
             return;
+
+         // if the last trade has a new size then we need to explicitly
+         // mark the volume container as dirty because there is a chance
+         // we have arrived here off a size change and not a volume change
+         // or a random change, like applying new settings
+         bool last_trade_size_changed = _old_last_trade.HasValue ? _last_trade.size != _old_last_trade.Value.size : true;
+         if (last_trade_size_changed && _settings.volume_column.show_ltq) {
+            _volume_container.mark_dirty();
+         }
          var vapls = _volume_container.read_new_value();
          if (vapls != null) {
             Log.assert_d(_price_list != null);
-            var ltp = _last_trade.price;
-            var last_index = LadderRender.index_of(_price_list, ltp, _price_comparer);
-            string direction_arrow = string.Empty;
-            if (MathUtils.epsilon_equals(ltp, _old_last_trade_price)) {
-               // do nothing if in here b/c direction_arrow already string.empty
-            } else if (ltp > _old_last_trade_price) {
-               direction_arrow = "▲";
-            } else {
-               direction_arrow = "▼";
-            }
-            LadderRender.render_volumes(_volume_vis_tup.visual, _volume_vis_tup.glyph_context, _price_list, vapls, _settings.row_height, security.ContractSpec, _settings.volume_column, last_index, _last_trade, direction_arrow);
-            _old_last_trade_price = ltp;
+            var last_index = LadderRender.index_of(_price_list, _last_trade.price, _price_comparer);
+            LadderRender.render_volumes(_volume_vis_tup.visual, _volume_vis_tup.glyph_context, _price_list, vapls, _settings.row_height, security.ContractSpec, _settings.volume_column, last_index, _get_last_arrow_string());
+            _old_last_trade = _last_trade;
+         }
+
+         string _get_last_arrow_string() {
+            // if _old_last_trade doesn't have a value, this is the first time the ladder has been launched
+            // and so the direction should be drawn without an arrow since there is no basis for comparison
+            if (!_old_last_trade.HasValue) {
+               _direction_arrow = string.Empty;
+               // if the Lasts are different then we need to reformat the direction arrow in some fashion
+            } else if (_old_last_trade != _last_trade) {
+               var ltp = _last_trade.price;
+               if (MathUtils.epsilon_equals(ltp, _old_last_trade.Value.price)) {
+                  // update on the same price, so size must be different
+                  _direction_arrow = string.Empty;
+               } else if (ltp > _old_last_trade.Value.price) {
+                  _direction_arrow = "▲";
+               } else {
+                  _direction_arrow = "▼";
+               }
+            } 
+            // regardless of if we've arrived here via a new Last (and new direction arrow)
+            // or we're reusing the old one, this format bit is the same
+            return $"{_direction_arrow} {_last_trade.size} ";
          }
       }
 

src/client/spark/Modules/Trading/Ladder/View/LadderOrdersHost.cs

@@ -9,9 +9,7 @@ using System.Linq;
 using System.Threading.Tasks;
 using System.Windows;
 using System.Windows.Controls;
-using System.Windows.Data;
 using System.Windows.Input;
-using System.Windows.Interactivity;
 using System.Windows.Media;
 
 namespace mbts.spark {
@@ -139,6 +137,7 @@ namespace mbts.spark {
                   // properly Dispose of it later when the popup is closed.
                   DataContext = obvm,
                   Child = view,
+                  // StaysOpen true for debugging
                   StaysOpen = false,
                   PlacementTarget = popup_placement_target,
                   Placement = System.Windows.Controls.Primitives.PlacementMode.Bottom,
@@ -155,7 +154,10 @@ namespace mbts.spark {
                popup.SetBinding(System.Windows.Controls.Primitives.Popup.IsOpenProperty,
                   nameof(OrderBookVM.is_row_collection_populated)
                );
-               popup.Closed += (sender, event_args) => (popup.DataContext as IDisposable)?.Dispose();
+               popup.Closed += (sender, event_args) => {
+                  (_parent.DataContext as LadderVM)?.on_mini_orderbook_closed(obvm.create());
+                  (popup.DataContext as IDisposable)?.Dispose();
+               };
                popup.MouseUp += (sender, event_args) => {
                   if (event_args.ChangedButton == MouseButton.Middle) {
                      popup.IsOpen = false;

src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs

@@ -196,8 +196,7 @@ namespace mbts.spark {
         ContractSpecificationImmutable spec,
         VolumeColumnSettings settings,
         int last_index,
-        NativePriceSize last_trade, 
-        string direction_arrow
+        string last_size_and_direction
         ) {
          if (!data.Any()) {
             _clear_visual(dv);
@@ -216,16 +215,16 @@ namespace mbts.spark {
          Brush total_brush = null;
          if (settings.total.bars.result.HasValue) {
             total_brush = new SolidColorBrush(settings.total.bars.result.Value);
-         } else if (components.Count == 0) {
+         } else if (components.Count == 0 && !settings.show_ltq) {
             _clear_visual(dv);
             return;
          }
          // inflate the max so that the graph never fills the available space
          double max = data.Max(v => v.Volume) * 1.1;
-         Brush text_brush = settings.general.foreground.rgb_brush();
          _render_cells(dv, row_height, data.Select(d => (d.Price, d)), settings.general, prices, spec, render_cell);
          /// local methods
          void render_cell(DrawingContext dc, int r, VolumeAtPriceLevelImmutable vap) {
+            Brush text_brush = settings.general.foreground.rgb_brush();
             double y = row_height * r;
             var last_trade_here = r == last_index;
 
@@ -259,7 +258,8 @@ namespace mbts.spark {
             }
             if (settings.show_ltq && last_trade_here) {
                numbers_text.Clear();
-               numbers_text.Add($"{direction_arrow} {last_trade.size} ");
+               numbers_text.Add(last_size_and_direction);
+               text_brush = BTSCoreColors.white;
             }
             if (numbers_text.Count > 0) {
                string str = string.Join("/", numbers_text);

src/client/spark/Modules/Trading/Ladder/View/LadderSettingsView.xaml.cs

@@ -10,10 +10,15 @@ namespace mbts.ui.spark {
    /// </summary>
    partial class LadderSettingsView : UserControl {
       public const string
-         OrdersColumnSampleTemplateKey = nameof(OrdersColumnSampleTemplateKey),
-         ColumnVisibilityToggleTemplateKey = nameof(ColumnVisibilityToggleTemplateKey),
+         OrdersColumnTemplateKey = nameof(OrdersColumnTemplateKey),
+         VolumeColumnTemplateKey = nameof(VolumeColumnTemplateKey),
+         LastColumnTemplateKey = nameof(LastColumnTemplateKey),
          FavoriteAlgoAddButtonTemplateKey = nameof(FavoriteAlgoAddButtonTemplateKey);
 
+      public static readonly IMultiValueConverter LadderColumnToggleShowToolTipConverter =
+         ValueConverter.create<bool, bool, string, string>((can_toggle_show, show, col_name) =>
+            can_toggle_show ? $"{(show ? "Hide" : "Show")} {col_name}" : $"{col_name} cannot be {(show ? "hidden" : "shown")}.");
+
       public LadderSettingsView() =>
          InitializeComponent();
 

src/client/spark/Modules/Trading/Ladder/View/LadderTactileAdorner.cs

@@ -152,20 +152,21 @@ namespace mbts.spark {
             // When middle click over bid or ask columns:
             //   Non-parameterizalbe order: change cursor to No indicating sending an order is not possible
             //   Parameterizable order:  if qty is null/0, flash and No cursor
-            var pos = e.GetPosition(_host);
-            var column_type = _host._column_for_point(pos).column_type;
-            var selected_algo_can_expand = _host._vm.order_properties_vm?.selected_algo_definition?.algo_root?.can_expand ?? true;
-            if (e.MiddleButton == MouseButtonState.Pressed &&
-               (column_type == LadderGridHost.ColumnType.Bid || column_type == LadderGridHost.ColumnType.Ask)) {
-               if (!selected_algo_can_expand) {
-                  _host.Cursor = Cursors.No;
-               }
-               if (selected_algo_can_expand && (_host._vm.size_calculator.value ?? 0) == 0) {
-                  _host._vm.size_calculator.flash_error();
-                  _host.Cursor = Cursors.No;
+            if (_host._vm != null) {
+               var pos = e.GetPosition(_host);
+               var column_type = _host._column_for_point(pos).column_type;
+               var selected_algo_can_expand = _host._vm.order_properties_vm?.selected_algo_definition?.algo_root?.can_expand ?? true;
+               if (e.MiddleButton == MouseButtonState.Pressed &&
+                  (column_type == LadderGridHost.ColumnType.Bid || column_type == LadderGridHost.ColumnType.Ask)) {
+                  if (!selected_algo_can_expand) {
+                     _host.Cursor = Cursors.No;
+                  }
+                  if (selected_algo_can_expand && (_host._vm.size_calculator.value ?? 0) == 0) {
+                     _host._vm.size_calculator.flash_error();
+                     _host.Cursor = Cursors.No;
+                  }
                }
             }
-
             _is_mouse_down = true;
             InvalidateVisual();
          }

src/client/spark/Modules/Trading/Ladder/View/LadderView.xaml

@@ -39,6 +39,8 @@
       <converters:ResponsiveTextConverter x:Key="OpenTextConverter" LongText="Open:" ShortText="O:" Threshold="99" />
       <converters:ResponsiveTextConverter x:Key="SettleTextConverter" LongText="Settle:" ShortText="S:" Threshold="99" />
       <converters:ResponsiveTextConverter x:Key="VolumeTextConverter" LongText="Volume:" ShortText="V:" Threshold="99" />
+      <converters:DoubleSubtractionConverter x:Key="DoubleSubtractionConverter" Value="4" />
+      <converters:DoubleSubtractionConverter x:Key="HeightDoubleSubtractionConverter" Value="6" />
       <Style TargetType="GridViewColumnHeader">
         <Setter Property="Background" Value="{mbts:BTSColor header}"/>
         <Setter Property="Foreground" Value="{mbts:BTSColor header_text}"/>
@@ -288,8 +290,11 @@
         />
       </Grid.LayoutTransform>
       <Grid.ColumnDefinitions>
-        <ColumnDefinition Width="{Binding left_panel_width, Mode=TwoWay, Converter={StaticResource GridLengthPixelConverter}}" 
-                          MinWidth="60" MaxWidth="150"/>
+        <ColumnDefinition
+          Width="{Binding left_panel_width, Mode=TwoWay, Converter={StaticResource GridLengthPixelConverter}}" 
+          MinWidth="{x:Static spark:LadderView.MinLeftPanelWidth}"
+          MaxWidth="{x:Static spark:LadderView.MaxLeftPanelWidth}"
+        />
         <ColumnDefinition/>
       </Grid.ColumnDefinitions>
       <Grid.RowDefinitions>
@@ -309,11 +314,14 @@
               </Style>
             </StackPanel.Resources>
             <StackPanel x:Name="_slider_stack_panel" Margin="5,5,5,0">
-              <Slider x:Name="_ui_scaler" Value="{Binding zoom_factor}" 
-                      Minimum="{StaticResource MinZoomFactor}"
-                      Maximum="{StaticResource MaxZoomFactor}"
-                      Width="{Binding Path=ActualWidth, ElementName=_slider_stack_panel}"
-                      Visibility="{Binding show_zoom, Converter={StaticResource BooleanToVisibilityConverter}}"/>
+              <Slider
+                x:Name="_ui_scaler"
+                Value="{Binding zoom_factor}" 
+                Minimum="{x:Static spark:LadderView.MinZoomFactor}"
+                Maximum="{x:Static spark:LadderView.MaxZoomFactor}"
+                Width="{Binding Path=ActualWidth, ElementName=_slider_stack_panel}"
+                Visibility="{Binding show_zoom, Converter={StaticResource BooleanToVisibilityConverter}}"
+              />
             </StackPanel>
             <Grid Margin="2,4,2,0">
               <Grid.RowDefinitions>
@@ -468,6 +476,7 @@
                     </converters:MultiValueConverterPipe>
                   </MultiBinding.Converter>
                   <Binding Path="show_day_position"/>
+                  <Binding Path="show_raw_day_position"/>
                   <Binding Path="show_account_position"/>
                 </MultiBinding>
               </Button.Visibility>
@@ -478,6 +487,7 @@
                     <MultiBinding Converter="{x:Static spark:LadderView.PositionToolTipConverter}">
                       <Binding Path="order_properties_vm.selected_account"/>
                       <Binding Path="show_day_position"/>
+                      <Binding Path="show_raw_day_position"/>
                       <Binding Path="show_account_position"/>
                     </MultiBinding>
                   </TextBlock.Text>
@@ -573,7 +583,9 @@
           <Setter Property="FontSize" Value="{Binding font_size}"/>
           <Setter Property="Foreground" Value="{Binding foreground}"/>
           <Setter Property="TextLines" Value="{Binding text_lines}" />
-          <Setter Property="Width" Value="{x:Static controls:Badge.DefaultWidth}"/>
+          <!--<Setter Property="Width" Value="{x:Static controls:Badge.DefaultWidth}"/>-->
+          <Setter Property="Width" Value="{Binding ActualWidth, RelativeSource={RelativeSource AncestorType={x:Type spark:LadderOrdersHost}}, Converter={StaticResource DoubleSubtractionConverter}}" />
+          <Setter Property="Height" Value="{Binding grid_row_height, Converter={StaticResource HeightDoubleSubtractionConverter}}" />
           <Setter Property="HasMultipleOrdersAtLevel" Value="{Binding has_multiple_orders_at_same_level}" />
           <Setter Property="IsHedgeOrder" Value="{Binding is_hedge_order}" />
           <Setter Property="AlgoType" Value="{Binding algo_type}" />

src/client/spark/Modules/Trading/Ladder/View/LadderView.xaml.cs

@@ -11,36 +11,68 @@ using System.Windows.Input;
 
 namespace mbts.spark {
    partial class LadderView : UserControl {
+      public const double
+         MinLeftPanelWidth = 60,
+         MaxLeftPanelWidth = 150,
+         MinZoomFactor = 0.5,
+         MaxZoomFactor = 1.5;
+
       public static IMultiValueConverter PositionToolTipConverter =
-         ValueConverter.create<AccountTuple?, bool, bool, string>((account, show_day_pos, show_total_pos) => {
-            const string day_pos_text = "day", total_pos_text = "total";
+         ValueConverter.create<AccountTuple?, bool, bool, bool, string>((account, show_day_pos, show_raw_day_pos, show_total_pos) => {
+            const string day_pos_text = "day", raw_day_pos_text = "raw day", total_pos_text = "total";
             if (!account.HasValue)
                return string.Empty;
-            var sb = new StringBuilderEx(account.Value.name);
-            string primary_pos;
-            if (show_day_pos) {
-               primary_pos = day_pos_text;
-               if (show_total_pos) {
-                  sb.Add(" '", primary_pos, " ");
-                  sb.Add("(", total_pos_text, ")' ");
-               } else {
-                  sb.Add(" ", primary_pos, " ");
-               }
-            } else if (show_total_pos) {
-               primary_pos = total_pos_text;
-               sb.Add(" ", primary_pos, " ");
-            } else {
-               // unexpected code path (the button for which this tooltip is destined should be invisible in this case), but no need to throw an exception.
-               return string.Empty;
-            }
-            sb.Add("position\n(click to copy ");
-            if (show_day_pos && show_total_pos)
-               sb.Add(primary_pos, " position ");
-            sb.Add("to size)");
-            return sb.ToString();
-         });
+            /// Note: 'day,' and 'raw day,' are interchangeable wrt the string format, 'total' however is treated differently.
+            /// Different Formats:
+            // No parts are visible:
+            //    null
+            //
+            // 1 part 'foo' is visible:
+            //    "<account> foo position
+            //    click to copy to size"
+            //
+            // 2 parts 'day' and 'raw day' are visible:
+            //    "<account> 'day / raw day' position
+            //     click to copy day to size"
+            // 
+            // 2 parts 'day' and 'total' are visible:
+            //    "<account> 'day (total)' position
+            //     click to copy day to size"
+            //
 
-      readonly double _max_zoom, _min_zoom;
+            string primary_pos = null;
+            // part count is incremented in the 'add_part' method
+            int part_count = 0;
+            var sb = new StringBuilderEx();
+
+            if (show_day_pos) add_part(day_pos_text, " / ");
+            if (show_raw_day_pos) add_part(raw_day_pos_text, " / ");
+            if (show_total_pos) add_part(total_pos_text, " (", ")");
+            //
+            if (part_count > 1) {
+               // This is a complex expression (showing more than 1 value) - wrap it in single quotes.
+               // Explicitly state which value will be copied to the size input.
+               sb.Insert(0, "'");
+               sb.Add("'");
+               sb.Add(" position\n(click to copy ", primary_pos, " to size)");
+            } else {
+               // Only showing 1 value, no need for single quotes,
+               // nor an explicit statement that indicates which value will be copied to the size input.
+               sb.Add(" position\n(click to copy to size)");
+            }
+            return sb.ToString();
+
+            void add_part(string part_name, string separator = null, string separator_suffix = null) {
+               if (part_count++ > 0) {
+                  sb.Add(separator);
+                  sb.Add(part_name);
+                  sb.Add(separator_suffix);
+               } else {
+                  primary_pos = part_name;
+                  sb.Add($"{account.Value.name} {part_name}");
+               }
+            }
+         });
 
       internal LadderView(LadderVM vm) {
          InitializeComponent();
@@ -50,19 +82,6 @@ namespace mbts.spark {
          this.vm = vm;
          DataContext = vm;
          DataContextChanged += datacontext_changed;
-         if (TryFindResource("MaxZoomFactor") is double found_max) {
-            _max_zoom = found_max;
-         } else {
-            // is there a better way of not specifying the constant twice ?
-            // once in the resource dictionary here and again in the xaml, seems like there has to be a better way
-            _max_zoom = 1.5;
-         }
-         // ditto
-         if (TryFindResource("MinZoomFactor") is double found_min) {
-            _min_zoom = found_min;
-         } else {
-            _min_zoom = 0.5;
-         }
          _ui_scaler.MouseDoubleClick += _ui_scaler_MouseDoubleClick;
          this.PreviewMouseWheel += LadderView_PreviewMouseWheel;
          this.PreviewMouseDown += LadderView_PreviewMouseDown;
@@ -78,7 +97,7 @@ namespace mbts.spark {
             var delta = (e.Delta > 0) ? 0.1 : -0.1;
             var proposed_scaler_value = _ui_scaler.Value + delta;
             // Here we enforce the same contraints that are on the gui slider regarding min and max
-            if (_min_zoom < proposed_scaler_value && proposed_scaler_value < _max_zoom) {
+            if (MinZoomFactor < proposed_scaler_value && proposed_scaler_value < MaxZoomFactor) {
                _ui_scaler.Value = proposed_scaler_value;
             }
          }

src/client/spark/Modules/Trading/ManualFills/ManualFillRowEditor.xaml

@@ -63,8 +63,10 @@
         IsEditMode="False"
         IsLazy="True"
         SecurityMap="{DynamicResource ResourceKey={x:Static usp:ManualFillRowEditor.SecuritiesKey}}"
-        SelectedSecurity="{Binding security}"
+        SelectedSecurity="{Binding security, UpdateSourceTrigger=Explicit}"
         ShowDialogSkirt="True"
+        ToolTip="{Binding SelectedCriteria, RelativeSource={RelativeSource Self}, Converter={x:Static c:ContractPickerPopup.SecurityCriteriaTextConverter}, Mode=OneWay}"
+        OKClick="{x:Static c:ContractPickerPopup.FlushSelectedSecurityHandler}"
       />
       <ComboBox Grid.Row="2" Grid.Column="2" ItemsSource="{DynamicResource ResourceKey={x:Static usp:ManualFillRowEditor.AccountsKey}}" SelectedItem="{Binding account}"/>
       <ComboBox Grid.Row="2" Grid.Column="4" ItemsSource="{DynamicResource ResourceKey={x:Static usp:ManualFillRowEditor.UsersKey}}" SelectedItem="{Binding user}"/>

src/client/spark/Modules/Trading/ManualFills/ManualFillsModel.cs

@@ -79,8 +79,8 @@ namespace bts.shell.manual_fills {
 
       public ManualFillsModel(OrdersModel model)
          : this(model, model.on_manual_fill_tuples,
-              model.factory.subscribe_accounts().Select(d => MappedDictionary.create(d, kv => new AccountTuple(kv.Key, kv.Value))).Table(u => u.id),
-              model.factory.subscribe_users().Select(d => MappedDictionary.create(d, kv => new UserTuple(kv.Key, kv.Value))).Table(a => a.id)) { }
+              model.factory.subscribe_accounts().Select(d => MappedDictionary.create(d, (k, v) => new AccountTuple(k, v))).Table(u => u.id),
+              model.factory.subscribe_users().Select(d => MappedDictionary.create(d, (k, v) => new UserTuple(k, v))).Table(a => a.id)) { }
 
       public ManualFillsModel(OrdersModel model, IObservable<TableUpdate<ManualFillTuple, int>> manual_fills, IObservable<TableUpdate<AccountTuple, uint>> accounts, IObservable<TableUpdate<UserTuple, uint>> users) {
          _model = model;

src/client/spark/Modules/Trading/ManualFills/ManualFillsParser.cs

@@ -73,7 +73,7 @@ namespace bts.shell.manual_fills {
       // The security desc lookup could be better optimized, but the speed at which fills are imported is probably not a paramount concern.
       public static IEnumerable<ParsedManualFill> parse_rows(IEnumerable<string> rows, IReadOnlyDictionary<uint, SecurityImmutable> security_map, IReadOnlyDictionary<uint, string> account_map, IReadOnlyDictionary<uint, string> user_map) =>
          parse_rows(rows,
-            reverse_lookup(MappedDictionary.create(security_map, kv => kv.Value.ToString())),
+            reverse_lookup(MappedDictionary.create(security_map, s => s.ToString())),
             reverse_lookup(account_map),
             reverse_lookup(user_map));
 

src/client/spark/Modules/Trading/ManualFills/ManualFillsVM.cs

@@ -157,7 +157,7 @@ namespace bts.shell.manual_fills {
             var lines = File.ReadAllLines(file_name);
             var parsed_fills = ManualFillsParser.parse_rows(
                lines,
-               MappedDictionary.create(security_map, kv => kv.Value.security),
+               MappedDictionary.create(security_map, smd => smd.security),
                accounts.ToDictionary(a => a.Value.id, a => a.Value.name),
                users.ToDictionary(u => u.Value.id, u => u.Value.name)
             ).ToList();

src/client/spark/Modules/Trading/ManualFills/ManualFillsView.xaml

@@ -145,6 +145,7 @@
                   SecurityMap="{Binding DataContext.security_map, RelativeSource={RelativeSource AncestorType=DataGrid}, Mode=OneWay}"
                   SelectedSecurity="{Binding security, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
                   ShowDialogSkirt="True"
+                  ToolTip="{Binding SelectedCriteria, RelativeSource={RelativeSource Self}, Converter={x:Static c:ContractPickerPopup.SecurityCriteriaTextConverter}, Mode=OneWay}"
                 />
               </DataTemplate>
             </DataGridTemplateColumn.CellEditingTemplate>

src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml

@@ -14,7 +14,6 @@
              xmlns:order="clr-namespace:bts.api.orderman;assembly=spark_api"
              mc:Ignorable="d"
              MaxHeight="240"
-             MinWidth="875"
              d:DesignHeight="600" d:DesignWidth="1080"
              FocusManager.IsFocusScope="True"
              Background="{StaticResource CommonBackground}">
@@ -99,7 +98,16 @@
             </MultiDataTrigger.Setters>
           </MultiDataTrigger>
         </Style.Triggers>
-
+        <!-- We added this IsSelected after seeing some strangeness  when bringing up the Mini OB,
+        then clicking the attach button, then performing a click to modify a param in the popup, the grid
+        would lose the appearance of its selected row. I think this was actually a result of a bad path
+        in the SelectionHighlight expression below, but that leaves me questioning how if it was bad (and
+        it was, I confirmed in Snoop) did the Grid successfully show a highlighted row in the first place.
+        
+        At any rate, I have a strong suspicion this Setter is no longer necessary, but I am too exhausted
+        and scared to remove it at this point.
+        -->
+        <Setter Property="IsSelected" Value="{Binding is_selected, Mode=TwoWay}" />
       </Style>
       <DataTemplate x:Key="{x:Static sp:MiniOrderBookView.RowTemplateKey}">
         <sp:MiniOrderBookRowView/>
@@ -121,10 +129,9 @@
       Rows="{Binding rows}"
       RowStyle="{StaticResource {x:Static sp:MiniOrderBookView.RowStyleKey}}"
       RowTemplate="{StaticResource {x:Static sp:MiniOrderBookView.RowTemplateKey}}"
-      SelectionHighlight="{Binding grid_settings_manager.selection_highlight, Mode=OneWay}"
+      SelectionHighlight="{Binding grid_settings_manager.core_manager.selection_highlight, Mode=OneWay}"
       RowsHorizontalScrollBarVisibility="Collapsed"
       RowHeight="20" 
-      SelectionMode="Single"
     >
         <c:DIYGrid.Resources>
           <ResourceDictionary>