Made cover cancel behaviour parameterizable.
This implements the server side only, the UI does not expose this configuration so effectively the behaviour right now is hard-coded until we get around to adding the UI.
This commit is contained in:
1 parent
bc3ab563bf
commit
66d05c63af
3 files changed
+24
-11
No files matched your search
@@ -174,6 +174,8 @@ message CoverOrderDefinition {
|
||||
CustomOrderDefinition hedge = 1;
|
||||
uint32 hedge_ticks = 2;
|
||||
CustomOrderDefinition child = 3;
|
||||
bool cancel_on_external_hedge_cancel = 4;
|
||||
bool cancel_hedges_on_cancel = 5;
|
||||
}
|
||||
message OffsetOrderDefinition {
|
||||
uint32 tick_offset_on_deploy = 1;
|
||||
|
||||
@@ -26,6 +26,8 @@ struct CoverAlgo::PImpl {
|
||||
IAlgoServices *algo;
|
||||
OrderKey child_key = null_order_key();
|
||||
Price price_improvement_delta;
|
||||
bool cancel_on_external_hedge_cancel = false;
|
||||
bool cancel_hedges_on_cancel = false;
|
||||
ChildTemplate *child_template = nullptr;
|
||||
ChildTemplate *hedge_template = nullptr;
|
||||
Quantity hedged_fills = Quantity(0);
|
||||
@@ -64,7 +66,7 @@ OrderOpResult CoverAlgo::do_before_launch(IBeforeLaunchAlgoServices &serv) {
|
||||
}
|
||||
|
||||
init_hedge_template(serv, cover.hedge());
|
||||
set_price_improvement_delta(serv, cover);
|
||||
update_definition(serv, cover);
|
||||
return {};
|
||||
}
|
||||
|
||||
@@ -135,10 +137,16 @@ void CoverAlgo::on_child_change(OrderKey k, ChildState const &st) {
|
||||
case ChildStatus::WORKING:
|
||||
break;
|
||||
case ChildStatus::CANCELED:
|
||||
if (me->cancel_on_external_hedge_cancel) {
|
||||
LOG(OrderMan, Info, "CoverAlgo {}. Hedge was canceled, terminating",
|
||||
algo().order_key().value());
|
||||
me->status = Status::DONE;
|
||||
algo().terminate_error("Unexpected child cancel");
|
||||
} else
|
||||
std::remove(me->hedges.begin(), me->hedges.end(), k);
|
||||
break;
|
||||
case ChildStatus::COMPLETED:
|
||||
if (auto it = std::find(me->hedges.begin(), me->hedges.end(), k);
|
||||
it != me->hedges.end())
|
||||
me->hedges.erase(it);
|
||||
std::remove(me->hedges.begin(), me->hedges.end(), k);
|
||||
break;
|
||||
}
|
||||
}
|
||||
@@ -162,7 +170,7 @@ void CoverAlgo::do_update(api::orderman::Update const &update) {
|
||||
// process custom part of the udpate if any
|
||||
if (update.has_custom()) {
|
||||
auto &cover_update = update.custom().cover();
|
||||
set_price_improvement_delta(algo(), cover_update);
|
||||
update_definition(algo(), cover_update);
|
||||
if (cover_update.has_child()) {
|
||||
*child_update.mutable_custom() = cover_update.child();
|
||||
}
|
||||
@@ -189,11 +197,14 @@ void orderman::CoverAlgo::init_hedge_template(
|
||||
me->hedge_template = &(algo.make_child_template(hedge_def));
|
||||
}
|
||||
|
||||
void CoverAlgo::set_price_improvement_delta(
|
||||
void CoverAlgo::update_definition(
|
||||
IBeforeLaunchAlgoServices &serv,
|
||||
api::orderman::CoverOrderDefinition const &cover) {
|
||||
me->price_improvement_delta = Price(
|
||||
securities::tick_size(serv.security()).value() * cover.hedge_ticks());
|
||||
me->cancel_hedges_on_cancel = cover.cancel_hedges_on_cancel();
|
||||
me->cancel_on_external_hedge_cancel =
|
||||
cover.cancel_on_external_hedge_cancel();
|
||||
}
|
||||
|
||||
void CoverAlgo::check_terminate() {
|
||||
@@ -209,10 +220,10 @@ void CoverAlgo::check_terminate() {
|
||||
}
|
||||
}
|
||||
|
||||
IAlgoOrder::OnCancelResponse CoverAlgo::on_cancel()
|
||||
{
|
||||
for (auto &k : me->hedges)
|
||||
algo().detach_child(k);
|
||||
IAlgoOrder::OnCancelResponse CoverAlgo::on_cancel() {
|
||||
if (!me->cancel_hedges_on_cancel)
|
||||
for (auto &k : me->hedges)
|
||||
algo().detach_child(k);
|
||||
return IAlgoOrder::OnCancelResponse::HONOR;
|
||||
}
|
||||
|
||||
|
||||
@@ -26,7 +26,7 @@ private:
|
||||
std::unique_ptr<PImpl> me;
|
||||
IAlgoServices &algo() const;
|
||||
void
|
||||
set_price_improvement_delta(IBeforeLaunchAlgoServices &,
|
||||
update_definition(IBeforeLaunchAlgoServices &,
|
||||
api::orderman::CoverOrderDefinition const &);
|
||||
void init_hedge_template(IBeforeLaunchAlgoServices &,
|
||||
api::orderman::CustomOrderDefinition const &);
|
||||
|
||||
Reference in new issue
Block a user