69b1ac243eabb009f0d006caa6d7786f0fd01fa4
As a static function that could be called from anywhere in the code (directly or indirectly), 'Configuration.Initialize' was vulnerable to race bugs. The "Configuration.get<T>()" method, whose calls are ubiquitous in our code, would initialize config if it hadn't been done so already. Without a reference to the configServer param, this param would effectively be ignored/overridden with null. It's important that login only be performed once, for obvious reasons (our exes that connect to sparkd are generally designed to process data for a single user). Furthermore, not every routine that requires a successful login has a reference to the credentials needed to do it. To address this, we now pass the ISparkdLoginService singleton to these routines so they can wait until the singular login task has completed before they begin.
Languages
C++
54.9%
C#
39.2%
CSS
2.7%
F#
1.3%
Python
0.8%
Other
0.9%