ui: Use dark theme foreground in mini orderbook, fills popups

It was black in a couple places before, making it hard to read.

.devcontainer/Dockerfile

@@ -90,6 +90,12 @@ RUN apt-get update && apt-get install -y libpcap0.8-dev
 # Databento (deps)
 RUN apt-get update && apt-get -y install libzstd-dev
 
+# Docker in Docker
+RUN apt-get update && apt-get install -y \
+    docker.io \
+    docker-compose \
+    docker-compose-v2
+
 # Set up default executables (update-alternatives)
 RUN \
    update-alternatives --install /usr/bin/clang clang /usr/bin/clang-$clang_major 100; \

.devcontainer/devcontainer.json

@@ -1,15 +1,10 @@
 {
   "dockerFile": "Dockerfile",
-  // Creates local dir to mount to HOME in docker 
-  "initializeCommand": "mkdir -p ${localEnv:HOME}/.bts/devcontainer-mounts/${devcontainerId}",
   "hostRequirements": {
-    "memory": "4gb",
-    "storage": "6gb"
+    "memory": "8gb",
+    "storage": "10gb"
   },
-  "postCreateCommand": "/home/bts/spark/docker/sparkd/dev/devcontainer_post_create.sh",
   "containerUser": "bts",
-  "workspaceMount": "source=${localWorkspaceFolder},target=/home/bts/spark,type=bind",
-  "workspaceFolder": "/home/bts/spark",
   "updateRemoteUserUID": true,
   "shutdownAction": "none",
   // Note: If running multiple containers on the same host, each must use a
@@ -17,34 +12,20 @@
   // example, if 8000-8003 is taken, go with 9000-9003, then 10000-10003, etc.
   "runArgs": [
     "--shm-size",
-    "2gb",
-    "-p",
-    "8000:8000",
-    "-p",
-    "8001:8001",
-    "-p",
-    "8002:8002",
-    "-p",
-    "8003:8003",
-    "-p",
-    "12345:12345"
+    "8gb"
   ],
   "mounts": [
-    "source=${localEnv:HOME}/.bts/devcontainer-mounts/${devcontainerId},target=/home/bts,type=bind"
+    "source=/var/run/docker.sock,target=/var/run/docker.sock,type=bind"
   ],
   "customizations": {
     "vscode": {
-      "settings": {
-        "clangd.arguments": [
-          "--compile-commands-dir=${workspaceFolder}/build/clang/debug"
-        ]
-      },
       "extensions": [
         "eamodio.gitlens",
         "llvm-vs-code-extensions.vscode-clangd",
         "ms-vscode.cmake-tools",
-        "ms-vscode.cpptools"
+        "ms-vscode.cpptools",
+        "xaver.clang-format"
       ]
     }
   }
-}
+}

.env

@@ -0,0 +1,47 @@
+# This file defines the global default configuration for docker deployments.
+# It is tracked in source control. For temporary modifications, please create
+# a separate file called ".env.local" (it's in .gitignore, so won't be tracked).
+# If a variable is defined in both files, the value in .env.local will be used.
+#
+# About the deployment procedure:
+#   We use Docker Compose to build images and launch containers for various services
+#   that make up our software suite:
+#     - sparkd
+#     - TODO: pubsub
+#     - TODO: md-publisher
+#     - TODO: webapp (DSQA on the web)
+#     - TODO: api-server (websocket based)
+#   From inside a devcontainer, you can launch all services in separate containers
+#   on your machine by running:
+#
+#     tools/deploy.sh
+#
+#   This script builds release versions for each service, packaged (generally) in
+#   self-contained directories. Next, it runs a few "docker compose" commands to
+#   build docker images loaded with the self-contained binaries from the previous
+#   step, and start containers with those images to run each service. To view the
+#   commands that deploy.sh runs internally (without actually running them), run:
+#
+#     tools/deploy.sh --dry-run
+#
+#   For additional information/help, run:
+#
+#     tools/deploy.sh --help
+#
+
+### Sparkd ###
+# The internal image for sparkd to use. For more info, view:
+#   src/server/sparkd/Dockerfile
+SPARKD__IMAGE=sparkd
+# The config dir for this service to use
+SPARKD__CONFIG_DIR=src/server/sparkd/configurations/dev
+# Mount a specific volume or dir to "~/sparkdata/data" inside the docker.
+# Defaults to a volume named "sparkd_<config_port>" (e.g., sparkd_8000).
+# SPARKD__DATA_DIR=/home/bts/sparkdata/data
+SPARKD__SOURCE_DIR=install/sparkd-release-gcc
+SPARKD__CONFIG_PORT=8000
+SPARKD__QUICKBUS_PORT=8001
+SPARKD__SIM_FIX_PORT=8002
+SPARKD__SHM_SIZE=4gb
+
+# TODO: add config for other services (pubsub, md-publisher, webapp, api-server, etc.)

.gitignore

@@ -59,3 +59,4 @@ trace_data/
 .devcontainer/
 *.Generated.cs
 *.lst
+.env.local

compose.yaml

@@ -0,0 +1,63 @@
+services:
+  sparkd:
+    volumes:
+      - ${SPARKD__DATA_DIR:-sparkd_data}:/home/bts/sparkdata/data
+    build:
+      dockerfile: src/server/sparkd/Dockerfile
+      args:
+        - IMAGE=${SPARKD__IMAGE}
+        - SOURCE_DIR=${SPARKD__SOURCE_DIR}
+        - CONFIG_DIR=${SPARKD__CONFIG_DIR}
+    shm_size: "${SPARKD__SHM_SIZE:-512mb}"
+    command: >
+      sh -c "
+        echo bts | sudo -S chown -R bts:bts /home/bts/sparkdata/data
+        if [ -e "/home/bts/sparkdata/data/logging.sparkd/log" ]; then
+          mv "/home/bts/sparkdata/data/logging.sparkd/log" "/home/bts/sparkdata/data/logging.sparkd/log_$(date '+%Y%m%d-%H%M')"
+        fi
+        if [ -e "/home/bts/sparkdata/conf/.env.local" ]; then
+          echo 'Sourcing /home/bts/sparkdata/conf/.env.local'
+          set -a
+          . /home/bts/sparkdata/conf/.env.local
+          set +a
+        fi
+        ./sparkd run"
+    env_file:
+      - .env
+      - ${SPARKD__CONFIG_DIR}/.env
+    ports:
+      - "${SPARKD__CONFIG_PORT}:${SPARKD__CONFIG_PORT}"
+      - "${SPARKD__QUICKBUS_PORT}:${SPARKD__QUICKBUS_PORT}"
+      - "${SPARKD__SIM_FIX_PORT}:${SPARKD__SIM_FIX_PORT}"
+    deploy:
+      resources:
+        limits:
+          memory: "${SPARKD__MEMORY:-4gb}"
+
+  sparkd-tail:
+    image: bluetradingsystems/linux_dotnet7
+    volumes:
+      - type: volume
+        read_only: true
+        source: sparkd_data
+        target: /home/bts/sparkdata/data/logging.sparkd
+        volume:
+          subpath: logging.sparkd
+    command: ["tail", "-f", "/home/bts/sparkdata/data/logging.sparkd/log"]
+
+  sparkd-ping-test:
+    depends_on:
+      - sparkd
+    profiles:
+      - ping-test
+    build:
+      context: .
+      dockerfile_inline: |
+        FROM bluetradingsystems/linux_dotnet7
+        USER "root"
+        RUN apt-get update && apt-get -y install iputils-ping
+    command: [ "ping", "sparkd" ]
+
+volumes:
+  sparkd_data:
+    name: "sparkd_${SPARKD__CONFIG_PORT:-8000}"

docker/images/bluetradingsystems/linux_dotnet7/Dockerfile

@@ -0,0 +1,38 @@
+FROM ubuntu:22.04
+
+ARG DEBIAN_FRONTEND=noninteractive
+
+RUN apt-get update && apt-get install -y pkg-config
+RUN apt-get update && apt-get install -y locales
+RUN apt-get update && apt-get install -y ca-certificates
+RUN apt-get update && apt-get install -y libssh2-1-dev
+RUN apt-get update && apt-get install -y software-properties-common
+RUN apt-get update && apt-get install -y sudo
+
+# GCC
+ARG gcc_major=13
+RUN add-apt-repository ppa:ubuntu-toolchain-r/test \
+  && apt-get update \
+  && apt-get install -y g++-$gcc_major
+
+RUN apt-get update \
+  && apt-get install -y dotnet7
+
+RUN locale-gen en_US.UTF-8
+
+ARG docker_user="bts"
+ARG docker_uid="1000"
+ARG docker_pass="bts"
+
+RUN \
+  groupadd -g "$docker_uid" "$docker_user" \
+  && useradd \
+  -m \
+  -u "$docker_uid" \
+  -g "$docker_uid" \
+  -G sudo \
+  --password "$(openssl passwd -1 "$docker_pass")" \
+  "$docker_user"
+
+USER bts
+WORKDIR /home/bts

requirements.txt

@@ -1,10 +1,13 @@
 astroid==2.7.3
 autopep8==1.5.7
+boto3==1.37.9
+botocore==1.37.9
 certifi==2023.5.7
 charset-normalizer==3.1.0
 colorama==0.4.4
 idna==3.4
 isort==5.9.3
+jmespath==1.0.1
 lazy-object-proxy==1.6.0
 mccabe==0.6.1
 platformdirs==2.3.0
@@ -14,7 +17,11 @@ pycodestyle==2.7.0
 pycparser==2.20
 pylint==2.10.2
 PyMeta3==0.5.1
+python-dotenv==1.0.1
+python-dateutil==2.9.0.post0
 requests==2.31.0
+s3transfer==0.11.4
+six==1.17.0
 termcolor==1.1.0
 toml==0.10.2
 urllib3==2.0.3

src/client/spark/AW2/LiveTheoPublisher.cs

@@ -8,6 +8,7 @@ using MathNet.Numerics.Providers.FourierTransform;
 using BCG;
 using System.Windows.Automation;
 using bts.collections;
+using mbts.co2;
 
 namespace mbts.spark {
    // Publishes theos for all options (on the side, also publishes the theos for TC2).
@@ -114,11 +115,53 @@ namespace mbts.spark {
             }
             sym_theos.set_data(k, tp);
          }
+         _override_theos(ref rv);
          foreach (var kv in rv) {
             _bb.post(SparkTags.TC2Tags.LiveTheosTag(kv.Key), kv.Value);
          }
       }
 
+      private void _override_theos(ref Dictionary<(string, Venue), ExpStrikeKeyedData<TheoPoint>> theos) {
+         if (_compute_midmarket) {
+            SystemContractData sc_data = _bb.read_state(SparkTags.SystemContractsTag);
+            foreach (var kv in theos) {
+               string sym = kv.Key.Item1;
+               Venue exchange = kv.Key.Item2;
+               foreach (var t in kv.Value.get_data_linearly()) {
+                  DateTime exp = t.first;
+                  double strike = t.second;
+                  TheoPoint tp = t.third;
+                  var call_sec_md = sc_data.get_option(exchange, sym, exp, strike, PutOrCall.Call);
+                  {
+                     NativePriceSize call_bid, call_ask;
+                     ulong time = 0;
+                     call_sec_md.Value.md.get_bbo(ref time, out call_bid, out call_ask);
+                     double call_mid = (call_bid.price + call_ask.price) / 2;
+                     tp.call = call_mid;
+                  }
+                  {
+                     var put_sec_md = sc_data.get_option(exchange, sym, exp, strike, PutOrCall.Put);
+                     NativePriceSize put_bid, put_ask;
+                     ulong time = 0;
+                     put_sec_md.Value.md.get_bbo(ref time, out put_bid, out put_ask);
+                     double put_mid = (put_bid.price + put_ask.price) / 2;
+                     tp.put = put_mid;
+                  }
+               }
+            }
+            //replace theos with market bid
+            // get it from the bus and override
+         } else {
+            // do nothing, passes unchanged
+         }
+      }
+
+      private bool _compute_midmarket {
+         get {
+            return true;
+         }
+      }
+
 
       private void _interp_and_publish() {
          var timer = Stopwatch.StartNew();

src/client/spark/AW2/Misc/TheoPoint.cs

@@ -281,5 +281,16 @@ namespace mbts.spark {
          else
             return tp.put + (tp.pdelta * driver_diff) + (0.5 * tp.pgamma * driver_diff * driver_diff);
       }
+
+      public static TheoPoint extrapolate(TheoPoint tp, double driver, bool is_call) {
+         TheoPoint rv = tp.Clone() as TheoPoint;
+         double h = driver - tp.driver;
+         if (is_call) {
+            rv.call = tp.call + h * (tp.cdelta);
+         } else {
+            rv.put = tp.put + h * (tp.cdelta);
+         }
+         return rv;
+      }
    }
 }

src/client/spark/Daemons/MDDaemon.cs

@@ -133,17 +133,31 @@ namespace bts {
 
             // set 'unit quantity' for each sec
             foreach (var smd in exch_secs.Values) {
-               var meta = _security_metadata.get(smd.security);
-               if (meta.HasValue) {
-                  exch_secs[smd.id] = new(
-                     smd.security,
-                     smd.md,
-                     meta.Value.HasPriceDisplay ? meta.Value.PriceDisplay : null,
-                     meta.Value.HasQuantityDisplay ? meta.Value.QuantityDisplay : null);
-               }
+               var (priceDisplay, qtyDisplay) = GetDisplaySettings(smd.security);
+               exch_secs[smd.id] = new(smd.security, smd.md, priceDisplay, qtyDisplay);
             }
             _bus.post(SparkTags.ServerSecuritiesTag, exch_secs);
          }
+
+         (TickDisplaySettingsImmutable? Price, TickDisplaySettingsImmutable? Quantity) GetDisplaySettings(SecurityImmutable sec) {
+            var meta = _security_metadata.get(sec);
+            var priceDisplay = meta?.PriceDisplay ?? Security.Defaults.price_display_settingsi;
+            var qtyDisplay = meta?.QuantityDisplay ?? Security.Defaults.quantity_display_settingsi;
+            if (sec.HasContractSpec) {
+               var pd = priceDisplay.CloneToMutable();
+               pd.TickFactors = TickUtils.get_tick(sec, 0).to_api_tick_factors();
+               priceDisplay = new(pd);
+               if (sec.ContractSpec.QuantityInfos.TryGetFirst(out var qtyInfo)) {
+                  var qd = qtyDisplay.CloneToMutable();
+                  qd.ShowDecimalPart = qtyInfo.TickBase.is_real_non_zero() && !(qtyInfo.TickUnit / qtyInfo.TickBase).is_int();
+                  qd.TickFactors ??= new();
+                  qd.TickFactors.TickBase = qtyInfo.TickBase;
+                  qd.TickFactors.TickUnit = qtyInfo.TickUnit;
+                  qtyDisplay = new(qd);
+               }
+            }
+            return (priceDisplay, qtyDisplay);
+         }
       }
 
       public void Dispose() =>

src/client/spark/Modules/Market/MarketView/MarketViewFilterStates.cs

@@ -12,8 +12,13 @@ namespace bts.shell.market_view {
    class MarketViewFilterStates {
       [ProtoMember(37)]
       public Venue[] venue { get; set; }
+
+      [ProtoMember(38)]
+      public string[] currency { get; set; }
+
       [ProtoMember(1)]
       public string security { get; set; }
+
       [ProtoMember(2)]
       public DoubleMinMaxState bid_price { get; set; }
 
@@ -128,6 +133,7 @@ namespace bts.shell.market_view {
          var pb = new ColumnPredicateBuilder<MarketViewVM.Row>();
          // security
          pb.add_discrete_values(venue, r => r.venue);
+         pb.add_discrete_values(currency, r => r.currency);
          pb.add_regex(security, r => r.security.ToString());
          pb.add_regex(security_key, r => r.security_key.ToString());
 

src/client/spark/Modules/Market/MarketView/MarketViewVM.cs

@@ -98,7 +98,14 @@ namespace mbts.spark {
          _sec_meta_store = sec_meta_store;
          _settings_hub = settings_hub;
          security_filter = new RegexFilterVM<Row>(r => r.security.ToString(), nameof(Row.security));
-         currency_filter =new RegexFilterVM<Row>(r => r.currency, nameof(Row.currency));
+         currency_filter = DiscreteValuesFilterVM.Create<Row, string>(
+            bus.subscribe(SparkTags.SecuritiesTag)
+               .Sample(TimeSpan.FromSeconds(1))
+               .Select(sec_mds => sec_mds.Values.Select(smd => smd.security.Currency).Distinct().ToList()),
+            r => r.currency,
+            nameof(Row.currency),
+            EqualityComparer<string>.Default,
+            Comparer<string>.Default);
          // rows
          _wrapped_rows = _rows.WrapSelector(r => r.security_md, s => {
             var r = new Row(_bus, s, _orders_model, _position_model);
@@ -124,7 +131,7 @@ namespace mbts.spark {
 
          add_col(ColKey.Venue, r => r.venue.ToString(), nameof(Row.venue), venue_filter, FilterType.DiscreteValues, ColWidth.Exchange);
          add_col(ColKey.Security, r => r.security.ToString(), nameof(Row.security), security_filter, FilterType.Regex, ColWidth.Security);
-         add_col(ColKey.Currency, r => r.currency, nameof(Row.currency), currency_filter, FilterType.Regex, ColWidth.Currency);
+         add_col(ColKey.Currency, r => r.currency, nameof(Row.currency), currency_filter, FilterType.DiscreteValues, ColWidth.Currency);
          add_col(ColKey.Volume, r => r.volume_text, nameof(Row.volume), volume_filter, FilterType.ULongMinMax, ColWidth.Volume);
 
          // last
@@ -391,7 +398,7 @@ namespace mbts.spark {
 
       public IDataGridColumnPersistentFilter<Row, Venue[]> venue_filter { get; } = DiscreteValuesFilterVM.Common.exchange<Row>(r => r.venue, nameof(Row.venue));
       public IDataGridColumnPersistentFilter<Row, string> security_filter { get; }
-      public IDataGridColumnPersistentFilter<Row, string> currency_filter { get; }
+      public IDataGridColumnPersistentFilter<Row, string[]> currency_filter { get; }
       public IDataGridColumnPersistentFilter<Row, DoubleMinMaxState> bid_price_filter { get; } = new DoubleMinMax<Row>(r => r.bid_price, nameof(Row.bid_price));
       public IDataGridColumnPersistentFilter<Row, DoubleMinMaxState> bid_qty_filter { get; } = new DoubleMinMax<Row>(r => r.bid_qty_display, nameof(Row.bid_qty_display));
       public IDataGridColumnPersistentFilter<Row, DoubleMinMaxState> dbid_qty_filter { get; } = new DoubleMinMax<Row>(r => r.dbid_qty_display, nameof(Row.dbid_qty_display));
@@ -538,6 +545,7 @@ namespace mbts.spark {
       public MarketViewFilterStates get_filter_states() =>
          new() {
             venue = venue_filter.get_state(),
+            currency = currency_filter.get_state(),
             security = security_filter.get_state(),
             bid_price = bid_price_filter.get_state(),
             bid_merged_size = bid_qty_filter.get_state(),
@@ -584,6 +592,7 @@ namespace mbts.spark {
 
          using var _ = rows_view.DeferRefresh();
          venue_filter.load_state(filters.venue);
+         currency_filter.load_state(filters.currency);
          security_filter.load_state(filters.security);
          bid_price_filter.load_state(filters.bid_price);
          bid_qty_filter.load_state(filters.bid_merged_size);
@@ -620,16 +629,16 @@ namespace mbts.spark {
 
       static (string desc, Color fg) _fills_title(ColKey key) =>
          key switch {
-            ColKey.Position => ("Day Fills", Colors.Black),
-            ColKey.RawDayPosition => ("Raw Day Fills", Colors.Black),
-            _ => ("Fills", Colors.Black),
+            ColKey.Position => ("Day Fills", BTSColors.DayFills.foreground),
+            ColKey.RawDayPosition => ("Raw Day Fills", BTSColors.DayFills.foreground),
+            _ => ("Fills", BTSColors.UI.default_text),
          };
 
       static (string desc, Color fg) _orderbook_title(ColKey key) =>
          key switch {
             ColKey.WorkingBids => ((string desc, Color fg))("Working Buy Orders", BTSColors.MarketData.bid),
             ColKey.WorkingAsks => ((string desc, Color fg))("Working Sell Orders", BTSColors.MarketData.ask),
-            _ => ("Working Orders", Colors.Black),
+            _ => ("Working Orders", BTSColors.UI.default_text),
          };
 
       static GridSettings _hide_cols(GridSettings grid, IEnumerable<OrderBookGridView.ColumnKeys> columns) =>

src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs

@@ -226,7 +226,7 @@ namespace mbts.spark {
             // notional value
             Add(notional_value_column = new NotionalValueColumn(
                new DoubleMinMax<OrderRecordTupleWithRoot>(
-                  ort => ort.order.order.notional_value(), nameof(OrderBookRowVM.notional_value))));
+                  ort => ort.notional_value, nameof(OrderBookRowVM.notional_value))));
             // edit quantity column
             // not usually part of the main order book, but it's useful to add it
             // rather than debugging the popup window
@@ -236,6 +236,10 @@ namespace mbts.spark {
                new DoubleMinMax<OrderRecordTupleWithRoot>(
                   ort => ort.order.order.filled_quantity(),
                   nameof(OrderBookRowVM.filled_quantity))));
+            // filled notional value
+            Add(filled_notional_value_column = new FilledNotionalValueColumn(
+               new DoubleMinMax<OrderRecordTupleWithRoot>(
+                  ort => ort.filled_notional_value, nameof(OrderBookRowVM.filled_notional_value))));
             // price
             Add(price_column = new SimpleTextColumn<DoubleMinMaxState>(
                Columns.Price,
@@ -371,6 +375,7 @@ namespace mbts.spark {
          public EditableQtyColumn edit_qty_column { get; }
          public SimpleTextColumn<DoubleMinMaxState> price_column { get; }
          public FilledColumn filled_qty_column { get; }
+         public FilledNotionalValueColumn filled_notional_value_column { get; }
          public SimpleTextColumn<DoubleMinMaxState> last_price_column { get; }
          public SimpleTextColumn<DoubleMinMaxState> avg_price_column { get; }
          public SimpleTextColumn<OrderStatus[]> status_column { get; }
@@ -399,6 +404,7 @@ namespace mbts.spark {
                notional_value = notional_value_column.filter.get_state(),
                price = price_column.filter.get_state(),
                qty_filled = filled_qty_column.filter.get_state(),
+               filled_notional_value = filled_notional_value_column.filter.get_state(),
                avg_price = avg_price_column.filter.get_state(),
                last_price = last_price_column.filter.get_state(),
                statuses = status_column.filter.get_state(),
@@ -423,6 +429,7 @@ namespace mbts.spark {
                qty_column.filter.load_state(fs.qty);
                notional_value_column.filter.load_state(fs.notional_value);
                filled_qty_column.filter.load_state(fs.qty_filled);
+               filled_notional_value_column.filter.load_state(fs.filled_notional_value);
                side_column.filter.load_state(fs.sides);
                order_type_column.filter.load_state(fs.order_types);
                root_algo_type_column.filter.load_state(fs.root_algo_types);
@@ -654,7 +661,14 @@ namespace mbts.spark {
 
       public class NotionalValueColumn : OrderbookColumnBase<DoubleMinMaxState>, IRenderColumn<OrderBookRowVM> {
          public NotionalValueColumn(IDataGridColumnPersistentFilter<OrderRecordTupleWithRoot, DoubleMinMaxState> filter)
-            : base(Columns.NotionalValue, DefaultColumnHeaders.NotionalValue, r => r.notional_value_text, DefaultColumnWidths.Qty, filter, DataGridFilterKnownTemplates.UIntMinMax, _wrap_comparer(r => r.quantity)) { }
+            : base(
+                 Columns.NotionalValue,
+                 DefaultColumnHeaders.NotionalValue,
+                 r => r.notional_value_text,
+                 DefaultColumnWidths.NotionalValue,
+                 filter,
+                 DataGridFilterKnownTemplates.DoubleMinMax,
+                 _wrap_comparer(r => r.notional_value)) { }
 
          public void draw(OrderBookRowVM row, DrawingContext dc, ColumnGeometry position, double row_height) =>
             CellRender.draw_text(
@@ -690,6 +704,32 @@ namespace mbts.spark {
                DefaultCellPadding);
       }
 
+      public class FilledNotionalValueColumn : OrderbookColumnBase<DoubleMinMaxState>, IRenderColumn<OrderBookRowVM> {
+         public FilledNotionalValueColumn(IDataGridColumnPersistentFilter<OrderRecordTupleWithRoot, DoubleMinMaxState> filter)
+            : base(
+                 Columns.FilledNotionalValue,
+                 DefaultColumnHeaders.FilledNotionalValue,
+                 r => r.filled_notional_value_text,
+                 DefaultColumnWidths.FilledNotionalValue,
+                 filter,
+                 DataGridFilterKnownTemplates.DoubleMinMax,
+                 _wrap_comparer(r => r.filled_notional_value)) { }
+
+         public void draw(OrderBookRowVM row, DrawingContext dc, ColumnGeometry position, double row_height) =>
+            CellRender.draw_text(
+               dc,
+               _get_glyph_context(row),
+               font_size,
+               row.filled_notional_value_text,
+               position,
+               row_height,
+               RenderUtils.get_side_brush(row),
+               background_brush,
+               horizontal_alignment,
+               VerticalAlignment.Center,
+               DefaultCellPadding);
+      }
+
       public class OrderBookOrderTypeColumn : OrderTypeColumn<Columns>, ICVOrderBookColumn {
          readonly BindingBase _foreground_binding;
          ListSortDirection? _cached_sort_direction;

src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs

@@ -108,7 +108,7 @@ namespace mbts.spark {
       public double display_quantity => quantity.safe_divide(_display_qty_divisor);
       public string display_quantity_text =>
          quantity_display_settings.to_tick_display_settings().format(display_quantity);
-      public double notional_value => order.notional_value();
+      public double notional_value => order_tuple.notional_value;
       public string notional_value_text => _fmt_price(notional_value);
       public TickDisplaySettingsImmutable quantity_display_settings {
          get => _quantity_display_settings;
@@ -130,6 +130,8 @@ namespace mbts.spark {
          filled_quantity.safe_divide(_display_qty_divisor);
       public string display_filled_quantity_text =>
          quantity_display_settings.to_tick_display_settings().format(display_filled_quantity);
+      public double filled_notional_value => order_tuple.filled_notional_value;
+      public string filled_notional_value_text => _fmt_price(filled_notional_value);
       public string last_msg => order.last_msg();
       // piq
       public uint piq => order_tuple.order.piq ?? uint.MaxValue;
@@ -357,9 +359,15 @@ namespace mbts.spark {
             if (_prospective_qty_translator_backing != null)
                _prospective_qty_translator_backing.actual_value = quantity;
          }
+         if ((Columns.NotionalValue & dirty) == Columns.NotionalValue) {
+            RaisePropertyChanged(nameof(notional_value), nameof(notional_value_text));
+         }
          if ((Columns.Filled & dirty) != 0) {
             RaisePropertyChanged(nameof(filled_quantity), nameof(display_filled_quantity));
          }
+         if ((Columns.FilledNotionalValue & dirty) == Columns.FilledNotionalValue) {
+            RaisePropertyChanged(nameof(filled_notional_value), nameof(filled_notional_value_text));
+         }
          // badge fill
          if (old_order_tuple.order.meta?.badge_color != order_tuple.order.meta?.badge_color) {
             // invalidate by setting to null (will be re-instantiated in the public getter)
@@ -523,6 +531,12 @@ namespace mbts.spark {
             if (oldval.order.piq != newval.order.piq) {
                dirty |= Columns.Piq;
             }
+            if (oldval.notional_value != newval.notional_value) {
+               dirty |= Columns.NotionalValue;
+            }
+            if (oldval.filled_notional_value != newval.filled_notional_value) {
+               dirty |= Columns.FilledNotionalValue;
+            }
             return dirty;
          }
       }

src/client/spark/Modules/Trading/OrderBook/Settings/OrderBookFilterStates.cs

@@ -1,165 +1,174 @@
-using bts.api;
-using bts.api.orderman;
-using bts.utils;
-
-using mbts;
-using mbts.spark;
-using mbts.spark.filters;
-using mbts.ui;
-using mbts.ui.utility;
-
-using ProtoBuf;
-
-using Spark.Api.Orders;
-
-using System;
-
-namespace bts.shell.orderbook {
-   [ProtoContract]
-   class FilterStates : IEquatable<FilterStates> {
-      [ProtoMember(1)]
-      public SecurityCriteria security_criteria;
-      [ProtoMember(2)]
-      public string order_key_regex;
-      [ProtoMember(3)]
-      public TimeFilterTuple time_created;
-      [ProtoMember(4)]
-      public string[] users;
-      [ProtoMember(5)]
-      public string[] accounts;
-      [ProtoMember(6)]
-      public Venue[] exchanges;
-      [ProtoMember(7)]
-      public TimeInForce[] tifs;
-      //[ProtoMember(8)]
-      //public CustomOrderDefinition.CustomOneofCase[] order_types;
-      [ProtoMember(23)]
-      public AlgoID[] order_types;
-      [ProtoMember(24)]
-      public AlgoID[] root_algo_types;
-      [ProtoMember(9)]
-      public Side[] sides;
-      [ProtoMember(10)]
-      public DoubleMinMaxState qty;
-      [ProtoMember(26)]
-      public DoubleMinMaxState notional_value;
-      [ProtoMember(11)]
-      public DoubleMinMaxState price;
-      [ProtoMember(12)]
-      public DoubleMinMaxState qty_filled;
-      [ProtoMember(13)]
-      public DoubleMinMaxState avg_price;
-      [ProtoMember(14)]
-      public DoubleMinMaxState last_price;
-      [ProtoMember(15)]
-      public OrderStatus[] statuses;
-      [ProtoMember(16)]
-      public string exchange_message_regex;
-      [ProtoMember(17)]
-      public TimeFilterTuple last_change;
-      //[ProtoMember(18)]
-      //public string security_regex;
-      [ProtoMember(19)]
-      public api.orderman.OrderSubType[] order_sub_types;
-      [ProtoMember(20)]
-      public string[] symbols;
-      [ProtoMember(21)]
-      public string parent_key_regex;
-      [ProtoMember(22)]
-      public string attached_target_order_key_regex;
-      [ProtoMember(25)]
-      public UIntMinMaxState piq;
-
-      public bool Equals(FilterStates other) =>
-         other != null &&
-         security_criteria.safe_equals(other.security_criteria) &&
-         order_key_regex == other.order_key_regex &&
-         parent_key_regex == other.parent_key_regex &&
-         attached_target_order_key_regex == other.attached_target_order_key_regex &&
-         time_created.Equals(other.time_created) &&
-         EqualityComparer.safe_sequence_equals(users, other.users) &&
-         EqualityComparer.safe_sequence_equals(accounts, other.accounts) &&
-         EqualityComparer.safe_sequence_equals(exchanges, other.exchanges) &&
-         EqualityComparer.safe_sequence_equals(tifs, other.tifs) &&
-         EqualityComparer.safe_sequence_equals(order_types, other.order_types) &&
-         EqualityComparer.safe_sequence_equals(root_algo_types, other.root_algo_types) &&
-         EqualityComparer.safe_sequence_equals(sides, other.sides) &&
-         qty.safe_equals(other.qty) &&
-         notional_value.safe_equals(other.notional_value) &&
-         price.safe_equals(other.price) &&
-         qty_filled.safe_equals(other.qty_filled) &&
-         avg_price.safe_equals(other.avg_price) &&
-         last_price.safe_equals(other.last_price) &&
-         EqualityComparer.safe_sequence_equals(statuses, other.statuses) &&
-         exchange_message_regex == other.exchange_message_regex &&
-         last_change.Equals(other.last_change) &&
-         EqualityComparer.safe_sequence_equals(order_sub_types, other.order_sub_types) &&
-         EqualityComparer.safe_sequence_equals(symbols, other.symbols) &&
-         piq.safe_equals(other.piq);
-
-      public override bool Equals(object obj) => Equals(obj as FilterStates);
-
-      public override int GetHashCode() =>
-         EqualityComparer.aggregate_hash(
-            security_criteria?.GetHashCode() ?? 0,
-            order_key_regex?.GetHashCode() ?? 0,
-            parent_key_regex?.GetHashCode() ?? 0,
-            attached_target_order_key_regex?.GetHashCode() ?? 0,
-            time_created.GetHashCode(),
-            EqualityComparer.safe_aggregate_hash(users),
-            EqualityComparer.safe_aggregate_hash(accounts),
-            EqualityComparer.safe_aggregate_hash(exchanges),
-            EqualityComparer.safe_aggregate_hash(tifs),
-            EqualityComparer.safe_aggregate_hash(order_types),
-            EqualityComparer.safe_aggregate_hash(root_algo_types),
-            EqualityComparer.safe_aggregate_hash(sides),
-            qty?.GetHashCode() ?? 0,
-            notional_value?.GetHashCode() ?? 0,
-            price?.GetHashCode() ?? 0,
-            qty_filled?.GetHashCode() ?? 0,
-            avg_price?.GetHashCode() ?? 0,
-            last_price?.GetHashCode() ?? 0,
-            EqualityComparer.safe_aggregate_hash(statuses),
-            exchange_message_regex?.GetHashCode() ?? 0,
-            last_change.GetHashCode(),
-            EqualityComparer.safe_aggregate_hash(order_sub_types),
-            EqualityComparer.safe_aggregate_hash(symbols),
-            piq?.GetHashCode() ?? 0);
-   }
-
-   static class FilterStatesExtensions {
-      public static Func<OrderRecordTupleWithRoot, bool> build_predicate(this FilterStates fs) {
-         var pb = new ColumnPredicateBuilder<OrderRecordTupleWithRoot>();
-         // security
-         pb.add_security_criteria(fs.security_criteria, o => o.order.security);
-         // regex
-         pb.add_regex(fs.order_key_regex, o => o.order.order.Key.ToString());
-         pb.add_regex(fs.exchange_message_regex, o => o.order.order.State.LastMsg);
-         pb.add_regex(fs.attached_target_order_key_regex, o => o.order.order.attached_target_order_key().ToString());
-         pb.add_regex(fs.parent_key_regex, o => o.order.order.ParentKey.ToString());
-         // time
-         pb.add_time_filter(fs.time_created, o => o.order.order.created());
-         pb.add_time_filter(fs.last_change, o => o.order.order.last_change());
-         // discrete values
-         pb.add_discrete_values(fs.users, o => o.order.order.user());
-         pb.add_discrete_values(fs.accounts, o => o.order.order.account());
-         pb.add_discrete_values(fs.exchanges, o => o.order.security?.Exchange ?? Venue.Unset);
-         pb.add_discrete_values(fs.tifs, o => o.order.order.time_in_force());
-         pb.add_discrete_values(fs.order_types, o => AlgoID.from_custom_def(o.order.order.Def.CustomDef));
-         pb.add_discrete_values(fs.root_algo_types, o => AlgoID.from_algo_key(o.root.algo?.key ?? default));
-         pb.add_discrete_values(fs.order_sub_types, o => o.order.order.sub_type());
-         pb.add_discrete_values(fs.sides, o => o.order.order.side());
-         pb.add_discrete_values(fs.statuses, o => o.order.order.status());
-         pb.add_discrete_values(fs.symbols, o => o.order.security?.Symbol);
-         // numeric
-         pb.add_numeric(fs.qty, o => o.order.order.quantity());
-         pb.add_numeric(fs.notional_value, o => o.order.order.notional_value());
-         pb.add_price(fs.price, o => o.order.order.ui_price(), o => o.order.security);
-         pb.add_numeric(fs.qty_filled, o => o.order.order.filled_quantity());
-         pb.add_numeric(fs.avg_price, o => o.order.order.avg_price());
-         pb.add_numeric(fs.last_price, o => o.order.order.last_price());
-         pb.add_numeric(fs.piq, o => o.order.piq ?? uint.MaxValue);
-         return pb.to_predicate();
-      }
-   }
-}
+using bts.api;
+using bts.api.orderman;
+using bts.utils;
+
+using mbts;
+using mbts.spark;
+using mbts.spark.filters;
+using mbts.ui;
+using mbts.ui.utility;
+
+using ProtoBuf;
+
+using Spark.Api.Orders;
+
+using System;
+
+namespace bts.shell.orderbook {
+   [ProtoContract]
+   class FilterStates : IEquatable<FilterStates> {
+      [ProtoMember(1)]
+      public SecurityCriteria security_criteria;
+      [ProtoMember(2)]
+      public string order_key_regex;
+      [ProtoMember(3)]
+      public TimeFilterTuple time_created;
+      [ProtoMember(4)]
+      public string[] users;
+      [ProtoMember(5)]
+      public string[] accounts;
+      [ProtoMember(6)]
+      public Venue[] exchanges;
+      [ProtoMember(7)]
+      public TimeInForce[] tifs;
+      //[ProtoMember(8)]
+      //public CustomOrderDefinition.CustomOneofCase[] order_types;
+      [ProtoMember(23)]
+      public AlgoID[] order_types;
+      [ProtoMember(24)]
+      public AlgoID[] root_algo_types;
+      [ProtoMember(9)]
+      public Side[] sides;
+      [ProtoMember(10)]
+      public DoubleMinMaxState qty;
+      [ProtoMember(26)]
+      public DoubleMinMaxState notional_value;
+      [ProtoMember(11)]
+      public DoubleMinMaxState price;
+      [ProtoMember(12)]
+      public DoubleMinMaxState qty_filled;
+      [ProtoMember(27)]
+      public DoubleMinMaxState filled_notional_value;
+      [ProtoMember(13)]
+      public DoubleMinMaxState avg_price;
+      [ProtoMember(14)]
+      public DoubleMinMaxState last_price;
+      [ProtoMember(15)]
+      public OrderStatus[] statuses;
+      [ProtoMember(16)]
+      public string exchange_message_regex;
+      [ProtoMember(17)]
+      public TimeFilterTuple last_change;
+      //[ProtoMember(18)]
+      //public string security_regex;
+      [ProtoMember(19)]
+      public api.orderman.OrderSubType[] order_sub_types;
+      [ProtoMember(20)]
+      public string[] symbols;
+      [ProtoMember(21)]
+      public string parent_key_regex;
+      [ProtoMember(22)]
+      public string attached_target_order_key_regex;
+      [ProtoMember(25)]
+      public UIntMinMaxState piq;
+
+      public bool Equals(FilterStates other) =>
+         other != null &&
+         security_criteria.safe_equals(other.security_criteria) &&
+         order_key_regex == other.order_key_regex &&
+         parent_key_regex == other.parent_key_regex &&
+         attached_target_order_key_regex == other.attached_target_order_key_regex &&
+         time_created.Equals(other.time_created) &&
+         EqualityComparer.safe_sequence_equals(users, other.users) &&
+         EqualityComparer.safe_sequence_equals(accounts, other.accounts) &&
+         EqualityComparer.safe_sequence_equals(exchanges, other.exchanges) &&
+         EqualityComparer.safe_sequence_equals(tifs, other.tifs) &&
+         EqualityComparer.safe_sequence_equals(order_types, other.order_types) &&
+         EqualityComparer.safe_sequence_equals(root_algo_types, other.root_algo_types) &&
+         EqualityComparer.safe_sequence_equals(sides, other.sides) &&
+         qty.safe_equals(other.qty) &&
+         notional_value.safe_equals(other.notional_value) &&
+         price.safe_equals(other.price) &&
+         qty_filled.safe_equals(other.qty_filled) &&
+         filled_notional_value.safe_equals(other.filled_notional_value) &&
+         avg_price.safe_equals(other.avg_price) &&
+         last_price.safe_equals(other.last_price) &&
+         EqualityComparer.safe_sequence_equals(statuses, other.statuses) &&
+         exchange_message_regex == other.exchange_message_regex &&
+         last_change.Equals(other.last_change) &&
+         EqualityComparer.safe_sequence_equals(order_sub_types, other.order_sub_types) &&
+         EqualityComparer.safe_sequence_equals(symbols, other.symbols) &&
+         piq.safe_equals(other.piq);
+
+      public override bool Equals(object obj) => Equals(obj as FilterStates);
+
+      public override int GetHashCode() =>
+         EqualityComparer.aggregate_hash(
+            security_criteria?.GetHashCode() ?? 0,
+            order_key_regex?.GetHashCode() ?? 0,
+            parent_key_regex?.GetHashCode() ?? 0,
+            attached_target_order_key_regex?.GetHashCode() ?? 0,
+            time_created.GetHashCode(),
+            EqualityComparer.safe_aggregate_hash(users),
+            EqualityComparer.safe_aggregate_hash(accounts),
+            EqualityComparer.safe_aggregate_hash(exchanges),
+            EqualityComparer.safe_aggregate_hash(tifs),
+            EqualityComparer.safe_aggregate_hash(order_types),
+            EqualityComparer.safe_aggregate_hash(root_algo_types),
+            EqualityComparer.safe_aggregate_hash(sides),
+            qty?.GetHashCode() ?? 0,
+            notional_value?.GetHashCode() ?? 0,
+            price?.GetHashCode() ?? 0,
+            qty_filled?.GetHashCode() ?? 0,
+            filled_notional_value?.GetHashCode() ?? 0,
+            avg_price?.GetHashCode() ?? 0,
+            last_price?.GetHashCode() ?? 0,
+            EqualityComparer.safe_aggregate_hash(statuses),
+            exchange_message_regex?.GetHashCode() ?? 0,
+            last_change.GetHashCode(),
+            EqualityComparer.safe_aggregate_hash(order_sub_types),
+            EqualityComparer.safe_aggregate_hash(symbols),
+            piq?.GetHashCode() ?? 0);
+   }
+
+   static class FilterStatesExtensions {
+      public static Func<OrderRecordTupleWithRoot, bool> build_predicate(this FilterStates fs) {
+         var pb = new ColumnPredicateBuilder<OrderRecordTupleWithRoot>();
+         // security
+         pb.add_security_criteria(fs.security_criteria, o => o.order.security);
+         // regex
+         pb.add_regex(fs.order_key_regex, o => o.order.order.Key.ToString());
+         pb.add_regex(fs.exchange_message_regex, o => o.order.order.State.LastMsg);
+         pb.add_regex(fs.attached_target_order_key_regex, o => o.order.order.attached_target_order_key().ToString());
+         pb.add_regex(fs.parent_key_regex, o => o.order.order.ParentKey.ToString());
+         // time
+         pb.add_time_filter(fs.time_created, o => o.order.order.created());
+         pb.add_time_filter(fs.last_change, o => o.order.order.last_change());
+         // discrete values
+         pb.add_discrete_values(fs.users, o => o.order.order.user());
+         pb.add_discrete_values(fs.accounts, o => o.order.order.account());
+         pb.add_discrete_values(fs.exchanges, o => o.order.security?.Exchange ?? Venue.Unset);
+         pb.add_discrete_values(fs.tifs, o => o.order.order.time_in_force());
+         pb.add_discrete_values(fs.order_types, o => AlgoID.from_custom_def(o.order.order.Def.CustomDef));
+         pb.add_discrete_values(
+            Array.ConvertAll(fs.root_algo_types, a => (AlgoID?)a),
+            o => o.root.algo.HasValue
+               ? AlgoID.from_algo_key(o.root.algo.Value.key)
+               : null);
+         pb.add_discrete_values(fs.order_sub_types, o => o.order.order.sub_type());
+         pb.add_discrete_values(fs.sides, o => o.order.order.side());
+         pb.add_discrete_values(fs.statuses, o => o.order.order.status());
+         pb.add_discrete_values(fs.symbols, o => o.order.security?.Symbol);
+         // numeric
+         pb.add_numeric(fs.qty, o => o.order.order.quantity());
+         pb.add_numeric(fs.notional_value, o => o.notional_value);
+         pb.add_price(fs.price, o => o.order.order.ui_price(), o => o.order.security);
+         pb.add_numeric(fs.qty_filled, o => o.order.order.filled_quantity());
+         pb.add_numeric(fs.filled_notional_value, o => o.filled_notional_value);
+         pb.add_numeric(fs.avg_price, o => o.order.order.avg_price());
+         pb.add_numeric(fs.last_price, o => o.order.order.last_price());
+         pb.add_numeric(fs.piq, o => o.order.piq ?? uint.MaxValue);
+         return pb.to_predicate();
+      }
+   }
+}

src/client/spark/Modules/Trading/OrderBook/Settings/OrderBookGridSettingsManager.cs

@@ -29,7 +29,7 @@ namespace bts.shell.orderbook {
       static OrderBookGridSettingsManager() {
          // make font-weight immutable for all columns (the font-weight rule is hard-coded: Regular for root-orders, Light for all others)
          // TODO: Remove the immutable font-weight flags when cell animation is ready
-         var col_settings_flags = EnumHelper.get_values<Columns>().ToDictionary(
+         var col_settings_flags = Enum.GetValuesAsUnderlyingType<Columns>().Cast<Columns>().ToDictionary(
             c => c.ToString(), c => GridColumnSettingsFeatureFlags.ImmutableFontWeight);
          // make font-color immutable for Side, Size, and Filled columns (the font-color rule is hard-coded: MarketData.bid for Buy orders, MarketData.ask for Sells)
          // TODO: Remove the immutable font-color flags when cell animation is ready

src/client/spark/Modules/Trading/OrderBook/Settings/OrderBookSettings.cs

@@ -1,271 +1,277 @@
-using bts.api.orderman;
-using bts.shell.fills;
-
-using mbts;
-using mbts.ui;
-using mbts.ui.controls;
-using mbts.ui.settings;
-
-using ProtoBuf;
-
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Reactive.Linq;
-using System.Windows;
-
-using Columns = mbts.spark.OrderBookGridView.ColumnKeys;
-using GridSettings = mbts.ui.settings.GridSettings;
-
-namespace bts.shell.orderbook {
-   using ColHeader = mbts.ui.controls.DIYGrid.DefaultColumnHeaders;
-   using ColWidth = mbts.ui.controls.DIYGrid.DefaultColumnWidths;
-
-   [ProtoContract]
-   class OrderBookStartupData {
-      const bool
-         _default_show_right_panel = true,
-         _default_show_order_params = true;
-      const double
-         _default_right_panel_width = 400,
-         _default_order_params_height = 250,
-         _default_fills_height = 300,
-         _default_ladder_height = 350;
-      [ProtoMember(16)]
-      OrderBookRightPanelSettings _right_panel;
-      // ALREADY USED TAGS
-      // [ProtoMember(5)]
-      // public readonly List<SortingCriteria> sort_criteria;
-
-      public OrderBookRightPanelSettings right_panel => _right_panel ?? (_right_panel = new OrderBookRightPanelSettings());
-      /// TODO: remove properties below, and redirect callers to <see cref="right_panel"/>
-      // right panel (host)
-      public bool show_right_panel { get => right_panel.show; set => right_panel.show = value; }
-      public double right_panel_width { get => right_panel.width; set => right_panel.width = value; }
-      // order params
-      public bool show_order_params { get => right_panel.stack.show_order_params; set => right_panel.stack.show_order_params = value; }
-      public double order_params_height { get; set; }
-      // ladder
-      public bool show_ladder { get; set; }
-      public double ladder_height { get => right_panel.stack.ladder_height; set => right_panel.stack.ladder_height = value; }
-      // fills
-      public bool show_fills { get => right_panel.stack.show_fills; set => right_panel.stack.show_fills = value; }
-      public double fills_height { get => right_panel.stack.fills_height; set => right_panel.stack.fills_height = value; }
-
-      // filters
-      [ProtoMember(10)]
-      public FilterStates filters;
-      // grid
-      [ProtoMember(15)]
-      [Obsolete]
-      public GridSettings grid { get; set; }
-      // orderbook grid
-      [ProtoMember(17)]
-      public OrderBookGridSettings orderbook_grid { get; set; }
-      // fills settings
-      [ProtoMember(26)]
-      public OrderBookFillsGridSettings fills_settings { get; set; }
-      // predicate animations
-      [ProtoMember(20)]
-      [Obsolete]
-      List<OrderRecordTuplePredicateAnimations> _predicate_animations;
-      // use defaults
-      [ProtoMember(25)]
-      public bool use_defaults;
-      // menu display
-      [ProtoMember(27)]
-      public SparkMenuDisplaySettings menu_display { get; set; }
-
-      /// <summary>
-      /// Please use <see cref="Default"/> to get a new instance (the only reason the default constructor still exists is for ProtoBuf deserialization).
-      /// </summary>
-      [Obsolete]
-      public OrderBookStartupData() {
-         show_right_panel = _default_show_right_panel;
-         show_order_params = _default_show_order_params;
-         right_panel_width = _default_right_panel_width;
-         order_params_height = _default_order_params_height;
-         fills_height = _default_fills_height;
-         ladder_height = _default_ladder_height;
-      }
-
-      public OrderBookStartupData(FilterStates filters, OrderBookGridSettings orderbook_grid = default, bool show_right_panel = false, double right_panel_width = 0, double fills_height = 0, bool show_fills = false, bool use_defaults = false) {
-         this.filters = filters;
-         this.use_defaults = use_defaults;
-         this.show_right_panel = show_right_panel;
-         this.right_panel_width = right_panel_width;
-         this.fills_height = fills_height;
-         this.show_fills = show_fills;
-         this.orderbook_grid = orderbook_grid;
-#pragma warning disable CS0612 // Type or member is obsolete
-         _predicate_animations = new List<OrderRecordTuplePredicateAnimations>();
-         if (predicate_animations != null)
-            _predicate_animations.AddRange(predicate_animations);
-#pragma warning restore CS0612 // Type or member is obsolete
-      }
-
-#pragma warning disable CS0612 // Type or member is obsolete
-      [Obsolete]
-      public IReadOnlyList<OrderRecordTuplePredicateAnimations> predicate_animations => _predicate_animations ?? (_predicate_animations = new List<OrderRecordTuplePredicateAnimations>());
-      public OrderBookGridSettings grid_settings_wrapper() {
-         if (use_defaults)
-            return null;
-         if (orderbook_grid == null) {
-            if (grid == null)
-               grid = _default_general_grid;
-            orderbook_grid = new OrderBookGridSettings(grid.Clone(), _predicate_animations);
-         }
-         return orderbook_grid;
-      }
-#pragma warning restore CS0612 // Type or member is obsolete
-
-      public static OrderBookStartupData Default =>
-        new OrderBookStartupData(
-           new FilterStates { statuses = new[] { OrderStatus.Working } },
-           DefaultGrid,
-           _default_show_right_panel,
-           _default_right_panel_width,
-           _default_fills_height,
-           use_defaults: true) {
-           show_order_params = _default_show_order_params,
-           order_params_height = _default_order_params_height,
-           fills_settings = DefaultFillsGrid
-        };
-
-      public static OrderBookGridSettings DefaultGrid => new OrderBookGridSettings(_default_general_grid) {
-         algo_tree_display_mode = AlgoTreeDisplayMode.RootAndLeafNodes
-      };
-
-      public static OrderBookFillsGridSettings DefaultFillsGrid {
-         get {
-            var default_fills = FillsSettings.Default();
-            var rv = new OrderBookFillsGridSettings {
-               sorting_criteria = default_fills.sorting_criteria.ToList(),
-               filters = default_fills.filters,
-               general = FillsSettings.MiniGridSettings
-            };
-            return rv;
-         }
-      }
-      static GridSettings _default_general_grid => GridSettings.Default.with(DefaultColumns.standard, DefaultColumns.sorting_criteria);
-      public static OrderBookGridSettings default_mini_grid => new OrderBookGridSettings(GridSettings.Default.with(DefaultColumns.mini, DefaultColumns.sorting_criteria)) {
-         algo_tree_display_mode = AlgoTreeDisplayMode.RootAndLeafNodes
-      };
-
-      static class DefaultColumns {
-         // standard
-         public static GridColumnSettings security => new GridColumnSettings(Columns.Security.ToString(), DIYGrid.DefaultColumnHeaders.Security, width: DIYGrid.DefaultColumnWidths.Security);
-         public static GridColumnSettings symbol => new GridColumnSettings(Columns.Symbol.ToString(), DIYGrid.DefaultColumnHeaders.Symbol, width: DIYGrid.DefaultColumnWidths.Symbol, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings time_created => new GridColumnSettings(Columns.Time.ToString(), "Time", width: DIYGrid.DefaultColumnWidths.Time, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings last_change => new GridColumnSettings(Columns.LastChange.ToString(), "Last Change", width: DIYGrid.DefaultColumnWidths.Time, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings user => new GridColumnSettings(Columns.User.ToString(), DIYGrid.DefaultColumnHeaders.User, width: DIYGrid.DefaultColumnWidths.User, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings account => new GridColumnSettings(Columns.Account.ToString(), DIYGrid.DefaultColumnHeaders.Account, width: DIYGrid.DefaultColumnWidths.Account, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings exchange => new GridColumnSettings(Columns.Exchange.ToString(), DIYGrid.DefaultColumnHeaders.Exchange, width: DIYGrid.DefaultColumnWidths.Exchange, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings time_in_force => new GridColumnSettings(Columns.TimeInForce.ToString(), DIYGrid.DefaultColumnHeaders.TimeInForce, width: DIYGrid.DefaultColumnWidths.TimeInForce);
-         public static GridColumnSettings order_type => new GridColumnSettings(Columns.OrderType.ToString(), DIYGrid.DefaultColumnHeaders.OrderType, width: DIYGrid.DefaultColumnWidths.OrderType);
-         public static GridColumnSettings root_algo_type => new GridColumnSettings(Columns.RootAlgoType.ToString(), DIYGrid.DefaultColumnHeaders.RootAlgoType, width: DIYGrid.DefaultColumnWidths.OrderType);
-         public static GridColumnSettings sub_type => new GridColumnSettings(Columns.SubType.ToString(), "Sub Type", width: 80, horizontal_alignment: HorizontalAlignment.Left);
-
-         public static GridColumnSettings side => new(
-            Columns.Side.ToString(), ColHeader.Side,
-            width: ColWidth.Side,
-            horizontal_alignment: HorizontalAlignment.Left);
-
-         public static GridColumnSettings quantity => new GridColumnSettings(Columns.Size.ToString(), "Qty", width: DIYGrid.DefaultColumnWidths.Qty, horizontal_alignment: HorizontalAlignment.Right);
-         public static GridColumnSettings notional_value => new GridColumnSettings(Columns.Size.ToString(), DIYGrid.DefaultColumnHeaders.NotionalValue, width: DIYGrid.DefaultColumnWidths.NotionalValue, horizontal_alignment: HorizontalAlignment.Right);
-         public static GridColumnSettings price => new GridColumnSettings(Columns.Price.ToString(), DIYGrid.DefaultColumnHeaders.Price, width: DIYGrid.DefaultColumnWidths.Price, horizontal_alignment: HorizontalAlignment.Right);
-
-         public static GridColumnSettings filled_quantity => new(
-            Columns.Filled.ToString(),
-            ColHeader.FilledQuantity,
-            width: ColWidth.Filled,
-            horizontal_alignment: HorizontalAlignment.Right);
-
-         public static GridColumnSettings avg_price => new(
-            Columns.AvgFilled.ToString(),
-            ColHeader.AvgFilled,
-            width: ColWidth.AveragePrice,
-            horizontal_alignment: HorizontalAlignment.Right);
-
-         public static GridColumnSettings last_price => new GridColumnSettings(Columns.LastPrice.ToString(), "Last Filled", width: DIYGrid.DefaultColumnWidths.LastPrice, horizontal_alignment: HorizontalAlignment.Right);
-         public static GridColumnSettings status => new GridColumnSettings(Columns.Status.ToString(), "Status", width: 80, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings last_message => new GridColumnSettings(Columns.LastMessage.ToString(), "Last Message", width: DIYGrid.DefaultColumnWidths.LastMessage, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings security_key => new GridColumnSettings(Columns.SecurityKey.ToString(), DIYGrid.DefaultColumnHeaders.SecurityKey, is_visible: false, width: DIYGrid.DefaultColumnWidths.SecurityKey, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings order_key => new GridColumnSettings(Columns.OrderKey.ToString(), DIYGrid.DefaultColumnHeaders.OrderKey, width: DIYGrid.DefaultColumnWidths.OrderKey, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings parent_key => new GridColumnSettings(Columns.ParentKey.ToString(), "Parent Key", width: DIYGrid.DefaultColumnWidths.ParentKey, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings attached_target_order_key => new GridColumnSettings(Columns.AttachedTargetOrderKey.ToString(), DIYGrid.DefaultColumnHeaders.AttachedTargetOrderKey, width: DIYGrid.DefaultColumnWidths.ParentKey, horizontal_alignment: HorizontalAlignment.Left);
-         public static GridColumnSettings piq => new GridColumnSettings(Columns.Piq.ToString(), "PIQ", width: DIYGrid.DefaultColumnWidths.Qty, horizontal_alignment: HorizontalAlignment.Right);
-         // editable
-         public static GridColumnSettings cancel => new GridColumnSettings(Columns.Cancel.ToString(), DIYGrid.DefaultColumnHeaders.Cancel, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.Cancel);
-         public static GridColumnSettings attach_detach => new GridColumnSettings(Columns.Attach.ToString(), DIYGrid.DefaultColumnHeaders.AttachDetach, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.AttachDetach);
-         public static GridColumnSettings update => new GridColumnSettings(Columns.Update.ToString(), DIYGrid.DefaultColumnHeaders.Update, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.Update);
-         public static GridColumnSettings edit_quantity => new GridColumnSettings(Columns.EditableQty.ToString(), DIYGrid.DefaultColumnHeaders.Qty, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.EditableSize);
-         public static GridColumnSettings edit_price => new GridColumnSettings(Columns.EditablePrice.ToString(), DIYGrid.DefaultColumnHeaders.Price, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.EditablePrice);
-         public static GridColumnSettings commit => new GridColumnSettings(Columns.Commit.ToString(), width: DIYGrid.DefaultColumnWidths.MiniOrderBook.Commit);
-
-         public static IEnumerable<SortingCriteria> sorting_criteria {
-            get {
-               yield return new SortingCriteria(time_created.id, false);
-            }
-         }
-
-         public static IEnumerable<GridColumnSettings> standard {
-            get {
-               yield return security;
-               yield return symbol;
-               yield return time_created;
-               yield return last_change;
-               yield return user;
-               yield return account;
-               yield return exchange;
-               yield return time_in_force;
-               yield return order_type;
-               yield return root_algo_type;
-               yield return sub_type;
-               yield return side;
-               yield return quantity;
-               yield return price;
-               yield return piq;
-               yield return filled_quantity;
-               yield return avg_price;
-               yield return last_price;
-               yield return status;
-               yield return last_message;
-               yield return security_key;
-               yield return order_key;
-               yield return parent_key;
-               yield return attached_target_order_key;
-            }
-         }
-
-         public static IEnumerable<GridColumnSettings> editable {
-            get {
-               yield return cancel;
-               yield return update;
-               yield return edit_quantity;
-               yield return edit_price;
-               yield return commit;
-               yield return attach_detach;
-            }
-         }
-
-         private static HashSet<GridColumnSettings> _mini_mode_columns_to_hide = new HashSet<GridColumnSettings> {
-               symbol, last_change, exchange, sub_type, quantity, price, avg_price, last_price, status, last_message, security_key, order_key, parent_key, attached_target_order_key
-            };
-
-         public static IEnumerable<GridColumnSettings> mini {
-            get {
-               foreach (var col_setting in editable)
-                  yield return col_setting;
-               foreach (var col_setting in standard) {
-                  if (_mini_mode_columns_to_hide.Contains(col_setting)) {
-                     yield return col_setting.with(is_visible: false);
-                  } else {
-                     yield return col_setting;
-                  }
-               }
-            }
-         }
-      }
-   }
-}
+using bts.api.orderman;
+using bts.shell.fills;
+
+using mbts;
+using mbts.ui;
+using mbts.ui.controls;
+using mbts.ui.settings;
+
+using ProtoBuf;
+
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Reactive.Linq;
+using System.Windows;
+
+using Columns = mbts.spark.OrderBookGridView.ColumnKeys;
+using GridSettings = mbts.ui.settings.GridSettings;
+
+namespace bts.shell.orderbook {
+   using ColHeader = mbts.ui.controls.DIYGrid.DefaultColumnHeaders;
+   using ColWidth = mbts.ui.controls.DIYGrid.DefaultColumnWidths;
+
+   [ProtoContract]
+   class OrderBookStartupData {
+      const bool
+         _default_show_right_panel = true,
+         _default_show_order_params = true;
+      const double
+         _default_right_panel_width = 400,
+         _default_order_params_height = 250,
+         _default_fills_height = 300,
+         _default_ladder_height = 350;
+      [ProtoMember(16)]
+      OrderBookRightPanelSettings _right_panel;
+      // ALREADY USED TAGS
+      // [ProtoMember(5)]
+      // public readonly List<SortingCriteria> sort_criteria;
+
+      public OrderBookRightPanelSettings right_panel => _right_panel ?? (_right_panel = new OrderBookRightPanelSettings());
+      /// TODO: remove properties below, and redirect callers to <see cref="right_panel"/>
+      // right panel (host)
+      public bool show_right_panel { get => right_panel.show; set => right_panel.show = value; }
+      public double right_panel_width { get => right_panel.width; set => right_panel.width = value; }
+      // order params
+      public bool show_order_params { get => right_panel.stack.show_order_params; set => right_panel.stack.show_order_params = value; }
+      public double order_params_height { get; set; }
+      // ladder
+      public bool show_ladder { get; set; }
+      public double ladder_height { get => right_panel.stack.ladder_height; set => right_panel.stack.ladder_height = value; }
+      // fills
+      public bool show_fills { get => right_panel.stack.show_fills; set => right_panel.stack.show_fills = value; }
+      public double fills_height { get => right_panel.stack.fills_height; set => right_panel.stack.fills_height = value; }
+
+      // filters
+      [ProtoMember(10)]
+      public FilterStates filters;
+      // grid
+      [ProtoMember(15)]
+      [Obsolete]
+      public GridSettings grid { get; set; }
+      // orderbook grid
+      [ProtoMember(17)]
+      public OrderBookGridSettings orderbook_grid { get; set; }
+      // fills settings
+      [ProtoMember(26)]
+      public OrderBookFillsGridSettings fills_settings { get; set; }
+      // predicate animations
+      [ProtoMember(20)]
+      [Obsolete]
+      List<OrderRecordTuplePredicateAnimations> _predicate_animations;
+      // use defaults
+      [ProtoMember(25)]
+      public bool use_defaults;
+      // menu display
+      [ProtoMember(27)]
+      public SparkMenuDisplaySettings menu_display { get; set; }
+
+      /// <summary>
+      /// Please use <see cref="Default"/> to get a new instance (the only reason the default constructor still exists is for ProtoBuf deserialization).
+      /// </summary>
+      [Obsolete]
+      public OrderBookStartupData() {
+         show_right_panel = _default_show_right_panel;
+         show_order_params = _default_show_order_params;
+         right_panel_width = _default_right_panel_width;
+         order_params_height = _default_order_params_height;
+         fills_height = _default_fills_height;
+         ladder_height = _default_ladder_height;
+      }
+
+      public OrderBookStartupData(FilterStates filters, OrderBookGridSettings orderbook_grid = default, bool show_right_panel = false, double right_panel_width = 0, double fills_height = 0, bool show_fills = false, bool use_defaults = false) {
+         this.filters = filters;
+         this.use_defaults = use_defaults;
+         this.show_right_panel = show_right_panel;
+         this.right_panel_width = right_panel_width;
+         this.fills_height = fills_height;
+         this.show_fills = show_fills;
+         this.orderbook_grid = orderbook_grid;
+#pragma warning disable CS0612 // Type or member is obsolete
+         _predicate_animations = new List<OrderRecordTuplePredicateAnimations>();
+         if (predicate_animations != null)
+            _predicate_animations.AddRange(predicate_animations);
+#pragma warning restore CS0612 // Type or member is obsolete
+      }
+
+#pragma warning disable CS0612 // Type or member is obsolete
+      [Obsolete]
+      public IReadOnlyList<OrderRecordTuplePredicateAnimations> predicate_animations => _predicate_animations ?? (_predicate_animations = new List<OrderRecordTuplePredicateAnimations>());
+      public OrderBookGridSettings grid_settings_wrapper() {
+         if (use_defaults)
+            return null;
+         if (orderbook_grid == null) {
+            if (grid == null)
+               grid = _default_general_grid;
+            orderbook_grid = new OrderBookGridSettings(grid.Clone(), _predicate_animations);
+         }
+         return orderbook_grid;
+      }
+#pragma warning restore CS0612 // Type or member is obsolete
+
+      public static OrderBookStartupData Default =>
+        new OrderBookStartupData(
+           new FilterStates { statuses = new[] { OrderStatus.Working } },
+           DefaultGrid,
+           _default_show_right_panel,
+           _default_right_panel_width,
+           _default_fills_height,
+           use_defaults: true) {
+           show_order_params = _default_show_order_params,
+           order_params_height = _default_order_params_height,
+           fills_settings = DefaultFillsGrid
+        };
+
+      public static OrderBookGridSettings DefaultGrid => new OrderBookGridSettings(_default_general_grid) {
+         algo_tree_display_mode = AlgoTreeDisplayMode.RootAndLeafNodes
+      };
+
+      public static OrderBookFillsGridSettings DefaultFillsGrid {
+         get {
+            var default_fills = FillsSettings.Default();
+            var rv = new OrderBookFillsGridSettings {
+               sorting_criteria = default_fills.sorting_criteria.ToList(),
+               filters = default_fills.filters,
+               general = FillsSettings.MiniGridSettings
+            };
+            return rv;
+         }
+      }
+      static GridSettings _default_general_grid => GridSettings.Default.with(DefaultColumns.standard, DefaultColumns.sorting_criteria);
+      public static OrderBookGridSettings default_mini_grid => new OrderBookGridSettings(GridSettings.Default.with(DefaultColumns.mini, DefaultColumns.sorting_criteria)) {
+         algo_tree_display_mode = AlgoTreeDisplayMode.RootAndLeafNodes
+      };
+
+      static class DefaultColumns {
+         // standard
+         public static GridColumnSettings security => new GridColumnSettings(Columns.Security.ToString(), DIYGrid.DefaultColumnHeaders.Security, width: DIYGrid.DefaultColumnWidths.Security);
+         public static GridColumnSettings symbol => new GridColumnSettings(Columns.Symbol.ToString(), DIYGrid.DefaultColumnHeaders.Symbol, width: DIYGrid.DefaultColumnWidths.Symbol, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings time_created => new GridColumnSettings(Columns.Time.ToString(), "Time", width: DIYGrid.DefaultColumnWidths.Time, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings last_change => new GridColumnSettings(Columns.LastChange.ToString(), "Last Change", width: DIYGrid.DefaultColumnWidths.Time, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings user => new GridColumnSettings(Columns.User.ToString(), DIYGrid.DefaultColumnHeaders.User, width: DIYGrid.DefaultColumnWidths.User, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings account => new GridColumnSettings(Columns.Account.ToString(), DIYGrid.DefaultColumnHeaders.Account, width: DIYGrid.DefaultColumnWidths.Account, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings exchange => new GridColumnSettings(Columns.Exchange.ToString(), DIYGrid.DefaultColumnHeaders.Exchange, width: DIYGrid.DefaultColumnWidths.Exchange, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings time_in_force => new GridColumnSettings(Columns.TimeInForce.ToString(), DIYGrid.DefaultColumnHeaders.TimeInForce, width: DIYGrid.DefaultColumnWidths.TimeInForce);
+         public static GridColumnSettings order_type => new GridColumnSettings(Columns.OrderType.ToString(), DIYGrid.DefaultColumnHeaders.OrderType, width: DIYGrid.DefaultColumnWidths.OrderType);
+         public static GridColumnSettings root_algo_type => new GridColumnSettings(Columns.RootAlgoType.ToString(), DIYGrid.DefaultColumnHeaders.RootAlgoType, width: DIYGrid.DefaultColumnWidths.OrderType);
+         public static GridColumnSettings sub_type => new GridColumnSettings(Columns.SubType.ToString(), "Sub Type", width: 80, horizontal_alignment: HorizontalAlignment.Left);
+
+         public static GridColumnSettings side => new(
+            Columns.Side.ToString(), ColHeader.Side,
+            width: ColWidth.Side,
+            horizontal_alignment: HorizontalAlignment.Left);
+
+         public static GridColumnSettings quantity => new GridColumnSettings(Columns.Size.ToString(), "Qty", width: DIYGrid.DefaultColumnWidths.Qty, horizontal_alignment: HorizontalAlignment.Right);
+         public static GridColumnSettings notional_value => new GridColumnSettings(Columns.NotionalValue.ToString(), DIYGrid.DefaultColumnHeaders.NotionalValue, width: DIYGrid.DefaultColumnWidths.NotionalValue, horizontal_alignment: HorizontalAlignment.Right);
+         public static GridColumnSettings price => new GridColumnSettings(Columns.Price.ToString(), DIYGrid.DefaultColumnHeaders.Price, width: DIYGrid.DefaultColumnWidths.Price, horizontal_alignment: HorizontalAlignment.Right);
+
+         public static GridColumnSettings filled_quantity => new(
+            Columns.Filled.ToString(),
+            ColHeader.FilledQuantity,
+            width: ColWidth.Filled,
+            horizontal_alignment: HorizontalAlignment.Right);
+
+         public static GridColumnSettings filled_notional_value => new(
+            Columns.FilledNotionalValue.ToString(),
+            ColHeader.FilledNotionalValue,
+            width: ColWidth.FilledNotionalValue,
+            horizontal_alignment: HorizontalAlignment.Right);
+
+         public static GridColumnSettings avg_price => new(
+            Columns.AvgFilled.ToString(),
+            ColHeader.AvgFilled,
+            width: ColWidth.AveragePrice,
+            horizontal_alignment: HorizontalAlignment.Right);
+
+         public static GridColumnSettings last_price => new GridColumnSettings(Columns.LastPrice.ToString(), "Last Filled", width: DIYGrid.DefaultColumnWidths.LastPrice, horizontal_alignment: HorizontalAlignment.Right);
+         public static GridColumnSettings status => new GridColumnSettings(Columns.Status.ToString(), "Status", width: 80, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings last_message => new GridColumnSettings(Columns.LastMessage.ToString(), "Last Message", width: DIYGrid.DefaultColumnWidths.LastMessage, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings security_key => new GridColumnSettings(Columns.SecurityKey.ToString(), DIYGrid.DefaultColumnHeaders.SecurityKey, is_visible: false, width: DIYGrid.DefaultColumnWidths.SecurityKey, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings order_key => new GridColumnSettings(Columns.OrderKey.ToString(), DIYGrid.DefaultColumnHeaders.OrderKey, width: DIYGrid.DefaultColumnWidths.OrderKey, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings parent_key => new GridColumnSettings(Columns.ParentKey.ToString(), "Parent Key", width: DIYGrid.DefaultColumnWidths.ParentKey, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings attached_target_order_key => new GridColumnSettings(Columns.AttachedTargetOrderKey.ToString(), DIYGrid.DefaultColumnHeaders.AttachedTargetOrderKey, width: DIYGrid.DefaultColumnWidths.ParentKey, horizontal_alignment: HorizontalAlignment.Left);
+         public static GridColumnSettings piq => new GridColumnSettings(Columns.Piq.ToString(), "PIQ", width: DIYGrid.DefaultColumnWidths.Qty, horizontal_alignment: HorizontalAlignment.Right);
+         // editable
+         public static GridColumnSettings cancel => new GridColumnSettings(Columns.Cancel.ToString(), DIYGrid.DefaultColumnHeaders.Cancel, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.Cancel);
+         public static GridColumnSettings attach_detach => new GridColumnSettings(Columns.Attach.ToString(), DIYGrid.DefaultColumnHeaders.AttachDetach, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.AttachDetach);
+         public static GridColumnSettings update => new GridColumnSettings(Columns.Update.ToString(), DIYGrid.DefaultColumnHeaders.Update, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.Update);
+         public static GridColumnSettings edit_quantity => new GridColumnSettings(Columns.EditableQty.ToString(), DIYGrid.DefaultColumnHeaders.Qty, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.EditableSize);
+         public static GridColumnSettings edit_price => new GridColumnSettings(Columns.EditablePrice.ToString(), DIYGrid.DefaultColumnHeaders.Price, width: DIYGrid.DefaultColumnWidths.MiniOrderBook.EditablePrice);
+         public static GridColumnSettings commit => new GridColumnSettings(Columns.Commit.ToString(), width: DIYGrid.DefaultColumnWidths.MiniOrderBook.Commit);
+
+         public static IEnumerable<SortingCriteria> sorting_criteria {
+            get {
+               yield return new SortingCriteria(time_created.id, false);
+            }
+         }
+
+         public static IEnumerable<GridColumnSettings> standard {
+            get {
+               yield return security;
+               yield return symbol;
+               yield return time_created;
+               yield return last_change;
+               yield return user;
+               yield return account;
+               yield return exchange;
+               yield return time_in_force;
+               yield return order_type;
+               yield return root_algo_type;
+               yield return sub_type;
+               yield return side;
+               yield return quantity;
+               yield return price;
+               yield return piq;
+               yield return filled_quantity;
+               yield return avg_price;
+               yield return last_price;
+               yield return status;
+               yield return last_message;
+               yield return security_key;
+               yield return order_key;
+               yield return parent_key;
+               yield return attached_target_order_key;
+            }
+         }
+
+         public static IEnumerable<GridColumnSettings> editable {
+            get {
+               yield return cancel;
+               yield return update;
+               yield return edit_quantity;
+               yield return edit_price;
+               yield return commit;
+               yield return attach_detach;
+            }
+         }
+
+         private static HashSet<GridColumnSettings> _mini_mode_columns_to_hide = new HashSet<GridColumnSettings> {
+               symbol, last_change, exchange, sub_type, quantity, price, avg_price, last_price, status, last_message, security_key, order_key, parent_key, attached_target_order_key
+            };
+
+         public static IEnumerable<GridColumnSettings> mini {
+            get {
+               foreach (var col_setting in editable)
+                  yield return col_setting;
+               foreach (var col_setting in standard) {
+                  if (_mini_mode_columns_to_hide.Contains(col_setting)) {
+                     yield return col_setting.with(is_visible: false);
+                  } else {
+                     yield return col_setting;
+                  }
+               }
+            }
+         }
+      }
+   }
+}

src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml.cs

@@ -1,108 +1,109 @@
-using bts.api.orderman;
-
-using mbts.ui;
-using mbts.ui.controls;
-using mbts.ui.converters;
-
-using System.Windows;
-using System.Windows.Controls;
-using System.Windows.Data;
-using System.Windows.Media;
-
-namespace mbts.spark {
-   internal partial class OrderBookGridView : DIYGrid {
-      public const string
-         SubTypeFilterTemplateKey = "SubTypeFilterTemplate",
-         ExpandCollapseToggleStyleKey = "ExpandCollapseToggleStyle",
-         RowStyleKey = "RowStyle",
-         RowTemplateKey = "RowTemplateKey",
-         CVRowStyleKey = "CVRowStyle",
-         CVRowTemplateKey = "CVRowTemplateKey";
-
-      // IMPORTANT: these enums are stored as strings in the general-purpose GridColumnSettings proto, and are used to ID THE COLUMNS!
-      // Do NOT RENAME them!  However, if you must, be sure to write an IShellWindowMigrationRule or something to account for backwards compatability.
-      public enum ColumnKeys {
-         Security = 1,
-         Symbol = 1 << 1,
-         Time = 1 << 2,
-         LastChange = 1 << 3,
-         User = 1 << 4,
-         Account = 1 << 5,
-         Exchange = 1 << 6,
-         TimeInForce = 1 << 7,
-         OrderType = 1 << 8,
-         SubType = 1 << 9,
-         Side = 1 << 10,
-         Size = 1 << 11,
-         Price = 1 << 12,
-         Filled = 1 << 13,
-         AvgFilled = 1 << 14,
-         LastPrice = 1 << 15,
-         Status = 1 << 16,
-         LastMessage = 1 << 17,
-         SecurityKey = 1 << 18,
-         OrderKey = 1 << 19,
-         ParentKey = 1 << 20,
-         AttachedTargetOrderKey = 1 << 21,
-         Cancel = 1 << 22,
-         EditableQty = 1 << 23,
-         EditablePrice = 1 << 24,
-         Attach = 1 << 25,
-         Detach = 1 << 26,
-         Update = 1 << 27,
-         Commit = 1 << 28,
-         RootAlgoType = 1 << 29,
-         Piq = 1 << 30,
-         Check = 1 << 31,
-         NotionalValue = 1 & (1 << 1),
-      }
-
-      public OrderBookGridView() {
-         InitializeComponent();
-         var row_template_factory = new FrameworkElementFactory(typeof(OrderBookRowView));
-         row_template_factory.SetValue(OrderBookRowView.BackgroundProperty, RowBackgroundHelper.row_background_binding);
-         RowTemplate = new DataTemplate { VisualTree = row_template_factory };
-      }
-
-      static class RowBackgroundHelper {
-         public static readonly BindingBase row_background_binding;
-
-         static RowBackgroundHelper() {
-            var bg_binding = new MultiBinding();
-            bg_binding.Bindings.Add(new Binding(nameof(OrderBookRowVM.status)));
-            bg_binding.Bindings.Add(new Binding(nameof(ListBoxItem.IsSelected)) { RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(ListBoxItem), 1) });
-            double overlay_opacity = config.Configuration.get<bts.config.OrderBookOptions>().StatusColorOpacityWhenSelected;
-            if (overlay_opacity > 0.1 && overlay_opacity < 0.9) {
-               bg_binding.Converter = ValueConverter.create<OrderStatus, bool, Brush>((status, is_selected) => {
-                  var color = _status_color(status);
-                  return color.HasValue ? new SolidColorBrush(color.Value) { Opacity = is_selected ? overlay_opacity : 1.0 } : null;
-               });
-            } else {
-               bg_binding.Converter = ValueConverter.create<OrderStatus, bool, Brush>((status, is_selected) => {
-                  if (is_selected)
-                     return null;
-                  var color = _status_color(status);
-                  return color.HasValue ? new SolidColorBrush(color.Value) : null;
-               });
-            }
-            row_background_binding = bg_binding;
-         }
-
-         static Color? _status_color(OrderStatus status) {
-            switch (status) {
-               case OrderStatus.Canceled: return BTSColors.Orders.canceled_order_background;
-               case OrderStatus.Completed: return BTSColors.Orders.completed_order_background;
-               case OrderStatus.Disconnected:
-               case OrderStatus.RejectedBySpark:
-               case OrderStatus.Error:
-                  return BTSColors.Orders.error_order_background;
-               default: return null;
-            }
-         }
-      }
-   }
-
-   class OrderBookRowView : DIYGrid.HighPerformanceRow<OrderBookRowVM> {
-      public OrderBookRowView() : base() { }
-   }
-}
+using bts.api.orderman;
+
+using mbts.ui;
+using mbts.ui.controls;
+using mbts.ui.converters;
+
+using System.Windows;
+using System.Windows.Controls;
+using System.Windows.Data;
+using System.Windows.Media;
+
+namespace mbts.spark {
+   internal partial class OrderBookGridView : DIYGrid {
+      public const string
+         SubTypeFilterTemplateKey = "SubTypeFilterTemplate",
+         ExpandCollapseToggleStyleKey = "ExpandCollapseToggleStyle",
+         RowStyleKey = "RowStyle",
+         RowTemplateKey = "RowTemplateKey",
+         CVRowStyleKey = "CVRowStyle",
+         CVRowTemplateKey = "CVRowTemplateKey";
+
+      // IMPORTANT: these enums are stored as strings in the general-purpose GridColumnSettings proto, and are used to ID THE COLUMNS!
+      // Do NOT RENAME them!  However, if you must, be sure to write an IShellWindowMigrationRule or something to account for backwards compatability.
+      public enum ColumnKeys : long {
+         Security = 1,
+         Symbol = 1 << 1,
+         Time = 1 << 2,
+         LastChange = 1 << 3,
+         User = 1 << 4,
+         Account = 1 << 5,
+         Exchange = 1 << 6,
+         TimeInForce = 1 << 7,
+         OrderType = 1 << 8,
+         SubType = 1 << 9,
+         Side = 1 << 10,
+         Size = 1 << 11,
+         Price = 1 << 12,
+         Filled = 1 << 13,
+         AvgFilled = 1 << 14,
+         LastPrice = 1 << 15,
+         Status = 1 << 16,
+         LastMessage = 1 << 17,
+         SecurityKey = 1 << 18,
+         OrderKey = 1 << 19,
+         ParentKey = 1 << 20,
+         AttachedTargetOrderKey = 1 << 21,
+         Cancel = 1 << 22,
+         EditableQty = 1 << 23,
+         EditablePrice = 1 << 24,
+         Attach = 1 << 25,
+         Detach = 1 << 26,
+         Update = 1 << 27,
+         Commit = 1 << 28,
+         RootAlgoType = 1 << 29,
+         Piq = 1 << 30,
+         Check = 1 << 31,
+         NotionalValue = 1L << 32,
+         FilledNotionalValue = 1L << 33,
+      }
+
+      public OrderBookGridView() {
+         InitializeComponent();
+         var row_template_factory = new FrameworkElementFactory(typeof(OrderBookRowView));
+         row_template_factory.SetValue(OrderBookRowView.BackgroundProperty, RowBackgroundHelper.row_background_binding);
+         RowTemplate = new DataTemplate { VisualTree = row_template_factory };
+      }
+
+      static class RowBackgroundHelper {
+         public static readonly BindingBase row_background_binding;
+
+         static RowBackgroundHelper() {
+            var bg_binding = new MultiBinding();
+            bg_binding.Bindings.Add(new Binding(nameof(OrderBookRowVM.status)));
+            bg_binding.Bindings.Add(new Binding(nameof(ListBoxItem.IsSelected)) { RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(ListBoxItem), 1) });
+            double overlay_opacity = config.Configuration.get<bts.config.OrderBookOptions>().StatusColorOpacityWhenSelected;
+            if (overlay_opacity > 0.1 && overlay_opacity < 0.9) {
+               bg_binding.Converter = ValueConverter.create<OrderStatus, bool, Brush>((status, is_selected) => {
+                  var color = _status_color(status);
+                  return color.HasValue ? new SolidColorBrush(color.Value) { Opacity = is_selected ? overlay_opacity : 1.0 } : null;
+               });
+            } else {
+               bg_binding.Converter = ValueConverter.create<OrderStatus, bool, Brush>((status, is_selected) => {
+                  if (is_selected)
+                     return null;
+                  var color = _status_color(status);
+                  return color.HasValue ? new SolidColorBrush(color.Value) : null;
+               });
+            }
+            row_background_binding = bg_binding;
+         }
+
+         static Color? _status_color(OrderStatus status) {
+            switch (status) {
+               case OrderStatus.Canceled: return BTSColors.Orders.canceled_order_background;
+               case OrderStatus.Completed: return BTSColors.Orders.completed_order_background;
+               case OrderStatus.Disconnected:
+               case OrderStatus.RejectedBySpark:
+               case OrderStatus.Error:
+                  return BTSColors.Orders.error_order_background;
+               default: return null;
+            }
+         }
+      }
+   }
+
+   class OrderBookRowView : DIYGrid.HighPerformanceRow<OrderBookRowVM> {
+      public OrderBookRowView() : base() { }
+   }
+}

src/client/spark/Modules/Trading/PNL/VM/PNLRowVM.cs

@@ -1,378 +1,380 @@
-using bts.api;
-using bts.utils;
-
-using mbts;
-using mbts.spark;
-using mbts.ui;
-using mbts.ui.shell;
-
-using Spark.Core.Collections;
-using Spark.Core.Data;
-
-using System;
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.Linq;
-using System.Reactive.Linq;
-
-using ColumnKeys = bts.shell.pnl.PNLView.Columns;
-using PNLKey = bts.AccountSecurityKey;
-
-namespace bts.shell.pnl {
-   class PNLRowVM : DisposableViewModelBase, IEquatable<PNLRowVM> {
-      public static readonly IComparer<PNLRowVM> key_comparer = Comparer<PNLKey>.Default.wrap<PNLKey, PNLRowVM>(r => r.key);
-      static readonly Func<bool, string> _fmt_has_day_trades = hdt => hdt ? "Yes" : "No";
-      //
-      readonly PNLCellIndexBuilder<PNLRowData> _cell_map = new PNLCellIndexBuilder<PNLRowData>();
-      readonly PNLCellEmbeddedAnimationModel<PNLRowData> _animator;
-      readonly ISecurityMetadataStore _sec_meta_store;
-      bool _refresh_normalized_data = true, _is_selected;
-      PNLNormalizedData _normalized_data;
-      api.domain.TickDisplaySettingsImmutable? _quantity_display_backing;
-
-      public PNLRowVM(
-         PNLRowData data,
-         ISecurityMetadataStore sec_meta_store,
-         ImmutableDictionary<ColumnKeys, PNLCellAppearance> default_appearances,
-         IReadOnlyList<IPNLAnimationTrigger<PNLRowData>> triggers,
-         Func<double, string> fmt_fill_price,
-         Func<double, string> fmt_market_price) {
-         //
-         this.data = data;
-         _sec_meta_store = sec_meta_store;
-         _animator = new PNLCellEmbeddedAnimationModel<PNLRowData>(default_appearances, triggers);
-         _animator.on_row(data);
-         pnl_price = _cell_map.add_price_double(ColumnKeys.PNLPrice, d => d.pnl_price);
-         account_cell = _cell_map.add(ColumnKeys.Account, d => d.account);
-         security_type_cell = _cell_map.add(ColumnKeys.SecurityType, d => d.security?.ContractCase ?? Security.ContractOneofCase.None);
-         exchange_cell = _cell_map.add(ColumnKeys.Exchange, d => d.security?.Exchange ?? Venue.Unset);
-         expiration_cell = _cell_map.add(
-            ColumnKeys.Expiration,
-            d => d.expiration,
-            e => SecurityFormatter.format_expiration(e));
-         symbol_cell = _cell_map.add(ColumnKeys.Symbol, d => d.symbol);
-         security_cell = _cell_map.add(
-            ColumnKeys.Security,
-            d => d.security,
-            null,
-            EqualityComparer<SecurityImmutable?>.Default,
-            Comparer<SecurityImmutable?>.Default);
-         security_key = _cell_map.add(ColumnKeys.SecurityKey, d => d.key.security_id);
-         cpp = _cell_map.add(ColumnKeys.CPP, d => d.effective_cpp);
-         // sod
-         sod_pnl = _cell_map.add_pnl_double(ColumnKeys.SODPNL, d => d.sod_pnl);
-         sod_net_pos = _cell_map.add_net_pos(
-            ColumnKeys.SODNetPos, d => d.display_sod_net_pos, fmt_qty);
-         sod_long_pos = _cell_map.add_long_pos(
-            ColumnKeys.SODLongPos, d => d.display_sod_long_pos, fmt_qty);
-         sod_long_avg_price = _cell_map.add_long_price(ColumnKeys.SODLongAvgPrice, d => d.sod_long_avg_price);
-         sod_short_pos = _cell_map.add_short_pos(
-            ColumnKeys.SODShortPos, d => d.display_sod_short_pos, fmt_qty);
-         sod_short_avg_price = _cell_map.add_short_price(ColumnKeys.SODShortAvgPrice, d => d.sod_short_avg_price);
-         sod_delta = _cell_map.add_pnl_double(ColumnKeys.SODDelta, d => d.sod_delta, fmt_greek);
-         sod_gamma = _cell_map.add_pnl_double(ColumnKeys.SODGamma, d => d.sod_gamma, fmt_greek);
-         sod_vega = _cell_map.add_pnl_double(ColumnKeys.SODVega, d => d.sod_vega, fmt_greek);
-         sod_theta = _cell_map.add_pnl_double(ColumnKeys.SODTheta, d => d.sod_theta, fmt_greek);
-
-         // day
-         day_pnl = _cell_map.add_pnl_double(ColumnKeys.DayPNL, d => d.day_pnl);
-         day_net_pos = _cell_map.add_net_pos(
-            ColumnKeys.DayNetPos, d => d.display_day_net_pos, fmt_qty);
-         day_long_pos = _cell_map.add_long_pos(
-            ColumnKeys.DayLongPos, d => d.display_day_long_pos, fmt_qty);
-         day_long_avg_price = _cell_map.add_long_price(ColumnKeys.DayLongAvgPrice, d => d.day_long_avg_price);
-         day_short_pos = _cell_map.add_short_pos(
-            ColumnKeys.DayShortPos, d => d.display_day_short_pos, fmt_qty);
-         day_short_avg_price = _cell_map.add_short_price(ColumnKeys.DayShortAvgPrice, d => d.day_short_avg_price);
-         day_delta = _cell_map.add_pnl_double(ColumnKeys.DayDelta, d => d.day_delta, fmt_greek);
-         day_gamma = _cell_map.add_pnl_double(ColumnKeys.DayGamma, d => d.day_gamma, fmt_greek);
-         day_vega = _cell_map.add_pnl_double(ColumnKeys.DayVega, d => d.day_vega, fmt_greek);
-         day_theta = _cell_map.add_pnl_double(ColumnKeys.DayTheta, d => d.day_theta, fmt_greek);
-         has_day_trades = _cell_map.add(ColumnKeys.HasDayTrades, d => d.has_day_trades, _fmt_has_day_trades);
-         // working
-         working_net_pos = _cell_map.add_net_pos(
-            ColumnKeys.WorkingNetPos, d => d.display_working_net_pos, fmt_qty);
-         var qty_display = _sec_meta_store.get_qty_display(security);
-         working_long_pos = _cell_map.add_working_long(
-            ColumnKeys.WorkingLongPos,
-            d => d.working.long_data,
-            d => d.bid_price,
-            qty_display);
-         working_long_avg_price = _cell_map.add_long_price(ColumnKeys.WorkingLongAvgPrice, d => d.working_long_avg_price);
-         working_short_pos = _cell_map.add_working_short(
-            ColumnKeys.WorkingShortPos, r => r.working.short_data, r => r.ask_price, qty_display);
-         working_short_avg_price = _cell_map.add_short_price(ColumnKeys.WorkingShortAvgPrice, d => d.working_short_avg_price);
-         // total
-         total_pnl = _cell_map.add_pnl_double(ColumnKeys.TotalPNL, d => d.total_pnl);
-         total_net_pos = _cell_map.add_net_pos(
-            ColumnKeys.TotalNetPos, d => d.display_total_net_pos, fmt_qty);
-         total_long_pos = _cell_map.add_long_pos(
-            ColumnKeys.TotalLongPos, d => d.display_total_long_pos, fmt_qty);
-         total_long_avg_price = _cell_map.add_long_price(ColumnKeys.TotalLongAvgPrice, d => d.total_long_avg_price);
-         total_short_pos = _cell_map.add_short_pos(
-            ColumnKeys.TotalShortPos, d => d.display_total_short_pos, fmt_qty);
-         total_short_avg_price = _cell_map.add_short_price(ColumnKeys.TotalShortAvgPrice, d => d.total_short_avg_price);
-         total_delta = _cell_map.add_pnl_double(
-            ColumnKeys.TotalDelta, d => d.total_delta, fmt_greek);
-         total_gamma = _cell_map.add_pnl_double(
-            ColumnKeys.TotalGamma, d => d.total_gamma, fmt_greek);
-         total_vega = _cell_map.add_pnl_double(ColumnKeys.TotalVega, d => d.total_vega, fmt_greek);
-         total_theta = _cell_map.add_pnl_double(
-            ColumnKeys.TotalTheta, d => d.total_theta, fmt_greek);
-
-         // market
-         bid_price = _cell_map.add_price_double(ColumnKeys.BidPrice, d => d.bid_price);
-         ask_price = _cell_map.add_price_double(ColumnKeys.AskPrice, d => d.ask_price);
-         mid_price = _cell_map.add_price_double(ColumnKeys.MidPrice, d => d.mid_price);
-         last_price = _cell_map.add_price_double(ColumnKeys.LastPrice, d => d.last_price);
-         settlement_price = _cell_map.add_price_double(ColumnKeys.SettlementPrice, d => d.settlement_price);
-
-         _set_price_formatting_delegates(fmt_fill_price, fmt_market_price);
-         _cell_map.on_row(data);
-         _cell_map.set_appearances(_animator.cell_appearances);
-         _dispose = _cell_map.animation_model.OnDispatcher().Subscribe(new_animations => {
-            animations = new_animations.Select(kv => new mbts.ui.spark.CellAnimation(kv.Key.column, kv.Key.type, kv.Value.color.to_brush())).ToList();
-            RaisePropertyChanged(nameof(animations));
-         });
-
-         static string fmt_greek(double v) =>
-            v.is_nan() ? "-" : v.ToString("#,0.00");
-
-         string fmt_qty(double v) =>
-            quantity_display.format(v);
-      }
-
-      // events
-      public event Action<PNLNormalizedData> updated;
-      public event Action<bool> is_selected_changed;
-
-      // data
-      public PNLKey key => data.key;
-      public PNLRowData data { get; private set; }
-      public PNLNormalizedData normalized_data {
-         get {
-            if (_refresh_normalized_data) {
-               _refresh_normalized_data = false;
-               // Only count outrights (spread positions should be normalized into outrights)
-               var sec_type = security?.ContractCase ?? Security.ContractOneofCase.None;
-               var (
-                  sod_long,
-                  sod_short,
-                  sod_delta,
-                  sod_gamma,
-                  sod_vega,
-                  sod_theta,
-                  day_long,
-                  day_short,
-                  day_delta,
-                  day_gamma,
-                  day_vega,
-                  day_theta) = sec_type switch {
-                  Security.ContractOneofCase.Future or Security.ContractOneofCase.Option => (
-                     data.sod.long_pos.round_to_decimal(),
-                     data.sod.short_pos.round_to_decimal(),
-                     data.sod.delta.round_to_decimal(),
-                     data.sod.gamma.round_to_decimal(),
-                     data.sod.vega.round_to_decimal(),
-                     data.sod.theta.round_to_decimal(),
-                     data.day.long_pos.round_to_decimal(),
-                     data.day.short_pos.round_to_decimal(),
-                     data.day.delta.round_to_decimal(),
-                     data.day.gamma.round_to_decimal(),
-                     data.day.vega.round_to_decimal(),
-                     data.day.theta.round_to_decimal()),
-                  _ => (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
-               };
-
-               var working_long = data.working_long_pos.round_to_decimal();
-               var working_short = data.working_short_pos.round_to_decimal();
-
-               var nd = new PNLNormalizedData() {
-                  // sod
-                  sod_pnl = sod_pnl.value.round_to_decimal(),
-                  sod_long_pos = sod_long,
-                  sod_short_pos = sod_short,
-                  sod_delta = sod_delta,
-                  sod_gamma = sod_gamma,
-                  sod_vega = sod_vega,
-                  sod_theta = sod_theta,
-                  display_sod_long_pos = sod_long,
-                  display_sod_short_pos = sod_short,
-
-                  // day
-                  day_pnl = day_pnl.value.round_to_decimal(),
-                  day_long_pos = day_long,
-                  day_short_pos = day_short,
-                  day_delta = day_delta,
-                  day_gamma = day_gamma,
-                  day_vega = day_vega,
-                  day_theta = day_theta,
-                  display_day_long_pos = day_long,
-                  display_day_short_pos = day_short,
-
-                  // working
-                  working_long_pos = working_long,
-                  working_short_pos = working_short,
-                  display_working_long_pos = working_long,
-                  display_working_short_pos = working_short
-               };
-               if (_normalized_data != nd) {
-                  _normalized_data = nd;
-                  updated?.Invoke(nd);
-               }
-            }
-            return _normalized_data;
-         }
-      }
-      // security
-      public string account_name => data.account_name;
-      public Venue exchange => security?.Exchange ?? Venue.Unset;
-      public string symbol => security.symbol_or_default();
-      public DateTime expiration => data.expiration;
-      public Security.ContractOneofCase security_type => security?.ContractCase ?? Security.ContractOneofCase.None;
-      public SecurityImmutable? security => data.security;
-      // cells
-      public PNLCellVM<PNLRowData, AccountTuple> account_cell { get; }
-      public PNLCellVM<PNLRowData, Venue> exchange_cell { get; }
-      public PNLCellVM<PNLRowData, DateTime> expiration_cell { get; }
-      public PNLCellVM<PNLRowData, string> symbol_cell { get; }
-      public PNLCellVM<PNLRowData, Security.ContractOneofCase> security_type_cell { get; }
-      public PNLCellVM<PNLRowData, SecurityImmutable?> security_cell { get; }
-      public PNLCellVM<PNLRowData, uint> security_key { get; }
-      public PNLCellVM<PNLRowData, double> cpp { get; }
-      // sod
-      public PNLCellVM<PNLRowData, double> sod_pnl { get; }
-      public PNLCellVM<PNLRowData, double> sod_net_pos { get; }
-      public PNLCellVM<PNLRowData, double> sod_long_pos { get; }
-      public PNLCellVM<PNLRowData, double> sod_long_avg_price { get; }
-      public PNLCellVM<PNLRowData, double> sod_short_pos { get; }
-      public PNLCellVM<PNLRowData, double> sod_short_avg_price { get; }
-      public PNLCellVM<PNLRowData, double> sod_delta { get; }
-      public PNLCellVM<PNLRowData, double> sod_gamma { get; }
-      public PNLCellVM<PNLRowData, double> sod_vega { get; }
-      public PNLCellVM<PNLRowData, double> sod_theta { get; }
-
-      // day
-      public PNLCellVM<PNLRowData, double> day_pnl { get; }
-      public PNLCellVM<PNLRowData, double> day_net_pos { get; }
-      public PNLCellVM<PNLRowData, double> day_long_pos { get; }
-      public PNLCellVM<PNLRowData, double> day_long_avg_price { get; }
-      public PNLCellVM<PNLRowData, double> day_short_pos { get; }
-      public PNLCellVM<PNLRowData, double> day_short_avg_price { get; }
-      public PNLCellVM<PNLRowData, double> day_delta { get; }
-      public PNLCellVM<PNLRowData, double> day_gamma { get; }
-      public PNLCellVM<PNLRowData, double> day_vega { get; }
-      public PNLCellVM<PNLRowData, double> day_theta { get; }
-      public PNLCellVM<PNLRowData, bool> has_day_trades { get; }
-      // working
-      public PNLCellVM<PNLRowData, double> working_net_pos { get; }
-      public PNLCellVM<PNLRowData, WorkingOrderSideData> working_long_pos { get; }
-      public PNLCellVM<PNLRowData, double> working_long_avg_price { get; }
-      public PNLCellVM<PNLRowData, WorkingOrderSideData> working_short_pos { get; }
-      public PNLCellVM<PNLRowData, double> working_short_avg_price { get; }
-      // total
-      public PNLCellVM<PNLRowData, double> total_pnl { get; }
-      public PNLCellVM<PNLRowData, double> total_net_pos { get; }
-      public PNLCellVM<PNLRowData, double> total_long_pos { get; }
-      public PNLCellVM<PNLRowData, double> total_long_avg_price { get; }
-      public PNLCellVM<PNLRowData, double> total_short_pos { get; }
-      public PNLCellVM<PNLRowData, double> total_short_avg_price { get; }
-      public PNLCellVM<PNLRowData, double> total_delta { get; }
-      public PNLCellVM<PNLRowData, double> total_gamma { get; }
-      public PNLCellVM<PNLRowData, double> total_vega { get; }
-      public PNLCellVM<PNLRowData, double> total_theta { get; }
-
-      // (market)
-      public PNLCellVM<PNLRowData, double> bid_price { get; }
-      public PNLCellVM<PNLRowData, double> mid_price { get; }
-      public PNLCellVM<PNLRowData, double> ask_price { get; }
-      public PNLCellVM<PNLRowData, double> last_price { get; }
-      public PNLCellVM<PNLRowData, double> settlement_price { get; }
-      public PNLCellVM<PNLRowData, double> pnl_price { get; }
-
-      // display
-      public api.domain.TickDisplaySettingsImmutable quantity_display {
-         get {
-            if (_quantity_display_backing.HasValue) {
-               return _quantity_display_backing.Value;
-            }
-            if (security.HasValue) {
-               _quantity_display_backing = _sec_meta_store.get_qty_display(security.Value);
-            }
-            return _quantity_display_backing ??= Security.Defaults.quantity_display_settingsi;
-         }
-      }
-
-      public IList<mbts.ui.spark.CellAnimation> animations { get; private set; }
-
-      public bool is_selected {
-         get => _is_selected;
-         set {
-            if (Set(ref _is_selected, value))
-               is_selected_changed?.Invoke(value);
-         }
-      }
-
-      IEnumerable<PNLCellVM<PNLRowData, double>> _market_price_cells {
-         get {
-            yield return pnl_price;
-            yield return last_price;
-            yield return bid_price;
-            yield return mid_price;
-            yield return ask_price;
-            yield return settlement_price;
-         }
-      }
-
-      // includes sod, day, total, and working avg price columns
-      IEnumerable<PNLCellVM<PNLRowData, double>> _fill_price_cells {
-         get {
-            // sod
-            yield return sod_long_avg_price;
-            yield return sod_short_avg_price;
-            // day
-            yield return day_long_avg_price;
-            yield return day_short_avg_price;
-            // total
-            yield return total_long_avg_price;
-            yield return total_short_avg_price;
-            // working
-            yield return working_long_avg_price;
-            yield return working_short_avg_price;
-         }
-      }
-
-      public void update(PNLRowData data) {
-         _quantity_display_backing = null;
-         _refresh_normalized_data = true;
-         this.data = data;
-         _cell_map.on_row(data);
-         _animator.on_row(data);
-         _cell_map.set_appearances(_animator.cell_appearances);
-      }
-
-      public void on_settings(ImmutableDictionary<ColumnKeys, PNLCellAppearance> defaults, IReadOnlyList<IPNLAnimationTrigger<PNLRowData>> triggers, Func<double, string> fmt_fill_price, Func<double, string> fmt_market_price) {
-         _animator.on_settings(defaults, triggers);
-         _cell_map.set_appearances(_animator.cell_appearances);
-         _set_price_formatting_delegates(fmt_fill_price, fmt_market_price);
-      }
-
-      public bool Equals(PNLRowVM other) =>
-         other != null && key == other.key;
-
-      public override int GetHashCode() =>
-         key.GetHashCode();
-
-      public override string ToString() =>
-         $"account: {account_name} exchange: {exchange} symbol: {symbol} security: {security} buy_quantity: {day_long_pos} sell_quantity: {day_short_pos} pnl: {total_pnl}";
-
-      void _set_price_formatting_delegates(Func<double, string> fmt_fill_price, Func<double, string> fmt_market_price) {
-         foreach (var cell in _fill_price_cells) {
-            cell.format = fmt_fill_price;
-         }
-         foreach (var cell in _market_price_cells) {
-            cell.format = fmt_market_price;
-         }
-      }
-   }
-}
+using bts.api;
+using bts.utils;
+
+using mbts;
+using mbts.spark;
+using mbts.ui;
+using mbts.ui.shell;
+
+using Spark.Core.Collections;
+using Spark.Core.Data;
+
+using System;
+using System.Collections.Generic;
+using System.Collections.Immutable;
+using System.Linq;
+using System.Reactive.Linq;
+
+using ColumnKeys = bts.shell.pnl.PNLView.Columns;
+using PNLKey = bts.AccountSecurityKey;
+
+namespace bts.shell.pnl {
+   class PNLRowVM : DisposableViewModelBase, IEquatable<PNLRowVM> {
+      public static readonly IComparer<PNLRowVM> key_comparer = Comparer<PNLKey>.Default.wrap<PNLKey, PNLRowVM>(r => r.key);
+      static readonly Func<bool, string> _fmt_has_day_trades = hdt => hdt ? "Yes" : "No";
+      //
+      readonly PNLCellIndexBuilder<PNLRowData> _cell_map = new PNLCellIndexBuilder<PNLRowData>();
+      readonly PNLCellEmbeddedAnimationModel<PNLRowData> _animator;
+      readonly ISecurityMetadataStore _sec_meta_store;
+      bool _refresh_normalized_data = true, _is_selected;
+      PNLNormalizedData _normalized_data;
+      api.domain.TickDisplaySettingsImmutable? _quantity_display_backing;
+
+      public PNLRowVM(
+         PNLRowData data,
+         ISecurityMetadataStore sec_meta_store,
+         ImmutableDictionary<ColumnKeys, PNLCellAppearance> default_appearances,
+         IReadOnlyList<IPNLAnimationTrigger<PNLRowData>> triggers,
+         Func<double, string> fmt_fill_price,
+         Func<double, string> fmt_market_price) {
+         //
+         this.data = data;
+         _sec_meta_store = sec_meta_store;
+         _animator = new PNLCellEmbeddedAnimationModel<PNLRowData>(default_appearances, triggers);
+         _animator.on_row(data);
+         pnl_price = _cell_map.add_price_double(ColumnKeys.PNLPrice, d => d.pnl_price);
+         account_cell = _cell_map.add(ColumnKeys.Account, d => d.account);
+         security_type_cell = _cell_map.add(ColumnKeys.SecurityType, d => d.security?.ContractCase ?? Security.ContractOneofCase.None);
+         exchange_cell = _cell_map.add(ColumnKeys.Exchange, d => d.security?.Exchange ?? Venue.Unset);
+         expiration_cell = _cell_map.add(
+            ColumnKeys.Expiration,
+            d => d.expiration,
+            e => e == DateTime.MinValue
+               ? "N/A"
+               : SecurityFormatter.format_expiration(e));
+         symbol_cell = _cell_map.add(ColumnKeys.Symbol, d => d.symbol);
+         security_cell = _cell_map.add(
+            ColumnKeys.Security,
+            d => d.security,
+            null,
+            EqualityComparer<SecurityImmutable?>.Default,
+            Comparer<SecurityImmutable?>.Default);
+         security_key = _cell_map.add(ColumnKeys.SecurityKey, d => d.key.security_id);
+         cpp = _cell_map.add(ColumnKeys.CPP, d => d.effective_cpp);
+         // sod
+         sod_pnl = _cell_map.add_pnl_double(ColumnKeys.SODPNL, d => d.sod_pnl);
+         sod_net_pos = _cell_map.add_net_pos(
+            ColumnKeys.SODNetPos, d => d.display_sod_net_pos, fmt_qty);
+         sod_long_pos = _cell_map.add_long_pos(
+            ColumnKeys.SODLongPos, d => d.display_sod_long_pos, fmt_qty);
+         sod_long_avg_price = _cell_map.add_long_price(ColumnKeys.SODLongAvgPrice, d => d.sod_long_avg_price);
+         sod_short_pos = _cell_map.add_short_pos(
+            ColumnKeys.SODShortPos, d => d.display_sod_short_pos, fmt_qty);
+         sod_short_avg_price = _cell_map.add_short_price(ColumnKeys.SODShortAvgPrice, d => d.sod_short_avg_price);
+         sod_delta = _cell_map.add_pnl_double(ColumnKeys.SODDelta, d => d.sod_delta, fmt_greek);
+         sod_gamma = _cell_map.add_pnl_double(ColumnKeys.SODGamma, d => d.sod_gamma, fmt_greek);
+         sod_vega = _cell_map.add_pnl_double(ColumnKeys.SODVega, d => d.sod_vega, fmt_greek);
+         sod_theta = _cell_map.add_pnl_double(ColumnKeys.SODTheta, d => d.sod_theta, fmt_greek);
+
+         // day
+         day_pnl = _cell_map.add_pnl_double(ColumnKeys.DayPNL, d => d.day_pnl);
+         day_net_pos = _cell_map.add_net_pos(
+            ColumnKeys.DayNetPos, d => d.display_day_net_pos, fmt_qty);
+         day_long_pos = _cell_map.add_long_pos(
+            ColumnKeys.DayLongPos, d => d.display_day_long_pos, fmt_qty);
+         day_long_avg_price = _cell_map.add_long_price(ColumnKeys.DayLongAvgPrice, d => d.day_long_avg_price);
+         day_short_pos = _cell_map.add_short_pos(
+            ColumnKeys.DayShortPos, d => d.display_day_short_pos, fmt_qty);
+         day_short_avg_price = _cell_map.add_short_price(ColumnKeys.DayShortAvgPrice, d => d.day_short_avg_price);
+         day_delta = _cell_map.add_pnl_double(ColumnKeys.DayDelta, d => d.day_delta, fmt_greek);
+         day_gamma = _cell_map.add_pnl_double(ColumnKeys.DayGamma, d => d.day_gamma, fmt_greek);
+         day_vega = _cell_map.add_pnl_double(ColumnKeys.DayVega, d => d.day_vega, fmt_greek);
+         day_theta = _cell_map.add_pnl_double(ColumnKeys.DayTheta, d => d.day_theta, fmt_greek);
+         has_day_trades = _cell_map.add(ColumnKeys.HasDayTrades, d => d.has_day_trades, _fmt_has_day_trades);
+         // working
+         working_net_pos = _cell_map.add_net_pos(
+            ColumnKeys.WorkingNetPos, d => d.display_working_net_pos, fmt_qty);
+         var qty_display = _sec_meta_store.get_qty_display(security);
+         working_long_pos = _cell_map.add_working_long(
+            ColumnKeys.WorkingLongPos,
+            d => d.working.long_data,
+            d => d.bid_price,
+            qty_display);
+         working_long_avg_price = _cell_map.add_long_price(ColumnKeys.WorkingLongAvgPrice, d => d.working_long_avg_price);
+         working_short_pos = _cell_map.add_working_short(
+            ColumnKeys.WorkingShortPos, r => r.working.short_data, r => r.ask_price, qty_display);
+         working_short_avg_price = _cell_map.add_short_price(ColumnKeys.WorkingShortAvgPrice, d => d.working_short_avg_price);
+         // total
+         total_pnl = _cell_map.add_pnl_double(ColumnKeys.TotalPNL, d => d.total_pnl);
+         total_net_pos = _cell_map.add_net_pos(
+            ColumnKeys.TotalNetPos, d => d.display_total_net_pos, fmt_qty);
+         total_long_pos = _cell_map.add_long_pos(
+            ColumnKeys.TotalLongPos, d => d.display_total_long_pos, fmt_qty);
+         total_long_avg_price = _cell_map.add_long_price(ColumnKeys.TotalLongAvgPrice, d => d.total_long_avg_price);
+         total_short_pos = _cell_map.add_short_pos(
+            ColumnKeys.TotalShortPos, d => d.display_total_short_pos, fmt_qty);
+         total_short_avg_price = _cell_map.add_short_price(ColumnKeys.TotalShortAvgPrice, d => d.total_short_avg_price);
+         total_delta = _cell_map.add_pnl_double(
+            ColumnKeys.TotalDelta, d => d.total_delta, fmt_greek);
+         total_gamma = _cell_map.add_pnl_double(
+            ColumnKeys.TotalGamma, d => d.total_gamma, fmt_greek);
+         total_vega = _cell_map.add_pnl_double(ColumnKeys.TotalVega, d => d.total_vega, fmt_greek);
+         total_theta = _cell_map.add_pnl_double(
+            ColumnKeys.TotalTheta, d => d.total_theta, fmt_greek);
+
+         // market
+         bid_price = _cell_map.add_price_double(ColumnKeys.BidPrice, d => d.bid_price);
+         ask_price = _cell_map.add_price_double(ColumnKeys.AskPrice, d => d.ask_price);
+         mid_price = _cell_map.add_price_double(ColumnKeys.MidPrice, d => d.mid_price);
+         last_price = _cell_map.add_price_double(ColumnKeys.LastPrice, d => d.last_price);
+         settlement_price = _cell_map.add_price_double(ColumnKeys.SettlementPrice, d => d.settlement_price);
+
+         _set_price_formatting_delegates(fmt_fill_price, fmt_market_price);
+         _cell_map.on_row(data);
+         _cell_map.set_appearances(_animator.cell_appearances);
+         _dispose = _cell_map.animation_model.OnDispatcher().Subscribe(new_animations => {
+            animations = new_animations.Select(kv => new mbts.ui.spark.CellAnimation(kv.Key.column, kv.Key.type, kv.Value.color.to_brush())).ToList();
+            RaisePropertyChanged(nameof(animations));
+         });
+
+         static string fmt_greek(double v) =>
+            v.is_nan() ? "-" : v.ToString("#,0.00");
+
+         string fmt_qty(double v) =>
+            quantity_display.format(v);
+      }
+
+      // events
+      public event Action<PNLNormalizedData> updated;
+      public event Action<bool> is_selected_changed;
+
+      // data
+      public PNLKey key => data.key;
+      public PNLRowData data { get; private set; }
+      public PNLNormalizedData normalized_data {
+         get {
+            if (_refresh_normalized_data) {
+               _refresh_normalized_data = false;
+               // Only count outrights (spread positions should be normalized into outrights)
+               var sec_type = security?.ContractCase ?? Security.ContractOneofCase.None;
+               var (
+                  sod_long,
+                  sod_short,
+                  sod_delta,
+                  sod_gamma,
+                  sod_vega,
+                  sod_theta,
+                  day_long,
+                  day_short,
+                  day_delta,
+                  day_gamma,
+                  day_vega,
+                  day_theta) = sec_type switch {
+                  Security.ContractOneofCase.Future or Security.ContractOneofCase.Option => (
+                     data.sod.long_pos.round_to_decimal(),
+                     data.sod.short_pos.round_to_decimal(),
+                     data.sod.delta.round_to_decimal(),
+                     data.sod.gamma.round_to_decimal(),
+                     data.sod.vega.round_to_decimal(),
+                     data.sod.theta.round_to_decimal(),
+                     data.day.long_pos.round_to_decimal(),
+                     data.day.short_pos.round_to_decimal(),
+                     data.day.delta.round_to_decimal(),
+                     data.day.gamma.round_to_decimal(),
+                     data.day.vega.round_to_decimal(),
+                     data.day.theta.round_to_decimal()),
+                  _ => (0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)
+               };
+
+               var working_long = data.working_long_pos.round_to_decimal();
+               var working_short = data.working_short_pos.round_to_decimal();
+
+               var nd = new PNLNormalizedData() {
+                  // sod
+                  sod_pnl = sod_pnl.value.round_to_decimal(),
+                  sod_long_pos = sod_long,
+                  sod_short_pos = sod_short,
+                  sod_delta = sod_delta,
+                  sod_gamma = sod_gamma,
+                  sod_vega = sod_vega,
+                  sod_theta = sod_theta,
+                  display_sod_long_pos = sod_long,
+                  display_sod_short_pos = sod_short,
+
+                  // day
+                  day_pnl = day_pnl.value.round_to_decimal(),
+                  day_long_pos = day_long,
+                  day_short_pos = day_short,
+                  day_delta = day_delta,
+                  day_gamma = day_gamma,
+                  day_vega = day_vega,
+                  day_theta = day_theta,
+                  display_day_long_pos = day_long,
+                  display_day_short_pos = day_short,
+
+                  // working
+                  working_long_pos = working_long,
+                  working_short_pos = working_short,
+                  display_working_long_pos = working_long,
+                  display_working_short_pos = working_short
+               };
+               if (_normalized_data != nd) {
+                  _normalized_data = nd;
+                  updated?.Invoke(nd);
+               }
+            }
+            return _normalized_data;
+         }
+      }
+      // security
+      public string account_name => data.account_name;
+      public Venue exchange => security?.Exchange ?? Venue.Unset;
+      public string symbol => security.symbol_or_default();
+      public DateTime expiration => data.expiration;
+      public Security.ContractOneofCase security_type => security?.ContractCase ?? Security.ContractOneofCase.None;
+      public SecurityImmutable? security => data.security;
+      // cells
+      public PNLCellVM<PNLRowData, AccountTuple> account_cell { get; }
+      public PNLCellVM<PNLRowData, Venue> exchange_cell { get; }
+      public PNLCellVM<PNLRowData, DateTime> expiration_cell { get; }
+      public PNLCellVM<PNLRowData, string> symbol_cell { get; }
+      public PNLCellVM<PNLRowData, Security.ContractOneofCase> security_type_cell { get; }
+      public PNLCellVM<PNLRowData, SecurityImmutable?> security_cell { get; }
+      public PNLCellVM<PNLRowData, uint> security_key { get; }
+      public PNLCellVM<PNLRowData, double> cpp { get; }
+      // sod
+      public PNLCellVM<PNLRowData, double> sod_pnl { get; }
+      public PNLCellVM<PNLRowData, double> sod_net_pos { get; }
+      public PNLCellVM<PNLRowData, double> sod_long_pos { get; }
+      public PNLCellVM<PNLRowData, double> sod_long_avg_price { get; }
+      public PNLCellVM<PNLRowData, double> sod_short_pos { get; }
+      public PNLCellVM<PNLRowData, double> sod_short_avg_price { get; }
+      public PNLCellVM<PNLRowData, double> sod_delta { get; }
+      public PNLCellVM<PNLRowData, double> sod_gamma { get; }
+      public PNLCellVM<PNLRowData, double> sod_vega { get; }
+      public PNLCellVM<PNLRowData, double> sod_theta { get; }
+
+      // day
+      public PNLCellVM<PNLRowData, double> day_pnl { get; }
+      public PNLCellVM<PNLRowData, double> day_net_pos { get; }
+      public PNLCellVM<PNLRowData, double> day_long_pos { get; }
+      public PNLCellVM<PNLRowData, double> day_long_avg_price { get; }
+      public PNLCellVM<PNLRowData, double> day_short_pos { get; }
+      public PNLCellVM<PNLRowData, double> day_short_avg_price { get; }
+      public PNLCellVM<PNLRowData, double> day_delta { get; }
+      public PNLCellVM<PNLRowData, double> day_gamma { get; }
+      public PNLCellVM<PNLRowData, double> day_vega { get; }
+      public PNLCellVM<PNLRowData, double> day_theta { get; }
+      public PNLCellVM<PNLRowData, bool> has_day_trades { get; }
+      // working
+      public PNLCellVM<PNLRowData, double> working_net_pos { get; }
+      public PNLCellVM<PNLRowData, WorkingOrderSideData> working_long_pos { get; }
+      public PNLCellVM<PNLRowData, double> working_long_avg_price { get; }
+      public PNLCellVM<PNLRowData, WorkingOrderSideData> working_short_pos { get; }
+      public PNLCellVM<PNLRowData, double> working_short_avg_price { get; }
+      // total
+      public PNLCellVM<PNLRowData, double> total_pnl { get; }
+      public PNLCellVM<PNLRowData, double> total_net_pos { get; }
+      public PNLCellVM<PNLRowData, double> total_long_pos { get; }
+      public PNLCellVM<PNLRowData, double> total_long_avg_price { get; }
+      public PNLCellVM<PNLRowData, double> total_short_pos { get; }
+      public PNLCellVM<PNLRowData, double> total_short_avg_price { get; }
+      public PNLCellVM<PNLRowData, double> total_delta { get; }
+      public PNLCellVM<PNLRowData, double> total_gamma { get; }
+      public PNLCellVM<PNLRowData, double> total_vega { get; }
+      public PNLCellVM<PNLRowData, double> total_theta { get; }
+
+      // (market)
+      public PNLCellVM<PNLRowData, double> bid_price { get; }
+      public PNLCellVM<PNLRowData, double> mid_price { get; }
+      public PNLCellVM<PNLRowData, double> ask_price { get; }
+      public PNLCellVM<PNLRowData, double> last_price { get; }
+      public PNLCellVM<PNLRowData, double> settlement_price { get; }
+      public PNLCellVM<PNLRowData, double> pnl_price { get; }
+
+      // display
+      public api.domain.TickDisplaySettingsImmutable quantity_display {
+         get {
+            if (_quantity_display_backing.HasValue) {
+               return _quantity_display_backing.Value;
+            }
+            if (security.HasValue) {
+               _quantity_display_backing = _sec_meta_store.get_qty_display(security.Value);
+            }
+            return _quantity_display_backing ??= Security.Defaults.quantity_display_settingsi;
+         }
+      }
+
+      public IList<mbts.ui.spark.CellAnimation> animations { get; private set; }
+
+      public bool is_selected {
+         get => _is_selected;
+         set {
+            if (Set(ref _is_selected, value))
+               is_selected_changed?.Invoke(value);
+         }
+      }
+
+      IEnumerable<PNLCellVM<PNLRowData, double>> _market_price_cells {
+         get {
+            yield return pnl_price;
+            yield return last_price;
+            yield return bid_price;
+            yield return mid_price;
+            yield return ask_price;
+            yield return settlement_price;
+         }
+      }
+
+      // includes sod, day, total, and working avg price columns
+      IEnumerable<PNLCellVM<PNLRowData, double>> _fill_price_cells {
+         get {
+            // sod
+            yield return sod_long_avg_price;
+            yield return sod_short_avg_price;
+            // day
+            yield return day_long_avg_price;
+            yield return day_short_avg_price;
+            // total
+            yield return total_long_avg_price;
+            yield return total_short_avg_price;
+            // working
+            yield return working_long_avg_price;
+            yield return working_short_avg_price;
+         }
+      }
+
+      public void update(PNLRowData data) {
+         _quantity_display_backing = null;
+         _refresh_normalized_data = true;
+         this.data = data;
+         _cell_map.on_row(data);
+         _animator.on_row(data);
+         _cell_map.set_appearances(_animator.cell_appearances);
+      }
+
+      public void on_settings(ImmutableDictionary<ColumnKeys, PNLCellAppearance> defaults, IReadOnlyList<IPNLAnimationTrigger<PNLRowData>> triggers, Func<double, string> fmt_fill_price, Func<double, string> fmt_market_price) {
+         _animator.on_settings(defaults, triggers);
+         _cell_map.set_appearances(_animator.cell_appearances);
+         _set_price_formatting_delegates(fmt_fill_price, fmt_market_price);
+      }
+
+      public bool Equals(PNLRowVM other) =>
+         other != null && key == other.key;
+
+      public override int GetHashCode() =>
+         key.GetHashCode();
+
+      public override string ToString() =>
+         $"account: {account_name} exchange: {exchange} symbol: {symbol} security: {security} buy_quantity: {day_long_pos} sell_quantity: {day_short_pos} pnl: {total_pnl}";
+
+      void _set_price_formatting_delegates(Func<double, string> fmt_fill_price, Func<double, string> fmt_market_price) {
+         foreach (var cell in _fill_price_cells) {
+            cell.format = fmt_fill_price;
+         }
+         foreach (var cell in _market_price_cells) {
+            cell.format = fmt_market_price;
+         }
+      }
+   }
+}

src/client/spark/Modules/Trading/PNL/VM/PNLVM.cs

@@ -774,6 +774,17 @@ namespace bts.shell.pnl {
             case ColumnKeys.Account: filter.accounts = new[] { g.Name.ToString() }; break;
             case ColumnKeys.Symbol: filter.symbols = new[] { g.Name.ToString() }; break;
             case ColumnKeys.Exchange: filter.exchanges = new[] { (Venue)g.Name }; break;
+            case ColumnKeys.Expiration: {
+                  if (g.Name is DateTime exp) {
+                     if (filter.security_criteria is null) {
+                        filter.security_criteria = SecurityCriteria.from_expirations(exp);
+                     } else {
+                        filter.security_criteria.clauses = ArrayHelper.add(
+                           filter.security_criteria.clauses, SecurityCriteriaClause.from_expirations(exp));
+                     }
+                  }
+                  break;
+               }
             case ColumnKeys.Security:
                if (g.Name is SecurityImmutable sec)
                   filter.security_criteria = SecurityCriteria.from_securities(sec);

src/client/spark/NMSheets/INMSheetGridFacingData.cs

@@ -65,9 +65,9 @@ namespace BCG {
       public static NMSheetTheoBBOCross get_cross_state(double bid_price, double ask_price, double theo, double delta, bool is_call, double driver_tick_size, bool is_proximity_alert_enabled) {
          double abs_delta = Math.Abs(delta);
          abs_delta = abs_delta == 0 ? Double.Epsilon : abs_delta;
-         if (!Double.IsNaN(theo) && !Double.IsNaN(bid_price) && theo < bid_price)
+         if (!Double.IsNaN(theo) && !Double.IsNaN(bid_price) && (bid_price - theo) > _basic_crosss_eps)
             return new NMSheetTheoBBOCross(CrossState.bid_cross, 0);
-         else if (!Double.IsNaN(theo) && !Double.IsNaN(ask_price) && theo > ask_price)
+         else if (!Double.IsNaN(theo) && !Double.IsNaN(ask_price) && (theo - ask_price) > _basic_crosss_eps)
             return new NMSheetTheoBBOCross(CrossState.ask_cross, 0);
          else if (is_proximity_alert_enabled) {
             /// bool is passed to bypass doing the below
@@ -87,6 +87,7 @@ namespace BCG {
          return NMSheetTheoBBOCross.get_nulled_obj();
       }
 
+      private static double _basic_crosss_eps = 0.01;
       private static double _n_max_ticks = 100.0;
       private static NMSheetTheoBBOCross _nulled_obj = new NMSheetTheoBBOCross(CrossState.none, 0);
       public static NMSheetTheoBBOCross get_nulled_obj() { return _nulled_obj; }

src/client/spark/Orders/OrderTicket.xaml

@@ -1,161 +1,161 @@
-<Window
-  x:Class="mbts.ui.spark.OrderTicket"
-  xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
-  xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-  xmlns:msys="clr-namespace:bts.api;assembly=spark_api"
-  xmlns:u="clr-namespace:mbts.ui"
-  xmlns:cv="clr-namespace:mbts.ui.converters"
-  xmlns:usp="clr-namespace:mbts.ui.spark"
-  xmlns:sys="clr-namespace:System;assembly=mscorlib"
-  u:WindowStyle.SizeToContent="WidthAndHeight"
-  u:WindowStyle.TitleContent="{Binding bbo, Mode=OneWay}"
-  Style="{StaticResource BTSWindowTitleTemplate}"
->
-  <Window.Resources>
-    <ResourceDictionary>
-      <ResourceDictionary.MergedDictionaries>
-        <ResourceDictionary Source="/view/Resources/Converters.xaml"/>
-      </ResourceDictionary.MergedDictionaries>
-      <sys:Double x:Key="HorizontalSpacing">8.0</sys:Double>
-      <sys:Double x:Key="VerticalSpacing">4.0</sys:Double>
-      <sys:Double x:Key="ButtonHeight">22.0</sys:Double>
-      <Style x:Key="SellButton" TargetType="Button" BasedOn="{StaticResource {x:Type Button}}">
-         <Setter Property="Background" Value="{u:BTSColor MarketData.ask}" />
-         <Setter Property="Foreground" Value="White" />
-         <Setter Property="MinHeight" Value="40" />
-         <Setter Property="FontWeight" Value="Bold" />
-         <Setter Property="HorizontalAlignment" Value="Stretch" />
-         <Setter Property="VerticalAlignment" Value="Stretch" />
-         <Setter Property="Content">
-            <Setter.Value>
-              <TextBlock VerticalAlignment="Center" Text="Sell" />
-            </Setter.Value>
-         </Setter>
-         <Setter Property="Template">
-            <Setter.Value>
-               <ControlTemplate TargetType="Button">
-                  <Border 
-                        x:Name="Border"
-                        CornerRadius="0" 
-                        BorderThickness="1"
-                        BorderBrush="{u:BTSColor UI.Button.normal_border}"
-                        Background="{u:BTSColor MarketData.ask}"
-                        Padding="2"
-                        Height="Auto"
-                        SnapsToDevicePixels="True">
-                        <ContentPresenter 
-                           HorizontalAlignment="Center"
-                           VerticalAlignment="Center"
-                           RecognizesAccessKey="True"
-                           Name="button_content" 
-                        />
-                     </Border>
-                  <ControlTemplate.Triggers>
-                        <Trigger Property="IsMouseOver" Value="True">
-                           <Setter TargetName="Border" Property="Background" Value="#99c00000" />
-                           <Setter TargetName="Border" Property="BorderBrush" Value="{u:BTSColor UI.Button.mouseover_border}" />
-                        </Trigger>
-                     </ControlTemplate.Triggers>
-               </ControlTemplate>
-            </Setter.Value>
-         </Setter>
-      </Style>
-      <Style x:Key="BuyButton" TargetType="Button" BasedOn="{StaticResource {x:Type Button}}">
-         <Setter Property="Background" Value="{u:BTSColor MarketData.bid}" />
-         <Setter Property="Foreground" Value="White" />
-         <Setter Property="MinHeight" Value="40" />
-         <Setter Property="FontWeight" Value="Bold" />
-         <Setter Property="HorizontalAlignment" Value="Stretch" />
-         <Setter Property="VerticalAlignment" Value="Stretch" />
-         <Setter Property="Content">
-            <Setter.Value>
-              <TextBlock VerticalAlignment="Center" Text="Buy" />
-            </Setter.Value>
-         </Setter>
-         <Setter Property="Template">
-            <Setter.Value>
-               <ControlTemplate TargetType="Button">
-                  <Border 
-                     x:Name="Border"
-                     CornerRadius="0" 
-                     BorderThickness="1"
-                     BorderBrush="{u:BTSColor UI.Button.normal_border}"
-                     Background="{u:BTSColor MarketData.bid}"
-                     Padding="2"
-                     Height="Auto"
-                     SnapsToDevicePixels="True">
-                     <ContentPresenter 
-                        HorizontalAlignment="Center"
-                        VerticalAlignment="Center"
-                        RecognizesAccessKey="True"
-                        Name="button_content" 
-                     />
-                  </Border>
-                  <ControlTemplate.Triggers>
-                     <Trigger Property="IsMouseOver" Value="True">
-                        <Setter TargetName="Border" Property="Background" Value="#99167ed3" />
-                        <Setter TargetName="Border" Property="BorderBrush" Value="{u:BTSColor UI.Button.mouseover_border}" />
-                     </Trigger>
-                  </ControlTemplate.Triggers>
-               </ControlTemplate>
-            </Setter.Value>
-         </Setter>
-      </Style>
-      </ResourceDictionary>
-  </Window.Resources>
-  <Window.InputBindings>
-    <KeyBinding Key="Esc" Command="{x:Static SystemCommands.CloseWindowCommand}"/>
-  </Window.InputBindings>
-  <Grid Margin="10">
-    <Grid.RowDefinitions>
-      <RowDefinition Height="Auto"/>
-      <RowDefinition Height="{Binding Source={StaticResource VerticalSpacing}}"/>
-      <RowDefinition Height="Auto"/>
-    </Grid.RowDefinitions>
-    <Grid.ColumnDefinitions>
-      <ColumnDefinition MinWidth="120"/>
-      <ColumnDefinition Width="{Binding Source={StaticResource HorizontalSpacing}}"/>
-      <ColumnDefinition MinWidth="120"/>
-    </Grid.ColumnDefinitions>
-    <usp:OrderModificationControl Grid.ColumnSpan="3" />
-      <Button Grid.Row="2"                 Style="{StaticResource BuyButton}"  Command="{Binding send_order}" CommandParameter="{u:Enum Buy, Type=msys:Side}" />
-      <Button Grid.Row="2" Grid.Column="2" Style="{StaticResource SellButton}" Command="{Binding send_order}" CommandParameter="{u:Enum Sell, Type=msys:Side}" />
-   </Grid>
-  <u:WindowStyle.TitleContentTemplate>
-    <DataTemplate>
-      <TextBlock Style="{StaticResource TextBlock.Dark}">
-        <TextBlock.Inlines>
-          <Run FontWeight="Bold" Text="{Binding security, Mode=OneWay}" />
-          <Run Foreground="{u:BTSColor MarketData.bid}" FontSize="10">
-            <MultiBinding Converter="{x:Static cv:TickDisplayConverter.Instance}" StringFormat="({0})">
-              <Binding Path="bid_size" Mode="OneWay"/>
-              <Binding Path="DataContext.qty_display" RelativeSource="{RelativeSource AncestorType=usp:OrderTicket}"/>
-            </MultiBinding>
-          </Run>
-          <Run Foreground="{u:BTSColor MarketData.bid}" FontWeight="Bold">
-            <Run.Text>
-              <MultiBinding Converter="{StaticResource TickDisplayConverter}" Mode="OneWay">
-                <Binding Path="bid"/>
-                <Binding Path="security.ContractSpec"/>
-              </MultiBinding>
-            </Run.Text>
-          </Run>
-          <Run Foreground="{u:BTSColor MarketData.ask}" FontWeight="Bold">
-            <Run.Text>
-              <MultiBinding Converter="{StaticResource TickDisplayConverter}" Mode="OneWay">
-                <Binding Path="ask"/>
-                <Binding Path="security.ContractSpec"/>
-              </MultiBinding>
-            </Run.Text>
-          </Run>
-          <Run Foreground="{u:BTSColor MarketData.ask}" FontSize="10">
-            <MultiBinding Converter="{x:Static cv:TickDisplayConverter.Instance}" StringFormat="({0})">
-              <Binding Path="ask_size" Mode="OneWay"/>
-              <Binding Path="DataContext.qty_display" RelativeSource="{RelativeSource AncestorType=usp:OrderTicket}"/>
-            </MultiBinding>
-          </Run>
-        </TextBlock.Inlines>
-      </TextBlock>
-    </DataTemplate>
-  </u:WindowStyle.TitleContentTemplate>
-</Window>
+<Window
+  x:Class="mbts.ui.spark.OrderTicket"
+  xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
+  xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
+  xmlns:msys="clr-namespace:bts.api;assembly=spark_api"
+  xmlns:u="clr-namespace:mbts.ui"
+  xmlns:cv="clr-namespace:mbts.ui.converters"
+  xmlns:usp="clr-namespace:mbts.ui.spark"
+  xmlns:sys="clr-namespace:System;assembly=mscorlib"
+  u:WindowStyle.SizeToContent="WidthAndHeight"
+  u:WindowStyle.TitleContent="{Binding bbo, Mode=OneWay}"
+  Style="{StaticResource BTSWindowTitleTemplate}"
+>
+  <Window.Resources>
+    <ResourceDictionary>
+      <ResourceDictionary.MergedDictionaries>
+        <ResourceDictionary Source="/view/Resources/Converters.xaml"/>
+      </ResourceDictionary.MergedDictionaries>
+      <sys:Double x:Key="HorizontalSpacing">8.0</sys:Double>
+      <sys:Double x:Key="VerticalSpacing">4.0</sys:Double>
+      <sys:Double x:Key="ButtonHeight">22.0</sys:Double>
+      <Style x:Key="SellButton" TargetType="Button" BasedOn="{StaticResource {x:Type Button}}">
+         <Setter Property="Background" Value="{u:BTSColor MarketData.ask_dark}" />
+         <Setter Property="Foreground" Value="White" />
+         <Setter Property="MinHeight" Value="40" />
+         <Setter Property="FontWeight" Value="Bold" />
+         <Setter Property="HorizontalAlignment" Value="Stretch" />
+         <Setter Property="VerticalAlignment" Value="Stretch" />
+         <Setter Property="Content">
+            <Setter.Value>
+              <TextBlock VerticalAlignment="Center" Text="Sell" />
+            </Setter.Value>
+         </Setter>
+         <Setter Property="Template">
+            <Setter.Value>
+               <ControlTemplate TargetType="Button">
+                  <Border 
+                        x:Name="Border"
+                        CornerRadius="0" 
+                        BorderThickness="1"
+                        BorderBrush="{u:BTSColor UI.Button.normal_border}"
+                        Background="{u:BTSColor MarketData.ask}"
+                        Padding="2"
+                        Height="Auto"
+                        SnapsToDevicePixels="True">
+                        <ContentPresenter 
+                           HorizontalAlignment="Center"
+                           VerticalAlignment="Center"
+                           RecognizesAccessKey="True"
+                           Name="button_content" 
+                        />
+                     </Border>
+                  <ControlTemplate.Triggers>
+                        <Trigger Property="IsMouseOver" Value="True">
+                           <Setter TargetName="Border" Property="Background" Value="#99c00000" />
+                           <Setter TargetName="Border" Property="BorderBrush" Value="{u:BTSColor UI.Button.mouseover_border}" />
+                        </Trigger>
+                     </ControlTemplate.Triggers>
+               </ControlTemplate>
+            </Setter.Value>
+         </Setter>
+      </Style>
+      <Style x:Key="BuyButton" TargetType="Button" BasedOn="{StaticResource {x:Type Button}}">
+         <Setter Property="Background" Value="{u:BTSColor MarketData.bid_dark}" />
+         <Setter Property="Foreground" Value="White" />
+         <Setter Property="MinHeight" Value="40" />
+         <Setter Property="FontWeight" Value="Bold" />
+         <Setter Property="HorizontalAlignment" Value="Stretch" />
+         <Setter Property="VerticalAlignment" Value="Stretch" />
+         <Setter Property="Content">
+            <Setter.Value>
+              <TextBlock VerticalAlignment="Center" Text="Buy" />
+            </Setter.Value>
+         </Setter>
+         <Setter Property="Template">
+            <Setter.Value>
+               <ControlTemplate TargetType="Button">
+                  <Border 
+                     x:Name="Border"
+                     CornerRadius="0" 
+                     BorderThickness="1"
+                     BorderBrush="{u:BTSColor UI.Button.normal_border}"
+                     Background="{u:BTSColor MarketData.bid}"
+                     Padding="2"
+                     Height="Auto"
+                     SnapsToDevicePixels="True">
+                     <ContentPresenter 
+                        HorizontalAlignment="Center"
+                        VerticalAlignment="Center"
+                        RecognizesAccessKey="True"
+                        Name="button_content" 
+                     />
+                  </Border>
+                  <ControlTemplate.Triggers>
+                     <Trigger Property="IsMouseOver" Value="True">
+                        <Setter TargetName="Border" Property="Background" Value="#99167ed3" />
+                        <Setter TargetName="Border" Property="BorderBrush" Value="{u:BTSColor UI.Button.mouseover_border}" />
+                     </Trigger>
+                  </ControlTemplate.Triggers>
+               </ControlTemplate>
+            </Setter.Value>
+         </Setter>
+      </Style>
+      </ResourceDictionary>
+  </Window.Resources>
+  <Window.InputBindings>
+    <KeyBinding Key="Esc" Command="{x:Static SystemCommands.CloseWindowCommand}"/>
+  </Window.InputBindings>
+  <Grid Margin="10">
+    <Grid.RowDefinitions>
+      <RowDefinition Height="Auto"/>
+      <RowDefinition Height="{Binding Source={StaticResource VerticalSpacing}}"/>
+      <RowDefinition Height="Auto"/>
+    </Grid.RowDefinitions>
+    <Grid.ColumnDefinitions>
+      <ColumnDefinition MinWidth="120"/>
+      <ColumnDefinition Width="{Binding Source={StaticResource HorizontalSpacing}}"/>
+      <ColumnDefinition MinWidth="120"/>
+    </Grid.ColumnDefinitions>
+    <usp:OrderModificationControl Grid.ColumnSpan="3" />
+      <Button Grid.Row="2"                 Style="{StaticResource BuyButton}"  Command="{Binding send_order}" CommandParameter="{u:Enum Buy, Type=msys:Side}" />
+      <Button Grid.Row="2" Grid.Column="2" Style="{StaticResource SellButton}" Command="{Binding send_order}" CommandParameter="{u:Enum Sell, Type=msys:Side}" />
+   </Grid>
+  <u:WindowStyle.TitleContentTemplate>
+    <DataTemplate>
+      <TextBlock Style="{StaticResource TextBlock.Dark}">
+        <TextBlock.Inlines>
+          <Run FontWeight="Bold" Text="{Binding security, Mode=OneWay}" />
+          <Run Foreground="{u:BTSColor MarketData.bid}" FontSize="10">
+            <MultiBinding Converter="{x:Static cv:TickDisplayConverter.Instance}" StringFormat="({0})">
+              <Binding Path="bid_size" Mode="OneWay"/>
+              <Binding Path="DataContext.qty_display" RelativeSource="{RelativeSource AncestorType=usp:OrderTicket}"/>
+            </MultiBinding>
+          </Run>
+          <Run Foreground="{u:BTSColor MarketData.bid}" FontWeight="Bold">
+            <Run.Text>
+              <MultiBinding Converter="{StaticResource TickDisplayConverter}" Mode="OneWay">
+                <Binding Path="bid"/>
+                <Binding Path="security.ContractSpec"/>
+              </MultiBinding>
+            </Run.Text>
+          </Run>
+          <Run Foreground="{u:BTSColor MarketData.ask}" FontWeight="Bold">
+            <Run.Text>
+              <MultiBinding Converter="{StaticResource TickDisplayConverter}" Mode="OneWay">
+                <Binding Path="ask"/>
+                <Binding Path="security.ContractSpec"/>
+              </MultiBinding>
+            </Run.Text>
+          </Run>
+          <Run Foreground="{u:BTSColor MarketData.ask}" FontSize="10">
+            <MultiBinding Converter="{x:Static cv:TickDisplayConverter.Instance}" StringFormat="({0})">
+              <Binding Path="ask_size" Mode="OneWay"/>
+              <Binding Path="DataContext.qty_display" RelativeSource="{RelativeSource AncestorType=usp:OrderTicket}"/>
+            </MultiBinding>
+          </Run>
+        </TextBlock.Inlines>
+      </TextBlock>
+    </DataTemplate>
+  </u:WindowStyle.TitleContentTemplate>
+</Window>

src/client/spark/Risk/PNL/PNLReportCalculator.cs

@@ -64,8 +64,7 @@ namespace mbts.analytics {
                if (tl.tl_row.size > 0) {
                   start_long_pos += tl.tl_row.size;
                   start_long_total_cost += cost;
-               }
-               else {
+               } else {
                   start_short_pos += Math.Abs(tl.tl_row.size);
                   start_short_total_cost += cost;
                }
@@ -78,8 +77,7 @@ namespace mbts.analytics {
                if (tl.tl_row.size > 0) {
                   day_long_pos += tl.tl_row.size;
                   day_long_total_cost += cost;
-               }
-               else {
+               } else {
                   day_short_pos += Math.Abs(tl.tl_row.size);
                   day_short_total_cost += cost;
                }
@@ -165,6 +163,13 @@ namespace mbts.analytics {
                   is_day_trade = _is_day_trade(tl)
                };
                pnl_trades.Add(pnl_tl);
+            } else if (tl.security_type == SecurityType.Spot) {
+               PNLTradeRow pnl_tl = new PNLTradeRow() {
+                  tl_row = tl,
+                  md = tl_md,
+                  is_day_trade = _is_day_trade(tl)
+               };
+               pnl_trades.Add(pnl_tl);
             }
          }
          return pnl_trades;

src/client/spark/Risk/PNL/PNLTradeLogRow.cs

@@ -4,6 +4,9 @@ using bts.api;
 
 using BCG;
 using mbts.co2;
+using System.Xml.Serialization;
+using ZstdSharp.Unsafe;
+using bts.proto;
 
 namespace mbts.analytics {
    // Pairs ITradeLogRow along with the data (theo, md) that is needed to compute
@@ -18,20 +21,88 @@ namespace mbts.analytics {
 
       public SecurityImmutable security { get { return md.security; } }
 
-      private double _option_pnl(double trade_price, double now_price) {
-         double coin_terms = (now_price - trade_price) * tl_row.size;
-         double usd_terms = coin_terms * driver;
-         return usd_terms;
+      // private double _option_pnl(double trade_price, double now_price) {
+      //    double coin_terms = (now_price - trade_price) * tl_row.size;
+      //    double usd_terms = coin_terms * driver;
+      //    return usd_terms;
+      // }
+
+      private bool _is_notional {
+         get {
+            return false;
+         }
       }
 
-      private double _future_pnl(double trade_price, double now_price) {
-         // the qty is in USD, so this is the initial cash flow
-         double init_asset_value = tl_row.size;
-         double asset_size = init_asset_value / tl_row.price;
-         double now_asset_value = asset_size * now_price;
-         return now_asset_value - init_asset_value;
+      private bool _is_inverse_option_contract {
+         get {
+            return false;
+         }
       }
 
+      private double _cpp {
+         get {
+            return 1.0;
+         }
+      }
+
+      private bool _is_reverse_option_contract {
+         get {
+            // check for Deribit options
+            return false;
+         }
+      }
+
+      private double _option_pnl {
+         get {
+            if (_is_notional) {
+               var now_price = theo;
+               double coin_terms = (now_price - tl_row.price) * tl_row.size;
+               double usd_terms = coin_terms * driver;
+               return usd_terms;
+            } else {
+               return _cpp * tl_row.size * (theo - tl_row.price);
+            }
+         }
+      }
+
+      private double _spot_pnl {
+         get {
+            // both are computed the same way
+            return _future_pnl;
+         }
+      }
+
+      private double _future_pnl {
+         get {
+            if (_is_notional) {
+               // TODO:
+               // let it fall through right now
+               // the qty is in USD, so this is the initial cash flow
+               var now_price = theo;
+               double init_asset_value = tl_row.size;
+               double asset_size = init_asset_value / tl_row.price;
+               double now_asset_value = asset_size * now_price;
+               return now_asset_value - init_asset_value;
+            } else {
+               // TODO: is position pnl, compute it wrt settlement price?
+               return tl_row.size * (theo - tl_row.price);
+            }
+         }
+      }
+
+      // private double _future_pnl(double trade_price, double now_price) {
+      //    if (_is_notional) {
+      //       // the qty is in USD, so this is the initial cash flow
+      //       double init_asset_value = tl_row.size;
+      //       double asset_size = init_asset_value / tl_row.price;
+      //       double now_asset_value = asset_size * now_price;
+      //       return now_asset_value - init_asset_value;
+      //    } else {
+      //       return tl_row.size * (theo - tl_row.price);
+      //    }
+      // }
+
+
       public double driver {
          get {
             if (tl_row.security_type == SecurityType.Option) {
@@ -44,35 +115,46 @@ namespace mbts.analytics {
       }
       public double theo {
          get {
-            if (tl_row.security_type == SecurityType.Option) {
-               return tl_row.call_put == PutOrCall.Call ?
-                  opt_theo.fwd_normalized_call : opt_theo.fwd_normalized_put;
-            } else if (tl_row.security_type == SecurityType.Future) {
-               return fut_theo.theo;
+            switch (tl_row.security_type) {
+               // TODO:
+               case SecurityType.Option:
+                  if (_is_inverse_option_contract) {
+                     return tl_row.call_put == PutOrCall.Call ?
+                        opt_theo.fwd_normalized_call : opt_theo.fwd_normalized_put;
+                  } else {
+                     return tl_row.call_put == PutOrCall.Call ?
+                        opt_theo.call : opt_theo.put;
+                  }
+               // future and options, just get mid market
+               case SecurityType.Future:
+               //return fut_theo.theo;
+               case SecurityType.Spot:
+                  var bbo = top_of_book;
+                  return (bbo.Item1 + bbo.Item2) / 2;
+               default:
+                  return Double.NaN;
             }
-            return Double.NaN;
          }
       }
       public double pnl {
          get {
             double rv = Double.NaN;
-            if (is_day_trade) {
-               if (tl_row.security_type == SecurityType.Future) {
-                  rv = _future_pnl(tl_row.price, theo);
-               } else if (tl_row.security_type == SecurityType.Option) {
-                  rv = _option_pnl(tl_row.price, theo);
-               }
-               return rv;
-            }
-            // use settle price ?
-            if (tl_row.security_type == SecurityType.Future) {
-               rv = _future_pnl(tl_row.price, theo);
-            } else if (tl_row.security_type == SecurityType.Option) {
-               rv = _option_pnl(tl_row.price, theo);
+            switch (tl_row.security_type) {
+               case SecurityType.Option:
+                  rv = _option_pnl;
+                  break;
+               case SecurityType.Future:
+                  rv = _future_pnl;
+                  break;
+               case SecurityType.Spot:
+                  // = tl_row.size * (theo - tl_row.price);
+                  rv = _spot_pnl;
+                  break;
             }
             return rv;
          }
       }
+
       public double settle_price {
          get {
             return md.md == null ? Double.NaN : md.md.settlement_price;

src/client/spark/Security/SecurityExpirationHelper.cs

@@ -36,6 +36,10 @@ namespace mbts {
       }
 
       public static bool is_unexpired(bts.api.SecurityTuple st, DateTime exp_date) {
+         if (st.Venue == Venue.Cboe || st.Venue == Venue.Glbx) {
+            // server is already getting teh righ contracts
+            return true;
+         }
          TimeSpan exp_time = get_exp_time(st);
          DateTime full_exp_utc = exp_date.ToUniversalTime().Date.Add(exp_time);
          DateTime now_utc = DateTime.UtcNow;
@@ -43,6 +47,8 @@ namespace mbts {
       }
 
       public static bool is_unexpired(bts.api.SecurityImmutable sec) {
+         if (sec.security_tuple().Venue == Venue.Cboe || sec.security_tuple().Venue == Venue.Glbx)
+            return true;
          var sec_type = sec.security_type();
          switch (sec_type) {
             case bts.api.SecurityType.Future:

src/client/spark/SpreadBox/Calculators/StatelessSpreadCalculator.cs

@@ -143,9 +143,21 @@ namespace BCG {
          return tp ?? mbts.spark.TheoPoint.getNulledObject();
       }
 
-      private static mbts.spark.TheoPoint _compute_single_option_leg_at_tied_price(DateTime option_expiration, double strike, bool is_call, OptionTheoInterpolationData sparse_theo_map, double driver_price) {
-         mbts.spark.TheoPoint tp = sparse_theo_map == null ? mbts.spark.TheoPoint.getNulledObject() : sparse_theo_map.interpolate_theos(option_expiration, strike, driver_price);
-         return tp ?? mbts.spark.TheoPoint.getNulledObject();
+      private static mbts.spark.TheoPoint _compute_single_option_leg_at_tied_price(DateTime option_expiration, double strike, bool is_call, OptionTheoInterpolationData sparse_theo_map,
+                                                                                    ExpStrikeKeyedData<mbts.spark.TheoPoint> live_symbol_theo_map, double driver_price) {
+         // mbts.spark.TheoPoint tp = sparse_theo_map == null ? mbts.spark.TheoPoint.getNulledObject() : sparse_theo_map.interpolate_theos(option_expiration, strike, driver_price);
+         // return tp ?? mbts.spark.TheoPoint.getNulledObject();
+         // TOD: config here
+         return _compute_single_option_leg_at_tied_price_from_live(option_expiration, strike, is_call, live_symbol_theo_map, driver_price);
+      }
+
+      private static mbts.spark.TheoPoint _compute_single_option_leg_at_tied_price_from_live(DateTime option_expiration, double strike, bool is_call,
+                                                                                             ExpStrikeKeyedData<mbts.spark.TheoPoint> live_symbol_theo_map, double driver_price) {
+         var tp = live_symbol_theo_map.get_data(option_expiration, strike);
+         if (tp == null)
+            return mbts.spark.TheoPoint.getNulledObject();
+         return TheoPoint.extrapolate(tp, driver_price, is_call);
+
       }
 
       /// this is the only relatively tricky thing here      
@@ -175,7 +187,7 @@ namespace BCG {
                   if (leg_price_spec.primaryFrozen)   /// tied
                   {
                      effective_driver = leg_price_spec.primary;
-                     return _compute_single_option_leg_at_tied_price(spread_option_leg.contract.expiration, spread_option_leg.contract.strike, spread_option_leg.contract.isCall, symbol_sparse_theo_map, leg_price_spec.primary);
+                     return _compute_single_option_leg_at_tied_price(spread_option_leg.contract.expiration, spread_option_leg.contract.strike, spread_option_leg.contract.isCall, symbol_sparse_theo_map, live_symbol_theo_map, leg_price_spec.primary);
                   } else {
                      mbts.spark.TheoPoint tp = _compute_single_option_leg_at_live_price(spread_option_leg.contract.expiration, spread_option_leg.contract.strike, spread_option_leg.contract.isCall, live_symbol_theo_map);
                      effective_driver = tp.driver;
@@ -189,7 +201,7 @@ namespace BCG {
                         future_theo_map.TryGetValue(driver_price_info.first, out symbol_future_theo_map);
                      double driver_price = StatelessFutureTheoCalculator.transform_price(symbol_future_theo_map, leg_price_spec.driverExpiration, leg_price_spec.primary, driver_price_info.second);
                      effective_driver = leg_price_spec.primary;
-                     return _compute_single_option_leg_at_tied_price(spread_option_leg.contract.expiration, spread_option_leg.contract.strike, spread_option_leg.contract.isCall, symbol_sparse_theo_map, driver_price);
+                     return _compute_single_option_leg_at_tied_price(spread_option_leg.contract.expiration, spread_option_leg.contract.strike, spread_option_leg.contract.isCall, symbol_sparse_theo_map, live_symbol_theo_map, driver_price);
                   } else {
                      bts.Log.Ui.error(String.Format("This spread is live but the driver expiration {0} is different from the system driver expiration {1} for {2}",
                                                       spread_option_leg.legPriceSpec.driverExpiration, driver_price_info.second, spread_option_leg.contract.product));

src/client/spark/core/FontsAndColors/BTSColors.cs

@@ -216,8 +216,10 @@ namespace mbts.ui {
          public static BTSColor ask_text => BTSCoreColors.red_dark;
          public static BTSColor bid_text => BTSCoreColors.blue;
          public static BTSColor bid => 0xff76b7fa;
+         public static BTSColor bid_dark => 0xff26239a;
          public static BTSColor bid_alt => BTSCoreColors.blue_light.with(0x70);
          public static BTSColor ask => 0xffff6666;
+         public static BTSColor ask_dark => 0xff7a2331;
          public static BTSColor ask_alt => 0x70ffb4b4;
          public static BTSColor last => BTSCoreColors.black;
          public static BTSColor bid_ask_alt_blend => BTSCoreColors.purple_light;
@@ -1038,6 +1040,7 @@ namespace mbts.ui {
       }
       public static class DayFills {
          public static BTSColor background => UI.common_background;
+         public static BTSColor foreground => UI.default_foreground;
       }
       public static class ComboReport {
          public static BTSColor foreground => UI.default_text;

src/client/spark/view/Controls/DIYGrid/Columns/ColumnBase.cs

@@ -26,7 +26,7 @@ namespace mbts.ui.controls {
          public const double
             Account = 62,
             CheckMark = 42,
-            Currency = 54,
+            Currency = 68,
             Exchange = 66,
             FillKey = 68,
             OrderKey = 78,
@@ -45,6 +45,7 @@ namespace mbts.ui.controls {
             MergedQty = 68,
             NotionalValue = 68,
             Filled = 56,
+            FilledNotionalValue = 81,
             Symbol = 60,
             Time = 112,
             TimeOfDay = 84,
@@ -146,6 +147,7 @@ namespace mbts.ui.controls {
             FillKind = "Fill Kind",
             FilledPrice = "Fill Price",
             FilledQuantity = "Fill Qty",
+            FilledNotionalValue = "Fill Notional",
             FillStatus = "Fill Status",
             Name = "Name",
             Description = "Description",

src/client/spark/view/Controls/Order/OrderTicketResources.xaml

@@ -19,7 +19,7 @@
   <sys:Double x:Key="ButtonHeight">22.0</sys:Double>
 
   <Style x:Key="SellButton" TargetType="Button" BasedOn="{StaticResource {x:Type Button}}">
-    <Setter Property="Background" Value="{u:BTSColor MarketData.ask}"/>
+    <Setter Property="Background" Value="{u:BTSBrush MarketData.ask_dark}"/>
     <Setter Property="BorderBrush" Value="{u:BTSColor UI.Button.normal_border}"/>
     <Setter Property="Foreground" Value="{u:BTSColor UI.default_text}" />
     <Setter Property="MinHeight" Value="40"/>
@@ -32,7 +32,7 @@
   </Style>
 
   <Style x:Key="BuyButton" TargetType="Button" BasedOn="{StaticResource {x:Type Button}}">
-    <Setter Property="Background" Value="{u:BTSColor MarketData.bid}"/>
+    <Setter Property="Background" Value="{u:BTSBrush MarketData.bid_dark}"/>
     <Setter Property="BorderBrush" Value="{u:BTSColor UI.Button.normal_border}"/>
     <Setter Property="Padding" Value="2"/>
     <Setter Property="Foreground" Value="{u:BTSColor UI.default_text}" />

src/client/spark/view/Controls/TickUpDown/PriceEntryCommitControl.xaml

@@ -8,7 +8,8 @@
              xmlns:cv="clr-namespace:mbts.ui.converters"
              xmlns:c="clr-namespace:mbts.ui.controls"
              xmlns:usp="clr-namespace:mbts.ui.spark"
-             d:DesignHeight="100" d:DesignWidth="800" x:Name="_me_price">
+             d:DesignHeight="100" d:DesignWidth="800" x:Name="_me_price"
+             Foreground="{u:BTSColor UI.input_text}">
   <UserControl.Resources>
     <cv:NullableDoubleConverter x:Key="TickDefaultPriceConverter" DefaultValue="0"/>
     <cv:TickDisplayConverter x:Key="TickDisplayConverter" x:Shared="False"/>

src/client/spark/view/Shell/ShellModel.cs

@@ -100,7 +100,7 @@
       }
 
       void PerformMEFComposition(string config_source) {
-         Log.Ui.info($"this is v2.2.3 Generating MEF dependencies for the shell" +
+         Log.Ui.info($"Generating MEF dependencies for the shell" +
                $"({typeof(IInitializable)}s, {typeof(IShellModule)}s, " +
                $"{typeof(IShellDaemon)}s, etc.)");
          try {

src/client/spark_api/Orders/OrderRecordTuple.cs

@@ -69,6 +69,20 @@ namespace Spark.Api.Orders {
       public uint security_id => order.security_id;
       public SecurityImmutable? security => order.security;
 
+      // TODO: remove assumption that synthetic quantities are already notional values
+      public double notional_value =>
+         (security?.HasSynthetic ?? false)
+         && security.Value.Synthetic.PriceCalc == SyntheticContract.Types.PriceCalc.NotionalLeg
+            ? order.order.quantity()
+            : order.order.notional_value();
+
+      // TODO: remove assumption that synthetic quantities are already notional values
+      public double filled_notional_value =>
+         (security?.HasSynthetic ?? false)
+         && security.Value.Synthetic.PriceCalc == SyntheticContract.Types.PriceCalc.NotionalLeg
+            ? order.order.filled_quantity()
+            : order.order.filled_notional_value();
+
       public bool Equals(OrderRecordTupleWithRoot other) =>
          order.Equals(other.order) &&
          EqualityComparer.nullable_equals(_root, other._root);

src/client/spark_api/Orders/OrdersExtensions.cs

@@ -51,6 +51,9 @@ namespace Spark.Api.Orders {
       public static double notional_value(this OrderRecordImmutable order) =>
          order.quantity() * order.ui_price();
 
+      public static double filled_notional_value(this OrderRecordImmutable order) =>
+         order.avg_price() * order.filled_quantity();
+
       public static double working_quantity(this OrderRecordImmutable order) =>
          order.HasState ? order.State.working_quantity() : 0;
 

src/client/spark_api/data/SecurityCriteria.cs

@@ -27,6 +27,12 @@ namespace mbts.spark {
       internal static SecurityCriteria from_keys(IEnumerable<uint> keys) =>
          new(new[] { new SecurityCriteriaClause(security_keys: keys.ToArray()) });
 
+      internal static SecurityCriteria from_expirations(params DateTime[] exp_dates) =>
+         from_expirations(exp_dates.AsEnumerable());
+
+      internal static SecurityCriteria from_expirations(IEnumerable<DateTime> expirations) =>
+         new(new[] { SecurityCriteriaClause.from_expirations(expirations) });
+
       internal static SecurityCriteria from_securities(params SecurityImmutable[] securities) =>
          from_securities(securities.AsEnumerable());
 

src/client/spark_api/data/SecurityCriteriaClause.cs

@@ -58,6 +58,14 @@ namespace mbts.spark {
          return new SecurityCriteriaClause(security_keys: keys, pretty_name: pretty_name);
       }
 
+      public static SecurityCriteriaClause from_expirations(IEnumerable<DateTime> expirations) =>
+         expirations is null
+            ? new()
+            : from_expirations(expirations as DateTime[] ?? expirations.ToArray());
+
+      public static SecurityCriteriaClause from_expirations(params DateTime[] expirations) =>
+         new(expirations: expirations);
+
       [ProtoMember(1)]
       public string? pretty_name { get; }
 

src/client/spark_core/utils_api/BTS.cs

@@ -1,5 +1,5 @@
 using System;
-using System.Collections.Generic;
+using System.Reflection;
 using System.Text;
 using System.Threading;
 
@@ -10,8 +10,9 @@ namespace bts
       static int _needs_init_spark_lib = 0;
 
       public static void init(string config_source = null) {
+         var version = Assembly.GetExecutingAssembly().GetName().Version;
          Console.WriteLine(
-            $"Configuring BTS with {(config_source is null ? "defaults" : $"'{config_source}'")}");
+            $"Configuring Spark {version} with {(config_source is null ? "defaults" : $"'{config_source}'")}");
          var args = Environment.GetCommandLineArgs();
          utils.BTSNativeMethods.provide_command_line(args, args.Length);
 

src/lib/api/md/DatabentoMarketDataConfig.proto

@@ -15,4 +15,7 @@ message DatabentoMarketDataConfig {
   string dataset = 70;
   uint32 filter_securities_upto_n_months= 80;
   bool load_reference_data = 90;
+  uint32 debug_sec = 100;
+  bool only_securities =  110;
+  string bbo_start_time = 120;
 }

src/lib/api/services/OrderService.cpp

@@ -0,0 +1,174 @@
+#include "OrderService.h"
+#include "lib/api/services/OrderService.pb.h"
+
+namespace bts::api::orderman {
+
+#define PARSE_STRING(name, dest, it)                                           \
+   it = j.find(#name);                                                         \
+   if (it != j.end()) {                                                        \
+      dest.mutable_##name()->clear();                                          \
+      it->get_to(*dest.mutable_##name());                                      \
+   }
+#define PARSE_VALUE(name, dest, it)                                            \
+   it = j.find(#name);                                                         \
+   if (it != j.end()) {                                                        \
+      dest.set_##name(it->get<decltype(dest.name())>());                       \
+   }
+#define PARSE_STRUCT(name, dest, it)                                           \
+   it = j.find(#name);                                                         \
+   if (it != j.end()) {                                                        \
+      it->get_to(*dest.mutable_##name());                                      \
+   }
+#define PARSE_ARRAY(name, dest, it)                                            \
+   it = j.find(#name);                                                         \
+   if (it != j.end() && it->is_array()) {                                      \
+      c.mutable_##name()->Clear();                                             \
+      it->get_to(*c.mutable_##name());                                         \
+   }
+#define PARSE_ONEOF(name, dest, it)                                            \
+   if (!parsed_oneof) {                                                        \
+      it = j.find(#name);                                                      \
+      if (it != j.end()) {                                                     \
+         it->get_to(*dest.mutable_##name());                                   \
+         parsed_oneof = true;                                                  \
+      }                                                                        \
+   }
+#define PARSE_ONEOFS(for_each)                                                 \
+   {                                                                           \
+      bool parsed_oneof = false;                                               \
+      for_each(PARSE_ONEOF)                                                    \
+   }
+
+#define WRITE_VALUE(src, name) j[#name] = src.name()
+#define WRITE_STRUCT(src, name)                                                \
+   if (src.has_##name()) {                                                     \
+      j[#name] = src.name();                                                   \
+   }
+
+#define WRITE_IF_NOT_ZERO(src, name)                                           \
+   if (src.name() != 0) {                                                      \
+      j[#name] = src.name();                                                   \
+   }
+#define WRITE_IF_NOT_NAN(src, name)                                            \
+   if (!std::isnan(src.name())) {                                              \
+      j[#name] = src.name();                                                   \
+   }
+#define WRITE_IF_NOT_EMPTY(src, name)                                          \
+   if (!src.name().empty()) {                                                  \
+      j[#name] = src.name();                                                   \
+   }
+#define WRITE_TIMESTAMP(src, name)                                             \
+   j[#name] = bts::core::TimeStamp::from_nanos(                                \
+                  src.name().seconds() * 1'000'000'000 + src.name().nanos())   \
+                  .to_iso_string()
+
+#define PARSE_TIMESTAMP(name, dest, it)                                        \
+   it = j.find(#name);                                                         \
+   if (it != j.end()) {                                                        \
+      bts::core::TimeStamp tmp_ts =                                            \
+          bts::core::TimeStamp::from_iso_string(it->get<std::string>());       \
+      tmp_ts.to_protobuf(*dest.mutable_##name());                              \
+   }
+
+void to_json(nlohmann::json &j, const Fill &f) {
+   WRITE_IF_NOT_ZERO(f, order_key);
+   WRITE_IF_NOT_ZERO(f, security_key);
+   WRITE_IF_NOT_EMPTY(f, account);
+   WRITE_IF_NOT_NAN(f, last_price);
+   WRITE_IF_NOT_NAN(f, avg_price);
+   WRITE_VALUE(f, side);
+   WRITE_IF_NOT_ZERO(f, last_shares);
+   WRITE_IF_NOT_EMPTY(f, fill_key);
+   WRITE_TIMESTAMP(f, timestamp);
+   WRITE_IF_NOT_ZERO(f, internal_account_id);
+   WRITE_VALUE(f, fill_kind);
+   WRITE_VALUE(f, fill_status);
+}
+
+void from_json(const nlohmann::json &j, Fill &f) {
+   nlohmann::json::const_iterator it;
+   PARSE_VALUE(order_key, f, it);
+   PARSE_VALUE(security_key, f, it);
+   PARSE_STRING(account, f, it);
+   PARSE_VALUE(last_price, f, it);
+   PARSE_VALUE(avg_price, f, it);
+   PARSE_VALUE(side, f, it);
+   PARSE_VALUE(last_shares, f, it);
+   PARSE_STRING(fill_key, f, it);
+   PARSE_TIMESTAMP(timestamp, f, it);
+   PARSE_VALUE(internal_account_id, f, it);
+   PARSE_VALUE(fill_kind, f, it);
+   PARSE_VALUE(fill_status, f, it);
+}
+
+void to_json(nlohmann::json &j, const NativeOrderState &n) {
+   WRITE_VALUE(n, exchange_order_id);
+   WRITE_VALUE(n, last_msg_seq_num);
+   WRITE_VALUE(n, sub_error_code);
+   WRITE_VALUE(n, native_status);
+   WRITE_VALUE(n, routing_record);
+   WRITE_VALUE(n, native_type);
+   WRITE_VALUE(n, last_transact_time);
+   WRITE_VALUE(n, last_transact_time_unix_ns);
+   WRITE_VALUE(n, stop_px);
+   WRITE_VALUE(n, exchange_order_id_u64);
+}
+
+void from_json(const nlohmann::json &j, NativeOrderState &n) {
+   nlohmann::json::const_iterator it;
+   PARSE_STRING(exchange_order_id, n, it);
+   PARSE_VALUE(last_msg_seq_num, n, it);
+   PARSE_VALUE(sub_error_code, n, it);
+   PARSE_VALUE(native_status, n, it);
+   PARSE_STRUCT(routing_record, n, it);
+   PARSE_VALUE(native_type, n, it);
+   PARSE_STRING(last_transact_time, n, it);
+   PARSE_VALUE(last_transact_time_unix_ns, n, it);
+   PARSE_VALUE(stop_px, n, it);
+   PARSE_VALUE(exchange_order_id_u64, n, it);
+}
+
+void to_json(nlohmann::json &j, const RoutingRecord &r) {
+   WRITE_IF_NOT_EMPTY(r, session);
+   WRITE_IF_NOT_EMPTY(r, account);
+   WRITE_IF_NOT_EMPTY(r, operator_id);
+   WRITE_VALUE(r, cti_code);
+   WRITE_VALUE(r, customer_or_firm);
+   WRITE_IF_NOT_EMPTY(r, smp_id);
+   WRITE_VALUE(r, smp_instruction);
+   WRITE_IF_NOT_EMPTY(r, location);
+   WRITE_IF_NOT_EMPTY(r, cust_order_handing_inst);
+   WRITE_IF_NOT_EMPTY(r, sender_compid);
+   WRITE_IF_NOT_EMPTY(r, clearing_firm);
+   WRITE_IF_NOT_EMPTY(r, customer_account_ref_id);
+   WRITE_IF_NOT_EMPTY(r, account_code);
+   WRITE_IF_NOT_EMPTY(r, company_id);
+   WRITE_IF_NOT_EMPTY(r, authorized_trader);
+   WRITE_IF_NOT_EMPTY(r, authorized_group);
+   WRITE_IF_NOT_EMPTY(r, cust_order_handing_inst);
+   WRITE_IF_NOT_EMPTY(r, order_server_id);
+}
+
+void from_json(const nlohmann::json &j, RoutingRecord &r) {
+   nlohmann::json::const_iterator it;
+   PARSE_STRING(session, r, it);
+   PARSE_STRING(account, r, it);
+   PARSE_STRING(operator_id, r, it);
+   PARSE_VALUE(cti_code, r, it);
+   PARSE_VALUE(customer_or_firm, r, it);
+   PARSE_STRING(smp_id, r, it);
+   PARSE_VALUE(smp_instruction, r, it);
+   PARSE_STRING(location, r, it);
+   PARSE_STRING(cust_order_handling_inst, r, it);
+   PARSE_STRING(sender_compid, r, it);
+   PARSE_STRING(clearing_firm, r, it);
+   PARSE_STRING(customer_account_ref_id, r, it);
+   PARSE_STRING(account_code, r, it);
+   PARSE_STRING(company_id, r, it);
+   PARSE_STRING(authorized_trader, r, it);
+   PARSE_STRING(authorized_group, r, it);
+   PARSE_STRING(cust_order_handing_inst, r, it);
+   PARSE_STRING(order_server_id, r, it);
+}
+
+} // namespace bts::api::orderman

src/lib/api/services/OrderService.h

@@ -1,6 +1,10 @@
 #pragma once
 
 #include "lib/api/services/OrderService.pb.h"
+#include "lib/api/services/native_order_type.h"
+#include "lib/api/services/order_status.h"
+#include "lib/api/services/time_in_force.h"
+#include "lib/api/services/trigger_price_type.h"
 #include "lib/core/EnumMacros.h"
 #include "lib/core/FMT_IMPL.h"
 #include "lib/io/JsonReader.h"
@@ -10,22 +14,70 @@
 
 namespace bts::api::orderman {
 
-PB_ENUM_FROM_JSON(OrderStatus)
-PB_ENUM_TO_JSON(OrderStatus)
+PB_ENUM_FROM_JSON(Fill_FillKind)
+PB_ENUM_TO_JSON(Fill_FillKind)
 
-PB_ENUM_FROM_JSON(TriggerPriceType)
-PB_ENUM_TO_JSON(TriggerPriceType)
+PB_ENUM_FROM_JSON(Fill_FillStatus)
+PB_ENUM_TO_JSON(Fill_FillStatus)
+
+void to_json(nlohmann::json &j, const Fill &f);
+void from_json(const nlohmann::json &j, Fill &f);
+
+PB_ENUM_FROM_JSON(OrderSubType)
+PB_ENUM_TO_JSON(OrderSubType)
+
+PB_ENUM_FROM_JSON(SelfMatchPreventionInstruction)
+PB_ENUM_TO_JSON(SelfMatchPreventionInstruction)
+
+PB_ENUM_FROM_JSON(CustomerOrFirm)
+PB_ENUM_TO_JSON(CustomerOrFirm)
+
+void to_json(nlohmann::json &j, const RoutingRecord &r);
+void from_json(const nlohmann::json &j, RoutingRecord &r);
+
+PB_ENUM_FROM_JSON(NativeOrderStatus)
+PB_ENUM_TO_JSON(NativeOrderStatus)
+
+PB_ENUM_FROM_JSON(NativeOrderState_SubError)
+PB_ENUM_TO_JSON(NativeOrderState_SubError)
+
+void to_json(nlohmann::json &j, const NativeOrderState &n);
+void from_json(const nlohmann::json &j, NativeOrderState &n);
 
 } // namespace bts::api::orderman
 
 FMT_IMPL(
-    bts::api::orderman::OrderStatus,
-    s,
+    bts::api::orderman::Fill_FillKind,
+    k,
     "{}",
-    bts::api::orderman::OrderStatus_Name(s));
+    bts::api::orderman::Fill_FillKind_Name(k));
 
 FMT_IMPL(
-    bts::api::orderman::TriggerPriceType,
+    bts::api::orderman::Fill_FillStatus,
+    s,
+    "{}",
+    bts::api::orderman::Fill_FillStatus(s));
+
+FMT_IMPL(
+    bts::api::orderman::OrderSubType,
     t,
     "{}",
-    bts::api::orderman::TriggerPriceType_Name(t));
+    bts::api::orderman::OrderSubType_Name(t));
+
+FMT_IMPL(
+    bts::api::orderman::SelfMatchPreventionInstruction,
+    s,
+    "{}",
+    bts::api::orderman::SelfMatchPreventionInstruction_Name(s));
+
+FMT_IMPL(
+    bts::api::orderman::NativeOrderStatus,
+    s,
+    "{}",
+    bts::api::orderman::NativeOrderStatus_Name(s));
+
+FMT_IMPL(
+    bts::api::orderman::NativeOrderState_SubError,
+    s,
+    "{}",
+    bts::api::orderman::NativeOrderState_SubError_Name(s));

src/lib/api/services/native_order_type.h

@@ -0,0 +1,57 @@
+#pragma once
+
+#include "lib/api/services/OrderService.pb.h"
+#include "lib/core/EnumMacros.h"
+#include "lib/core/FMT_IMPL.h"
+#include "lib/io/JsonReader.h"
+#include "lib/logging/logging.h"
+#include "lib/utils/string_utils.h"
+
+#include <nlohmann/json.hpp>
+
+namespace bts::api::orderman {
+
+/**
+ * Parses NativeOrderType from a string. Unlike `bts::api::orderman::NativeOrderType_Parse`,
+ * this implementation is case insensitive, and makes the 'NATIVE_ORDER_TYPE_' prefix optional.
+ */
+bool native_order_type_parse_smart(
+    const std::string &str, NativeOrderType *result);
+
+PB_ENUM_FROM_JSON(NativeOrderType)
+PB_ENUM_TO_JSON(NativeOrderType)
+
+std::ostream &operator<<(std::ostream &out, NativeOrderType t) noexcept;
+
+//////////////////////////////////////////////////
+// Definition
+//////////////////////////////////////////////////
+
+inline bool native_order_type_parse_smart(
+    const std::string &str, NativeOrderType *result) {
+   if (NativeOrderType_Parse(str, result)) {
+      return true;
+   }
+   std::string s = bts::system::string_utils::copy_to_upper(str);
+   if (NativeOrderType_Parse(s, result)) {
+      return true;
+   }
+   const char *prefix = "NATIVE_ORDER_TYPE_";
+   if (!s.starts_with(prefix)) {
+      s.insert(0, prefix);
+   }
+   return NativeOrderType_Parse(s, result);
+}
+
+inline std::ostream &operator<<(std::ostream &out, NativeOrderType t) noexcept {
+   out << NativeOrderType_Name(t);
+   return out;
+}
+
+} // namespace bts::api::orderman
+
+FMT_IMPL(
+    bts::api::orderman::NativeOrderType,
+    t,
+    "{}",
+    bts::api::orderman::NativeOrderType_Name(t));

src/lib/api/services/order_status.h

@@ -0,0 +1,56 @@
+#pragma once
+
+#include "lib/api/services/OrderService.pb.h"
+#include "lib/core/EnumMacros.h"
+#include "lib/core/FMT_IMPL.h"
+#include "lib/io/JsonReader.h"
+#include "lib/logging/logging.h"
+#include "lib/utils/string_utils.h"
+
+#include <nlohmann/json.hpp>
+
+namespace bts::api::orderman {
+
+/**
+ * Parses OrderStatus from a string. Unlike `bts::api::orderman::OrderStatus_Parse`,
+ * this implementation is case insensitive, and makes the 'ORDER_STATUS_' prefix optional.
+ */
+bool order_status_parse_smart(const std::string &str, OrderStatus *result);
+
+PB_ENUM_FROM_JSON(OrderStatus)
+PB_ENUM_TO_JSON(OrderStatus)
+
+std::ostream &operator<<(std::ostream &out, OrderStatus s) noexcept;
+
+//////////////////////////////////////////////////
+// Definition
+//////////////////////////////////////////////////
+
+inline bool order_status_parse_smart(
+    const std::string &str, OrderStatus *result) {
+   if (OrderStatus_Parse(str, result)) {
+      return true;
+   }
+   std::string s = bts::system::string_utils::copy_to_upper(str);
+   if (OrderStatus_Parse(s, result)) {
+      return true;
+   }
+   const char *prefix = "ORDER_STATUS_";
+   if (!s.starts_with(prefix)) {
+      s.insert(0, prefix);
+   }
+   return OrderStatus_Parse(s, result);
+}
+
+inline std::ostream &operator<<(std::ostream &out, OrderStatus s) noexcept {
+   out << OrderStatus_Name(s);
+   return out;
+}
+
+} // namespace bts::api::orderman
+
+FMT_IMPL(
+    bts::api::orderman::OrderStatus,
+    s,
+    "{}",
+    bts::api::orderman::OrderStatus_Name(s));

src/lib/api/services/time_in_force.h

@@ -0,0 +1,56 @@
+#pragma once
+
+#include "lib/api/services/OrderService.pb.h"
+#include "lib/core/EnumMacros.h"
+#include "lib/core/FMT_IMPL.h"
+#include "lib/io/JsonReader.h"
+#include "lib/logging/logging.h"
+#include "lib/utils/string_utils.h"
+
+#include <nlohmann/json.hpp>
+
+namespace bts::api::orderman {
+
+/**
+ * Parses TimeInForce from a string. Unlike `bts::api::orderman::TimeInForce_Parse`,
+ * this implementation is case insensitive, and makes the 'TIME_IN_FORCE_' prefix optional.
+ */
+bool time_in_force_parse_smart(const std::string &str, TimeInForce *result);
+
+PB_ENUM_FROM_JSON(TimeInForce)
+PB_ENUM_TO_JSON(TimeInForce)
+
+std::ostream &operator<<(std::ostream &out, TimeInForce tif) noexcept;
+
+//////////////////////////////////////////////////
+// Definition
+//////////////////////////////////////////////////
+
+inline bool time_in_force_parse_smart(
+    const std::string &str, TimeInForce *result) {
+   if (TimeInForce_Parse(str, result)) {
+      return true;
+   }
+   std::string s = bts::system::string_utils::copy_to_upper(str);
+   if (TimeInForce_Parse(s, result)) {
+      return true;
+   }
+   const char *prefix = "TIME_IN_FORCE_";
+   if (!s.starts_with(prefix)) {
+      s.insert(0, prefix);
+   }
+   return TimeInForce_Parse(s, result);
+}
+
+inline std::ostream &operator<<(std::ostream &out, TimeInForce tif) noexcept {
+   out << TimeInForce_Name(tif);
+   return out;
+}
+
+} // namespace bts::api::orderman
+
+FMT_IMPL(
+    bts::api::orderman::TimeInForce,
+    v,
+    "{}",
+    bts::api::orderman::TimeInForce_Name(v));

src/lib/api/services/trigger_price_type.h

@@ -0,0 +1,58 @@
+#pragma once
+
+#include "lib/api/services/OrderService.pb.h"
+#include "lib/core/EnumMacros.h"
+#include "lib/core/FMT_IMPL.h"
+#include "lib/io/JsonReader.h"
+#include "lib/logging/logging.h"
+#include "lib/utils/string_utils.h"
+
+#include <nlohmann/json.hpp>
+
+namespace bts::api::orderman {
+
+/**
+ * Parses TriggerPriceType from a string. Unlike `bts::api::orderman::TriggerPriceType_Parse`,
+ * this implementation is case insensitive, and makes the 'TRIGGER_PRICE_TYPE_' prefix optional.
+ */
+bool trigger_price_type_parse_smart(
+    const std::string &str, TriggerPriceType *result);
+
+PB_ENUM_FROM_JSON(TriggerPriceType)
+PB_ENUM_TO_JSON(TriggerPriceType)
+
+std::ostream &operator<<(std::ostream &out, TriggerPriceType t) noexcept;
+
+//////////////////////////////////////////////////
+// Definition
+//////////////////////////////////////////////////
+
+inline bool trigger_price_type_parse_smart(
+    const std::string &str, TriggerPriceType *result) {
+   if (TriggerPriceType_Parse(str, result)) {
+      return true;
+   }
+   std::string s = bts::system::string_utils::copy_to_upper(str);
+   if (TriggerPriceType_Parse(s, result)) {
+      return true;
+   }
+   const char *prefix = "TRIGGER_PRICE_TYPE_";
+   if (!s.starts_with(prefix)) {
+      s.insert(0, prefix);
+   }
+   return TriggerPriceType_Parse(s, result);
+}
+
+inline std::ostream &operator<<(
+    std::ostream &out, TriggerPriceType t) noexcept {
+   out << TriggerPriceType_Name(t);
+   return out;
+}
+
+} // namespace bts::api::orderman
+
+FMT_IMPL(
+    bts::api::orderman::TriggerPriceType,
+    t,
+    "{}",
+    bts::api::orderman::TriggerPriceType_Name(t));

src/lib/cmake/GetLinuxClientSources.cmake

@@ -75,6 +75,7 @@ function(get_cpp_sources dest)
     expression/ParserExceptions.cpp
     expression/Value.cpp
     expression/tests/expression_parser_tests.cpp
+    io/JsonReader.cpp
     logging/LoggerHub.cpp
     logging/Sink.cpp
     logging/logging.cpp

src/lib/cmake/GetWindowsClientSources.cmake

@@ -74,6 +74,7 @@ function(get_cpp_sources dest)
     expression/ParserExceptions.cpp
     expression/Value.cpp
     expression/tests/expression_parser_tests.cpp
+    io/JsonReader.cpp
     logging/LoggerHub.cpp
     logging/Sink.cpp
     logging/logging.cpp

src/lib/collections/concurrent_factory.h

@@ -0,0 +1,98 @@
+#pragma once
+
+#include "lib/utils/LockBox.h"
+#include "lib/utils/bts_assert.h"
+#include "lib/utils/type_name.h"
+
+#include <functional>
+#include <memory>
+
+namespace bts::collections {
+
+template <class KeyT, class ValueT>
+class ConcurrentFactory {
+   utils::LockBox<std::unordered_map<KeyT, std::shared_ptr<ValueT>>> store;
+
+ public:
+   std::shared_ptr<ValueT> add(
+       const KeyT &key,
+       std::function<void(std::shared_ptr<ValueT> &)> callback) {
+      return store.lock([&](auto &map) {
+         auto [it, is_new] = map.try_emplace(key, std::make_shared<ValueT>());
+         bts_assert_msgf(
+             is_new, "{}::add. Duplicate key '{}'",
+             utils::cached_type_name<ConcurrentFactory<KeyT, ValueT>>(), key);
+         callback(it->second);
+         return it->second;
+      });
+   }
+
+   std::size_t erase(const KeyT &key) {
+      return store.lock([&](auto &map) {
+         map.erase(key);
+         return map.size();
+      });
+   }
+
+   std::size_t size() const {
+      return store.lock([&](auto &map) { return map.size(); });
+   }
+
+   template <
+       typename CallbackT = std::function<void(std::shared_ptr<ValueT> &)>>
+   std::shared_ptr<const ValueT> get(const KeyT &key, CallbackT callback) {
+      return store.lock([&](auto &map) {
+         auto [it, is_new] = map.try_emplace(key, std::make_shared<ValueT>());
+         bts_assert_msgf(
+             !is_new, "{}::get. Key not found '{}'",
+             utils::cached_type_name<ConcurrentFactory<KeyT, ValueT>>(), key);
+         callback(it->second);
+         return it->second;
+      });
+   }
+
+   template <
+       typename CallbackT =
+           std::function<void(std::shared_ptr<ValueT> &, bool)>>
+   std::shared_ptr<const ValueT> get_or_add(
+       const KeyT &key, CallbackT callback) {
+      return store.lock([&](auto &map) {
+         auto [it, is_new] = map.try_emplace(key);
+         if (is_new) {
+            it->second = std::make_shared<ValueT>();
+         }
+         callback(it->second, is_new);
+         return it->second;
+      });
+   }
+
+   template <
+       typename CallbackT =
+           std::function<void(std::shared_ptr<ValueT> &, bool)>>
+   std::shared_ptr<const ValueT> replace(const KeyT &key, CallbackT callback) {
+      return store.lock([&](auto &map) {
+         auto [it, is_new] = map.try_emplace(key);
+         bts_assert_msgf(
+             !is_new, "{}::replace. Key not found '{}'",
+             utils::cached_type_name<ConcurrentFactory<KeyT, ValueT>>(), key);
+         it->second = std::make_shared<ValueT>();
+         callback(it->second, is_new);
+         return it->second;
+      });
+   }
+
+   template <
+       typename CallbackT =
+           std::function<void(std::shared_ptr<ValueT> &, bool)>>
+   std::shared_ptr<const ValueT> replace_or_add(
+       const KeyT &key, CallbackT callback) {
+      return store.lock([&](auto &map) {
+         auto [it, is_new] = map.try_emplace(key);
+         it->second = std::make_shared<ValueT>();
+         callback(it->second, is_new);
+         return it->second;
+      });
+   }
+};
+
+} // namespace bts::collections

src/lib/config/profiles/default/okx_exe_cfg.conf

@@ -0,0 +1,17 @@
+OkxExeCfg {
+    value{
+        account : "ACC A"
+        ops_id : "op_id_bts"
+        secret_key : "DAF6CBB09475D2520B88D2070788A976"
+        api_key : "4492a9ab-5784-454c-acc7-38dc2a503ed0"
+        passphrase : "Pakistan@123"
+        ws_url : "wss://wspap.okx.com:8443"
+        rest_url : "https://www.okx.com"
+        ws_ping_timeout_seconds : 10 
+        ws_ping_interval_seconds : 25
+        ws_reconnect_interval_seconds : 5
+        ws_reconnect_max_count : 5
+        simulated_trading : true
+        tdmode : "cross"
+    }
+}

src/lib/config/profiles/default/orderman_cfg.conf

@@ -1,34 +1,34 @@
 OrdermanCfg {
-   rule: "DeploymentType.type == 'dev'"
-   value {
-      executor {
-         thread_name: "oman_orders"
-	 poll: false 
-	 hosted_actor: "MDSource"
-	 hosted_actor: "OrderManager"
-	 hosted_actor: "ExecutionGateway"
-      }
-      executor {
-         thread_name: "oman_slow"
-	 poll: false 
-	 hosted_actor: "*"
-      }
-   }
+  rule: "DeploymentType.type == 'dev'"
+  value {
+    executor {
+      thread_name: "oman_orders"
+      poll: false 
+      hosted_actor: "MDSource"
+      hosted_actor: "OrderManager"
+      hosted_actor: "ExecutionGateway"
+    }
+    executor {
+      thread_name: "oman_slow"
+      poll: false 
+	    hosted_actor: "*"
+    }
+  }
 }
 
 OrdermanCfg {
-   value {
-      executor {
-         thread_name: "oman_orders"
-	 poll: true 
-	 hosted_actor: "MDSource"
-	 hosted_actor: "OrderManager"
-	 hosted_actor: "ExecutionGateway"
-      }
-      executor {
-         thread_name: "oman_slow"
-	 poll: false 
-	 hosted_actor: "*"
-      }
-   }
-}
+  value {
+    executor {
+      thread_name: "oman_orders"
+      poll: true 
+      hosted_actor: "MDSource"
+      hosted_actor: "OrderManager"
+      hosted_actor: "ExecutionGateway"
+    }
+    executor {
+      thread_name: "oman_slow"
+	    poll: false 
+      hosted_actor: "*"
+    }
+  }
+}

src/lib/config/protos/okx_exe_cfg.proto

@@ -0,0 +1,18 @@
+syntax = "proto3";
+package bts.config;
+message OkxExeCfg {
+    string account = 1;
+    string ops_id = 2;
+    string secret_key = 3;
+    string api_key = 4;
+    string passphrase = 5;
+    string ws_url = 6;
+    string rest_url = 7;
+    uint32 ws_ping_timeout_seconds = 8;
+    uint32 ws_ping_interval_seconds = 9;
+    uint32 ws_reconnect_interval_seconds = 10;
+    uint32 ws_reconnect_max_count = 11;
+    bool simulated_trading = 12;
+    string tdmode = 13;
+
+}

src/lib/core/EnumMacros.h

@@ -110,6 +110,19 @@
    ENUM_TO_JSON(type)                                                          \
    ENUM_EQUALITY_OPS(type)
 
+#define ENUM_CLASS_DEF_NO_JSON(type, for_all)                                  \
+   class type {                                                                \
+    public:                                                                    \
+      enum Value { for_all(ENUM_DECLARE_VALUE) };                              \
+                                                                               \
+      ENUM_BASIC_MEMBERS(type)                                                 \
+   };                                                                          \
+                                                                               \
+   ENUM_OUTPUT_OPS(type)                                                       \
+   ENUM_NAME_DEF(type, for_all)                                                \
+   ENUM_PARSE_DEF(type, for_all)                                               \
+   ENUM_EQUALITY_OPS(type)
+
 #define ENUM_BITWISE_COMPARISON_OP(enum_type, numeric_type, op)                \
    constexpr enum_type operator op(enum_type lhs, enum_type rhs) noexcept {    \
       return static_cast<enum_type>(static_cast<numeric_type>(lhs)             \
@@ -154,3 +167,4 @@
    inline void to_json(nlohmann::json &j, const enum_type &value) {            \
       j = enum_type##_Name(value);                                             \
    }
+

src/lib/core/TimeStamp.cpp

@@ -1,6 +1,7 @@
 #include "TimeStamp.h"
 #include "lib/utils/datetime.h"
 #include <boost/date_time/posix_time/time_formatters.hpp>
+#include <google/protobuf/timestamp.pb.h>
 
 namespace bts::core {
 
@@ -43,6 +44,12 @@ bool TimeStamp::from_ymd(
    return true;
 }
 
+void TimeStamp::to_protobuf(google::protobuf::Timestamp &ts) const {
+   ts.set_seconds(seconds());
+   bts_assert(nanos() >= seconds() * 1'000'000'000);
+   ts.set_nanos(nanos() - seconds() * 1'000'000'000);
+}
+
 TimeStamp TimeStamp::from_iso_string(const std::string &iso_string) {
    auto ptime = datetime::parse_iso_date_time_string(iso_string);
    return from_ptime(ptime);

src/lib/core/TimeStamp.h

@@ -10,6 +10,7 @@
 #include <boost/date_time/time.hpp>
 #include <cstdint>
 #include <fmt/format.h>
+#include <google/protobuf/timestamp.pb.h>
 #include <limits>
 #include <string>
 
@@ -87,6 +88,7 @@ struct TimeStamp {
    // Gets a TimeStamp representing this date at midnight.
    TimeStamp date() const;
    constexpr boost::posix_time::ptime to_ptime() const;
+   void to_protobuf(google::protobuf::Timestamp &ts) const;
    std::string to_iso_string() const;
    // current epoch ns
    static uint64_t now_ns() {

src/lib/domain_model/PutOrCall.h

@@ -0,0 +1,52 @@
+#pragma once
+
+#include "lib/core/EnumMacros.h"
+#include "lib/core/FMT_IMPL.h"
+#include "lib/domain_model/Security.pb.h"
+#include "lib/io/JsonReader.h"
+#include "lib/logging/logging.h"
+#include "lib/utils/string_utils.h"
+
+#include <nlohmann/json.hpp>
+
+namespace bts::api {
+
+/**
+ * Parses PutOrCall from a string. Unlike `bts::api::SecurityType_Parse`, this
+ * implementation is case insensitive, and makes the 'PUTORCALL_' prefix optional.
+ */
+bool put_or_call_parse_smart(const std::string &str, PutOrCall *result);
+
+PB_ENUM_FROM_JSON(PutOrCall)
+PB_ENUM_TO_JSON(PutOrCall)
+
+std::ostream &operator<<(std::ostream &out, const PutOrCall &poc) noexcept;
+
+//////////////////////////////////////////////////
+// Definition
+//////////////////////////////////////////////////
+
+inline bool put_or_call_parse_smart(const std::string &str, PutOrCall *result) {
+   if (PutOrCall_Parse(str, result)) {
+      return true;
+   }
+   std::string s = bts::system::string_utils::copy_to_upper(str);
+   if (PutOrCall_Parse(s, result)) {
+      return true;
+   }
+   const char *prefix = "PUTORCALL_";
+   if (!s.starts_with(prefix)) {
+      s.insert(0, prefix);
+   }
+   return PutOrCall_Parse(s, result);
+}
+
+inline std::ostream &operator<<(
+    std::ostream &out, const PutOrCall &poc) noexcept {
+   out << PutOrCall_Name(poc);
+   return out;
+}
+
+} // namespace bts::api
+
+FMT_IMPL(bts::api::PutOrCall, poc, "{}", bts::api::PutOrCall_Name(poc));

src/lib/domain_model/Security.cpp

@@ -2,10 +2,13 @@
 #include "lib/config/config.h"
 #include "lib/config/protos/orders_fills_cleanup.pb.h"
 #include "lib/domain_model/Security.pb.h"
+#include "lib/io/JsonMacros.h"
 #include "lib/md/common.h"
+#include "lib/utils/pb_json_macros.h"
 
 #include <boost/date_time/posix_time/posix_time.hpp>
 #include <google/protobuf/text_format.h>
+#include <nlohmann/json.hpp>
 
 namespace bts {
 namespace securities {
@@ -191,3 +194,389 @@ std::string unique_descriptor(const api::Security &security) {
 
 } // namespace securities
 } // namespace bts
+
+namespace bts::api {
+
+using nlohmann::json;
+using std::uint32_t;
+
+void to_json(json &j, const api::ContractQuantityInfo &cqi) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, cqi, min_value);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, cqi, max_value);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, cqi, tick_unit);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, cqi, tick_base);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, cqi, multiplier);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, cqi, max_price);
+}
+
+void from_json(const json &j, api::ContractQuantityInfo &cqi) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, cqi, min_value, it);
+   PB_JSON_READ_VALUE(j, cqi, max_value, it);
+   PB_JSON_READ_VALUE(j, cqi, max_value, it);
+   PB_JSON_READ_VALUE(j, cqi, tick_unit, it);
+   PB_JSON_READ_VALUE(j, cqi, tick_base, it);
+   PB_JSON_READ_VALUE(j, cqi, max_price, it);
+}
+
+void to_json(json &j, const api::ContractSpecification &spec) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, low_tick);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, price_break);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, high_tick);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, cash_per_point);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, price_multiplier);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, main_fraction);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, sub_fraction);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, spec, price_display_format);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, spec, quantity_infos);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, spec, notional_quantity_infos);
+}
+
+void from_json(const json &j, api::ContractSpecification &spec) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, spec, low_tick, it);
+   PB_JSON_READ_VALUE(j, spec, price_break, it);
+   PB_JSON_READ_VALUE(j, spec, high_tick, it);
+   PB_JSON_READ_VALUE(j, spec, cash_per_point, it);
+   PB_JSON_READ_VALUE(j, spec, price_multiplier, it);
+   PB_JSON_READ_VALUE(j, spec, main_fraction, it);
+   PB_JSON_READ_VALUE(j, spec, sub_fraction, it);
+   PB_JSON_READ_VALUE(j, spec, price_display_format, it);
+   PB_JSON_READ_ARRAY(j, spec, quantity_infos, it);
+   PB_JSON_READ_ARRAY(j, spec, notional_quantity_infos, it);
+}
+
+void to_json(json &, const SpotContract &) {}
+void from_json(const json &, SpotContract &) {}
+
+template <class ExpContract>
+static void exp_to_json(json &j, const ExpContract &ec) {
+   j = bts::core::TimeStamp::from_ymd(
+           ec.expiration_year(), ec.expiration_month(), ec.expiration_day())
+           .to_iso_string();
+}
+
+template <class ExpContract>
+static void exp_from_json(const json &j, ExpContract &ec) {
+   const auto dt = bts::core::TimeStamp::from_iso_string(j.get<std::string>());
+   uint32_t y, m, d;
+   dt.to_date(y, m, d);
+   ec.set_expiration_year(y);
+   ec.set_expiration_month(m);
+   ec.set_expiration_day(d);
+}
+
+void to_json(json &j, const FutureContract &f) {
+   exp_to_json(j["expiration"], f);
+}
+
+void from_json(const json &j, FutureContract &f) {
+   const auto it = j.find("expiration");
+   if (it != j.end()) {
+      exp_from_json(*it, f);
+   }
+}
+
+void to_json(json &j, const OptionContract &opt) {
+   exp_to_json(j["expiration"], opt);
+   PB_JSON_WRITE_VALUE(j, opt, strike);
+   PB_JSON_WRITE_VALUE(j, opt, call_put);
+}
+
+void from_json(const json &j, OptionContract &opt) {
+   json::const_iterator it;
+   it = j.find("expiration");
+   if (it != j.end()) {
+      exp_from_json(*it, opt);
+   }
+   PB_JSON_READ_VALUE(j, opt, strike, it);
+   PB_JSON_READ_VALUE(j, opt, call_put, it);
+}
+
+void to_json(json &j, const ContractLeg &leg) {
+   PB_JSON_WRITE_STRUCT(j, leg, security);
+   PB_JSON_WRITE_VALUE(j, leg, quantity);
+   PB_JSON_WRITE_VALUE(j, leg, side);
+   PB_JSON_WRITE_VALUE(j, leg, price_multiplier);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, leg, leg_delta);
+   PB_JSON_WRITE_VALUE(j, leg, price_calc);
+}
+
+void from_json(const json &j, ContractLeg &leg) {
+   json::const_iterator it;
+   PB_JSON_READ_STRUCT(j, leg, security, it);
+   PB_JSON_READ_VALUE(j, leg, quantity, it);
+   PB_JSON_READ_VALUE(j, leg, side, it);
+   PB_JSON_READ_VALUE(j, leg, price_multiplier, it);
+   PB_JSON_READ_VALUE(j, leg, leg_delta, it);
+   PB_JSON_READ_VALUE(j, leg, price_calc, it);
+}
+
+void to_json(json &j, const SpreadContract &spd) {
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, spd, legs);
+}
+
+void from_json(const json &j, SpreadContract &spd) {
+   json::const_iterator it;
+   PB_JSON_READ_ARRAY(j, spd, legs, it);
+}
+
+void to_json(json &j, const SyntheticContract &syn) {
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, syn, name);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, syn, user_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, syn, legs);
+   PB_JSON_WRITE_VALUE(j, syn, price_calc);
+}
+
+void from_json(const json &j, SyntheticContract &syn) {
+   json::const_iterator it;
+   PB_JSON_READ_STRING(j, syn, name, it);
+   PB_JSON_READ_VALUE(j, syn, user_id, it);
+   PB_JSON_READ_ARRAY(j, syn, legs, it);
+   PB_JSON_READ_VALUE(j, syn, price_calc, it);
+}
+
+void to_json(json &j, const GLBXExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, cfi_code);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, cme_symbol);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, market_segment_id);
+}
+
+void from_json(const json &j, GLBXExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+   PB_JSON_READ_STRING(j, data, cfi_code, it);
+   PB_JSON_READ_STRING(j, data, cme_symbol, it);
+   PB_JSON_READ_VALUE(j, data, market_segment_id, it);
+}
+
+void to_json(json &j, const CBOEExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, class_key);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, source);
+}
+
+void from_json(const json &j, CBOEExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+   PB_JSON_READ_VALUE(j, data, class_key, it);
+   PB_JSON_READ_STRING(j, data, source, it);
+}
+
+void to_json(json &j, const CBOECFEExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, class_key);
+}
+
+void from_json(const json &j, CBOECFEExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+   PB_JSON_READ_VALUE(j, data, class_key, it);
+}
+
+void to_json(json &j, const ICEExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, price_denominator);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, deal_denominator);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, settle_denominator);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, market_description);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, cleared_alias);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, product_name);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, hub_alias);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, strip_name);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, mic_code);
+   PB_JSON_WRITE_IF_TRUE(j, data, is_strip);
+}
+
+void from_json(const json &j, ICEExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+   PB_JSON_READ_VALUE(j, data, price_denominator, it);
+   PB_JSON_READ_VALUE(j, data, deal_denominator, it);
+   PB_JSON_READ_VALUE(j, data, settle_denominator, it);
+   PB_JSON_READ_STRING(j, data, market_description, it);
+   PB_JSON_READ_STRING(j, data, cleared_alias, it);
+   PB_JSON_READ_STRING(j, data, product_name, it);
+   PB_JSON_READ_STRING(j, data, hub_alias, it);
+   PB_JSON_READ_STRING(j, data, strip_name, it);
+   PB_JSON_READ_STRING(j, data, mic_code, it);
+   PB_JSON_READ_VALUE(j, data, is_strip, it);
+}
+
+void to_json(json &j, const TAIFEXExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, class_key);
+}
+
+void from_json(const json &j, TAIFEXExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+   PB_JSON_READ_VALUE(j, data, class_key, it);
+}
+
+void to_json(json &j, const DeribitExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, DeribitExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const FTXExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, FTXExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const BinanceExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, BinanceExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const BinanceUsdsFuturesExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, BinanceUsdsFuturesExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const BinanceCoinFuturesExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, BinanceCoinFuturesExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const BinanceUsExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, BinanceUsExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const OkxExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, OkxExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const CoinbaseExchangeData &data) {
+   PB_JSON_WRITE_IF_NOT_ZERO(j, data, exchange_id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, data, security_desc);
+}
+
+void from_json(const json &j, CoinbaseExchangeData &data) {
+   json::const_iterator it;
+   PB_JSON_READ_VALUE(j, data, exchange_id, it);
+   PB_JSON_READ_STRING(j, data, security_desc, it);
+}
+
+void to_json(json &j, const Security &s) {
+   // clang-format off
+#define CONTRACT_ONEOF(oneof)           \
+   oneof(j, s, Spot, spot)              \
+   oneof(j, s, Future, future)          \
+   oneof(j, s, Option, option)          \
+   oneof(j, s, Spread, spread)          \
+   oneof(j, s, Synthetic, synthetic)
+
+#define EXCHANGE_DATA_ONEOF(oneof)                        \
+   oneof(j, s, Glbx, glbx)                                \
+   oneof(j, s, Cboe, cboe)                                \
+   oneof(j, s, Cfe, cfe)                                  \
+   oneof(j, s, Ice, ice)                                  \
+   oneof(j, s, Deribit, deribit)                          \
+   oneof(j, s, Ftx, ftx)                                  \
+   oneof(j, s, Binance, binance)                          \
+   oneof(j, s, BinanceCoinFutures, binance_coin_futures)  \
+   oneof(j, s, BinanceUsdsFutures, binance_usds_futures)  \
+   oneof(j, s, BinanceUs, binance_us)                     \
+   oneof(j, s, Coinbase, coinbase)                        \
+   oneof(j, s, Okx, okx)                                  \
+   oneof(j, s, Taifex, taifex)
+   // clang-format on
+
+   PB_JSON_WRITE_IF_NOT_ZERO(j, s, id);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, s, symbol);
+   PB_JSON_WRITE_VALUE(j, s, exchange);
+   PB_JSON_WRITE_STRUCT(j, s, contract_spec);
+   PB_JSON_WRITE_IF_NOT_EMPTY(j, s, currency);
+   PB_JSON_WRITE_ONEOF(j, s, Contract, CONTRACT_ONEOF);
+   PB_JSON_WRITE_ONEOF(j, s, ExchangeData, EXCHANGE_DATA_ONEOF);
+}
+
+void from_json(const json &j, Security &s) {
+   json::const_iterator it;
+
+#define SEC_TYPE_ONEOF(oneof)                                                  \
+   oneof(j, s, future, it);                                                    \
+   oneof(j, s, option, it);                                                    \
+   oneof(j, s, spread, it);                                                    \
+   oneof(j, s, synthetic, it)
+
+#define CONTRACT_CASE_ONEOF(oneof)                                             \
+   oneof(j, s, glbx, it);                                                      \
+   oneof(j, s, cboe, it);                                                      \
+   oneof(j, s, cfe, it);                                                       \
+   oneof(j, s, ice, it);                                                       \
+   oneof(j, s, deribit, it);                                                   \
+   oneof(j, s, ftx, it);                                                       \
+   oneof(j, s, binance, it);                                                   \
+   oneof(j, s, binance_usds_futures, it);                                      \
+   oneof(j, s, binance_coin_futures, it);                                      \
+   oneof(j, s, binance_us, it);                                                \
+   oneof(j, s, coinbase, it);                                                  \
+   oneof(j, s, okx, it);                                                       \
+   oneof(j, s, taifex, it);
+
+   PB_JSON_READ_VALUE(j, s, id, it);
+   PB_JSON_READ_STRING(j, s, symbol, it);
+   PB_JSON_READ_STRING(j, s, currency, it);
+   PB_JSON_READ_STRUCT(j, s, contract_spec, it);
+   PB_JSON_READ_ONEOFS(SEC_TYPE_ONEOF);
+   PB_JSON_READ_ONEOFS(CONTRACT_CASE_ONEOF);
+}
+
+} // namespace bts::api

src/lib/domain_model/Security.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include "lib/core/FMT_IMPL.h"
+#include "lib/domain_model/PutOrCall.h"
 #include "lib/domain_model/Security.pb.h"
 #include "lib/domain_model/SecurityType.h"
 #include "lib/domain_model/Side.h"
@@ -9,6 +9,7 @@
 #include "lib/utils/bts_assert.h"
 
 #include <cmath>
+#include <nlohmann/json_fwd.hpp>
 
 namespace boost {
 namespace gregorian {
@@ -16,14 +17,83 @@ class date;
 }
 } // namespace boost
 
-namespace bts {
+namespace bts::api {
 
-namespace api {
 class Security;
 class ICEExchangeData;
-} // namespace api
 
-namespace securities {
+void to_json(nlohmann::json &j, const ContractQuantityInfo &c);
+void from_json(const nlohmann::json &j, ContractQuantityInfo &c);
+
+void to_json(nlohmann::json &j, const ContractSpecification &c);
+void from_json(const nlohmann::json &j, ContractSpecification &c);
+
+void to_json(nlohmann::json &j, const ContractLeg &c);
+void from_json(const nlohmann::json &j, ContractLeg &c);
+
+void to_json(nlohmann::json &j, const SpotContract &c);
+void from_json(const nlohmann::json &j, SpotContract &c);
+
+void to_json(nlohmann::json &j, const FutureContract &c);
+void from_json(const nlohmann::json &j, FutureContract &c);
+
+void to_json(nlohmann::json &j, const OptionContract &c);
+void from_json(const nlohmann::json &j, OptionContract &c);
+
+void to_json(nlohmann::json &j, const SpreadContract &c);
+void from_json(const nlohmann::json &j, SpreadContract &c);
+
+void to_json(nlohmann::json &j, const SyntheticContract_PriceCalc &c);
+void from_json(const nlohmann::json &j, SyntheticContract_PriceCalc &c);
+
+void to_json(nlohmann::json &j, const SyntheticContract &c);
+void from_json(const nlohmann::json &j, SyntheticContract &c);
+
+void to_json(nlohmann::json &j, const GLBXExchangeData &data);
+void from_json(const nlohmann::json &j, GLBXExchangeData &data);
+
+void to_json(nlohmann::json &j, const CBOEExchangeData &data);
+void from_json(const nlohmann::json &j, CBOEExchangeData &data);
+
+void to_json(nlohmann::json &j, const CBOECFEExchangeData &data);
+void from_json(const nlohmann::json &j, CBOECFEExchangeData &data);
+
+void to_json(nlohmann::json &j, const ICEExchangeData &data);
+void from_json(const nlohmann::json &j, ICEExchangeData &data);
+
+void to_json(nlohmann::json &j, const DeribitExchangeData &data);
+void from_json(const nlohmann::json &j, DeribitExchangeData &data);
+
+void to_json(nlohmann::json &j, const FTXExchangeData &data);
+void from_json(const nlohmann::json &j, FTXExchangeData &data);
+
+void to_json(nlohmann::json &j, const BinanceExchangeData &data);
+void from_json(const nlohmann::json &j, BinanceExchangeData &data);
+
+void to_json(nlohmann::json &j, const BinanceUsdsFuturesExchangeData &data);
+void from_json(const nlohmann::json &j, BinanceUsdsFuturesExchangeData &data);
+
+void to_json(nlohmann::json &j, const BinanceCoinFuturesExchangeData &data);
+void from_json(const nlohmann::json &j, BinanceCoinFuturesExchangeData &data);
+
+void to_json(nlohmann::json &j, const BinanceUsExchangeData &data);
+void from_json(const nlohmann::json &j, BinanceUsExchangeData &data);
+
+void to_json(nlohmann::json &j, const OkxExchangeData &data);
+void from_json(const nlohmann::json &j, OkxExchangeData &data);
+
+void to_json(nlohmann::json &j, const CoinbaseExchangeData &data);
+void from_json(const nlohmann::json &j, CoinbaseExchangeData &data);
+
+void to_json(nlohmann::json &j, const Security &s);
+void from_json(const nlohmann::json &j, Security &s);
+
+PB_ENUM_FROM_JSON(SyntheticContract_PriceCalc);
+PB_ENUM_TO_JSON(SyntheticContract_PriceCalc);
+
+} // namespace bts::api
+
+namespace bts::securities {
 
 /**
  * Gets a descriptor string for a security (should be unique within a particular exchange).
@@ -60,7 +130,8 @@ inline api::Side other_side(api::Side side) {
       return side;
    }
 }
-template <class V> class TwoSided {
+template <class V>
+class TwoSided {
  public:
    TwoSided() : buy(), sell() {}
 
@@ -104,7 +175,8 @@ inline bool is_worse(api::Side s, Price p1, Price p2) {
    return is_better(s, p2, p1);
 }
 
-template <class C> void apply_to_both_sides(C c) {
+template <class C>
+void apply_to_both_sides(C c) {
    c(api::SIDE_BUY);
    c(api::SIDE_SELL);
 }
@@ -178,8 +250,8 @@ inline Price encode_exchange_price(api::Security const &sec, Price in) {
       return in;
 }
 
-inline double
-raw_round_to_quote_price(double raw_price, double tick_size, api::Side side) {
+inline double raw_round_to_quote_price(
+    double raw_price, double tick_size, api::Side side) {
    double factor = 1000000000;
    auto i_price = llround(factor * raw_price);
    auto i_tick_size = llround(tick_size * factor);
@@ -222,8 +294,8 @@ inline double checked_round_to_quote_price(
    }
 }
 
-inline Price
-round_to_quote_price(api::Security const &sec, Price in, api::Side side) {
+inline Price round_to_quote_price(
+    api::Security const &sec, Price in, api::Side side) {
    auto p = in.value();
    bts_assert_d(!std::isnan(p));
    if (p < -sec.contract_spec().price_break() ||
@@ -287,8 +359,8 @@ inline const std::string &descriptor(
 // Looking to round md::IntPrice? Look in IntPrice.h
 
 // computes price_2 - price_1 in ticks
-inline int
-price_diff_to_ticks(double price_1, double price_2, double tick_size) {
+inline int price_diff_to_ticks(
+    double price_1, double price_2, double tick_size) {
    return static_cast<int>(std::round((price_2 - price_1) / tick_size));
 }
 // returns the difference (in ticks) bw and order and a market.
@@ -312,8 +384,8 @@ inline int order_diff_market(
 // simple double equality can not be used to compare prices.
 // this function deems 2 prices to be equal if they are within
 // 1 % of the tick size
-inline bool
-test_price_equality(double price_1, double price_2, double tick_size) {
+inline bool test_price_equality(
+    double price_1, double price_2, double tick_size) {
    return std::fabs(price_2 - price_1) < 0.01 * tick_size;
 }
 inline bool gr_than_eq(double p1, double p2, double tick_size) {
@@ -362,7 +434,4 @@ inline bool is_spread_of_strips(const bts::api::Security &sec) {
    return false;
 }
 
-} // namespace securities
-} // namespace bts
-
-FMT_IMPL(bts::api::Security, s, "{}", bts::securities::descriptor(s));
+} // namespace bts::securities

src/lib/domain_model/common.h

@@ -33,8 +33,8 @@ struct CQuantity {
    uint32_t value() const { return static_cast<uint32_t>(qty); }
    double full_value() const { return qty; }
    float full_value_float() const { return static_cast<float>(full_value()); }
-   uint32_t int_part() { return static_cast<uint32_t>(qty); }
-   double fractional_part() { return full_value() - int_part(); }
+   uint32_t int_part() const { return static_cast<uint32_t>(qty); }
+   double fractional_part() const { return full_value() - int_part(); }
    static bool equal_d(double d1, double d2) {
       return std::abs(d1 - d2) <= err;
    }

src/lib/io/JsonMacros.h

@@ -3,18 +3,14 @@
 #define _TO_JSON_FIELD(field) j[#field] = t.field;
 #define _FROM_JSON_FIELD(field) bts::io::JsonReader{&j, #field}.read(t.field);
 
-#define SPARK_TO_JSON_IMPL(type, for_each)                                     \
-   inline void to_json(nlohmann::json &j, const type &t) {                     \
-      FOR_EACH(_TO_JSON_FIELD)                                                 \
-   }
+#define SPARK_TO_JSON_IMPL(type, fields)                                       \
+   void to_json(nlohmann::json &j, const type &t) { fields(_TO_JSON_FIELD) }
 
-#define SPARK_FROM_JSON_IMPL(type, for_each)                                   \
-   inline void from_json(const nlohmann::json &j, type &t) {                   \
-      FOR_EACH(_FROM_JSON_FIELD)                                               \
-   }
+#define SPARK_FROM_JSON_IMPL(type, fields)                                     \
+   void from_json(const nlohmann::json &j, type &t) { fields(_FROM_JSON_FIELD) }
 
 #define OSTREAM_JSON_IMPL(type)                                                \
-   inline std::ostream &operator<<(std::ostream &out, const type &t) {         \
+   std::ostream &operator<<(std::ostream &out, const type &t) {                \
       nlohmann::json j;                                                        \
       to_json(j, t);                                                           \
       out << j.dump(2);                                                        \

src/lib/io/JsonReader.h

@@ -94,7 +94,18 @@ class JsonReader {
     * @return True if the read succeeds, otherwise false
     */
    template <class T>
-   bool read_or(const std::string &name, T &result, T default_value) const;
+   bool read_or(const std::string &name, T &result, T default_value = {}) const;
+
+   template <class T>
+   bool read_optional_or(
+       std::optional<T> &result,
+       std::optional<T> default_value = std::nullopt) const;
+
+   template <class T>
+   bool read_optional_or(
+       const std::string &name,
+       std::optional<T> &result,
+       std::optional<T> default_value = std::nullopt) const;
 
  private:
    const nlohmann::json *json_;
@@ -269,6 +280,33 @@ inline bool JsonReader::read_or(
    return false;
 }
 
+template <class T>
+inline bool JsonReader::read_optional_or(
+    std::optional<T> &result, std::optional<T> default_value) const {
+   if (read_optional(result)) {
+      return true;
+   }
+   result = std::move(default_value);
+   return false;
+}
+
+template <class T>
+inline bool JsonReader::read_optional_or(
+    const std::string &name,
+    std::optional<T> &result,
+    std::optional<T> default_value) const {
+   if (json_ && json_->is_object()) {
+      auto it = json_->find(name);
+      if (it != json_->end()) {
+         if (JsonReader{&it.value()}.read_optional(result)) {
+            return true;
+         }
+      }
+   }
+   result = std::move(default_value);
+   return false;
+}
+
 template <class T>
 bool JsonReader::read_flat(
     const std::vector<nlohmann::json> &items, std::vector<T> &result) {

src/lib/io/http/curl_session.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "lib/logging/logging.h"
+
 #include <atomic>
 #include <curl/curl.h>
 #include <curl/easy.h>
@@ -12,6 +14,7 @@ struct CurlSession {
 
    CurlSession() {
       if (++ref_count == 1) {
+         LOG(Http, Info, "Initializing curl (global)");
          curl_global_init(CURL_GLOBAL_ALL);
       }
       curl = curl_easy_init();
@@ -20,6 +23,7 @@ struct CurlSession {
    ~CurlSession() {
       curl_easy_cleanup(curl);
       if (--ref_count == 0) {
+         LOG(Http, Info, "Cleaning up curl (global)");
          curl_global_cleanup();
       }
    }

src/lib/io/http/http_client.cpp

@@ -34,7 +34,31 @@ static size_t write_headers(
     void *ptr, size_t size, size_t nmemb, IHttpResponse *data) {
    return data->write_headers((char *)ptr, size, nmemb);
 }
-
+// static int curl_debug_callback(CURL *handle, curl_infotype type, char *data, size_t size, void *userptr) {
+//    (void)handle;
+//    (void)type;
+//    (void)userptr;
+//     switch (type) {
+//         case CURLINFO_TEXT:
+//             LOG(Http, Info, "CURLINFO_TEXT: {}", std::string(data, size));
+//             break;
+//         case CURLINFO_HEADER_IN:
+//             LOG(Http, Info, "Header In: {}", std::string(data, size));
+//             break;
+//         case CURLINFO_HEADER_OUT:
+//             LOG(Http, Info, "Header Out: {}", std::string(data, size));
+//             break;
+//         case CURLINFO_DATA_IN:
+//             LOG(Http, Info, "Data In: {} bytes, in: {}", size,std::string(data, size));
+//             break;
+//         case CURLINFO_DATA_OUT:
+//             LOG(Http, Info, "Data Out: {} bytes, out: {}", size, std::string(data, size));
+//             break;
+//         default:
+//             break;
+//     }
+//     return 0;
+// }
 void HttpClient::get(
     string url,
     unordered_map<string, string> headers,
@@ -91,7 +115,12 @@ void HttpClient::send(const HttpRequest &req, IHttpResponse *response) {
    CURL *curl = session.curl;
    CurlHeaders curl_headers{req.headers};
    // Prepare req
-   curl_easy_setopt(curl, CURLOPT_FAILONERROR, true);
+   //to debug curl requests
+   // curl_easy_setopt(curl, CURLOPT_DEBUGFUNCTION, curl_debug_callback);
+   // Disable signals to avoid strange stack corruption related to set/longjmp
+   // https://stackoverflow.com/questions/9191668/error-longjmp-causes-uninitialized-stack-frame
+   curl_easy_setopt(curl, CURLOPT_NOSIGNAL, 1L);
+   curl_easy_setopt(curl, CURLOPT_FAILONERROR, 0L);
    curl_easy_setopt(curl, CURLOPT_URL, req.url.c_str());
    curl_easy_setopt(curl, CURLOPT_HTTPHEADER, curl_headers.data());
    if (response != nullptr) {
@@ -108,6 +137,7 @@ void HttpClient::send(const HttpRequest &req, IHttpResponse *response) {
       curl_easy_setopt(curl, CURLOPT_HTTPPOST, 1L);
       curl_easy_setopt(curl, CURLOPT_POSTFIELDS, req.body.c_str());
       curl_easy_setopt(curl, CURLOPT_POSTFIELDSIZE, req.body.size());
+      // curl_easy_setopt(curl, CURLOPT_VERBOSE, 1L);
       break;
    case io::http::HttpMethod::PUT:
       curl_easy_setopt(curl, CURLOPT_CUSTOMREQUEST, "PUT");

src/lib/io/json_formatter.h

@@ -0,0 +1,54 @@
+#pragma once
+
+#include <fmt/format.h>
+#include <nlohmann/json.hpp>
+#include <string>
+
+namespace bts::io {
+
+/**
+ * This wrapper struct provides a means to format arbitrary objects as json
+ * in templated strings (e.g., LOG macros).
+ */
+template <class T>
+struct JsonFormatter {
+   T value;
+
+   std::string to_string() const { return fmt::format("{}", *this); }
+};
+
+template <class T>
+JsonFormatter<T> json_formatter(T value) {
+   return JsonFormatter<T>{std::move(value)};
+}
+
+} // namespace bts::io
+
+template <class T>
+struct fmt::formatter<bts::io::JsonFormatter<T>> {
+   int indent = -1;
+
+   constexpr auto parse(fmt::format_parse_context &ctx) -> decltype(ctx.end()) {
+      const auto end = ctx.end();
+      auto it = ctx.begin();
+      if (it != end) {
+         indent = 0;
+         do {
+            int x = *it - '0';
+            if (x < 0 || x > 9) {
+               return it;
+            }
+            indent = indent * 10 + x;
+         } while (++it != end);
+      }
+      return it;
+   }
+
+   template <typename FormatContext>
+   auto format(const bts::io::JsonFormatter<T> &jf, FormatContext &ctx) const
+       -> decltype(ctx.out()) {
+      nlohmann::json j;
+      to_json(j, jf.value);
+      return fmt::format_to(ctx.out(), "{}", j.dump(indent));
+   }
+};

src/lib/io/websocket/websocket_client.cpp

@@ -3,14 +3,19 @@
 #include "lib/core/TimeSpan.h"
 #include "lib/core/TimeStamp.h"
 #include "lib/io/websocket/websocket_client_config.h"
+#include "lib/io/websocket/websocket_client_logger.h"
 #include "lib/io/websocket/websocket_client_state.h"
 #include "lib/io/websocket/websocket_close_status.h"
 #include "lib/io/websocket/websocket_error_code.h"
 #include "lib/io/websocket/websocketpp_exception_formatter.h"
 #include "lib/logging/logging.h"
+#include "lib/utils/bts_assert.h"
 #include "lib/utils/formatters/exception_formatter.h"
 
+#include <algorithm>
 #include <atomic>
+#include <boost/asio/io_context.hpp>
+#include <chrono>
 #include <exception>
 #include <fmt/format.h>
 #include <mutex>
@@ -18,6 +23,7 @@
 #include <optional>
 #include <stdexcept>
 #include <string>
+#include <system_error>
 #include <thread>
 #include <websocketpp/close.hpp>
 #include <websocketpp/common/connection_hdl.hpp>
@@ -28,11 +34,51 @@
 #include <websocketpp/config/core_client.hpp>
 #include <websocketpp/roles/client_endpoint.hpp>
 
+namespace websocketpp::config {
+
+/// Client config with asio transport and TLS enabled
+struct bts_asio_tls_client : public core_client {
+   typedef bts_asio_tls_client type;
+   typedef core_client base;
+
+   typedef base::concurrency_type concurrency_type;
+
+   typedef base::request_type request_type;
+   typedef base::response_type response_type;
+
+   typedef base::message_type message_type;
+   typedef base::con_msg_manager_type con_msg_manager_type;
+   typedef base::endpoint_msg_manager_type endpoint_msg_manager_type;
+
+   typedef websocketpp::log::WebsocketClientLogger<
+       websocketpp::log::ElevelAdapter>
+       elog_type;
+   typedef websocketpp::log::WebsocketClientLogger<
+       websocketpp::log::AlevelAdapter>
+       alog_type;
+
+   typedef base::rng_type rng_type;
+
+   struct transport_config : public base::transport_config {
+      typedef type::concurrency_type concurrency_type;
+      typedef type::alog_type alog_type;
+      typedef type::elog_type elog_type;
+      typedef type::request_type request_type;
+      typedef type::response_type response_type;
+      typedef transport::asio::tls_socket::endpoint socket_type;
+   };
+
+   typedef transport::asio::endpoint<transport_config> transport_type;
+};
+
+} // namespace websocketpp::config
+
 namespace bts::websocket {
 
 struct WebsocketClientSnapshot {
    int client_id;
    WebsocketClientState state;
+   int n_reconnects;
    int version;
 };
 
@@ -41,9 +87,10 @@ struct WebsocketClientSnapshot {
 FMT_IMPL(
     bts::websocket::WebsocketClientSnapshot,
     t,
-    "id: {}; state: {}; version: {}",
+    "id: {}; state: {}; n_reconnects: {}; version: {}",
     t.client_id,
     t.state,
+    t.n_reconnects,
     t.version);
 
 namespace bts::websocket {
@@ -61,10 +108,11 @@ using std::size_t;
 using std::string;
 using std::thread;
 using std::uint32_t;
-using websocketpp::config::asio_tls_client;
+using std::chrono::nanoseconds;
+using std::this_thread::sleep_for;
 
 using WebsocketppClient =
-    websocketpp::client<websocketpp::config::asio_tls_client>;
+    websocketpp::client<websocketpp::config::bts_asio_tls_client>;
 using ConnectionHdl = websocketpp::connection_hdl;
 using ConnectionPtr = WebsocketppClient::connection_ptr;
 using MessageTypePtr = websocketpp::config::core_client::message_type::ptr;
@@ -85,9 +133,16 @@ using State = WebsocketClientState;
 #define ERROR(...) LOG(Http, Error, __VA_ARGS__)
 #define ERROR_FN(...) LOG(Http, Error, "WebsocketClient::" __VA_ARGS__)
 
+static bts::core::TimeSpan reconnect_interval(std::uint32_t n_attempts) {
+   std::int64_t secs = 5 * n_attempts;
+   secs = std::clamp(secs, 5L, 300L);
+   return bts::core::TimeSpan::from_seconds(secs);
+}
+
 struct WebsocketClient::PImpl {
    WebsocketClientConfig config;
    WebsocketppClient client{};
+   boost::asio::io_context *io_context = nullptr;
    WebsocketppClient::connection_ptr con;
    optional<OpenHandler> open_handler;
    optional<MessageHandler> message_handler;
@@ -97,8 +152,48 @@ struct WebsocketClient::PImpl {
    optional<thread> io_thread;
    int client_id{client_id_counter++};
    mutex instance_mx;
-   State state;
+   State state = State::IDLE;
    int version = 0;
+   int n_reconnects = 0;
+
+   PImpl(WebsocketClientConfig config, boost::asio::io_context *io_context)
+       : config(std::move(config)), io_context(io_context) {
+      client.get_alog().set_name(this->config.name);
+      client.get_elog().set_name(this->config.name);
+      client.set_access_channels(websocketpp::log::alevel::all);
+      // client.clear_access_channels(websocketpp::log::alevel::frame_payload);
+      client.set_error_channels(websocketpp::log::elevel::all);
+      if (io_context == nullptr) {
+         client.init_asio();
+      } else {
+         client.init_asio(io_context);
+      }
+      client.set_message_handler(
+          [this](auto hdl, auto msg) { on_message(hdl, msg); });
+      client.set_open_handler([this](auto hdl) { on_open(hdl); });
+      client.set_ping_handler([](auto /*hdl*/, auto /*msg*/) {
+         LOG(Http, Info, "Received ping");
+         return true;
+      });
+      client.set_pong_timeout(0);
+      client.set_pong_handler([](auto /*hdl*/, auto /*msg*/) {
+         LOG(Http, Info, "Received pong");
+         return true;
+      });
+      client.set_tls_init_handler([&](auto hdl) { return on_tls_init(hdl); });
+      client.set_close_handler([=, this](auto hdl) {
+         on_close(hdl);
+         if (config.reconnect_on_close) {
+            sleep_for(nanoseconds{reconnect_interval(n_reconnects).nanos()});
+            connect();
+         }
+      });
+      client.set_fail_handler([this](auto hdl) {
+         const auto ec = client.get_con_from_hdl(hdl)->get_ec();
+         ERROR_FN("fail_handler. {}; err: {}", snapshot(), ec.message());
+         on_fail(hdl);
+      });
+   }
 
    ~PImpl() {
       if (io_thread) {
@@ -119,7 +214,7 @@ struct WebsocketClient::PImpl {
    }
 
    constexpr WebsocketClientSnapshot snapshot() const {
-      return {client_id, state, version};
+      return {client_id, state, n_reconnects, version};
    }
 
    void close(websocketpp::close::status::value code, std::string reason) {
@@ -163,8 +258,7 @@ struct WebsocketClient::PImpl {
    /**
     * Connects to the websocket server
     */
-   void connect(
-       const map<string, string> &headers, bool run_in_background = true) {
+   void connect() {
       lock_guard<mutex> lock{instance_mx};
       INFO_FN("connect. {}", snapshot());
       switch (state.value) {
@@ -176,9 +270,6 @@ struct WebsocketClient::PImpl {
       }
       set_state(State::OPENING);
       try {
-         init_logging();
-         init_handlers();
-         // Get connection
          websocketpp::lib::error_code ec;
          con = client.get_connection(config.url, ec);
          if (ec) {
@@ -186,46 +277,27 @@ struct WebsocketClient::PImpl {
             return;
          }
          // Add headers
-         for (const auto &[k, v] : headers) {
+         for (const auto &[k, v] : config.headers) {
             con->append_header(k, v);
          }
          // Connect
          client.connect(con);
-         if (run_in_background) {
-            bts_assert_msgf(
-                !io_thread, "Websocket io_thread already instantiated. {}",
-                snapshot());
-            io_thread = std::thread{[this]() { run(); }};
-            if (config.connect_timeout > core::TimeSpan::zero()) {
-               wait_for_connect(config.connect_timeout);
-            }
-         }
       } catch (const std::exception &ex) {
+         std::string str = ex.what();
          ERROR_FN(
              "connect_no_timeout. Failed to connect. {}; err: {}", snapshot(),
-             ex);
+             str);
          set_state(State::IDLE);
          // Don't wait for connect
          return;
       }
    }
 
-   void wait_for_connect(const TimeSpan timeout) {
-      INFO_FN("wait_for_connect. {}; timeout: {}", snapshot(), timeout);
-      const auto start = TimeStamp::now();
-      while (state == State::OPENING) {
-         const auto elapsed = TimeStamp::now() - start;
-         const auto rem = timeout - elapsed;
-         if (rem < TimeSpan::zero()) {
-            throw std::runtime_error{fmt::format(
-                "Timed out waiting for connection after {} secs. {}",
-                elapsed.total_seconds(), snapshot())};
-         }
-         WARN_FN(
-             "wait_for_connect. Still waiting. {}; timeout: {}; rem: {}",
-             snapshot(), timeout, rem);
-         std::this_thread::sleep_for(std::chrono::seconds(1));
-      }
+   void reconnect() {
+      WARN_FN("reconnect. {}", snapshot());
+      sleep_for(nanoseconds{reconnect_interval(n_reconnects).nanos()});
+      ++n_reconnects;
+      connect();
    }
 
    void run() {
@@ -236,11 +308,16 @@ struct WebsocketClient::PImpl {
          ERROR_FN(
              "io_thread. Websocket io threw websocketpp::exception. {}; "
              "err: {}",
-             snapshot(), ex);
+             snapshot(), std::string(ex.what()));
+             bts_assert_msgf(false, "io_thread. Websocket io threw websocketpp::exception. {}; "
+             "err: {}",
+               snapshot(), std::string(ex.what()));
       } catch (const std::exception &ex) {
          ERROR_FN(
              "io_thread. Websocket io threw std::exception. {}; err: {}",
-             snapshot(), ex);
+             snapshot(), std::string(ex.what()));
+         bts_assert_msgf(false, "io_thread. Websocket io threw std::exception. {}; err: {}",
+             snapshot(), std::string(ex.what()));
       } catch (...) {
          bts_assert_msgf(
              false,
@@ -251,10 +328,33 @@ struct WebsocketClient::PImpl {
       INFO("Websocket 'run' thread end. {}", snapshot());
    }
 
+   void run_one() {
+      try {
+         client.run_one();
+      } catch (const websocketpp::exception &ex) {
+         ERROR_FN(
+             "io_thread (run_one). Websocket io threw websocketpp::exception. "
+             "{}; err: {}",
+             snapshot(), ex);
+      } catch (const std::exception &ex) {
+         ERROR_FN(
+             "io_thread (run_one). Websocket io threw std::exception. {}; err: "
+             "{}",
+             snapshot(), ex);
+      } catch (...) {
+         bts_assert_msgf(
+             false,
+             "io_thread (run_one). Websocket io threw unknown exception. Could "
+             "this have been thrown by a callback delegate? {}",
+             snapshot());
+      }
+   }
+
  private:
    static std::atomic<int> client_id_counter;
 
-   auto on_tls_init(ConnectionHdl /*hdl*/) {
+   std::shared_ptr<boost::asio::ssl::context> on_tls_init(
+       ConnectionHdl /*hdl*/) {
       INFO_FN("on_tls_init. state: {}; version: {}", state, version);
       auto result =
           websocketpp::lib::make_shared<SslContext>(SslContext::sslv23_client);
@@ -262,44 +362,13 @@ struct WebsocketClient::PImpl {
       return result;
    }
 
-   void init_handlers() {
-      INFO_FN("init_handlers. state: {}; version: {}", state, version);
-      bts_assert(!io_thread);
-      client.init_asio();
-      client.set_message_handler(
-          [this](auto hdl, auto msg) { on_message(hdl, msg); });
-      client.set_open_handler([this](auto hdl) { on_open(hdl); });
-      client.set_ping_handler([](auto /*hdl*/, auto /*msg*/) {
-         LOG(Http, Info, "Received ping");
-         return true;
-      });
-      client.set_pong_timeout(0);
-      client.set_pong_handler([](auto /*hdl*/, auto /*msg*/) {
-         LOG(Http, Info, "Received pong");
-         return true;
-      });
-      client.set_tls_init_handler(
-          [this](auto hdl) { return on_tls_init(hdl); });
-      client.set_close_handler([this](auto hdl) { on_close(hdl); });
-      client.set_fail_handler([this](auto hdl) {
-         const auto ec = client.get_con_from_hdl(hdl)->get_ec();
-         ERROR_FN("fail_handler. {}; err: {}", snapshot(), ec.message());
-      });
-   }
-
-   void init_logging() {
-      INFO_FN("init_logging. {}", snapshot());
-      client.set_access_channels(websocketpp::log::alevel::all);
-      // client.clear_access_channels(websocketpp::log::alevel::frame_payload);
-      client.set_error_channels(websocketpp::log::elevel::all);
-   }
-
    void on_open(ConnectionHdl hdl) {
       lock_guard<mutex> lock{instance_mx};
       INFO_FN("on_open. {}", snapshot());
       const auto ec = client.get_con_from_hdl(hdl)->get_ec();
       if (ec) {
          ERROR_FN("on_open. {}; err: {}", snapshot(), ec.message());
+         bts_assert(false);
       }
       switch (state.value) {
       case State::OPENING:
@@ -350,11 +419,34 @@ struct WebsocketClient::PImpl {
       if (close_handler) {
          (*close_handler)(ec);
       }
+      if (config.reconnect_on_close) {
+         reconnect();
+      }
+   }
+
+   void on_fail(ConnectionHdl hdl) {
+      lock_guard<mutex> lock{instance_mx};
+      ERROR_FN("on_fail. {}", snapshot());
+      set_state(State::IDLE);
+      const auto con = client.get_con_from_hdl(hdl);
+      const auto ec = con->get_ec();
+      if (ec) {
+         ERROR_FN(
+             "on_fail. {}; local_code: {}; "
+             "local_reason: {}; remote_code: {}; remote_reason: {}; err: {}",
+             snapshot(), con->get_local_close_code(),
+             con->get_local_close_reason(), con->get_remote_close_code(),
+             con->get_remote_close_reason(), ec.message());
+      }
+      if (config.reconnect_on_fail) {
+         reconnect();
+      }
    }
 };
 
-WebsocketClient::WebsocketClient(WebsocketClientConfig config)
-    : me_(std::make_unique<PImpl>(std::move(config))) {}
+WebsocketClient::WebsocketClient(
+    WebsocketClientConfig config, boost::asio::io_context *io_context)
+    : me_(std::make_unique<PImpl>(std::move(config), io_context)) {}
 
 WebsocketClient::~WebsocketClient() {
    me_->close(websocketpp::close::status::going_away, "");
@@ -383,13 +475,16 @@ WebsocketClient::CloseHandler &WebsocketClient::close_handler() {
    return *me_->close_handler;
 }
 
-void WebsocketClient::connect(
-    const std::map<std::string, std::string> &headers, bool run_in_background) {
-   me_->connect(headers, run_in_background);
-}
+void WebsocketClient::connect() { me_->connect(); }
 
 void WebsocketClient::run() { me_->run(); }
 
+void WebsocketClient::run_one() { me_->run_one(); }
+
+boost::asio::io_context *WebsocketClient::io_context() {
+   return me_->io_context;
+}
+
 websocketpp::lib::error_code WebsocketClient::send_text(const string &text) {
    return me_->send_text(text);
 }
@@ -407,4 +502,6 @@ bool WebsocketClient::is_connected() const {
 
 void WebsocketClient::ping(const string &payload) { me_->con->ping(payload); }
 
+const string &WebsocketClient::url() const { return me_->config.url; }
+
 } // namespace bts::websocket

src/lib/io/websocket/websocket_client.h

@@ -3,6 +3,7 @@
 #include "lib/io/websocket/websocket_client_config.h"
 #include "lib/utils/Delegate.h"
 
+#include <boost/asio/io_context.hpp>
 #include <memory>
 #include <string>
 #include <websocketpp/config/core_client.hpp>
@@ -12,28 +13,33 @@ namespace bts::websocket {
 
 class WebsocketClient {
  public:
-   explicit WebsocketClient(WebsocketClientConfig config);
+   WebsocketClient(
+       WebsocketClientConfig config,
+       boost::asio::io_context *io_context = nullptr);
    ~WebsocketClient();
 
    using OpenHandler = bts::core::Delegate<void(const std::error_code &)>;
    using MessageHandler = bts::core::Delegate<void(const std::string &)>;
    using CloseHandler = bts::core::Delegate<void(const std::error_code &)>;
 
-   void connect(
-       const std::map<std::string, std::string> &headers = {},
-       bool run_in_background = true);
+   void connect();
    void disconnect();
    bool is_connected() const;
+   boost::asio::io_context *io_context();
    void run();
+   void run_one();
    CloseHandler &open_handler();
    MessageHandler &message_handler();
    CloseHandler &close_handler();
    websocketpp::lib::error_code send_text(const std::string &text);
    void ping(const std::string &payload = "");
 
+   const std::string &url() const;
+
  private:
    struct PImpl;
    std::unique_ptr<PImpl> me_;
 };
 
 } // namespace bts::websocket
+

src/lib/io/websocket/websocket_client_config.h

@@ -5,9 +5,14 @@
 namespace bts::websocket {
 
 struct WebsocketClientConfig {
-   std::string url;
-   core::TimeSpan connect_timeout;
-   core::TimeSpan pong_timeout;
+   std::string url{};
+   core::TimeSpan connect_timeout = core::TimeSpan::zero();
+   core::TimeSpan pong_timeout = core::TimeSpan::zero();
+   bool reconnect_on_close = false;
+   bool reconnect_on_fail = false;
+   std::map<std::string, std::string> headers{};
+   // name to use in logs
+   std::string name{};
 };
 
 } // namespace bts::websocket

src/lib/io/websocket/websocket_client_logger.h

@@ -0,0 +1,88 @@
+#pragma once
+
+#include "lib/logging/Common.h"
+#include "lib/logging/logging.h"
+
+#include <websocketpp/concurrency/basic.hpp>
+#include <websocketpp/logger/basic.hpp>
+#include <websocketpp/logger/levels.hpp>
+
+namespace websocketpp::log {
+
+struct ElevelAdapter {
+   typedef elevel LevelT;
+
+   constexpr bts::log::Level operator()(level channel) {
+      switch (channel) {
+      case elevel::devel:
+         return bts::Diag;
+      case elevel::library:
+      case elevel::warn:
+         return bts::Warn;
+      case elevel::rerror:
+         return bts::Error;
+      case elevel::fatal:
+         return bts::Fatal;
+      default:
+         return bts::Info;
+      }
+   }
+};
+
+struct AlevelAdapter {
+   typedef alevel LevelT;
+
+   constexpr bts::log::Level operator()(level channel) {
+      switch (channel) {
+      case alevel::control:
+      case alevel::frame_header:
+      case alevel::frame_payload:
+      case alevel::message_header:
+      case alevel::message_payload:
+      case alevel::debug_handshake:
+      case alevel::debug_close:
+      case alevel::devel:
+         return bts::Diag;
+      case alevel::disconnect:
+         return bts::Warn;
+      case alevel::fail:
+         return bts::Error;
+      default:
+         return bts::Info;
+      }
+   }
+};
+
+template <typename LevelAdapter>
+class WebsocketClientLogger
+    : public basic<concurrency::basic, typename LevelAdapter::LevelT> {
+   typedef basic<concurrency::basic, typename LevelAdapter::LevelT> base;
+
+   std::string name;
+   LevelAdapter level_adapter;
+
+ public:
+   WebsocketClientLogger(
+       level c, channel_type_hint::value h = channel_type_hint::access)
+       : base(c, h) {}
+
+   void set_name(std::string name) {
+      concurrency::basic::scoped_lock_type lock{this->m_lock};
+      this->name = std::move(name);
+   }
+
+   void write(level channel, const std::string &msg) {
+      concurrency::basic::scoped_lock_type lock{this->m_lock};
+      if (!this->dynamic_test(channel)) {
+         return;
+      }
+      LOG(Http, level_adapter(channel), "WebsocketClient-{} {}. {}", name,
+          std::string{LevelAdapter::LevelT::channel_name(channel)}, msg);
+   }
+
+   void write(level channel, const char *msg) {
+      write(channel, std::string{msg});
+   }
+};
+
+} // namespace websocketpp::log

src/lib/logging/Sink.cpp

@@ -9,6 +9,7 @@
 #include <boost/date_time/posix_time/posix_time.hpp>
 #include <boost/filesystem.hpp>
 #include <boost/filesystem/path.hpp>
+#include <cstdint>
 #include <fmt/ostream.h>
 #include <fstream>
 #include <iostream>
@@ -94,7 +95,7 @@ std::ifstream::pos_type filesize(std::string const &filename) {
 Sink file_sink(LoggingConfig const &cfg) {
    static std::ofstream stream;
    static uint64_t bytes_written = 0;
-   const auto max_sz = 120 * 1024 * 1024;
+   const uintmax_t max_sz =  1024 * 1024 * 1024 ;
 
    auto f = formatter(cfg);
    auto path = log_path();
@@ -107,7 +108,7 @@ Sink file_sink(LoggingConfig const &cfg) {
 
    if (boost::filesystem::exists(path)) {
       auto sz = boost::filesystem::file_size(path);
-      if (sz > max_sz && false) {
+      if (sz > max_sz) {
          auto backup = boost::filesystem::path(path.string() + ".old");
          boost::filesystem::rename(path, backup);
       }
@@ -118,8 +119,7 @@ Sink file_sink(LoggingConfig const &cfg) {
    return [=](LogMsg const &m) {
       auto msg = f(m);
       bytes_written += msg.size();
-      if (bytes_written >= max_sz && false) {
-         return;
+      if (bytes_written >= max_sz) {
          bytes_written = 0;
          stream.close();
          auto backup = boost::filesystem::path(path.string() + ".old");

src/lib/md/GeneralMarketDataListener.cpp

@@ -682,6 +682,18 @@ static bool get_qty_info(
       qty_tick_unit = 1;
       qty_tick_base = 1000000;
       break;
+   case 10'000'000:
+      qty_tick_unit = 1;
+      qty_tick_base = 10'000'000;
+      break;
+   case 100'000'000:
+      qty_tick_unit = 1;
+      qty_tick_base = 100'000'000;
+      break;
+   case 1'000'000'000:
+      qty_tick_unit = 1;
+      qty_tick_base = 1'000'000'000;
+      break;
    case 4:
       qty_tick_unit = 25;
       qty_tick_base = 100;

src/lib/md/MDConsumer.cpp

@@ -435,7 +435,8 @@ class SyntheticConsumerInst {
    void add_security(const api::Security &sec) {
       Mutex::scoped_lock lock(_workmutex);
       if (_data.find(sec.id()) == _data.end()) {
-         LOG(md, Info, "MDConsumer::add_security. {}", sec);
+         LOG(md, Info, "MDConsumer::add_security. {}",
+             bts::securities::descriptor(sec));
          auto ptr = to_strategy(make_shared<api::Security>(sec));
          vector<IncompleteStrategy> vec;
          vec.push_back(ptr);

src/lib/md/SecurityCache.cpp

@@ -14,6 +14,15 @@
 namespace bts {
 namespace md {
 
+#define ASSERT_FN(test, fn, ...)                                               \
+   bts_assert_msg(test, "SecurityCache::" fn ". " __VA_ARGS__)
+#define LOG_FN(level, fn, ...)                                                 \
+   LOG(md, level, "SecurityCache::" fn ". " __VA_ARGS__)
+#define DIAG_FN(fn, ...) LOG_FN(Diag, fn, __VA_ARGS__)
+#define INFO_FN(fn, ...) LOG_FN(Info, fn, __VA_ARGS__)
+#define WARN_FN(fn, ...) LOG_FN(Warn, fn, __VA_ARGS__)
+#define ERROR_FN(fn, ...) LOG_FN(Error, fn, __VA_ARGS__)
+
 using std::string;
 using std::unordered_map;
 
@@ -99,6 +108,9 @@ struct SecurityCacheIndex {
       // Insert but don't overwrite existing
       auto result =
           cache.insert(std::make_pair(SecurityKey(security->id()), security));
+      venue_type_ids.get_or_add(security->exchange())
+          .get_or_add(bts::securities::security_type(*security))
+          .try_emplace(bts::securities::descriptor(*security), security->id());
       return result.second;
    }
 
@@ -166,8 +178,8 @@ struct SecurityCacheImpl {
 };
 
 void SecurityCacheImpl::enqueue_update_db(const SecurityPtr &security) {
-   LOG(md, Diag, "SecurityCacheImpl::enqueue_update_db security: {}",
-       bts::securities::descriptor(*security));
+   DIAG_FN(
+       "enqueue_update_db", "security: {}", securities::descriptor(*security));
    update_queue.push(security);
 }
 
@@ -180,7 +192,13 @@ void SecurityCacheImpl::flush() {
          work.push_back(temp);
       }
       if (!work.empty()) {
+         INFO_FN("flush", "Saving securities to db. count: {}", work.size());
          if (db::insert_or_replace(work) == Result::error) {
+            WARN_FN(
+                "flush",
+                "Failed to save securities to db. Will retry on next flush. "
+                "count: {}",
+                work.size());
             // If we fail to insert then retry later
             for (auto &s : work)
                update_queue.push(std::move(s));
@@ -270,14 +288,18 @@ std::vector<api::Security const *> SecurityCache::get_securities() {
 }
 
 bool SecurityCache::add_live_security(const SecurityPtr &security) {
-   bts_assert(security);
-   LOG(md, Diag, "SecurityCache::add_live_security security: {}",
-       bts::securities::descriptor(*security));
-   return _me->cache.lock([&](SecurityCacheIndex &cache) {
+   ASSERT_FN(security, "add_live_security", "security is null");
+   const bool is_new_sec = _me->cache.lock([&](SecurityCacheIndex &cache) {
       const bool is_new_sec = cache.add_live_security(security);
       _me->enqueue_update_db(security);
       return is_new_sec;
    });
+   if (is_new_sec) {
+      INFO_FN(
+          "add_live_security", "new security: {}",
+          bts::securities::descriptor(*security));
+   }
+   return is_new_sec;
 }
 
 void SecurityCache::flush_to_disk() { _me->flush(); }

src/lib/md/SecurityIDRecorder.cpp

@@ -7,7 +7,6 @@
 #include "lib/utils/checked_arithmetic.h"
 
 #include <boost/filesystem.hpp>
-#include <boost/pool/object_pool.hpp>
 #include <memory>
 #include <sqlite/sqlite3.h>
 #include <stdexcept>

src/lib/md/Shm/FixedSecurity.cpp

@@ -509,6 +509,91 @@ void convert_security(
    }
 }
 
+void to_json(nlohmann::json &j, const FixedSecurity &f) {
+   j = nlohmann::json{
+       {"key", f.key},
+       {"symbol", f.symbol()},
+       {"type", api::SecurityType_Name(f.type)},
+       {"venue", api::Venue_Name(f.exchange)},
+       {"alt_symbol", f.alt_symbol()},
+       {"cfi_code", f.cfi_code()},
+       {"security_desc", f.security_desc()},
+       {"platform_id", f.platform_id()},
+       {"display_factor", f.display_factor},
+       {"numeric_id", f.numeric_id},
+       {"cboe_class_key", f.cboe_class_key},
+       {"main_frac", (int)f.cme_main_fraction},
+       {"sub_frac", (int)f.cme_sub_fraction},
+       {"price_format", (int)f.cme_price_display_format},
+       {"market_segment", (int)f.cme_market_segment_id},
+
+       {"price_break", f.price_break},
+       {"low_tick", f.low_tick},
+       {"high_tick", f.high_tick},
+       {"cpp", f.cash_per_point},
+
+       {"ice_market_description", f.ice_market_description()},
+       {"ice_cleared_alias", f.ice_cleared_alias()},
+       {"ice_product_name", f.ice_product_name()},
+       {"ice_hub_alias", f.ice_hub_alias()},
+       {"ice_strip_name", f.ice_strip_name()},
+       {"mic_code", f.mic_code()},
+   };
+   // Qty Info
+   {
+      auto qty_infos_j = nlohmann::json::array();
+      float min_value, max_value, tick_unit, tick_base, max_price;
+      bool is_notional;
+      for (int8_t i = 0; f.get_quantity_info(
+               i, min_value, max_value, tick_unit, tick_base, max_price,
+               is_notional);
+           i++) {
+         auto qty_info_j = nlohmann::json::object();
+         qty_info_j["min_value"] = min_value;
+         qty_info_j["max_value"] = max_value;
+         qty_info_j["tick_unit"] = tick_unit;
+         qty_info_j["tick_base"] = tick_base;
+         qty_info_j["max_price"] = max_price;
+         qty_info_j["is_notional"] = is_notional;
+         qty_infos_j.push_back(std::move(qty_info_j));
+      }
+      j["qty_infos"] = std::move(qty_infos_j);
+   }
+
+   switch (f.type) {
+   case api::SECURITYTYPE_SPOT:
+      break;
+   case api::SECURITYTYPE_FUTURE: {
+      auto *fut = static_cast<const FixedFutureSecurity *>(&f);
+      core::TimeStamp exp;
+      core::TimeStamp::from_ymd(
+          fut->expiration_year, fut->expiration_month, fut->expiration_day,
+          &exp);
+      j["expiration"] = exp.to_iso_string();
+      break;
+   }
+   case api::SECURITYTYPE_OPTION: {
+      auto *opt = static_cast<const FixedOptionSecurity *>(&f);
+      core::TimeStamp exp;
+      core::TimeStamp::from_ymd(
+          opt->expiration_year, opt->expiration_month, opt->expiration_day,
+          &exp);
+      j["expiration"] = exp.to_iso_string();
+      j["strike"] = opt->strike;
+      j["callput"] = api::PutOrCall_Name(opt->call_put);
+      break;
+   }
+   case api::SECURITYTYPE_SPREAD: {
+      auto *spd = static_cast<const FixedSpreadSecurityXL *>(&f);
+      std::vector<FixedSpreadLeg> legs{spd->legs, spd->legs + spd->leg_count()};
+      j["legs"] = legs;
+      break;
+   }
+   default:
+      break;
+   }
+}
+
 } // namespace md
 } // namespace bts
 

src/lib/md/Shm/FixedSecurity.h

@@ -273,71 +273,6 @@ inline void to_json(nlohmann::json &j, const FixedSpreadLeg &f) {
    };
 }
 
-inline void to_json(nlohmann::json &j, const FixedSecurity &f) {
-   j = nlohmann::json{
-       {"key", f.key},
-       {"symbol", f.symbol()},
-       {"type", api::SecurityType_Name(f.type)},
-       {"venue", api::Venue_Name(f.exchange)},
-       {"alt_symbol", f.alt_symbol()},
-       {"cfi_code", f.cfi_code()},
-       {"security_desc", f.security_desc()},
-       {"platform_id", f.platform_id()},
-       {"display_factor", f.display_factor},
-       {"numeric_id", f.numeric_id},
-       {"cboe_class_key", f.cboe_class_key},
-       {"main_frac", (int)f.cme_main_fraction},
-       {"sub_frac", (int)f.cme_sub_fraction},
-       {"price_format", (int)f.cme_price_display_format},
-       {"market_segment", (int)f.cme_market_segment_id},
-
-       {"price_break", f.price_break},
-       {"low_tick", f.low_tick},
-       {"high_tick", f.high_tick},
-       {"cpp", f.cash_per_point},
-
-       {"ice_market_description", f.ice_market_description()},
-       {"ice_cleared_alias", f.ice_cleared_alias()},
-       {"ice_product_name", f.ice_product_name()},
-       {"ice_hub_alias", f.ice_hub_alias()},
-       {"ice_strip_name", f.ice_strip_name()},
-       {"mic_code", f.mic_code()},
-   };
-
-   switch (f.type) {
-   case api::SECURITYTYPE_SPOT:
-      break;
-   case api::SECURITYTYPE_FUTURE: {
-      auto *fut = static_cast<const FixedFutureSecurity *>(&f);
-      core::TimeStamp exp;
-      core::TimeStamp::from_ymd(
-          fut->expiration_year, fut->expiration_month, fut->expiration_day,
-          &exp);
-      j["expiration"] = exp.to_iso_string();
-      break;
-   }
-   case api::SECURITYTYPE_OPTION: {
-      auto *opt = static_cast<const FixedOptionSecurity *>(&f);
-      core::TimeStamp exp;
-      core::TimeStamp::from_ymd(
-          opt->expiration_year, opt->expiration_month, opt->expiration_day,
-          &exp);
-      j["expiration"] = exp.to_iso_string();
-      j["strike"] = opt->strike;
-      j["callput"] = api::PutOrCall_Name(opt->call_put);
-      break;
-   }
-   case api::SECURITYTYPE_SPREAD: {
-      auto *spd = static_cast<const FixedSpreadSecurityXL *>(&f);
-      std::vector<FixedSpreadLeg> legs{spd->legs, spd->legs + spd->leg_count()};
-      j["legs"] = legs;
-      break;
-   }
-   default:
-      break;
-   }
-}
-
 inline std::ostream &operator<<(
     std::ostream &out, const FixedSecurity &f) noexcept {
    out << io::JsonDumper::dump(f);

src/lib/mercury/broker/BrokerProxy.cpp

@@ -8,7 +8,10 @@ namespace mercury {
 BrokerProxy::BrokerProxy(ILocalBroker &real_broker)
     : _real_broker(real_broker), _id(real_broker.id()), _cycles(0),
       _outgoing(config::get<config::Mercury>().queue_size()),
-      _incoming(config::get<config::Mercury>().queue_size()), _action_pool() {}
+      _incoming(config::get<config::Mercury>().queue_size()), _action_pool() {
+   _action_pool.set_max_count(4096 * 10);
+   _action_pool.set_log_freq(100);
+}
 
 BrokerProxy::~BrokerProxy() {}
 
@@ -96,5 +99,60 @@ void BrokerProxy::schedule_action(std::function<void()> const &action) {
    send(*m);
 }
 
+void BrokerProxy::do_work(trace::PerfLog &log) {
+   _cycles++;
+   _outgoing.consume_all([this, &log](BrokerMsg *m) {
+      switch (m->msg_type) {
+      case BrokerMsgType::ADD_NEIGHBOUR:
+         _real_broker.add_neighbour(*m->neighbour);
+         break;
+      case BrokerMsgType::REMOVE_NEIGHBOUR:
+         _real_broker.remove_neighbour(m->broker_id);
+         break;
+      case BrokerMsgType::ADVERTISE:
+         _real_broker.advertise(m->broker_id, m->stream_id, m->topic);
+         break;
+      case BrokerMsgType::UNADVERTISE:
+         _real_broker.unadvertise(m->broker_id, m->stream_id);
+         break;
+      case BrokerMsgType::SUBSCRIBE:
+         _real_broker.subscribe(m->broker_id, m->sub_id, m->stream_id);
+         break;
+      case BrokerMsgType::UNSUBSCRIBE:
+         _real_broker.unsubscribe(m->broker_id, m->sub_id, m->stream_id);
+         break;
+      case BrokerMsgType::NOTIFY: {
+         LOG(Latency, Diag, "Notify broker {}. Cycles: {}", _id.value(),
+             _cycles);
+         auto scoped_do_work = trace::log_scope(log, {}, "BrokerProxy::notify");
+         _real_broker.notify(
+             m->broker_id, m->stream_id, m->sub_id, m->notification);
+      } break;
+      case BrokerMsgType::LOCAL_SUBSCRIBE:
+         _real_broker.local_subscribe(
+             m->local_sub_id, m->filter, m->local_handler);
+         break;
+      case BrokerMsgType::LOCAL_UNSUBSCRIBE:
+         _real_broker.local_unsubscribe(m->local_sub_id);
+         break;
+      case BrokerMsgType::EXECUTE_ACTION: {
+         auto start = Timer::now();
+         LOG(Latency, Diag, "Executing lambda on broker {}", _id.value());
+         m->action();
+         auto stop = Timer::now();
+         LOG(Latency, Diag,
+             "Finished executing lambda on broker {}. Took: {}us", _id.value(),
+             us_diff(stop, start));
+         break;
+      }
+      default:
+         bts_assert(false);
+         break;
+      }
+      _incoming.drain();
+      _incoming.push(m);
+   });
+}
+
 } // namespace mercury
 } // namespace bts

src/lib/mercury/broker/BrokerProxy.h

@@ -5,8 +5,8 @@
 #include "lib/mercury/topics/Topic.h"
 #include "lib/tracing/PerfLog.h"
 #include "lib/utils/GrowableSPSCQueue.h"
+#include "lib/utils/object_pool.h"
 
-#include <boost/pool/object_pool.hpp>
 #include <memory>
 
 namespace bts {
@@ -80,61 +80,7 @@ class BrokerProxy : public ILocalBroker {
       send(m);
    }
 
-   void do_work(trace::PerfLog &log) {
-      _cycles++;
-      _outgoing.consume_all([this, &log](BrokerMsg *m) {
-         switch (m->msg_type) {
-         case BrokerMsgType::ADD_NEIGHBOUR:
-            _real_broker.add_neighbour(*m->neighbour);
-            break;
-         case BrokerMsgType::REMOVE_NEIGHBOUR:
-            _real_broker.remove_neighbour(m->broker_id);
-            break;
-         case BrokerMsgType::ADVERTISE:
-            _real_broker.advertise(m->broker_id, m->stream_id, m->topic);
-            break;
-         case BrokerMsgType::UNADVERTISE:
-            _real_broker.unadvertise(m->broker_id, m->stream_id);
-            break;
-         case BrokerMsgType::SUBSCRIBE:
-            _real_broker.subscribe(m->broker_id, m->sub_id, m->stream_id);
-            break;
-         case BrokerMsgType::UNSUBSCRIBE:
-            _real_broker.unsubscribe(m->broker_id, m->sub_id, m->stream_id);
-            break;
-         case BrokerMsgType::NOTIFY: {
-            LOG(Latency, Diag, "Notify broker {}. Cycles: {}", _id.value(),
-                _cycles);
-            auto scoped_do_work =
-                trace::log_scope(log, {}, "BrokerProxy::notify");
-            _real_broker.notify(
-                m->broker_id, m->stream_id, m->sub_id, m->notification);
-         } break;
-         case BrokerMsgType::LOCAL_SUBSCRIBE:
-            _real_broker.local_subscribe(
-                m->local_sub_id, m->filter, m->local_handler);
-            break;
-         case BrokerMsgType::LOCAL_UNSUBSCRIBE:
-            _real_broker.local_unsubscribe(m->local_sub_id);
-            break;
-         case BrokerMsgType::EXECUTE_ACTION: {
-            auto start = Timer::now();
-            LOG(Latency, Diag, "Executing lambda on broker {}", _id.value());
-            m->action();
-            auto stop = Timer::now();
-            LOG(Latency, Diag,
-                "Finished executing lambda on broker {}. Took: {}us",
-                _id.value(), us_diff(stop, start));
-            break;
-         }
-         default:
-            bts_assert(false);
-            break;
-         }
-         _incoming.drain();
-         _incoming.push(m);
-      });
-   }
+   void do_work(trace::PerfLog &log);
 
  private:
    ILocalBroker &_real_broker;
@@ -142,7 +88,7 @@ class BrokerProxy : public ILocalBroker {
    uint64_t _cycles;
    utils::GrowableSPSCQueue<BrokerMsg *> _outgoing;
    utils::GrowableSPSCQueue<BrokerMsg *> _incoming;
-   boost::object_pool<BrokerMsg> _action_pool;
+   bts::utils::object_pool<BrokerMsg> _action_pool;
 
    void send(BrokerMsg &m) {
       _outgoing.push(&m);

src/lib/orderman/CreateOrderMsg.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include "lib/api/services/OrderService.h"
 #include "lib/core/FMT_IMPL.h"
 #include "lib/domain_model/Security.h"
 #include "lib/domain_model/common.h"
@@ -24,6 +25,25 @@ struct CreateOrderMsg {
    api::orderman::RoutingRecord const *routing_record;
 };
 
+/**
+ * A CreateOrderMsg wrapper with a custom fmt::formatter that doesn't access the
+ * raw security pointer. This is mainly used for logging purposes (because the
+ * security pointer may be invalid by the time the fmt::formatter is invoked).
+ */
+struct CreateOrderMsg_JsonData {
+   CreateOrderMsg_JsonData() = default;
+   CreateOrderMsg_JsonData(CreateOrderMsg source) : source(std::move(source)) {
+      if (this->source.security != nullptr) {
+         sec_name = securities::descriptor(*this->source.security);
+      }
+   }
+
+   CreateOrderMsg source;
+   std::string sec_name;
+};
+
+void to_json(nlohmann::json &j, const CreateOrderMsg &msg);
+
 inline std::ostream &operator<<(std::ostream &out, CreateOrderMsg const &msg) {
    out << "key: " << msg.key.value() << " price: " << msg.price.value()
        << " qty: " << msg.quantity.full_value() << " security: "
@@ -43,6 +63,29 @@ inline std::ostream &operator<<(std::ostream &out, CreateOrderMsg const &msg) {
    return out;
 }
 
+inline void to_json(
+    nlohmann::json &j, const CreateOrderMsg_JsonData &msg_data) {
+   const auto &msg = msg_data.source;
+   j["key"] = msg.key.value();
+   j["price"] = msg.price.value();
+   j["quantity"] = msg.quantity.value();
+   if (msg.display_quantity.value() != 0) {
+      j["display_quantity"] = msg.quantity.value();
+   }
+   if (!msg_data.sec_name.empty()) {
+      j["security"] = msg_data.sec_name;
+   }
+   j["side"] = msg.side;
+   if (msg.stop_px.value() != 0) {
+      j["stop_px"] = msg.stop_px.value();
+   }
+   j["time_in_force"] = msg.time_in_force;
+   j["manual_order_indicator"] = msg.manual_order_indicator;
+   if (msg.routing_record != nullptr) {
+      j["routing_record"] = *msg.routing_record;
+   }
+}
+
 } // namespace bts::orderman
 
 FMT_IMPL_OSTREAM(bts::orderman::CreateOrderMsg);

src/lib/orderman/OrderServiceServer.cpp

@@ -8,6 +8,7 @@
 #include "lib/config/config.h"
 #include "lib/config/protos/jetfix.pb.h"
 #include "lib/config/protos/orderman_cfg.pb.h"
+#include "lib/core/FMT.h"
 #include "lib/domain_model/Security.pb.h"
 #include "lib/domain_model/common.h"
 #include "lib/logging/logging.h"
@@ -29,11 +30,11 @@
 #include "lib/orderman/actors/order_manager/order_gateway_definition.h"
 #include "lib/orderman/events/ExchangePositionEvent.h"
 #include "lib/orderman/events/OrderOpResultEvent.h"
-#include "lib/orderman/gateways/execution_gateway_provider.h"
 #include "lib/orderman/gateways/i_execution_gateway_provider.h"
 #include "lib/orderman/order_factory/DynamicOrderRegistry.h"
 #include "lib/orderman/orderman_utils/ExchangeOpenOrders.h"
 #include "lib/orderman/orders/Order.h"
+#include "lib/os/os.h"
 #include "lib/os/spark_data_directory.h"
 #include "lib/plugin/SparkServices.h"
 #include "lib/plugin/plugin.h"
@@ -41,7 +42,6 @@
 #include "lib/utils/bts_chrono.h"
 #include "lib/utils/thread_manager.h"
 #include "lib/utils/type_name.h"
-#include "lib_binance_execution/binance_execution/execution_gateway_provider.h"
 
 #include <bits/stdint-uintn.h>
 #include <boost/algorithm/string/predicate.hpp>
@@ -73,16 +73,58 @@ struct ActorThread {
    void start(trace::PerfLog &log) {
       if (cfg.poll())
          thread = threading::make_thread(cfg.thread_name(), [this, &log]() {
-            for (;;)
+            const core::TimeSpan log_interval =
+                core::TimeSpan::from_seconds(30);
+            core::TimeStamp last_log_time{0};
+            core::TimeStamp now;
+            core::TimeSpan elapsed;
+            std::uint32_t last_count = 0;
+            for (;;) {
+               now = core::TimeStamp::now();
+               elapsed = now - last_log_time;
+               if (elapsed > log_interval) {
+                  LOG(OrderMan, Info,
+                      "OrderServiceServer ActorThread work speed is {:.2f} "
+                      "cycles/sec",
+                      static_cast<float>(last_count) / elapsed.total_seconds());
+                  last_log_time = now;
+                  last_count = 0;
+               }
                executor.do_work(log);
+               last_count++;
+            }
          });
       else {
          thread = threading::make_thread(cfg.thread_name(), [this, &log]() {
+            // for logging purposes
+            const std::string t_name = bts::os::get_thread_name();
+            const std::string actors_desc = FMT_JOIN(cfg.hosted_actor(), ", ");
+            const core::TimeSpan log_interval =
+                core::TimeSpan::from_seconds(30);
+
             const auto inner_iter = 1000;
+            bts::core::TimeStamp last_log_time{0};
+            core::TimeStamp now;
+            core::TimeSpan elapsed;
+            std::uint32_t last_count = 0;
             while (!done) {
+               now = core::TimeStamp::now();
+               elapsed = now - last_log_time;
+               auto log_elapsed = now - last_log_time;
+               if (log_elapsed > log_interval) {
+                  LOG(OrderMan, Info,
+                      "OrderServiceServer ActorThread {} work speed is {:.2f} "
+                      "cycles/sec ({})",
+                      t_name,
+                      static_cast<float>(last_count) / elapsed.total_seconds(),
+                      actors_desc);
+                  last_log_time = now;
+                  last_count = 0;
+               }
                auto start = Timer::now();
                for (auto i = 0; i < inner_iter; i++)
                   executor.do_work(log);
+               last_count += inner_iter;
                auto stop = Timer::now();
                loop_metric->observe(ns_diff(stop, start) / inner_iter);
                std::this_thread::sleep_for(10ms);

src/lib/orderman/actors/FillStore.cpp

@@ -2,7 +2,10 @@
 #include "lib/api/services/OrderService.pb.h"
 #include "lib/config/config.h"
 #include "lib/config/protos/toggles.pb.h"
+#include "lib/core/TimeStamp.h"
 #include "lib/domain_model/Security.h"
+#include "lib/domain_model/Security.pb.h"
+#include "lib/domain_model/SecurityKey.h"
 #include "lib/logging/logging.h"
 #include "lib/mercury/events/Update.h"
 #include "lib/orderman/actors/SODPosition.h"
@@ -14,18 +17,88 @@
 #include "lib/os/os.h"
 #include "lib/persistence/SqliteStore.h"
 #include "lib/utils/PBUtils.h"
+#include "lib/utils/TimeStamp.h"
 #include "lib/utils/bts_assert.h"
+#include "lib/utils/bts_chrono.h"
 #include "lib/utils/overloaded.h"
 
 #include <boost/date_time/posix_time/posix_time.hpp>
+#include <google/protobuf/timestamp.pb.h>
 #include <string>
 #include <sys/time.h>
 
 namespace bts {
 namespace orderman {
 
+#define LOG_FN(level, fn, ...)                                                 \
+   LOG(OrderMan, level, "FillStore::" fn ". " __VA_ARGS__)
+#define INFO_FN(fn, ...) LOG_FN(Info, fn, __VA_ARGS__)
+#define WARN_FN(fn, ...) LOG_FN(Warn, fn, __VA_ARGS__)
+#define ERROR_FN(fn, ...) LOG_FN(Error, fn, __VA_ARGS__)
+
 auto const fills_ns = "fills";
 
+struct FillAggregator {
+   struct SecPosition {
+    private:
+      Fill agg_fill;
+
+    public:
+      double agg_price = 0, agg_qty = 0;
+      SecPosition(const Fill &fill) : agg_fill(fill) {
+         const auto &fill_key = fill.fill_key();
+         std::string new_fill_key = "aggpos_" + fill_key;
+         agg_fill.set_fill_key(new_fill_key);
+         auto now_ns = bts::core::TimeStamp::now_ns();
+         agg_fill.mutable_timestamp()->set_nanos(now_ns);
+         add_fill(fill);
+      }
+      void add_fill(const Fill &fill) {
+         bts_assert(fill.security_key() == agg_fill.security_key());
+         double mult = fill.side() == api::SIDE_BUY ? 1.0 : -1.0;
+         double fp = fill.avg_price();
+         double fq = mult * fill.last_shares();
+         double new_agg_price =
+             ((agg_price * agg_qty) + (fp * fq)) / (agg_qty + fq);
+         double new_agg_qty = agg_qty + fq;
+         agg_price = new_agg_price;
+         agg_qty = new_agg_qty;
+      }
+
+    public:
+      Fill fill() const {
+         Fill rv = agg_fill;
+         rv.set_avg_price(agg_price);
+         rv.set_last_shares(std::abs(agg_qty));
+         rv.set_side(::bts::api::Side::SIDE_BUY);
+         if (agg_qty < 0) {
+            rv.set_side(::bts::api::Side::SIDE_SELL);
+         }
+         return rv;
+      }
+   };
+   std::map<SecurityKey, SecPosition> pos_map = {};
+
+   void add_fill(const Fill &fill) {
+      SecurityKey k = SecurityKey(fill.security_key());
+      auto it = pos_map.find(k);
+      if (it != pos_map.end()) {
+         SecPosition &sec_pos = it->second;
+         sec_pos.add_fill(fill);
+      } else {
+         pos_map.insert({k, {fill}});
+      }
+   }
+
+   std::vector<Fill> get_aggregated_fills() const {
+      std::vector<Fill> rv = {};
+      for (const auto &kv : pos_map) {
+         rv.push_back(kv.second.fill());
+      }
+      return rv;
+   }
+};
+
 struct FillStore::UnresolvedFills {
    std::vector<api::orderman::Fill> fills;
    api::Security const *security;
@@ -42,6 +115,8 @@ struct FillStore::PImpl {
    std::unordered_map<OrderKey, UnresolvedFills> fills_with_unresolved_accounts;
    mercury::Stream<StoredFillEvent> fill_stream;
    md::SecurityOracle oracle;
+   FillAggregator fill_aggregator = {};
+   bool aggregate_pos = false;
 };
 
 FillStore::FillStore(md::SecurityOracle o) : me(new PImpl(o)) {
@@ -94,40 +169,83 @@ void FillStore::init() {
        os::get_thread_id(), os::get_thread_name());
    LOG(OrderMan, Info, "FillStore::init oracle n_secs: {}",
        me->oracle.get_securities().size());
-   // Subscribe to NewExecutionReportEvent for new fills
-   subscribe<NewExecutionReportEvent>(
-       [this](auto const &ev) { this->on_execution_report(ev); });
-
    // Load stored fills, resolve their securities and publish the lot
-   api::orderman::Fill fill;
    std::vector<StoredFillEvent> stored_batch;
    LOG(persist, Info, "Loading load all fills");
    auto all = me->store->retrieve_all()[fills_ns];
    LOG(persist, Info, "Finished loading all {} fills", all.size());
-   SODPosition sod_helper;
-   for (auto const &kvp : all)
-      if (utils::pb::from_string<api::orderman::Fill>(kvp.second, &fill)) {
-         if (sod_helper.is_sod(fill.timestamp())) {
-            auto fill_kind = sod_fill_kind(fill);
-            fill.set_fill_kind(fill_kind);
+   auto aggregate_clean_and_publish = [&]() {
+      api::orderman::Fill fill;
+      for (auto const &kvp : all) {
+         if (utils::pb::from_string<api::orderman::Fill>(kvp.second, &fill)) {
+            me->fill_aggregator.add_fill(fill);
+         } else {
+            LOG(persist, Error,
+                "Could not recover fill {} from storage. "
+                "This should be investigated",
+                kvp.first);
          }
-         auto sec = me->oracle.get_security(SecurityKey(fill.security_key()));
+      }
+      // 1. go through all fills in aggregator and make StoredFillEvent
+      auto aggregated_fills = me->fill_aggregator.get_aggregated_fills();
+      for (auto &f : aggregated_fills) {
+         auto sec = me->oracle.get_security(SecurityKey(f.security_key()));
          if (sec) {
-            auto fk = kvp.first;
-            me->known_fills.insert(fk);
-            if (!config::get<config::toggles::FilterExpiredFills>().enabled() ||
-                !securities::is_expired(*sec)) {
-               stored_batch.emplace_back(fill, *sec);
+            stored_batch.emplace_back(f, *sec);
+         } else {
+            LOG(persist, Error,
+                "Stored fill {} contains unresolved security {}. ",
+                utils::pb::to_string(f), fill.security_key());
+         }
+      }
+      // 2 delete all fills in the DB
+      me->store->remove_all(fills_ns);
+      // 3. add the aggregated fills back
+      for (const auto &e : stored_batch) {
+         const Fill &f = e.fill;
+         me->store->insert(fills_ns, f.fill_key(), utils::pb::to_string(f));
+      }
+   };
+   auto publish_with_sod_marking = [&]() {
+      api::orderman::Fill fill;
+      SODPosition sod_helper;
+      for (auto const &kvp : all) {
+         if (utils::pb::from_string<api::orderman::Fill>(kvp.second, &fill)) {
+            if (sod_helper.is_sod(fill.timestamp())) {
+               auto fill_kind = sod_fill_kind(fill);
+               fill.set_fill_kind(fill_kind);
             }
+            auto sec =
+                me->oracle.get_security(SecurityKey(fill.security_key()));
+            if (sec) {
+               auto fk = kvp.first;
+               me->known_fills.insert(fk);
+               if (!config::get<config::toggles::FilterExpiredFills>()
+                        .enabled() ||
+                   !securities::is_expired(*sec)) {
+                  stored_batch.emplace_back(fill, *sec);
+               }
+            } else
+               LOG(persist, Error,
+                   "Stored fill {} contains unresolved security {}. ",
+                   kvp.first, fill.security_key());
          } else
             LOG(persist, Error,
-                "Stored fill {} contains unresolved security {}. ", kvp.first,
-                fill.security_key());
-      } else
-         LOG(persist, Error,
-             "Could not recover fill {} from storage. "
-             "This should be investigated",
-             kvp.first);
+                "Could not recover fill {} from storage. "
+                "This should be investigated",
+                kvp.first);
+      }
+   };
+
+   // Subscribe to NewExecutionReportEvent for new fills
+   subscribe<NewExecutionReportEvent>(
+       [this](auto const &ev) { this->on_execution_report(ev); });
+   if (me->aggregate_pos) {
+      aggregate_clean_and_publish();
+   } else {
+      publish_with_sod_marking();
+   }
+
    me->fill_stream = make_stream<StoredFillEvent>();
    LOG(OrderMan, Info,
        "Fill Store published {} fills recoved from disk out of {} "
@@ -160,7 +278,7 @@ void FillStore::on_execution_report(
              ev.data->to_string());
          auto &er = *ev.data;
          auto fk = fmt::format(
-             "{}:{}", er.order_key.value(), to_str(er.exchange_fill_id));
+             "{}:{}", er.order_key.value(), to_strn(er.exchange_fill_id));
          auto is_known = me->known_fills.count(fk);
          if (er.exec_type == api::orderman::EXEC_TYPE_PARTIAL_FILL ||
              er.exec_type == api::orderman::EXEC_TYPE_FILL) {
@@ -176,7 +294,7 @@ void FillStore::on_execution_report(
                   fill.set_fill_kind(api::orderman::Fill::FILL_KIND_STANDARD);
                   fill.set_security_key(er.security->id());
                }
-               fill.set_account(to_str(er.account_name));
+               fill.set_account(to_strn(er.account_name));
                fill.set_last_price(er.last_price.value());
                fill.set_avg_price(er.avg_price.value());
                fill.set_side(er.side);
@@ -207,7 +325,15 @@ void FillStore::on_execution_report(
                auto it = me->known_orders.find(er.order_key);
                if (it != me->known_orders.end()) {
                   auto &order_def = it->second;
-                  fill.set_account(order_def.account());
+                  if (fill.account() != order_def.account()) {
+                     WARN_FN(
+                         "on_execution_report",
+                         "ExecutionReport account '{}' does not match "
+                         "OrderDefinition account '{}' (order_key: {}). "
+                         "Setting fill account to the latter",
+                         fill.account(), order_def.account(), er.order_key);
+                     fill.set_account(order_def.account());
+                  }
                   fill.set_internal_account_id(order_def.account_id());
                } else
                   me->fills_with_unresolved_accounts[er.order_key]
@@ -215,6 +341,7 @@ void FillStore::on_execution_report(
 
                auto fv = utils::pb::to_string(fill);
                me->store->insert(fills_ns, fk, fv);
+               LOG(OrderMan, Info, "Publishing fill. {}", fv);
                publish(me->fill_stream, fill, *er.security);
             } else
                LOG(OrderMan, Info,

src/lib/orderman/actors/OrderStore.cpp

@@ -5,6 +5,7 @@
 #include "lib/config/protos/orders_fills_cleanup.pb.h"
 #include "lib/config/protos/toggles.pb.h"
 #include "lib/logging/logging.h"
+#include "lib/md/ExchangeSecurityKey.h"
 #include "lib/orderman/actors/SODPosition.h"
 #include "lib/orderman/events/OrderDefinitionUpdateEvent.h"
 #include "lib/orderman/events/OrderStateUpdateEvent.h"
@@ -12,6 +13,7 @@
 #include "lib/persistence/SqliteStore.h"
 #include "lib/utils/PBUtils.h"
 
+#include <google/protobuf/timestamp.pb.h>
 #include <unordered_set>
 
 namespace bts {
@@ -38,6 +40,7 @@ struct OrderStore::PImpl {
    bool soft_cleanup_enabled;
    md::SecurityOracle oracle;
    timeval cutoff_time;
+   bool clear_all_orders = true;
 };
 
 OrderStore::OrderStore(md::SecurityOracle o) : me(new PImpl(o)) {}
@@ -63,34 +66,46 @@ void OrderStore::init() {
 
    me->cutoff_time = SODPosition::get_order_cutoff_time(all);
 
-   for (auto const &kvp : all)
-      if (utils::pb::from_string<api::orderman::OrderRecord>(
-              kvp.second, &rec)) {
-         auto ok = OrderKey(std::stoi(kvp.first));
-         auto sk = SecurityKey(rec.def().security_key());
-         auto sec = me->oracle.get_security(sk);
+   auto load_orders = [&]() {
+      for (auto const &kvp : all) {
+         if (utils::pb::from_string<api::orderman::OrderRecord>(
+                 kvp.second, &rec)) {
+            auto ok = OrderKey(std::stoi(kvp.first));
+            auto sk = SecurityKey(rec.def().security_key());
+            auto sec = me->oracle.get_security(sk);
 
-         if (config::get<config::toggles::FilterOrdersWithDanglingSecurities>()
-                 .enabled() &&
-             sec == nullptr) {
-            LOG(OrderMan, Diag, "Order {} refers to unresolved security {}",
-                ok.value(), sk.value());
-         } else {
-            if (!_order_cutoff(rec))
-               stored_batch.emplace_back(rec);
-            me->known_orders[ok] = PImpl::ORInfo{rec, true};
-         }
-      } else
-         LOG(OrderMan, Error,
-             "Could not recover order {} from storage. "
-             "This should be investigated",
-             kvp.first);
+            if (config::get<
+                    config::toggles::FilterOrdersWithDanglingSecurities>()
+                    .enabled() &&
+                sec == nullptr) {
+               LOG(OrderMan, Diag, "Order {} refers to unresolved security {}",
+                   ok.value(), sk.value());
+            } else {
+               if (!_order_cutoff(rec))
+                  stored_batch.emplace_back(rec);
+               me->known_orders[ok] = PImpl::ORInfo{rec, true};
+            }
+         } else
+            LOG(OrderMan, Error,
+                "Could not recover order {} from storage. "
+                "This should be investigated",
+                kvp.first);
+      }
+   };
 
    me->order_stream = make_stream<StoredOrderEvent>();
    LOG(OrderMan, Info,
        "Order Store published {} orders recoved from disk out of {} "
        "total orders",
        stored_batch.size(), all.size());
+
+   if (me->clear_all_orders) {
+      // clear orders
+      me->store->remove_all(orders_ns);
+   } else {
+      load_orders();
+   }
+
    publish_batch(me->order_stream, stored_batch);
 }
 
@@ -114,17 +129,22 @@ void OrderStore::on_order_state_update(
          rec.set_key(ev.key.value());
          rec.set_parent_key(ev.parent_key.value());
          modified_orders.insert(ev.key);
+         const auto now = utils::pb::pb_now();
          if (rec.has_state()) {
+            google::protobuf::Timestamp created;
+            if (rec.state().has_created()) {
+               created = rec.state().created();
+            }
             rec.mutable_state()->CopyFrom(ev.rebuild_state());
-            *rec.mutable_state()->mutable_created() = utils::pb::pb_now();
-            *rec.mutable_state()->mutable_last_change() = rec.state().created();
+            *rec.mutable_state()->mutable_created() =
+                created.seconds() > 0 || created.nanos() > 0 ? created : now;
             // if filled qty went from 0.99 -> 1, it was copying the int part and not clearing the fraction part,
             // so changing MergeFrom to CopyFrom
          } else {
             *rec.mutable_state() = ev.rebuild_state();
-            *rec.mutable_state()->mutable_created() = utils::pb::pb_now();
+            *rec.mutable_state()->mutable_created() = now;
          }
-         *rec.mutable_state()->mutable_last_change() = utils::pb::pb_now();
+         *rec.mutable_state()->mutable_last_change() = now;
          LOG(OrderMan, Info, "OrderStore::on_order_state_update k: {} rec: {}",
              ev.key, utils::pb::to_string(rec));
       }
@@ -155,7 +175,7 @@ void OrderStore::store_and_publish_if_complete(
       auto &rec_info = me->known_orders[k];
       auto &rec = rec_info.rec;
       if (rec.has_def() && rec.has_state()) {
-         LOG(OrderMan, Info,
+         LOG(OrderMan, Diag,
              "OrderStore::store_and_publish_if_complete rec: {}",
              utils::pb::to_string(rec));
          publish(me->order_stream, rec);

src/lib/orderman/actors/ServiceBridge.cpp

@@ -37,6 +37,12 @@
 namespace bts {
 namespace orderman {
 
+#define _LOG_FN(level, fn, ...)                                                \
+   LOG(OrderMan, level, "ServiceBridge::" fn ". " __VA_ARGS__)
+#define INFO_FN(fn, ...) _LOG_FN(Info, fn, __VA_ARGS__)
+#define WARN_FN(fn, ...) _LOG_FN(Warn, fn, __VA_ARGS__)
+#define ERROR_FN(fn, ...) _LOG_FN(Error, fn, __VA_ARGS__)
+
 struct ServiceBridge::PImpl {
    PImpl(
        OnReady const &on_ready,
@@ -173,56 +179,72 @@ void ServiceBridge::init() {
 } // namespace orderman
 
 void ServiceBridge::on(mercury::Update<StoredFillEvent> const &update) {
-   if (update.events) {
-      std::vector<api::orderman::Fill> fills;
-      fills.reserve(update.events->size());
-      for (auto ev : *(update.events))
-         fills.push_back(ev.fill);
-      me->on_fills(fills);
+   if (!update.events) {
+      WARN_FN("on StoredFillEvent", "no event data");
+      return;
    }
+   INFO_FN("on StoredFillEvent", "n_events: {}", update.events->size());
+   std::vector<api::orderman::Fill> fills;
+   fills.reserve(update.events->size());
+   for (auto ev : *(update.events))
+      fills.push_back(ev.fill);
+   me->on_fills(fills);
 }
 
 void ServiceBridge::on(mercury::Update<StoredOrderEvent> const &update) {
-   if (update.events) {
-      bool was_ready = is_ready();
-      me->have_orders = true;
-
-      std::vector<api::orderman::OrderRecord> orders;
-      orders.reserve(update.events->size());
-      for (auto ev : *(update.events)) {
-         me->known_orders.insert(OrderKey(ev.order_record.key()));
-         orders.push_back(ev.order_record);
-      }
-      me->on_orders(orders);
-      maybe_signal_ready(was_ready);
+   if (!update.events) {
+      WARN_FN("on StoredOrderEvent", "no event data");
+      return;
    }
+   INFO_FN("on StoredOrderEvent", "n_events: {}", update.events->size());
+   bool was_ready = is_ready();
+   me->have_orders = true;
+
+   std::vector<api::orderman::OrderRecord> orders;
+   orders.reserve(update.events->size());
+   for (auto ev : *(update.events)) {
+      me->known_orders.insert(OrderKey(ev.order_record.key()));
+      orders.push_back(ev.order_record);
+   }
+   me->on_orders(orders);
+   maybe_signal_ready(was_ready);
 }
 
 void ServiceBridge::on(mercury::Update<OrderManagerReadyEvent> const &update) {
-   if (update.events) {
-      bool was_ready = is_ready();
-      me->order_manager_ready = true;
-      maybe_signal_ready(was_ready);
+   if (!update.events) {
+      WARN_FN("on OrderManagerReadyEvent", "no event data");
+      return;
    }
+   INFO_FN("on OrderManagerReadyEvent", "n_events: {}", update.events->size());
+   bool was_ready = is_ready();
+   me->order_manager_ready = true;
+   maybe_signal_ready(was_ready);
 }
 
 void ServiceBridge::on(mercury::Update<NewAdminDataEvent> const &update) {
-   if (update.events)
-      for (auto ev : *(update.events))
-         me->order_router.update(*ev.admin_data);
+   if (!update.events) {
+      WARN_FN("on NewAdminDataEvent", "no event data");
+      return;
+   }
+   INFO_FN("on NewAdminDataEvent", "n_events: {}", update.events->size());
+   for (auto ev : *(update.events)) {
+      me->order_router.update(*ev.admin_data);
+   }
 }
 
 void ServiceBridge::on(mercury::Update<OrderOpResultEvent> const &update) {
-   if (update.events)
-      for (auto ev : *(update.events))
-         me->on_order_op_result(ev);
+   if (!update.events) {
+      WARN_FN("on OrderOpResultEvent", "no event data");
+      return;
+   }
+   INFO_FN("on OrderOpResultEvent", "n_events: {}", update.events->size());
+   for (auto ev : *(update.events)) {
+      me->on_order_op_result(ev);
+   }
 }
 
 void ServiceBridge::create_order(uint32_t rid, api::orderman::Create const &c) {
-
-   LOG(OrderMan, Info, "Received new order from client: {}",
-       utils::pb::to_string(c));
-
+   INFO_FN("create_order", "rid: {}; req: {}", rid, utils::pb::to_string(c));
    me->service_call_marshaller.schedule_action([this, c, rid]() {
       if (is_ready()) {
          auto &order =
@@ -239,9 +261,7 @@ void ServiceBridge::create_order(uint32_t rid, api::orderman::Create const &c) {
 }
 
 void ServiceBridge::update_order(uint32_t rid, api::orderman::Update const &c) {
-   LOG(OrderMan, Info, "ServiceBridge::update_order update: {}",
-       utils::pb::to_string(c));
-
+   INFO_FN("update_order", "rid: {}; req: {}", rid, utils::pb::to_string(c));
    me->service_call_marshaller.schedule_action([this, c, rid]() {
       auto ok = OrderKey(c.order_key());
       if (is_ready()) {
@@ -259,9 +279,7 @@ void ServiceBridge::update_order(uint32_t rid, api::orderman::Update const &c) {
 }
 
 void ServiceBridge::cancel_order(uint32_t rid, api::orderman::Cancel const &c) {
-   LOG(OrderMan, Info, "Received order cancel from client: {}",
-       utils::pb::to_string(c));
-
+   INFO_FN("cancel_order", "rid: {}; req: {}", rid, utils::pb::to_string(c));
    me->service_call_marshaller.schedule_action([this, c, rid]() {
       auto ok = OrderKey(c.order_key());
       if (is_ready()) {
@@ -279,9 +297,7 @@ void ServiceBridge::cancel_order(uint32_t rid, api::orderman::Cancel const &c) {
 }
 
 void ServiceBridge::detach_order(uint32_t rid, api::orderman::Detach const &c) {
-   LOG(OrderMan, Info, "Received order detach from client: {}",
-       utils::pb::to_string(c));
-
+   INFO_FN("detach_order", "rid: {}; req: {}", rid, utils::pb::to_string(c));
    me->service_call_marshaller.schedule_action([this, c, rid]() {
       auto ok = OrderKey(c.order_key());
       if (is_ready()) {
@@ -300,15 +316,13 @@ void ServiceBridge::detach_order(uint32_t rid, api::orderman::Detach const &c) {
 
 void ServiceBridge::manually_bust_all_fills(
     const api::orderman::ManualBustParameters &c) {
-   LOG(OrderMan, Info, "ServiceBridge::manually_bust_all_fills: {}",
-       utils::pb::to_string(c));
+   INFO_FN("manually_bust_all_fills", "req: {}", utils::pb::to_string(c));
    me->service_call_marshaller.schedule_action(
        [this, c]() { publish(me->manually_bust_fills_pub, c.account()); });
 }
 
 void ServiceBridge::send_rfq(api::orderman::RFQRequest const &rfq) {
-   LOG(OrderMan, Info, "ServiceBridge::send_rfq rfq: {}",
-       utils::pb::to_string(rfq));
+   INFO_FN("send_rfq", "req: {}", utils::pb::to_string(rfq));
    me->service_call_marshaller.schedule_action(
        [this, rfq]() { publish(me->rfq_pub, rfq); });
 }
@@ -398,6 +412,11 @@ std::optional<FilledPositionEvent> make_pos_event(
 
 void ServiceBridge::update_position(
     api::position::Position_dataUpdate const &pos) {
+   INFO_FN(
+       "update_position",
+       "n_added: {}; n_changed: {}; n_removed: {}; n_total: {}",
+       pos.added().size(), pos.changed().size(), pos.removed().size(),
+       pos.all().size());
    std::vector<FilledPositionEvent> evs;
    for (auto const &pu : pos.added()) {
       auto ev = make_pos_event(*pu, me->sec_db);
@@ -430,6 +449,9 @@ bool ServiceBridge::is_ready() const {
 }
 
 void ServiceBridge::maybe_signal_ready(bool old_ready) {
+   INFO_FN(
+       "maybe_signal_ready", "old_ready: {}; is_ready: {}", old_ready,
+       is_ready());
    if (!old_ready && is_ready())
       me->on_ready();
 }

src/lib/orderman/actors/order_manager/OrderManager.cpp

@@ -40,6 +40,13 @@
 namespace bts {
 namespace orderman {
 
+#define _LOG_FN(level, fn, ...)                                                \
+   LOG(OrderMan, level, "OrderManager::" fn ". " __VA_ARGS__)
+#define DIAG_FN(fn, ...) _LOG_FN(Diag, fn, __VA_ARGS__)
+#define INFO_FN(fn, ...) _LOG_FN(Info, fn, __VA_ARGS__)
+#define WARN_FN(fn, ...) _LOG_FN(Warn, fn, __VA_ARGS__)
+#define ERROR_FN(fn, ...) _LOG_FN(Error, fn, __VA_ARGS__)
+
 using namespace mercury;
 
 enum class OrderManager::State {
@@ -80,6 +87,23 @@ struct OrderManager::PImpl {
    mercury::Stream<OrderManagerReadyEvent> pub_ready;
    std::thread background_thread;
    std::atomic<bool> shutdown = false;
+
+   constexpr std::string state_name() {
+      switch (state) {
+      case State::WAIT_ADMIN:
+         return "WAIT_ADMIN";
+      case State::WAIT_SEC:
+         return "WAIT_SEC";
+      case State::WAIT_FILLED_POSITION:
+         return "WAIT_FILLED_POSITION";
+      case State::WAIT_ORDERS:
+         return "WAIT_ORDERS";
+      case State::READY:
+         return "READY";
+      default:
+         return "UNKNOWN";
+      }
+   }
 };
 
 OrderManager::OrderManager(
@@ -108,6 +132,7 @@ OrderManager::~OrderManager() {
 }
 
 void OrderManager::init() {
+   INFO_FN("init", "state: {}", me->state_name());
    subscribe<NewAdminDataEvent>(
        [this](auto const &admin_update) { this->on_admin_data(admin_update); });
    subscribe<AccountPnLUpdateEvent>(
@@ -119,300 +144,365 @@ void OrderManager::init() {
 }
 
 void OrderManager::on_admin_data(const mercury::Update<NewAdminDataEvent> &m) {
-   if (m.events) {
-      if (me->state == State::WAIT_ADMIN) {
-         LOG(OrderMan, Info,
-             "Order manager received admin data. Subscribing to security list "
-             "now ");
-         for (auto &osd : me->services_data.sessions)
-            osd->gw->on_admin_data(m);
+   if (!m.events) {
+      WARN_FN("on_admin_data", "no event data. state: {}", me->state_name());
+      return;
+   }
+   INFO_FN("on_admin_data", "state: {}", me->state_name());
+   if (me->state == State::WAIT_ADMIN) {
+      for (auto &osd : me->services_data.sessions)
+         osd->gw->on_admin_data(m);
 
-         me->state = State::WAIT_SEC;
-         subscribe<NewSecuritiesEvent>([this](auto const &sec_update) {
-            this->on_securities(sec_update);
-         });
-      }
+      me->state = State::WAIT_SEC;
+      INFO_FN("on_admin_data", "state: {}", me->state_name());
+      subscribe<NewSecuritiesEvent>(
+          [this](auto const &sec_update) { this->on_securities(sec_update); });
+   }
 
-      for (auto ev : *m.events) {
-         me->services_data.order_router.update(*ev.admin_data);
-         me->services_data.limiter.update(*ev.admin_data);
-      }
+   for (auto ev : *m.events) {
+      me->services_data.order_router.update(*ev.admin_data);
+      me->services_data.limiter.update(*ev.admin_data);
    }
 }
 
 void OrderManager::on_pnl_update(
     const mercury::Update<AccountPnLUpdateEvent> &u) {
-   if (u.events)
-      for (auto ev : *u.events)
-         me->services_data.limiter.set_day_pnl(ev.account_id, ev.day_pnl);
+   if (!u.events) {
+      WARN_FN("on_pnl_update", "no event data. state: {}", me->state_name());
+      return;
+   }
+   // This log is too noisy. It fires regularly on an interval (sometimes when
+   // the pnl hasn't actually changed).
+   // INFO_FN(
+   //     "on_pnl_update", "state: {}; n_events: {}", me->state_name(),
+   //     u.events->size());
+   for (auto ev : *u.events) {
+      me->services_data.limiter.set_day_pnl(ev.account_id, ev.day_pnl);
+   }
 }
 
 void OrderManager::on_excess_liquidity_update(
     const mercury::Update<ExcessLiquidityUpdateEvent> &u) {
-   if (u.events)
-      for (auto ev : *u.events)
-         me->services_data.limiter.set_excess_liquidity(
-             ev.account_id, ev.excess_liquidity);
+   if (!u.events) {
+      WARN_FN(
+          "on_excess_liquidity_update", "no event data. state: {}",
+          me->state_name());
+      return;
+   }
+   INFO_FN(
+       "on_excess_liquidity_update", "state: {}; n_events: {}",
+       me->state_name(), u.events->size());
+   for (auto ev : *u.events) {
+      me->services_data.limiter.set_excess_liquidity(
+          ev.account_id, ev.excess_liquidity);
+   }
 }
 
 void OrderManager::on_rfq_send(const mercury::Update<RFQEvent> &rfq) {
-   if (rfq.events) {
-      std::vector<OrderMsg> msgs = {};
-      for (auto ev : *rfq.events) {
-         RFQMsg rfq_msg = RFQMsg(ev);
-         msgs.emplace_back(rfq_msg);
-      }
-      trace::CorID cid = {};
-      LOG(OrderMan, Info, "OrderManager::on_rfq_send n_events: {}",
-          rfq.events->size());
-      for (auto &osd : me->services_data.sessions)
-         osd->gw->send_msgs(msgs, cid);
+   if (!rfq.events) {
+      WARN_FN("on_rfq_send", "no event data. state: {}", me->state_name());
+      return;
+   }
+   INFO_FN(
+       "on_rfq_send", "state: {}; n_events: {}", me->state_name(),
+       rfq.events->size());
+   std::vector<OrderMsg> msgs = {};
+   for (auto ev : *rfq.events) {
+      RFQMsg rfq_msg = RFQMsg(ev);
+      msgs.emplace_back(rfq_msg);
+   }
+   trace::CorID cid = {};
+   for (auto &osd : me->services_data.sessions) {
+      osd->gw->send_msgs(msgs, cid);
    }
 }
 
 void OrderManager::on_securities(
     const mercury::Update<NewSecuritiesEvent> &update) {
-
+   if (!update.events) {
+      WARN_FN("on_securities", "no event data. state: {}", me->state_name());
+      return;
+   }
+   INFO_FN(
+       "on_securities", "state: {}; n_events: {}", me->state_name(),
+       update.events->size());
    // forward to execution gateways
    for (auto &osd : me->services_data.sessions)
       osd->gw->on_securities(update);
 
-   if (update.events) {
+   // update our security db and accumulate for the sake of the limiter
+   std::vector<api::Security const *> secs;
+   for (auto const &ev : *(update.events)) {
+      auto sec_ptr = ev.security;
+      secs.push_back(sec_ptr);
+   }
+   me->services_data.limiter.add_securities(secs);
 
-      // update our security db and accumulate for the sake of the limiter
-      std::vector<api::Security const *> secs;
-      for (auto const &ev : *(update.events)) {
-         auto sec_ptr = ev.security;
-         secs.push_back(sec_ptr);
-      }
-      me->services_data.limiter.add_securities(secs);
-
-      if (me->state == State::WAIT_SEC) {
-         LOG(OrderMan, Info,
-             "Order manager received initial set of {} "
-             "securities. Waiting for the filled position now",
-             update.events->size());
-         me->state = State::WAIT_FILLED_POSITION;
-         me->filled_position_sub = subscribe<FilledPositionEvent>(
-             [this](auto const &pos) { this->on_filled_position(pos); });
-      }
+   if (me->state == State::WAIT_SEC) {
+      me->state = State::WAIT_FILLED_POSITION;
+      INFO_FN(
+          "on_securities", "received initial set of {} securities. state: {}",
+          update.events->size(), me->state_name());
+      me->filled_position_sub = subscribe<FilledPositionEvent>(
+          [this](auto const &pos) { this->on_filled_position(pos); });
    }
 }
 
 void OrderManager::on_filled_position(
     const mercury::Update<FilledPositionEvent> &update) {
-   if (update.events) {
-      if (me->state == State::WAIT_FILLED_POSITION) {
-         LOG(OrderMan, Info,
-             "Order manager received initial set of {} "
-             "stored filled position records. Waiting for stored orders now",
-             update.events->size());
-         me->state = State::WAIT_ORDERS;
-         me->stored_order_sub = subscribe<StoredOrderEvent>(
-             [this](auto const &orders) { this->on_order_recovery(orders); });
-      }
+   if (!update.events) {
+      WARN_FN(
+          "on_filled_position", "no event data. state: {}", me->state_name());
+      return;
+   }
+   INFO_FN(
+       "on_filled_position", "state: {}; n_events: {}", me->state_name(),
+       update.events->size());
+   if (me->state == State::WAIT_FILLED_POSITION) {
+      me->state = State::WAIT_ORDERS;
+      INFO_FN("on_filled_position", "new_state: {}", me->state_name());
+      me->stored_order_sub = subscribe<StoredOrderEvent>(
+          [this](auto const &orders) { this->on_order_recovery(orders); });
+   }
 
-      for (auto const &ev : *(update.events)) {
-         me->services_data.position.update(ev);
-         me->services_data.limiter.set_filled_position(
-             *ev.security, ev.account_id, ev.long_quantity, ev.short_quantity);
-      }
+   for (auto const &ev : *(update.events)) {
+      me->services_data.position.update(ev);
+      me->services_data.limiter.set_filled_position(
+          *ev.security, ev.account_id, ev.long_quantity, ev.short_quantity);
    }
 }
 
 void OrderManager::on_order_recovery(
     const mercury::Update<StoredOrderEvent> &update) {
-   if (update.events)
-      if (me->state == State::WAIT_ORDERS) {
+   if (!update.events) {
+      WARN_FN(
+          "on_order_recovery", "no event data. state: {}", me->state_name());
+      return;
+   }
+   if (me->state != State::WAIT_ORDERS) {
+      WARN_FN(
+          "on_order_recovery",
+          "Expected state WAIT_ORDERS. state: {}; n_events: {}",
+          me->state_name(), update.events->size());
+      return;
+   }
+   // Got the first batch of persisted orders which has to match the orders
+   // stored on disk (since we are the only ones producing new orders)
+   INFO_FN(
+       "on_order_recovery", "state: {}; n_events: {}", me->state_name(),
+       update.events->size());
+   // Don't need to monitor persisted orders anymore, all the new orders we care
+   // about will be generated by us.
+   unsubscribe(me->stored_order_sub);
 
-         // Got the first batch of persisted orders which has to match
-         // the orders stored on disk (since we are the only ones
-         // producing new orders)
-         LOG(OrderMan, Info,
-             "Order manager received initial set of {} persisted orders.",
-             update.events->size());
+   init_order_services();
 
-         // Don't need to monitor persisted orders anymore, all the
-         // new orders we care about will be generated by us.
-         unsubscribe(me->stored_order_sub);
+   // recover orders from disk
+   for (auto const &ev : *(update.events)) {
+      auto &order = me->services_data.order_factory.recover(ev.order_record);
+      auto const &def = order.def();
+      publish_order_def_update(OrderKey(ev.key()), def);
+      order.init_order_services(me->services_data);
 
-         init_order_services();
+      auto r = me->orders.emplace(order.key(), &order);
+      bts_assert(r.second);
+      auto const &ostate = ev.order_record.state();
+      order.on_activate(
+          Price(ostate.price()), Quantity(ostate.quantity()), *order._services);
+   }
 
-         // recover orders from disk
-         for (auto const &ev : *(update.events)) {
-            auto &order =
-                me->services_data.order_factory.recover(ev.order_record);
-            auto const &def = order.def();
-            publish_order_def_update(OrderKey(ev.key()), def);
-            order.init_order_services(me->services_data);
-
-            auto r = me->orders.emplace(order.key(), &order);
-            bts_assert(r.second);
-            auto const &ostate = ev.order_record.state();
-            order.on_activate(
-                Price(ostate.price()), Quantity(ostate.quantity()),
-                *order._services);
-         }
-
-         // signal that we are ready
-         LOG(OrderMan, Info, "Order manager is ready");
-         publish(me->pub_ready);
-         me->state = State::READY;
-      }
+   // signal that we are ready
+   INFO_FN("on_order_recovery", "OrderManager is ready");
+   publish(me->pub_ready);
+   me->state = State::READY;
 }
 
 void OrderManager::on_execution_report(
     const mercury::Update<NewExecutionReportEvent> &m) {
-   if (m.events)
-      for (auto const &report : *m.events)
-         if (report.data->leg_security == nullptr) {
-            auto k = report.data->order_key;
-            auto it = me->orders.find(k);
-            if (it == me->orders.end()) {
-               LOG(OrderMan, Error,
-                   "Received an execution report for an unknown order with key "
-                   "{}. Order state will be reconstructed from this report but "
-                   "some "
-                   "information will be lost, including CustomerOrFirm,CTI "
-                   "code "
-                   "and "
-                   "parent order id",
-                   k.value());
-               auto order =
-                   &me->services_data.order_factory.recreate_from_exe_report(
-                       *report.data);
-               auto const &def = order->def();
-               publish_order_def_update(OrderKey(k), def);
-               order->init_order_services(me->services_data);
-               auto r = me->orders.emplace(order->key(), order);
-               bts_assert(r.second);
-               order->on_activate(
-                   report.data->price, report.data->quantity,
-                   *order->_services);
-            }
-         }
+   if (!m.events) {
+      WARN_FN("on_execution_report", "no event data");
+      return;
+   }
+   INFO_FN(
+       "on_execution_report", "state: {}; n_events", me->state_name(),
+       m.events->size());
+   for (auto const &report : *m.events) {
+      if (report.data->leg_security != nullptr) {
+         continue;
+      }
+      auto k = report.data->order_key;
+      auto it = me->orders.find(k);
+      if (it == me->orders.end()) {
+         ERROR_FN(
+             "on_execution_report",
+             "Received an execution report for an unknown order with key {}. "
+             "Order state USED TO be reconstructed from this report but some "
+             "information will be lost, including CustomerOrFirm,CTI code and "
+             "parent order id but now these are IGNORED",
+             k.value());
+         continue;
+         // auto order = &me->services_data.order_factory.recreate_from_exe_report(
+         //     *report.data);
+         // auto const &def = order->def();
+         // publish_order_def_update(OrderKey(k), def);
+         // order->init_order_services(me->services_data);
+         // auto r = me->orders.emplace(order->key(), order);
+         // bts_assert(r.second);
+         // order->on_activate(
+         //     report.data->price, report.data->quantity, *order->_services);
+      }
+   }
 }
 
 void OrderManager::on_activate_order(
     const mercury::Update<ActivateOrderEvent> &m) {
-   if (m.events)
-      for (auto const &ev : *m.events) {
-         LOG(OrderMan, Info,
-             "OrderManager::on_activate_order req_id: {} p: {} q: {}",
-             ev.req_id, ev.price, ev.quantity);
-         auto order = ev.order;
-         auto const &def = order->def();
-         publish_order_def_update(order->key(), def);
-         order->init_order_services(me->services_data);
-         auto r = me->orders.emplace(order->key(), order);
-         bts_assert(r.second);
+   if (!m.events) {
+      WARN_FN("on_activate_order", "no event data");
+      return;
+   }
+   INFO_FN(
+       "on_activate_order", "state: {}; n_events: {}", me->state_name(),
+       m.events->size());
+   for (auto const &ev : *m.events) {
+      LOG(OrderMan, Info,
+          "OrderManager::on_activate_order req_id: {} p: {} q: {}", ev.req_id,
+          ev.price, ev.quantity);
+      auto order = ev.order;
+      auto const &def = order->def();
+      publish_order_def_update(order->key(), def);
+      order->init_order_services(me->services_data);
+      auto r = me->orders.emplace(order->key(), order);
+      bts_assert(r.second);
 
-         auto rid = ev.req_id;
-         auto k = order->key();
-         auto on_response = [this, rid, k](auto const &order_op_result) {
-            publish(
-                me->services_data.report_order_op_result_pub, k, rid,
-                order_op_result);
-         };
-         order->_services->activate(ev.price, ev.quantity, on_response);
-      }
+      auto rid = ev.req_id;
+      auto k = order->key();
+      auto on_response = [this, rid, k](auto const &order_op_result) {
+         publish(
+             me->services_data.report_order_op_result_pub, k, rid,
+             order_op_result);
+      };
+      order->_services->activate(ev.price, ev.quantity, on_response);
+   }
 }
 
 void OrderManager::on_update_order(const mercury::Update<UpdateOrderEvent> &m) {
-   if (m.events)
-      for (auto const &ev : *m.events) {
-         auto k = ev.key();
-         auto it = me->orders.find(k);
-         auto rid = ev.req_id();
+   if (!m.events) {
+      WARN_FN("on_update_order", "no event data");
+      return;
+   }
+   INFO_FN(
+       "on_update_order", "state: {}; n_events: {}", me->state_name(),
+       m.events->size());
+   for (auto const &ev : *m.events) {
+      auto k = ev.key();
+      auto it = me->orders.find(k);
+      auto rid = ev.req_id();
 
-         auto on_order_op_result = [this, rid, k](auto const &order_op_result) {
-            publish(
-                me->services_data.report_order_op_result_pub, k, rid,
-                order_op_result);
-         };
+      auto on_order_op_result = [this, rid, k](auto const &order_op_result) {
+         publish(
+             me->services_data.report_order_op_result_pub, k, rid,
+             order_op_result);
+      };
 
-         if (it != me->orders.end()) {
-            if (ev.is_full_update())
-               it->second->_services->update(
-                   ev.full_update(), on_order_op_result);
-            else
-               it->second->_services->update(
-                   Price(ev.price()), Quantity(ev.quantity()),
-                   on_order_op_result);
+      if (it != me->orders.end()) {
+         if (ev.is_full_update()) {
+            it->second->_services->update(ev.full_update(), on_order_op_result);
          } else {
-            on_order_op_result(OrderOpResult{
-                api::orderman::ORDER_ERROR_UNKNOWN_ORDER, "Unknown order"});
-            LOG(OrderMan, Error,
-                "Received an update request for an unknown order {}. "
-                "This should not happen and likely indicates a serious bug. ",
-                ev.key().value());
+            it->second->_services->update(
+                Price(ev.price()), Quantity(ev.quantity()), on_order_op_result);
          }
+      } else {
+         on_order_op_result(OrderOpResult{
+             api::orderman::ORDER_ERROR_UNKNOWN_ORDER, "Unknown order"});
+         ERROR_FN(
+             "on_update_order",
+             "order not found (id={}). This likely indicates a serious bug.",
+             ev.key().value());
       }
+   }
 }
 
 void OrderManager::on_cancel_order(const mercury::Update<CancelOrderEvent> &m) {
-   if (m.events)
-      for (auto const &ev : *m.events) {
-         auto k = ev.key();
-         auto it = me->orders.find(k);
-         auto rid = ev.req_id;
+   if (!m.events) {
+      WARN_FN("on_cancel_order", "no event data");
+      return;
+   }
+   INFO_FN(
+       "on_cancel_order", "state: {}; n_events: {}", me->state_name(),
+       m.events->size());
+   for (auto const &ev : *m.events) {
+      auto k = ev.key();
+      auto it = me->orders.find(k);
+      auto rid = ev.req_id;
 
-         auto on_order_op_result = [this, rid, k](auto const &order_op_result) {
-            publish(
-                me->services_data.report_order_op_result_pub, k, rid,
-                order_op_result);
-         };
+      auto on_order_op_result = [this, rid, k](auto const &order_op_result) {
+         publish(
+             me->services_data.report_order_op_result_pub, k, rid,
+             order_op_result);
+      };
 
-         if (it != me->orders.end())
-            it->second->_services->cancel(on_order_op_result);
-         else {
-            on_order_op_result(OrderOpResult{
-                api::orderman::ORDER_ERROR_UNKNOWN_ORDER, "Unknown order"});
-            LOG(OrderMan, Error,
-                "Received a cancel request for an unknown order {}. "
-                "This should not happen and likely indicates a serious bug. ",
-                ev.key().value());
-         }
+      if (it != me->orders.end()) {
+         it->second->_services->cancel(on_order_op_result);
+      } else {
+         on_order_op_result(OrderOpResult{
+             api::orderman::ORDER_ERROR_UNKNOWN_ORDER, "Unknown order"});
+         ERROR_FN(
+             "on_cancel_order",
+             "order not found (id={}). This likely indicates a serious bug.",
+             ev.key().value());
       }
+   }
 }
 
 void OrderManager::on_detach_order(const mercury::Update<DetachOrderEvent> &m) {
-   if (m.events)
-      for (auto const &ev : *m.events) {
-         auto k = ev.key();
-         auto it = me->orders.find(k);
-         auto rid = ev.req_id;
+   if (!m.events) {
+      WARN_FN("on_detach_order", "no event data");
+      return;
+   }
+   INFO_FN(
+       "on_detach_order", "state: {}; n_events: {}", me->state_name(),
+       m.events->size());
+   for (auto const &ev : *m.events) {
+      auto k = ev.key();
+      auto it = me->orders.find(k);
+      auto rid = ev.req_id;
 
-         auto on_order_op_result = [this, rid, k](auto const &order_op_result) {
-            publish(
-                me->services_data.report_order_op_result_pub, k, rid,
-                order_op_result);
-         };
+      auto on_order_op_result = [this, rid, k](auto const &order_op_result) {
+         publish(
+             me->services_data.report_order_op_result_pub, k, rid,
+             order_op_result);
+      };
 
-         if (it != me->orders.end())
-            it->second->_services->detach(on_order_op_result);
-         else {
-            on_order_op_result(OrderOpResult{
-                api::orderman::ORDER_ERROR_UNKNOWN_ORDER, "Unknown Order"});
+      if (it != me->orders.end()) {
+         it->second->_services->detach(on_order_op_result);
+      } else {
+         on_order_op_result(OrderOpResult{
+             api::orderman::ORDER_ERROR_UNKNOWN_ORDER, "Unknown Order"});
 
-            LOG(OrderMan, Error,
-                "Received a detach request for an unknown order {}. "
-                "This should not happen and likely indicates a serious bug. ",
-                ev.key().value());
-         }
+         ERROR_FN(
+             "on_detach_order",
+             "order not found (id={}). This likely indicates a serious bug.",
+             ev.key().value());
       }
+   }
 }
 
 void OrderManager::on_gateway_state(
     const mercury::Update<GatewayStatusChangeEvent> &m) {
-   if (m.events)
-      for (auto const &ev : *m.events) {
-         LOG(OrderMan, Info,
-             " OrderManager::on_gateway_state gw: {} connected: {}", ev.gw_name,
-             ev.is_connected);
-         auto &sr = me->services_data.get_session(ev.gw_name.value());
-         sr.gw_connected = ev.is_connected;
-      }
+   if (!m.events) {
+      WARN_FN("on_gateway_state", "no event data");
+      return;
+   }
+   INFO_FN(
+       "on_gateway_state", "state: {}; n_events: {}", me->state_name(),
+       m.events->size());
+   for (auto const &ev : *m.events) {
+      LOG(OrderMan, Info,
+          " OrderManager::on_gateway_state gw: {} connected: {}", ev.gw_name,
+          ev.is_connected);
+      auto &sr = me->services_data.get_session(ev.gw_name.value());
+      sr.gw_connected = ev.is_connected;
+   }
 }
 
 void OrderManager::add_child_order(OrderServices &parent, Order &child) {
@@ -470,9 +560,12 @@ void OrderManager::init_order_services() {
                   return s->session;
                }),
        ", "));
-   LOG(OrderMan, Info, "init_order_services. sessions: {}", session_names);
+   INFO_FN(
+       "init_order_services", "state: {}; sessions: {}", me->state_name(),
+       session_names);
 
    for (auto &s : me->services_data.sessions) {
+      INFO_FN("init_order_services", "Initializing session {}", s->session);
       auto gw_name = GatewayName(s->session);
 
       // Now we are ready to subscribe to the execution gateway
@@ -535,9 +628,11 @@ void OrderManager::init_order_services() {
       // reject evets
       auto s_ptr = s.get();
       s->exe_report_pub = make_stream<NewExecutionReportEvent>(gw_name);
-      s->gw->on_exe_report() = [s_ptr, this](auto const &er, auto const &t) {
-         publish(s_ptr->exe_report_pub, &er, t);
-      };
+      s->gw->on_exe_report() =
+          [s_ptr,
+           this](std::shared_ptr<const ExecutionReport> er, auto const &t) {
+             publish(s_ptr->exe_report_pub, std::move(er), t);
+          };
       s->gw_status_change_pub = make_stream<GatewayStatusChangeEvent>(gw_name);
       s->gw->on_gw_status_change() = [s_ptr, this, gw_name](bool b) {
          publish(s_ptr->gw_status_change_pub, gw_name, b);
@@ -563,9 +658,10 @@ void OrderManager::init_order_services() {
       s->gw->on_cancel_reject() = [s_ptr, this](auto const &cr) {
          publish(s_ptr->cancel_reject_pub, cr);
       };
+      INFO_FN("init_order_services", "Starting session {}", s->session);
       // handlers are ready so we can start processing fix events
       s->gw->start();
-
+      INFO_FN("init_order_services", "Started session {}", s->session);
       reload_fix_buffer(*s);
    }
 
@@ -676,9 +772,10 @@ void OrderManager::after_event() {
          if (queued_ops.size()) {
             auto &corid = osd->current_trace;
             auto now = utils::TimeStamp::now();
-            LOG(Latency, Info,
-                "entry_type:after_event channel:{} sn:{} app_arrival:{} now:{} "
-                "delta:{}",
+            INFO_FN(
+                "after_event",
+                "channel: {} sn: {} app_arrival: {} now: {} "
+                "delta: {}",
                 std::string{corid.channel}, corid.sn,
                 corid.app_arrival.to_uint64(), now.to_uint64(),
                 (now - corid.app_arrival).nanoseconds());
@@ -694,9 +791,9 @@ void OrderManager::reload_fix_buffer(SessionServicesData &osd) {
       osd.buffered_fix_msgs = osd.free_buffers.back();
       osd.free_buffers.pop_back();
    } else {
-      LOG(OrderMan, Warn,
-          "Ran out of fix buffers in {}.  Will allocate directly. "
-          "This will have an impact on performance",
+      WARN_FN(
+          "reload_fix_buffer",
+          "Allocating new fix buffers in {}. This will impact performance",
           osd.cfg.name());
       osd.buffered_fix_msgs = std::make_shared<jetfix::OutFIX>(osd.cfg);
    }

src/lib/orderman/actors/order_manager/OrderServicesData.cpp

@@ -1,10 +1,6 @@
 #include "OrderServicesData.h"
-#include "lib/config/config.h"
-#include "lib/config/protos/jetfix.pb.h"
 #include "lib/md/SecurityOracle.h"
 #include "lib/orderman/actors/order_manager/order_gateway_definition.h"
-#include "lib/orderman/gateways/ExecutionGatewayFactory.h"
-#include "lib/os/spark_data_directory.h"
 #include "lib/tracing/PerfLog.h"
 
 namespace bts {
@@ -26,8 +22,6 @@ OrderServicesData::OrderServicesData(
    for (auto &g : gateways) {
       sessions.push_back(std::make_unique<SessionServicesData>(std::move(g)));
    }
-   // spark::SparkDataDirectory data_dir;
-   // auto binance_j = data_dir.load_config_json("binance_execution");
 }
 
 } // namespace orderman

src/lib/orderman/actors/order_manager/OrderServicesData.h

@@ -34,7 +34,6 @@
 #include "lib/orderman/events/TickerUpdateEvent.h"
 #include "lib/orderman/events/TradeSignalEvent.h"
 #include "lib/orderman/events/UpdateOrderEvent.h"
-#include "lib/orderman/gateways/ExecutionGatewayFactory.h"
 #include "lib/orderman/gateways/IExecutionGateway.h"
 #include "lib/orderman/limiter/Limiter.h"
 #include "lib/orderman/order_factory/OrderFactory.h"

src/lib/orderman/actors/order_manager/session_services_data.h

@@ -10,7 +10,6 @@
 #include "lib/orderman/events/ExchangePositionEvent.h"
 #include "lib/orderman/events/GatewayStatusChangeEvent.h"
 #include "lib/orderman/events/NewExecutionReportEvent.h"
-#include "lib/orderman/gateways/ExecutionGatewayFactory.h"
 #include "lib/orderman/gateways/IExecutionGateway.h"
 #include "lib/utils/PBUtils.h"
 

src/lib/orderman/ccapi/CCAPIDeribitOrderMux.cpp

@@ -20,6 +20,7 @@
 #include "lib/utils/bts_assert.h"
 #include <bits/stdint-uintn.h>
 #include <boost/lockfree/spsc_queue.hpp>
+#include <ccapi_cpp/bts_session_options.h>
 #include <ccapi_cpp/ccapi_element.h>
 #include <ccapi_cpp/ccapi_event.h>
 #include <ccapi_cpp/ccapi_macro.h>
@@ -255,7 +256,8 @@ struct CCAPIDeribitOrderMux::PImpl {
           {CCAPI_DERIBIT_CLIENT_ID, d_conn_config.client_id},
           {CCAPI_DERIBIT_CLIENT_SECRET, d_conn_config.client_secret},
       });
-      session = new ccapi::Session({}, session_configs, &event_handler);
+      session = new ccapi::Session(
+          {}, {ccapi::BtsVenues::DERIBIT}, session_configs, &event_handler);
    }
 };
 
@@ -953,4 +955,4 @@ void CCAPIDeribitOrderMux::_send_buffered_orders(uint32_t sec_id) {
        "n_buffered_orders: {}",
        me->buffered_creates.size());
 }
-} // namespace bts::orderman
+} // namespace bts::orderman

src/lib/orderman/events/NewExecutionReportEvent.h

@@ -20,12 +20,13 @@ class NewExecutionReportEvent : public mercury::Event<NewExecutionReportEvent> {
  public:
    using Tag = GatewayName;
    using SynopsisPolicy = mercury::CacheAll<NewExecutionReportEvent>;
-   ExecutionReport const *data;
+   std::shared_ptr<const ExecutionReport> data;
    trace::CorID trace;
    // used by ContentSubscription
    OrderKey key() const { return data->order_key; }
-   NewExecutionReportEvent(const ExecutionReport *dt, trace::CorID const &trace)
-       : data(dt), trace(trace){};
+   NewExecutionReportEvent(
+       std::shared_ptr<const ExecutionReport> dt, trace::CorID const &trace)
+       : data(std::move(dt)), trace(trace){};
 };
 
 } // namespace orderman

src/lib/orderman/gateways/CCAPIExecutionGateway.cpp

@@ -40,7 +40,7 @@
 #include <bits/stdint-uintn.h>
 //#include <boost/container/small_vector.hpp>
 #include "lib/orderman/ccapi/CCAPIConnectionConfig.h"
-#include <boost/pool/object_pool.hpp>
+
 #include <cmath>
 #include <cstdint>
 #include <optional>
@@ -138,7 +138,6 @@ struct CCAPIExecutionGateway::PImpl {
    OnExchangeOpenOrdersState on_exchange_open_orders;
    // orders are sent out and callbacks received via IEMOrderMuxer
    size_t msg_seq_num = 0;
-   boost::object_pool<ExecutionReport> exe_report_pool;
    std::unordered_map<OrderKey, CreateOrderMsg> order_map = {};
    // this is updated as we get exchange positions
    ExchangePosition exchange_position;
@@ -339,8 +338,7 @@ void CCAPIExecutionGateway::_on_order_cb(const CCAPIOrderState &s) {
    const auto &cr_msg = it->second;
 
    // cant create one on the stack
-   ExecutionReport *er_p = me->exe_report_pool.construct();
-   ExecutionReport &er = *er_p;
+   ExecutionReport er;
    // length of these have to be <= 12
    to_array(cr_msg.routing_record->account(), &er.account_name.value());
    to_array(cr_msg.routing_record->operator_id(), &er.operator_id.value());
@@ -390,7 +388,7 @@ void CCAPIExecutionGateway::_on_order_cb(const CCAPIOrderState &s) {
    LOG(OrderMan, Info,
        "CCAPIExecutionGateway::_process_cb_and_fire_er firing er: {}",
        er.to_string());
-   me->on_exe_report(er, {});
+   me->on_exe_report(std::make_shared<ExecutionReport>(std::move(er)), {});
    // _fire_leg_er(em_cb, er);
 }
 

src/lib/orderman/gateways/ExecutionGatewayFactory.cpp

@@ -1,61 +0,0 @@
-#include "ExecutionGatewayFactory.h"
-#include "lib/domain_model/Security.pb.h"
-#include "lib/md/SecurityOracle.h"
-#include "lib/orderman/gateways/CCAPIExecutionGateway.h"
-// #include "lib/orderman/gateways/EMExecutionGateway.h"
-#include "lib/orderman/gateways/FakeExecutionGateway.h"
-#include "lib/orderman/gateways/GeneralExecutionGateway.h"
-#include "lib/orderman/gateways/GLBXExecutionGateway.h"
-#include "lib/orderman/gateways/GLBXiLink3ExecutionGateway.h"
-#include "lib/orderman/gateways/ICEExecutionGateway.h"
-#include "lib/orderman/gateways/IExecutionGenericAdapter.h"
-#include "lib/orderman/gateways/OkxExecutionAdapter.h"
-#include "lib/orderman/gateways/OnixFIXAdapter.h"
-#include "lib/orderman/gateways/sim/SimExecutionGatewayFactory.h"
-#include "lib/orderman/gateways/sim/SimExecutionGatewayUniqueWrapper.h"
-#include "lib/tracing/PerfLog.h"
-#include "lib/utils/PBUtils.h"
-#include "lib/utils/ValueWrapper.h"
-#include <memory>
-#include <variant>
-
-namespace bts::orderman {
-
-std::unique_ptr<IExecutionGateway> ExecutionGatewayFactory::create_gateway(
-    const config::JetFIX::Connection &conn,
-    trace::PerfLog &pl,
-    md::SecurityOracle o) {
-   LOG(OrderMan, Info, "ExecutionGatewayFactory::create_gateway conn: {}",
-       utils::pb::to_string(conn));
-   if (SimExecutionGatewayFactory::is_sim_execution_on(conn.venue())) {
-      return std::make_unique<SimExecutionGatewayUniqueWrapper>(conn.venue());
-   }
-   LOG(OrderMan, Info, "ExecutionGatewayFactory::create_gateway NOT SIM conn: {}",
-       utils::pb::to_string(conn));
-   switch(conn.venue()){
-      case bts::api::VENUE_ICE:
-      case bts::api::VENUE_SIMICE:
-         return std::make_unique<ICEExecutionGateway>(conn, pl, o);
-      case bts::api::VENUE_GLBX:{
-         if (conn.use_ilink3())
-            return std::make_unique<ilink3::GLBXiLink3ExecutionGateway>( conn, pl, o);
-         return std::make_unique<GLBXExecutionGateway>(conn, pl, o);
-      }
-      case bts::api::VENUE_DERIBIT:
-         return std::make_unique<CCAPIExecutionGateway>(conn.venue(), o);
-      case bts::api::VENUE_CBOE:
-         {
-             std::unique_ptr<IExecutionGenericAdapter> adapter = std::make_unique<OnixFIXAdapter>(o);
-            return std::make_unique<GeneralExecutionGateway>(conn.venue(),std::move(adapter),o);
-         }
-      case bts::api::VENUE_OKX:
-         {
-             std::unique_ptr<IExecutionGenericAdapter> adapter = std::make_unique<OkxExecutionAdapter>(o);
-            return std::make_unique<GeneralExecutionGateway>(conn.venue(),std::move(adapter),o);
-         }
-      default:
-         return std::make_unique<FakeExecutionGateway>(o);
-   }
-}
-
-} // namespace bts::orderman

src/lib/orderman/gateways/ExecutionGatewayFactory.h

@@ -1,25 +0,0 @@
-#pragma once
-#include "lib/config/protos/jetfix.pb.h"
-#include <memory>
-
-namespace bts::trace {
-class PerfLog;
-}
-
-namespace bts::md {
-class SecurityOracle;
-}
-
-namespace bts::orderman {
-
-class IExecutionGateway;
-
-class ExecutionGatewayFactory {
- public:
-   static std::unique_ptr<IExecutionGateway> create_gateway(
-       const config::JetFIX::Connection &,
-       trace::PerfLog &,
-       md::SecurityOracle);
-};
-
-} // namespace bts::orderman

src/lib/orderman/gateways/FakeExecutionGateway.cpp

@@ -25,7 +25,6 @@
 #include "server/sparkd/md/platforms/emumba/IEMOrderMuxer.h"
 
 #include <atomic>
-#include <boost/pool/object_pool.hpp>
 #include <cstdint>
 #include <set>
 #include <string>
@@ -54,7 +53,7 @@ struct FakeExecutionGateway::PImpl {
    md::SecurityOracle sec_oracle;
    std::vector<OrderMsg> buffered_msgs = {};
    unsigned long exchange_oid = 0;
-   std::vector<ExecutionReport> exe_reports = {};
+   std::vector<std::shared_ptr<ExecutionReport>> exe_reports = {};
    IEMOrderMuxer *_order_mux = nullptr;
 };
 
@@ -84,7 +83,9 @@ void FakeExecutionGateway::dispatch_incoming_fix_messages() {
              "FakeExecutionGateway::dispatch_incoming_fix_message key: {} sec: "
              "{} p: {} q: {}",
              cr_msg.key, cr_msg.security->id(), cr_msg.price, cr_msg.quantity);
-         ExecutionReport er = {};
+         me->exe_reports.push_back(std::make_shared<ExecutionReport>());
+         std::shared_ptr<ExecutionReport> &er_p = me->exe_reports.back();
+         ExecutionReport &er = *er_p;
          std::string account_name = "ACCA1";
          std::array<char, 12> an_array = {};
          size_t i = 0;
@@ -115,19 +116,18 @@ void FakeExecutionGateway::dispatch_incoming_fix_messages() {
          er.msg = "Message Placed";
          er.exchange = api::VENUE_SIM;
          trace::CorID cid = {};
-         me->exe_reports.push_back(er);
-         const auto &er_pheap = me->exe_reports.back();
          LOG(OrderMan, Info,
              "FakeExecutionGateway::dispatch_incoming_fix_messages er: {}",
-             er_pheap.to_string());
-         me->on_exe_report(er_pheap, cid);
+             er.to_string());
+         me->on_exe_report(er_p, cid);
       } else if (std::holds_alternative<CancelOrderMsg>(m)) {
          CancelOrderMsg cxl_m = std::get<CancelOrderMsg>(m);
-         for (auto &er : me->exe_reports) {
+         for (std::shared_ptr<ExecutionReport> &er_p : me->exe_reports) {
+            auto &er = *er_p;
             if (er.order_key == cxl_m.key) {
                er.order_status = api::orderman::NATIVE_ORDER_STATUS_CANCELED;
                er.msg = "Cancelled";
-               me->on_exe_report(er, {});
+               me->on_exe_report(er_p, {});
                LOG(OrderMan, Info,
                    "FakeExecutionGateway::dispatch_incoming_fix_messages er: "
                    "{}",
@@ -138,13 +138,14 @@ void FakeExecutionGateway::dispatch_incoming_fix_messages() {
       } else if (std::holds_alternative<CancelReplaceOrderMsg>(m)) {
          CancelReplaceOrderMsg cxl_r_msg = std::get<CancelReplaceOrderMsg>(m);
          CreateOrderMsg cr_msg = cxl_r_msg.create_fields;
-         for (auto &er : me->exe_reports) {
+         for (std::shared_ptr<ExecutionReport> &er_p : me->exe_reports) {
+            auto &er = *er_p;
             if (er.order_key == cr_msg.key) {
                er.order_status = api::orderman::NATIVE_ORDER_STATUS_REPLACED;
                er.msg = "Replaced";
                er.price = cr_msg.price;
                er.quantity = cr_msg.quantity;
-               me->on_exe_report(er, {});
+               me->on_exe_report(er_p, {});
                return;
             }
          }
@@ -196,4 +197,4 @@ OnExchangeOpenOrdersState &FakeExecutionGateway::on_exchange_open_orders() {
 }
 
 } // namespace orderman
-} // namespace bts
+} // namespace bts

src/lib/orderman/gateways/GLBXExecutionGateway.cpp

@@ -13,8 +13,6 @@
 #include "lib/utils/TimeStamp.h"
 #include "lib/utils/bts_chrono.h"
 
-#include <boost/pool/object_pool.hpp>
-
 namespace bts {
 namespace orderman {
 
@@ -31,12 +29,11 @@ struct GLBXExecutionGateway::PImpl {
        config::JetFIX::Connection const &cfg,
        trace::PerfLog &l,
        md::SecurityOracle o)
-       : gw(cfg, l), exe_report_pool(), state(State::WAITING_FOR_SECURITIES),
+       : gw(cfg, l), state(State::WAITING_FOR_SECURITIES),
          securities(), securities_by_descriptor(), gw_name(cfg.name()),
          cfg(cfg), perf_log(l), sec_oracle(o) {}
 
    JFGw gw;
-   boost::object_pool<ExecutionReport> exe_report_pool;
    State state;
    std::unordered_map<SecurityKey::Value, api::Security const *> securities;
    std::unordered_map<std::string, api::Security const *>
@@ -209,8 +206,8 @@ void GLBXExecutionGateway::on_exe_report(
       if (msg.has<fix::Text>())
          text_msg = msg.get<fix::Text>();
 
-      // allocate from our pool
-      auto data = me->exe_report_pool.construct();
+      ExecutionReport er;
+      ExecutionReport *data = &er;
 
       data->exec_type = api::orderman::ExecType(msg.get<fix::ExecType>());
       data->msg_seq_num = msg.get<fix::MsgSeqNum>();
@@ -290,7 +287,8 @@ void GLBXExecutionGateway::on_exe_report(
       data->cfg = &me->cfg;
       data->msg = text_msg;
       data->exchange = api::Venue::VENUE_GLBX;
-      me->on_exe_report(*data, msg.trace());
+      me->on_exe_report(
+          std::make_shared<ExecutionReport>(std::move(er)), msg.trace());
    }
 }
 

src/lib/orderman/gateways/GLBXiLink3ExecutionGateway.cpp

@@ -12,6 +12,7 @@
 #include "lib/orderman/ilink3/IL3Reactor.h"
 #include "lib/orderman/ilink3/IL3SecDB.h"
 #include "lib/orderman/ilink3/SessionStore.h"
+#include "lib/orderman/orderman_utils/ExecutionReport.h"
 #include "lib/orderman/orderman_utils/fix_order_codec.h"
 #include "lib/utils/PBUtils.h"
 #include <cstddef>
@@ -149,8 +150,11 @@ void GLBXiLink3ExecutionGateway::connect(jetfix::SessionName const &sn) {
    if (!me->has_replayed) {
       me->has_replayed = true;
       me->replay_messages = me->session_store.value().replay();
-      for (auto const &er : me->replay_messages)
-         me->on_exe_report(er, {});
+      for (ExecutionReport &er : me->replay_messages) {
+         me->on_exe_report(
+             std::make_shared<ExecutionReport>(std::move(er)), {});
+      }
+      me->replay_messages.clear();
    }
 
    c.raw_message_logger =
@@ -169,7 +173,7 @@ void GLBXiLink3ExecutionGateway::connect(jetfix::SessionName const &sn) {
 
    me->gw->subscribe_execution_reports([this](auto er) {
       bts_assert(me->state == State::READY || me->state == State::CONNECTING);
-      me->on_exe_report(*er, {});
+      me->on_exe_report(std::move(er), {});
    });
 
    me->gw->subscribe_session(

src/lib/orderman/gateways/GeneralExecutionGateway.cpp

@@ -64,7 +64,9 @@ void GeneralExecutionGateway::send_msgs(
           msg);
    }
 }
-void GeneralExecutionGateway::dispatch_incoming_fix_messages() {}
+void GeneralExecutionGateway::dispatch_incoming_fix_messages() {
+   me->_adapter->dispatch_incoming_fix_messages();
+}
 void GeneralExecutionGateway::on_securities(
     const mercury::Update<NewSecuritiesEvent> &) {}
 void GeneralExecutionGateway::on_admin_data(

src/lib/orderman/gateways/ICEExecutionGateway.cpp

@@ -18,7 +18,6 @@
 #include "lib/utils/helper_macros.h"
 
 #include <atomic>
-#include <boost/pool/object_pool.hpp>
 #include <set>
 
 namespace bts {
@@ -39,13 +38,12 @@ struct ICEExecutionGateway::PImpl {
        const config::JetFIX::Connection &cfg,
        trace::PerfLog &l,
        md::SecurityOracle o)
-       : gw(cfg, l), exe_report_pool(), state(State::WAITING_FOR_SECURITIES),
-         securities(), securities_by_exchange_id(), gw_name(cfg.name()),
-         cfg(cfg), perf_log(l), admin_data(), nusers(-1), connection_time(),
+       : gw(cfg, l), state(State::WAITING_FOR_SECURITIES), securities(),
+         securities_by_exchange_id(), gw_name(cfg.name()), cfg(cfg),
+         perf_log(l), admin_data(), nusers(-1), connection_time(),
          exec_id_to_memo(), sec_oracle(o) {}
 
    JFGw gw;
-   boost::object_pool<ExecutionReport> exe_report_pool;
    State state;
    std::unordered_map<SecurityKey::Value, api::Security const *> securities;
    std::unordered_map<int64_t, api::Security const *> securities_by_exchange_id;
@@ -373,7 +371,8 @@ void ICEExecutionGateway::on_exe_report(
                      std::to_string(msg.get<fix::DeleteReason>());
 
       // allocate from our pool
-      auto data = me->exe_report_pool.construct();
+      ExecutionReport er;
+      ExecutionReport *data = &er;
 
       if (msg.has<fix::Memo>())
          data->memo = msg.get<fix::Memo>();
@@ -467,7 +466,8 @@ void ICEExecutionGateway::on_exe_report(
       data->cfg = &me->cfg;
       data->msg = text_msg;
       data->exchange = api::Venue::VENUE_ICE;
-      me->on_exe_report(*data, msg.trace());
+      me->on_exe_report(
+          std::make_shared<ExecutionReport>(std::move(er)), msg.trace());
    }
 }
 

src/lib/orderman/gateways/IExecutionGateway.h

@@ -28,8 +28,8 @@ class ExecutionReport;
 class CancelReject;
 
 using OnGwStatusChange = std::function<void(bool)>;
-using OnExeReport =
-    std::function<void(ExecutionReport const &, trace::CorID const &)>;
+using OnExeReport = std::function<void(
+    std::shared_ptr<const ExecutionReport>, trace::CorID const &)>;
 using OnCancelReject = std::function<void(CancelReject const &)>;
 using OnExchangePositionState = std::function<void(ExchangePosition const &)>;
 using OnExchangeOpenOrdersState =

src/lib/orderman/gateways/IExecutionGenericAdapter.h

@@ -20,9 +20,10 @@ class NewAdminDataEvent;
 class ExecutionReport;
 class CancelReject;
 
-using OnExecutionReport = std::function<void(ExecutionReport const &, const trace::CorID &)>;
+using OnExecutionReport = std::function<void(
+    std::shared_ptr<const ExecutionReport>, const trace::CorID &)>;
 
-// fix execution gateway for a single FIX session
+//  execution gateway for a single session
 class IExecutionGenericAdapter {
  public:
    IExecutionGenericAdapter() = default;
@@ -34,6 +35,7 @@ class IExecutionGenericAdapter {
    virtual void launch_new_order(const CreateOrderMsg &) =0;
    virtual void modify_order(const CancelReplaceOrderMsg &) = 0;
    virtual void cancel_order(const CancelOrderMsg &) =0;
+   virtual void dispatch_incoming_fix_messages() = 0;
    // as new securities are added
    // virtual void update_securities(
    //     const mercury::Update<NewSecuritiesEvent> &) = 0;

src/lib/orderman/gateways/OkxExecutionAdapter.cpp

@@ -1,95 +0,0 @@
-#include "OkxExecutionAdapter.h"
-#include "OnixS/FIXEngine/FIX/Engine.h"
-#include "lib/config/protos/marex_fix_cfg.pb.h"
-#include "lib/domain_model/Security.pb.h"
-#include "lib/logging/logging.h"
-#include "lib/orderman/CancelOrderMsg.h"
-#include "lib/orderman/CancelReplaceOrderMsg.h"
-#include "lib/orderman/CreateOrderMsg.h"
-#include "lib/orderman/gateways/OnixFIXListener.h"
-#include "lib/orderman/gateways/TrafixOrderStateHandler.h"
-#include "lib/orderman/orderman_utils/orderman_common.h"
-#include "lib/utils/bts_assert.h"
-#include "lib/utils/helper_macros.h"
-#include <OnixS/FIXEngine/FIX/Exception.h>
-#include <OnixS/FIXEngine/FIX/FIX42.h>
-#include <OnixS/FIXEngine/FIX/Message.h>
-#include <OnixS/FIXEngine/FIX/Numeric.h>
-#include <OnixS/FIXEngine/FIX/ProtocolVersion.h>
-#include <cassert>
-#include <chrono>
-#include <exception>
-#include <memory>
-#include <quickfix/FixFields.h>
-#include <ratio>
-#include <string>
-#include <unistd.h>
-
-namespace bts::orderman {
-
-OkxExecutionAdapter::OkxExecutionAdapter(md::SecurityOracle){}//listener() {}
-OkxExecutionAdapter::~OkxExecutionAdapter() {}
-inline void handleOkException(
-    const std::string &context, const std::string &error) {
-   bts_assert_msgf(false, "{} Exception: {}", context, error);
-}
-void OkxExecutionAdapter::start() {
-    int attempt = 0;
-
-    while (true) {
-        try {
-            LOG(OrderMan, Warn, "OkxExecutionAdapter::start Attempting login (Attempt: {})", attempt + 1);
-            LOG(OrderMan, Warn, "OkxExecutionAdapter::start Login successful");
-            break; // Exit loop on success
-        } catch (const std::exception &ex) {
-            const std::string err = ex.what();
-            LOG(OrderMan, Error, "OkxExecutionAdapter::start Login failed: {}. Retrying in {} seconds.", err, 10);
-
-            // if (maxRetries > 0 && ++attempt >= maxRetries) {
-            //     LOG(OrderMan, Error, "OkxExecutionAdapter::start Exceeded max retries ({}). Aborting.", maxRetries);
-            //     handleOkException("OkxExecutionAdapter::start", err);
-            //     break; // Exit if retries are exhausted
-            // }
-            // std::this_thread::sleep_for(std::chrono::seconds(std::max(60,retryInterval)));
-        }
-    }
-}
-
-void OkxExecutionAdapter::modify_order(
-    const CancelReplaceOrderMsg &msg) { //confirm will have everything
-   try {
-      LOG(OrderMan, Warn, "OkxExecutionAdapter::modify_order modifying order{}",
-          msg);
-   } catch (const std::exception &ex) {
-     const std::string err = ex.what();
-      handleOkException("Modify order", err);
-   }
-}
-
-void OkxExecutionAdapter::launch_new_order(const CreateOrderMsg &msg) {
-   LOG(OrderMan, Warn, "launch order {}", msg);
-   try {
-      LOG(OrderMan, Warn, "OkxExecutionAdapter::launch_new_order creating order");
-   }
-   // Shut down all reactors if they exist.
-   catch (const std::exception &ex) {
-    const std::string err = ex.what();
-      handleOkException("Launch order", err);
-   }
-}
-void OkxExecutionAdapter::register_callback([[maybe_unused]]const OnExecutionReport &cb) {
-   LOG(OrderMan, Warn, "OkxExecutionAdapter::register_callback callback registered");
-   // listener.setCallback(cb);
-}
-void OkxExecutionAdapter::cancel_order(const CancelOrderMsg &msg) {
-   LOG(OrderMan, Warn, "cancel order {}", msg);
-   try {
-      LOG(OrderMan, Warn, "order cancel sent");
-   }
-   // Shut down all reactors if they exist.
-   catch (const std::exception &ex) {
-    const std::string err = ex.what();
-      handleOkException("Cacnel order", err);
-   }
-}
-} // namespace bts::orderman