SP-288 ladder crash (IndexOutOfRange ex accessing price array)

Master

src/client/spark/App.xaml.cs

@@ -115,7 +115,7 @@ namespace mbts.ui.shell
       {
          try
          {
-            var path = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData) + "\\BTS\\stunnel\\";
+            string path = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData) + "\\BTS\\stunnel\\";
             if (File.Exists(path + "config\\stunnel.conf"))
             {
                uint job_error = BTSUINativeMethods.setup_process_job_object();   
@@ -124,6 +124,15 @@ namespace mbts.ui.shell
                   kill_stunnel();
                start_stunnel(path, job_error);
             }
+            path = AppDomain.CurrentDomain.BaseDirectory + "\\..\\stunnel\\";
+            if (File.Exists(path + "config\\stunnel.conf"))
+            {
+               uint job_error = BTSUINativeMethods.setup_process_job_object();
+               //if we can't put this process and stunnel into a job, try to stop stunnel then restart
+               if (job_error != 0)
+                  kill_stunnel();
+               start_stunnel(path, job_error);
+            }
          }
          catch(Exception ex)
          {

src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs

@@ -534,8 +534,7 @@ namespace mbts.spark {
          _size_from_row(row, _price_list, _asks, _vm.security.ContractSpec);
 
       uint _volume_from_row(int row) {
-         if (_price_list != null) {
-            var price = _price_list[row];
+         if (_price_list.SafeTryGetAt(row, out var price)) {
             var vapls = _volume_container.read_new_value();
             if (vapls != null) {
                return vapls.SelectFirstOrDefault(v => MathUtils.epsilon_equals(v.Price, price), v => v.Volume);

src/client/spark_core/Collections/Extensions/ListExtensions.cs

@@ -103,6 +103,15 @@ namespace bts.collections {
          return array;
       }
 
+      public static bool SafeTryGetAt<T>(this IList<T> list, int index, out T value) {
+         if (list != null && index >= 0 && index < list.Count) {
+            value = list[index];
+            return true;
+         }
+         value = default;
+         return false;
+      }
+
       public static bool TryGetAt<T>(this IList<T> list, int index, out T value) {
          if (index >= 0 && index < list.Count) {
             value = list[index];