Merged in SP-208 (pull request #330)

SP-208 - no nullref when clearing empty discrete filter

Approved-by: Kevin Darby <kevin.darby@bluetradesys.com>

doc/user/CMakeDeps.cmake

@@ -1 +1 @@
-set(sources /home/ppinto/Dropbox/bts/spark/doc/user/build.sh;content/_index.md;content/bts_spark/Algos/_index.md;content/bts_spark/Glossary/index.md;content/bts_spark/Help/about_spark.png;content/bts_spark/Help/image39.png;content/bts_spark/Help/image58.png;content/bts_spark/Help/index.md;content/bts_spark/Launcher/image38.png;content/bts_spark/Launcher/image68.png;content/bts_spark/Launcher/index.md;content/bts_spark/Logging-In-to-the-System/image3.png;content/bts_spark/Logging-In-to-the-System/image64.png;content/bts_spark/Logging-In-to-the-System/index.md;content/bts_spark/Market/change_securities.png;content/bts_spark/Market/image11.png;content/bts_spark/Market/image14.png;content/bts_spark/Market/image20.png;content/bts_spark/Market/image21.png;content/bts_spark/Market/image23.png;content/bts_spark/Market/image24.png;content/bts_spark/Market/image34.png;content/bts_spark/Market/image49.png;content/bts_spark/Market/image53.png;content/bts_spark/Market/image66.png;content/bts_spark/Market/image69.png;content/bts_spark/Market/index.md;content/bts_spark/Market/market_view.png;content/bts_spark/Market/settings_icon.png;content/bts_spark/Market/time_and_sales.png;content/bts_spark/My-Windows/image15.png;content/bts_spark/My-Windows/image16.png;content/bts_spark/My-Windows/image37.png;content/bts_spark/My-Windows/index.md;content/bts_spark/Settings/image51.png;content/bts_spark/Settings/image9.png;content/bts_spark/Settings/index.md;content/bts_spark/Spreader/image10.png;content/bts_spark/Spreader/image13.png;content/bts_spark/Spreader/image18.png;content/bts_spark/Spreader/image19.png;content/bts_spark/Spreader/image28.png;content/bts_spark/Spreader/image29.png;content/bts_spark/Spreader/image31.png;content/bts_spark/Spreader/image35.png;content/bts_spark/Spreader/image40.png;content/bts_spark/Spreader/image43.png;content/bts_spark/Spreader/image54.png;content/bts_spark/Spreader/image55.png;content/bts_spark/Spreader/image56.png;content/bts_spark/Spreader/image6.png;content/bts_spark/Spreader/image7.png;content/bts_spark/Spreader/image70.png;content/bts_spark/Spreader/image72.png;content/bts_spark/Spreader/image8.png;content/bts_spark/Spreader/index.md;content/bts_spark/Trading/algo_studio.png;content/bts_spark/Trading/collapse_all_icon.png;content/bts_spark/Trading/cover_algo_control.png;content/bts_spark/Trading/expand_all_icon.png;content/bts_spark/Trading/image1.png;content/bts_spark/Trading/image17.png;content/bts_spark/Trading/image2.png;content/bts_spark/Trading/image25.png;content/bts_spark/Trading/image27.png;content/bts_spark/Trading/image33.png;content/bts_spark/Trading/image42.png;content/bts_spark/Trading/image44.png;content/bts_spark/Trading/image47.png;content/bts_spark/Trading/image48.png;content/bts_spark/Trading/image5.png;content/bts_spark/Trading/image50.png;content/bts_spark/Trading/image52.png;content/bts_spark/Trading/image57.png;content/bts_spark/Trading/image59.png;content/bts_spark/Trading/image60.png;content/bts_spark/Trading/image61.png;content/bts_spark/Trading/image62.png;content/bts_spark/Trading/image73.png;content/bts_spark/Trading/image74.png;content/bts_spark/Trading/index.md;content/bts_spark/Trading/join_algo_control.png;content/bts_spark/Trading/ladder.png;content/bts_spark/Trading/ladder_badges.png;content/bts_spark/Trading/ladder_main_part.png;content/bts_spark/Trading/lean_algo_control.png;content/bts_spark/Trading/mini_orderbook.png;content/bts_spark/Trading/oco_algo_control.png;content/bts_spark/Trading/offset_algo_control.png;content/bts_spark/Trading/pnl_calculation.png;content/bts_spark/Trading/pnl_window.png;content/bts_spark/Trading/recreate_icon.png;content/bts_spark/Trading/settings_icon.png;content/bts_spark/Trading/spark_menu_order_book.png;content/bts_spark/Trading/top_algo_control.png;content/bts_spark/Trading/trigger_algo_control.png;content/bts_spark/_index.md;content/release_notes/_index.md;content/system_requirements/_index.md;static/book.js;static/favicon.ico;static/image.js;templates/index.html;templates/page.html;templates/section.html;templates/shortcodes/back_button.html)
+set(sources /home/ppinto/Dropbox/bts/spark/doc/user/build.sh;content/_index.md;content/bts_spark/Glossary/_index.md;content/bts_spark/Help/_index.md;content/bts_spark/Help/about_spark.png;content/bts_spark/Help/image39.png;content/bts_spark/Help/image58.png;content/bts_spark/Launcher/_index.md;content/bts_spark/Launcher/image38.png;content/bts_spark/Launcher/image68.png;content/bts_spark/Logging-In-to-the-System/_index.md;content/bts_spark/Logging-In-to-the-System/image3.png;content/bts_spark/Logging-In-to-the-System/image64.png;content/bts_spark/Market/_index.md;content/bts_spark/Market/change_securities.png;content/bts_spark/Market/image11.png;content/bts_spark/Market/image14.png;content/bts_spark/Market/image20.png;content/bts_spark/Market/image21.png;content/bts_spark/Market/image23.png;content/bts_spark/Market/image24.png;content/bts_spark/Market/image34.png;content/bts_spark/Market/image49.png;content/bts_spark/Market/image53.png;content/bts_spark/Market/image66.png;content/bts_spark/Market/image69.png;content/bts_spark/Market/market_view.png;content/bts_spark/Market/settings_icon.png;content/bts_spark/Market/time_and_sales.png;content/bts_spark/My-Windows/_index.md;content/bts_spark/My-Windows/image15.png;content/bts_spark/My-Windows/image16.png;content/bts_spark/My-Windows/image37.png;content/bts_spark/Settings/_index.md;content/bts_spark/Settings/image51.png;content/bts_spark/Settings/image9.png;content/bts_spark/Spreader/_index.md;content/bts_spark/Spreader/image10.png;content/bts_spark/Spreader/image13.png;content/bts_spark/Spreader/image18.png;content/bts_spark/Spreader/image19.png;content/bts_spark/Spreader/image28.png;content/bts_spark/Spreader/image29.png;content/bts_spark/Spreader/image31.png;content/bts_spark/Spreader/image35.png;content/bts_spark/Spreader/image40.png;content/bts_spark/Spreader/image43.png;content/bts_spark/Spreader/image54.png;content/bts_spark/Spreader/image55.png;content/bts_spark/Spreader/image56.png;content/bts_spark/Spreader/image6.png;content/bts_spark/Spreader/image7.png;content/bts_spark/Spreader/image70.png;content/bts_spark/Spreader/image72.png;content/bts_spark/Spreader/image8.png;content/bts_spark/Trading/OrderTypes/index.md;content/bts_spark/Trading/_index.md;content/bts_spark/Trading/algo_studio.png;content/bts_spark/Trading/collapse_all_icon.png;content/bts_spark/Trading/cover_algo_control.png;content/bts_spark/Trading/expand_all_icon.png;content/bts_spark/Trading/image1.png;content/bts_spark/Trading/image17.png;content/bts_spark/Trading/image2.png;content/bts_spark/Trading/image25.png;content/bts_spark/Trading/image27.png;content/bts_spark/Trading/image33.png;content/bts_spark/Trading/image42.png;content/bts_spark/Trading/image44.png;content/bts_spark/Trading/image47.png;content/bts_spark/Trading/image48.png;content/bts_spark/Trading/image5.png;content/bts_spark/Trading/image50.png;content/bts_spark/Trading/image52.png;content/bts_spark/Trading/image57.png;content/bts_spark/Trading/image59.png;content/bts_spark/Trading/image60.png;content/bts_spark/Trading/image61.png;content/bts_spark/Trading/image62.png;content/bts_spark/Trading/image73.png;content/bts_spark/Trading/image74.png;content/bts_spark/Trading/join_algo_control.png;content/bts_spark/Trading/ladder.png;content/bts_spark/Trading/ladder_badges.png;content/bts_spark/Trading/ladder_main_part.png;content/bts_spark/Trading/lean_algo_control.png;content/bts_spark/Trading/mini_orderbook.png;content/bts_spark/Trading/oco_algo_control.png;content/bts_spark/Trading/offset_algo_control.png;content/bts_spark/Trading/pnl_calculation.png;content/bts_spark/Trading/pnl_window.png;content/bts_spark/Trading/recreate_icon.png;content/bts_spark/Trading/settings_icon.png;content/bts_spark/Trading/spark_menu_order_book.png;content/bts_spark/Trading/top_algo_control.png;content/bts_spark/Trading/trigger_algo_control.png;content/bts_spark/_index.md;content/release_notes/_index.md;content/system_requirements/_index.md;static/book.js;static/favicon.ico;static/image.js;templates/index.html;templates/page.html;templates/section.html;templates/shortcodes/back_button.html)

doc/user/content/release_notes/_index.md

@@ -4,6 +4,17 @@ weight = 3
 sort_by = "weight"
 insert_anchor_links = "right"
 +++
+## 2.8.3
+### Bug Fixes
+  - Fixed a bug that could cause an OrderBook's Security column filter to be blank
+  - Fixed a bug that could cause a UI failure when clearing a filter selection on a filtering widget
+## 2.8.2
+### Bug Fixes
+  - Added proper display factors for SOM spreads
+  - Fixed a bug that could cause a UI failure when trying to change settings in a synthetic ladder
+## 2.8.1
+### Bug fixes
+  - Fixed an error in the UI grids filtering widget
 ## 2.8.0
 ### User Visible Changes
   - Added ProRata and Scratch algos

src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs

@@ -137,7 +137,7 @@ namespace mbts.spark {
                c.PropertyChanged -= on_prop_changed;
          }
          AccountTuple? account_factory(KeyValuePair<uint, string> kv) => new AccountTuple(kv.Key, kv.Value);
-         AlgoDefinitionVM algo_factory(AlgoData data) => AlgoDefinitionVM.create(_model, data);
+         AlgoDefinitionVM algo_factory(AlgoData data) => AlgoDefinitionVM.create(_model, data, is_synthetic ? AlgoFormats.Spreader : AlgoFormats.Exchange);
       }
 
       public event Action result_changed;

src/client/spark/view/Controls/DataGridEx/Filters/VM/DiscreteValuesFilterVM.cs

@@ -110,10 +110,11 @@ namespace mbts.spark.filters {
 
       class DynamicItemsFilter<TRow, TValue, TState> : FilterVMBase<TRow, TValue, TState>, IDisposable {
          readonly IEqualityComparer<TValue> _equality_comparer;
+         readonly IComparer<TValue> _comparer;
          readonly Func<ISet<TValue>, TState> _get_state;
          readonly Func<TState, IObservable<IEnumerable<TValue>>> _load_state;
          readonly HashSet<TValue> _items_set, _selected_items_set;
-         readonly ObservableCollection<TValue> _unsorted_items;
+         readonly ObservableCollection<TValue> _items = new ObservableCollection<TValue>();
          bool _override_desired_selection;
          IDisposable _desired_items_sub, _items_sub;
 
@@ -129,7 +130,7 @@ namespace mbts.spark.filters {
             //
             _items_sub = items.OnDispatcher().Subscribe(new_items => {
                _items_set.SetItems(new_items.Concat(_selected_items_set));
-               _unsorted_items.sync_with(_items_set);
+               _sync_items();
             });
          }
  
@@ -148,7 +149,7 @@ namespace mbts.spark.filters {
                   _items_set.Remove(v);
                foreach (var v in update.added)
                   _items_set.Add(v);
-               _unsorted_items.sync_with(_items_set);
+               _sync_items();
             });
          }
 
@@ -164,11 +165,12 @@ namespace mbts.spark.filters {
             _get_state = get_state;
             _load_state = load_state;
             _equality_comparer = equality_comparer;
+            _comparer = comparer;
             _selected_items_set = new HashSet<TValue>(_equality_comparer);
             _items_set = new HashSet<TValue>(_equality_comparer);
-            _unsorted_items = new ObservableCollection<TValue>();
-            items = comparer != null ? ObservableAutoWrapper.create_sorted_wrapper(_unsorted_items, comparer) : ObservableAutoWrapper.create_read_only_wrapper(_unsorted_items);
+            items = ObservableAutoWrapper.create_read_only_wrapper(_items);
             selected_items.CollectionChanged += _on_selected_items_CollectionChanged;
+            _sync_items();
          }
 
          public IReadOnlyObservableCollection<TValue> items { get; }
@@ -238,9 +240,11 @@ namespace mbts.spark.filters {
                var copy = new HashSet<TValue>(_selected_items_set, _equality_comparer);
                _selected_items_set.SetItems(dsi);
                using (selected_items.SuspendHandler(_on_selected_items_CollectionChanged)) {
-                  foreach (var item in _selected_items_set) {
-                     if (_items_set.Add(item))
-                        _unsorted_items.Add(item);
+                  var to_add = _selected_items_set.Where(_items_set.Add);
+                  if (_comparer != null) {
+                     _items.InsertSorted(to_add, _comparer);
+                  } else {
+                     _items.AddRange(to_add);
                   }
                   selected_items.sync_with(_selected_items_set);
                }
@@ -248,6 +252,14 @@ namespace mbts.spark.filters {
                   _raise_filter_changed();
             }
          }
+
+         void _sync_items() {
+            if (_comparer != null) {
+               _items.sync_with(_items_set.Ordered(_comparer));
+            } else {
+               _items.sync_with(_items_set);
+            }
+         }
       }
 
       class TableUpdateItemsFilter<TRow, TValue, TKey, TState> : FilterVMBase<TRow, TValue, TState>, IObserver<TableUpdate<TValue, TKey>> where TKey : struct, IEquatable<TKey> {

src/client/spark/view/Controls/ListBoxEx/ListBoxEx.xaml.cs

@@ -101,7 +101,8 @@ namespace mbts.ui.controls
 					case NotifyCollectionChangedAction.Replace:
 						if (e.OldItems != null) foreach (var item in e.OldItems) _set_is_selected(item, false);
 						if (e.NewItems != null) foreach (var item in e.NewItems) _set_is_selected(item, true); break;
-					case NotifyCollectionChangedAction.Reset: foreach (var item in ItemsSource) _set_is_selected(item, false); break;
+					case NotifyCollectionChangedAction.Reset:
+                  if (ItemsSource != null) foreach (var item in ItemsSource) _set_is_selected(item, false); break;
 				}
 				_update_is_all_selected();
 			}

src/lib/CMakeDeps.cmake

@@ -1 +1 @@
-set(sources api/apicore.proto;api/apigateway.proto;api/apioptions.proto;api/core/ApiClientInterop.cpp;api/core/ApiServerInterop.cpp;api/public/ApiServer.cpp;api/public/ClientChannel.cpp;api/public/QuickbusClientChannel.cpp;api/public/ServerChannel.cpp;api/public/ServiceContext.cpp;api/service_helpers/AdminServiceUtils.cpp;api/service_helpers/AlgoServiceUtils.cpp;api/services/AdminService.proto;api/services/AlgoDefinitionService.proto;api/services/AlgoService.proto;api/services/ApiUnitTestService.proto;api/services/AuthService.proto;api/services/ErrorReportService.proto;api/services/HelloService.proto;api/services/MBOService.proto;api/services/MarginService.proto;api/services/MarketDataAuxiliaryService.proto;api/services/MarketDataRelay.proto;api/services/OrderService.proto;api/services/OutOfProcessURLListener.proto;api/services/PersistenceService.proto;api/services/PositionService.proto;api/services/ShellDiagnosticService.proto;api/services/ShellLatencyService.proto;api/services/SyntheticSecurityService.proto;api/test/ApiTests.cpp;api/test/HelloServiceServer.cpp;config/ConfigCheck.cpp;config/ConfigDownloader.cpp;config/ConfigErrorCollector.cpp;config/ConfigLog.cpp;config/ConfigPropertyEvaluator.cpp;config/ConfigValueQueue.cpp;config/ConfigurationException.cpp;config/ConfigurationState.cpp;config/PreprocessInputStream.cpp;config/config.cpp;config/defaults/MarketData.conf;config/defaults/Ports.conf;config/defaults/Symbols.conf;config/defaults/cme_reference_data.conf;config/defaults/edge.conf;config/defaults/jetfix.conf;config/defaults/keycode.conf;config/defaults/logging.conf;config/defaults/orderman_cfg.conf;config/defaults/orders_fills_cleanup.conf;config/defaults/span.conf;config/defaults/spreader.conf;config/defaults/testkeys.conf;config/defaults/threads.conf;config/defaults/toggles.conf;config/extensions/extensions.proto;config/invalid/invalid.proto;config/protos/ExchangeSimCfg.proto;config/protos/MarketData.proto;config/protos/Ports.proto;config/protos/Symbols.proto;config/protos/UI.proto;config/protos/cme_reference_data.proto;config/protos/jetfix.proto;config/protos/keycode.proto;config/protos/logging.proto;config/protos/mercury_cfg.proto;config/protos/orderman_cfg.proto;config/protos/orders_fills_cleanup.proto;config/protos/perflog_cfg.proto;config/protos/quickbus_cfg.proto;config/protos/span.proto;config/protos/spreader.proto;config/protos/system.proto;config/protos/testkeys.proto;config/protos/threads.proto;config/protos/toggles.proto;config/tests/HTTPServer.cpp;config/tests/config_ref_tests.cpp;config/tests/config_tests.cpp;config/text_format/text_format.cpp;domain_model/Security.cpp;domain_model/Security.proto;domain_model/SecurityTests.cpp;domain_model/tests/domain_tests.cpp;expression/BooleanGrammar.cpp;expression/ExpressionEvaluator.cpp;expression/ParserExceptions.cpp;expression/Value.cpp;expression/tests/expression_parser_tests.cpp;jetfix/codec/FIXArray.cpp;jetfix/common/OutFIX.cpp;jetfix/connection/AsyncReader.cpp;jetfix/connection/IConnection.cpp;jetfix/connection/SocketConnection.cpp;jetfix/gateway/CoreGateway.cpp;jetfix/gateway/JetFIXGateway.cpp;jetfix/gateway/Session.cpp;jetfix/store/FIXFileStore.cpp;jetfix/store/session_name.cpp;jetfix/tests/async_reader_tests.cpp;jetfix/tests/decoding_tests.cpp;jetfix/tests/fix_encoding_stream_tests.cpp;jetfix/tests/fix_fragment_tests.cpp;jetfix/tests/jetfix_performance_tests.cpp;jetfix/tests/sample_fix.cpp;jetfix/tests/store_tests.cpp;logging/LoggerHub.cpp;logging/Sink.cpp;logging/logging.cpp;logging/tests/logging_tests.cpp;md/Diag/MDPeriodicDumper.cpp;md/Diag/ShmDumper.cpp;md/MBOProcessor.cpp;md/MBOServiceServer.cpp;md/MDClient.cpp;md/MDConsumer.cpp;md/MDConsumerHandle.cpp;md/MDConsumerInterop.cpp;md/MDProducer.cpp;md/MDProducerHandle.cpp;md/MemorySegmentUtils.cpp;md/PlatformLoader.cpp;md/PriceSize.cpp;md/SecurityCache.cpp;md/SecurityDB.cpp;md/SecurityIDRecorder.cpp;md/SecurityOracle.cpp;md/SettlementRecorder.cpp;md/Shm/FixedSecurity.cpp;md/SyntheticSecurityService.cpp;md/cme/MDP3Utils.cpp;md/common.cpp;md/ice/ICEUtils.cpp;md/protos/co2.proto;md/relay/QueryServer.cpp;md/relay/RelayClient.cpp;md/relay/RelayRecorder.cpp;md/test/Co2ManagedTestHelper.cpp;md/test/Co2TestInstrument.cpp;md/test/mbo_tests.cpp;md/test/md2_tests.cpp;md/test/md_test_utils.cpp;md/test/synthetic_book_merge_tests.cpp;mercury/actors/IPollableActor.cpp;mercury/broker/Broker.cpp;mercury/broker/BrokerProxy.cpp;mercury/broker/ILocalBroker.cpp;mercury/broker/IRemoteBroker.cpp;mercury/common/mercury_common.cpp;mercury/events/TimerEvent.cpp;mercury/executor/Executor.cpp;mercury/topics/Topic.cpp;metrics/metrics.cpp;metrics/system_metrics.cpp;orderman/actors/AsyncFactory.cpp;orderman/actors/ExecutionGateway.cpp;orderman/actors/FillStore.cpp;orderman/actors/MDSupplementarySource.cpp;orderman/actors/OrderStore.cpp;orderman/actors/SODPosition.cpp;orderman/actors/SecuritySrc.cpp;orderman/actors/ServiceBridge.cpp;orderman/actors/order_manager/OrderBuilder.cpp;orderman/actors/order_manager/OrderMLine truncated
+set(sources api/apicore.proto;api/apigateway.proto;api/apioptions.proto;api/core/ApiClientInterop.cpp;api/core/ApiServerInterop.cpp;api/public/ApiServer.cpp;api/public/ClientChannel.cpp;api/public/QuickbusClientChannel.cpp;api/public/ServerChannel.cpp;api/public/ServiceContext.cpp;api/service_helpers/AdminServiceUtils.cpp;api/service_helpers/AlgoServiceUtils.cpp;api/services/AdminService.proto;api/services/AlgoDefinitionService.proto;api/services/AlgoService.proto;api/services/ApiUnitTestService.proto;api/services/AuthService.proto;api/services/ErrorReportService.proto;api/services/HelloService.proto;api/services/MBOService.proto;api/services/MarginService.proto;api/services/MarketDataAuxiliaryService.proto;api/services/MarketDataRelay.proto;api/services/OrderService.proto;api/services/OutOfProcessURLListener.proto;api/services/PersistenceService.proto;api/services/PositionService.proto;api/services/ShellDiagnosticService.proto;api/services/ShellLatencyService.proto;api/services/SyntheticSecurityService.proto;api/test/ApiTests.cpp;api/test/HelloServiceServer.cpp;config/ConfigCheck.cpp;config/ConfigDownloader.cpp;config/ConfigErrorCollector.cpp;config/ConfigLog.cpp;config/ConfigPropertyEvaluator.cpp;config/ConfigValueQueue.cpp;config/ConfigurationException.cpp;config/ConfigurationState.cpp;config/PreprocessInputStream.cpp;config/config.cpp;config/defaults/MarketData.conf;config/defaults/Ports.conf;config/defaults/Symbols.conf;config/defaults/cme_reference_data.conf;config/defaults/edge.conf;config/defaults/jetfix.conf;config/defaults/keycode.conf;config/defaults/logging.conf;config/defaults/orderman_cfg.conf;config/defaults/orders_fills_cleanup.conf;config/defaults/span.conf;config/defaults/spreader.conf;config/defaults/testkeys.conf;config/defaults/threads.conf;config/defaults/toggles.conf;config/extensions/extensions.proto;config/invalid/invalid.proto;config/protos/ExchangeSimCfg.proto;config/protos/MarketData.proto;config/protos/Ports.proto;config/protos/Symbols.proto;config/protos/UI.proto;config/protos/cme_reference_data.proto;config/protos/jetfix.proto;config/protos/keycode.proto;config/protos/logging.proto;config/protos/mercury_cfg.proto;config/protos/orderman_cfg.proto;config/protos/orders_fills_cleanup.proto;config/protos/perflog_cfg.proto;config/protos/quickbus_cfg.proto;config/protos/span.proto;config/protos/spreader.proto;config/protos/system.proto;config/protos/testkeys.proto;config/protos/threads.proto;config/protos/toggles.proto;config/tests/HTTPServer.cpp;config/tests/config_ref_tests.cpp;config/tests/config_tests.cpp;config/text_format/text_format.cpp;domain_model/Security.cpp;domain_model/Security.proto;domain_model/SecurityTests.cpp;domain_model/tests/domain_tests.cpp;expression/BooleanGrammar.cpp;expression/ExpressionEvaluator.cpp;expression/ParserExceptions.cpp;expression/Value.cpp;expression/tests/expression_parser_tests.cpp;jetfix/codec/FIXArray.cpp;jetfix/common/OutFIX.cpp;jetfix/connection/AsyncReader.cpp;jetfix/connection/IConnection.cpp;jetfix/connection/SocketConnection.cpp;jetfix/gateway/CoreGateway.cpp;jetfix/gateway/JetFIXGateway.cpp;jetfix/gateway/Session.cpp;jetfix/store/FIXFileStore.cpp;jetfix/store/session_name.cpp;jetfix/tests/async_reader_tests.cpp;jetfix/tests/decoding_tests.cpp;jetfix/tests/fix_encoding_stream_tests.cpp;jetfix/tests/fix_fragment_tests.cpp;jetfix/tests/jetfix_performance_tests.cpp;jetfix/tests/sample_fix.cpp;jetfix/tests/store_tests.cpp;logging/LoggerHub.cpp;logging/Sink.cpp;logging/logging.cpp;logging/tests/logging_tests.cpp;md/Diag/MDPeriodicDumper.cpp;md/Diag/ShmDumper.cpp;md/MBOProcessor.cpp;md/MBOServiceServer.cpp;md/MDClient.cpp;md/MDConsumer.cpp;md/MDConsumerHandle.cpp;md/MDConsumerInterop.cpp;md/MDProducer.cpp;md/MDProducerHandle.cpp;md/MemorySegmentUtils.cpp;md/PlatformLoader.cpp;md/PriceSize.cpp;md/SecurityCache.cpp;md/SecurityDB.cpp;md/SecurityIDRecorder.cpp;md/SecurityOracle.cpp;md/SettlementRecorder.cpp;md/Shm/FixedSecurity.cpp;md/SyntheticSecurityService.cpp;md/cme/MDP3Utils.cpp;md/common.cpp;md/ice/ICEUtils.cpp;md/protos/co2.proto;md/relay/QueryServer.cpp;md/relay/RelayClient.cpp;md/relay/RelayRecorder.cpp;md/test/Co2ManagedTestHelper.cpp;md/test/Co2TestInstrument.cpp;md/test/mbo_tests.cpp;md/test/md2_tests.cpp;md/test/md_test_utils.cpp;md/test/synthetic_book_merge_tests.cpp;mercury/actors/IPollableActor.cpp;mercury/broker/Broker.cpp;mercury/broker/BrokerProxy.cpp;mercury/broker/ILocalBroker.cpp;mercury/broker/IRemoteBroker.cpp;mercury/common/mercury_common.cpp;mercury/events/TimerEvent.cpp;mercury/executor/Executor.cpp;mercury/topics/Topic.cpp;metrics/metrics.cpp;metrics/system_metrics.cpp;orderman/actors/AsyncFactory.cpp;orderman/actors/ExecutionGateway.cpp;orderman/actors/FillStore.cpp;orderman/actors/MDSupplementarySource.cpp;orderman/actors/OrderStore.cpp;orderman/actors/SODPosition.cpp;orderman/actors/SecuritySrc.cpp;orderman/actors/ServiceBridge.cpp;orderman/actors/order_manager/OrderBuilder.cpp;orderman/actors/order_manager/OrderMLine truncated

src/lib/CMakeDeps_win.cmake

@@ -1 +1 @@
-set(sources api/apicore.proto;api/apigateway.proto;api/apioptions.proto;api/core/ApiClientInterop.cpp;api/core/ApiServerInterop.cpp;api/public/ApiServer.cpp;api/public/ClientChannel.cpp;api/public/QuickbusClientChannel.cpp;api/public/ServerChannel.cpp;api/public/ServiceContext.cpp;api/service_helpers/AdminServiceUtils.cpp;api/service_helpers/AlgoServiceUtils.cpp;api/services/AdminService.proto;api/services/AlgoDefinitionService.proto;api/services/AlgoService.proto;api/services/ApiUnitTestService.proto;api/services/AuthService.proto;api/services/ErrorReportService.proto;api/services/HelloService.proto;api/services/MBOService.proto;api/services/MarginService.proto;api/services/MarketDataAuxiliaryService.proto;api/services/MarketDataRelay.proto;api/services/OrderService.proto;api/services/OutOfProcessURLListener.proto;api/services/PersistenceService.proto;api/services/PositionService.proto;api/services/ShellDiagnosticService.proto;api/services/ShellLatencyService.proto;api/services/SyntheticSecurityService.proto;api/test/ApiTests.cpp;api/test/HelloServiceServer.cpp;config/ConfigCheck.cpp;config/ConfigDownloader.cpp;config/ConfigErrorCollector.cpp;config/ConfigLog.cpp;config/ConfigPropertyEvaluator.cpp;config/ConfigValueQueue.cpp;config/ConfigurationException.cpp;config/ConfigurationState.cpp;config/PreprocessInputStream.cpp;config/config.cpp;config/defaults/MarketData.conf;config/defaults/Ports.conf;config/defaults/Symbols.conf;config/defaults/cme_reference_data.conf;config/defaults/edge.conf;config/defaults/jetfix.conf;config/defaults/keycode.conf;config/defaults/logging.conf;config/defaults/orderman_cfg.conf;config/defaults/orders_fills_cleanup.conf;config/defaults/span.conf;config/defaults/spreader.conf;config/defaults/testkeys.conf;config/defaults/threads.conf;config/defaults/toggles.conf;config/extensions/extensions.proto;config/invalid/invalid.proto;config/protos/ExchangeSimCfg.proto;config/protos/MarketData.proto;config/protos/Ports.proto;config/protos/Symbols.proto;config/protos/UI.proto;config/protos/cme_reference_data.proto;config/protos/jetfix.proto;config/protos/keycode.proto;config/protos/logging.proto;config/protos/mercury_cfg.proto;config/protos/orderman_cfg.proto;config/protos/orders_fills_cleanup.proto;config/protos/perflog_cfg.proto;config/protos/quickbus_cfg.proto;config/protos/span.proto;config/protos/spreader.proto;config/protos/system.proto;config/protos/testkeys.proto;config/protos/threads.proto;config/protos/toggles.proto;config/tests/HTTPServer.cpp;config/tests/config_ref_tests.cpp;config/tests/config_tests.cpp;config/text_format/text_format.cpp;domain_model/Security.cpp;domain_model/Security.proto;domain_model/SecurityTests.cpp;domain_model/tests/domain_tests.cpp;expression/BooleanGrammar.cpp;expression/ExpressionEvaluator.cpp;expression/ParserExceptions.cpp;expression/Value.cpp;expression/tests/expression_parser_tests.cpp;logging/LoggerHub.cpp;logging/Sink.cpp;logging/logging.cpp;logging/tests/logging_tests.cpp;md/Diag/MDPeriodicDumper.cpp;md/Diag/ShmDumper.cpp;md/MBOProcessor.cpp;md/MBOServiceServer.cpp;md/MDClient.cpp;md/MDConsumer.cpp;md/MDConsumerHandle.cpp;md/MDConsumerInterop.cpp;md/MDProducer.cpp;md/MDProducerHandle.cpp;md/MemorySegmentUtils.cpp;md/PlatformLoader.cpp;md/PriceSize.cpp;md/SecurityCache.cpp;md/SecurityDB.cpp;md/SecurityIDRecorder.cpp;md/SecurityOracle.cpp;md/SettlementRecorder.cpp;md/Shm/FixedSecurity.cpp;md/SyntheticSecurityService.cpp;md/cme/MDP3Utils.cpp;md/common.cpp;md/ice/ICEUtils.cpp;md/protos/co2.proto;md/relay/QueryServer.cpp;md/relay/RelayClient.cpp;md/relay/RelayRecorder.cpp;md/test/Co2ManagedTestHelper.cpp;md/test/Co2TestInstrument.cpp;md/test/mbo_tests.cpp;md/test/md2_tests.cpp;md/test/md_test_utils.cpp;md/test/synthetic_book_merge_tests.cpp;os/os.cpp;os/tests/os_tests.cpp;quickbus/core/LocalNode.cpp;quickbus/core/Quickbus.cpp;quickbus/core/SubscriptionID.cpp;quickbus/core/TableID.cpp;quickbus/message_model/Update.cpp;quickbus/message_model/merge_updates.cpp;quickbus/network/QBConnection.cpp;quickbus/network/QBConnectionManager.cpp;quickbus/network/endpoint_description.cpp;quickbus/network/quickbus_msgs.proto;quickbus/pubsub/TablePublisher.cpp;quickbus/pubsub/TableSubscriber.cpp;quickbus/pubsub/tests/qb_pubsub_tests.cpp;quickbus/routing/INode.cpp;quickbus/routing/NodeID.cpp;quickbus/routing/Router.cpp;quickbus/rpc/RPCClient.cpp;quickbus/rpc/RPCServer.cpp;quickbus/rpc/RPCSessionID.cpp;quickbus/rpc/rpc_utils.cpp;quickbus/rpc/tests/qb_rpc_tests.cpp;quickbus/tests/quickbus_tests.cpp;sparkproto/SparkProtos.proto;testing/catch_test_runner.cpp;utils/AuthSessionManager.cpp;utils/AuthToken.cpp;utils/Dispatcher.cpp;utils/GrowableSPSCQueue.cpp;utils/HTTPStream.cpp;utils/PBUtils.cpp;utils/Puid.cpp;utils/SecureLogon.cpp;utils/SharedMemory.cpp;utils/Sqlite_utils.cpp;utils/Uuid.cpp;utils/crypto/CipherType.cpp;utils/crypto/CryptoInit.cpp;utils/crypto/Digest.cpp;utils/crypto/KeyCodeHelper.cpp;utils/crypto/PasswordCallback.cpp;utils/crypto/PrivateKey.cpp;utils/cryptoLine truncated
+set(sources api/apicore.proto;api/apigateway.proto;api/apioptions.proto;api/core/ApiClientInterop.cpp;api/core/ApiServerInterop.cpp;api/public/ApiServer.cpp;api/public/ClientChannel.cpp;api/public/QuickbusClientChannel.cpp;api/public/ServerChannel.cpp;api/public/ServiceContext.cpp;api/service_helpers/AdminServiceUtils.cpp;api/service_helpers/AlgoServiceUtils.cpp;api/services/AdminService.proto;api/services/AlgoDefinitionService.proto;api/services/AlgoService.proto;api/services/ApiUnitTestService.proto;api/services/AuthService.proto;api/services/ErrorReportService.proto;api/services/HelloService.proto;api/services/MBOService.proto;api/services/MarginService.proto;api/services/MarketDataAuxiliaryService.proto;api/services/MarketDataRelay.proto;api/services/OrderService.proto;api/services/OutOfProcessURLListener.proto;api/services/PersistenceService.proto;api/services/PositionService.proto;api/services/ShellDiagnosticService.proto;api/services/ShellLatencyService.proto;api/services/SyntheticSecurityService.proto;api/test/ApiTests.cpp;api/test/HelloServiceServer.cpp;config/ConfigCheck.cpp;config/ConfigDownloader.cpp;config/ConfigErrorCollector.cpp;config/ConfigLog.cpp;config/ConfigPropertyEvaluator.cpp;config/ConfigValueQueue.cpp;config/ConfigurationException.cpp;config/ConfigurationState.cpp;config/PreprocessInputStream.cpp;config/config.cpp;config/defaults/MarketData.conf;config/defaults/Ports.conf;config/defaults/Symbols.conf;config/defaults/cme_reference_data.conf;config/defaults/edge.conf;config/defaults/jetfix.conf;config/defaults/keycode.conf;config/defaults/logging.conf;config/defaults/orderman_cfg.conf;config/defaults/orders_fills_cleanup.conf;config/defaults/span.conf;config/defaults/spreader.conf;config/defaults/testkeys.conf;config/defaults/threads.conf;config/defaults/toggles.conf;config/extensions/extensions.proto;config/invalid/invalid.proto;config/protos/ExchangeSimCfg.proto;config/protos/MarketData.proto;config/protos/Ports.proto;config/protos/Symbols.proto;config/protos/UI.proto;config/protos/cme_reference_data.proto;config/protos/jetfix.proto;config/protos/keycode.proto;config/protos/logging.proto;config/protos/mercury_cfg.proto;config/protos/orderman_cfg.proto;config/protos/orders_fills_cleanup.proto;config/protos/perflog_cfg.proto;config/protos/quickbus_cfg.proto;config/protos/span.proto;config/protos/spreader.proto;config/protos/system.proto;config/protos/testkeys.proto;config/protos/threads.proto;config/protos/toggles.proto;config/tests/HTTPServer.cpp;config/tests/config_ref_tests.cpp;config/tests/config_tests.cpp;config/text_format/text_format.cpp;domain_model/Security.cpp;domain_model/Security.proto;domain_model/SecurityTests.cpp;domain_model/tests/domain_tests.cpp;expression/BooleanGrammar.cpp;expression/ExpressionEvaluator.cpp;expression/ParserExceptions.cpp;expression/Value.cpp;expression/tests/expression_parser_tests.cpp;logging/LoggerHub.cpp;logging/Sink.cpp;logging/logging.cpp;logging/tests/logging_tests.cpp;md/Diag/MDPeriodicDumper.cpp;md/Diag/ShmDumper.cpp;md/MBOProcessor.cpp;md/MBOServiceServer.cpp;md/MDClient.cpp;md/MDConsumer.cpp;md/MDConsumerHandle.cpp;md/MDConsumerInterop.cpp;md/MDProducer.cpp;md/MDProducerHandle.cpp;md/MemorySegmentUtils.cpp;md/PlatformLoader.cpp;md/PriceSize.cpp;md/SecurityCache.cpp;md/SecurityDB.cpp;md/SecurityIDRecorder.cpp;md/SecurityMapper.cpp;md/SecurityOracle.cpp;md/SettlementRecorder.cpp;md/Shm/FixedSecurity.cpp;md/SyntheticSecurityService.cpp;md/cme/MDP3Utils.cpp;md/common.cpp;md/ice/ICEUtils.cpp;md/protos/co2.proto;md/relay/QueryServer.cpp;md/relay/RelayClient.cpp;md/relay/RelayRecorder.cpp;md/test/Co2ManagedTestHelper.cpp;md/test/Co2TestInstrument.cpp;md/test/mbo_tests.cpp;md/test/md2_tests.cpp;md/test/md_test_utils.cpp;md/test/synthetic_book_merge_tests.cpp;os/os.cpp;os/tests/os_tests.cpp;quickbus/core/LocalNode.cpp;quickbus/core/Quickbus.cpp;quickbus/core/SubscriptionID.cpp;quickbus/core/TableID.cpp;quickbus/message_model/Update.cpp;quickbus/message_model/merge_updates.cpp;quickbus/network/QBConnection.cpp;quickbus/network/QBConnectionManager.cpp;quickbus/network/endpoint_description.cpp;quickbus/network/quickbus_msgs.proto;quickbus/pubsub/TablePublisher.cpp;quickbus/pubsub/TableSubscriber.cpp;quickbus/pubsub/tests/qb_pubsub_tests.cpp;quickbus/routing/INode.cpp;quickbus/routing/NodeID.cpp;quickbus/routing/Router.cpp;quickbus/rpc/RPCClient.cpp;quickbus/rpc/RPCServer.cpp;quickbus/rpc/RPCSessionID.cpp;quickbus/rpc/rpc_utils.cpp;quickbus/rpc/tests/qb_rpc_tests.cpp;quickbus/tests/quickbus_tests.cpp;sparkproto/SparkProtos.proto;testing/catch_test_runner.cpp;utils/AuthSessionManager.cpp;utils/AuthToken.cpp;utils/Dispatcher.cpp;utils/GrowableSPSCQueue.cpp;utils/HTTPStream.cpp;utils/PBUtils.cpp;utils/Puid.cpp;utils/SecureLogon.cpp;utils/SharedMemory.cpp;utils/Sqlite_utils.cpp;utils/Uuid.cpp;utils/crypto/CipherType.cpp;utils/crypto/CryptoInit.cpp;utils/crypto/Digest.cpp;utils/crypto/KeyCodeHelper.cpp;utils/crypto/PasswordCallback.cpp;utils/crypto/PrivaLine truncated

src/lib/config/defaults/MarketData.conf

@@ -94,3 +94,14 @@ MDBootDelayWindow {
         }
     }
 }
+
+DisplayFactorOverride {
+    value {
+        override {
+            symbol: "SOM"
+            exchange: "GLBX"
+            type: "SPREAD"
+            price_multiplier: 1
+        }
+    }
+}

src/lib/config/protos/MarketData.proto

@@ -216,3 +216,13 @@ message CMETradingSchedule {
 message SecurityExpirationCutoff {
   optional uint32 max_days_after_expiration =1 [default = 7];
 }
+
+message DisplayFactorOverride {
+   message Override {
+      required string symbol = 1;
+      required string exchange = 2;
+      optional string type = 3;
+      optional double price_multiplier = 10;
+   }
+   repeated Override override = 1;
+}

src/lib/md/MDProducer.cpp

@@ -16,12 +16,12 @@ namespace md {
 // Owns shared memory for a single symbol+type
 class MDProducerImpl {
 public:
-   MDProducerImpl(const string& symbol, SecurityType type, Venue exchange, Platform platform, bool shared) :
+   MDProducerImpl(const string& symbol, SecurityType type, Venue exchange, Platform platform, MDProducerFlags flags) :
       _symbol(symbol),
       _type(type),
       _exchange(exchange),
-      _hot(hot_segment_name(symbol, type, exchange, platform), 1024, 1024, shared),
-      _cold(cold_segment_name(symbol, type, exchange, platform), 8192, 2048, shared),
+      _hot(hot_segment_name(symbol, type, exchange, platform), 1024, 1024, flags & MDProducerFlags::Shared),
+      _cold(cold_segment_name(symbol, type, exchange, platform), 8192, 2048, flags & MDProducerFlags::Shared),
       _trades(_cold.header().trade_buffer, BTS_ARRAYSIZE(_cold.header().trade_buffer), true),
       _rfqs(_cold.header().rfq_buffer, BTS_ARRAYSIZE(_cold.header().rfq_buffer), true)
       {
@@ -33,7 +33,7 @@ public:
          // static_assert(sizeof(HotEntry) <= 32,"HotEntry should be less than 32 bytes");
       }
  
-   MDProducerHandle add_security(const FixedSecurity& security) {
+   MDProducerHandle add_security(const FixedSecurity& security, SecurityMapper& smapper) {
       void* h_entry = nullptr;
       if (has_depth()) {
          h_entry = new (_hot.add(sizeof(HotDepthEntry))) HotDepthEntry();
@@ -45,6 +45,7 @@ public:
       // Calculating the size for the variable sized entries is tricky
       ColdEntry* c_entry = new (_cold.add(ColdEntry::fixed_size() + security.size)) ColdEntry(security.size);
       memcpy(&c_entry->security, &security, security.size);
+      smapper.apply(c_entry->security);
 
       MDProducerHandle handle(_cold.header(), _hot.header(), *c_entry, h_entry, MDProducerChannel(*this));
 
@@ -102,27 +103,30 @@ private:
 // MDProducer
 //
 
-MDProducer::MDProducer(Platform platform, bool shared) :
+MDProducer::MDProducer(Platform platform, MDProducerFlags flags) :
    _mutex(new std::mutex()),
    _producers(),
    _id_recorder(),
    _platform(platform),
-   _shared(shared)
+   _flags(flags),
+   _smapper(flags & MDProducerFlags::SecurityMapper)
 { }
 #ifndef WIN32
-MDProducer::MDProducer(Platform platform, SecurityIDRecorder recorder, bool shared) :
+MDProducer::MDProducer(Platform platform, SecurityIDRecorder recorder, MDProducerFlags flags) :
    _mutex(new std::mutex()),
    _producers(),
    _id_recorder(std::make_unique<SecurityIDRecorder>(recorder)),
    _platform(platform),
-   _shared(shared)
+   _flags(flags),
+   _smapper(flags & MDProducerFlags::SecurityMapper)
 { }
 #endif
 MDProducer::MDProducer(MDProducer&& other) :
    _mutex(std::move(other._mutex)),
    _producers(std::move(other._producers)),
    _platform(other._platform),
-   _shared(other._shared)
+   _flags(other._flags),
+   _smapper(_flags & MDProducerFlags::SecurityMapper)
 {}
 
 MDProducer::~MDProducer() {}
@@ -141,10 +145,10 @@ MDProducerImpl& MDProducer::get_producer(const char* symbol, SecurityType type,
    unique_ptr<MDProducerImpl> newp;
    if (type == api::SECURITYTYPE_SYNTHETIC) {
       // synthetics are special. We don't want to allocate a separate section for each one so we put them all in one
-      newp.reset(new MDProducerImpl(SYNTHETIC_SYMBOL, api::SECURITYTYPE_SYNTHETIC, Venue::VENUE_BTS, _platform, _shared));
+      newp.reset(new MDProducerImpl(SYNTHETIC_SYMBOL, api::SECURITYTYPE_SYNTHETIC, Venue::VENUE_BTS, _platform, _flags));
    }
    else {
-      newp.reset(new MDProducerImpl(symbol, type, exchange, _platform, _shared));
+      newp.reset(new MDProducerImpl(symbol, type, exchange, _platform, _flags));
    }
    _producers.push_back(move(newp));
    return *_producers.back();
@@ -155,7 +159,7 @@ MDProducerHandle MDProducer::add_security(const FixedSecurity& security) {
    bts_assert(security.size >= sizeof(FixedSecurity));
    std::lock_guard<std::mutex> lock(*_mutex);
    auto& impl = get_producer(security.symbol(), security.type, security.exchange);
-   auto result = impl.add_security(security);
+   auto result = impl.add_security(security, _smapper);
    if (security.key != invalid_security_key) { result.set_key(security.key); }
    else if(_id_recorder) {
       _id_recorder->ensure_key(result);

src/lib/md/MDProducer.h

@@ -7,6 +7,7 @@
 #include "MDProducerHandle.h"
 #include "MDProducerChannel.h"
 #include "Shm/FixedSecurity.h"
+#include "SecurityMapper.h"
 #include <vector>
 #include <memory>
 #include <mutex>
@@ -17,11 +18,23 @@ namespace md {
 class MDProducerImpl;
 class SecurityIDRecorder;
 
+enum class MDProducerFlags {
+   None           = 0x0,
+   Shared         = 0x1,
+   SecurityMapper = 0x2,
+};
+
+constexpr MDProducerFlags operator+(MDProducerFlags a, MDProducerFlags b) { return (MDProducerFlags)((uint32_t)a | (uint32_t)b); }
+constexpr MDProducerFlags operator-(MDProducerFlags a, MDProducerFlags b) { return (MDProducerFlags)((uint32_t)a | (uint32_t)b); }
+constexpr bool operator&(const MDProducerFlags a, const MDProducerFlags b) { return ((uint32_t)a & (uint32_t)b) == (uint32_t)b; }
+
+constexpr MDProducerFlags DefaultMDProducerFlags = MDProducerFlags::Shared + MDProducerFlags::SecurityMapper;
+
 class BTS_EXPORT MDProducer
 {
 public:
-   MDProducer(Platform platform, bool shared=true);
-   MDProducer(Platform platform, SecurityIDRecorder recorder, bool shared=true);
+   MDProducer(Platform platform, MDProducerFlags flags=DefaultMDProducerFlags);
+   MDProducer(Platform platform, SecurityIDRecorder recorder, MDProducerFlags flags=DefaultMDProducerFlags);
    MDProducer(MDProducer&& other);
    ~MDProducer();
 
@@ -45,7 +58,8 @@ private:
    std::vector<std::unique_ptr<MDProducerImpl>> _producers;
    std::unique_ptr<SecurityIDRecorder> _id_recorder;
    Platform _platform;
-   bool _shared;
+   MDProducerFlags _flags;
+   SecurityMapper _smapper;
 };
 
 

src/lib/md/SecurityMapper.cpp

@@ -0,0 +1,72 @@
+#include "SecurityMapper.h" 
+#include "UserSymbol.h"
+#include "PriceSize.h"
+#include "lib/config/config.h"
+#include "lib/config/protos/MarketData.pb.h"
+#include "lib/domain_model/Security.h"
+#include "lib/utils/parse_enum.h"
+#ifndef _WIN32
+#include "google/btree/btree_map.h"
+
+namespace bts { 
+namespace md { 
+struct DisplayFactorMapper : public ISecurityMapper 
+{
+   btree::btree_map<UserSymbol, int> _mapped;
+   DisplayFactorMapper() : _mapped() {
+      for (const auto& ov : config::get<DisplayFactorOverride>().override()) {
+         if (ov.has_price_multiplier()) {
+            auto venue = parse_enum<api::Venue>(ov.exchange(), "VENUE", api::Venue_Parse);
+            bts_assert_msg(venue, fmt::format("Invalid venue `{}`", ov.exchange()));
+            auto type = parse_enum<SecurityType>(ov.type(), "SECURITYTYPE", api::SecurityType_Parse);
+
+            if (type) {
+               _mapped.insert(
+                  std::make_pair(
+                     UserSymbol { uppercase_copy(ov.symbol()), *venue, *type }, 
+                     -to_exponent(ov.price_multiplier())));
+            }
+            else {
+               for (auto t : { 
+                     SecurityType::SECURITYTYPE_FUTURE, 
+                     SecurityType::SECURITYTYPE_SPREAD, 
+                     SecurityType::SECURITYTYPE_OPTION }) {
+                  _mapped.insert(
+                     std::make_pair(
+                        UserSymbol { uppercase_copy(ov.symbol()), *venue, t }, 
+                        -to_exponent(ov.price_multiplier())));
+               }
+            }
+         }
+      }
+   }
+
+   void apply(FixedSecurity& f) const override {
+      UserSymbol key { f.symbol(), f.exchange, f.type };
+      auto iter = _mapped.find(key);
+      if (iter != _mapped.end()) {
+         f.display_factor = iter->second;
+      }
+   }
+};
+
+SecurityMapper::SecurityMapper(bool enabled): _impl() { 
+   if (enabled) {
+      _impl.push_back(std::make_unique<DisplayFactorMapper>());
+      // Register more mappers HERE
+   }
+}
+
+#else
+namespace bts { 
+namespace md { 
+SecurityMapper::SecurityMapper(bool): _impl() {}
+#endif
+
+SecurityMapper::~SecurityMapper() { }
+void SecurityMapper::apply(FixedSecurity& security) {
+   for (const auto& m : _impl) {
+      m->apply(security);
+   }
+}
+}} //namespace 

src/lib/md/SecurityMapper.h

@@ -0,0 +1,23 @@
+#pragma once 
+#include "Shm/FixedSecurity.h"
+#include <memory>
+#include <vector>
+
+namespace bts { 
+namespace md { 
+
+struct ISecurityMapper {
+   virtual void apply(FixedSecurity&) const = 0;
+};
+
+class SecurityMapper {
+   std::vector<std::unique_ptr<ISecurityMapper>> _impl;
+   public:
+   SecurityMapper(bool enabled);
+   ~SecurityMapper();
+   // apply various mappings to the security
+   void apply(FixedSecurity&);
+};
+
+
+}} //namespace 

src/lib/md/Shm/FixedSecurity.cpp

@@ -140,7 +140,7 @@ std::string security_descriptor(const api::Security& security) {
    return result.str();
 }
 
-void get_contract_spec(const FixedSecurity& source, api::ContractSpecification& spec) {
+void get_contract_spec(const FixedSecurity& source, /*out*/ api::ContractSpecification& spec) {
    spec.set_price_break(source.price_break);
    spec.set_low_tick(source.low_tick);
    spec.set_high_tick(source.high_tick);

src/lib/md/relay/RelayClient.cpp

@@ -100,7 +100,9 @@ public:
    MDProducer& ensure_producer(Platform platform) {
       auto find_result = _producers.find(platform);
       if (find_result == _producers.end()) {
-         auto result = _producers.insert(make_pair(platform, MDProducer(platform, _shared)));
+         // relay never wants to enable SecurityMapper. Securities should always match the relay source.
+         auto flags = _shared ? MDProducerFlags::Shared : MDProducerFlags::None;
+         auto result = _producers.insert(make_pair(platform, MDProducer(platform, flags)));
          if (result.second) {
             return result.first->second;
          }

src/lib/md/test/Co2ManagedTestHelper.cpp

@@ -120,7 +120,7 @@ extern "C" BTS_EXPORT TestProducer* co2_produce_test_md() {
       "   }"
       "}");
    auto* tp = new TestProducer();
-   tp->md = std::make_shared<MDProducer>(PLATFORM_SIM, false);
+   tp->md = std::make_shared<MDProducer>(PLATFORM_SIM, MDProducerFlags::None);
    tp->handles = create_test_securities(*(tp->md));
    auto& producers = tp->handles;
    assign_ids(producers.begin(), producers.end());

src/lib/utils/optional.h

@@ -0,0 +1,56 @@
+#pragma once
+//  An incomplete version of std::optional which should work well enough on Windows until it catch up
+#ifdef _WIN32
+#include <exception>
+namespace std {
+   class bad_optional_access : exception { };
+
+   template <class T>
+   class optional {
+      bool _has_value;
+      union {
+         T _value;
+         int _unused;
+      };
+   public:
+      optional(const T& value) : _has_value(true), _value(value) { }
+      optional(T&& value) : _has_value(true), _value(value) { }
+      optional() : _has_value(false)
+      ~optional() { reset(); }
+      bool has_value() const { return _has_value; }
+      operator bool() { return b.has_value(); }
+      T& operator *() { 
+         if (has_value()) {
+            return _value;
+         }
+         else throw std::bad_optional_access();
+      }
+      const T& operator*() const { return **this; }
+      T& operator->() { return **this; }
+      const T& operator->() const { return **this; }
+      bool operator==(const std::optional<T>& other)  const {
+         if (!_has_value && !other.has_value()) return true;
+         return _has_value == other._has_value && _value == other.value();
+      }
+      bool operator!=(const std::optional<T>& other) const { return !(*this == other); }
+      T& value() { return **this; }
+      const T& value() const { return **this; }
+      T value_or(T default_value) {
+         if (has_value()) return _value;
+         else return default_value;
+      }
+      void reset() { 
+         if (has_value()) {
+            _value.~T();
+            _has_value = false;
+         }
+      }
+      // This class is incomplete. Add methods as necessary
+   };
+
+   template <class T>
+   constexpr optional<T> nullopt = {};
+}
+#else
+#include <optional>
+#endif

src/lib/utils/parse_enum.h

@@ -0,0 +1,27 @@
+#pragma once
+
+#include <string>
+#include "lib/utils/optional.h"
+namespace bts {
+
+   inline std::string uppercase_copy(const std::string& cs) {
+      std::string s = cs;
+      std::transform(s.begin(), s.end(), s.begin(), ::toupper);
+      return s;
+   }
+
+   template <class T, class T2>
+   std::optional<T> parse_enum(const std::string& value, const std::string& prefix, T2 parse) {
+      auto temp = value;
+      T result;
+      if (temp.find(prefix) == std::string::npos) {
+         temp = prefix + "_" + temp;
+      }
+      if(parse(temp, &result)) {
+         return {result};
+      }
+      else {
+         return std::nullopt;
+      }
+   }
+}

src/server/sparkd/md/run_md.cpp

@@ -16,6 +16,7 @@
 #include "lib/md/SecurityDB.h"
 #include "server/sparkd/exchange_sim/ExchangeSim.h"
 #include "lib/utils/thread_manager.h"
+#include "lib/utils/parse_enum.h"
 
 
 #include <boost/filesystem.hpp>
@@ -169,16 +170,14 @@ string& uppercase(string& s) {
    return s;
 }
 template <class T, class T2>
-bool parse_enum(const string& value, const string& prefix, T2 parse, T default_value, T* presult) {
-   string temp = value;
-   if (temp.find(prefix) == string::npos) {
-      temp = prefix + "_" + temp;
-   }
-   if(parse(temp, presult)) {
+bool parse_enum(const string& value, const string& prefix, T2 parse, T default_value, T* result) {
+   auto opt = ::bts::parse_enum<T>(value, prefix, parse);
+   if (opt) {
+      *result = opt.value();
       return true;
    }
    else {
-      *presult = default_value;
+      *result = default_value;
       return false;
    }
 }
@@ -208,13 +207,14 @@ struct MDArgs {
 MDArgs parse_md_args(const vector<string>& args) {
    using namespace api;
    using namespace co2;
-   auto venue = VENUE_UNSET; // Default to glbx. If you change this change below (used) also
+   auto venue = VENUE_UNSET;
    auto platform = PLATFORM_UNSET;
    auto type = SECURITYTYPE_UNSET;
    bool hot = false;
    long number = 0;
    std::string symbol;
    for (auto str : args) {
+      // Iterate through each argument and see if it parses to one of these enums
       uppercase(str);
       bool used = 
          (venue == VENUE_UNSET && parse_enum(str, "VENUE", Venue_Parse, venue, &venue)) ||

tools/linux_control/build_in_docker.sh

@@ -2,6 +2,6 @@
 if [ -f /.dockerenv ]; then
     ninja
 else
-    cid=`docker ps | grep bluetradingsystems/linux_docker | awk '{print $1}'`
+    cid=`docker ps | grep -P "emacs_ide|bluetradingsystems/linux_docker" | awk '{print $1}'`
     docker exec $cid /bin/bash -c "cd build/clang_debug/ && ninja"
 fi