Bugs (fixed):
* Grid settings dialogs crash when multiple are opened on diff threads
Cause: Brushes (and all Freezables) that haven't been frozen throw an ex when
any Dependency Properties are accessed from a thread that isn't associated
with their Dispatcher (i.e., the thread on which they were created).
Clean up the OrderBookView's VisualState's a bit in the process. Set each
item's visibility to 'Collapsed' by default, and flip to 'Visible' in the
VisualStates
Bugs (fixed):
* OrderBook ladder doesn't show orders
* OrderBook ladder doesn't allow user to scroll beyond initial price range
Cause: Both bugs occur because the LadderVMContainer doesn't detect LadderVM
instance changes unless LadderVM.security has changed
Once the async price-range-shift op is completed
Bugs (fixed):
* Can't scroll beyond initial price range in orderbook ladder
Cause: The LadderGridHost's price-range-shift 'busy' flag gets stuck to false
'Lock(this)' is generally bad practice. It's better to use an explicitly named
var that is minimally accessible to outside callers to reduce risk of deadlocks.
* Move Anonymous/FinalizableDisposable to own file
* Rename DisposableCombo -> ImmutableDisposable and move it to its own file
* Clean up IDisposable utils impl, but keep changes to calling code minimial
The 'SubscribeClosed' call should be executed immediately, and the returned
IDisposable disposed when 'login_hooks' is disposed (prior to this commit, it
wasn't calling 'SubscribeClosed' until login_hooks was disposed)
Bugs (fixed):
* [preemptive] SelectorWrapper.IsReadOnly is wrong
Details: The fix is considered 'preemptive' because this prop is almost
certainly not referenced. Nevertheless, the impl ought to be correct.
Bugs (fixed):
* Window size isn't restored if window has multiple tabs
Cause: The typo flips the bool arg that indicates whether or not a window
should be measured and fit to size (as happens when a window is opened for
the first time)
Bugs (fixed):
* Can't reopen Fills windows via undo/redo in the BookMarks module
Details:
* Only applies to Fills windows closed via the tab-close 'x' button (not
the window-close 'x' button)
* Doesn't cause a crash, nor exhibit any side effects (aside from breaking
undo/redo)
Cause:
* ISlow/SharedWindows (i.e., shell windows that run on bg threads) are
disposed before the ISettingsCollector retrieves their state via
'IShellWindow.SaveState'. The FillsWindow sets its _vm member to null
when it is disposed, leading to a null-ref ex in its SaveState getter.
This ex is caught (synchronously) and logged as an error, which explains
the lack of side effects.