Commit Graph
13402 Commits
Author SHA1 Message Date
Taha dee32dead4 Fixing implied vols for SPX (market data was getting divide dby the fwd) 2024-10-03 17:46:51 +05:00
John Colvin b2e022505f fix build: Add ".list" to SymbolLists config
For new exchanges, TAIFEX and CBOE
2024-10-03 17:46:51 +05:00
John Colvin ac9b3ec365 fix (build): Add break statement to new venue switch cases
Namely, TAIFEX and CBOE
2024-10-03 17:46:51 +05:00
John Colvin ed89da7f38 fix: Preserve vs exp sec type (Option) when computing implied vol
Because the exp keys in the data map have sec type Option.
2024-10-03 17:46:51 +05:00
John Colvin a334d9be88 ui: Highlight launcher buttons when selected
Namely, the expandable menu buttons in Analytics shell module
2024-10-03 17:46:51 +05:00
John Colvin aee56569d1 Replace trivial refs to ThreadedBlackboard w/ IBus 2024-10-03 17:46:51 +05:00
John Colvin 7fdd3f6b1b fix: Move accounts subscription to dispatcher thread
We update a collection that is bound to the view in the callback (mutation
ops throw if performed on a different thread).
2024-10-03 17:46:51 +05:00
John Colvin 3e1949d94f fix: Check 'HasTimestamp' before accessing prop in man fill row
Pending adds (i.e., unpersisted new rows) don't have timestamps.
In such cases, the 'Timestamp' getter throws an exception.
2024-10-03 17:46:51 +05:00
John Colvin 4cb3dbc313 Cache/index options for faster lookups in SystemContractData 2024-10-03 17:46:51 +05:00
John Colvin 0268bd476f fix: Include venue w/ symbol when publishing interp greeks 2024-10-03 17:46:51 +05:00
John Colvin 2511b0d966 Fix typo in comment 2024-10-03 17:46:50 +05:00
John Colvin 92456649df fix: SelectorList.RemoveAt doesn't need 'convert_back' delegate
So don't throw an exception if it is null.
2024-10-03 17:46:50 +05:00
John Colvin ec32078dd5 fix: Don't assume venue is in spread def string
Pass it as an argument to the parse fn. This should be fine for now, but
obviously a singular venue param won't work for cross exchange spreads.
2024-10-03 17:46:50 +05:00
John Colvin 6bcce832ac improvement: Move system contracts sub off of dispatcher thread
Also add 200ms throttle. Contracts shouldn't change that often, so we don't need
lightening speed here. Furthermore, such changes may trigger expensive cpu ops.

Note: this change also replaces refs to ThreadedBlackboard w/ IBus (the
former is somewhat tethered to the dispatcher thread, particularly by
its timer_callback).
2024-10-03 17:46:50 +05:00
John Colvin 85529b2232 fix: Pass symbol/venue from vs usage cfg to AnalyticsService proto 2024-10-03 17:46:50 +05:00
John Colvin c3cb8995bf cleanup: Remove unused code 2024-10-03 17:46:50 +05:00
John Colvin ab2f0f975e refactor: Index vol and theos data by symbol/venue tuple
Rather than just symbol, to avoid conflicts when the same symbol exists
at multiple exchanges
2024-10-03 17:46:50 +05:00
John Colvin 2e133ea182 cleanup: Remove redundant type VolSurfaceSymbolStructure
There is an identical type (in terms of prop types and corresponding proto indices)
called VolSurfaceSymbolRelationship that is used in more places.
2024-10-03 17:46:50 +05:00
John Colvin 30615f3429 Move nested vm classes into own files
VolSurfaceSettingsEditor has too much code (still). It is hard to
navigate.
2024-10-03 17:46:50 +05:00
John Colvin 61371804a2 Simplify driver symbol structure in vs settings vm
The code was confusing and difficult to follow.
2024-10-03 17:46:50 +05:00
John Colvin 02d82e39bc fix: Raise prop changed event when is_selected changes 2024-10-03 17:46:50 +05:00
John Colvin 50188e6688 Add venue to vs calc fns 2024-10-03 17:46:50 +05:00
John Colvin 5137785f7f fix: Provide venue param w/ symbol when computing fut slide 2024-10-03 17:46:50 +05:00
John Colvin def021612c diag: Log added/removed exps when syncing vs input w/ system exps
This shouldn't happen often, but if it does, we should know about it.

PS: We recently fixed a bug caused by inequalities between
VolSurfaceExpirations in vs input, and in SystemContractData. User
inputs to the vs grid would be immediately reverted, as the exps
associated with the inputs were not found in the SystemContractData.
This bug would have been easier to track down with this logging in
place.
2024-10-03 17:46:50 +05:00
John Colvin 217c5be131 Add venue to VolSurface(DisplayGrid)Expiration
So we can handle symbol/exp date conflicts for securities that differ
only by venue (exchange)
2024-10-03 17:46:50 +05:00
John Colvin a75441cd07 Clean up VolSurfaceExpiration
* Enable nullable lang feat
* Use file-scoped namespace
* Sort members
* Include sec type in Compare impl
2024-10-03 17:46:50 +05:00
John Colvin 78eb096d6f Add null check in SelectorList ctr 2024-10-03 17:46:50 +05:00
John Colvin 2b66f46db1 cleanup: Remove unused code 2024-10-03 17:46:50 +05:00
John Colvin ae3029d9ed refactor: Replace ThreadedBlackboard w/ IBus
In SingleVolSurfaceCommittedOutputRetriever
2024-10-03 17:46:50 +05:00
John Colvin d4a0603933 Clean up VolSurfaceTimeParameters
* Enable nullable lang feat
* Use file-scoped namespace
* Implement ICloneable
2024-10-03 17:46:50 +05:00
John Colvin db6e96cf00 cleanup: Remove unnecessary ternary op 2024-10-03 17:46:50 +05:00
John Colvin 371db4afd2 fix: Actually use (sec) type arg in to_security_expiration 2024-10-03 17:46:50 +05:00
John Colvin 08484a0954 fix: Check security_type in vs exp Equals impl 2024-10-03 17:46:50 +05:00
John Colvin 39db44ed63 fix: Maintain sec type when converting SecurityExpiration to vs exp
Avoids data loss
2024-10-03 17:46:50 +05:00
John Colvin b4dca8e23f refactor: Get rid of sec type 'Option' default (magic const)
Better to be explict
2024-10-03 17:46:50 +05:00
John Colvin b4bf06d17a Fix selection binding issues in vs settings editor
This specifically addresses issues in the driver symbol grids.
Unfortunately, we can't bind directly to ComboCheckBox.SelectedItems
because the view is contained in TabControl. When the selected tab
changes, the previously selected tab clears its ItemsSource (and
consequently the SelectedItems) as a side effect of being unloaded.
2024-10-03 17:46:50 +05:00
John Colvin 8c17705f02 refactor: Enable nullable (ref types) in ImmutableListExtensions 2024-10-03 17:46:50 +05:00
John Colvin 551f26e5f3 Fix typo in namespace bts.collection -> bts.collections 2024-10-03 17:46:50 +05:00
John Colvin f4adf35e49 fix: Use ComboCheckBoxItem.IsSelectedProperty
Instead of Selector.IsSelectedProperty. Unlike ComboBoxItem, ComboCheckItem's
IsSelectedProperty isn't linked to Selector.IsSelectedProperty.
2024-10-03 17:46:50 +05:00
John Colvin 90128863d9 Add currency column to mview 2024-10-03 17:46:50 +05:00
John Colvin 300831c97a fix: Use SetCurrentValue instead of SetValue
So we propagate values to/from the binding data source,
rather than overwrite the data source itself.
2024-10-03 17:46:50 +05:00
John Colvin f3f6a82d9a Add venue, sec type dropdown filters to exp params ui 2024-10-03 17:46:50 +05:00
John Colvin 7c8a41b2b7 fix: Add null check in ComboCheckBox.SelectedItemsCollectionChanged 2024-10-03 17:46:50 +05:00
John Colvin 408114c1f6 fix: Disconnect old INotifyCollectionChanged source when dp changes 2024-10-03 17:46:50 +05:00
John Colvin 5c9be0bfb9 fix: Index opt/fut exps by venue in vs analytics 2024-10-03 17:46:50 +05:00
John Colvin c0f970ab89 fix: Support multiple exchanges in exp params view/vm 2024-10-03 17:46:50 +05:00
John Colvin 25e1804286 cleanup: Remove unused 'option_symbol' param from compute_atm_data 2024-10-03 17:46:50 +05:00
John Colvin 3c84dc48f6 fix: Filter by exch when getting atm data for sheets
This is necessary now that we support exchanges with overlapping securities
2024-10-03 17:46:50 +05:00
John Colvin 9ae20f0c4d fix: Remove sec id prop from SecurityExpiration
This class isn't designed to represent a particular contract; it's
basically a key to get option theos.
2024-10-03 17:46:50 +05:00
John Colvin e8a72e7bd9 refactor: Add 'onDispatcher' param to 'ThreadedBlackboard.subscribe'
This will allow us to gradually move subscriptions off of the dispatcher
(render) thread. When the render thread is pegged, the ui is laggy and
unresponsive. The new param defaults to true, so it won't change
anything until we explicitly set it to false in 'subscribe' calls.
2024-10-03 17:46:50 +05:00