John Colvin
d11fd23cb0
refactor: Drop "_" suffix in private vars (cpp)
...
It just looks ugly, and unnecessary with modern tooling. Plus it's ugly.
2025-04-29 19:35:15 +00:00
John Colvin
8499ac0dfb
diag: Clean up structured logging in binance order store
2025-04-29 19:35:15 +00:00
John Colvin
f4afe348e6
fix: Update timestamps in binance order store when orders change
2025-04-29 19:35:15 +00:00
John Colvin
096424b60b
refactor: Use WebsocketClient fn run_in_background in binance gws
2025-04-29 19:35:15 +00:00
John Colvin
b4f5e66466
fix: Set okx perp exp to year 2100
...
Because the year 3000 is too big for signed int64
nanosecond timestamp
2025-04-29 19:35:15 +00:00
John Colvin
69a0bcc9cd
fix: Request binance fut md on ccapi dispatcher thread
2025-04-29 19:32:21 +00:00
John Colvin
d72ebdf421
perf: Send Binance Usds Futs md rest reqs on background thread
2025-04-29 19:32:21 +00:00
John Colvin
8e93856767
fix: Send exchangeInfo req via our HttpClient instead of ccapi
...
For binance usds futs (we already did this for spots)
Bugs (fixed):
* We get a boost beast exception about the read limit being exceeded
when requesting securities from Binance prod url (testnet works).
2025-04-29 19:32:21 +00:00
John Colvin
19dae6cd34
fix build (cpp release): Don't return reference to local var
2025-04-29 19:32:21 +00:00
John Colvin
24f42550dd
fix build (cpp release): Explicitly cast int64 -> uint64
2025-04-29 19:32:21 +00:00
John Colvin
c2150ae450
refactor: Move BinanceUsdsFuturesFilterTuple fns to cpp file
2025-04-29 19:32:21 +00:00
John Colvin
40dbfaa068
improvement: Support both key types in binance spots gw
...
Namely, ED25519 and HMAC-SHA256. Only the former can be used
to login over websocket, which eliminates the need to sign requests
after that.
2025-04-29 19:32:21 +00:00
John Colvin
3756a8a8b7
Add api key type enum to binance exe gateway config
...
ED25519 keys offer performance benefits over the HMAC-SHA256
keys when using the websocket api, as you can log in on the websocket
connection to avoid signing each request.
2025-04-29 19:32:21 +00:00
John Colvin
46c8dcb18f
fix: Add binance spot order newOrderResp type to json/query params
2025-04-29 19:32:21 +00:00
John Colvin
024480f32e
improvement: Send binance usds fut orders via websocket api
...
Unlike the previous implementation, which sent REST requests, this won't
block the dispatch thread waiting for a response.
2025-04-29 19:32:21 +00:00
John Colvin
ba525372bb
cleanup: Move a few types from orderman_utils to their own headers
...
So they can be included without depending on OrderService.pb.h
2025-04-29 19:24:41 +00:00
John Colvin
8aa0f1b674
refactor: Move binance state machine out of "spots" dir
...
So it can be used in the implementation for all binance apis (usds futs,
cross margin, etc.)
2025-04-29 05:24:04 +00:00
John Colvin
fc14215d9b
fix: Don't assert-crash if ord key isn't found for outgoing req
...
The i/o is asynchronous, so it's possible for the gateway to receive
a terminal ack from the exchange, remove the order from its index,
then receive a cancel/modify req from an algo that submitted the
req before it knew the order reached a terminal state.
2025-04-29 05:24:04 +00:00
John Colvin
091ed5a327
fix: Don't fire exe report for internal rejections
...
Internal rejections don't mean the order isn't "working". Only
rejections from the exchange mean that.
2025-04-29 05:24:04 +00:00
John Colvin
30bb9d0837
fix: Make SpotsOrderStore threadsafe
2025-04-29 05:24:04 +00:00
John Colvin
9cb2c580d6
diag: Use structured logging in binance spots gw
2025-04-29 05:24:04 +00:00
John Colvin
2e2150ac1a
refactor: Send binance spot orders through websocket api
...
This offers performance benefits over the REST api, since we don't have
to sign each request.
Note: I consolidated the UserDataSubscription code into SpotsGateway
because it was cleaner than trying to share a single websocket
connection between the two classes (UserDataSubscription and
SpotsGateway).
2025-04-29 05:24:04 +00:00
John Colvin
21d9435a67
Add run_in_background fn to WebsocketClient (cpp)
2025-04-29 05:24:04 +00:00
John Colvin
e7e334fb5a
Add continous ping function to WebsocketClient (cpp)
2025-04-28 17:12:59 +00:00
John Colvin
61f04c4605
fix: Implement state machine for binance cxl/replace
2025-04-28 17:12:59 +00:00
John Colvin
24fb2e1e39
refactor: Remove 'get_internal_key' delegate from exe report store
...
It made constructing the exe report store awkward, and smelled like poor
design.
2025-04-28 17:12:59 +00:00
John Colvin
ece141c448
Add dedicated types for structured logging
2025-04-28 17:12:59 +00:00
John Colvin
617bac8e74
cleanup: Move CancelOrderMsg impl to .cpp
2025-04-28 17:12:59 +00:00
John Colvin
ab217401eb
cleanup: Move CreateOrderMsg impl to .cpp, get rid of unused code
2025-04-28 17:12:58 +00:00
John Colvin
77e5c1481b
Add security_id/name fns to ExecutionReport for convenience
...
So callers don't need to check if security is a nullptr
2025-04-28 17:12:58 +00:00
John Colvin
a0f77f92a3
cleanup: Move ExecutionReport impl to .cpp
...
Also add using aliases to get rid of repetitive namespace prefixes
2025-04-28 17:12:58 +00:00
John Colvin
0acdcb150d
fix: Format price & qty w/ 6 decimals in binance modify order json
2025-04-28 17:12:58 +00:00
John Colvin
ac2f3b9bc6
Add ConcurrentQueue (c++)
2025-04-28 17:12:58 +00:00
John Colvin
0e522f90e5
refactor: Add line num suffix to var name in LOCK_GUARD macro
...
Rename to "BTS_LOCK_GUARD" while we're at it to avoid potential naming conflicts
2025-04-28 17:12:58 +00:00
John Colvin
40ad1f1b48
Update binance websocket endpoints
...
The api just changed, and old urls will be retired in May 2025
2025-04-28 17:12:58 +00:00
John Colvin
1cb75d399f
devcontainer: Update dotnet7 -> dotnet8
2025-04-28 17:12:58 +00:00
John Colvin
cddecc0543
cleanup: Fix benign typo in websocket_client.h
...
The open_handler fn return type should be "OpenHandler", not
"CloseHandler" (obviously).
2025-04-28 17:12:58 +00:00
John Colvin
484e36b330
refactor: Make timestamp internal value to signed (int64)
...
I am sick of casting uint64 -> int64. The latter is a much more
common argument type than the former.
2025-04-28 17:12:58 +00:00
John Colvin
8a9c22fa2a
vscode: Add Python Debugger entry to launch.json
2025-04-28 17:12:58 +00:00
John Colvin
a6e8853cb9
fix build (warns): Account for nullable ref types
2025-04-28 17:12:58 +00:00
John Colvin
dafa193283
fix build (windows): Update externals to fix catch include path
...
I couldn't get the build to work with the new catch2 on windows, though
it does work on linux. Rather than revert the catch -> catch2 include
path changes (again, which do build on linux), I decided to rename the
old windows catch include dir 'catch2'.
2025-04-28 17:12:58 +00:00
John Colvin
23651970c9
fix: Fix improper 'OfType' linq cast
...
Previously, animations were expressed through polymorphism (derived from the
base class CellAnimation), but the new impl uses composition. This 'OfType' call
was leftover from the polymorphism implementation, an attempt to linq cast
elements of base class (CellAnimation) to BackgroundAnimation.
2025-04-28 17:12:58 +00:00
John Colvin
043efab5a2
build: Upgrade c# to net8.0
2025-04-28 17:12:58 +00:00
John Colvin
5476466d55
Fetch secrets for config profiles with new aws sso config
2025-04-28 17:12:58 +00:00
John Colvin
54cb5a2ab2
tool: Add script to configure aws sso
2025-04-28 17:12:58 +00:00
John Colvin
29bf7d8d7e
deploy (fix): Update okx urls
...
Their aws domain has been retired.
2025-04-28 17:12:58 +00:00
John Colvin
855d2fd790
build: Update vcpkg
2025-04-28 17:12:58 +00:00
John Colvin
8a6a652882
fix build: Get rid of databento's internal nlohmann-json
...
** Migrate nlohmann-json over to vcpkg in the process **
Make it so databento is built with the same nlohmann-json lib that our
code is built with. Recently, I started getting undefined symbol errors
in databento code from nlohmann headers - presumably a conflict between
their nlohmann dep and ours.
2025-04-28 17:12:58 +00:00
John Colvin
3f288704bf
build (linux): Migrate openssl to vcpkg, update to 3.5.0
...
Databento, as of version 0.32.0, requires openssl >= 3.0
https://github.com/databento/databento-cpp/releases/tag/v0.32.0
2025-04-28 17:12:58 +00:00
John Colvin
98bc78463d
build (linux): Migrate catch2 dep to vcpkg (from externals)
2025-04-28 17:12:58 +00:00