John Colvin
c19d173983
refactor: Move SecurityStore to spark_core, rename Resolver
2022-08-16 17:25:02 -04:00
John Colvin
203164f372
fix (preemptive): Init default UserSettings.day_fills_grid
...
This fix is preemptive because the hardcoded Day Fills defaults are automatically
used when the UserSettings.day_fills_grid member is null
2022-08-16 17:25:02 -04:00
John Colvin
6f69f1c2e2
fix (preemptive): Apply Day Fills settings migration rules
...
This is a preemptive fix bc as of now (8/14/2022), there are no Day Fills
migration rules
2022-08-16 17:25:02 -04:00
John Colvin
ad1a585b5c
refactor: Move Optional into Spark.Core
2022-08-16 17:25:02 -04:00
John Colvin
f29e367ec7
refactor: Clean up ObservableSortedCollection
...
* Enable nullability
* Run formatter
* Add readonly specifiers where possible
* Improve documentation
2022-08-16 17:25:02 -04:00
John Colvin
18127383f0
refactor: Make IObservableCollection inherit IReadOnly
2022-08-16 17:25:02 -04:00
John Colvin
b450c757c9
refactor: Move ObservableSortedCollection to Spark.Core.Collections
2022-08-16 17:25:02 -04:00
John Colvin
836683bcbe
refactor: Move IObservableCollection to Spark.Core.Collections
2022-08-16 17:25:02 -04:00
John Colvin
c271af30d8
refactor: Get rid of non-generic InsertRange ext
2022-08-16 17:25:02 -04:00
John Colvin
31fab94208
refactor: Get rid of non-generic AddRange ext
...
Most references to this fn were by generic IList<T>s. This resulted in error
prone, misleading code as such calls subtly bypass the compile-type type
constraints provided of the generic impl.
2022-08-16 17:25:02 -04:00
John Colvin
a9b5067d7a
refactor: Move fns from GlobalExtensions to less vague classes
2022-08-16 17:25:01 -04:00
John Colvin
7a31b025a2
refactor: Add 'ms' suffix to exch-open-order timestamp fields
...
Just to make it clear that they are milliseconds (not nanos, micros, etc.)
2022-08-16 17:24:52 -04:00
John Colvin
31897a1b2e
refactor: Change exch-open-order record_id to auto-incremented int
...
To insulate ourselves from potential duplicate-id bugs at the exchange
2022-08-16 16:46:47 -04:00
John Colvin
f93bc592cb
fix: Set RetrievedExchangeOpenOrder.exchange_order_id
...
Bugs (fixed):
* The 'exchange order id' field is empty in open orders data received
by client
2022-08-16 13:22:38 -04:00
John Colvin
6ca2753951
fix (vs): Use precison in terms of actual data for eq comp
...
Bugs (fixed):
* The tick up/down buttons have no effect for vol input cells
Cause: The cell vm ignores some value updates because the equality
comparer incorrectly considers the new value equal to the current one
(because it doesn't use enough decimal places in the comparison)
2022-08-11 01:33:43 -04:00
Taha Afzal
470ca0093e
Adding more logging helpers to VolSurfaceTroubleshootingFunctions
2022-08-10 20:54:10 -04:00
John Colvin
7e1715964f
fix (vs): Pass the vm's 'current_grid' to the model
...
Bugs (fixed):
* Cannot edit volsurface cell values (they are immediately reverted)
Cause: The vm was passing the model's grid back to itself before, effectively
undoing manual edits in cells
2022-08-10 18:27:41 -04:00
John Colvin
39e929a614
fix: Actually use eq-comp member in Property vm
2022-08-10 18:17:58 -04:00
John Colvin
a9aa06f275
fix (vs): Actually use coulmn comparer in cell vm
2022-08-10 18:11:27 -04:00
John Colvin
54510c9e59
refactor (vs grid): Supress recalc reqs while processing update
2022-08-10 14:26:28 -04:00
John Colvin
cb56429f04
refactor: Rename 'execute' -> 'Invoke'
...
To be consistent and interchangeable w/ System.Action
2022-08-10 14:26:28 -04:00
John Colvin
ac8147cc0f
refactor: Add 'implicit operator T(Optional<T>)' for convenience
2022-08-10 14:26:28 -04:00
John Colvin
82ac189ac9
refactor: Strip 'Wrapper' from 'DeferrableActionWrapper' name
2022-08-10 14:26:27 -04:00
John Colvin
5721ff78b6
fix (vs): Only request recalc when input changes (not output)
...
Bugs (fixed):
* The volsurface grid can get into an endless loop of recalc requests
2022-08-09 15:56:05 -04:00
John Colvin
7afd2947f1
refactor: Clean up vs grid vms a bit
...
* Split vs-cell-vm classes up into own files
* Rename classes by changing 'VolGrid' prefix to 'VolSurface'
* Remove unused struct VolSurfaceCellState
* Enable nullable
* Run formatter
2022-08-09 15:55:40 -04:00
John Colvin
c3e3862c5f
refactor: Update vs cell 'is_dirty' synchronously when vals change
2022-08-09 02:57:35 -04:00
John Colvin
bf2dc9ecca
fix (vs grid): Account for nan & rounding error
...
Bugs (fixed):
* The volsurface grid starts flasing is_dirty borders all over the place. The
repro is inexact, but it seems to happen after inputs are changed a few
times (perhaps from loading a previous volsurface).
* The volsurface grid flashes is_dirty borders just from clicking on an input
cell (even if no change is entered).
2022-08-09 02:57:35 -04:00
John Colvin
e0e188a02c
refactor: Enable NaN identity equality in tick_equals
2022-08-09 02:57:35 -04:00
John Colvin
79ba1654d3
fix: Fix typo in tick_equals fn
2022-08-09 02:57:35 -04:00
Taha Afzal
2aab0d18a5
Formatting slide exp, to look like PNL's
2022-08-08 23:45:02 -04:00
John Colvin
312c8ded11
fix (ui pnl): Add greek props to group row vm
...
Bugs (fixed):
* Greek sums still aren't visible in group rows (though they are visible in
Selected/Total header rows)
2022-08-08 16:11:25 -04:00
John Colvin
3f86779da6
ui (launcher): Move PNL menu items to Analytics module
2022-08-08 16:11:25 -04:00
John Colvin
716d3b8482
ui (day fills): Make title & icon consistent w/ PNL win
2022-08-08 16:11:25 -04:00
John Colvin
24f6dbc4f0
ui (day fills): Convert fill_time utc to local
2022-08-08 16:11:25 -04:00
John Colvin
3e943fa35e
refactor (pnl): Add 'PNL' prop to Icons class
...
To make it clear which icon belongs to which window
2022-08-08 16:11:25 -04:00
John Colvin
457f878b41
ui (pnl): Change win title to 'P&L' to match launcher menu item
2022-08-08 16:11:25 -04:00
John Colvin
ac2b2d042a
refactor: Split WorkspaceProtos up into 1 class/file
2022-08-08 16:11:25 -04:00
John Colvin
829d2cdbf6
refactor: Provide ICloneable impl in IProtobuf<T>
2022-08-08 16:11:25 -04:00
John Colvin
3cd9693b36
diag (vs): Log cell vm 'is_dirty' changes
2022-08-08 16:11:25 -04:00
John Colvin
2b52ecf2ef
perf (vs): Supress repeated 'is_dirty' updates
...
Before the updates reach the dispatcher thread
2022-08-08 16:11:25 -04:00
John Colvin
faab60cbc1
ui (vs): Convert NaN to 0 when users clicks tick up/down
2022-08-08 16:11:25 -04:00
John Colvin
b6be0d649d
fix (vs): Don't throw ex if parse_double input is null
...
Bugs (fixed):
* Previous vol surfaces may have missing data, which can lead to an assert
crash in the parse_double fn
2022-08-08 16:11:25 -04:00
Taha Afzal
2a65c45d21
Theos/Greeks are still produced if AW2 window is not loaded
2022-08-08 16:00:48 -04:00
Taha Afzal
dc6ae2ac29
Removing P from the names of greek columns in Day PNL
2022-08-08 11:53:56 -04:00
Taha Afzal
df4250c33a
Hooking AW2 populate empty exps
2022-08-07 22:03:50 -04:00
John Colvin
53504ef6f0
ui (pnl): Improve default settings
2022-08-07 15:18:16 -04:00
John Colvin
10afb1af06
ui (pnl): Show greek sums in group/header rows
2022-08-07 14:59:00 -04:00
John Colvin
a9149dfa87
refactor: Clean up PNLNormalizedData
...
* Use new lang feats: nullable, and 'init' prop setters
* Group 'sod', 'day', and 'working' members in respective groups
* Run formatter
2022-08-07 14:39:44 -04:00
John Colvin
5afa6695e7
fix (pnl view): Enforce min height for 'Selected' header row
2022-08-07 13:51:55 -04:00
John Colvin
d2a6d54090
refactor (pnl): Replace dyn resources w/ Bindings in xaml
...
Traditional Bindings are more performant than DynamicResources, and make for
cleaner code
2022-08-07 13:51:55 -04:00