Commit Graph
13572 Commits
Author SHA1 Message Date
John Colvin 490e425fc3 Remove reference to spark protobuf Config in ViewStream
We can't read spark protobuf Config until it has been initialized,
and since ViewStream doesn't have the configServer param handy it
isn't able to initialize config if necessary. In that case, it would simply
block until config was initialized by someone else. Such a risk doesn't
seem justified for this particular configuration dependency
(DataStreamConfig.UseUncopiedNewRowsInFire). For now, its hardcoded to false.
2024-10-14 17:21:46 +00:00
John Colvin 0382d5de3b refactor: Run RemoteQueryManager as an IHostedService
This paradigm more accurately represents the RemoteQueryManager as a
Service that can be started/stopped.
2024-10-14 17:21:46 +00:00
John Colvin 0ae1d61ce1 Remove inappropriate "Unable to dispose subscription" log msg 2024-10-14 17:21:46 +00:00
John Colvin 3c1d849989 fix: Ensure spark config init and login are only performed once
As a static function that could be called from anywhere in the code
(directly or indirectly), 'Configuration.Initialize' was vulnerable to
race bugs. The "Configuration.get<T>()" method, whose calls are
ubiquitous in our code, would initialize config if it hadn't been done
so already. Without a reference to the configServer param, this param
would effectively be ignored/overridden with null.

It's important that login only be performed once, for obvious reasons
(our exes that connect to sparkd are generally designed to process data
for a single user). Furthermore, not every routine that requires a
successful login has a reference to the credentials needed to do it. To
address this, we now pass the ISparkdLoginService singleton to these
routines so they can wait until the singular login task has completed
before they begin.
2024-10-14 17:21:46 +00:00
John Colvin 1b26f4b114 Move misplaced log abt initializing query text to appropriate place 2024-10-14 17:21:46 +00:00
John Colvin 8a2dea53e6 Assert ViewStreamDatabase.instance is only created once
The instance must be initialized via ViewStreamDatabase.SetGlobalInstance
2024-10-14 17:21:46 +00:00
John Colvin e396ebb181 cleanup: Remove unused code from ViewStreamDatabase 2024-10-14 17:21:46 +00:00
John Colvin 7f9be44cc2 Include subscription id in ds websocket updates 2024-10-14 17:21:46 +00:00
John Colvin 0f88a15c57 fix: Define BoooleanConstant before StringConstant
Otherwise the former masks the latter and prevents it from matching
2024-10-14 17:21:46 +00:00
John Colvin b84dfce39d Log event data in websocket open, close, error callbacks 2024-10-14 17:21:46 +00:00
John Colvin 86bddb7fd6 refactor: Bring back Material DataGrid
Fix the column resize bugs that made it previously unusable
2024-10-14 17:21:46 +00:00
John Colvin 3b4e424dd3 refactor: Improve react webapp state management
* Add queryTextResetTime as part of the CannedQuery state
  (the QueryControl compares the canned query click time with the time of the
  last user input, and applies the text from the most recent change)

* Replace 'isRunning' (bool) with a 'queryState' (string) to reflect the subscription status
  value received from the server. Less indirection this way.

* Replace inappropriate useMemo call w/ useEffect
2024-10-14 17:21:46 +00:00
John Colvin 96dee6ac0e cleanup: Get rid of magic const (subscriptionId) in webapp App.jsx 2024-10-14 17:21:46 +00:00
John Colvin e0ea6418bd build: Copy configuration profiles to publish dir 2024-10-14 17:21:46 +00:00
John Colvin fd34c0f5e7 cleanup: Remove unnecessary deps from csprojs 2024-10-14 17:21:46 +00:00
John Colvin 0e50994c2d build: Change publish_data_stream.py to publish the sln
We were publishing individual projects as a workaround for the
dependency issue (bug) that caused some projects to incorrectly target
net8.0. The fact that publishing individual projects "just worked" was
probably dumb luck. Now that the underlying issue has been addressed, we
can resume publishing the sln as a whole.
2024-10-14 17:21:46 +00:00
John Colvin 8612f6c073 dev: Install docker in devcontainer
So we can start various services like sparkd, pubsub, ds publishers, ds
webapp, etc. from inside the devcontainer.
2024-10-14 17:21:46 +00:00
John Colvin 39bc561834 dev: Remove dotnet8 from devcontainer
We'll upgrade to dotnet8 eventually, but now isn't the time (too much
more important work to be done).
2024-10-14 17:21:46 +00:00
John Colvin 2f88cbd7e8 dev: Run devcontainer on host network
So we don't need to worry about publishing the right ports (and don't
need to rebuild the container everytime the list of ports changes).
2024-10-14 17:21:46 +00:00
John Colvin 1e625c58cf fix: Downgrade Microsoft.Extensions.Hosting to 7.0.1
A handful of csprojs were referencing version 8.0.0. Since that version
targets net8.0, I have no idea why it didn't cause the build to fail.
Instead, this framework mismatch led to a mysterious runtime crash with
the following error, despite the dll in question being present in the
build dir:

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Diagnostics.DiagnosticSource, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
The system cannot find the file specified.

It is worth noting that this crash would only happen for exes published
as part of the DataStreamSuite.sln with the "--self-contained" flag. For
example, the Bts.DataStreamSuite.Server exe would always fail if
published via:

dotnet publish --configuration Release --sc --framework net7.0 --runtime linux-x64 <DataStreamSuite.sln>
2024-10-14 17:21:46 +00:00
John Colvin c792e1897e Add HttpsRedirection middleware first in the webapp pipeline
Middleware handlers are invoked in the order in which they are added. Any middleware
that is added before HttpsRedirection may can prevent the request from being redirected.
As of now, only development-specific middleware is added ahead of HttpsRedircetion.
2024-10-14 17:21:46 +00:00
John Colvin 71032cdefc build: Copy configuration profiles to build dir
So they are readily available to publish/deploy scripts.
2024-10-14 17:21:46 +00:00
John Colvin 6709ccc2fe Fix benign typo in Scanner/Parser msbuild targets
The output path referenced a non-existant msbuild metadata prop "RelativeOutputDir"
(the actual prop is called "RelativeDir"). Also, the OutputFile path is relative to the
project dir (the 'MSBuildProjectDir' prop), not the file being included.
2024-10-14 17:21:46 +00:00
John Colvin 807675a0ab fix: Catch exception when creating TcpClient 2024-10-14 17:21:46 +00:00
John Colvin f7f1ea2c0c fix: Catch WebSocketException in DataStreamSubscription 2024-10-14 17:21:46 +00:00
John Colvin 443aac540a fix: Add null check to NonIncGroupByStream 2024-10-14 17:21:46 +00:00
John Colvin 7c803d18f9 fix: Add null check to TableAccumulator2 2024-10-14 17:21:46 +00:00
John Colvin 2c813da889 fix: Add self-signed certificate to Dockerfile for ds webapp 2024-10-14 17:21:46 +00:00
John Colvin 6e0dbe56a3 fix: Make SystemSubscriptionMapPublisher threadsafe
The PubSubState.onTagMapChanged event may not be invoked on
the same thread as doWork.
2024-10-14 17:21:46 +00:00
John Colvin 7550e81aa7 fix: Add null check in TimeBasedFilter.cs 2024-10-14 17:21:46 +00:00
John Colvin d3ce9a7a9a Reduce task wait/timeout code in AsyncTCPConnector 2024-10-14 17:21:46 +00:00
John Colvin 4ffc0cf38e Add a few canned queries to AwsProd.json for ds webapp 2024-10-14 17:21:46 +00:00
John Colvin 5607e92ea9 fix: Copy canned queries to clipboard on click
Instead of trying to update the text directly, which causes the front end
to overwrite the user's changes everytime the data updates from then on.
2024-10-14 17:21:46 +00:00
John Colvin 77b9a2fbbb fix: Convert invalid doubles to nan in ds webapp serializer 2024-10-14 17:21:46 +00:00
John Colvin 7e1136a092 Increase datagrid maxheight in ds webapp to 1000px 2024-10-14 17:21:46 +00:00
John Colvin f5b71bda18 Improve error display in ds webapp 2024-10-14 17:21:46 +00:00
John Colvin e4d6bc604b fix: Dispose existing sub on subscribe req in ds webapp
Even if new sub has parse error. This fixes a bug where the previous
subscription would continue firing and updating the frontend, when it
should just display the error info to the user and cease updates.
2024-10-14 17:21:46 +00:00
John Colvin 148a1bd5d4 fix: Get rid of "UseSpa" calls in webapp Production environment
This was leftover from a misguided attempt to fix a bug that turned out
to be due to an omitted environment var:
ASPNETCORE_HOSTINGSTARTUPASSEMBLIES=Microsoft.AspNetCore.SpaProxy
2024-10-14 17:21:46 +00:00
John Colvin b4eaba8af4 Define webapp specific env vars in generic datastream app deploy script
For now, this makes things easier, as I don't need to write a special script just for the webapp
2024-10-14 17:21:46 +00:00
John Colvin 7801ac9300 Add config profile and Dockerfile args to deploy script 2024-10-14 17:21:46 +00:00
John Colvin 4f6614c080 Copy DataStream WebApp 'dist' to 'wwwroot' in deploy script 2024-10-14 17:21:46 +00:00
John Colvin f9084e24dd Tweak DataGrid style in DataStream WebApp 2024-10-14 17:21:46 +00:00
John Colvin 32c8589478 Add AwsProd config for DataStream WebApp 2024-10-14 17:21:46 +00:00
John Colvin 7e25b904b4 fix: Add VITE_ prefix to imported env vars
For the DataStream WebApp client
2024-10-14 17:21:46 +00:00
John Colvin a25afb9c64 Fix urls for DataStreamPublisher AwsProd.json 2024-10-14 17:21:46 +00:00
John Colvin f672d2221a Add benzinga news streams to AwsProd.json
This is a config profile for DataStreamPublisher, designed to be deployed
to aws (on public internet).
2024-10-14 17:21:46 +00:00
John Colvin 36f1596288 fix build warnings: Make props nullable strings in SharedStreamConfig 2024-10-14 17:21:46 +00:00
John Colvin d0f0ef12f5 whitespace: Format PubSubServer.json (indentation issues) 2024-10-14 17:21:46 +00:00
John Colvin ca326690a5 fix import from environment variable 2024-10-14 17:21:46 +00:00
John Colvin d84fb40454 Add a few tasks to run DataStream WebApp 2024-10-14 17:21:46 +00:00