John Colvin
3bb2025ea2
fix (ladder): Make sure price-range 'busy' is flipped back to false
...
Once the async price-range-shift op is completed
Bugs (fixed):
* Can't scroll beyond initial price range in orderbook ladder
Cause: The LadderGridHost's price-range-shift 'busy' flag gets stuck to false
2022-08-22 01:30:31 -04:00
John Colvin
f2730ff0d7
doc: Add documentation for Task.ignore ext
2022-08-22 01:30:31 -04:00
John Colvin
7fcff9e5b4
refactor: Clean up MarketViewAnimation code a bit
2022-08-22 01:30:31 -04:00
John Colvin
51f83f4880
refactor: Rename 'HashCode.with' -> 'with_values'
...
Repurpose 'with' to accept a single value
2022-08-22 01:30:31 -04:00
John Colvin
88cb510aea
refactor: Remove the ulong 'lldatetime' ext
...
It's too esoteric. Most ulongs don't represent an 'LLDateTime'
TODO: Consider removing the uint 'argb' extensions for same reason
2022-08-22 01:30:14 -04:00
John Colvin
452c642af0
refactor: Rename TryFirst ext FirstOrNull
...
Also move to it from APIExtensions to EnumerableExtensions
2022-08-22 00:05:08 -04:00
John Colvin
3fafc5004e
refactor: Clean up LazySubscription, move to Spark.Core.Disposables ns
2022-08-22 00:05:07 -04:00
John Colvin
fd8e502140
refactor: Lock private obj (not 'this')
...
'Lock(this)' is generally bad practice. It's better to use an explicitly named
var that is minimally accessible to outside callers to reduce risk of deadlocks.
2022-08-22 00:05:07 -04:00
John Colvin
b499a5c38b
refactor: Move IDisposable utils to Spark.Core.Disposables ns
...
* Move Anonymous/FinalizableDisposable to own file
* Rename DisposableCombo -> ImmutableDisposable and move it to its own file
* Clean up IDisposable utils impl, but keep changes to calling code minimial
2022-08-22 00:05:04 -04:00
John Colvin
2320383b16
refactor: Remove DisposableContainer class
...
It's innately antithetical to the Dispose pattern, as it can never truly be
disposed
2022-08-22 00:03:11 -04:00
John Colvin
59b3e73330
fix: Assign IDisposable to _dispose member (not local var)
...
So it is properly disposed, and not just eventually collected by GC
2022-08-22 00:03:11 -04:00
John Colvin
9d9a1b86c4
fix: Fix typo in 'init_auto_login'
...
The 'SubscribeClosed' call should be executed immediately, and the returned
IDisposable disposed when 'login_hooks' is disposed (prior to this commit, it
wasn't calling 'SubscribeClosed' until login_hooks was disposed)
2022-08-22 00:03:11 -04:00
John Colvin
21cc2cefbf
refactor: Un-nest SelectorWrapper class, rename SelectorList
2022-08-22 00:03:11 -04:00
John Colvin
904df4260d
fix (preemptive): Fix typo in SelectorWrapper list
...
Bugs (fixed):
* [preemptive] SelectorWrapper.IsReadOnly is wrong
Details: The fix is considered 'preemptive' because this prop is almost
certainly not referenced. Nevertheless, the impl ought to be correct.
2022-08-22 00:03:11 -04:00
John Colvin
af785d5d0b
fix: Make sure ThreadSafeEvent uses same lock as owner
2022-08-22 00:03:11 -04:00
John Colvin
1d796856ca
refactor: Make spark_api depend on spark_core (not other way around)
2022-08-22 00:03:11 -04:00
John Colvin
35f0d5a53f
refactor: Split (Equality)Comparer utils up into modular classes
2022-08-22 00:03:10 -04:00
John Colvin
2b2fdd2b94
refactor: Remove borderline useless TaskExtensions
...
There were few references to these extensions, and many weren't referenced at all
2022-08-22 00:03:10 -04:00
John Colvin
9e4539a902
refactor: Remove unused code
2022-08-22 00:03:05 -04:00
John Colvin
a76c8ffd98
fix: Fix typo 'is not null' -> 'is null'
...
Bugs (fixed):
* Window size isn't restored if window has multiple tabs
Cause: The typo flips the bool arg that indicates whether or not a window
should be measured and fit to size (as happens when a window is opened for
the first time)
2022-08-18 16:17:22 -04:00
John Colvin
d7474cb8da
fix (ui): Await settings-save before disposing IShellWindow
...
Bugs (fixed):
* Can't reopen Fills windows via undo/redo in the BookMarks module
Details:
* Only applies to Fills windows closed via the tab-close 'x' button (not
the window-close 'x' button)
* Doesn't cause a crash, nor exhibit any side effects (aside from breaking
undo/redo)
Cause:
* ISlow/SharedWindows (i.e., shell windows that run on bg threads) are
disposed before the ISettingsCollector retrieves their state via
'IShellWindow.SaveState'. The FillsWindow sets its _vm member to null
when it is disposed, leading to a null-ref ex in its SaveState getter.
This ex is caught (synchronously) and logged as an error, which explains
the lack of side effects.
2022-08-18 13:57:44 -04:00
John Colvin
890a23a537
refactor: Rename AsyncEvent.invoke -> Invoke
...
To be syntactically consistent w/ csharp delegates (and the wpf Dispatcher,
which has Invoke/InvokeAsync methods)
2022-08-18 12:39:57 -04:00
John Colvin
ab17eee260
refactor: Remove unused code
2022-08-18 12:39:57 -04:00
Taha Afzal
8701fb7132
Fixing qty in ExchangeOpenOrders for fractional qty orders
2022-08-17 14:12:23 -04:00
Taha Afzal
89fcb3092b
Fixing merge conflict
2022-08-17 12:54:27 -04:00
John Colvin
c9856b96ae
fix build (client): Remove erroneous using statement
2022-08-16 21:12:49 -04:00
John Colvin
04477a4b7c
refactor: Don't copy strings
2022-08-16 21:08:53 -04:00
John Colvin
99371a2ead
feat: Add Open Orders window
2022-08-16 17:25:03 -04:00
John Colvin
70487a8ef7
ui: Make 'B/S' the standard header for 'Side' cols
...
Until now, this header was hardcoded in OrderBookSettings
2022-08-16 17:25:03 -04:00
John Colvin
44c419fdaf
refactor: Move bool-check converter from rec rep to common place
...
Will be used in the new Open Orders window
2022-08-16 17:25:03 -04:00
John Colvin
5eb151f9a0
refactor: Move common orderbook col headers to shared place
...
Specifically, col headers that will be used in the new Open Orders window, for
consistency's sake
2022-08-16 17:25:03 -04:00
John Colvin
855a939c51
refactor: Return obj from Log.not/isnull fns
...
For convenience, so these calls may be used in a chain like manner, etc.
2022-08-16 17:25:03 -04:00
John Colvin
7071d9b961
refactor: Add Not/MaybeNull attributes to Log.not/isnull fns
...
So the compiler recognizes these methods guarentee a particular result of
the expression 'obj is null'
2022-08-16 17:25:03 -04:00
John Colvin
adf14491bc
refactor: Check if obj is of type 'T' in Optional<T>.Equals
2022-08-16 17:25:03 -04:00
John Colvin
7e0e8f2801
refactor: Clean up Optional<T>
2022-08-16 17:25:02 -04:00
John Colvin
4a37e2d6a6
refactor: Implement IKeyedData in generated cs pbuf types
...
For convenience, so we don't have to pass key-selector lambdas all over the
place when dealing w/ IObservable<TableUpdate>s from the pbuf services
2022-08-16 17:25:02 -04:00
John Colvin
12b2371a69
style: Clean up api code-gen template immutable.pb.cs
2022-08-16 17:25:02 -04:00
John Colvin
c19d173983
refactor: Move SecurityStore to spark_core, rename Resolver
2022-08-16 17:25:02 -04:00
John Colvin
203164f372
fix (preemptive): Init default UserSettings.day_fills_grid
...
This fix is preemptive because the hardcoded Day Fills defaults are automatically
used when the UserSettings.day_fills_grid member is null
2022-08-16 17:25:02 -04:00
John Colvin
6f69f1c2e2
fix (preemptive): Apply Day Fills settings migration rules
...
This is a preemptive fix bc as of now (8/14/2022), there are no Day Fills
migration rules
2022-08-16 17:25:02 -04:00
John Colvin
ad1a585b5c
refactor: Move Optional into Spark.Core
2022-08-16 17:25:02 -04:00
John Colvin
f29e367ec7
refactor: Clean up ObservableSortedCollection
...
* Enable nullability
* Run formatter
* Add readonly specifiers where possible
* Improve documentation
2022-08-16 17:25:02 -04:00
John Colvin
18127383f0
refactor: Make IObservableCollection inherit IReadOnly
2022-08-16 17:25:02 -04:00
John Colvin
b450c757c9
refactor: Move ObservableSortedCollection to Spark.Core.Collections
2022-08-16 17:25:02 -04:00
John Colvin
836683bcbe
refactor: Move IObservableCollection to Spark.Core.Collections
2022-08-16 17:25:02 -04:00
John Colvin
c271af30d8
refactor: Get rid of non-generic InsertRange ext
2022-08-16 17:25:02 -04:00
John Colvin
31fab94208
refactor: Get rid of non-generic AddRange ext
...
Most references to this fn were by generic IList<T>s. This resulted in error
prone, misleading code as such calls subtly bypass the compile-type type
constraints provided of the generic impl.
2022-08-16 17:25:02 -04:00
John Colvin
a9b5067d7a
refactor: Move fns from GlobalExtensions to less vague classes
2022-08-16 17:25:01 -04:00
John Colvin
7a31b025a2
refactor: Add 'ms' suffix to exch-open-order timestamp fields
...
Just to make it clear that they are milliseconds (not nanos, micros, etc.)
2022-08-16 17:24:52 -04:00
John Colvin
31897a1b2e
refactor: Change exch-open-order record_id to auto-incremented int
...
To insulate ourselves from potential duplicate-id bugs at the exchange
2022-08-16 16:46:47 -04:00