SPARK-462 recovered errors take the spreader to the end state now (not asserting)

This commit is contained in:
Taha Afzal committed 2018-02-13 13:10:01 -05:00
1 parent c98c6cca76
commit dd7a400e2d
11 files changed
+35 -5

No files matched your search

@@ -21,6 +21,8 @@ public:
// 1. called once before the other calls. state should be
// constructed here
virtual void on_init_new(api::orderman::OrderDefinition const&, const SpreaderPreActivationOrderServices&) = 0;
// when constructed on recovery (with partial state)
virtual void on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&) = 0;
// 2. this is the end of the construction cycle. should happen
// after on_init_new and before all other calls. market data subs
// and quoter order creation happens here
@@ -46,9 +48,7 @@ public:
// 14. is called periodically
virtual void on_check_termination () = 0;
// 15.
virtual void on_crack ()
{
}
virtual void on_crack () {}
};
}}
@@ -36,6 +36,11 @@ void SpreaderOrder::on_init_new(const api::orderman::OrderDefinition& order_def,
if (!_active) return;
_on_init_new(order_def, SpreaderPreActivationOrderServices(&pao_services));
}
void SpreaderOrder::on_init_recovered(const bts::api::orderman::OrderRecord& order_record, const bts::orderman::PreActivationOrderServices& pao_services)
{
LOG(OrderMan, Info, "SpreaderOrder.on_init_recovered order_key: {}", key().value());
_state_worker->on_init_recovered(order_record, SpreaderPreActivationOrderServices(&pao_services));
}
void SpreaderOrder::on_activate(Price price, Quantity quantity, OrderServices& services)
{
if (!_active) return;
@@ -62,7 +62,7 @@ public:
// this is the construction, can be slow
void on_init_new(const bts::api::orderman::OrderDefinition& order_def, const bts::orderman::PreActivationOrderServices&) override;
// called when the order is recovered from disk (not dealing with it now)
void on_init_recovered(bts::api::orderman::OrderRecord const&, const bts::orderman::PreActivationOrderServices&) override {bts_assert (false);}
void on_init_recovered(bts::api::orderman::OrderRecord const&, const bts::orderman::PreActivationOrderServices&) override;
// this is in the critical path, orders can be submitted now
// (this is only called once and after the on_init_new)
void on_activate(Price, Quantity, OrderServices&) override;
@@ -18,6 +18,10 @@ void SpreaderEndStateWorker::on_init_new(api::orderman::OrderDefinition const&,
{
bts_assert_msg (false, "SpreaderEndStateWorker::on_init_new is an illegal operation");
}
void SpreaderEndStateWorker::on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&)
{
bts_assert_msg (false, "SpreaderEndStateWorker::on_init_new is an illegal operation");
}
void SpreaderEndStateWorker::on_activate(Price price, Quantity quantity, SpreaderOrderServices&)
{
// this can only happen if the security could not be resolved
@@ -15,6 +15,7 @@ public:
void on_transition() override;
SpreaderState state() const override;
void on_init_new(api::orderman::OrderDefinition const&, const SpreaderPreActivationOrderServices&) override;
void on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&) override;
void on_activate(Price, Quantity, SpreaderOrderServices&) override;
void on_update(Price, Quantity) override;
void on_cancel() override;
@@ -29,6 +29,15 @@ void SpreaderStartStateWorker::on_init_new(const api::orderman::OrderDefinition&
_spreader->_transform_to_END (&msg);
}
}
void SpreaderStartStateWorker::on_init_recovered(const bts::api::orderman::OrderRecord& order_record, const SpreaderPreActivationOrderServices& spreader_pao_services)
{
bts_assert(!_spreader->_inited());
// we are not handling this yet, so lets send it directly to END
_spreader->_bookkeeping_data_ptr = new SpreaderBookkeepingData (*_spreader, _spreader->key(), order_record.def(), spreader_pao_services, std::vector<LegPropertyData>());
LOG(OrderMan, Error, "SpreaderStartStateWorker.on_init_recovered key: {} , going to END", _spreader->key().value());
std::string msg = "Recovered spreader orders and not supported";
_spreader->_transform_to_END (&msg);
}
void SpreaderStartStateWorker::on_activate(Price price, Quantity quantity, SpreaderOrderServices& order_services)
{
// 1. update price, qty
@@ -16,7 +16,8 @@ public:
SpreaderStartStateWorker (SpreaderOrder* spreader);
void on_transition() override;
SpreaderState state() const override;
void on_init_new(api::orderman::OrderDefinition const&, const SpreaderPreActivationOrderServices&) override;
void on_init_new(const api::orderman::OrderDefinition&, const SpreaderPreActivationOrderServices&) override;
void on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&) override;
void on_activate(Price, Quantity, SpreaderOrderServices&) override;
void on_update(Price, Quantity) override;
void on_cancel() override;
@@ -18,6 +18,10 @@ void SpreaderWaitingForCancelAllStateWorker::on_init_new(api::orderman::OrderDef
{
bts_assert_msg (false, "SpreaderWaitingForCancelAllStateWorker::on_init_new is an illegal operation");
}
void SpreaderWaitingForCancelAllStateWorker::on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&)
{
bts_assert_msg (false, "SpreaderWaitingForCancelAllStateWorker::on_init_new is an illegal operation");
}
void SpreaderWaitingForCancelAllStateWorker::on_activate(Price, Quantity, SpreaderOrderServices&)
{
bts_assert_msg (false, "SpreaderWaitingForCancelAllStateWorker::on_activate is an illegal operation");
@@ -16,6 +16,7 @@ public:
void on_transition() override;
SpreaderState state() const override;
void on_init_new(api::orderman::OrderDefinition const&, const SpreaderPreActivationOrderServices&) override;
void on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&) override;
void on_activate(Price, Quantity, SpreaderOrderServices&) override;
void on_update(Price, Quantity) override;
void on_cancel() override;
@@ -17,6 +17,10 @@ void SpreaderWorkingStateWorker::on_init_new(api::orderman::OrderDefinition cons
{
bts_assert_msg (false, "SpreaderWorkingStateWorker::on_init_new is an illegal operation");
}
void SpreaderWorkingStateWorker::on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&)
{
bts_assert_msg (false, "SpreaderWorkingStateWorker::on_init_recovered is an illegal operation");
}
void SpreaderWorkingStateWorker::on_activate(Price, Quantity, SpreaderOrderServices&)
{
bts_assert_msg (false, "SpreaderWorkingStateWorker::on_activate is an illegal operation");
@@ -15,6 +15,7 @@ public:
void on_transition() override;
SpreaderState state() const override;
void on_init_new(api::orderman::OrderDefinition const&, const SpreaderPreActivationOrderServices&) override;
void on_init_recovered(const bts::api::orderman::OrderRecord&, const SpreaderPreActivationOrderServices&) override;
void on_activate(Price, Quantity, SpreaderOrderServices&) override;
void on_update(Price, Quantity) override;
void on_cancel() override;