refactor: Change raw IDGenerator ptr to shared_ptr

This commit is contained in:
John Colvin committed 2024-11-29 15:05:12 +00:00
1 parent 869f629d3f
commit 5604eabde4
4 files changed
+10 -8

No files matched your search

@@ -51,7 +51,7 @@ struct MarketDataGateway::PImpl {
shared_ptr<MDProducer> md_producer;
shared_ptr<IMarketDataListener> listener;
MdSink(api::Venue venue, IDGenerator *sec_id_store)
MdSink(api::Venue venue, shared_ptr<IDGenerator> sec_id_store)
: sec_index(std::make_shared<GeneralSecurityIndex>()),
md_producer(std::make_shared<MDProducer>()),
listener(std::make_shared<GeneralMarketDataListener>(
@@ -103,7 +103,7 @@ void MarketDataGateway::start() {
for (auto &[venue, source] : provider->get_sources()) {
const auto v = domain::DomainSecurityUtils::convert(venue);
auto &sink = me_->sinks.emplace_back(
std::make_unique<PImpl::MdSink>(v, me_->sec_id_store.get()));
std::make_unique<PImpl::MdSink>(v, me_->sec_id_store));
source->start(sink->listener);
}
}
@@ -47,7 +47,7 @@ struct CCApiMarketDataProvider::PImpl {
VenueSink(api::Venue venue, shared_ptr<IDGenerator> sec_id_store)
: sec_index(), md_producer(std::make_shared<MDProducer>()),
listener(std::make_shared<GeneralMarketDataListener>(
sec_index, md_producer, venue, sec_id_store.get())) {}
sec_index, md_producer, venue, sec_id_store)) {}
};
MarketDataConfig config;
@@ -54,6 +54,8 @@
namespace bts::md {
using bts::persistence::IDGenerator;
using MDArray = std::array<PriceSize, COCONUT_MAX_DEPTH>;
#define SEC_TYPE(x) bts::domain::protobufs::SECURITY_TYPE_##x
@@ -277,7 +279,7 @@ struct GeneralMarketDataListener::PImpl {
const bool use_given_sec_key = false;
const std::string cc_name_prefix = "cc_security";
size_t n_bk_updates = 0;
bts::persistence::IDGenerator *id_gen;
std::shared_ptr<IDGenerator> id_gen;
std::shared_ptr<GeneralSecurityIndex> index;
std::shared_ptr<MDProducer> md_producer;
const std::shared_ptr<bts::orderman::SimExecutionGateway> sim_ex_gwy =
@@ -296,8 +298,8 @@ struct GeneralMarketDataListener::PImpl {
std::shared_ptr<GeneralSecurityIndex> index,
std::shared_ptr<MDProducer> md_producer,
std::shared_ptr<bts::orderman::SimExecutionGateway> sim_ex_gwy,
bts::persistence::IDGenerator *sec_id_store)
: venue(venue), id_gen(sec_id_store), index(std::move(index)),
std::shared_ptr<IDGenerator> sec_id_store)
: venue(venue), id_gen(std::move(sec_id_store)), index(std::move(index)),
md_producer(std::move(md_producer)),
sim_ex_gwy(std::move(sim_ex_gwy)) {
if (this->sim_ex_gwy != nullptr) {
@@ -353,7 +355,7 @@ GeneralMarketDataListener::GeneralMarketDataListener(
std::shared_ptr<GeneralSecurityIndex> index,
std::shared_ptr<MDProducer> md_producer,
api::Venue venue,
persistence::IDGenerator *sec_id_store)
std::shared_ptr<IDGenerator> sec_id_store)
: me(std::make_unique<PImpl>(
domain::DomainSecurityUtils::convert(venue),
index,
@@ -20,7 +20,7 @@ class GeneralMarketDataListener : public IMarketDataListener {
std::shared_ptr<GeneralSecurityIndex> index,
std::shared_ptr<MDProducer> md_producer,
api::Venue venue,
persistence::IDGenerator *sec_id_store);
std::shared_ptr<persistence::IDGenerator> sec_id_store);
virtual ~GeneralMarketDataListener();
void on_securities(const std::vector<domain::Security const *>
&complete_security_list) override;