Fixing the issue were fractional fills on a working order could result in overfills being reported (it was only a reporting issue)
This commit is contained in:
1 parent
6fcaf07df0
commit
4ee595cdaf
1 file changed
+8
-4
@@ -114,13 +114,17 @@ void OrderStore::on_order_state_update(
|
||||
rec.set_key(ev.key.value());
|
||||
rec.set_parent_key(ev.parent_key.value());
|
||||
modified_orders.insert(ev.key);
|
||||
if (rec.has_state())
|
||||
rec.mutable_state()->MergeFrom(ev.rebuild_state());
|
||||
else {
|
||||
if (rec.has_state()) {
|
||||
rec.mutable_state()->CopyFrom(ev.rebuild_state());
|
||||
// if filled qty went from 0.99 -> 1, it was copying the int part and not clearing the fraction part,
|
||||
// so changing MergeFrom to CopyFrom
|
||||
} else {
|
||||
*rec.mutable_state() = ev.rebuild_state();
|
||||
*rec.mutable_state()->mutable_created() = utils::pb::pb_now();
|
||||
}
|
||||
*rec.mutable_state()->mutable_last_change() = utils::pb::pb_now();
|
||||
LOG(OrderMan, Info, "OrderStore::on_order_state_update k: {} rec: {}",
|
||||
ev.key, utils::pb::to_string(rec));
|
||||
}
|
||||
store_and_publish_if_complete(modified_orders);
|
||||
}
|
||||
@@ -149,7 +153,7 @@ void OrderStore::store_and_publish_if_complete(
|
||||
auto &rec_info = me->known_orders[k];
|
||||
auto &rec = rec_info.rec;
|
||||
if (rec.has_def() && rec.has_state()) {
|
||||
LOG(OrderMan, Diag,
|
||||
LOG(OrderMan, Info,
|
||||
"OrderStore::store_and_publish_if_complete rec: {}",
|
||||
utils::pb::to_string(rec));
|
||||
publish(me->order_stream, rec);
|
||||
|
||||
Reference in new issue
Block a user