refactor: Move OrderBuilder defs to cpp file
So impl deps don't leak into the sdk through headers
This commit is contained in:
1 parent
0302c44fc0
commit
12f0f59f70
2 files changed
+105
-97
No files matched your search
@@ -1,8 +1,91 @@
|
||||
#include "OrderBuilder.h"
|
||||
|
||||
namespace bts {
|
||||
namespace orderman {
|
||||
namespace bts::orderman {
|
||||
|
||||
using bts::api::orderman::OrderDefinition;
|
||||
using std::size_t;
|
||||
|
||||
std::atomic<size_t> OrderBuilder::_current_builder_id(0);
|
||||
|
||||
OrderBuilder::OrderBuilder()
|
||||
: _parent_key(null_order_key()), _definition(), _reserve_sz(0),
|
||||
_order_stash(), _builder_id(), _order_services(nullptr) {}
|
||||
|
||||
OrderBuilder::OrderBuilder(OrderBuilder &&src) { operator=(std::move(src)); }
|
||||
|
||||
OrderBuilder::OrderBuilder(
|
||||
OrderKey parent_key,
|
||||
OrderDefinition const &def,
|
||||
IOrderFactory &factory,
|
||||
size_t reserve_sz)
|
||||
: _parent_key(parent_key), _definition(def), _reserve_sz(reserve_sz),
|
||||
_order_stash(), _builder_id(++_current_builder_id),
|
||||
_order_services(nullptr)
|
||||
|
||||
{
|
||||
bts_assert(parent_key != null_order_key());
|
||||
while (_order_stash.size() != reserve_sz)
|
||||
_order_stash.push_back(&factory.create(parent_key, _definition));
|
||||
}
|
||||
} // namespace bts
|
||||
|
||||
OrderBuilder::OrderBuilder(
|
||||
OrderKey parent_key,
|
||||
bts::api::orderman::OrderDefinition const &def,
|
||||
std::size_t reserve_sz)
|
||||
: _parent_key(parent_key), _definition(def), _reserve_sz(reserve_sz),
|
||||
_order_stash(), _builder_id(++_current_builder_id),
|
||||
_order_services(nullptr) {
|
||||
bts_assert(parent_key != null_order_key());
|
||||
}
|
||||
|
||||
bool OrderBuilder::is_activated() const { return _order_services != nullptr; }
|
||||
|
||||
void OrderBuilder::activate(OrderServices &order_services) {
|
||||
bts_assert(!_order_services);
|
||||
_order_services = &order_services;
|
||||
_order_services->subscribe_to_order_creation_reply(
|
||||
_builder_id, [this](auto const &order_ev) {
|
||||
_order_stash.insert(
|
||||
_order_stash.end(), order_ev.orders.begin(),
|
||||
order_ev.orders.end());
|
||||
});
|
||||
}
|
||||
|
||||
ChildOrder OrderBuilder::build() {
|
||||
bts_assert_msg(
|
||||
_order_services,
|
||||
"OrderBuilder::activate() must be called before orders can be built");
|
||||
|
||||
ChildOrder result;
|
||||
if (_order_stash.size()) {
|
||||
result = ChildOrder(*_order_stash.back(), *_order_services);
|
||||
_order_stash.pop_back();
|
||||
} else {
|
||||
LOG(OrderMan, Warn,
|
||||
"Ran out of pre-allocated child orders for order {}. Will "
|
||||
"allocate directly. "
|
||||
"This will have an impact on performance",
|
||||
_parent_key);
|
||||
result = ChildOrder(
|
||||
_order_services->order_factory().create(_parent_key, _definition),
|
||||
*_order_services);
|
||||
}
|
||||
if (_reserve_sz > _order_stash.size()) {
|
||||
auto need = _reserve_sz - _order_stash.size();
|
||||
_order_services->send_order_create_req(
|
||||
_builder_id, _parent_key, _definition, need);
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
OrderBuilder &OrderBuilder::operator=(OrderBuilder &&src) {
|
||||
move_here(src);
|
||||
return *this;
|
||||
}
|
||||
|
||||
OrderServices &OrderBuilder::services() {
|
||||
bts_assert(_order_services != nullptr);
|
||||
return *_order_services;
|
||||
}
|
||||
|
||||
} // namespace bts::orderman
|
||||
@@ -1,123 +1,48 @@
|
||||
#pragma once
|
||||
|
||||
#include "lib/api/services/OrderService.pb.h"
|
||||
#include "lib/logging/logging.h"
|
||||
#include "lib/orderman/ChildOrder.h"
|
||||
#include "lib/orderman/OrderServices.h"
|
||||
#include "lib/orderman/orderman_utils/orderman_common.h"
|
||||
#include <atomic>
|
||||
#include <memory>
|
||||
|
||||
namespace bts {
|
||||
namespace orderman {
|
||||
#include <atomic>
|
||||
|
||||
namespace bts::orderman {
|
||||
|
||||
class OrderBuilder {
|
||||
public:
|
||||
OrderBuilder()
|
||||
: _parent_key(null_order_key()), _definition(), _reserve_sz(0),
|
||||
_order_stash(), _builder_id(), _order_services(nullptr) {}
|
||||
|
||||
OrderBuilder(OrderBuilder &&src) { operator=(std::move(src)); }
|
||||
OrderBuilder();
|
||||
OrderBuilder(OrderBuilder &&src);
|
||||
|
||||
OrderBuilder(
|
||||
OrderKey parent_key,
|
||||
api::orderman::OrderDefinition const &def,
|
||||
IOrderFactory &factory,
|
||||
size_t reserve_sz = 1)
|
||||
: _parent_key(parent_key), _definition(def), _reserve_sz(reserve_sz),
|
||||
_order_stash(), _builder_id(++_current_builder_id),
|
||||
_order_services(nullptr)
|
||||
|
||||
{
|
||||
bts_assert(parent_key != null_order_key());
|
||||
while (_order_stash.size() != reserve_sz)
|
||||
_order_stash.push_back(&factory.create(parent_key, _definition));
|
||||
}
|
||||
size_t reserve_sz = 1);
|
||||
|
||||
OrderBuilder(
|
||||
OrderKey parent_key,
|
||||
api::orderman::OrderDefinition const &def,
|
||||
size_t reserve_sz = 1)
|
||||
: _parent_key(parent_key), _definition(def), _reserve_sz(reserve_sz),
|
||||
_order_stash(), _builder_id(++_current_builder_id),
|
||||
_order_services(nullptr)
|
||||
size_t reserve_sz = 1);
|
||||
|
||||
{
|
||||
bts_assert(parent_key != null_order_key());
|
||||
}
|
||||
OrderBuilder &operator=(OrderBuilder &&src);
|
||||
|
||||
bool is_activated() { return _order_services != nullptr; }
|
||||
|
||||
void activate(OrderServices &order_services) {
|
||||
bts_assert(!_order_services);
|
||||
_order_services = &order_services;
|
||||
_order_services->subscribe_to_order_creation_reply(
|
||||
_builder_id, [this](auto const &order_ev) {
|
||||
_order_stash.insert(
|
||||
_order_stash.end(), order_ev.orders.begin(),
|
||||
order_ev.orders.end());
|
||||
});
|
||||
}
|
||||
|
||||
ChildOrder build() {
|
||||
bts_assert_msg(
|
||||
_order_services,
|
||||
"OrderBuilder::activate() must be called before orders can be built");
|
||||
|
||||
ChildOrder result;
|
||||
if (_order_stash.size()) {
|
||||
result = ChildOrder(*_order_stash.back(), *_order_services);
|
||||
_order_stash.pop_back();
|
||||
} else {
|
||||
LOG(OrderMan, Warn,
|
||||
"Ran out of pre-allocated child orders for order {}. Will "
|
||||
"allocate directly. "
|
||||
"This will have an impact on performance",
|
||||
_parent_key);
|
||||
result = ChildOrder(
|
||||
_order_services->order_factory().create(_parent_key, _definition),
|
||||
*_order_services);
|
||||
}
|
||||
if (_reserve_sz > _order_stash.size()) {
|
||||
auto need = _reserve_sz - _order_stash.size();
|
||||
_order_services->send_order_create_req(
|
||||
_builder_id, _parent_key, _definition, need);
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
OrderBuilder &operator=(OrderBuilder &&src) {
|
||||
move_here(src);
|
||||
return *this;
|
||||
}
|
||||
|
||||
OrderServices &services() {
|
||||
bts_assert(_order_services != nullptr);
|
||||
return *_order_services;
|
||||
}
|
||||
bool is_activated() const;
|
||||
void activate(OrderServices &order_services);
|
||||
ChildOrder build();
|
||||
OrderServices &services();
|
||||
|
||||
private:
|
||||
void move_here(OrderBuilder &src) {
|
||||
_order_services = src._order_services;
|
||||
_parent_key = src._parent_key;
|
||||
_definition = src._definition;
|
||||
_reserve_sz = src._reserve_sz;
|
||||
_order_stash = src._order_stash;
|
||||
_builder_id = src._builder_id;
|
||||
src._order_stash.clear();
|
||||
src._builder_id = 0;
|
||||
src._order_services = nullptr;
|
||||
bts_assert(_parent_key != null_order_key());
|
||||
}
|
||||
static std::atomic<std::size_t> _current_builder_id;
|
||||
|
||||
OrderKey _parent_key;
|
||||
api::orderman::OrderDefinition _definition;
|
||||
size_t _reserve_sz;
|
||||
bts::api::orderman::OrderDefinition _definition;
|
||||
std::size_t _reserve_sz;
|
||||
std::vector<Order *> _order_stash;
|
||||
size_t _builder_id;
|
||||
std::size_t _builder_id;
|
||||
OrderServices *_order_services;
|
||||
|
||||
static std::atomic<size_t> _current_builder_id;
|
||||
void move_here(OrderBuilder &src);
|
||||
};
|
||||
|
||||
} // namespace orderman
|
||||
} // namespace bts
|
||||
} // namespace bts::orderman
|
||||
Reference in new issue
Block a user