The slight convenience afforded by this opt doesn't seem worth the
additional complexity. This script produces a self-contained application
folder. Decisions on what to do with that folder (whether or not to zip
it, etc.) are best left upstream.
Clean up the web build process a bit while we're at it
* Add 'custom_commands' to run npm install in CMakeLists
* Generate tsconfig files for CMake preset configurations
* Rename local variables to _snake_case in CMakeLists
Previously, the virtual environment was activated in the Proto3 build target.
Since the proto3 build target is executed once per proto file, and 91 proto
files are processed during the client cs build, this added significant time to
the build. For example, on [John's]my laptop, activating the venv takes ~0.15s,
which amounts to ~9.55 secs per build.
Otherwise cmake picks 'cc' by default
Bugs (fixed):
* Sparkd crashes due to strange runtime error related to multithreaded access
of std::promise in clang builds
The sole purpose of the buildspark_redirect script is to workaround a bug in
the vscode c# extension. Unfortunately some buggy behavior persists when these
dirs are symlinked.
A lot of server-side changes were just merged as part of the Brandon
project (crypto). Many of those changes were in libspark (a lib on
which both the client and server depend), and upgrades to its external
dependencies. As a result, windows counterparts of several upgraded
external libs needed to be similarly upgraded (or added for the first
time). These libs include: boost, btree, catch, curl, fmt, nlohmann json,
openssl, range, rxcpp, websocketpp
This change also makes protobuf generation compatible with python3, and thus
eliminates the build's dependency on python2
For some reason, the build fails when the output dir is referenced by the c#
extension in vscode. It produces errors saying various g.cs files (which are
generated for the spark csproj) could not be found. However, examining the
contents of the output directory after the build "fails" show that those files
exist, and are in the proper build subdirectory. Seems like a race.