There was a typo when determining "deletes" and "undeletes" on synth
changes (i.e., when deleted changes false -> true, and true-> false
respectively).
This new structure provides several benefits:
* Allows us to install multiple CMake projects in the same destination
dir (without include path conflicts).
- This makes shipping the trading algo sdk a trivial excercise. Simply
copy the lib and include dirs from the install dest. That's it!
* Puts us in a position to break up the monolithic libspark into smaller
modules, which are easier to manage.
Windows specific notes:
* Get rid of unnecessary script vs_filters.cmake
* Define WebsocketConnectionGateway directly in cs (instead of proto)
- The proto would no longer be in the include path passed to protoc.
Moving it to c# because there wasn't a compelling reason for it to
be a proto in the first place.
* Set spark output prefix to "lib" on windows
- So we get "libspark.dll" instead of "spark.dll", which conflicts
with the csharp lib, "Spark.dll".
* Copy libspark.dll to net8.0 & net8.0-windows in a single cmake build
target
fix build: Copy libspark to both dirs net8.0, net8.0-windows
Previously, animations were expressed through polymorphism (derived from the
base class CellAnimation), but the new impl uses composition. This 'OfType' call
was leftover from the polymorphism implementation, an attempt to linq cast
elements of base class (CellAnimation) to BackgroundAnimation.
Previously, the Subscribe impl only bootstrapped the first observer
(i.e., only in first call to Subscribe).
Bugs (fixed):
* The ladder crashes if there are working orders when the
ticks-per-row setting is changed.
Cause: The ladder viewmodel resubscribes to order updates each time
the ticks per row setting changes (as this determines the size of
the price buckets into which orders are grouped). The IObservable
"Bootstrap" extension fn doesn't properly clean up state leftover
from the previous subcsription when this happens.
This addresses a subtle inconsistency in the pnl window.
The old "start_pnl" and "day_pnl" values (from IPNLUnit) are computed
with respect to the mid market for both long and short positions, while
the new "unrealized" pnl values are computed with respect to the side of
the market needed to close the position (i.e., bid market for long pos,
ask for short). Consequently, the combined pnl columns weren't equal to
the sum of realized and unrealized pnl.
When looking at avg cost, you often really want to know the difference
between it and the current market. These columns provide that information
so you don't need to do the arithmetic in your head.
Bugs (fixed):
* Sometimes mview shows that a security has working orders when it
doesn't. It appears to be rounding-related as the price and qty of
the phony working orders is NaN and 0, respectively.
Cause: Rounding error accumulates in the order summarizer. If it gets
bad enough, the working quantity (which is computed incrementally as
orders transition to/from a working state) may still be non-zero after
all orders become non-working.