Bugs (fixed):
* Ladder assert-crashes when rendering volume-at-price
Cause: The render routine expected items to be sorted by price, and
asserted as much (indirectly). In hindsight, this expectation placed
an unnecessary burden on the caller.
Bugs (fixed):
* The Activity Log window crashes immediately opened.
Cause: WPF throws an Exception because it fails to resolve the
StaticResources 'TextBox.BackgroundBrush', and
'TextBox.ForegroundBrush', as they are defined in Colors.xaml, which
is not imported by LogViewer.xaml.
I replaced the StaticResources w/ BTSColor extension (rather than
include Colors.xaml), because it is less error prone, and allows us
to keep colors organized in 1 place: BTSColors.cs.
I'm not sure how long the bug was around. It likely slipped through
the cracks because the ActivityLog window isn't used often.
Bugs (fixed):
* The PNL Summary window throws a null ref ex when the first row is
populated.
Cause: The SecurityMetadataImmutable's internal QuantityDisplay is
null. In other words, the mutable SecurityMetadata obj around which
it wraps has a null QuantityDisplay, which is not allowed since
Immutable protos (such as 'QuantityDisplayImmutable') must be
constructed w/ a non-null instance of their mutable counterpart.
* Implement same fix (pre-emptively) in ManualFillRow, and
OrderCompletedEventPredicate.
Bugs (fixed):
* The InterpTheosServerPublisher throws a null ref during startup when it
accesses 'UsageList' from the VolSurfaceUsageTag data.
Cause: Immutable protos instantiated w/ the default ctr have an
invalid state, because the mutable (reference type) instance around
which they wrap is null. Since an immutable type's props are trivial
wrappers for this mutable instance, they throw a null ref if the
mutable instance is null.
Bugs (fixed):
The render routine was indirectly asserting that each item's price was
>= the ladder's min price. That seems like an inappropriate burden to
put on the caller. Now we filter these items out in the routine.
Bugs (fixed):
* My Windows module popup is always empty
Cause: The list of favorite windows is only evaluated on startup
(before the list has been properly initialized). Furthermore, even
if the list was initialized, it must be re-evaluated to account for
newly added/removed windows.
Prior to this commit, proto files were added to csprojs via the Proto3
target. This target generated 4 files per proto:
.cs, .immutable.cs, .client.pb.cs, and server.pb.cs
For the (many) proto files that don't define services (just normal messages),
the .client/server.pb.cs files were unnecessary.
This commit splits proto-generation into 2 targets:
* ProtoService - same as the old 'Proto3' target (generates 4 files per
proto as described above).
* Proto - a new target that generates only .cs, and .immutable.cs files