John Colvin
c5b79b3dae
chore: Define common IUniqueID member impls in interface
...
Taking advantage of nifty new language feats
2023-08-22 11:35:41 -04:00
John Colvin
d26b818939
build: Copy libspark to dotnet bin dirs in CMakeLists
2023-08-22 01:29:45 -04:00
John Colvin
b2d5ab5e03
chore: Add SyntheticSecurityClient to WebsocketDataSync
...
TODO (Arham): Integrate SyntheticSecurityClient w/ the websocket api
2023-08-21 15:35:03 -04:00
John Colvin
c3e098e27d
feat: Add SyntheticSecurityClient (for websocket api)
2023-08-21 15:05:37 -04:00
John Colvin
a930d2165a
refactor: Move SyntheticTuple to spark_api proj
...
Also clean struct up a bit and rename 'SyntheticSecurityTuple'
2023-08-21 15:05:37 -04:00
John Colvin
05cdfce9ce
fix: Add null checks to account for bad analytics exp params
...
The Spark client was throwing null ref exs after merging prod to
developement, likely because the param protos stored in db were invalid.
2023-08-11 11:42:29 -04:00
John Colvin
61c9d6b2d6
fix build: Sand rough edges after merge
2023-08-05 00:09:16 -04:00
John Colvin
7545d3fd5c
Merge remote-tracking branch 'origin/spark_crypto.prod' into development
2023-08-04 13:40:04 -04:00
John Colvin
04e0297e86
refactor: Simplify 'render_piq' by using common code
...
No need to re-invent the 'render_cells' wheel
2023-07-31 14:50:44 -04:00
John Colvin
562706b968
fix: Don't assume ladder row-data is sorted by price
...
Bugs (fixed):
* Ladder assert-crashes when rendering volume-at-price
Cause: The render routine expected items to be sorted by price, and
asserted as much (indirectly). In hindsight, this expectation placed
an unnecessary burden on the caller.
2023-07-31 14:20:08 -04:00
John Colvin
4195207a71
fix: Replace non-existent StaticResource w/ BTSColor
...
Bugs (fixed):
* The Activity Log window crashes immediately opened.
Cause: WPF throws an Exception because it fails to resolve the
StaticResources 'TextBox.BackgroundBrush', and
'TextBox.ForegroundBrush', as they are defined in Colors.xaml, which
is not imported by LogViewer.xaml.
I replaced the StaticResources w/ BTSColor extension (rather than
include Colors.xaml), because it is less error prone, and allows us
to keep colors organized in 1 place: BTSColors.cs.
I'm not sure how long the bug was around. It likely slipped through
the cracks because the ActivityLog window isn't used often.
2023-07-28 14:16:46 -04:00
John Colvin
71eb89b6a1
fix: Check 'HasQuantityDisplay' before accessing prop
...
Bugs (fixed):
* The PNL Summary window throws a null ref ex when the first row is
populated.
Cause: The SecurityMetadataImmutable's internal QuantityDisplay is
null. In other words, the mutable SecurityMetadata obj around which
it wraps has a null QuantityDisplay, which is not allowed since
Immutable protos (such as 'QuantityDisplayImmutable') must be
constructed w/ a non-null instance of their mutable counterpart.
* Implement same fix (pre-emptively) in ManualFillRow, and
OrderCompletedEventPredicate.
2023-07-28 14:01:57 -04:00
John Colvin
94e4a0b725
fix: Change bus data type to nullable immutable
...
Bugs (fixed):
* The InterpTheosServerPublisher throws a null ref during startup when it
accesses 'UsageList' from the VolSurfaceUsageTag data.
Cause: Immutable protos instantiated w/ the default ctr have an
invalid state, because the mutable (reference type) instance around
which they wrap is null. Since an immutable type's props are trivial
wrappers for this mutable instance, they throw a null ref if the
mutable instance is null.
2023-07-28 12:02:50 -04:00
John Colvin
40d1fe20e3
diag: Add detailed error logs to notification serv order handler
...
Maintain a circular buffer of the last N updates. Then if/when an
exception occurs, log the update sequence that led up to it.
2023-07-26 15:30:55 -04:00
John Colvin
0b35c2ccde
fix: Add lock, try/catch in notification serv order handler
...
Brandon has been experiencing a crash on startup. The stack trace shows
this handler is throwing a duplicate-key ex on 'dictionary.Add' (unclear
why).
2023-07-26 00:55:50 -04:00
John Colvin
98eea0ef09
chore: Remove unused iface member
2023-07-26 00:13:22 -04:00
John Colvin
4bf237aebe
fix (pre-emptive): Guard against null/empty prices in LadderRender
2023-07-25 14:27:13 -04:00
John Colvin
da927adef4
fix: Check price is within ladder's range before rendering
...
Bugs (fixed):
The render routine was indirectly asserting that each item's price was
>= the ladder's min price. That seems like an inappropriate burden to
put on the caller. Now we filter these items out in the routine.
2023-07-25 14:24:16 -04:00
John Colvin
cf587e26d5
fix: Remove bad assert abt tickdiff in LadderRender
...
* The test condition was wrong in the first place
* Instead of assert/crashing, log a warning
2023-07-25 14:22:15 -04:00
Taha
b07a1e2c74
Fixing the issues, where the theos are only published out by the vol surface owner
2023-07-18 20:40:59 -04:00
Taha Afzal
8376fce5fe
Merge branch 'spark_crypto.prod.vol_order' into spark_crypto.prod
2023-07-14 17:01:29 +00:00
Taha Afzal
d9e5c846c2
Adding more logs to VolAlgo
2023-07-14 16:57:55 +00:00
Taha Afzal
65736c13ef
VolAlgo completed
2023-07-14 03:54:14 +00:00
Taha Afzal
071c28e925
VolAlgo reflects its state correctly now
2023-07-10 03:20:05 +00:00
Taha Afzal
8355e3e1be
VolAlgo code complete - need to test
2023-07-09 04:21:42 +00:00
John Colvin
f9a6e0963c
chore: Remove Spark.Admin.WebApp
...
These files were added by accident (leftover from switching branches
from development -> spark_crypto.prod)
2023-07-06 14:52:57 +00:00
John Colvin
0d03ddb009
Merge remote-tracking branch 'origin/spark_crypto.prod' into spark_crypto.tick_hotfix
2023-07-06 12:26:28 +00:00
John Colvin
a6dfa4ae80
fix: Don't show decimal BTC Futs/Spd qtys
...
They tick in multiples of 10, so decimal precision isn't needed
2023-07-05 18:20:53 -04:00
John Colvin
e66ec82ba8
hotfix: Setup default cfg for new Deribit price ticks
2023-07-05 18:19:49 -04:00
John Colvin
9ce5e971c6
fix: Fix typos in BTSColor paths in xaml
2023-07-05 18:11:40 -04:00
John Colvin
3e7cc49ebb
hotfix: Format text w/ RegionalTickFactors in PriceEntryControl
2023-07-05 18:11:40 -04:00
John Colvin
d07e68b6e2
hotfix: Use 1st leg's min price tick rule for Deribit combos
2023-07-05 18:11:40 -04:00
John Colvin
619ece2313
refactor: Consolidate impl for 'round_to_tick' overloads
...
Also add a 'decimal' overload for RegionalTickFactors. This is more work
for Deribit tick hotfix.
2023-07-05 18:11:40 -04:00
John Colvin
1dda9566f3
hotfix: Use '.' separator if tick unit is multiple of base
2023-07-05 18:11:06 -04:00
Taha
3704d1ed16
InterptheosServerPublisher is now opulated the newly added vol field in the PrecomputedTheoPoint proto
2023-07-05 14:41:31 -04:00
John Colvin
a524ca02a5
refactor: Change tick arithmetic to use int64
...
The tick count is "price / tick_size" and tick_size is usually < 1, so
the extra bits may be needed to avoid arithmetic overflow
2023-07-05 12:02:28 -04:00
John Colvin
3c97f2552b
fix build: Don't use libfmt or ranges in win cpp
...
I can't deal with this anymore. My build is suddenly broken on Windows
(for spark_crypto.prod branch). I assume they updated the compiler
in a way that isn't backwards compatible. Thanks Windows.
2023-07-05 11:58:14 -04:00
John Colvin
15b1d55ef1
fix build: Disable Binance md code on win
2023-07-05 11:58:14 -04:00
John Colvin
4e42c9f01b
test: Refactor tick tests for RegionalTickFactors
...
Gives us some peace of mind about the dynamic ticks hotfix for Deribit
2023-07-05 11:58:14 -04:00
John Colvin
76775f821a
hotfix: Support dynamic ticks in order ticket
2023-07-05 11:58:14 -04:00
John Colvin
e7088f6b1c
hotfix: Support dynamic ticks in ladder
...
Deribit now provides dynamic price ticks (a list of ticks per range).
https://www.deribit.com/kb/4-july-2023
https://www.deribit.com/kb/deribit-on-screen-options-tick-size-reduction
2023-07-05 11:58:14 -04:00
Taha Afzal
f2c3ff4be6
Adding vol to PrecomputedTheoPoint
2023-07-05 15:16:45 +00:00
Taha
1fb42ade59
Adding perf logs on the front end
2023-07-05 10:50:13 -04:00
Taha
129650e9d4
Only the skew owner publishes theos to the server
2023-07-05 10:50:13 -04:00
John Colvin
170a44ac04
fix: Check sign to tick in correct direction
...
Don't assume it's positive and blindly tickup
2023-07-03 22:34:46 -05:00
Taha Afzal
7e04f02327
Merge branch 'spark_crypto.prod.autofit' into spark_crypto.prod
2023-07-04 03:21:28 +00:00
Taha Afzal
abda2dbf97
VolSurfaces and achived theo history size is not mantained at runtime
2023-07-04 03:13:46 +00:00
Taha Afzal
ad1a45cf49
ArchivedTheos are truncated on a server start
2023-07-04 03:13:46 +00:00
John Colvin
e9abdd0ff2
chore: Remove unused fn 'gen_prices'
2023-07-03 12:30:03 -05:00
John Colvin
9254002318
fix: Check HasPrice/QuantityDisplay before accessing prop
2023-07-03 12:24:20 -05:00