Commit Graph
12092 Commits
Author SHA1 Message Date
John Colvin 7fb411adce Add SparkLoggerAdapter for Msft ILogger 2024-11-25 15:26:59 +00:00
John Colvin cac881ea1b Display exception stack trace w/ 1 call per line in ds webapp 2024-11-25 15:26:59 +00:00
John Colvin 07a72f6943 Remove unused ErrorView from ds webapp 2024-11-25 15:26:59 +00:00
John Colvin b6f64b4804 Propagate ViewStream errors to webapp frontend 2024-11-25 15:26:58 +00:00
John Colvin fa5cc6ab38 Add ErrorChanged event to propagate DataStream exceptions 2024-11-25 15:26:58 +00:00
John Colvin 664424c91c Set columns to empty array rather than null in ds webapp
If no data has been received. Since the 'columns' property was marked
'required', this eliminates a warning that was being logged to console.
2024-11-25 15:26:58 +00:00
John Colvin 0b463f4e65 Improve alignment/spacing in ds webapp 2024-11-25 15:26:58 +00:00
John Colvin ea0f1153e4 Configure datastream deployment with docker-compose
To deploy to aws, connect to our aws vpn then run:
tools/deploy-docker-compose.sh

The deploy script does the following:
* builds sparkd
* builds datastream apps (pubsub, md-publisher, and webapp)
* uploads the build to aws
* bounces all services (sparkd, pubsub, md-publisher, and webapp)

Note: the name 'md-publisher' refers to DataStreamPublisher w/ MarketData
configuration
2024-11-25 15:26:58 +00:00
John Colvin ff4bab71f3 Remove "BTS Cloud Streams" title from webapp
Space is precious when viewing on phone (tbh, it didn't look that good
anyways).
2024-11-25 15:26:58 +00:00
John Colvin c1fdc2e8be fix: Ensure md-publisher waits for pubsub and sparkd
Bugs (fixed):
  * md-publisher silently fails if it tries to connect before those services are "ready".

The Docker compose "depends_on" property ensures sparkd and pubsub
containers are up, but doesn't prevent startup race bugs (e.g., if
md-publisher and pubsub start around the same time, and md-publisher
tries to connect before pubsub has started accepting connections). To
address these race conditions, we use a nifty tool called "dockerize"

References:
  * https://github.com/jwilder/dockerize
2024-11-25 15:26:58 +00:00
John Colvin 2ddb12212f Replace ErrorView component w/ robust QueryStatusView 2024-11-25 15:26:58 +00:00
John Colvin 06c694ea8a Fix typos in query button theme 2024-11-25 15:26:58 +00:00
John Colvin 2cdea43eb5 fix: Don't assert on exception in BooleanExpression.evaluate
Bugs (fixed):
  * DataStream WebApp Server sometimes crashes when the user enters a
    bad query.
2024-11-25 15:26:58 +00:00
John Colvin 10f105d48d Change VITE_DATASTREAM_WEBSOCKET_URL to localhost 2024-11-25 15:26:58 +00:00
John Colvin fb69e75019 Assert that local ip address is successfully obtained 2024-11-25 15:26:58 +00:00
John Colvin d3736df90f improvement: Resolve hostnames when comparing ip addrs
So we can to configure pubsub routes by hostname or ipv4 (ipv6 hasn't been
tested yet...so we should assume it doesn't work).
2024-11-25 15:26:58 +00:00
John Colvin 337828ff62 Assert TcpConnection endpoint matches expected 2024-11-25 15:26:58 +00:00
John Colvin 6ba4354e4c Fix typo in log msg (was missing interpolation '$') 2024-11-25 15:26:58 +00:00
John Colvin c5830493fe Catch exceptions on AsyncTCPConnector_AsyncWrapper background thread
Since it spawns a new thread on each attempt, uncaught exceptions were previously undetected,
and caused silent failures down the pipe. This should make it easier to track such bugs down.
2024-11-25 15:26:58 +00:00
John Colvin 87c72d43dc fix: Format PubSubRoute as json in log msgs
It was previously using the default ToString, which simply returns the type name
2024-11-25 15:26:58 +00:00
John Colvin 47e70272d2 build: Upgrade packages (deps) in DataStreamTests 2024-11-25 15:26:58 +00:00
John Colvin d04d711706 cleanup: Remove unused ViewStreamDatabase config 2024-11-25 15:26:58 +00:00
John Colvin 5606e690e6 Configure apps as a distributed system via Docker compose 2024-11-25 15:26:58 +00:00
John Colvin 8f50979f90 Remove reference to spark protobuf Config in ViewStream
We can't read spark protobuf Config until it has been initialized,
and since ViewStream doesn't have the configServer param handy it
isn't able to initialize config if necessary. In that case, it would simply
block until config was initialized by someone else. Such a risk doesn't
seem justified for this particular configuration dependency
(DataStreamConfig.UseUncopiedNewRowsInFire). For now, its hardcoded to false.
2024-11-25 15:26:58 +00:00
John Colvin 61e61e8bb8 refactor: Run RemoteQueryManager as an IHostedService
This paradigm more accurately represents the RemoteQueryManager as a
Service that can be started/stopped.
2024-11-25 15:26:58 +00:00
John Colvin b4baefb802 Remove inappropriate "Unable to dispose subscription" log msg 2024-11-25 15:26:58 +00:00
John Colvin 40c09084bd fix: Ensure spark config init and login are only performed once
As a static function that could be called from anywhere in the code
(directly or indirectly), 'Configuration.Initialize' was vulnerable to
race bugs. The "Configuration.get<T>()" method, whose calls are
ubiquitous in our code, would initialize config if it hadn't been done
so already. Without a reference to the configServer param, this param
would effectively be ignored/overridden with null.

It's important that login only be performed once, for obvious reasons
(our exes that connect to sparkd are generally designed to process data
for a single user). Furthermore, not every routine that requires a
successful login has a reference to the credentials needed to do it. To
address this, we now pass the ISparkdLoginService singleton to these
routines so they can wait until the singular login task has completed
before they begin.
2024-11-25 15:26:58 +00:00
John Colvin c0d622a02b Move misplaced log abt initializing query text to appropriate place 2024-11-25 15:26:58 +00:00
John Colvin 99a17a81ff Assert ViewStreamDatabase.instance is only created once
The instance must be initialized via ViewStreamDatabase.SetGlobalInstance
2024-11-25 15:26:58 +00:00
John Colvin 86c40fd487 cleanup: Remove unused code from ViewStreamDatabase 2024-11-25 15:26:58 +00:00
John Colvin e13dcaab58 Include subscription id in ds websocket updates 2024-11-25 15:26:58 +00:00
John Colvin 4532c8644f fix: Define BoooleanConstant before StringConstant
Otherwise the former masks the latter and prevents it from matching
2024-11-25 15:26:58 +00:00
John Colvin cb97978fb0 Log event data in websocket open, close, error callbacks 2024-11-25 15:26:58 +00:00
John Colvin 3a13bb389a refactor: Bring back Material DataGrid
Fix the column resize bugs that made it previously unusable
2024-11-25 15:26:58 +00:00
John Colvin ddf7c89b61 refactor: Improve react webapp state management
* Add queryTextResetTime as part of the CannedQuery state
  (the QueryControl compares the canned query click time with the time of the
  last user input, and applies the text from the most recent change)

* Replace 'isRunning' (bool) with a 'queryState' (string) to reflect the subscription status
  value received from the server. Less indirection this way.

* Replace inappropriate useMemo call w/ useEffect
2024-11-25 15:26:58 +00:00
John Colvin 3078dfda73 cleanup: Get rid of magic const (subscriptionId) in webapp App.jsx 2024-11-25 15:26:58 +00:00
John Colvin 331d906a12 build: Copy configuration profiles to publish dir 2024-11-25 15:26:58 +00:00
John Colvin ef0ffdc243 cleanup: Remove unnecessary deps from csprojs 2024-11-25 15:26:58 +00:00
John Colvin 5dfd2d96b5 fix: Downgrade Microsoft.Extensions.Hosting to 7.0.1
A handful of csprojs were referencing version 8.0.0. Since that version
targets net8.0, I have no idea why it didn't cause the build to fail.
Instead, this framework mismatch led to a mysterious runtime crash with
the following error, despite the dll in question being present in the
build dir:

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Diagnostics.DiagnosticSource, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'.
The system cannot find the file specified.

It is worth noting that this crash would only happen for exes published
as part of the DataStreamSuite.sln with the "--self-contained" flag. For
example, the Bts.DataStreamSuite.Server exe would always fail if
published via:

dotnet publish --configuration Release --sc --framework net7.0 --runtime linux-x64 <DataStreamSuite.sln>
2024-11-25 15:26:58 +00:00
John Colvin d6b3f102de Add HttpsRedirection middleware first in the webapp pipeline
Middleware handlers are invoked in the order in which they are added. Any middleware
that is added before HttpsRedirection may can prevent the request from being redirected.
As of now, only development-specific middleware is added ahead of HttpsRedircetion.
2024-11-25 15:26:58 +00:00
John Colvin 949b0b5b72 build: Copy configuration profiles to build dir
So they are readily available to publish/deploy scripts.
2024-11-25 15:26:58 +00:00
John Colvin 37e2d2ee13 Fix benign typo in Scanner/Parser msbuild targets
The output path referenced a non-existant msbuild metadata prop "RelativeOutputDir"
(the actual prop is called "RelativeDir"). Also, the OutputFile path is relative to the
project dir (the 'MSBuildProjectDir' prop), not the file being included.
2024-11-25 15:26:58 +00:00
John Colvin bfdf6228be fix: Catch exception when creating TcpClient 2024-11-25 15:26:58 +00:00
John Colvin bc408c0c75 fix: Catch WebSocketException in DataStreamSubscription 2024-11-25 15:26:58 +00:00
John Colvin 1486c1185c fix: Add null check to NonIncGroupByStream 2024-11-25 15:26:58 +00:00
John Colvin cb06d07eea fix: Add null check to TableAccumulator2 2024-11-25 15:26:58 +00:00
John Colvin 911347e080 fix: Make SystemSubscriptionMapPublisher threadsafe
The PubSubState.onTagMapChanged event may not be invoked on
the same thread as doWork.
2024-11-25 15:26:58 +00:00
John Colvin a65eaf1cc4 fix: Add null check in TimeBasedFilter.cs 2024-11-25 15:26:58 +00:00
John Colvin fe2235bc8d Reduce task wait/timeout code in AsyncTCPConnector 2024-11-25 15:26:58 +00:00
John Colvin 2417b430fd Add a few canned queries to AwsProd.json for ds webapp 2024-11-25 15:26:58 +00:00