This is a more natural location. Also, it looked weird on the right because the
menu labels aren't fixed width, so the buttons weren't vertically aligned.
This is a prelude to integrating streams into spark. The plan is to use
an ms HostBuilder to instantiate stream services/dependencies alongside
the spark Application object.
This looks like it hasn't been hooked up for years...it would only start
if a stunnel.conf file was detected, which hasn't been around for a very
long time.
So we can create ViewStreams that depend on other services, config, etc.
Previously, the PrimitiveManager relied purely on static construction of
types through reflection.
As a static function that could be called from anywhere in the code
(directly or indirectly), 'Configuration.Initialize' was vulnerable to
race bugs. The "Configuration.get<T>()" method, whose calls are
ubiquitous in our code, would initialize config if it hadn't been done
so already. Without a reference to the configServer param, this param
would effectively be ignored/overridden with null.
It's important that login only be performed once, for obvious reasons
(our exes that connect to sparkd are generally designed to process data
for a single user). Furthermore, not every routine that requires a
successful login has a reference to the credentials needed to do it. To
address this, we now pass the ISparkdLoginService singleton to these
routines so they can wait until the singular login task has completed
before they begin.
These will be useful in stream operators, row indexing, etc:
* AggregateList
* CircularBuffer
* DeltaList
* DictionarySetWrapper
* ImmutableOrderedDictionary
* ImmutableOrderedSet
* IMutableCollectionFacade
- inherits IReadOnlyCollection<T> and ICollection<T>
- throws NotSupportedException in default impls for mutation ops
* IMutableListFacade
- inherits IReadOnlyList<T> and IList<T>
- throws NotSupportedException in default impls for mutation ops
* IndexDependentSelectorList
* MergedSortedList
* OffsetList
* OrderedDictionary
* ReverseArrayList
* SliceList
* StepList
More notes:
* Renames ExceptionAssert.is_valid ExceptionAssert.Index.IsValid.
- Like the 'ExceptionAssert.Argument' class, which provides methods to throw
ArgumentException if a condition isn't satisfied, this class throws
IndexOutOfRange exceptions.
We really need to replace these old non-generic collections with generic ones.
BlueRow's IDictionaryEnumerator implementation iterates over values when passed
to a foreach loop, not key value pairs.
One of the 'securities_incremental' fns was calling back into itself instead of
the other overload. This is a 'preemptive' fix because the problematic code path
wasn't running in practice (though it was a ticking time bomb).
Pnl window settings are stored with the workspace on the server (like all shell
window settings), and may originate from an older version of Spark with a
different set of columns. We shouldn't crash if this happens.
It is initialized from data stored in shared memory (not a normal struct). The
cs build emits a warning because it detects a field that "is never written to
and will always have a default value of 0."
This code hasn't changed for years. It suddenly becoming a warning-as-error is
likely related to a recent Visual Studio update.
Bugs (fixed):
* SettingsPersistenceModel drops items after initial update in filtered
subscriptions.
Cause: The SettingsPersistenceModel subscribe fn only publishes the "added"
items in each update, and omits pre-existing items. From the observer's
perspective, pre-existing items appear deleted.
Binary search is used to add, remove, and change rows in response to
incremental updates. Needless to say, if the rows become unsorted,
everything breaks.
Bugs (fixed):
* The fills window crashes sometimes, possibly related to client
reconnecting to server.
Cause: This was a 2 part bug.
1) Changes to existing rows are applied BEFORE the new sort index
is determined via binary search. If the change affects a
property in the current sorting criteria, the rows could
become unsorted and thus invalidate the binary search.
2) When an existing row is changed so that its new sort index is
greater than its current one, the new index is not decremented
by one (it must be since the row is removed before it is
re-inserted).
There was a typo when determining "deletes" and "undeletes" on synth
changes (i.e., when deleted changes false -> true, and true-> false
respectively).