John Colvin
04251c96b6
ui (pnl): Compute pnl as sum of realized + unrealized
...
This addresses a subtle inconsistency in the pnl window.
The old "start_pnl" and "day_pnl" values (from IPNLUnit) are computed
with respect to the mid market for both long and short positions, while
the new "unrealized" pnl values are computed with respect to the side of
the market needed to close the position (i.e., bid market for long pos,
ask for short). Consequently, the combined pnl columns weren't equal to
the sum of realized and unrealized pnl.
2025-03-24 10:13:24 -04:00
John Colvin
c2d400af1a
fix (pnl ui): Don't overwrite menu display settings w/ defaults
2025-03-24 10:13:24 -04:00
John Colvin
133cc16628
ui: Add menu item to open mview from pnl
...
Populated with the same securities as the pnl window
2025-03-24 10:13:24 -04:00
John Colvin
16f7aede93
fix: Add case for Synthetic sec type in proto conversions
2025-03-24 10:13:24 -04:00
John Colvin
2b9488faff
ui: Make pnl default settings pretty
...
* Make profit (green) and loss (red) easier to read against dark bg
* Hide 'SOD' and 'Day' columns (just show totals)
2025-03-24 10:13:24 -04:00
John Colvin
51b6d592d3
fix (pnl ui): Negate short avg cost when translating to avg price
2025-03-23 15:17:41 -04:00
John Colvin
1eb4ceba0a
ui: Add columns for long/short avg pnl
...
When looking at avg cost, you often really want to know the difference
between it and the current market. These columns provide that information
so you don't need to do the arithmetic in your head.
2025-03-23 15:17:41 -04:00
John Colvin
dbf5cadb44
ui: Add columns for realized/unrealized pnl
2025-03-23 15:17:41 -04:00
John Colvin
90f1bb0851
refactor: Move PNL data types to spark_api csproj
2025-03-23 13:08:46 -04:00
John Colvin
547d83e1b8
cleanup: Remove unused pnl enum WaterfallPriceFlags
2025-03-23 13:08:41 -04:00
John Colvin
d9eff37184
fix: Don't let rounding error accumulate in mview order summarizer
...
Bugs (fixed):
* Sometimes mview shows that a security has working orders when it
doesn't. It appears to be rounding-related as the price and qty of
the phony working orders is NaN and 0, respectively.
Cause: Rounding error accumulates in the order summarizer. If it gets
bad enough, the working quantity (which is computed incrementally as
orders transition to/from a working state) may still be non-zero after
all orders become non-working.
2025-03-15 15:21:56 -04:00
John Colvin
3d055de139
cleanup: Rename _tick_factors -> _qty_tick in mview order summarizer
...
It is specifically for quantity (not price).
2025-03-15 15:21:56 -04:00
John Colvin
648be7dd97
improvement: Don't resort orderbook on every order update
...
This causes performace issues when the orderbook is sufficiently large
(noticeable when around 20k orders).
2025-03-15 15:21:56 -04:00
John Colvin
2cac9affe4
fix: Use consistent price comp in ladder order stream
...
Bugs (fixed):
* The ladder occasionally crashes when orders are changing.
Cause: Subtle differences between the ordinal and equality comparers
made it possible for 2 prices to be considered equal by the former,
and not equal by the latter. Since the ladder indexes orders by
price, a "Key not found" exception could be thrown if the equality
comparer detected a price change that the ordinal comparer did not.
2025-03-15 15:21:55 -04:00
John Colvin
30ff3ba707
Add some null checks in LadderGridHost
2025-03-15 15:21:55 -04:00
John Colvin
9d3afd68aa
ui: Format Perp and Spot exps as "Perp" and "None"
2025-03-15 15:21:55 -04:00
John Colvin
795062864d
fix: Fix typo in permission filter comparison (change == to !=)
...
Bugs (fixed):
* The orderbook and ladder blink/flicker when orders change if logged
in as non-bts user.
Cause: The permission filter acted as if the predicate itself
changed everytime an order changed. As a result, it would fire one
update to cleared all values, then fire another to add items that
pass the "new" predicate.
2025-03-13 10:39:33 -04:00
John Colvin
1ff72e9444
fix (ui): Show fractional order qty in activity log
...
Also fix formatting - change "price @ qty" to "qty @ price"
2025-03-13 10:39:33 -04:00
John Colvin
e13b5066a3
fix: Preserve fractional qty when modifying existing order in ticket
2025-03-13 10:39:33 -04:00
John Colvin
066a0ba693
ui: Use dark theme foreground in mini orderbook, fills popups
...
It was black in a couple places before, making it hard to read.
2025-03-10 14:47:58 -04:00
John Colvin
c2b67b4813
fix: Check for null in orderbook root algo type filter
2025-03-10 14:47:58 -04:00
John Colvin
ecad456a2d
fix: Apply exp filter to popup grids in pnl window
2025-03-10 14:47:58 -04:00
John Colvin
ee53fb854c
ui: Make buy/sell button bg darker in order ticket
...
The buttons looked washed out; too bright, yet pale.
2025-02-20 00:49:59 -05:00
Taha
d36e2d61f6
Fixing PNL for both crypto and non crypto
2025-02-19 19:06:12 -05:00
John Colvin
1eb13028c1
ui: Get qty display settings from md instead of config
2025-02-12 15:59:51 -05:00
John Colvin
424e5ff16b
Get Spark version at runtime via reflection
...
So it doesn't need to be hardcoded per release
2025-02-12 15:59:51 -05:00
Taha
4909944694
Fixing PNL for perps (its base don mid market now)
2025-02-12 11:20:55 -05:00
Mohammad Arham
6a9e8de475
Deployment: Updating version numbers
2025-02-11 05:06:21 +00:00
Taha
d8de211aac
Front end does NOT filter nay CBOE or CME expirations
2025-02-10 17:49:14 -05:00
John Colvin
87394bc60b
ui: Increase Currency col width so filter icon isn't clipped
2025-02-10 15:31:31 -05:00
John Colvin
beba30f65c
fix (ui): Remove temp hack that assumed synth qty always notional
2025-02-10 15:31:31 -05:00
John Colvin
2d58424d8f
ui (mview): Hook up currency filter in vm
...
Make it a discrete values filter (listbox) while we're at it. This seems
more practical than regex.
2025-02-10 15:31:31 -05:00
John Colvin
1c5cbaf60b
Change: Update version to 2.2.4-1
2025-02-08 13:19:41 -05:00
John Colvin
b8de447cfb
fix (pnl ui): Assume rows w/ exp DateTime.MinValue are Spots
...
Not the most elegant fix, but it'll do for now.
Bugs (fixed):
* The Pnl window groups perpetual futures with spots
2025-02-08 13:18:27 -05:00
Mohammad Arham
8bfc2d40f9
Update: V2.2.4 pnl working now
2025-02-08 12:43:13 -05:00
Taha
c09fd71c94
Fixing PNL for spots
2025-02-08 06:55:07 -05:00
Taha
c59ec95460
Sheets and spreadbox theos can now optionally be set to market mid
2025-02-06 17:42:12 -05:00
John Colvin
4625bed8b8
Change: Update version to v2.2.3-1
2025-02-05 17:01:11 -05:00
John Colvin
f18fb332b5
fix (orderbook): Make ColumnKeys enum 64bit
...
We rely on bit flags to indicate "dirty" columns in the vm. Need to do
this now that we have > 31 columns.
2025-02-05 17:01:11 -05:00
John Colvin
8746a6f5ca
fix (orderbook): Refresh Notional Value view when it changes in vm
2025-02-05 16:30:13 -05:00
John Colvin
702d47abb5
fix (orderbook): Fix typos in default settings for Notional Value
2025-02-05 16:29:29 -05:00
John Colvin
bf2a54717c
ui (orderbook): Add Filled Notional Value column
2025-02-05 16:13:34 -05:00
John Colvin
9db779fb25
fix (hack): Assume synth quantities are always notional values
2025-02-05 16:07:07 -05:00
Mohammad Arham
f55ddec708
Add: Vesrion logs to bothserver and client
2025-02-05 09:50:33 -05:00
Mohammad Arham
6e942dd2d4
Change: Updated version to v2.2.3
2025-02-05 08:38:31 -05:00
John Colvin
7f99a89a95
ui (fills): Add notional value column
2025-02-05 00:00:41 -05:00
John Colvin
bfce663b4b
fix (orderbook): Hook up notional val filter in vm, persist settings
2025-02-04 23:42:58 -05:00
John Colvin
33c743643d
fix (orderbook): Include fractional qty in notional val
2025-02-04 23:34:47 -05:00
John Colvin
f21e7f3602
ui (orderbook): Show synth notional value in terms of first leg
2025-02-04 16:54:37 -05:00
John Colvin
b56c35aca4
ui (ladder): Show synth notional value in terms of first leg
2025-02-04 16:54:37 -05:00