From ff65acba056ff0083e62bd339ebf44d55e89176d Mon Sep 17 00:00:00 2001 From: John Colvin Date: Thu, 7 Aug 2025 14:33:48 -0400 Subject: [PATCH] fix: Gracefully handle missing column settings in pnl win Pnl window settings are stored with the workspace on the server (like all shell window settings), and may originate from an older version of Spark with a different set of columns. We shouldn't crash if this happens. --- .../spark/Modules/Trading/PNL/VM/PNLCellEmbeddedAnimator.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/PNL/VM/PNLCellEmbeddedAnimator.cs b/src/client/spark/Modules/Trading/PNL/VM/PNLCellEmbeddedAnimator.cs index 3a018e95e..ab90592c7 100644 --- a/src/client/spark/Modules/Trading/PNL/VM/PNLCellEmbeddedAnimator.cs +++ b/src/client/spark/Modules/Trading/PNL/VM/PNLCellEmbeddedAnimator.cs @@ -28,7 +28,9 @@ namespace bts.shell.pnl { foreach (var t in _triggers) { foreach (var kv in t.trigger(data)) { if (!bd.TryGetValue(kv.Key, out var app)) { - app = _defaults[kv.Key]; + if (!_defaults.TryGetValue(kv.Key, out app)) { + continue; + } } app = kv.Value.merge(app); bd[kv.Key] = app;