From eea3bc1d8b2d4b3fde043d95eca59edcd95aa212 Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Fri, 6 Sep 2019 16:03:33 -0400 Subject: [PATCH] SP-214 simplify trading status for synthetic logic --- src/lib/md/MDConsumerHandle.h | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/lib/md/MDConsumerHandle.h b/src/lib/md/MDConsumerHandle.h index 84550ac3a..f9d01a439 100644 --- a/src/lib/md/MDConsumerHandle.h +++ b/src/lib/md/MDConsumerHandle.h @@ -218,20 +218,15 @@ public: case HANDLETYPE_DEPTH: return book.cdata->exchange_status; case HANDLETYPE_BBO: return bbo.cdata->exchange_status; case HANDLETYPE_SYNTHETIC: { - co2::TradingStatus status = co2::TradingStatus::TRADINGSTATUS_UNKNOWN;; // Return the status if all legs match otherwise return TRADINGSTATUS_UNKNOWN - for (auto iter = synthetic.def->legs.begin(); iter != synthetic.def->legs.end(); ++iter) { - if (iter == synthetic.def->legs.begin()) { - status = iter->trading_status(); - } - else { - auto temp = iter->trading_status(); - if (temp != status) { - return co2::TradingStatus::TRADINGSTATUS_UNKNOWN; - } + if (synthetic.def->legs.size() > 0) { + auto status = synthetic.def->legs.front().trading_status(); + for (const auto& leg : synthetic.def->legs) { + if (leg.trading_status() != status) break; } + return status; } - return status; + return co2::TRADINGSTATUS_UNKNOWN; } default: case HANDLETYPE_VOID: