diff --git a/src/lib/orderman/orders/algo/algo_orders/DormanAlgo.cpp b/src/lib/orderman/orders/algo/algo_orders/DormanAlgo.cpp index 583b4bb50..9a0bcce77 100644 --- a/src/lib/orderman/orders/algo/algo_orders/DormanAlgo.cpp +++ b/src/lib/orderman/orders/algo/algo_orders/DormanAlgo.cpp @@ -196,8 +196,10 @@ void DormanAlgo::on_child_change(OrderKey key, const ChildState& state) { algo().cancel("Unexpected fill decrease."); return; } - - // todo: If child is canceled do we need to cancel? probably. + if (state.status == ChildStatus::CANCELED) { + algo().cancel("Unexpected child cancel"); + return; + } auto delta = state.total_fills.value() - me->child_state.total_fills.value(); if (delta != 0) { @@ -212,9 +214,10 @@ void DormanAlgo::on_child_change(OrderKey key, const ChildState& state) { do_scratch(); } - if (me->fills >= algo().quantity().value()) { + if (me->fills >= algo().quantity().value() || state.status == ChildStatus::COMPLETED) { complete(); } + } void DormanAlgo::on_book(SecurityKey key, const Book& book) {