From dc43d25c534fcd3f593f7bcc5008b12f6aeaff69 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 21 Aug 2019 15:54:23 -0500 Subject: [PATCH 1/4] use Spreader AlgoFormat when security is synthetic --- src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs b/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs index 97db476d3..a1bd3fc6f 100644 --- a/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs +++ b/src/client/spark/Modules/Trading/Ladder/VM/LadderSettingsVM.cs @@ -137,7 +137,7 @@ namespace mbts.spark { c.PropertyChanged -= on_prop_changed; } AccountTuple? account_factory(KeyValuePair kv) => new AccountTuple(kv.Key, kv.Value); - AlgoDefinitionVM algo_factory(AlgoData data) => AlgoDefinitionVM.create(_model, data); + AlgoDefinitionVM algo_factory(AlgoData data) => AlgoDefinitionVM.create(_model, data, is_synthetic ? AlgoFormats.Spreader : AlgoFormats.Exchange); } public event Action result_changed; From 14aad6ece8f4ffab4db460884ad5ebadedb541c4 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 28 Aug 2019 08:48:34 -0500 Subject: [PATCH 2/4] SP-208 - no nullref when clearing empty discrete filter --- src/client/spark/view/Controls/ListBoxEx/ListBoxEx.xaml.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/client/spark/view/Controls/ListBoxEx/ListBoxEx.xaml.cs b/src/client/spark/view/Controls/ListBoxEx/ListBoxEx.xaml.cs index 5fbdcd504..3b663b650 100644 --- a/src/client/spark/view/Controls/ListBoxEx/ListBoxEx.xaml.cs +++ b/src/client/spark/view/Controls/ListBoxEx/ListBoxEx.xaml.cs @@ -101,7 +101,8 @@ namespace mbts.ui.controls case NotifyCollectionChangedAction.Replace: if (e.OldItems != null) foreach (var item in e.OldItems) _set_is_selected(item, false); if (e.NewItems != null) foreach (var item in e.NewItems) _set_is_selected(item, true); break; - case NotifyCollectionChangedAction.Reset: foreach (var item in ItemsSource) _set_is_selected(item, false); break; + case NotifyCollectionChangedAction.Reset: + if (ItemsSource != null) foreach (var item in ItemsSource) _set_is_selected(item, false); break; } _update_is_all_selected(); } From 94baf15d01f61c91e75c0a85d80ab194dfd00107 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 28 Aug 2019 10:02:37 -0500 Subject: [PATCH 3/4] Per John, adding this line back to repopulate items once again --- .../Controls/DataGridEx/Filters/VM/DiscreteValuesFilterVM.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/client/spark/view/Controls/DataGridEx/Filters/VM/DiscreteValuesFilterVM.cs b/src/client/spark/view/Controls/DataGridEx/Filters/VM/DiscreteValuesFilterVM.cs index e33c4e7e7..be1856777 100644 --- a/src/client/spark/view/Controls/DataGridEx/Filters/VM/DiscreteValuesFilterVM.cs +++ b/src/client/spark/view/Controls/DataGridEx/Filters/VM/DiscreteValuesFilterVM.cs @@ -168,6 +168,7 @@ namespace mbts.spark.filters { _comparer = comparer; _selected_items_set = new HashSet(_equality_comparer); _items_set = new HashSet(_equality_comparer); + items = ObservableAutoWrapper.create_read_only_wrapper(_items); selected_items.CollectionChanged += _on_selected_items_CollectionChanged; _sync_items(); } From 8c36b498a4141468038d2d8daa21b34ba4ac4534 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 28 Aug 2019 10:45:45 -0500 Subject: [PATCH 4/4] proposed release notes --- doc/user/content/release_notes/_index.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/user/content/release_notes/_index.md b/doc/user/content/release_notes/_index.md index 4b447d088..9daaf582d 100644 --- a/doc/user/content/release_notes/_index.md +++ b/doc/user/content/release_notes/_index.md @@ -4,6 +4,10 @@ weight = 3 sort_by = "weight" insert_anchor_links = "right" +++ +## 2.8.3 +### Bug Fixes + - Fixed a bug that could cause an OrderBook's Security column filter to be blank + - Fixed a bug that could cause a UI failure when clearing a filter selection on a filtering widget ## 2.8.2 ### Bug Fixes - Added proper display factors for SOM spreads