From dd049374d7693be89f2126ff9877d2e95fc9e889 Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Thu, 9 May 2019 14:26:14 -0400 Subject: [PATCH] Fix equality comparison between mbo price levels --- src/client/spark/view/Spark/Ladder/MBO/MBODetailView.cs | 2 +- src/lib/md/MBOServiceServer.cpp | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/client/spark/view/Spark/Ladder/MBO/MBODetailView.cs b/src/client/spark/view/Spark/Ladder/MBO/MBODetailView.cs index 8b72f9330..83402b47a 100644 --- a/src/client/spark/view/Spark/Ladder/MBO/MBODetailView.cs +++ b/src/client/spark/view/Spark/Ladder/MBO/MBODetailView.cs @@ -105,7 +105,7 @@ namespace mbts.spark { var tickLength = large ? 6.0 : 3.0; dc.DrawLine(pen, new Point(x, baseline), new Point(x, baseline + tickLength)); - if (x + smallTick > _dp.size.Width) { + if (x + smallTick >= _dp.size.Width) { // last tick mark var size = (int)(x / _dp.scale); var text = TextUtils.GetFormattedText(size.ToString(), 9.0); diff --git a/src/lib/md/MBOServiceServer.cpp b/src/lib/md/MBOServiceServer.cpp index 70eb77e8a..3ba0f9f66 100644 --- a/src/lib/md/MBOServiceServer.cpp +++ b/src/lib/md/MBOServiceServer.cpp @@ -4,6 +4,7 @@ #include "lib/api/services/OrderService.client.pb.h" #include "lib/utils/Dispatcher.h" #include "lib/utils/TimeStamp.h" +#include "lib/domain_model/Security.h" #include "MDClient.h" #include "ExchangeOrderKey.h" #include "MBOProcessor.h" @@ -308,13 +309,14 @@ void MBOServiceServer::get_orders_for_security(const MBOSecurityQuery& request, } size_t count = 0; + auto tick = handle.get_minimum_tick(); if(handle.is_initialized()) { auto mbo = handle.get_mbo(); if (mbo) { for (const auto& o : mbo->bids) { double price = o.price.price(); bool isnan = os::is_nan(request.price_level()); - if (isnan || request.price_level() == price) { + if (isnan || securities::test_price_equality(request.price_level(), price, tick)) { ++count; if (request.limit() && count > request.limit()) break; auto* entry = response.add_orders(); @@ -330,7 +332,7 @@ void MBOServiceServer::get_orders_for_security(const MBOSecurityQuery& request, for (const auto& o : mbo->asks) { double price = o.price.price(); bool isnan = os::is_nan(request.price_level()); - if (isnan || request.price_level() == price) { + if (isnan || securities::test_price_equality(request.price_level(), price, tick)) { ++count; if (request.limit() && count > request.limit()) break; auto* entry = response.add_orders();