IDGenerator is a thread-safe singleton now

This commit is contained in:
Taha Afzal authored and John Colvin committed 2023-01-02 18:44:59 -05:00
1 parent 5515404062
commit d9efbb879d
4 files changed
+27 -3

No files matched your search

+12
View File
@@ -8,6 +8,9 @@
namespace bts::persistence {
IDGenerator *IDGenerator::_instance = nullptr;
std::mutex IDGenerator::_instance_mx;
struct IDGenerator::PImpl {
std::unique_ptr<persistence::IStore> kv_store;
PImpl() : kv_store(std::make_unique<persistence::SqliteStore>("key_ids")) {}
@@ -15,6 +18,14 @@ struct IDGenerator::PImpl {
IDGenerator::IDGenerator() : me(new PImpl()) {}
IDGenerator &IDGenerator::insance() {
std::lock_guard<std::mutex> myLock(_instance_mx);
if (!_instance) {
_instance = new IDGenerator();
}
return *_instance;
}
inline uint64_t str_to_id(const std::string id_str) {
return std::stoull(id_str);
}
@@ -35,6 +46,7 @@ uint64_t get_next_id(
std::optional<uint64_t> IDGenerator::get_id(
const std::string &ns, const std::string &key, bool add_if_new) {
std::lock_guard<std::mutex> myLock(_instance_mx);
auto [exists, val] = me->kv_store->retrieve_one(ns, key);
if (exists) {
uint64_t rv = str_to_id(val);