From b2c3488c5e78594e2101c21e1b77bd2c8e14bc81 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Tue, 2 Jul 2019 14:01:07 -0500 Subject: [PATCH 1/5] draw volume numbers when bars not present --- src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs b/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs index 8f0168332..f91867329 100644 --- a/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs +++ b/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs @@ -215,7 +215,7 @@ namespace mbts.spark { Brush total_brush = null; if (settings.total.bars.result.HasValue) { total_brush = new SolidColorBrush(settings.total.bars.result.Value); - } else if (components.Count == 0) { + } else if (components.Count == 0 && !settings.show_ltq) { _clear_visual(dv); return; } From 8f22a326ab15973a7ff8e9a68c3daeb233ac3e92 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Tue, 2 Jul 2019 14:01:50 -0500 Subject: [PATCH 2/5] last on volume foreground text is now white --- src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs b/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs index f91867329..d12c79a6c 100644 --- a/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs +++ b/src/client/spark/Modules/Trading/Ladder/View/LadderRender.cs @@ -221,10 +221,10 @@ namespace mbts.spark { } // inflate the max so that the graph never fills the available space double max = data.Max(v => v.Volume) * 1.1; - Brush text_brush = settings.general.foreground.rgb_brush(); _render_cells(dv, row_height, data.Select(d => (d.Price, d)), settings.general, prices, spec, render_cell); /// local methods void render_cell(DrawingContext dc, int r, VolumeAtPriceLevelImmutable vap) { + Brush text_brush = settings.general.foreground.rgb_brush(); double y = row_height * r; var last_trade_here = r == last_index; @@ -259,6 +259,7 @@ namespace mbts.spark { if (settings.show_ltq && last_trade_here) { numbers_text.Clear(); numbers_text.Add(last_size_and_direction); + text_brush = BTSCoreColors.white; } if (numbers_text.Count > 0) { string str = string.Join("/", numbers_text); From 213567bcdb841c6d56957d37e0b53ed23eebdbc9 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 5 Jul 2019 11:49:34 -0500 Subject: [PATCH 3/5] display tooltip again when re-entering same cell where tooltip was previouly closed --- src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs b/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs index 2a2af3223..b78519f62 100644 --- a/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs +++ b/src/client/spark/Modules/Trading/Ladder/View/LadderGridHost.cs @@ -694,12 +694,14 @@ namespace mbts.spark { // At any rate, we need this part hiding the tooltip so that we don't leave random tooltips around // and we have to reset to old row so that when we go back to what could be our preivous row, the tooltip gets drawn again //System.Diagnostics.Debug.WriteLine(" Tooltip - Volume is 0"); + _old_tooltip_row = int.MaxValue; _hide_tool_tip(); //_old_tooltip_row = Int32.MaxValue; } } } else { //System.Diagnostics.Debug.WriteLine(" Tooltip - not over Volume column"); + _old_tooltip_row = int.MaxValue; _hide_tool_tip(); } } From 36ed80dc87e6b2c31f5574c6518e4a1806dc997c Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Mon, 8 Jul 2019 10:15:14 -0400 Subject: [PATCH 4/5] Updated release notes. --- doc/user/content/release_notes/_index.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/user/content/release_notes/_index.md b/doc/user/content/release_notes/_index.md index f2ba4c36e..b06ee5496 100644 --- a/doc/user/content/release_notes/_index.md +++ b/doc/user/content/release_notes/_index.md @@ -4,6 +4,9 @@ weight = 3 sort_by = "weight" insert_anchor_links = "right" +++ +## 2.6.0 +### User Visible Changes + - In the ladder made last trade more distinctive when overlayed on the volumn column ## 2.5.0 ### User Visible Changes - Added loss limit risk check From e079acf91f4bdf56e84a850ccfc2b31b7dea4681 Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Mon, 8 Jul 2019 10:28:18 -0400 Subject: [PATCH 5/5] Updated release notes. --- doc/user/content/release_notes/_index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/user/content/release_notes/_index.md b/doc/user/content/release_notes/_index.md index b06ee5496..873055005 100644 --- a/doc/user/content/release_notes/_index.md +++ b/doc/user/content/release_notes/_index.md @@ -7,6 +7,7 @@ insert_anchor_links = "right" ## 2.6.0 ### User Visible Changes - In the ladder made last trade more distinctive when overlayed on the volumn column + - In the ladder, corrected display of volume tool tip ## 2.5.0 ### User Visible Changes - Added loss limit risk check