From cd23c1a5a1c7678a99f0dad2a3ce2ea3f2d5d72f Mon Sep 17 00:00:00 2001 From: John Colvin Date: Mon, 2 May 2022 13:17:10 -0400 Subject: [PATCH] fix (ui): Use 'opacity' to indicate enabled/disabled in spark menu Bugs (fixed): * SparkMenuItems sometimes look disabled when they aren't (esp in AnalyticsExpirationParameters win) In wpf, VisualStates in different VisualStateGroups shouldn't adjust common properties. A visual element can only be in 1 visual state at a time. When a visual element transitions to a new visual state, all depepdency property changes associated with the transition to the previous state are cleared. --- .../view/Controls/SparkMenu/SparkMenu.xaml | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/client/spark/view/Controls/SparkMenu/SparkMenu.xaml b/src/client/spark/view/Controls/SparkMenu/SparkMenu.xaml index 1f398c323..b70fc8cd6 100644 --- a/src/client/spark/view/Controls/SparkMenu/SparkMenu.xaml +++ b/src/client/spark/view/Controls/SparkMenu/SparkMenu.xaml @@ -25,6 +25,7 @@ MinWidth="150" BorderBrush="{u:BTSColor UI.Button.normal_border}" Background="{u:BTSColor UI.spark_menu_background}" + Opacity="1" ToolTipService.InitialShowDelay="30000"> @@ -144,24 +145,12 @@ - - + + - - - - - -