From fb314f0eb19b72e573dc32398e2db2bbd3b82f66 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 5 Jun 2019 14:01:47 -0500 Subject: [PATCH 01/42] SPARK-2491 - mass cancel --- .../Trading/Ladder/VM/LadderOrderVM.cs | 1 + .../Trading/OrderBook/OrderBookColumns.cs | 22 +++++++++++++++++++ .../Trading/OrderBook/OrderBookRowVM.cs | 6 ++++- .../Modules/Trading/OrderBook/OrderBookVM.cs | 9 ++++++-- .../OrderBook/View/OrderBookGridView.xaml.cs | 3 ++- 5 files changed, 37 insertions(+), 4 deletions(-) diff --git a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs index 51e162565..c0bbe5c18 100644 --- a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs +++ b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs @@ -335,6 +335,7 @@ namespace mbts.spark { } obvm.columns.Insert(0, new OrderBookVM.UpdateColumn(typeof(MiniOrderBookView))); obvm.columns.Insert(0, new OrderBookVM.CancelColumn(nameof(OrderBookRowVM.cancel_command))); + obvm.columns.Insert(0, new OrderBookVM.CheckColumn(nameof(OrderBookRowVM.is_checked))); obvm.load_from(state); return obvm; diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 76daca299..6eaa6d6c1 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -724,6 +724,28 @@ namespace mbts.spark { } } + public class CheckColumn : FrameworkElementColumnBase { + readonly BindingBase _checked_binding; + public CheckColumn(string checked_property) : base(Columns.Check) { + id = key.ToString(); + Width = 30; + _checked_binding = new Binding(checked_property); + } + + public override FrameworkElement view_factory() { + var grid = new Grid() { + HorizontalAlignment = HorizontalAlignment.Center, + VerticalAlignment = VerticalAlignment.Center, + }; + var cb = new CheckBox(); + cb.Name = "check_col"; + cb.SetBinding(CheckBox.IsCheckedProperty, _checked_binding); + + grid.Children.Add(cb); + return grid; + } + } + public class CancelColumn : FrameworkElementColumnBase { readonly BindingBase _command_binding; diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs index e9a7d3b6b..24c36ca91 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs @@ -21,7 +21,7 @@ namespace mbts.spark { Color? _root_algo_badge_color_backing; Brush _badge_fill, _root_algo_badge_fill; IRaiseCanExecuteChangedCommand _show_order_modify_cmd, _toggle_expanded_cmd, _cancel_cmd, _detach_command, _attach_command, _update_command, _modify_order_quantity_andor_price, _revert_prospective_order_quantity_andor_price; - bool _is_parent, _is_expanded, _is_selected, _is_attachable, _is_detachable; + bool _is_parent, _is_expanded, _is_selected, _is_attachable, _is_detachable, _is_checked; int _depth_level; SecurityImmutable? _security => order_tuple.security; // for mini-ob @@ -138,6 +138,10 @@ namespace mbts.spark { } public bool is_qty_dirty => this.prospective_quantity != this.quantity; public bool is_price_dirty => this.prospective_price != this.price; + public bool is_checked { + get => _is_checked; + set => Set(ref _is_checked, value); + } // Commands public ICommand toggle_command => _toggle_expanded_cmd ?? ( diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index cff54d5c4..7957d9541 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -572,8 +572,13 @@ namespace mbts.spark { internal void show_order_modify(OrderBookRowVM row) => _bus.post(SparkTags.ShowModifyOrderTag, row.order_key); - internal void cancel_order(OrderBookRowVM row) => - _bus.post(SparkTags.CancelOrders, new List { row.order_key }); + internal void cancel_order(OrderBookRowVM row) { + if (row.is_checked) { + rows.Where(r => r.is_checked).ForEach((checked_row) => _bus.post(SparkTags.CancelOrders, new List { checked_row.order_key })); + } else { + _bus.post(SparkTags.CancelOrders, new List { row.order_key }); + } + } internal void modify_order_quantity(OrderBookRowVM row, uint size) => _bus.post(SparkTags.UpdateOrder, (row.order_key, row.price, size)); diff --git a/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml.cs b/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml.cs index 2f996e32f..2f6d21923 100644 --- a/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml.cs +++ b/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml.cs @@ -50,7 +50,8 @@ namespace mbts.spark { Update = 1 << 27, Commit = 1 << 28, RootAlgoType = 1 << 29, - Piq = 1 << 30 + Piq = 1 << 30, + Check = 1 << 31 } public OrderBookGridView() { From a38a6057e07aa7798dba39b9764c7a1198c6b8d7 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Thu, 6 Jun 2019 13:32:48 -0500 Subject: [PATCH 02/42] part of SPARK-2485 - mini ob only shows exchange orders + spreader rows --- .../spark/Modules/Trading/AlgoStudio/Model/AlgoKey.cs | 6 ++++++ .../spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs | 4 +++- src/client/spark/Orders/OrderDataHelper.cs | 7 +++++++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoKey.cs b/src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoKey.cs index 98c414a46..f063fb01c 100644 --- a/src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoKey.cs +++ b/src/client/spark/Modules/Trading/AlgoStudio/Model/AlgoKey.cs @@ -3,6 +3,7 @@ using bts.persist.algo; using bts.utils; using ProtoBuf; using System; +using System.Linq; namespace mbts.spark { [ProtoContract] @@ -14,6 +15,11 @@ namespace mbts.spark { [ProtoMember(3)] readonly uint? _persisted_key; + public static readonly AlgoID[] exchange_algo_keys = utilities.OrderDataHelper.outright_order_types + .Concat(new CustomOrderDefinition.CustomOneofCase[] { CustomOrderDefinition.CustomOneofCase.Spreader }) + .Select(cooc => new AlgoID(cooc)) + .ToArray(); + public AlgoID(CustomOrderDefinition.CustomOneofCase factory_key) { _factory_key = factory_key; _dynamic_key = null; diff --git a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs index c0bbe5c18..cbc33c7b4 100644 --- a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs +++ b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs @@ -1,5 +1,6 @@ using bts.api; using bts.api.orderman; +using mbts.spark.utilities; using mbts.ui; using mbts.ui.shell; using System; @@ -297,7 +298,8 @@ namespace mbts.spark { new bts.shell.orderbook.FilterStates { security_criteria = new SecurityCriteria(_owner.security), price = price_filter, - statuses = new[] { OrderStatus.Working } + statuses = new[] { OrderStatus.Working }, + order_types = AlgoID.exchange_algo_keys }, bts.shell.orderbook.OrderBookStartupData.default_mini_grid, use_defaults: false diff --git a/src/client/spark/Orders/OrderDataHelper.cs b/src/client/spark/Orders/OrderDataHelper.cs index 96acc2caa..0fa0730a0 100644 --- a/src/client/spark/Orders/OrderDataHelper.cs +++ b/src/client/spark/Orders/OrderDataHelper.cs @@ -622,6 +622,13 @@ namespace mbts.spark.utilities { CustomOrderDefinition.CustomOneofCase.Join, CustomOrderDefinition.CustomOneofCase.Cover, CustomOrderDefinition.CustomOneofCase.Top + }, + outright_order_types = new[] { + CustomOrderDefinition.CustomOneofCase.Market, + CustomOrderDefinition.CustomOneofCase.Limit, + CustomOrderDefinition.CustomOneofCase.Stop, + CustomOrderDefinition.CustomOneofCase.StopLimit, + CustomOrderDefinition.CustomOneofCase.GlbxIceberg, }; public static readonly CustomOrderDefinition.CustomOneofCase[] all_order_types = exchange_order_types.Union(spreader_order_types).ToArray(); From 570f85377ae1072732d3da056e6e7e696645a7ab Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Thu, 6 Jun 2019 14:00:06 -0500 Subject: [PATCH 03/42] part of SPARK-2485 - miniob - update buttons not visible unless leaf under control of an algo --- .../Modules/Trading/OrderBook/OrderBookColumns.cs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 6eaa6d6c1..2b9e28a09 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -992,9 +992,9 @@ namespace mbts.spark { public override FrameworkElement view_factory() { var popup = new System.Windows.Controls.Primitives.Popup(); - #region Attach Button + #region Update Button - // create the attach button and assign the menu to it + // create the update button and assign the menu to it var update_button = new Button() { Name = "update_button", Content = "···", @@ -1017,6 +1017,14 @@ namespace mbts.spark { row_vm_update_command_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); update_button.SetBinding(Button.CommandProperty, row_vm_update_command_binding); + // update button is only visible for orders under the control of an algo + var update_button_visibility_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.root_algo_order_type))) { + Converter = ValueConverter.create(ord_type => utilities.OrderDataHelper.outright_order_types.Contains(ord_type) ? Visibility.Hidden : Visibility.Visible) + }; + update_button_visibility_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); + update_button.SetBinding(Button.VisibilityProperty, update_button_visibility_binding); + + #endregion #region OrderParamsPanel From 3f245cd88674530a5703467be28d181f2e001a0c Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Thu, 6 Jun 2019 14:20:00 -0500 Subject: [PATCH 04/42] SPARK-2497 - mini ob mass detach --- .../spark/Modules/Trading/OrderBook/OrderBookVM.cs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 7957d9541..0a9759524 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -555,8 +555,15 @@ namespace mbts.spark { return r; } - internal void detach_orders(OrderBookRowVM order) => - _detach_orders_async(new[] { order }).ignore(); + internal void detach_orders(OrderBookRowVM order) { + if (order.is_checked) { + var detach_candidates = rows.Where(r => r.is_checked); + _detach_orders_async(detach_candidates).ignore(); + detach_candidates.ForEach((row_vm) => row_vm.is_checked = false); + } else { + _detach_orders_async(new[] { order }).ignore(); + } + } public OrderSecurity get_ordersecurityalgometa(OrderRecordImmutable order) { _cached_orders.TryGetValue(order.Key, out var osam); From 9ba2ba1d757871b408ac8b953f772168667546ea Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 7 Jun 2019 09:25:25 -0500 Subject: [PATCH 05/42] refactoring modify_selected_orders to accept a IEnumerable>OrderBookRowVM>; creating a new command for minob that iterates over checked orders to modify --- .../Modules/Trading/OrderBook/OrderBookColumns.cs | 2 +- .../spark/Modules/Trading/OrderBook/OrderBookVM.cs | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 2b9e28a09..c249f29b4 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -1056,7 +1056,7 @@ namespace mbts.spark { // we make use of this addition trick from John that allows for both of these things to happen. // We take our original ICommand (send_attached) and wrap it in another Command by way of a Converter on the binding, // pure genious! - var modify_selected_button_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.modify_selected_orders_cmd))) { + var modify_selected_button_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.modify_checked_orders_cmd))) { Converter = CommandWithActionWrapper.mk_wrap_converter(() => popup.IsOpen = false) }; modify_selected_button_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(Popup), 1); diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 0a9759524..34102213d 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -113,6 +113,7 @@ namespace mbts.spark { expand_all_rows_command = new DelegateCommand(_row_collection.expand_all); var modify_selected_orders_async_cmd = new AsyncCommand(_modify_selected_orders_async, () => _selected_params_mon.all_active && order_mod_vm.is_dirty); modify_selected_orders_cmd = modify_selected_orders_async_cmd; + modify_checked_orders_cmd = new AsyncCommand(() => _modify_orders_async(rows.Where(r => r.is_checked) /* we probably need some kind of can_execute in here and maybe a new checked_params_mon*/)); var revert_selected_orders_cmd = new DelegateCommand(order_mod_vm.revert, () => _selected_params_mon.all_active && order_mod_vm.is_dirty); this.revert_selected_orders_cmd = revert_selected_orders_cmd; var send_attached_orders_async_cmd = new ObservantAsyncCommand(send_attached_orders_async); @@ -371,6 +372,7 @@ namespace mbts.spark { public ICommand collapse_all_rows_command { get; } public ICommand expand_all_rows_command { get; } public ICommand modify_selected_orders_cmd { get; } + public ICommand modify_checked_orders_cmd { get; } public ICommand revert_selected_orders_cmd { get; } public ICommand send_attached_orders_cmd { get; } public ICommand cancel_attach_orders_cmd { get; } @@ -624,7 +626,9 @@ namespace mbts.spark { } } - async Task _modify_selected_orders_async() { + async Task _modify_selected_orders_async() => await _modify_orders_async(selected_rows); + + async Task _modify_orders_async(IEnumerable modify_candidates) { double? price = DoubleHelper.nan_nullable(order_mod_vm.price); uint? size = order_mod_vm.size; if (order_mod_vm.algo_vm.algo_root is IAlgoVM mod_algo_vm) { @@ -636,7 +640,7 @@ namespace mbts.spark { // their values will be cleared (in the param grid gui), and the modifications will not be applied. // FYI this behavior is implemented to support 'partial edits.' (e.g., changing the 'price' for multiple orders that do not have the same 'size'). // ---- - var update_params = selected_rows.Select(update_params_factory).ToList(); + var update_params = modify_candidates.Select(update_params_factory).ToList(); await Task.WhenAll(update_params.Select(t => _model.update_order(t.order, new_price: price, new_size: size, new_algo: t.new_algo))); (OrderRecordImmutable order, CustomOrderDefinitionImmutable? new_algo) update_params_factory(OrderBookRowVM row) { var mod_algo = row.order.Def.CustomDef.CloneToMutable(); @@ -648,7 +652,7 @@ namespace mbts.spark { var mod_algoi = new CustomOrderDefinitionImmutable(mod_algo); return (row.order, OrderDataHelper.EqualsHelpers.equals(row.order.Def.CustomDef, mod_algoi) ? (CustomOrderDefinitionImmutable?)null : mod_algoi); } - } else await Task.WhenAll(selected_rows.Select(r => _model.update_order(r.order, price))); + } else await Task.WhenAll(modify_candidates.Select(r => _model.update_order(r.order, price))); } IObservable> _subscribe_throttled_selected_rows() => From 307d3d94661c23d277c8825833048b14dcbb1aac Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 7 Jun 2019 10:33:26 -0500 Subject: [PATCH 06/42] eliminating new mini ob checkbox col and just operating based off of the standard diygrid selected_rows --- .../Trading/Ladder/VM/LadderOrderVM.cs | 2 +- .../MiniOrderBook/MiniOrderBookView.xaml | 1 - .../Trading/OrderBook/OrderBookColumns.cs | 46 +++++++++---------- .../Trading/OrderBook/OrderBookRowVM.cs | 24 +++++----- .../Modules/Trading/OrderBook/OrderBookVM.cs | 12 ++--- 5 files changed, 41 insertions(+), 44 deletions(-) diff --git a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs index cbc33c7b4..11ad2036e 100644 --- a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs +++ b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs @@ -337,7 +337,7 @@ namespace mbts.spark { } obvm.columns.Insert(0, new OrderBookVM.UpdateColumn(typeof(MiniOrderBookView))); obvm.columns.Insert(0, new OrderBookVM.CancelColumn(nameof(OrderBookRowVM.cancel_command))); - obvm.columns.Insert(0, new OrderBookVM.CheckColumn(nameof(OrderBookRowVM.is_checked))); + //obvm.columns.Insert(0, new OrderBookVM.CheckColumn(nameof(OrderBookRowVM.is_checked))); obvm.load_from(state); return obvm; diff --git a/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml b/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml index 751bca859..6cc0ec713 100644 --- a/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml +++ b/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml @@ -124,7 +124,6 @@ SelectionHighlight="{Binding grid_settings_manager.selection_highlight, Mode=OneWay}" RowsHorizontalScrollBarVisibility="Collapsed" RowHeight="20" - SelectionMode="Single" > diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index c249f29b4..a9eab87a9 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -724,27 +724,27 @@ namespace mbts.spark { } } - public class CheckColumn : FrameworkElementColumnBase { - readonly BindingBase _checked_binding; - public CheckColumn(string checked_property) : base(Columns.Check) { - id = key.ToString(); - Width = 30; - _checked_binding = new Binding(checked_property); - } + //public class CheckColumn : FrameworkElementColumnBase { + // readonly BindingBase _checked_binding; + // public CheckColumn(string checked_property) : base(Columns.Check) { + // id = key.ToString(); + // Width = 30; + // _checked_binding = new Binding(checked_property); + // } - public override FrameworkElement view_factory() { - var grid = new Grid() { - HorizontalAlignment = HorizontalAlignment.Center, - VerticalAlignment = VerticalAlignment.Center, - }; - var cb = new CheckBox(); - cb.Name = "check_col"; - cb.SetBinding(CheckBox.IsCheckedProperty, _checked_binding); + // public override FrameworkElement view_factory() { + // var grid = new Grid() { + // HorizontalAlignment = HorizontalAlignment.Center, + // VerticalAlignment = VerticalAlignment.Center, + // }; + // var cb = new CheckBox(); + // cb.Name = "check_col"; + // cb.SetBinding(CheckBox.IsCheckedProperty, _checked_binding); - grid.Children.Add(cb); - return grid; - } - } + // grid.Children.Add(cb); + // return grid; + // } + //} public class CancelColumn : FrameworkElementColumnBase { readonly BindingBase _command_binding; @@ -1013,9 +1013,9 @@ namespace mbts.spark { // kept in sync between those controls via a PlacementTarget.DataContext binding update_button.SetBinding(Button.DataContextProperty, orderbook_vm_datacontext_binding); - var row_vm_update_command_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.update_command))); - row_vm_update_command_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); - update_button.SetBinding(Button.CommandProperty, row_vm_update_command_binding); + //var row_vm_update_command_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.update_command))); + //row_vm_update_command_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); + //update_button.SetBinding(Button.CommandProperty, row_vm_update_command_binding); // update button is only visible for orders under the control of an algo var update_button_visibility_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.root_algo_order_type))) { @@ -1056,7 +1056,7 @@ namespace mbts.spark { // we make use of this addition trick from John that allows for both of these things to happen. // We take our original ICommand (send_attached) and wrap it in another Command by way of a Converter on the binding, // pure genious! - var modify_selected_button_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.modify_checked_orders_cmd))) { + var modify_selected_button_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.modify_selected_orders_cmd))) { Converter = CommandWithActionWrapper.mk_wrap_converter(() => popup.IsOpen = false) }; modify_selected_button_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(Popup), 1); diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs index 24c36ca91..53bf811a8 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs @@ -20,8 +20,8 @@ namespace mbts.spark { readonly OrderBookVM _owner; Color? _root_algo_badge_color_backing; Brush _badge_fill, _root_algo_badge_fill; - IRaiseCanExecuteChangedCommand _show_order_modify_cmd, _toggle_expanded_cmd, _cancel_cmd, _detach_command, _attach_command, _update_command, _modify_order_quantity_andor_price, _revert_prospective_order_quantity_andor_price; - bool _is_parent, _is_expanded, _is_selected, _is_attachable, _is_detachable, _is_checked; + IRaiseCanExecuteChangedCommand _show_order_modify_cmd, _toggle_expanded_cmd, _cancel_cmd, _detach_command, _attach_command, /*_update_command,*/ _modify_order_quantity_andor_price, _revert_prospective_order_quantity_andor_price; + bool _is_parent, _is_expanded, _is_selected, _is_attachable, _is_detachable; int _depth_level; SecurityImmutable? _security => order_tuple.security; // for mini-ob @@ -138,10 +138,6 @@ namespace mbts.spark { } public bool is_qty_dirty => this.prospective_quantity != this.quantity; public bool is_price_dirty => this.prospective_price != this.price; - public bool is_checked { - get => _is_checked; - set => Set(ref _is_checked, value); - } // Commands public ICommand toggle_command => _toggle_expanded_cmd ?? ( @@ -194,16 +190,16 @@ namespace mbts.spark { public ICommand attach_command => _attach_command ?? ( _attach_command = new DelegateCommand(() => { // the _select me will trigger the OBVM.attach_vm to get primed - _select_me(); + //_select_me(); _owner.begin_attach_algos(); }) ); - public ICommand update_command => _update_command ?? ( - _update_command = new DelegateCommand(() => { - _select_me(); - }) - ); + //public ICommand update_command => _update_command ?? ( + // _update_command = new DelegateCommand(() => { + // _select_me(); + // }) + //); // private props Color _root_algo_badge_color { @@ -294,6 +290,10 @@ namespace mbts.spark { // root display name if (old_order_tuple.root_algo.name != order_tuple.root_algo.name) RaisePropertyChanged(nameof(root_algo_display_name)); + // root order type + if (old_order_tuple.root_algo.value.CustomCase != order_tuple.root_algo.value.CustomCase) { + RaisePropertyChanged(nameof(root_algo_order_type)); + } // status if ((Columns.Status & dirty) != 0) RaisePropertyChanged(nameof(status)); diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 34102213d..d2a32fa53 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -113,7 +113,6 @@ namespace mbts.spark { expand_all_rows_command = new DelegateCommand(_row_collection.expand_all); var modify_selected_orders_async_cmd = new AsyncCommand(_modify_selected_orders_async, () => _selected_params_mon.all_active && order_mod_vm.is_dirty); modify_selected_orders_cmd = modify_selected_orders_async_cmd; - modify_checked_orders_cmd = new AsyncCommand(() => _modify_orders_async(rows.Where(r => r.is_checked) /* we probably need some kind of can_execute in here and maybe a new checked_params_mon*/)); var revert_selected_orders_cmd = new DelegateCommand(order_mod_vm.revert, () => _selected_params_mon.all_active && order_mod_vm.is_dirty); this.revert_selected_orders_cmd = revert_selected_orders_cmd; var send_attached_orders_async_cmd = new ObservantAsyncCommand(send_attached_orders_async); @@ -372,7 +371,6 @@ namespace mbts.spark { public ICommand collapse_all_rows_command { get; } public ICommand expand_all_rows_command { get; } public ICommand modify_selected_orders_cmd { get; } - public ICommand modify_checked_orders_cmd { get; } public ICommand revert_selected_orders_cmd { get; } public ICommand send_attached_orders_cmd { get; } public ICommand cancel_attach_orders_cmd { get; } @@ -558,10 +556,10 @@ namespace mbts.spark { } internal void detach_orders(OrderBookRowVM order) { - if (order.is_checked) { - var detach_candidates = rows.Where(r => r.is_checked); + if (order.is_selected) { + var detach_candidates = rows.Where(r => r.is_selected); _detach_orders_async(detach_candidates).ignore(); - detach_candidates.ForEach((row_vm) => row_vm.is_checked = false); + detach_candidates.ForEach((row_vm) => row_vm.is_selected = false); } else { _detach_orders_async(new[] { order }).ignore(); } @@ -582,8 +580,8 @@ namespace mbts.spark { _bus.post(SparkTags.ShowModifyOrderTag, row.order_key); internal void cancel_order(OrderBookRowVM row) { - if (row.is_checked) { - rows.Where(r => r.is_checked).ForEach((checked_row) => _bus.post(SparkTags.CancelOrders, new List { checked_row.order_key })); + if (row.is_selected) { + rows.Where(r => r.is_selected).ForEach((selected_row) => _bus.post(SparkTags.CancelOrders, new List { selected_row.order_key })); } else { _bus.post(SparkTags.CancelOrders, new List { row.order_key }); } From 16eeddec7dd459425db2781a96e9c85d3c19f624 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 7 Jun 2019 16:10:17 -0500 Subject: [PATCH 07/42] OperableHierarchicalCollectionModel - fixing get_parent --- .../Hierarchical/OperableHierarchicalCollectionModel.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/client/spark_core/Collections/Operable/Hierarchical/OperableHierarchicalCollectionModel.cs b/src/client/spark_core/Collections/Operable/Hierarchical/OperableHierarchicalCollectionModel.cs index 3dd046b8d..28c795387 100644 --- a/src/client/spark_core/Collections/Operable/Hierarchical/OperableHierarchicalCollectionModel.cs +++ b/src/client/spark_core/Collections/Operable/Hierarchical/OperableHierarchicalCollectionModel.cs @@ -65,8 +65,12 @@ namespace bts.collections { return false; } - public TRow get_parent(TKey key) => - _tree.TryGetNode(key, out var n) ? n.value : default; + public TRow get_parent(TKey key) { + if (try_get_row(key, out TRow r)) { + return _tree.GetParent(r).value; + } + return default; + } public IEnumerable get_descendent_rows(TKey key) { if (_tree.TryGetNode(key, out var n)) { From c5f7ee0ed3d48dfd03c013dcab037d897a1185ca Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 7 Jun 2019 16:16:27 -0500 Subject: [PATCH 08/42] reassigning the miniob update button to the update_command property so select the row if it's not already selected --- .../spark/Modules/Trading/OrderBook/OrderBookColumns.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index a9eab87a9..0ac341136 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -1013,9 +1013,9 @@ namespace mbts.spark { // kept in sync between those controls via a PlacementTarget.DataContext binding update_button.SetBinding(Button.DataContextProperty, orderbook_vm_datacontext_binding); - //var row_vm_update_command_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.update_command))); - //row_vm_update_command_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); - //update_button.SetBinding(Button.CommandProperty, row_vm_update_command_binding); + var row_vm_update_command_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.update_command))); + row_vm_update_command_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); + update_button.SetBinding(Button.CommandProperty, row_vm_update_command_binding); // update button is only visible for orders under the control of an algo var update_button_visibility_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.root_algo_order_type))) { From 6756b23104b513d1a4dcff1d52f342959033373e Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 7 Jun 2019 16:17:42 -0500 Subject: [PATCH 09/42] miniob - attach and update select the row if they're not already selected --- .../Trading/OrderBook/OrderBookRowVM.cs | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs index 53bf811a8..2f767c6d2 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs @@ -20,7 +20,7 @@ namespace mbts.spark { readonly OrderBookVM _owner; Color? _root_algo_badge_color_backing; Brush _badge_fill, _root_algo_badge_fill; - IRaiseCanExecuteChangedCommand _show_order_modify_cmd, _toggle_expanded_cmd, _cancel_cmd, _detach_command, _attach_command, /*_update_command,*/ _modify_order_quantity_andor_price, _revert_prospective_order_quantity_andor_price; + IRaiseCanExecuteChangedCommand _show_order_modify_cmd, _toggle_expanded_cmd, _cancel_cmd, _detach_command, _attach_command, _update_command, _modify_order_quantity_andor_price, _revert_prospective_order_quantity_andor_price; bool _is_parent, _is_expanded, _is_selected, _is_attachable, _is_detachable; int _depth_level; SecurityImmutable? _security => order_tuple.security; @@ -190,16 +190,20 @@ namespace mbts.spark { public ICommand attach_command => _attach_command ?? ( _attach_command = new DelegateCommand(() => { // the _select me will trigger the OBVM.attach_vm to get primed - //_select_me(); + if (!is_selected) { + _select_me(); + } _owner.begin_attach_algos(); }) ); - //public ICommand update_command => _update_command ?? ( - // _update_command = new DelegateCommand(() => { - // _select_me(); - // }) - //); + public ICommand update_command => _update_command ?? ( + _update_command = new DelegateCommand(() => { + if (!is_selected) { + _select_me(); + } + }) + ); // private props Color _root_algo_badge_color { From 370b4bcde93e3aea8ab7881ba8f061d32e909b13 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 7 Jun 2019 16:19:16 -0500 Subject: [PATCH 10/42] coording root row with selected params mon --- .../Modules/Trading/OrderBook/OrderBookVM.cs | 34 +++++++++++++------ 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index d2a32fa53..d308b5075 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -430,16 +430,20 @@ namespace mbts.spark { using (_selected_params_mon.begin_udpate()) { if (e.RemovedItems != null) { foreach (var row_vm in e.RemovedItems.OfType()) { + var root_row_vm = get_root(row_vm); row_vm.is_selected = false; - _selected_params_mon.on_row_unselected(row_vm); + root_row_vm.is_selected = false; + _selected_params_mon.on_row_unselected(root_row_vm); _attachable_selected_orders.Remove(row_vm.order_key); _detachable_selected_orders.Remove(row_vm.order_key); } } if (e.AddedItems != null) { foreach (var row_vm in e.AddedItems.OfType()) { + var root_row_vm = get_root(row_vm); row_vm.is_selected = true; - _selected_params_mon.on_row_selected(row_vm); + root_row_vm.is_selected = true; + _selected_params_mon.on_row_selected(root_row_vm); if (row_vm.is_attachable) _attachable_selected_orders.Add(row_vm.order_key); if (row_vm.is_detachable) @@ -548,13 +552,23 @@ namespace mbts.spark { public bool try_get_parent(OrderBookRowVM row, out OrderSecurity parent) => _cached_orders.TryGetValue(row.parent_order_key, out parent); - public OrderRecordImmutable get_root(OrderRecordImmutable r) { - while (r.ParentKey != 0 && _cached_orders.TryGetValue(r.ParentKey, out var parent_osam)) { - r = parent_osam.order; + public OrderBookRowVM get_root(OrderBookRowVM r) { + while (r.order.ParentKey != 0 ) { + var parent = get_parent(r); + if (parent != null) { + r = parent; + } } return r; } + public OrderSecurity get_root(OrderSecurity os) { + while (os.order.ParentKey != 0 && _cached_orders.TryGetValue(os.order.ParentKey, out var parent_osam)) { + os = parent_osam; + } + return os; + } + internal void detach_orders(OrderBookRowVM order) { if (order.is_selected) { var detach_candidates = rows.Where(r => r.is_selected); @@ -624,9 +638,9 @@ namespace mbts.spark { } } - async Task _modify_selected_orders_async() => await _modify_orders_async(selected_rows); + async Task _modify_selected_orders_async() => await _modify_orders_async(selected_rows.Select(r => get_root(r.order_tuple))); - async Task _modify_orders_async(IEnumerable modify_candidates) { + async Task _modify_orders_async(IEnumerable modify_candidates) { double? price = DoubleHelper.nan_nullable(order_mod_vm.price); uint? size = order_mod_vm.size; if (order_mod_vm.algo_vm.algo_root is IAlgoVM mod_algo_vm) { @@ -640,15 +654,15 @@ namespace mbts.spark { // ---- var update_params = modify_candidates.Select(update_params_factory).ToList(); await Task.WhenAll(update_params.Select(t => _model.update_order(t.order, new_price: price, new_size: size, new_algo: t.new_algo))); - (OrderRecordImmutable order, CustomOrderDefinitionImmutable? new_algo) update_params_factory(OrderBookRowVM row) { - var mod_algo = row.order.Def.CustomDef.CloneToMutable(); + (OrderRecordImmutable order, CustomOrderDefinitionImmutable? new_algo) update_params_factory(OrderSecurity os) { + var mod_algo = os.order.Def.CustomDef.CloneToMutable(); if (mod_algo.CustomCase == CustomOrderDefinition.CustomOneofCase.Composite) { mod_algo_vm.assign_to(mod_algo.Composite.Definition); } else { mod_algo_vm.assign_to(mod_algo); } var mod_algoi = new CustomOrderDefinitionImmutable(mod_algo); - return (row.order, OrderDataHelper.EqualsHelpers.equals(row.order.Def.CustomDef, mod_algoi) ? (CustomOrderDefinitionImmutable?)null : mod_algoi); + return (os.order, OrderDataHelper.EqualsHelpers.equals(os.order.Def.CustomDef, mod_algoi) ? (CustomOrderDefinitionImmutable?)null : mod_algoi); } } else await Task.WhenAll(modify_candidates.Select(r => _model.update_order(r.order, price))); } From a0bf7779f5b0bc8df568561a56e00b1adb7c36ff Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Mon, 10 Jun 2019 14:35:06 -0500 Subject: [PATCH 11/42] mini ob - changes from John; closer to working but not yet, likely related to mark_commited/revert not getting wired up/called --- .../Modules/Trading/OrderBook/OrderBookVM.cs | 70 ++++++++++--------- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index d308b5075..8986731bc 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -430,24 +430,35 @@ namespace mbts.spark { using (_selected_params_mon.begin_udpate()) { if (e.RemovedItems != null) { foreach (var row_vm in e.RemovedItems.OfType()) { - var root_row_vm = get_root(row_vm); row_vm.is_selected = false; - root_row_vm.is_selected = false; - _selected_params_mon.on_row_unselected(root_row_vm); + _selected_params_mon.on_row_unselected(_get_root(row_vm.order_tuple)); _attachable_selected_orders.Remove(row_vm.order_key); _detachable_selected_orders.Remove(row_vm.order_key); } } if (e.AddedItems != null) { foreach (var row_vm in e.AddedItems.OfType()) { - var root_row_vm = get_root(row_vm); + var root = _get_root(row_vm.order_tuple); row_vm.is_selected = true; - root_row_vm.is_selected = true; - _selected_params_mon.on_row_selected(root_row_vm); + row_vm.updated += on_updated; + _selected_params_mon.on_row_selected(root); if (row_vm.is_attachable) _attachable_selected_orders.Add(row_vm.order_key); if (row_vm.is_detachable) _detachable_selected_orders.Add(row_vm.order_key); + void on_updated((OrderSecurity oldval, OrderSecurity newval) change) { + if (!row_vm.is_selected) { + // self destruct + row_vm.updated -= on_updated; + return; + } + var new_root = _get_root(change.newval); + if (!new_root.Equals(root)) { + _selected_params_mon.on_row_unselected(root); + _selected_params_mon.on_row_selected(new_root); + root = new_root; + } + } } } RowSelectionHelper.apply_changes(selected_rows, e); @@ -552,20 +563,15 @@ namespace mbts.spark { public bool try_get_parent(OrderBookRowVM row, out OrderSecurity parent) => _cached_orders.TryGetValue(row.parent_order_key, out parent); - public OrderBookRowVM get_root(OrderBookRowVM r) { - while (r.order.ParentKey != 0 ) { - var parent = get_parent(r); - if (parent != null) { - r = parent; - } - } - return r; + OrderBookRowVM _get_root_row(OrderBookRowVM row) { + while (row.parent_order_key != 0 && _row_collection.get_parent(row.parent_order_key) is OrderBookRowVM prow) + row = prow; + return row; } - public OrderSecurity get_root(OrderSecurity os) { - while (os.order.ParentKey != 0 && _cached_orders.TryGetValue(os.order.ParentKey, out var parent_osam)) { - os = parent_osam; - } + OrderSecurity _get_root(OrderSecurity os) { + while (os.order.ParentKey != 0 && _cached_orders.TryGetValue(os.order.ParentKey, out var pos)) + os = pos; return os; } @@ -638,9 +644,8 @@ namespace mbts.spark { } } - async Task _modify_selected_orders_async() => await _modify_orders_async(selected_rows.Select(r => get_root(r.order_tuple))); - - async Task _modify_orders_async(IEnumerable modify_candidates) { + // Note: modifications are performed on the selected orders' ROOT orders. + async Task _modify_selected_orders_async() { double? price = DoubleHelper.nan_nullable(order_mod_vm.price); uint? size = order_mod_vm.size; if (order_mod_vm.algo_vm.algo_root is IAlgoVM mod_algo_vm) { @@ -652,19 +657,20 @@ namespace mbts.spark { // their values will be cleared (in the param grid gui), and the modifications will not be applied. // FYI this behavior is implemented to support 'partial edits.' (e.g., changing the 'price' for multiple orders that do not have the same 'size'). // ---- - var update_params = modify_candidates.Select(update_params_factory).ToList(); + var update_params = selected_rows.Select(r => update_params_factory(_get_root(r.order_tuple))).ToList(); await Task.WhenAll(update_params.Select(t => _model.update_order(t.order, new_price: price, new_size: size, new_algo: t.new_algo))); - (OrderRecordImmutable order, CustomOrderDefinitionImmutable? new_algo) update_params_factory(OrderSecurity os) { - var mod_algo = os.order.Def.CustomDef.CloneToMutable(); + (OrderRecordImmutable order, CustomOrderDefinitionImmutable? new_algo) update_params_factory(OrderSecurity order_tuple) { + var mod_algo = order_tuple.order.Def.CustomDef.CloneToMutable(); if (mod_algo.CustomCase == CustomOrderDefinition.CustomOneofCase.Composite) { mod_algo_vm.assign_to(mod_algo.Composite.Definition); } else { mod_algo_vm.assign_to(mod_algo); } var mod_algoi = new CustomOrderDefinitionImmutable(mod_algo); - return (os.order, OrderDataHelper.EqualsHelpers.equals(os.order.Def.CustomDef, mod_algoi) ? (CustomOrderDefinitionImmutable?)null : mod_algoi); + return (order_tuple.order, OrderDataHelper.EqualsHelpers.equals(order_tuple.order.Def.CustomDef, mod_algoi) ? (CustomOrderDefinitionImmutable?)null : mod_algoi); } - } else await Task.WhenAll(modify_candidates.Select(r => _model.update_order(r.order, price))); + } else await Task.WhenAll(selected_rows.Select(r => _model.update_order(r.order, price))); + selected_rows.ForEach(r => r.is_selected = false); } IObservable> _subscribe_throttled_selected_rows() => @@ -1035,15 +1041,11 @@ namespace mbts.spark { public IDisposable begin_udpate() => _group_mon.defer_updates(); - public void on_row_selected(OrderBookRowVM row) { - _group_mon.add(row.order_tuple); - row.updated += _on_row_updated; - } + public void on_row_selected(OrderSecurity order_tuple) => + _group_mon.add(order_tuple); - public void on_row_unselected(OrderBookRowVM row) { - _group_mon.remove(row.order_tuple); - row.updated -= _on_row_updated; - } + public void on_row_unselected(OrderSecurity order_tuple) => + _group_mon.remove(order_tuple); public void on_security_md_map(IReadOnlyDictionary security_md_map) { _security_md_map = security_md_map; From 93534eb8010d86d62620497bd17147c378083b62 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Tue, 11 Jun 2019 10:57:07 -0500 Subject: [PATCH 12/42] changing row selection while in change breaks the main ob --- src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 8986731bc..9c4dbaa8c 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -670,7 +670,6 @@ namespace mbts.spark { return (order_tuple.order, OrderDataHelper.EqualsHelpers.equals(order_tuple.order.Def.CustomDef, mod_algoi) ? (CustomOrderDefinitionImmutable?)null : mod_algoi); } } else await Task.WhenAll(selected_rows.Select(r => _model.update_order(r.order, price))); - selected_rows.ForEach(r => r.is_selected = false); } IObservable> _subscribe_throttled_selected_rows() => From d64df2718875042f051bf936b5947f356f4ecafd Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Tue, 11 Jun 2019 12:27:51 -0500 Subject: [PATCH 13/42] don't change is_selected state here b/c it leads to discrepancies when attaching/updating --- src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 9c4dbaa8c..bb79529bc 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -579,7 +579,8 @@ namespace mbts.spark { if (order.is_selected) { var detach_candidates = rows.Where(r => r.is_selected); _detach_orders_async(detach_candidates).ignore(); - detach_candidates.ForEach((row_vm) => row_vm.is_selected = false); + // Don't change the is_selecte state here b/c it will cause state issues + // in with the miniob attach param popup } else { _detach_orders_async(new[] { order }).ignore(); } From a7da930e697190ebf6f120c0b91142ffeb3e1d95 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Tue, 11 Jun 2019 14:02:23 -0500 Subject: [PATCH 14/42] synchronize selected_rows with _un/select_me() --- src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs index 2f767c6d2..8c13ef0e6 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs @@ -237,11 +237,13 @@ namespace mbts.spark { private void _unselect_me() { this.is_selected = false; + _owner.selected_rows.Remove(this); _owner.current_row = null; } private void _select_me() { this.is_selected = true; + _owner.selected_rows.Add(this); _owner.current_row = this; } From 44e7cfb4a50fa145694a239913ef323e7064384e Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Tue, 11 Jun 2019 14:06:08 -0500 Subject: [PATCH 15/42] setting is_selected and clearing selected_rows when update popup closes --- .../spark/Modules/Trading/OrderBook/OrderBookColumns.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 0ac341136..66876feab 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -1116,8 +1116,11 @@ namespace mbts.spark { RelativeSource = new RelativeSource(RelativeSourceMode.Self) }); popup.Closed += (s, e) => { - if (popup.try_find_ancestor_of_type(out MiniOrderBookView mini_ob) && mini_ob.DataContext is OrderBookVM ob_vm) + if (popup.try_find_ancestor_of_type(out MiniOrderBookView mini_ob) && mini_ob.DataContext is OrderBookVM ob_vm) { ob_vm.is_attaching_orders = false; + ob_vm.selected_rows.ForEach(r => r.is_selected = false); + ob_vm.selected_rows.Clear(); + } }; var the_whole_thing = new Grid(); From 4854a06edac9dfac442691d57a1b0c590518cc96 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 08:12:48 -0500 Subject: [PATCH 16/42] fix SelectionHighlight databinding expression in mini ob --- .../Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml b/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml index 6cc0ec713..7450bd576 100644 --- a/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml +++ b/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml @@ -121,7 +121,7 @@ Rows="{Binding rows}" RowStyle="{StaticResource {x:Static sp:MiniOrderBookView.RowStyleKey}}" RowTemplate="{StaticResource {x:Static sp:MiniOrderBookView.RowTemplateKey}}" - SelectionHighlight="{Binding grid_settings_manager.selection_highlight, Mode=OneWay}" + SelectionHighlight="{Binding grid_settings_manager.core_manager.selection_highlight, Mode=OneWay}" RowsHorizontalScrollBarVisibility="Collapsed" RowHeight="20" > From b21cd840c290b4a12fa3c410d16b4c4918c2e946 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 08:23:55 -0500 Subject: [PATCH 17/42] The first time I met the blues, I was losing my SelectionHighlight; too beat down to remove this Setter that was added over many hours of debugging --- .../OrderBook/MiniOrderBook/MiniOrderBookView.xaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml b/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml index 7450bd576..a3c025aa5 100644 --- a/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml +++ b/src/client/spark/Modules/Trading/OrderBook/MiniOrderBook/MiniOrderBookView.xaml @@ -99,7 +99,16 @@ - + + From 40805be11eb1cd410238be15e8d15283b5a5f40a Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 08:27:39 -0500 Subject: [PATCH 18/42] Bringing back the check column in case of SelectionHighlight shenanigans --- .../Trading/OrderBook/OrderBookColumns.cs | 38 +++++++++---------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 66876feab..1f8c4105c 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -724,27 +724,27 @@ namespace mbts.spark { } } - //public class CheckColumn : FrameworkElementColumnBase { - // readonly BindingBase _checked_binding; - // public CheckColumn(string checked_property) : base(Columns.Check) { - // id = key.ToString(); - // Width = 30; - // _checked_binding = new Binding(checked_property); - // } + public class CheckColumn : FrameworkElementColumnBase { + readonly BindingBase _checked_binding; + public CheckColumn(string checked_property) : base(Columns.Check) { + id = key.ToString(); + Width = 30; + _checked_binding = new Binding(checked_property); + } - // public override FrameworkElement view_factory() { - // var grid = new Grid() { - // HorizontalAlignment = HorizontalAlignment.Center, - // VerticalAlignment = VerticalAlignment.Center, - // }; - // var cb = new CheckBox(); - // cb.Name = "check_col"; - // cb.SetBinding(CheckBox.IsCheckedProperty, _checked_binding); + public override FrameworkElement view_factory() { + var grid = new Grid() { + HorizontalAlignment = HorizontalAlignment.Center, + VerticalAlignment = VerticalAlignment.Center, + }; + var cb = new CheckBox(); + cb.Name = "check_col"; + cb.SetBinding(CheckBox.IsCheckedProperty, _checked_binding); - // grid.Children.Add(cb); - // return grid; - // } - //} + grid.Children.Add(cb); + return grid; + } + } public class CancelColumn : FrameworkElementColumnBase { readonly BindingBase _command_binding; From 114c9f3c2791d74eee0f8398daf6ffc76fbfac4d Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 08:28:56 -0500 Subject: [PATCH 19/42] Adding resurrected check column back to mini ob, bound to is_selected --- src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs index 11ad2036e..1de41351e 100644 --- a/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs +++ b/src/client/spark/Modules/Trading/Ladder/VM/LadderOrderVM.cs @@ -337,7 +337,7 @@ namespace mbts.spark { } obvm.columns.Insert(0, new OrderBookVM.UpdateColumn(typeof(MiniOrderBookView))); obvm.columns.Insert(0, new OrderBookVM.CancelColumn(nameof(OrderBookRowVM.cancel_command))); - //obvm.columns.Insert(0, new OrderBookVM.CheckColumn(nameof(OrderBookRowVM.is_checked))); + obvm.columns.Insert(0, new OrderBookVM.CheckColumn(nameof(OrderBookRowVM.is_selected))); obvm.load_from(state); return obvm; From c2e91b03f62c074b1ef874cf7ec99b3545252be2 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 09:40:35 -0500 Subject: [PATCH 20/42] Adding similar IsSelected setter to main OB just in case ... --- .../Modules/Trading/OrderBook/View/OrderBookGridView.xaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml b/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml index b9c7a1421..916c3783e 100644 --- a/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml +++ b/src/client/spark/Modules/Trading/OrderBook/View/OrderBookGridView.xaml @@ -108,4 +108,9 @@ + + + \ No newline at end of file From e47706eb1b6d0dc0852fc82bf4c890403af38841 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 09:49:00 -0500 Subject: [PATCH 21/42] guaranteeing on_updating is hooked up to only a single callback; this was a major pain to debug, thx john --- .../Modules/Trading/OrderBook/OrderBookVM.cs | 20 ++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index bb79529bc..3ec1c118a 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -64,6 +64,7 @@ namespace mbts.spark { _attachable_selected_orders = new HashSet(), _detachable_selected_orders = new HashSet(); FilterData _cached_filter_data; + Dictionary _on_updated_single_callback_gatekeeper = new Dictionary(); public OrderBookVM( IObservable owner_title, @@ -440,7 +441,10 @@ namespace mbts.spark { foreach (var row_vm in e.AddedItems.OfType()) { var root = _get_root(row_vm.order_tuple); row_vm.is_selected = true; - row_vm.updated += on_updated; + if (!_on_updated_single_callback_gatekeeper.ContainsKey(row_vm.order_key)) { + row_vm.updated += on_updated; + _on_updated_single_callback_gatekeeper.Add(row_vm.order_key, Disposable.Create(() => row_vm.updated -= on_updated)); + } _selected_params_mon.on_row_selected(root); if (row_vm.is_attachable) _attachable_selected_orders.Add(row_vm.order_key); @@ -449,13 +453,19 @@ namespace mbts.spark { void on_updated((OrderSecurity oldval, OrderSecurity newval) change) { if (!row_vm.is_selected) { // self destruct - row_vm.updated -= on_updated; + if (_on_updated_single_callback_gatekeeper.TryGetValue(row_vm.order_key, out var unsubscribe_updated_disposable)) { + unsubscribe_updated_disposable.Dispose(); + _on_updated_single_callback_gatekeeper.Remove(row_vm.order_key); + } + _selected_params_mon.on_row_unselected(_get_root(row_vm.order_tuple)); return; } var new_root = _get_root(change.newval); if (!new_root.Equals(root)) { - _selected_params_mon.on_row_unselected(root); - _selected_params_mon.on_row_selected(new_root); + // unselect and select in one smooth motion via on_row_updated + // because we thought there may be gremlins afoot when doing + // on_row_unselected and then on_row_selected + _selected_params_mon.on_row_updated((root, new_root)); root = new_root; } } @@ -1052,7 +1062,7 @@ namespace mbts.spark { _security_md_map_changed?.Invoke(); } - void _on_row_updated((OrderSecurity oldval, OrderSecurity newval) ch) { + public void on_row_updated((OrderSecurity oldval, OrderSecurity newval) ch) { using (begin_udpate()) { _group_mon.remove(ch.oldval); _group_mon.add(ch.newval); From b57d6cce85f2cea195776cfeaed3fad0a1aea2b1 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 09:52:22 -0500 Subject: [PATCH 22/42] select/unselect me only needs to manipulate row.is_selected now --- src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs index 8c13ef0e6..c605a4630 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookRowVM.cs @@ -237,14 +237,10 @@ namespace mbts.spark { private void _unselect_me() { this.is_selected = false; - _owner.selected_rows.Remove(this); - _owner.current_row = null; } private void _select_me() { this.is_selected = true; - _owner.selected_rows.Add(this); - _owner.current_row = this; } // These fns present a way for the orderbook to avoid noisy, intermittent collection changes during "Expand/Collapse All" ops, From 164c88fa60682e0251c0353b2388160e71286f4b Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 09:56:03 -0500 Subject: [PATCH 23/42] popup debug comments --- src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 1f8c4105c..2afe9f50e 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -879,6 +879,7 @@ namespace mbts.spark { // We take our original ICommand (send_attached) and wrap it in another Command by way of a Converter on the binding, // pure genious! var send_attach_button_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.send_attached_orders_cmd))) { + // set to true for debugging Converter = CommandWithActionWrapper.mk_wrap_converter(() => popup.IsOpen = false) }; send_attach_button_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(Popup), 1); @@ -929,6 +930,7 @@ namespace mbts.spark { #endregion popup.Child = border; + // set to true for debugging popup.StaysOpen = false; popup.PlacementTarget = attach_button; popup.Placement = PlacementMode.Bottom; @@ -1057,6 +1059,7 @@ namespace mbts.spark { // We take our original ICommand (send_attached) and wrap it in another Command by way of a Converter on the binding, // pure genious! var modify_selected_button_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.modify_selected_orders_cmd))) { + // set to true for debugging Converter = CommandWithActionWrapper.mk_wrap_converter(() => popup.IsOpen = false) }; modify_selected_button_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(Popup), 1); From 4b7adbe0c9b2bb2ee4478c81166258ebb9fc7bdb Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 09:59:48 -0500 Subject: [PATCH 24/42] adding tooltip to update button --- src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 2afe9f50e..5a3ca9786 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -1002,7 +1002,8 @@ namespace mbts.spark { Content = "···", Margin = new Thickness(2), VerticalAlignment = VerticalAlignment.Center, - Focusable = false + Focusable = false, + ToolTip = "Update" }; update_button.Click += (s, e) => { popup.IsOpen = !popup.IsOpen; }; From 5c79a08f0ed0a7fa0c90e757556209b45dd5bb4e Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 10:53:15 -0500 Subject: [PATCH 25/42] popup close event no longer messes with selected_rows --- src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index 5a3ca9786..aee502117 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -1122,8 +1122,6 @@ namespace mbts.spark { popup.Closed += (s, e) => { if (popup.try_find_ancestor_of_type(out MiniOrderBookView mini_ob) && mini_ob.DataContext is OrderBookVM ob_vm) { ob_vm.is_attaching_orders = false; - ob_vm.selected_rows.ForEach(r => r.is_selected = false); - ob_vm.selected_rows.Clear(); } }; From 4a758c75541af40ae094f3986aa1cba5eed4fcfd Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 10:54:02 -0500 Subject: [PATCH 26/42] misc comment cleanup, line endings or something --- .../Modules/Trading/OrderBook/OrderBookColumns.cs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs index aee502117..77a5e18f8 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookColumns.cs @@ -851,13 +851,13 @@ namespace mbts.spark { var row_vm_attach_command_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookRowVM.attach_command))); row_vm_attach_command_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); - attach_button.SetBinding(Button.CommandProperty, row_vm_attach_command_binding); + attach_button.SetBinding(Button.CommandProperty, row_vm_attach_command_binding); #region OrderParamsPanel // finally, set the order_params DataContext to that of the ContextMenu var order_params = AlgoEditorGridView.create_attach_view(); var order_params_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.attach_vm))); - order_params_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(Popup), 1); + order_params_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(Popup), 1); order_params.SetBinding(FrameworkElement.DataContextProperty, order_params_binding); order_params.SetBinding(AlgoEditorGridView.AlgoRootsProperty, new Binding(WPFHelper.join_binding_paths(nameof(OrderParamsVM.algo_vm), nameof(AlgoDefinitionVM.algo_roots)))); order_params.SetBinding(AlgoEditorGridView.SelectedAlgoRootProperty, new Binding(WPFHelper.join_binding_paths(nameof(OrderParamsVM.algo_vm), nameof(AlgoDefinitionVM.algo_root)))); @@ -938,7 +938,6 @@ namespace mbts.spark { popup.SetBinding(Popup.DataContextProperty, new Binding("PlacementTarget.DataContext") { RelativeSource = new RelativeSource(RelativeSourceMode.Self) }); - #endregion #region Detach Button @@ -1026,23 +1025,20 @@ namespace mbts.spark { }; update_button_visibility_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(MiniOrderBookRowView), 1); update_button.SetBinding(Button.VisibilityProperty, update_button_visibility_binding); - - #endregion #region OrderParamsPanel - // finally, set the order_params DataContext to that of the ContextMenu var order_params = new AlgoEditorGridView { Margin = new Thickness(6), CanUserChangeAlgoRoot = false, }; - ; var order_params_binding = new Binding(WPFHelper.join_binding_paths("DataContext", nameof(OrderBookVM.order_mod_vm))); order_params_binding.RelativeSource = new RelativeSource(RelativeSourceMode.FindAncestor, typeof(Popup), 1); order_params.SetBinding(FrameworkElement.DataContextProperty, order_params_binding); order_params.SetBinding(AlgoEditorGridView.AlgoRootsProperty, new Binding(WPFHelper.join_binding_paths(nameof(OrderParamsVM.algo_vm), nameof(AlgoDefinitionVM.algo_roots)))); order_params.SetBinding(AlgoEditorGridView.SelectedAlgoRootProperty, new Binding(WPFHelper.join_binding_paths(nameof(OrderParamsVM.algo_vm), nameof(AlgoDefinitionVM.algo_root)))); order_params.SetBinding(AlgoEditorGridView.AlgoParamRowsProperty, new Binding(nameof(OrderParamsVM.param_rows))); + #endregion #region Dialog Skirt From c2f6b0156759936d53284c0f0bfd80da60c858b8 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 10:54:24 -0500 Subject: [PATCH 27/42] debugging comment --- src/client/spark/Modules/Trading/Ladder/View/LadderOrdersHost.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/client/spark/Modules/Trading/Ladder/View/LadderOrdersHost.cs b/src/client/spark/Modules/Trading/Ladder/View/LadderOrdersHost.cs index ac4354874..6ccb3d81c 100644 --- a/src/client/spark/Modules/Trading/Ladder/View/LadderOrdersHost.cs +++ b/src/client/spark/Modules/Trading/Ladder/View/LadderOrdersHost.cs @@ -139,6 +139,7 @@ namespace mbts.spark { // properly Dispose of it later when the popup is closed. DataContext = obvm, Child = view, + // StaysOpen true for debugging StaysOpen = false, PlacementTarget = popup_placement_target, Placement = System.Windows.Controls.Primitives.PlacementMode.Bottom, From 0d020e98212f8720672958f16b84a979c4139d80 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Wed, 12 Jun 2019 14:48:36 -0500 Subject: [PATCH 28/42] updating manual test --- testing/manual/orders/mini_ob.txt | 57 +++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/testing/manual/orders/mini_ob.txt b/testing/manual/orders/mini_ob.txt index 1858ef6d3..b2dd6ca8c 100644 --- a/testing/manual/orders/mini_ob.txt +++ b/testing/manual/orders/mini_ob.txt @@ -51,5 +51,62 @@ A(attach)/D(etach) buttons Verify the limit row's D button has now changed to an A Verify the limit row is no longer a child to the IB Verify the IB order is now canceled + +Multi-selection specific tests +------------------------------ + +Prerequisites + Place 10 1-lots at a specific price in the ladder + Have the mini ob open + + Cancel + ------ + Select any 2 rows by however you feel like it - click and drag, ctrl + click, clicking on checkbox column + Note the rows you have chosen, perhaps by time + Click the red cancel icon and the your selected orders should be cancelled + Attach + ------ + Select any 2 rows + Click the attach icon and then OK to attach to an IB + If you're feeling adventurous, attach to a different Algo + The following should happen to your selected rows: + Update buttons should be visible + The black attach icon should change to the red detach icon + The root algo column should reflect IB (the root algo badge as well) + + Detach + ------ + Select the previously attached rows from our prior attach step + Click the detach icon + The following should happen to your selected rows: + Update buttons should disappear + The red detach icon should change to the black attach icon + The root algo column should reflect a standard Limit(the root algo badge as well) + For extra credit, repeat the detach step here but also include some non-attached rows as well + + Update + ------ + Perform the following WITHOUT closing the mini ob: + + Attach an IB with show qty 1 to any 2 rows + Click update (...) button, modify the show quantity to 2, and hit ok + Uncheck one of the selected rows + Hit the update button in the currently selected row and verify the show quantity reads 2, hit cancel + + Uncheck your current row, so there should be no rows currently selected + + Hit the update button in the *other* row and verify the show quantity reads 2 there as well, now change the show quantity to 3 + Uncheck your current row + Hit the update button in the *other* row and verify the show quantity *still* reads 2. + + Check both rows and hit the update button + Show quantity should display as '-' signifying that the 2 rows have differing show quantities + + Uncheck all rows + Select one of the currently IB-controlled rows and a regular limit order and hit the update button + You should see the param popup effectively display as empty as these are incompatible order types selected + Cancel to return back to mini ob + + \ No newline at end of file From 12dd3909bfc32aedaa92d2a3cbf95a8deb015b40 Mon Sep 17 00:00:00 2001 From: Michael Harding Date: Thu, 13 Jun 2019 12:49:13 -0400 Subject: [PATCH 29/42] Fix documentation deploy --- doc/user/deploy_to_web.sh | 5 ----- 1 file changed, 5 deletions(-) diff --git a/doc/user/deploy_to_web.sh b/doc/user/deploy_to_web.sh index 5b6339c66..f80a67ed5 100644 --- a/doc/user/deploy_to_web.sh +++ b/doc/user/deploy_to_web.sh @@ -1,7 +1,6 @@ #/bin/bash #python -m mkdocs build -d site -cp -r ../../src/sdk/doc/* ./content/bts_spark_sdk/Server/ ./run_zola.sh build scp -r ./public bts@bluetradesys.com:/home/bts/doc/ @@ -14,7 +13,3 @@ sudo mv ./public/* /var/www/documentation/ EOF rm -r public -cd ./content/bts_spark_sdk/server/ -find . -not -name '_index.md' -delete -cd ../.. - From 5a54b37af7f8d18781061d7a7d63cab564036731 Mon Sep 17 00:00:00 2001 From: Michael Harding Date: Thu, 13 Jun 2019 13:07:42 -0400 Subject: [PATCH 30/42] Move system requirements to Docs --- .../content/system_requirements/_index.md | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 doc/user/content/system_requirements/_index.md diff --git a/doc/user/content/system_requirements/_index.md b/doc/user/content/system_requirements/_index.md new file mode 100644 index 000000000..d5f9e5ae9 --- /dev/null +++ b/doc/user/content/system_requirements/_index.md @@ -0,0 +1,55 @@ ++++ +title = "System Requirements" +weight = 4 +sort_by = "weight" +insert_anchor_links = "right" ++++ + + +### Minimum Workstation +* New XPS Tower +* 8th Generation Intel® Core™ i7-8700 6-Core Processor (12M Cache, up to 4.6 GHz) +* 16GB, 2666MHz, DDR4 up to 64GB +* Windows 10 Professional 64-bit +* NVIDIA® GeForce® GTX 1070 with 8GB GDDR5 Graphics Memory +* 1 x 2.5" 256GB SATA Solid State Drive + +### Recommended Workstation +* Similar or better than: +* Dell Precision Tower 5820 +* Intel Xeon W-2145 3.7GHz, 4.5GHz Turbo, 8C, 11M Cache, HT, (140W) DDR4-2666 +* Windows 10 Professional 64-bit +* NVIDIA® Quadro® P1000, 4GB, 4 mDP +* 16GB (4x4GB) 2133MHz DDR4 RDIMM ECC +* 2 x 2.5" 256GB SATA Solid State Drive running RAID1 + + +### BTS Recommended Server Specifications +* Dell R640 +* 2x Intel Xeon Gold 6148 2.40GHz 20-Core Processors. For better performance BTS recommends Intel® Xeon® Platinum 8268 2.9G, 24 Core CPU +* 192GB RAM 2666MHz DDR4 +* 3x 480GB SSD RAID 5 HBA Minicard +* iDRAC 9 Enterprise +* Embedded Broadcom NIC +* Solarflare SFN8522-R2 +* Redundant Power Supply + +### BTS Minimum Server Specifications +* Dell R620 +* Chassis with up to 8, 2.5” Hard Drives, up to 2 PCIe Slots (With Optional Riser) +* 2 x Intel® E5-2670 (16 total cores/ 32 total threads) +* 64GB total memory +* RAID 1 for H330/H730/H730P +* PERC H730 RAID Controller, 1GB NV Cache +* 3 x 300GB 10K RPM SATA 6Gbps 2.5in Hot-plug Hard Drive (RAID 5) +* iDRAC8 Enterprise, integrated Dell Remote Access Controller, Enterprise (varies by hosting company) +* Solarflare Ultra SFN7122F Dual-Port 10GbE (10 GB connectivity requirements, copper vs optical, varies by hosting company). +* Dual, Hot-plug, Redundant Power Supply (1+1), 750W +* Performance BIOS Setting +* ReadyRails Sliding Rails Without Cable Management Arm (varies by hosting company) + +### Edge Tablet Requirements +* Similar or better than: +* Microsoft Surface Pro 4 Or Motion R12 +* Intel i7 +* 8 GB DDR4 RAM \ No newline at end of file From e8d799a0f66f8bb204ad8d413aef5d006f751895 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 14 Jun 2019 09:00:17 -0500 Subject: [PATCH 31/42] PR refactoring detach --- .../spark/Modules/Trading/OrderBook/OrderBookVM.cs | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 1bbec8df9..65850bd5c 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -584,14 +584,11 @@ namespace mbts.spark { return os; } - internal void detach_orders(OrderBookRowVM order) { - if (order.is_selected) { - var detach_candidates = rows.Where(r => r.is_selected); - _detach_orders_async(detach_candidates).ignore(); - // Don't change the is_selecte state here b/c it will cause state issues - // in with the miniob attach param popup + internal void detach_orders(OrderBookRowVM row) { + if (row.is_selected) { + _detach_orders_async(selected_rows).ignore(); } else { - _detach_orders_async(new[] { order }).ignore(); + _detach_orders_async(new[] { row }).ignore(); } } From 213fb1de594557e34b1f27cdf6e9c24bc54367ea Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 14 Jun 2019 09:00:30 -0500 Subject: [PATCH 32/42] PR refactoring cancel --- src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 65850bd5c..e14b4e3d8 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -608,7 +608,7 @@ namespace mbts.spark { internal void cancel_order(OrderBookRowVM row) { if (row.is_selected) { - rows.Where(r => r.is_selected).ForEach((selected_row) => _bus.post(SparkTags.CancelOrders, new List { selected_row.order_key })); + _bus.post(SparkTags.CancelOrders, selected_rows.Select(r => r.order_key).ToList()); } else { _bus.post(SparkTags.CancelOrders, new List { row.order_key }); } From f34f718c721b1a56ad20490ae606f7997c7d4176 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 14 Jun 2019 09:02:24 -0500 Subject: [PATCH 33/42] PR rename on_row_selected --- src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index e14b4e3d8..e5993412f 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -444,7 +444,7 @@ namespace mbts.spark { row_vm.updated += on_updated; _on_updated_single_callback_gatekeeper.Add(row_vm.order_key, Disposable.Create(() => row_vm.updated -= on_updated)); } - _selected_params_mon.on_row_selected(root); + _selected_params_mon.on_order_selected(root); if (row_vm.is_attachable) _attachable_selected_orders.Add(row_vm.order_key); if (row_vm.is_detachable) @@ -1047,7 +1047,7 @@ namespace mbts.spark { public IDisposable begin_udpate() => _group_mon.defer_updates(); - public void on_row_selected(OrderSecurity order_tuple) => + public void on_order_selected(OrderSecurity order_tuple) => _group_mon.add(order_tuple); public void on_row_unselected(OrderSecurity order_tuple) => From ad0b1756b121fd5ccd95eb690787c0c0be1d4307 Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 14 Jun 2019 09:03:07 -0500 Subject: [PATCH 34/42] PR rename on_row_unselected --- src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index e5993412f..a7808fd64 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -431,7 +431,7 @@ namespace mbts.spark { if (e.RemovedItems != null) { foreach (var row_vm in e.RemovedItems.OfType()) { row_vm.is_selected = false; - _selected_params_mon.on_row_unselected(_get_root(row_vm.order_tuple)); + _selected_params_mon.on_order_unselected(_get_root(row_vm.order_tuple)); _attachable_selected_orders.Remove(row_vm.order_key); _detachable_selected_orders.Remove(row_vm.order_key); } @@ -456,7 +456,7 @@ namespace mbts.spark { unsubscribe_updated_disposable.Dispose(); _on_updated_single_callback_gatekeeper.Remove(row_vm.order_key); } - _selected_params_mon.on_row_unselected(_get_root(row_vm.order_tuple)); + _selected_params_mon.on_order_unselected(_get_root(row_vm.order_tuple)); return; } var new_root = _get_root(change.newval); @@ -1050,7 +1050,7 @@ namespace mbts.spark { public void on_order_selected(OrderSecurity order_tuple) => _group_mon.add(order_tuple); - public void on_row_unselected(OrderSecurity order_tuple) => + public void on_order_unselected(OrderSecurity order_tuple) => _group_mon.remove(order_tuple); public void on_security_md_map(IReadOnlyDictionary security_md_map) { From d678d202c1f03c454df90fa16663cc5a6ee8f44f Mon Sep 17 00:00:00 2001 From: Jake Norbut Date: Fri, 14 Jun 2019 09:04:09 -0500 Subject: [PATCH 35/42] PR rename on_row_updated --- src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index a7808fd64..bb9da3e0d 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -464,7 +464,7 @@ namespace mbts.spark { // unselect and select in one smooth motion via on_row_updated // because we thought there may be gremlins afoot when doing // on_row_unselected and then on_row_selected - _selected_params_mon.on_row_updated((root, new_root)); + _selected_params_mon.on_order_updated((root, new_root)); root = new_root; } } @@ -1058,7 +1058,7 @@ namespace mbts.spark { _security_md_map_changed?.Invoke(); } - public void on_row_updated((OrderSecurity oldval, OrderSecurity newval) ch) { + public void on_order_updated((OrderSecurity oldval, OrderSecurity newval) ch) { using (begin_udpate()) { _group_mon.remove(ch.oldval); _group_mon.add(ch.newval); From 3dda3e7f758466a6cafdbda5ba720ea6c396d1be Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Fri, 14 Jun 2019 10:44:38 -0400 Subject: [PATCH 36/42] Allow cover order to continue even if hedgding child is canceled. --- src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp index 01dff07fb..86f2cf008 100644 --- a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp +++ b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp @@ -134,17 +134,12 @@ void CoverAlgo::on_child_change(OrderKey k, ChildState const &st) { switch (st.status) { case ChildStatus::WORKING: break; + case ChildStatus::CANCELED: case ChildStatus::COMPLETED: if (auto it = std::find(me->hedges.begin(), me->hedges.end(), k); it != me->hedges.end()) me->hedges.erase(it); break; - case ChildStatus::CANCELED: - LOG(OrderMan, Info, "CoverAlgo {}. Hedge was canceled, terminating", - algo().order_key().value()); - me->status = Status::DONE; - algo().terminate_error("Unexpected child cancel"); - break; } } check_terminate(); From ed23bc7e2b30bcd5e573812a3665dd540f347c6c Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Fri, 14 Jun 2019 10:50:34 -0400 Subject: [PATCH 37/42] Enhanced the API to allow algos to implement custom cancel handling --- .../orderman/orders/algo/AlgoWrapperOrder.cpp | 18 ++++++++++++++---- src/lib/orderman/orders/algo/IAlgoOrder.h | 8 ++++++++ 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp b/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp index b14e7c7ef..950c619a3 100644 --- a/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp +++ b/src/lib/orderman/orders/algo/AlgoWrapperOrder.cpp @@ -135,9 +135,9 @@ void AlgoWrapperOrder::on_init_new(OrderDefinition const &def, if (can_consume_attachment(me->definition.custom_def().custom_case())) { me->attach_target = OrderKey(me->definition.attach_target_order_key()); me->definition.clear_attach_target_order_key(); - } - else { - terminate(ORDER_STATUS_REJECTED_BY_SPARK, "Algo does not support attachment"); + } else { + terminate(ORDER_STATUS_REJECTED_BY_SPARK, + "Algo does not support attachment"); return; } } @@ -290,9 +290,19 @@ orderman::OrderOpResult AlgoWrapperOrder::on_cancel() { switch (me->status) { case Status::W_ATTACH: - case Status::WORKING: terminate(ORDER_STATUS_CANCELED); break; + case Status::WORKING: + switch (me->algo->on_cancel()) { + case IAlgoOrder::OnCancelResponse::HONOR: + cancel(); + break; + case IAlgoOrder::OnCancelResponse::IGNORE: + LOG(OrderMan,Info,"Algo order with key {} ignored cancel request", + key().value()); + break; + } + break; case Status::COMPLETED: break; case Status::INACTIVE: diff --git a/src/lib/orderman/orders/algo/IAlgoOrder.h b/src/lib/orderman/orders/algo/IAlgoOrder.h index 55f5d7679..3b882b49d 100644 --- a/src/lib/orderman/orders/algo/IAlgoOrder.h +++ b/src/lib/orderman/orders/algo/IAlgoOrder.h @@ -64,6 +64,14 @@ class IAlgoOrder { // implementation should validate the update and either apply it, // if valid or terminate with an error otherwise virtual void do_update(api::orderman::Update const &) {} + + // Override this method to provide custom handling of a cancel + // request. The default behaviour is to cancel both this order and + // recursively any of its children. Algos may override this method + // for example to detach from specific children before canceling or + // to implement custom cleanup behaviour when canceled. + enum class OnCancelResponse {IGNORE, HONOR}; + virtual OnCancelResponse on_cancel() {return OnCancelResponse::HONOR;} }; } // namespace orderman From bc3ab563bf1d5e2ab4c469f2bc3c51bcb0b02dd5 Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Fri, 14 Jun 2019 10:58:33 -0400 Subject: [PATCH 38/42] Changed Cover to detach its hedges when canceled. --- src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp | 7 +++++++ src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp index 86f2cf008..e96081023 100644 --- a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp +++ b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp @@ -209,5 +209,12 @@ void CoverAlgo::check_terminate() { } } +IAlgoOrder::OnCancelResponse CoverAlgo::on_cancel() +{ + for (auto &k : me->hedges) + algo().detach_child(k); + return IAlgoOrder::OnCancelResponse::HONOR; +} + } // namespace orderman } // namespace bts diff --git a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h index 3bedb00e7..203f93e5c 100644 --- a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h +++ b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h @@ -18,6 +18,7 @@ public: void do_launch_attached(IAlgoServices &, OrderKey, ChildState) override; void do_update(api::orderman::Update const &) override; void on_child_change(OrderKey, ChildState const &) override; + IAlgoOrder::OnCancelResponse on_cancel() override; private: struct PImpl; From 66d05c63afa930c101d6490dfb5d43d7330c808b Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Fri, 14 Jun 2019 14:25:04 -0400 Subject: [PATCH 39/42] Made cover cancel behaviour parameterizable. This implements the server side only, the UI does not expose this configuration so effectively the behaviour right now is hard-coded until we get around to adding the UI. --- src/lib/api/services/OrderService.proto | 2 ++ .../orders/algo/algo_orders/CoverAlgo.cpp | 31 +++++++++++++------ .../orders/algo/algo_orders/CoverAlgo.h | 2 +- 3 files changed, 24 insertions(+), 11 deletions(-) diff --git a/src/lib/api/services/OrderService.proto b/src/lib/api/services/OrderService.proto index 5c03be00b..2470930e5 100644 --- a/src/lib/api/services/OrderService.proto +++ b/src/lib/api/services/OrderService.proto @@ -174,6 +174,8 @@ message CoverOrderDefinition { CustomOrderDefinition hedge = 1; uint32 hedge_ticks = 2; CustomOrderDefinition child = 3; + bool cancel_on_external_hedge_cancel = 4; + bool cancel_hedges_on_cancel = 5; } message OffsetOrderDefinition { uint32 tick_offset_on_deploy = 1; diff --git a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp index e96081023..d7dd1a56f 100644 --- a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp +++ b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.cpp @@ -26,6 +26,8 @@ struct CoverAlgo::PImpl { IAlgoServices *algo; OrderKey child_key = null_order_key(); Price price_improvement_delta; + bool cancel_on_external_hedge_cancel = false; + bool cancel_hedges_on_cancel = false; ChildTemplate *child_template = nullptr; ChildTemplate *hedge_template = nullptr; Quantity hedged_fills = Quantity(0); @@ -64,7 +66,7 @@ OrderOpResult CoverAlgo::do_before_launch(IBeforeLaunchAlgoServices &serv) { } init_hedge_template(serv, cover.hedge()); - set_price_improvement_delta(serv, cover); + update_definition(serv, cover); return {}; } @@ -135,10 +137,16 @@ void CoverAlgo::on_child_change(OrderKey k, ChildState const &st) { case ChildStatus::WORKING: break; case ChildStatus::CANCELED: + if (me->cancel_on_external_hedge_cancel) { + LOG(OrderMan, Info, "CoverAlgo {}. Hedge was canceled, terminating", + algo().order_key().value()); + me->status = Status::DONE; + algo().terminate_error("Unexpected child cancel"); + } else + std::remove(me->hedges.begin(), me->hedges.end(), k); + break; case ChildStatus::COMPLETED: - if (auto it = std::find(me->hedges.begin(), me->hedges.end(), k); - it != me->hedges.end()) - me->hedges.erase(it); + std::remove(me->hedges.begin(), me->hedges.end(), k); break; } } @@ -162,7 +170,7 @@ void CoverAlgo::do_update(api::orderman::Update const &update) { // process custom part of the udpate if any if (update.has_custom()) { auto &cover_update = update.custom().cover(); - set_price_improvement_delta(algo(), cover_update); + update_definition(algo(), cover_update); if (cover_update.has_child()) { *child_update.mutable_custom() = cover_update.child(); } @@ -189,11 +197,14 @@ void orderman::CoverAlgo::init_hedge_template( me->hedge_template = &(algo.make_child_template(hedge_def)); } -void CoverAlgo::set_price_improvement_delta( +void CoverAlgo::update_definition( IBeforeLaunchAlgoServices &serv, api::orderman::CoverOrderDefinition const &cover) { me->price_improvement_delta = Price( securities::tick_size(serv.security()).value() * cover.hedge_ticks()); + me->cancel_hedges_on_cancel = cover.cancel_hedges_on_cancel(); + me->cancel_on_external_hedge_cancel = + cover.cancel_on_external_hedge_cancel(); } void CoverAlgo::check_terminate() { @@ -209,10 +220,10 @@ void CoverAlgo::check_terminate() { } } -IAlgoOrder::OnCancelResponse CoverAlgo::on_cancel() -{ - for (auto &k : me->hedges) - algo().detach_child(k); +IAlgoOrder::OnCancelResponse CoverAlgo::on_cancel() { + if (!me->cancel_hedges_on_cancel) + for (auto &k : me->hedges) + algo().detach_child(k); return IAlgoOrder::OnCancelResponse::HONOR; } diff --git a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h index 203f93e5c..24fb06cf5 100644 --- a/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h +++ b/src/lib/orderman/orders/algo/algo_orders/CoverAlgo.h @@ -26,7 +26,7 @@ private: std::unique_ptr me; IAlgoServices &algo() const; void - set_price_improvement_delta(IBeforeLaunchAlgoServices &, + update_definition(IBeforeLaunchAlgoServices &, api::orderman::CoverOrderDefinition const &); void init_hedge_template(IBeforeLaunchAlgoServices &, api::orderman::CustomOrderDefinition const &); From fef5b4edaa47c09dbb0baa628902de66d02c8b75 Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Mon, 17 Jun 2019 10:42:05 -0400 Subject: [PATCH 40/42] Updated release notes. --- doc/user/content/release_notes/_index.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/user/content/release_notes/_index.md b/doc/user/content/release_notes/_index.md index 09b6c5ed3..d0b293803 100644 --- a/doc/user/content/release_notes/_index.md +++ b/doc/user/content/release_notes/_index.md @@ -4,6 +4,12 @@ weight = 3 sort_by = "weight" insert_anchor_links = "right" +++ +## 2.3.0 +### User Visible Changes + - Changed cover order to continue even if hedgding child is canceled and detach from hedges if canceled +### API Changes + - Enhanced the API to allow algos to implement custom cancel handling + ## 2.2.0 ### User Visible Changes - Made our orders easier to spot in MBO display From 0f87973ee24dca701c2dc02a2d57e60dd55207ff Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Mon, 17 Jun 2019 10:53:22 -0400 Subject: [PATCH 41/42] Updated release notes. --- doc/user/content/release_notes/_index.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/user/content/release_notes/_index.md b/doc/user/content/release_notes/_index.md index d0b293803..f2575da24 100644 --- a/doc/user/content/release_notes/_index.md +++ b/doc/user/content/release_notes/_index.md @@ -7,6 +7,11 @@ insert_anchor_links = "right" ## 2.3.0 ### User Visible Changes - Changed cover order to continue even if hedgding child is canceled and detach from hedges if canceled + - Streamlined the mini order book as follows: + - We now only show exchange orders + - We now only display update buttons for orders that are under control of an algo with the update applying to the entire algo, not just the exchange order + - We can now select multiple rows to attach, detach, update or cancel multiple orders in a batch + - A checkbox column has been added to make clearer which rows are selected ### API Changes - Enhanced the API to allow algos to implement custom cancel handling From e7286e305da4e0ad86707f55c8faa4a0e6bbbeda Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Mon, 17 Jun 2019 10:57:33 -0400 Subject: [PATCH 42/42] Updated release notes. --- doc/user/content/release_notes/_index.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/user/content/release_notes/_index.md b/doc/user/content/release_notes/_index.md index f2575da24..4dbe96aaf 100644 --- a/doc/user/content/release_notes/_index.md +++ b/doc/user/content/release_notes/_index.md @@ -14,6 +14,8 @@ insert_anchor_links = "right" - A checkbox column has been added to make clearer which rows are selected ### API Changes - Enhanced the API to allow algos to implement custom cancel handling +### Internal Changes + - Added system requirements to Spark documentation ## 2.2.0 ### User Visible Changes