diff --git a/src/client/spark/view/Spark/Ladder/LadderGridHost.cs b/src/client/spark/view/Spark/Ladder/LadderGridHost.cs index 516ccf0f8..4c04913ba 100644 --- a/src/client/spark/view/Spark/Ladder/LadderGridHost.cs +++ b/src/client/spark/view/Spark/Ladder/LadderGridHost.cs @@ -55,7 +55,7 @@ namespace mbts.spark { LadderTactileAdorner _tactile_adorner; ulong _prices_updated; NativePriceSize[] _bids, _asks; - bool _price_dirty = false; + bool _price_dirty, _piq_dirty = false; double[] _price_list = null; IComparer _price_comparer; double _last_origin_price; @@ -235,11 +235,15 @@ namespace mbts.spark { case NotifyCollectionChangedAction.Add: foreach (LadderOrderVM item in e.NewItems) { _ordershost.add_order(item); + item.piq_changed += _set_piq_dirty; + _set_piq_dirty(); } break; case NotifyCollectionChangedAction.Remove: foreach (LadderOrderVM item in e.OldItems) { _ordershost.remove_order(item); + item.piq_changed -= _set_piq_dirty; + _set_piq_dirty(); } break; case NotifyCollectionChangedAction.Reset: @@ -250,6 +254,9 @@ namespace mbts.spark { throw new NotImplementedException(); } } + + void _set_piq_dirty() { _piq_dirty = true; } + #endregion Column[] columns { get; set; } = new Column[0]; @@ -438,6 +445,7 @@ namespace mbts.spark { _prices_updated = 0; _price_comparer = Comparer.Create((x, y) => security.ContractSpec.tick_equals(x, y) ? 0 : y.CompareTo(x)); _price_dirty = true; + _piq_dirty = true; _vm.on_tick += _tick; _settings_sub = _vm.settings.OnDispatcher().Subscribe(_settings_updated); _volume_sub = _vm.model.md_auxiliary_model.security_volume_at_price(security.Id).Subscribe(t => _volume_container.write_value(t.state.Values)); @@ -523,8 +531,10 @@ namespace mbts.spark { if (depth_changed) _refresh_sizes(); } - // TODO - detect changes in PIQ to selectively redraw - _refresh_piq(); + if (_piq_dirty) { + _refresh_piq(); + _piq_dirty = false; + } _refresh_volume_at_price(); _last_origin_price = _mkt_break_lines.origin; _price_dirty = false; @@ -565,8 +575,7 @@ namespace mbts.spark { if (!_settings.piq_column.show) return; int origin_index = LadderRender.index_of(_price_list, _mkt_break_lines.origin, _price_comparer); - var piq_list = _vm.price_vs_piq; - LadderRender.render_piqs(_piq_vis_tup.visual, _last_vis_tup.glyph_context, origin_index, _price_list, piq_list.ToArray(), _settings.row_height, security.ContractSpec, _settings.piq_column); + LadderRender.render_piqs(_piq_vis_tup.visual, _last_vis_tup.glyph_context, origin_index, _price_list, _vm.price_vs_piq.ToArray(), _settings.row_height, security.ContractSpec, _settings.piq_column); } void _refresh_sizes() { diff --git a/src/client/spark/view/Spark/Ladder/LadderOrderVM.cs b/src/client/spark/view/Spark/Ladder/LadderOrderVM.cs index a78ff0443..f4b173b3d 100644 --- a/src/client/spark/view/Spark/Ladder/LadderOrderVM.cs +++ b/src/client/spark/view/Spark/Ladder/LadderOrderVM.cs @@ -44,6 +44,9 @@ namespace mbts.spark { double _real_price = double.NaN, _phantom_price = double.NaN; uint filled, quantity; int working_quantity; + uint? _min_piq = UInt32.MaxValue; + + public event Action piq_changed; LadderModel model => _parent.model; Dictionary _orders = new Dictionary(); @@ -134,10 +137,22 @@ namespace mbts.spark { public void add_order((OrderRecordImmutable order, uint? p) new_op) { _orders[new_op.order.Key] = new_op; + // reevaluate min piq if this order's piq is less + if (new_op.p.HasValue) { + if (new_op.p.Value < min_piq) { + min_piq = new_op.p.Value; + } + } } public void remove_order(uint order_key) { _orders.Remove(order_key); + // on a remove, potentially the order w/ the lowest piq has been removed, so + // if the min() is now > than the current min_piq, update the min_piq + var prospective_piq = _orders.Select(op => op.Value.p).Where(piq => piq.HasValue).Min(); + if (prospective_piq > min_piq) { + min_piq = prospective_piq; + } } //public void update(OrderRecordImmutable neworder) { @@ -149,7 +164,16 @@ namespace mbts.spark { public uint security_key => _parent.security.Id; public double price { get => double.IsNaN(_phantom_price) ? _real_price : _phantom_price; } - public uint? min_piq => _orders.Select(op => op.Value.p).Where(piq => piq.HasValue).Min(); + public uint? min_piq { + get { + return _min_piq; + } + set { + if (Set(ref _min_piq, value)) { + piq_changed?.Invoke(); + } + } + } public double real_price => _real_price; public Side side { get {