From b38fed070e6cabbfe2f3b5d565fd5e9c2965ef48 Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Tue, 5 Sep 2017 14:17:57 -0400 Subject: [PATCH] UISettings no longer owns (and should not dispose) the settings connection --- src/client/spark/sys/persist/UISettings.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/spark/sys/persist/UISettings.cs b/src/client/spark/sys/persist/UISettings.cs index 8dc37252a..564f9940d 100644 --- a/src/client/spark/sys/persist/UISettings.cs +++ b/src/client/spark/sys/persist/UISettings.cs @@ -71,10 +71,10 @@ namespace mbts.persist switch (result) { case RetrieveResponse.Types.Result.EmptyNs: case RetrieveResponse.Types.Result.NoSuchNs: + case RetrieveResponse.Types.Result.NoSuchKey: empty = true; return; case RetrieveResponse.Types.Result.EmptyKey: - case RetrieveResponse.Types.Result.NoSuchKey: case RetrieveResponse.Types.Result.DuplicateKey: throw new ArgumentException($"Invalid Key {result} '{key}'"); default: @@ -122,7 +122,7 @@ namespace mbts.persist .SubscribeOn(SynchronizationContext.Current); } - public void Dispose() { Disposable.dispose(ref _persist); } + public void Dispose() {/*UISettings does not own Persistence*/} } [Export(typeof(IPersist))]