From af816bb905cbd2a7616d55a875f43386bba2d716 Mon Sep 17 00:00:00 2001 From: John Colvin Date: Wed, 27 Apr 2022 00:27:13 -0400 Subject: [PATCH] fix: Don't cast numeric types via boxing This is illegal --- src/client/spark_api/utils/MathUtils.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/spark_api/utils/MathUtils.cs b/src/client/spark_api/utils/MathUtils.cs index 294e3f891..32bc468b6 100644 --- a/src/client/spark_api/utils/MathUtils.cs +++ b/src/client/spark_api/utils/MathUtils.cs @@ -218,8 +218,8 @@ namespace bts.utils { public static decimal round_to_decimal(T value, int decimals = API_DECIMAL_PRECISION) where T : IFloatingPoint => T.IsNaN(value) ? 0 : - // TODO: avoid boxing/unboxing - (decimal)(object)T.Round(value, decimals, MidpointRounding.AwayFromZero); + NumericCastInConverter.to_decimal( + T.Round(value, decimals, MidpointRounding.AwayFromZero)); public static bool is_int(T value) where T : IFloatingPoint => epsilon_equals(value, T.Round(value));