From af0152b945d65d83ee6c5c6de5eb3fd3efba4eb2 Mon Sep 17 00:00:00 2001 From: John Colvin Date: Thu, 3 May 2018 11:57:41 -0400 Subject: [PATCH] PR edits --- src/client/spark/Modules/Trading/TradingShellModule.cs | 2 +- .../core/ShellInterface/UserSettings/UserSettingsHub.cs | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/client/spark/Modules/Trading/TradingShellModule.cs b/src/client/spark/Modules/Trading/TradingShellModule.cs index bfdd0e586..bfb542351 100644 --- a/src/client/spark/Modules/Trading/TradingShellModule.cs +++ b/src/client/spark/Modules/Trading/TradingShellModule.cs @@ -20,7 +20,7 @@ namespace bts.shell { PAndLWindowFactory _plwf; [ImportingConstructor] - public TradingShellModule(IBus bus, IWindowManager wm, IUserPersist persist, UserSettingsHub settings_hub, OrdersModel orders_model, PAndLModel pandl_model) { + public TradingShellModule(IBus bus, IWindowManager wm, UserSettingsHub settings_hub, OrdersModel orders_model, PAndLModel pandl_model) { _lwf = new LadderWindowFactory(this, bus, wm, new WindowSettingsManagerFactory(settings_hub, us => us.ladder, (us, v) => us.with(v)), orders_model); _obwf = new OrderBookWindowFactory(this, bus, orders_model); diff --git a/src/client/spark/core/ShellInterface/UserSettings/UserSettingsHub.cs b/src/client/spark/core/ShellInterface/UserSettings/UserSettingsHub.cs index 90c2f5295..f6ddf2d28 100644 --- a/src/client/spark/core/ShellInterface/UserSettings/UserSettingsHub.cs +++ b/src/client/spark/core/ShellInterface/UserSettings/UserSettingsHub.cs @@ -10,7 +10,8 @@ namespace mbts.persist { /// [Export(typeof(UserSettingsHub))] class UserSettingsHub { - const string _ns = "settings", _default_key = "default"; + // do NOT CHANGE these consts, they represent a file path on the server + const string NAME_SPACE = "settings", DEFAULT_KEY = "default"; IUserPersist _persist; UserSettings _default_settings; @@ -19,7 +20,7 @@ namespace mbts.persist { _persist = persist; init(); async void init() { - _default_settings = await _persist.get(_ns, _default_key); + _default_settings = await _persist.get(NAME_SPACE, DEFAULT_KEY); updated?.Invoke(current); } } @@ -34,7 +35,7 @@ namespace mbts.persist { _default_settings = value; // fire event before persisting so the changes are reflected immediately in the ui updated?.Invoke(value); - await _persist.set(_ns, _default_key, value); + await _persist.set(NAME_SPACE, DEFAULT_KEY, value); } } } \ No newline at end of file