From 29e080da71b1e3863fd59785a797742749352e35 Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Fri, 21 Aug 2020 16:18:24 -0400 Subject: [PATCH 1/3] remove tests --- .../md/mdp3/tests/spartan_md_tests.cpp | 54 +++++++++++++++---- 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp index c312a4a26..829cae4ce 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp @@ -400,16 +400,14 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { SECTION("add") { // bids auto n_levels = 10; - double price = 15.00, inc = 0.01; - for (int i=0;i(exp_n_orders)/2)*(1+exp_n_orders); verify_book_level(bid_bk.at(i),exp_price,exp_qty,exp_n_orders); - exp_price -= inc; + exp_price -= 0.01; } } // verify asks @@ -429,10 +427,44 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { auto exp_n_orders = (i+1)*10; auto exp_qty = (static_cast(exp_n_orders)/2)*(1+exp_n_orders); verify_book_level(ask_bk.at(i),exp_price,exp_qty,exp_n_orders); - exp_price += inc; + exp_price += 0.01; } } } + SECTION("remove") { + auto n_levels = 10; + // bids + for (struct {int i=0;double p=15;void inc(){i++;p+=0.01;}} lp; + lp.i Date: Fri, 21 Aug 2020 18:49:00 -0400 Subject: [PATCH 2/3] tests for order remove/modify and its affects on the book --- .../md/mdp3/tests/spartan_md_tests.cpp | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp index 829cae4ce..d7d8d13bd 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp @@ -465,6 +465,36 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { Book bk = sec_me.book(api::Side::SIDE_BUY); verify_book_level(bk.at(1),15.07,3240,80); } + SECTION("modify") { + auto n_levels = 10; + // bids + for (struct {int i=0;double p=15;void inc(){i++;p+=0.01;}} lp; + lp.i Date: Fri, 21 Aug 2020 23:23:26 -0400 Subject: [PATCH 3/3] fixed bug with sweeps --- .../mdp3/back_testing/FifoSecurityMatcher.cpp | 2 +- .../md/mdp3/tests/spartan_md_tests.cpp | 25 +++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp index 0d4fc4772..183816673 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp @@ -125,7 +125,7 @@ void FifoSecurityMatcher::on_new_order(const MDP3Order& ord){ } MDP3Order ord_corrected = ord; ord_corrected.quantity = MDP3Quantity(rem); - price_level->on_new_same_side_order(ord); + price_level->on_new_same_side_order(ord_corrected); } } diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp index d7d8d13bd..0cd01e9ba 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp @@ -377,6 +377,7 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { uint32_t qty, uint32_t n_orders){ REQUIRE(bl.price == md::IntPrice_from_double<7>(price)); + REQUIRE(bl.n_orders == n_orders); REQUIRE(bl.quantity.value() == qty); REQUIRE(bl.n_orders == n_orders); }; @@ -495,6 +496,30 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { verify_book_level(bk.at(1),15.07,3240,80); verify_book_level(bk.at(0),15.09,5140,190); } + SECTION("crosses") { + auto n_levels = 10; + // bids + for (struct {int i=0;double p=15;void inc(){i++;p+=0.01;}} lp; + lp.i