diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp index 0d4fc4772..183816673 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/FifoSecurityMatcher.cpp @@ -125,7 +125,7 @@ void FifoSecurityMatcher::on_new_order(const MDP3Order& ord){ } MDP3Order ord_corrected = ord; ord_corrected.quantity = MDP3Quantity(rem); - price_level->on_new_same_side_order(ord); + price_level->on_new_same_side_order(ord_corrected); } } diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp index c312a4a26..0cd01e9ba 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/tests/spartan_md_tests.cpp @@ -377,6 +377,7 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { uint32_t qty, uint32_t n_orders){ REQUIRE(bl.price == md::IntPrice_from_double<7>(price)); + REQUIRE(bl.n_orders == n_orders); REQUIRE(bl.quantity.value() == qty); REQUIRE(bl.n_orders == n_orders); }; @@ -400,16 +401,14 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { SECTION("add") { // bids auto n_levels = 10; - double price = 15.00, inc = 0.01; - for (int i=0;i(exp_n_orders)/2)*(1+exp_n_orders); verify_book_level(bid_bk.at(i),exp_price,exp_qty,exp_n_orders); - exp_price -= inc; + exp_price -= 0.01; } } // verify asks @@ -429,10 +428,98 @@ TEST_CASE("fifo_matching_engine_book", "[spartan_md]") { auto exp_n_orders = (i+1)*10; auto exp_qty = (static_cast(exp_n_orders)/2)*(1+exp_n_orders); verify_book_level(ask_bk.at(i),exp_price,exp_qty,exp_n_orders); - exp_price += inc; + exp_price += 0.01; } } } + SECTION("remove") { + auto n_levels = 10; + // bids + for (struct {int i=0;double p=15;void inc(){i++;p+=0.01;}} lp; + lp.i