From 9c6327160da689fc90b4a65d262d3f5a4437d5e5 Mon Sep 17 00:00:00 2001 From: John Colvin Date: Fri, 8 Apr 2022 12:37:28 -0400 Subject: [PATCH] fix: Set response-success to true in delete report Bugs (fixed): * When a report is successfully deleted, the response from the server indicates failure --- src/server/sparkd/analytics/AnalyticsServiceServer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/server/sparkd/analytics/AnalyticsServiceServer.cpp b/src/server/sparkd/analytics/AnalyticsServiceServer.cpp index 7dba2b9ee..e4c37ca46 100644 --- a/src/server/sparkd/analytics/AnalyticsServiceServer.cpp +++ b/src/server/sparkd/analytics/AnalyticsServiceServer.cpp @@ -336,7 +336,6 @@ void AnalyticsServiceServer::delete_report( api::ResultMessage res; res.set_success(false); if (!present) { - res.set_success(false); res.set_error_message("Could not find report"); resp(res); return; @@ -345,6 +344,7 @@ void AnalyticsServiceServer::delete_report( me->reports_publisher.erase(id.data()); me->reports_publisher.flush(); me->reports_store->remove(me->reports_ns, {key}); + res.set_success(true); resp(res); } @@ -403,4 +403,4 @@ void AnalyticsServiceServer::get_archived_theos( AnalyticsServiceServer::~AnalyticsServiceServer() {} -} // namespace bts::analytics \ No newline at end of file +} // namespace bts::analytics