diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/algos/Sniper.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/algos/Sniper.cpp index e94765313..9392a8f7e 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/algos/Sniper.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/algos/Sniper.cpp @@ -87,7 +87,7 @@ Sniper::MaybeTarget Sniper::pick() { LOG(Spartan, Info, "Top opportunities"); for (auto it = valuation.rbegin(); it != valuation.rend(); it++) { LOG(Spartan, Info, " {}", it->value); - if (max_print-- == 0 || it->value<0) + if (max_print-- == 0 || it->value<=0) break; } } diff --git a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/simulator/agents/AlgoAgent.cpp b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/simulator/agents/AlgoAgent.cpp index edabe3178..920fb495d 100644 --- a/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/simulator/agents/AlgoAgent.cpp +++ b/src/server/sparkd/cmds/spartan/md/mdp3/back_testing/simulator/agents/AlgoAgent.cpp @@ -56,7 +56,7 @@ double AlgoAgent::pandl() const { auto flow = mkt_to_cash_flow(f.side); this_pos.cash += flow * cash; - this_pos.contracts += -flow * cash; + this_pos.contracts += -flow * f.last_fills.value(); } // Liquidate remainder contracts @@ -72,7 +72,7 @@ double AlgoAgent::pandl() const { auto cash = mkt.price.price(); auto flow = mkt_to_cash_flow(mkt_action); this_pos.cash += flow * cash; - this_pos.contracts += -flow * cash; + this_pos.contracts += -flow * this_pos.contracts; } // Convert to human terms, sum across all contracts