From 8d0d678c019bbbcd69e572b0de39a09ad70cd33d Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Mon, 14 Jan 2019 09:58:13 -0500 Subject: [PATCH] unused parameters rmeoved form add_new_hedger --- .../orders/spreader_orders/SpreaderOrder.cpp | 6 ++--- .../spreader/SpreaderBookkeepingData.cpp | 9 ++++--- .../spreader/SpreaderBookkeepingData.h | 6 ++--- .../spreader_orders/tests/spreader_tests.cpp | 24 +++++-------------- 4 files changed, 14 insertions(+), 31 deletions(-) diff --git a/src/lib/orderman/orders/spreader_orders/SpreaderOrder.cpp b/src/lib/orderman/orders/spreader_orders/SpreaderOrder.cpp index 1193d8a71..8b64a7e95 100644 --- a/src/lib/orderman/orders/spreader_orders/SpreaderOrder.cpp +++ b/src/lib/orderman/orders/spreader_orders/SpreaderOrder.cpp @@ -343,12 +343,10 @@ bool SpreaderOrder::_quoters_can_accept_modification (){ void SpreaderOrder::_send_hedge(size_t hedge_leg_index, Price hedge_price, Quantity hedge_qty, - const trace::CorID trace){ + const trace::CorID){ _bookkeeping_data().add_new_hedger (hedge_leg_index, hedge_price, - hedge_qty, - _order_services, - trace); + hedge_qty); } void SpreaderOrder::_compute_hedge_price_quantity(size_t filled_leg_index, Price fill_price, diff --git a/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.cpp b/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.cpp index d735539c1..519b71a13 100644 --- a/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.cpp +++ b/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.cpp @@ -88,11 +88,10 @@ void SpreaderBookkeepingData::total_fills (Quantity& out_quantity, out_quantity = Quantity(fills); out_price = Price(avg_price); } -SingleFillHedger& SpreaderBookkeepingData::add_new_hedger(size_t leg_index, - bts::Price hedge_price, - bts::Quantity hedge_quantity, - SpreaderOrderServices*, - const trace::CorID&){ +SingleFillHedger& SpreaderBookkeepingData::add_new_hedger( + size_t leg_index, + Price hedge_price, + Quantity hedge_quantity){ bts_assert(leg_index < _leg_data.size()); SpreaderLegData& leg_data=_leg_data[leg_index]; return leg_data.add_new_hedger(hedge_price,hedge_quantity); diff --git a/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.h b/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.h index be51f287f..8a72ebaf8 100644 --- a/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.h +++ b/src/lib/orderman/orders/spreader_orders/spreader/SpreaderBookkeepingData.h @@ -104,10 +104,8 @@ public: // (dont keep pointers to hedgers since the vector // can resize) SingleFillHedger& add_new_hedger(size_t leg_index, - bts::Price hedge_price, - bts::Quantity hedge_quantity, - SpreaderOrderServices *services, - const trace::CorID&); + Price hedge_price, + Quantity hedge_quantity); // finds the spreader fill, price (ie averages it out, using // the size and price ratio, across all legs) void total_fills (Quantity& out_quantity, Price& out_price) const; diff --git a/src/lib/orderman/orders/spreader_orders/tests/spreader_tests.cpp b/src/lib/orderman/orders/spreader_orders/tests/spreader_tests.cpp index 1f4343d0d..cb35affa0 100644 --- a/src/lib/orderman/orders/spreader_orders/tests/spreader_tests.cpp +++ b/src/lib/orderman/orders/spreader_orders/tests/spreader_tests.cpp @@ -1280,9 +1280,7 @@ TEST_CASE ("hedger_START_state", "[spreader]") ChildOrder co; SingleFillHedger& hedger = bookeeping_data.add_new_hedger(1, hedger_price, - hedger_quantity, - nullptr, - trace::CorID()); + hedger_quantity); verify_complete_hedger_state (hedger, HedgerState::WAITING_FOR_FIRST_ACK, hedger_price, @@ -1364,9 +1362,7 @@ TEST_CASE ("hedger_WAITING_FOR_FIRST_ACK_state", "[spreader]") //SingleFillHedger hedger (sm, sm.get_leg_data (1), co, hedger_price, hedger_quantity,false); SingleFillHedger& hedger = bookeeping_data.add_new_hedger(1, hedger_price, - hedger_quantity, - nullptr, - trace::CorID()); + hedger_quantity); verify_complete_hedger_state (hedger, HedgerState::WAITING_FOR_FIRST_ACK, hedger_price, hedger_quantity, Quantity (0), hedger_price, hedger_quantity, hedger_quantity); SECTION("1. init") { @@ -1427,9 +1423,7 @@ TEST_CASE ("hedger_WAITING_FOR_FIRST_ACK_CANCELLED_state", "[spreader]") ChildOrder co; SingleFillHedger& hedger = bookeeping_data.add_new_hedger(1, hedger_price, - hedger_quantity, - nullptr, - trace::CorID()); + hedger_quantity); verify_complete_hedger_state (hedger, HedgerState::WAITING_FOR_FIRST_ACK, hedger_price, @@ -1506,9 +1500,7 @@ TEST_CASE ("hedger_WAITING_FOR_CANCEL_ACK_state", "[spreader]") ChildOrder co; SingleFillHedger& hedger = bookeeping_data.add_new_hedger(1, hedger_price, - hedger_quantity, - nullptr, - trace::CorID()); + hedger_quantity); verify_complete_hedger_state (hedger, HedgerState::WAITING_FOR_FIRST_ACK, hedger_price, @@ -1588,9 +1580,7 @@ TEST_CASE ("hedger_END_state", "[spreader]") ChildOrder co; SingleFillHedger& hedger = bookeeping_data.add_new_hedger(1, hedger_price, - hedger_quantity, - nullptr, - trace::CorID()); + hedger_quantity); verify_complete_hedger_state (hedger, HedgerState::WAITING_FOR_FIRST_ACK, hedger_price, @@ -1651,9 +1641,7 @@ TEST_CASE ("hedger_WORKING", "[spreader]") ChildOrder co; SingleFillHedger& hedger = bookeeping_data.add_new_hedger(1, hedger_price, - hedger_quantity, - nullptr, - trace::CorID()); + hedger_quantity); verify_complete_hedger_state (hedger, HedgerState::WAITING_FOR_FIRST_ACK, hedger_price,