cleanup: Get rid of 'using namespaces'
In headers, this is an objectively bad practice, since the type aliases leak into dependent code and can cause unexpected naming conflicts. In source files, it is debatable, but I prefer explicit aliases of the form 'using Foo = Bar'. The intentions are clear, and the resulting code is naturally resistent to naming conflicts.
This commit is contained in:
1 parent
2e6d12c9c1
commit
8bebbc278d
15 files changed
+336
-279
No files matched your search
@@ -4,7 +4,8 @@
|
||||
|
||||
namespace bts::orderman {
|
||||
|
||||
const std::string &getm(const NVMap &map, char const *key_name) {
|
||||
const std::string &getm(
|
||||
const std::map<std::string, std::string> &map, char const *key_name) {
|
||||
auto it = map.find(key_name);
|
||||
bts_assert_msg(
|
||||
it != map.end(), "Could not find key_name" + std::string(key_name));
|
||||
@@ -59,4 +60,4 @@ std::ostream &operator<<(
|
||||
return out;
|
||||
}
|
||||
|
||||
} // namespace bts::orderman
|
||||
} // namespace bts::orderman
|
||||
Reference in new issue
Block a user