From 80ce5447e59bf693701a344040b112bdc9078dc4 Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Fri, 8 Mar 2019 17:56:27 -0500 Subject: [PATCH] Validate that IcebergOrders must have child definitions. --- src/lib/orderman/orders/IcebergOrder2.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/lib/orderman/orders/IcebergOrder2.cpp b/src/lib/orderman/orders/IcebergOrder2.cpp index f268bc112..a527e8eb3 100644 --- a/src/lib/orderman/orders/IcebergOrder2.cpp +++ b/src/lib/orderman/orders/IcebergOrder2.cpp @@ -88,11 +88,9 @@ void IcebergOrder2::on_init_new(OrderDefinition const &def, "Show quantity must be greater than 0"); return; } - auto attach_target = OrderKey(me->def.attach_target_order_key()); - if (!ib.has_child() && attach_target == null_order_key()) { + if (!ib.has_child()) { terminate(ORDER_STATUS_REJECTED_BY_SPARK, - "Iceberg order must have a child order definition or attach to " - "an existing order"); + "Iceberg order must have a child order definition"); return; } initialize_child_builder(services.order_factory);