From f6f9605a83a1df4fd94131bbf952018b386303a2 Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Tue, 12 Feb 2019 12:26:11 -0500 Subject: [PATCH 1/7] Revert "Try to ensure Dispatcher::background is terminated" This reverts commit 5cc408557727828ad09536b625dbf1f1cb6fc7ff. --- src/lib/utils/init_spark_lib.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lib/utils/init_spark_lib.cpp b/src/lib/utils/init_spark_lib.cpp index 772d62c7a..d9dc6fab9 100644 --- a/src/lib/utils/init_spark_lib.cpp +++ b/src/lib/utils/init_spark_lib.cpp @@ -2,7 +2,6 @@ #include "lib/logging/logging.h" #include "lib/utils/bts_assert.h" #include "lib/utils/thread_manager.h" -#include "lib/utils/Dispatcher.h" namespace bts { namespace utils { @@ -21,7 +20,6 @@ void finit_spark_lib() if (poller) { delete poller; } - utils::Dispatcher::background().terminate(); } }} From 15750383652b6c960fe0edbab2ed0604755084b3 Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Wed, 13 Feb 2019 08:27:28 -0500 Subject: [PATCH 2/7] Fix equality on OrderSecurity type --- src/client/spark/Orders/OrderSecurity.cs | 2 +- src/client/spark/Orders/OrdersModel.cs | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/client/spark/Orders/OrderSecurity.cs b/src/client/spark/Orders/OrderSecurity.cs index dd9936162..a703e4c2b 100644 --- a/src/client/spark/Orders/OrderSecurity.cs +++ b/src/client/spark/Orders/OrderSecurity.cs @@ -15,7 +15,7 @@ namespace bts.api.orderman { public OrderRecordImmutable order { get; } public override bool Equals(object obj) => (obj is OrderSecurity os) && Equals(os); - public bool Equals(OrderSecurity other) => order.Key == other.order.Key && security == other.security; + public bool Equals(OrderSecurity other) => order.Equals(other.order) && security == other.security; public override int GetHashCode() => (security, order).GetHashCode(); public static bool operator == (OrderSecurity left, OrderSecurity right) => left.Equals(right); diff --git a/src/client/spark/Orders/OrdersModel.cs b/src/client/spark/Orders/OrdersModel.cs index 0503e569e..b41edc81f 100644 --- a/src/client/spark/Orders/OrdersModel.cs +++ b/src/client/spark/Orders/OrdersModel.cs @@ -175,12 +175,12 @@ namespace mbts.spark { clone.Remove(o.order.Key); } } - foreach (var o in table.changed) { - if (o.order.is_active()) { - clone[o.order.Key] = o; + foreach (var o in table.changes) { + if (o.Old.order.is_active()) { + clone.Remove(o.Old.order.Key); } - else { - clone.Remove(o.order.Key); + if (o.New.order.is_active()) { + clone.Add(o.New.order.Key, o.New); } } foreach (var o in table.added) { From 2cb485a883e55670a2fc9853404e6deba5a8de09 Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Wed, 13 Feb 2019 13:18:36 -0500 Subject: [PATCH 3/7] Add note for ui_perf manual test --- testing/manual/ladder/ui_performance.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/testing/manual/ladder/ui_performance.txt b/testing/manual/ladder/ui_performance.txt index 9fb54cc18..ee27662c8 100644 --- a/testing/manual/ladder/ui_performance.txt +++ b/testing/manual/ladder/ui_performance.txt @@ -14,3 +14,4 @@ This test needs to run against production market data or high quality recorded d 4. Repeat 2. +5. If there is *any* doubt that the UI is snappy bring up the previous release and compare. At minimum we need to not regress UI performance. From 0f8b996c8ca8d9a6a0b0c1b54ea20ae5d58af7d5 Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Wed, 13 Feb 2019 13:44:07 -0500 Subject: [PATCH 4/7] Reduce config connection timeout to 6 seconds from 30 --- src/lib/config/ConfigDownloader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/config/ConfigDownloader.cpp b/src/lib/config/ConfigDownloader.cpp index 2c6e94af8..da23232eb 100755 --- a/src/lib/config/ConfigDownloader.cpp +++ b/src/lib/config/ConfigDownloader.cpp @@ -53,7 +53,7 @@ ConfigDownloader::Result ConfigDownloader::get(const string& url, stringstream& curl_easy_setopt(_curl, CURLOPT_WRITEDATA, &out_stream); curl_easy_setopt(_curl, CURLOPT_VERBOSE, 0); curl_easy_setopt(_curl, CURLOPT_FAILONERROR, 1); - curl_easy_setopt(_curl, CURLOPT_CONNECTTIMEOUT, 30); + curl_easy_setopt(_curl, CURLOPT_CONNECTTIMEOUT, 6); curl_easy_setopt(_curl, CURLOPT_SOCKOPTFUNCTION, no_linger); CURLcode res = curl_easy_perform(_curl); From 7212049c0cb890330c6665fc2b48b4b634cb952c Mon Sep 17 00:00:00 2001 From: Kevin Darby Date: Thu, 14 Feb 2019 12:37:34 -0500 Subject: [PATCH 5/7] ignore *.code-workspace files --- .gitignore | 1 + remote-sparkvm.code-workspace | 27 --------------------------- 2 files changed, 1 insertion(+), 27 deletions(-) delete mode 100644 remote-sparkvm.code-workspace diff --git a/.gitignore b/.gitignore index d87a92c1b..a8d93ca09 100644 --- a/.gitignore +++ b/.gitignore @@ -26,6 +26,7 @@ src/server/sparkd/orderman/perf_analysis/logs/ src/server/sparkd/orderman/perf_analysis/trace_data/ .fake *.fsx.lock +*.code-workspace src/lib/orderman/perf_analysis/logs/latency_data/ trace_data/ /src/lib/orderman/perf_analysis/last_pretty_log.csv diff --git a/remote-sparkvm.code-workspace b/remote-sparkvm.code-workspace deleted file mode 100644 index 03c875df7..000000000 --- a/remote-sparkvm.code-workspace +++ /dev/null @@ -1,27 +0,0 @@ -{ - "folders": [ - { - "path": "." - }, - { - "uri": "sftp://bts:BT5u53r@sparkvm:22/home/bts/", - "name": "sparkvm" - } - ], - "settings": { - "files.associations": { - "utility": "cpp", - "initializer_list": "cpp", - "list": "cpp", - "type_traits": "cpp", - "vector": "cpp", - "xhash": "cpp", - "xstring": "cpp", - "system_error": "cpp", - "array": "cpp", - "string_view": "cpp", - "xutility": "cpp", - "*.ipp": "cpp" - } - } -} \ No newline at end of file From 7829724c1b1df7aa3beff1a62d635c9f5051934b Mon Sep 17 00:00:00 2001 From: ppinto Date: Fri, 15 Feb 2019 16:33:10 -0500 Subject: [PATCH 6/7] Updated pointer to docker subrepo --- docker/linux | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/linux b/docker/linux index 8ee969259..8d82558f9 160000 --- a/docker/linux +++ b/docker/linux @@ -1 +1 @@ -Subproject commit 8ee9692597d9e59adf0a3ab77610b711892f79a6 +Subproject commit 8d82558f9015a699c3baf88e2490b4ac6efcb83e From 6a656fe96b74d8b8d2a1b3d8e573578ae6828ce3 Mon Sep 17 00:00:00 2001 From: ppinto Date: Fri, 15 Feb 2019 16:35:23 -0500 Subject: [PATCH 7/7] Dropped local install of paket --- src/web/api/build.sh | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/web/api/build.sh b/src/web/api/build.sh index 921e590a3..ce57168f7 100755 --- a/src/web/api/build.sh +++ b/src/web/api/build.sh @@ -6,10 +6,6 @@ export PATH="$PATH:/root/.dotnet/tools" if ! [ -x "$(command -v npx)" ]; then npm install -g npx fi -# install paket -if ! [ -x "$(command -v paket)" ]; then - dotnet tool install -g paket -fi export OUT=${BUILD_DIR:-../../../build}/web MODE=manual