diff --git a/src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioWindow.cs b/src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioWindow.cs index c860668f8..749b287dc 100644 --- a/src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioWindow.cs +++ b/src/client/spark/Modules/Trading/AlgoStudio/AlgoStudioWindow.cs @@ -141,18 +141,24 @@ namespace mbts.spark { _vm.remove_template(t).ignore(); } else if (value is AlgoDefinitionVM d) { string prompt; MessageBoxImage icon; - if (_model.algo_model.templates_enabled()) { + if (_model.algo_model.templates_enabled() && d.templates.Count > 0) { prompt = $"Deleting this definition ({d.name}) will also delete its templates ({d.templates.Count}).\n\nDo you wan to Continue?"; icon = MessageBoxImage.Warning; - } else { + } else if (d.key.mode == AlgoKey.Mode.Persisted) { prompt = $"Are you sure you want to delete '{d.name}?'"; icon = MessageBoxImage.Question; + } else { + // algo hasn't even been created yet (just an unsaved placeholder item), no need to get user confirmation in this case. + prompt = null; + icon = default; } - var resp = BTSMessageBox.Show(prompt, "Algo Studio", BTSMessageBoxButtons.Yes | BTSMessageBoxButtons.No, icon); - switch (resp) { - case BTSMessageBoxButtons.Yes: break; - case BTSMessageBoxButtons.No: - default: return; + if (prompt != null) { + var resp = BTSMessageBox.Show(prompt, "Algo Studio", BTSMessageBoxButtons.Yes | BTSMessageBoxButtons.No, icon); + switch (resp) { + case BTSMessageBoxButtons.Yes: break; + case BTSMessageBoxButtons.No: + default: return; + } } _vm.remove_definition(d).ignore(); }