From 49609b69766e44ead0c38dc255a7a771fcc76529 Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Wed, 4 Oct 2017 21:12:55 -0400 Subject: [PATCH 01/13] quoter test (incomplete) --- src/server/sparkd/spreader/LegPropertyData.h | 17 +- src/server/sparkd/spreader/SimpleSpreader.cpp | 6 +- .../sparkd/spreader/SpreaderBookkeepingData.h | 7 +- src/server/sparkd/spreader/SpreaderTests.cpp | 163 +++++++++++++++++- src/server/sparkd/spreader/SpreaderUtils.h | 4 +- 5 files changed, 173 insertions(+), 24 deletions(-) diff --git a/src/server/sparkd/spreader/LegPropertyData.h b/src/server/sparkd/spreader/LegPropertyData.h index 1a8425217..d8339a176 100644 --- a/src/server/sparkd/spreader/LegPropertyData.h +++ b/src/server/sparkd/spreader/LegPropertyData.h @@ -17,25 +17,22 @@ class LegPropertyData { public: const size_t leg_index; - const bts::api::Security spread_security; const bts::api::ContractLeg leg_contract; const bts::spark::LegSpreaderParams leg_params; const api::BuySell trading_side; LegPropertyData(size_t leg_index_arg, - const bts::api::Security& spread_security_arg, - const bts::api::ContractLeg& leg_contract_arg, - const bts::spark::LegSpreaderParams& leg_params_arg, - api::BuySell trading_side_arg) - : + const bts::api::ContractLeg& leg_contract_arg, + const bts::spark::LegSpreaderParams& leg_params_arg, + api::BuySell trading_side_arg) + : // copying the values via copy cons leg_index(leg_index_arg), - spread_security(spread_security_arg), leg_contract(leg_contract_arg), leg_params(leg_params_arg), - trading_side (trading_side_arg) + trading_side(trading_side_arg) { - } - uint32_t security_key() const { return spread_security.id(); } + } + uint32_t security_key() const { return leg_contract.security().id(); } double price_multiplier() const { return leg_contract.price_multiplier(); } double size_multiplier() const { return leg_contract.quantity(); } double tick_size() const { return leg_contract.security().contract_spec().low_tick(); } diff --git a/src/server/sparkd/spreader/SimpleSpreader.cpp b/src/server/sparkd/spreader/SimpleSpreader.cpp index 16dc64fde..0f94481fd 100644 --- a/src/server/sparkd/spreader/SimpleSpreader.cpp +++ b/src/server/sparkd/spreader/SimpleSpreader.cpp @@ -60,11 +60,11 @@ namespace spreader bts_assert(st_it != execution_strategy.leg_params_map().end()); const bts::api::ContractLeg& leg = *it; api::BuySell leg_order_side = SpreaderUtils::get_leg_side(create.order.side(), leg); - LegPropertyData leg_property_data(index++, sec, leg, st_it->second, leg_order_side); + LegPropertyData leg_property_data(index++, leg, st_it->second, leg_order_side); SpreaderBookkeepingData::LegData leg_data(leg_property_data); leg_data_vector.push_back(leg_data); } - _bookkeeping_data = std::make_unique(leg_data_vector); + _bookkeeping_data = std::make_unique(create.order.security(), leg_data_vector); // now settings up the quoters for (size_t index = 0; index < _bookkeeping_data->count(); index++) { @@ -413,7 +413,7 @@ namespace spreader const OrderTemplate& SimpleSpreader::_get_order_template(size_t leg_index) { SpreaderBookkeepingData::LegData& leg_data = _bookkeeping_data->get_leg_data(leg_index); - return make_order_template(leg_data.leg_shared_data.spread_security, + return make_order_template(_bookkeeping_data->security, orderman::AccountName(), //TODO _create_order_request.native_order().account_name orderman::OperatorID(), //_create_order_request.native_order().operator_id(), leg_data.leg_shared_data.trading_side, diff --git a/src/server/sparkd/spreader/SpreaderBookkeepingData.h b/src/server/sparkd/spreader/SpreaderBookkeepingData.h index b2eb49e99..8b2d344a8 100644 --- a/src/server/sparkd/spreader/SpreaderBookkeepingData.h +++ b/src/server/sparkd/spreader/SpreaderBookkeepingData.h @@ -92,9 +92,12 @@ private: std::vector _leg_data; boost::container::flat_map _sec_key_to_index; public: - SpreaderBookkeepingData(const std::vector& leg_data) + const api::Security security; +public: + SpreaderBookkeepingData(const api::Security& security_arg, const std::vector& leg_data) : - _leg_data (leg_data) + _leg_data (leg_data), + security(security_arg) { for (auto it = leg_data.begin(); it != leg_data.end(); ++it) _sec_key_to_index.insert(std::pair(it->leg_shared_data.security_key(), it->leg_shared_data.leg_index)); diff --git a/src/server/sparkd/spreader/SpreaderTests.cpp b/src/server/sparkd/spreader/SpreaderTests.cpp index 2694fd7f5..ba733f57e 100644 --- a/src/server/sparkd/spreader/SpreaderTests.cpp +++ b/src/server/sparkd/spreader/SpreaderTests.cpp @@ -1,37 +1,186 @@ #include "catch/catch.hpp" -#include "../risk_limits/RiskLimitManager.h" -#include "../risk_limits/SharedRiskLimiter.h" -#include "../risk_limits/RiskLimiter.h" -#include "../risk_limits/RiskLimitState.h" -#include "../risk_limits/IRiskLimitObserver.h" - #include "server/sparkd/orderman/utils/orderman_utils.h" #include "lib/config/config.h" #include "lib/config/protos/Account.pb.h" -#include "lib/config/protos/User.pb.h" #include "lib/domain_model/Security.pb.h" #include "lib/utils/helper_macros.h" +#include "ISpreaderManager.h" +#include "SpreaderBase.h" +#include "LegPropertyData.h" +#include "SpreaderBookkeepingData.h" #include #include + using namespace bts::orderman; +using namespace bts::spark; namespace bts{ namespace spreader{ + class SpreaderManagerSim : public ISpreaderManager + { + private: + Book b; + api::FutureContract _leg_1_f; + api::Security _leg_1_s; + api::ContractLeg _leg_1_contract; + api::FutureContract _leg_2_f; + api::Security _leg_2_s; + api::ContractLeg _leg_2_contract; + api::ContractSpecification _spec; + api::SyntheticContract _synth_contract; + api::Security _spread_security; + QuoteParams _leg_1_q_params; + QuoteMuteZone _leg_1_qmz; + PreHedgeParams _leg_1_ph_params; + PostHedgeParams _leg_1_pph_params; + LegSpreaderParams _leg_1_spr_params; + LegPropertyData* _leg_1_property_data; + QuoteParams _leg_2_q_params; + QuoteMuteZone _leg_2_qmz; + PreHedgeParams _leg_2_ph_params; + PostHedgeParams _leg_2_pph_params; + LegSpreaderParams _leg_2_spr_params; + LegPropertyData* _leg_2_property_data; + + SpreaderBookkeepingData* _bookkeeping_data; + public: + SpreaderManagerSim() + { + //security + // common to leg1 and leg1 + api::ContractSpecification spec; + spec.set_low_tick(0.25); + spec.set_high_tick(0.25); + // leg1 + _leg_1_f.set_expiration_day(15); + _leg_1_f.set_expiration_month(12); + _leg_1_f.set_expiration_year(2017); + + _leg_1_s.set_id(1000); + _leg_1_s.set_symbol("ES"); + _leg_1_s.set_exchange(api::Venue::GLBX); + _leg_1_s.set_allocated_contract_spec(&spec); + _leg_1_s.set_allocated_future(&_leg_1_f); + + _leg_1_contract.set_allocated_security(&_leg_1_s); + _leg_1_contract.set_quantity(1.0); + _leg_1_contract.set_side(api::BuySell::BUY); + _leg_1_contract.set_price_multiplier(1.0); + + // leg2 + _leg_2_f.set_expiration_day(16); + _leg_2_f.set_expiration_month(3); + _leg_2_f.set_expiration_year(2018); + + _leg_2_s.set_id(1001); + _leg_2_s.set_symbol("ES"); + _leg_2_s.set_exchange(api::Venue::GLBX); + _leg_2_s.set_allocated_contract_spec(&spec); + _leg_2_s.set_allocated_future(&_leg_2_f); + + _leg_2_contract.set_allocated_security(&_leg_2_s); + _leg_2_contract.set_quantity(1.0); + _leg_2_contract.set_side(api::BuySell::SELL); + _leg_2_contract.set_price_multiplier(1.0); + + _synth_contract.set_name("spread_test_1"); + _synth_contract.set_price_calc(bts::api::SyntheticContract_PriceCalc::SyntheticContract_PriceCalc_diff); + + _synth_contract.mutable_legs()->AddAllocated(&_leg_1_contract); + _synth_contract.mutable_legs()->AddAllocated(&_leg_2_contract); + + + _spread_security.set_allocated_synthetic(&_synth_contract); + + // LegSpreaderParams + _leg_1_qmz.set_outside_ticks(1); + _leg_1_qmz.set_inside_ticks(1); + _leg_1_q_params.set_allocated_quote_mute_zone(&_leg_1_qmz); + _leg_1_spr_params.set_allocated_quote_params(&_leg_1_q_params); + _leg_1_property_data = new LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY); + + _leg_2_qmz.set_outside_ticks(1); + _leg_2_qmz.set_inside_ticks(1); + _leg_2_q_params.set_allocated_quote_mute_zone(&_leg_2_qmz); + _leg_2_spr_params.set_allocated_quote_params(&_leg_2_q_params); + _leg_2_property_data = new LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::BUY); + + SpreaderBookkeepingData::LegData leg_1_data(*_leg_1_property_data); + SpreaderBookkeepingData::LegData leg_2_data(*_leg_2_property_data); + + std::vector leg_data_v; + leg_data_v.push_back(LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY)); + leg_data_v.push_back(LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::SELL)); + + _bookkeeping_data = new SpreaderBookkeepingData(_spread_security, leg_data_v); + } + bts::orderman::OrderKey send_limit_order(const OrderTemplate&, bts::Price, bts::Quantity) override + { + OrderKey key(1); + return key; + } + // orders are modified through this. order_key uniquely distinguishes orders + void update_order(bts::orderman::OrderKey, bts::Price, bts::Quantity) override + { + + } + // call this to cancel orders + void cancel_order(bts::orderman::OrderKey) override + { + } + // for a leg index, returns the Book in O(1). the caller can hold at + // reference to the returned type forever (the data in the returned + // type can change beneath it) + const orderman::Book& get_book(size_t index) const override + { + SpreaderBookkeepingData::LegData& leg_data = _bookkeeping_data->get_leg_data(index); + return leg_data.book; + } + // the caller can keep a reference to the returned type forever. the + // data in the returned type is all const, so nothing will change + // beneath it + const LegPropertyData& get_leg_data(size_t index) const override + { + SpreaderBookkeepingData::LegData& leg_data = _bookkeeping_data->get_leg_data(index); + return leg_data.leg_shared_data; + } + // number of legs on the spread + size_t n_legs() const override + { + return 2; + } + }; + TEST_CASE("Simple Test", "[spreader]") { SECTION("nothing_really") { + std::vector v; for (int i = 0; i < 100; i++) v.push_back(i); REQUIRE(v.size() == 100); } } + + TEST_CASE("Simple Single Quoter Tester", "[spreader]") + { + SECTION("nothing_really") + { + /*ISpreaderManager* sim = new SpreaderManagerSim(); + OrderTemplate ot; + SingleLegQuoter leg_1_q(*sim, ot, 0, Price(0.0), Quantity(10));*/ + /*std::vector v; + for (int i = 0; i < 100; i++) + v.push_back(i); + REQUIRE(v.size() == 100);*/ + } + } }} diff --git a/src/server/sparkd/spreader/SpreaderUtils.h b/src/server/sparkd/spreader/SpreaderUtils.h index 00b3e0951..26b185889 100644 --- a/src/server/sparkd/spreader/SpreaderUtils.h +++ b/src/server/sparkd/spreader/SpreaderUtils.h @@ -50,7 +50,7 @@ public: return true; } } - static void fill_leg_shared_data(const bts::api::Security& sec, const bts::spark::ExecutionStrategy& execution_strategy, api::BuySell order_side, + /*static void fill_leg_shared_data(const bts::api::Security& sec, const bts::spark::ExecutionStrategy& execution_strategy, api::BuySell order_side, std::vector& out_v) { bts_assert(sec.has_synthetic()); @@ -64,7 +64,7 @@ public: api::BuySell leg_order_side = get_leg_side(order_side, leg); out_v.push_back(LegPropertyData(index, sec, leg, st_it->second, leg_order_side)); } - } + }*/ const static bts::spark::LegSpreaderParams& find_spread_params(const bts::spark::ExecutionStrategy& exec_strategy, const bts::api::Security& leg_security) { From 43209cacb6704f91240eca3b0c7011b20f00655f Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Thu, 5 Oct 2017 10:51:48 -0400 Subject: [PATCH 02/13] hard coding securities for spreader test --- src/server/sparkd/spreader/SpreaderTests.cpp | 268 ++++++++++--------- 1 file changed, 141 insertions(+), 127 deletions(-) diff --git a/src/server/sparkd/spreader/SpreaderTests.cpp b/src/server/sparkd/spreader/SpreaderTests.cpp index ba733f57e..4d881e68e 100644 --- a/src/server/sparkd/spreader/SpreaderTests.cpp +++ b/src/server/sparkd/spreader/SpreaderTests.cpp @@ -20,158 +20,171 @@ using namespace bts::spark; namespace bts{ namespace spreader{ - - class SpreaderManagerSim : public ISpreaderManager +class SpreaderManagerSim : public ISpreaderManager +{ +private: + Book b; + api::FutureContract _leg_1_f; + api::Security _leg_1_s; + api::ContractLeg _leg_1_contract; + api::FutureContract _leg_2_f; + api::Security _leg_2_s; + api::ContractLeg _leg_2_contract; + api::ContractSpecification _spec; + api::SyntheticContract _synth_contract; + api::Security _spread_security; + QuoteParams _leg_1_q_params; + QuoteMuteZone _leg_1_qmz; + PreHedgeParams _leg_1_ph_params; + PostHedgeParams _leg_1_pph_params; + LegSpreaderParams _leg_1_spr_params; + LegPropertyData* _leg_1_property_data; + QuoteParams _leg_2_q_params; + QuoteMuteZone _leg_2_qmz; + PreHedgeParams _leg_2_ph_params; + PostHedgeParams _leg_2_pph_params; + LegSpreaderParams _leg_2_spr_params; + LegPropertyData* _leg_2_property_data; +public: + SpreaderBookkeepingData* bookkeeping_data; + SpreaderManagerSim() { - private: - Book b; - api::FutureContract _leg_1_f; - api::Security _leg_1_s; - api::ContractLeg _leg_1_contract; - api::FutureContract _leg_2_f; - api::Security _leg_2_s; - api::ContractLeg _leg_2_contract; - api::ContractSpecification _spec; - api::SyntheticContract _synth_contract; - api::Security _spread_security; - QuoteParams _leg_1_q_params; - QuoteMuteZone _leg_1_qmz; - PreHedgeParams _leg_1_ph_params; - PostHedgeParams _leg_1_pph_params; - LegSpreaderParams _leg_1_spr_params; - LegPropertyData* _leg_1_property_data; - QuoteParams _leg_2_q_params; - QuoteMuteZone _leg_2_qmz; - PreHedgeParams _leg_2_ph_params; - PostHedgeParams _leg_2_pph_params; - LegSpreaderParams _leg_2_spr_params; - LegPropertyData* _leg_2_property_data; - - SpreaderBookkeepingData* _bookkeeping_data; - public: - SpreaderManagerSim() - { - //security - // common to leg1 and leg1 - api::ContractSpecification spec; - spec.set_low_tick(0.25); - spec.set_high_tick(0.25); - // leg1 - _leg_1_f.set_expiration_day(15); - _leg_1_f.set_expiration_month(12); - _leg_1_f.set_expiration_year(2017); + //security + // common to leg1 and leg1 + _spec.set_low_tick(0.25); + _spec.set_high_tick(0.25); + // leg1 + _leg_1_f.set_expiration_day(15); + _leg_1_f.set_expiration_month(12); + _leg_1_f.set_expiration_year(2017); + _leg_1_s.set_id(1000); + _leg_1_s.set_symbol("ES"); + _leg_1_s.set_exchange(api::Venue::GLBX); + _leg_1_s.set_allocated_contract_spec(&_spec); + _leg_1_s.set_allocated_future(&_leg_1_f); - _leg_1_s.set_id(1000); - _leg_1_s.set_symbol("ES"); - _leg_1_s.set_exchange(api::Venue::GLBX); - _leg_1_s.set_allocated_contract_spec(&spec); - _leg_1_s.set_allocated_future(&_leg_1_f); + _leg_1_contract.set_allocated_security(&_leg_1_s); + _leg_1_contract.set_quantity(1.0); + _leg_1_contract.set_side(api::BuySell::BUY); + _leg_1_contract.set_price_multiplier(1.0); - _leg_1_contract.set_allocated_security(&_leg_1_s); - _leg_1_contract.set_quantity(1.0); - _leg_1_contract.set_side(api::BuySell::BUY); - _leg_1_contract.set_price_multiplier(1.0); + // leg2 + _leg_2_f.set_expiration_day(16); + _leg_2_f.set_expiration_month(3); + _leg_2_f.set_expiration_year(2018); - // leg2 - _leg_2_f.set_expiration_day(16); - _leg_2_f.set_expiration_month(3); - _leg_2_f.set_expiration_year(2018); + _leg_2_s.set_id(1001); + _leg_2_s.set_symbol("ES"); + _leg_2_s.set_exchange(api::Venue::GLBX); + _leg_2_s.set_allocated_contract_spec(&_spec); + _leg_2_s.set_allocated_future(&_leg_2_f); - _leg_2_s.set_id(1001); - _leg_2_s.set_symbol("ES"); - _leg_2_s.set_exchange(api::Venue::GLBX); - _leg_2_s.set_allocated_contract_spec(&spec); - _leg_2_s.set_allocated_future(&_leg_2_f); + _leg_2_contract.set_allocated_security(&_leg_2_s); + _leg_2_contract.set_quantity(1.0); + _leg_2_contract.set_side(api::BuySell::SELL); + _leg_2_contract.set_price_multiplier(1.0); - _leg_2_contract.set_allocated_security(&_leg_2_s); - _leg_2_contract.set_quantity(1.0); - _leg_2_contract.set_side(api::BuySell::SELL); - _leg_2_contract.set_price_multiplier(1.0); + _synth_contract.set_name("spread_test_1"); + _synth_contract.set_price_calc(bts::api::SyntheticContract_PriceCalc::SyntheticContract_PriceCalc_diff); - _synth_contract.set_name("spread_test_1"); - _synth_contract.set_price_calc(bts::api::SyntheticContract_PriceCalc::SyntheticContract_PriceCalc_diff); - - _synth_contract.mutable_legs()->AddAllocated(&_leg_1_contract); - _synth_contract.mutable_legs()->AddAllocated(&_leg_2_contract); + _synth_contract.mutable_legs()->AddAllocated(&_leg_1_contract); + _synth_contract.mutable_legs()->AddAllocated(&_leg_2_contract); - _spread_security.set_allocated_synthetic(&_synth_contract); + _spread_security.set_allocated_synthetic(&_synth_contract); - // LegSpreaderParams - _leg_1_qmz.set_outside_ticks(1); - _leg_1_qmz.set_inside_ticks(1); - _leg_1_q_params.set_allocated_quote_mute_zone(&_leg_1_qmz); - _leg_1_spr_params.set_allocated_quote_params(&_leg_1_q_params); - _leg_1_property_data = new LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY); + // LegSpreaderParams + _leg_1_qmz.set_outside_ticks(1); + _leg_1_qmz.set_inside_ticks(1); + _leg_1_q_params.set_allocated_quote_mute_zone(&_leg_1_qmz); + _leg_1_spr_params.set_allocated_quote_params(&_leg_1_q_params); + _leg_1_property_data = new LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY); - _leg_2_qmz.set_outside_ticks(1); - _leg_2_qmz.set_inside_ticks(1); - _leg_2_q_params.set_allocated_quote_mute_zone(&_leg_2_qmz); - _leg_2_spr_params.set_allocated_quote_params(&_leg_2_q_params); - _leg_2_property_data = new LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::BUY); + _leg_2_qmz.set_outside_ticks(1); + _leg_2_qmz.set_inside_ticks(1); + _leg_2_q_params.set_allocated_quote_mute_zone(&_leg_2_qmz); + _leg_2_spr_params.set_allocated_quote_params(&_leg_2_q_params); + _leg_2_property_data = new LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::BUY); - SpreaderBookkeepingData::LegData leg_1_data(*_leg_1_property_data); - SpreaderBookkeepingData::LegData leg_2_data(*_leg_2_property_data); + SpreaderBookkeepingData::LegData leg_1_data(*_leg_1_property_data); + SpreaderBookkeepingData::LegData leg_2_data(*_leg_2_property_data); - std::vector leg_data_v; - leg_data_v.push_back(LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY)); - leg_data_v.push_back(LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::SELL)); + std::vector leg_data_v; + leg_data_v.push_back(LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY)); + leg_data_v.push_back(LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::SELL)); - _bookkeeping_data = new SpreaderBookkeepingData(_spread_security, leg_data_v); - } - bts::orderman::OrderKey send_limit_order(const OrderTemplate&, bts::Price, bts::Quantity) override - { - OrderKey key(1); - return key; - } + bookkeeping_data = new SpreaderBookkeepingData(_spread_security, leg_data_v); + } + bts::orderman::OrderKey send_limit_order(const OrderTemplate&, bts::Price, bts::Quantity) override + { + OrderKey key(1); + return key; + } // orders are modified through this. order_key uniquely distinguishes orders - void update_order(bts::orderman::OrderKey, bts::Price, bts::Quantity) override - { - - } + void update_order(bts::orderman::OrderKey, bts::Price, bts::Quantity) override + { + + } // call this to cancel orders - void cancel_order(bts::orderman::OrderKey) override - { - } + void cancel_order(bts::orderman::OrderKey) override + { + } // for a leg index, returns the Book in O(1). the caller can hold at // reference to the returned type forever (the data in the returned // type can change beneath it) - const orderman::Book& get_book(size_t index) const override - { - SpreaderBookkeepingData::LegData& leg_data = _bookkeeping_data->get_leg_data(index); - return leg_data.book; - } + const orderman::Book& get_book(size_t index) const override + { + SpreaderBookkeepingData::LegData& leg_data = bookkeeping_data->get_leg_data(index); + return leg_data.book; + } // the caller can keep a reference to the returned type forever. the // data in the returned type is all const, so nothing will change // beneath it - const LegPropertyData& get_leg_data(size_t index) const override - { - SpreaderBookkeepingData::LegData& leg_data = _bookkeeping_data->get_leg_data(index); - return leg_data.leg_shared_data; - } - // number of legs on the spread - size_t n_legs() const override - { - return 2; - } - }; - - TEST_CASE("Simple Test", "[spreader]") + const LegPropertyData& get_leg_data(size_t index) const override { - SECTION("nothing_really") - { - - std::vector v; - for (int i = 0; i < 100; i++) - v.push_back(i); - REQUIRE(v.size() == 100); - } + SpreaderBookkeepingData::LegData& leg_data = bookkeeping_data->get_leg_data(index); + return leg_data.leg_shared_data; } + // number of legs on the spread + size_t n_legs() const override + { + return 2; + } +}; - TEST_CASE("Simple Single Quoter Tester", "[spreader]") + //class SpreaderTestHelper + //{ + //public: + // static void test() + // { + // // create sim spreader + // bts::spreader::SpreaderManagerSim sim; + // // create quoter + // OrderTemplate ord_templ; + // SingleLegQuoter quoter(sim, ord_templ, 0, Price(0.0), Quantity(10)); + // quoter.init(); + // // fire md update + // Book book; + // sim.bookkeeping_data->get_leg_data(1).set_book(book); + // quoter.update_md(1); + // } + //}; + +TEST_CASE("Simple Test", "[spreader]") +{ + SECTION("nothing_really") + { + std::vector v; + for (int i = 0; i < 100; i++) + v.push_back(i); + REQUIRE(v.size() == 100); + } +} + + TEST_CASE("Simple Single Quoter Tester", "[spreader]") +{ + SECTION("nothing_really") { - SECTION("nothing_really") - { /*ISpreaderManager* sim = new SpreaderManagerSim(); OrderTemplate ot; SingleLegQuoter leg_1_q(*sim, ot, 0, Price(0.0), Quantity(10));*/ @@ -179,8 +192,9 @@ namespace spreader{ for (int i = 0; i < 100; i++) v.push_back(i); REQUIRE(v.size() == 100);*/ - } } +} + }} From 0c383bcb56fbd5b9446d4c7885771784c1901c7f Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Thu, 5 Oct 2017 10:52:35 -0400 Subject: [PATCH 03/13] merge --- externals | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/externals b/externals index a15b17370..466db3141 160000 --- a/externals +++ b/externals @@ -1 +1 @@ -Subproject commit a15b17370e680224500fe6258e3ebea5ce1a0fba +Subproject commit 466db3141f44511d722eee94afad4b32c6b3bf05 From bc0bc444011b0e947b3a5bf0f5a36591ecf76cf8 Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 16:04:06 +0000 Subject: [PATCH 04/13] Better book. --- src/server/sparkd/orderman/md/Book.h | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/server/sparkd/orderman/md/Book.h b/src/server/sparkd/orderman/md/Book.h index 57835d3ab..fc971196b 100644 --- a/src/server/sparkd/orderman/md/Book.h +++ b/src/server/sparkd/orderman/md/Book.h @@ -14,6 +14,30 @@ class MDSource; class Book { public: + Book () : + _security_key(), + _book() + {} + + Book (SecurityKey key, + BookSide const&bid, + BookSide const&ask) : + _security_key(key), + _book {bid,ask} + {} + + Book (Book const&rhs) + : _security_key(rhs._security_key), + _book(rhs._book) + {} + + Book &operator=(Book const &rhs) + { + _security_key = rhs._security_key; + _book = rhs._book; + return *this; + } + SecurityKey security_key() const {return _security_key;} ; BookSide const &bid () const {return _book[0];} From 06fc7609c6173f58c59e3924f069e1800ebd87b1 Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 16:05:16 +0000 Subject: [PATCH 05/13] Cleaner logging. --- src/lib/logging/Sink.cpp | 4 ++-- src/lib/logging/logging.h | 2 +- src/server/sparkd/main.cpp | 10 +++++++--- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/lib/logging/Sink.cpp b/src/lib/logging/Sink.cpp index e754635de..865050c64 100644 --- a/src/lib/logging/Sink.cpp +++ b/src/lib/logging/Sink.cpp @@ -40,11 +40,11 @@ struct InitSysLog { auto formatter() { return [] (LogMsg const&m) { - return fmt::format("{}: {} | ~{}:{}~ {}:{} tid:{} pid:{}", + return fmt::format("{}| ~{}:{}~ {} | {}:{} tid:{} pid:{}", datetime::time_string(datetime::now()), - m.msg, m.subsystem_name, m.level_name, + m.msg, boost::filesystem::path(m.file).filename().string() , m.line, m.tid, diff --git a/src/lib/logging/logging.h b/src/lib/logging/logging.h index e4a5ee93b..6e7eaf639 100644 --- a/src/lib/logging/logging.h +++ b/src/lib/logging/logging.h @@ -63,7 +63,7 @@ private: std::atomic _done; }; -#define LOG(subsystem,level,...) bts::log::_thread_logger.logger->enqueue(log::subsystem,level,__FILE__,__LINE__,__VA_ARGS__) +#define LOG(subsystem,level,...) bts::log::_thread_logger.logger->enqueue(bts::log::subsystem,level,__FILE__,__LINE__,__VA_ARGS__) #define LOG_ONCE_MAYBE(subsystem,level,...) bts::log::_thread_logger.logger->enqueue_once_maybe(log::subsystem,level,__FILE__,__LINE__,__VA_ARGS__) diff --git a/src/server/sparkd/main.cpp b/src/server/sparkd/main.cpp index 64947d577..6e69b43ce 100644 --- a/src/server/sparkd/main.cpp +++ b/src/server/sparkd/main.cpp @@ -7,6 +7,7 @@ #include "server/sparkd/cmds/Run.h" #include "server/sparkd/cmds/Help.h" #include "server/sparkd/cmds/TestOrderman.h" +#include "lib/logging/logging.h" #define BEGIN_CMD #define REGISTER(CMD) bts::cmd::CmdRegistry::register_cmd (#CMD) @@ -14,8 +15,11 @@ int main( int argc, char*argv [] ) { - bts::os::set_thread_name("main"); - bts::utils::init_spark_lib(); + using namespace bts; + + os::set_thread_name("main"); + utils::init_spark_lib(); + LOG(Gen,Warn,"Sparkd launched --------------------------------------------------------------------"); BEGIN_CMD; REGISTER (Test); @@ -24,7 +28,7 @@ int main( int argc, char*argv [] ) REGISTER (TestOrderman); END_CMD; - bts::utils::finit_spark_lib(); + utils::finit_spark_lib(); return 0; } From 5072cceb8b9b3eff5e676435f803c02f8ad1395e Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 16:05:30 +0000 Subject: [PATCH 06/13] Changed default location for persistence. --- src/server/sparkd/persistence/SqliteStore.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/sparkd/persistence/SqliteStore.cpp b/src/server/sparkd/persistence/SqliteStore.cpp index de5a73771..955f769b6 100644 --- a/src/server/sparkd/persistence/SqliteStore.cpp +++ b/src/server/sparkd/persistence/SqliteStore.cpp @@ -18,7 +18,7 @@ boost::filesystem::path db_location (std::string const&store_root,std::string co { std::string base_path = store_root; boost::filesystem::path result = utils::normalize_data_path (base_path); - result /= "PersistenceService"; + result /= "databases"; result /= db + ".sqlite"; return result; } From cb8fea89fd61fe204ee970a64eaa6dfb3f37160d Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 16:06:06 +0000 Subject: [PATCH 07/13] Better spreader order state reporting. --- externals | 2 +- src/lib/api/services/OrderService.proto | 4 +-- src/server/sparkd/cmds/TestOrderman.cpp | 2 +- .../orderman/components/SpreaderOrderMan.cpp | 20 ++++++++--- .../events/SpreaderOrderStateChange.cpp | 4 +-- .../orderman/service/OrderServiceServer.cpp | 9 +---- .../spreader_orders/SpreaderOrder.cpp | 34 +++++++++++++++++-- .../orderman/spreader_orders/SpreaderOrder.h | 1 + .../spreader_orders/SpreaderOrderState.h | 4 +-- 9 files changed, 57 insertions(+), 23 deletions(-) diff --git a/externals b/externals index a15b17370..466db3141 160000 --- a/externals +++ b/externals @@ -1 +1 @@ -Subproject commit a15b17370e680224500fe6258e3ebea5ce1a0fba +Subproject commit 466db3141f44511d722eee94afad4b32c6b3bf05 diff --git a/src/lib/api/services/OrderService.proto b/src/lib/api/services/OrderService.proto index 742c9639e..b9bbc0cc2 100644 --- a/src/lib/api/services/OrderService.proto +++ b/src/lib/api/services/OrderService.proto @@ -139,8 +139,8 @@ message NativeOrderState { } message SpreaderOrderState { - double target_price = 1; - uint32 target_quantity = 2 ; + double price = 1; + uint32 quantity = 2 ; string account_name = 3; string operator_id = 4; } diff --git a/src/server/sparkd/cmds/TestOrderman.cpp b/src/server/sparkd/cmds/TestOrderman.cpp index 616e57311..39c088f96 100644 --- a/src/server/sparkd/cmds/TestOrderman.cpp +++ b/src/server/sparkd/cmds/TestOrderman.cpp @@ -111,7 +111,7 @@ int TestOrderman::execute(std::vector const &) while (true) { std::cout << "create native order: n sec_key b/s price quantity\n" - "create spreader order: s sec_key b/s price quantity\n" + "create spreader order: s b/s price quantity\n" "update order: u price quantity\n" "cancel order: x\n" "change current order: o order_key n|s\n"; diff --git a/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp b/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp index 71199d1bf..de8e033df 100644 --- a/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp +++ b/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp @@ -40,9 +40,15 @@ SpreaderOrderMan::SpreaderOrderMan (securities::SecurityDB &sec_db, : me(new PImpl(sec_db,native_order_factory)) { for (auto const &os : existing_orders) - if (os.has_spreader()) - me->spreader_orders[OrderKey(os.order_key()) ] = - std::make_unique(sec_db,me->native_order_factory,os); + if (os.has_spreader()) { + auto spreader = std::make_unique(sec_db,me->native_order_factory,os); + spreader->init_signals(spreader_order_state_change_signal, + create_native_order_signal, + update_native_order_signal, + cancel_native_order_signal, + md_subscription_signal); + me->spreader_orders[OrderKey(os.order_key()) ] = std::move(spreader); + } } SpreaderOrderMan::~SpreaderOrderMan() {} @@ -50,8 +56,9 @@ SpreaderOrderMan::~SpreaderOrderMan() {} void SpreaderOrderMan::on(event_grid::event::Init const&) { LOG(OrderMan,Diag, "SpreaderOrderMan init"); - for (auto const &kvp : me->spreader_orders) + for (auto const &kvp : me->spreader_orders) { kvp.second->init(); + } } void SpreaderOrderMan::on(event::CreateSpreaderOrder const&cso) @@ -65,6 +72,11 @@ void SpreaderOrderMan::on(event::CreateSpreaderOrder const&cso) order = std::make_unique (me->sec_db, me->native_order_factory, cso.order_key,cso.create); + order->init_signals(spreader_order_state_change_signal, + create_native_order_signal, + update_native_order_signal, + cancel_native_order_signal, + md_subscription_signal); order->init(); if (me->gateway_ready) order->on_connect(); diff --git a/src/server/sparkd/orderman/events/SpreaderOrderStateChange.cpp b/src/server/sparkd/orderman/events/SpreaderOrderStateChange.cpp index 579223613..4beaa2137 100644 --- a/src/server/sparkd/orderman/events/SpreaderOrderStateChange.cpp +++ b/src/server/sparkd/orderman/events/SpreaderOrderStateChange.cpp @@ -31,8 +31,8 @@ api::orderman::OrderState to_pb(SpreaderOrderHeader const&header,SpreaderOrderSt if (current_state.reject_msg) result.set_reject_msg(*current_state.reject_msg); - spreader.set_target_price(current_state.target_price.value()); - spreader.set_target_quantity(current_state.target_quantity.value()); + spreader.set_price(current_state.price.value()); + spreader.set_quantity(current_state.quantity.value()); return result; } diff --git a/src/server/sparkd/orderman/service/OrderServiceServer.cpp b/src/server/sparkd/orderman/service/OrderServiceServer.cpp index fbbb5382d..d1b8dbc99 100644 --- a/src/server/sparkd/orderman/service/OrderServiceServer.cpp +++ b/src/server/sparkd/orderman/service/OrderServiceServer.cpp @@ -533,14 +533,6 @@ void OrderServiceServer::update_order(const api::orderman::UpdateOrderRequest& u api::orderman::UpdateOrderResponse resp; resp.set_order_key(update.order_key()); - if (!update.has_native()) { - resp.set_error_code(api::orderman::OE_UNSUPPORTED_ORDER_TYPE); - on_reply(resp); - return; - } - - auto const&native = update.native(); - if (me->state == State::DISCONNECTED) { resp.set_error_code(api::orderman::OE_GATEWAY_NOT_READY); on_reply(resp); @@ -560,6 +552,7 @@ void OrderServiceServer::update_order(const api::orderman::UpdateOrderRequest& u } if (update.has_native()) { + auto const&native = update.native(); auto it = me->native_order_objs.find(OrderKey(update.order_key())); if (it == me->native_order_objs.end()) { resp.set_error_code(api::orderman::OE_UNKNOWN_ORDER); diff --git a/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.cpp b/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.cpp index 47b01e8e6..cd683cedc 100644 --- a/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.cpp +++ b/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.cpp @@ -1,20 +1,36 @@ #include "SpreaderOrder.h" #include "lib/logging/logging.h" #include "lib/utils/PBUtils.h" +#include "server/sparkd/orderman/spreader_orders/SpreaderOrderState.h" namespace bts { namespace orderman { struct SpreaderOrder::PImpl { - PImpl() + PImpl(api::orderman::OrderStatus status, + Price price, Quantity quantity, + std::string const &reject_msg) + :status(status), + price(price), + quantity(quantity), + reject_msg(reject_msg) {} + + api::orderman::OrderStatus status; + Price price; + Quantity quantity; + std::string reject_msg; }; SpreaderOrder::SpreaderOrder(securities::SecurityDB &db, NativeOrderFactory &f, api::orderman::OrderState const&os) - : SpreaderOrderBase(db,f,os) , me (new PImpl()) + : SpreaderOrderBase(db,f,os) , + me (new PImpl(os.order_status(), + Price(os.spreader().price()), + Quantity(os.spreader().quantity()), + os.reject_msg())) { LOG(OrderMan,Diag,"recovered SpreaderOrder from state. state: {}", utils::pb::to_string(os)); @@ -24,7 +40,11 @@ SpreaderOrder::SpreaderOrder(securities::SecurityDB &db, NativeOrderFactory &f, OrderKey k, api::orderman::CreateOrderRequest const&cor) - : SpreaderOrderBase(db,f,k,cor) , me (new PImpl()) + : SpreaderOrderBase(db,f,k,cor) , + me (new PImpl(api::orderman::OS_UNACKNOWLEDGED, + Price(cor.spreader().price()), + Quantity(cor.spreader().quantity()), + std::string(""))) { LOG(OrderMan,Diag,"creating new SpreaderOrder. request: {}", utils::pb::to_string(cor)); @@ -32,9 +52,17 @@ SpreaderOrder::SpreaderOrder(securities::SecurityDB &db, SpreaderOrder::~SpreaderOrder () {} +void SpreaderOrder::report_state() +{ + report_state_change( + SpreaderOrderState { + me->status, me->price,me->quantity,me->reject_msg.empty()? nullptr:&me->reject_msg}); +} + void SpreaderOrder::init() { LOG(OrderMan,Diag,"Init"); + report_state(); } void SpreaderOrder::on_connect() diff --git a/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.h b/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.h index 612edcaab..cf8fcedda 100644 --- a/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.h +++ b/src/server/sparkd/orderman/spreader_orders/SpreaderOrder.h @@ -44,6 +44,7 @@ public: void on_external_error(std::string const&); private: + void report_state(); struct PImpl; std::unique_ptr me; }; diff --git a/src/server/sparkd/orderman/spreader_orders/SpreaderOrderState.h b/src/server/sparkd/orderman/spreader_orders/SpreaderOrderState.h index fee915c93..6f20feda4 100644 --- a/src/server/sparkd/orderman/spreader_orders/SpreaderOrderState.h +++ b/src/server/sparkd/orderman/spreader_orders/SpreaderOrderState.h @@ -9,8 +9,8 @@ class SpreaderOrderState { public: api::orderman::OrderStatus order_status; - Price target_price; - Quantity target_quantity; + Price price; + Quantity quantity; std::string *reject_msg; }; From 6f9232b6e03b19da5c33f1c8a1bdf2650f4b8bbc Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 16:31:34 +0000 Subject: [PATCH 08/13] Testing spreader manager --- src/server/sparkd/cmds/TestOrderman.cpp | 8 +++++++- .../sparkd/orderman/components/SpreaderOrderMan.cpp | 3 +-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/server/sparkd/cmds/TestOrderman.cpp b/src/server/sparkd/cmds/TestOrderman.cpp index 39c088f96..d78a64568 100644 --- a/src/server/sparkd/cmds/TestOrderman.cpp +++ b/src/server/sparkd/cmds/TestOrderman.cpp @@ -7,6 +7,7 @@ #include "server/sparkd/orderman/service/OrderServiceServer.h" #include "lib/api/public/ServiceContext.h" #include "lib/api/services/OrderService.client.pb.h" +#include "server/sparkd/cmds/Run.h" #include "lib/utils/datetime.h" #include "lib/utils/PBUtils.h" @@ -98,7 +99,11 @@ int TestOrderman::execute(std::vector const &) CurrentOrderType current_order_type (CurrentOrderType::UNDEFINED); api::ServiceContext ctx; - OrderServiceServer server(ctx); + auto server_thread = std::thread([]() { + cmd::Run run; + run.execute({}); + }); + api::orderman::OrderService client(ctx.locate ()); client.subscribe_orders().subscribe([](const api::orderman::OrdersUpdate &update) { @@ -197,3 +202,4 @@ std::string TestOrderman::help () }} + diff --git a/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp b/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp index de8e033df..b62f9d8e7 100644 --- a/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp +++ b/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp @@ -56,9 +56,8 @@ SpreaderOrderMan::~SpreaderOrderMan() {} void SpreaderOrderMan::on(event_grid::event::Init const&) { LOG(OrderMan,Diag, "SpreaderOrderMan init"); - for (auto const &kvp : me->spreader_orders) { + for (auto const &kvp : me->spreader_orders) kvp.second->init(); - } } void SpreaderOrderMan::on(event::CreateSpreaderOrder const&cso) From d1e2412f088fa186899a8dc25408d77ebb8229fe Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 22:38:21 +0000 Subject: [PATCH 09/13] Added tick rounding function for security prices. --- src/lib/domain_model/Security.h | 38 +++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/src/lib/domain_model/Security.h b/src/lib/domain_model/Security.h index 273a8811a..d48eaadbe 100644 --- a/src/lib/domain_model/Security.h +++ b/src/lib/domain_model/Security.h @@ -29,4 +29,42 @@ inline Price encode_exchange_price(api::Security const&sec, Price in) { return in; } +inline double raw_round_to_quote_price (double raw_price, double tick_size, api::BuySell side) +{ + double factor = 1000000; + auto i_price = llround (factor * raw_price); + auto i_tick_size = llround (tick_size * factor); + + long new_i_price = 0; + long mod = i_price % i_tick_size; + + if (mod == 0) + // price is already a valid tick + new_i_price = i_price; + else if (side == api::BUY) { + // buy, round down + if (i_price > 0) + new_i_price = i_price - mod; + else + new_i_price = i_price - mod - i_tick_size; + } + else if (side == api::SELL) { + // sell, round up + if (i_price > 0) + new_i_price = i_price - mod + i_tick_size; + else + new_i_price = i_price - mod; + } + + return new_i_price / factor; +} + +inline Price round_to_quote_price(api::Security const&sec, Price in, api::BuySell side) { + auto p = in.value(); + if (p < -sec.contract_spec().price_break() || p > sec.contract_spec().price_break()) + return Price(raw_round_to_quote_price(p,sec.contract_spec().high_tick(),side)); + else + return Price(raw_round_to_quote_price(p,sec.contract_spec().low_tick(),side)); +} + }} From 78808d0d061ec85a723cd1d5f268c54fa5b6fc05 Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 22:38:52 +0000 Subject: [PATCH 10/13] Fixed a bug in spreader order state reporting. --- .../orderman/components/SpreaderOrderMan.cpp | 16 +++++++++------- .../orderman/service/OrderServiceServer.cpp | 1 + 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp b/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp index b62f9d8e7..fca064da2 100644 --- a/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp +++ b/src/server/sparkd/orderman/components/SpreaderOrderMan.cpp @@ -42,11 +42,6 @@ SpreaderOrderMan::SpreaderOrderMan (securities::SecurityDB &sec_db, for (auto const &os : existing_orders) if (os.has_spreader()) { auto spreader = std::make_unique(sec_db,me->native_order_factory,os); - spreader->init_signals(spreader_order_state_change_signal, - create_native_order_signal, - update_native_order_signal, - cancel_native_order_signal, - md_subscription_signal); me->spreader_orders[OrderKey(os.order_key()) ] = std::move(spreader); } } @@ -56,8 +51,15 @@ SpreaderOrderMan::~SpreaderOrderMan() {} void SpreaderOrderMan::on(event_grid::event::Init const&) { LOG(OrderMan,Diag, "SpreaderOrderMan init"); - for (auto const &kvp : me->spreader_orders) - kvp.second->init(); + for (auto const &kvp : me->spreader_orders) { + auto &spreader = kvp.second; + spreader->init_signals(spreader_order_state_change_signal, + create_native_order_signal, + update_native_order_signal, + cancel_native_order_signal, + md_subscription_signal); + spreader->init(); + } } void SpreaderOrderMan::on(event::CreateSpreaderOrder const&cso) diff --git a/src/server/sparkd/orderman/service/OrderServiceServer.cpp b/src/server/sparkd/orderman/service/OrderServiceServer.cpp index d1b8dbc99..5a1a0d165 100644 --- a/src/server/sparkd/orderman/service/OrderServiceServer.cpp +++ b/src/server/sparkd/orderman/service/OrderServiceServer.cpp @@ -296,6 +296,7 @@ OrderServiceServer::OrderServiceServer (bts::api::ServiceContext& ctx) event_grid::forward (me->fast.node,me->slow.node); event_grid::forward (me->fast.node,me->slow.node); event_grid::forward (me->fast.node,me->slow.node); + event_grid::forward (me->fast.node,me->slow.node); me->publish_orders = make_orders_publisher(); me->publish_fills = make_fills_publisher(); me->publish_gateway_status = make_gateway_publisher(); From d783f6696c8a4542a495d4b637288fcc12608d6f Mon Sep 17 00:00:00 2001 From: Pedro Pinto Date: Thu, 5 Oct 2017 22:39:07 +0000 Subject: [PATCH 11/13] Improved logging format (maybe) --- src/lib/logging/Sink.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/logging/Sink.cpp b/src/lib/logging/Sink.cpp index 865050c64..b7481f636 100644 --- a/src/lib/logging/Sink.cpp +++ b/src/lib/logging/Sink.cpp @@ -40,7 +40,7 @@ struct InitSysLog { auto formatter() { return [] (LogMsg const&m) { - return fmt::format("{}| ~{}:{}~ {} | {}:{} tid:{} pid:{}", + return fmt::format("{}| {:<10} {:<8} | {} --- {}:{} tid:{} pid:{}", datetime::time_string(datetime::now()), m.subsystem_name, m.level_name, From fdb4eb6c5eaef53347da5841bcf6397bb10e1d52 Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Thu, 5 Oct 2017 20:10:00 -0400 Subject: [PATCH 12/13] tests and traverse_depth modified --- .../sparkd/spreader/SingleLegQuoter.cpp | 3 +- src/server/sparkd/spreader/SingleLegQuoter.h | 9 +- src/server/sparkd/spreader/SpreaderTests.cpp | 400 ++++++++++-------- src/server/sparkd/spreader/SpreaderUtils.h | 38 +- 4 files changed, 270 insertions(+), 180 deletions(-) diff --git a/src/server/sparkd/spreader/SingleLegQuoter.cpp b/src/server/sparkd/spreader/SingleLegQuoter.cpp index cf38f85ae..7dd6db8e7 100644 --- a/src/server/sparkd/spreader/SingleLegQuoter.cpp +++ b/src/server/sparkd/spreader/SingleLegQuoter.cpp @@ -22,7 +22,8 @@ SingleLegQuoter::SingleLegQuoter(ISpreaderManager& order_bridge, _state(QuoterState::START), _price_quantity_state(QuoteLegPriceQuantityState(spread_order_price, Quantity(static_cast(spread_order_quantity.value() * _this_leg_data.size_multiplier())))) { - _aux_comp_data.reserve(order_bridge.n_legs()); + for (size_t q_idx = 0; q_idx < order_bridge.n_legs(); q_idx++) + _aux_comp_data.push_back(PQPair()); } void SingleLegQuoter::init() diff --git a/src/server/sparkd/spreader/SingleLegQuoter.h b/src/server/sparkd/spreader/SingleLegQuoter.h index 5b3b1f56e..4550687aa 100644 --- a/src/server/sparkd/spreader/SingleLegQuoter.h +++ b/src/server/sparkd/spreader/SingleLegQuoter.h @@ -28,6 +28,7 @@ class SingleLegQuoter // cancel of this leg order (automatic or manual) CancelOrder, }; +public: // the states of the quoter state machine enum class QuoterState { @@ -55,7 +56,7 @@ class SingleLegQuoter // there are no working orders in this state. END }; - +private: // the external events and data are packaged into // this class and sent over to the state machine. // depending on the value of the external_event, @@ -104,7 +105,8 @@ class SingleLegQuoter Quantity leg_quantity; Quantity quoter_leg_quantity; PQPair() - : leg_price(0.0), + : + leg_price(0.0), leg_quantity(0), quoter_leg_quantity(0) {} @@ -158,6 +160,7 @@ public: // called when the hedge order is cancelled, either // manually or automatically void cancel_order(); + QuoterState get_state() { return _state; } private: /********************External Event Handling in START***********************/ void _handle_events_in_START(const EventData& event_data); @@ -191,6 +194,6 @@ private: // using the market of the other legs, computes the // quoting price and quantity, and if the quantity > 0 void _compute_price_quantity(Price& price, Quantity& quantity); - Price _compute_leg_price(const std::vector& leg_values); + Price _compute_leg_price(const std::vector& leg_values); }; }} \ No newline at end of file diff --git a/src/server/sparkd/spreader/SpreaderTests.cpp b/src/server/sparkd/spreader/SpreaderTests.cpp index 4d881e68e..085c84445 100644 --- a/src/server/sparkd/spreader/SpreaderTests.cpp +++ b/src/server/sparkd/spreader/SpreaderTests.cpp @@ -10,6 +10,8 @@ #include "SpreaderBase.h" #include "LegPropertyData.h" #include "SpreaderBookkeepingData.h" +#include "SpreaderUtils.h" +#include "../src/lib/utils/bts_chrono.h" #include #include @@ -18,183 +20,251 @@ using namespace bts::orderman; using namespace bts::spark; -namespace bts{ -namespace spreader{ -class SpreaderManagerSim : public ISpreaderManager -{ -private: - Book b; - api::FutureContract _leg_1_f; - api::Security _leg_1_s; - api::ContractLeg _leg_1_contract; - api::FutureContract _leg_2_f; - api::Security _leg_2_s; - api::ContractLeg _leg_2_contract; - api::ContractSpecification _spec; - api::SyntheticContract _synth_contract; - api::Security _spread_security; - QuoteParams _leg_1_q_params; - QuoteMuteZone _leg_1_qmz; - PreHedgeParams _leg_1_ph_params; - PostHedgeParams _leg_1_pph_params; - LegSpreaderParams _leg_1_spr_params; - LegPropertyData* _leg_1_property_data; - QuoteParams _leg_2_q_params; - QuoteMuteZone _leg_2_qmz; - PreHedgeParams _leg_2_ph_params; - PostHedgeParams _leg_2_pph_params; - LegSpreaderParams _leg_2_spr_params; - LegPropertyData* _leg_2_property_data; -public: - SpreaderBookkeepingData* bookkeeping_data; - SpreaderManagerSim() - { - //security - // common to leg1 and leg1 - _spec.set_low_tick(0.25); - _spec.set_high_tick(0.25); - // leg1 - _leg_1_f.set_expiration_day(15); - _leg_1_f.set_expiration_month(12); - _leg_1_f.set_expiration_year(2017); - _leg_1_s.set_id(1000); - _leg_1_s.set_symbol("ES"); - _leg_1_s.set_exchange(api::Venue::GLBX); - _leg_1_s.set_allocated_contract_spec(&_spec); - _leg_1_s.set_allocated_future(&_leg_1_f); +namespace bts { + namespace spreader { + class SpreaderManagerSim : public ISpreaderManager + { + private: + Book b; + api::FutureContract _leg_1_f; + api::Security _leg_1_s; + api::ContractLeg _leg_1_contract; + api::FutureContract _leg_2_f; + api::Security _leg_2_s; + api::ContractLeg _leg_2_contract; + api::ContractSpecification _spec; + api::SyntheticContract _synth_contract; + api::Security _spread_security; + QuoteParams _leg_1_q_params; + QuoteMuteZone _leg_1_qmz; + PreHedgeParams _leg_1_ph_params; + PostHedgeParams _leg_1_pph_params; + LegSpreaderParams _leg_1_spr_params; + LegPropertyData* _leg_1_property_data; + QuoteParams _leg_2_q_params; + QuoteMuteZone _leg_2_qmz; + PreHedgeParams _leg_2_ph_params; + PostHedgeParams _leg_2_pph_params; + LegSpreaderParams _leg_2_spr_params; + LegPropertyData* _leg_2_property_data; + public: + SpreaderBookkeepingData* bookkeeping_data; + SpreaderManagerSim() + { + //security + // common to leg1 and leg1 + _spec.set_low_tick(0.25); + _spec.set_high_tick(0.25); + // leg1 + _leg_1_f.set_expiration_day(15); + _leg_1_f.set_expiration_month(12); + _leg_1_f.set_expiration_year(2017); + _leg_1_s.set_id(1000); + _leg_1_s.set_symbol("ES"); + _leg_1_s.set_exchange(api::Venue::GLBX); + _leg_1_s.set_allocated_contract_spec(&_spec); + _leg_1_s.set_allocated_future(&_leg_1_f); - _leg_1_contract.set_allocated_security(&_leg_1_s); - _leg_1_contract.set_quantity(1.0); - _leg_1_contract.set_side(api::BuySell::BUY); - _leg_1_contract.set_price_multiplier(1.0); + _leg_1_contract.set_allocated_security(&_leg_1_s); + _leg_1_contract.set_quantity(1.0); + _leg_1_contract.set_side(api::BuySell::BUY); + _leg_1_contract.set_price_multiplier(1.0); - // leg2 - _leg_2_f.set_expiration_day(16); - _leg_2_f.set_expiration_month(3); - _leg_2_f.set_expiration_year(2018); + // leg2 + _leg_2_f.set_expiration_day(16); + _leg_2_f.set_expiration_month(3); + _leg_2_f.set_expiration_year(2018); - _leg_2_s.set_id(1001); - _leg_2_s.set_symbol("ES"); - _leg_2_s.set_exchange(api::Venue::GLBX); - _leg_2_s.set_allocated_contract_spec(&_spec); - _leg_2_s.set_allocated_future(&_leg_2_f); + _leg_2_s.set_id(1001); + _leg_2_s.set_symbol("ES"); + _leg_2_s.set_exchange(api::Venue::GLBX); + _leg_2_s.set_allocated_contract_spec(&_spec); + _leg_2_s.set_allocated_future(&_leg_2_f); - _leg_2_contract.set_allocated_security(&_leg_2_s); - _leg_2_contract.set_quantity(1.0); - _leg_2_contract.set_side(api::BuySell::SELL); - _leg_2_contract.set_price_multiplier(1.0); + _leg_2_contract.set_allocated_security(&_leg_2_s); + _leg_2_contract.set_quantity(1.0); + _leg_2_contract.set_side(api::BuySell::SELL); + _leg_2_contract.set_price_multiplier(1.0); - _synth_contract.set_name("spread_test_1"); - _synth_contract.set_price_calc(bts::api::SyntheticContract_PriceCalc::SyntheticContract_PriceCalc_diff); + _synth_contract.set_name("spread_test_1"); + _synth_contract.set_price_calc(bts::api::SyntheticContract_PriceCalc::SyntheticContract_PriceCalc_diff); - _synth_contract.mutable_legs()->AddAllocated(&_leg_1_contract); - _synth_contract.mutable_legs()->AddAllocated(&_leg_2_contract); + _synth_contract.mutable_legs()->AddAllocated(&_leg_1_contract); + _synth_contract.mutable_legs()->AddAllocated(&_leg_2_contract); - _spread_security.set_allocated_synthetic(&_synth_contract); + _spread_security.set_allocated_synthetic(&_synth_contract); - // LegSpreaderParams - _leg_1_qmz.set_outside_ticks(1); - _leg_1_qmz.set_inside_ticks(1); - _leg_1_q_params.set_allocated_quote_mute_zone(&_leg_1_qmz); - _leg_1_spr_params.set_allocated_quote_params(&_leg_1_q_params); - _leg_1_property_data = new LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY); + // LegSpreaderParams + _leg_1_qmz.set_outside_ticks(1); + _leg_1_qmz.set_inside_ticks(1); + _leg_1_q_params.set_allocated_quote_mute_zone(&_leg_1_qmz); + _leg_1_spr_params.set_allocated_quote_params(&_leg_1_q_params); + _leg_1_property_data = new LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY); - _leg_2_qmz.set_outside_ticks(1); - _leg_2_qmz.set_inside_ticks(1); - _leg_2_q_params.set_allocated_quote_mute_zone(&_leg_2_qmz); - _leg_2_spr_params.set_allocated_quote_params(&_leg_2_q_params); - _leg_2_property_data = new LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::BUY); + _leg_2_qmz.set_outside_ticks(1); + _leg_2_qmz.set_inside_ticks(1); + _leg_2_q_params.set_allocated_quote_mute_zone(&_leg_2_qmz); + _leg_2_spr_params.set_allocated_quote_params(&_leg_2_q_params); + _leg_2_property_data = new LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::BUY); - SpreaderBookkeepingData::LegData leg_1_data(*_leg_1_property_data); - SpreaderBookkeepingData::LegData leg_2_data(*_leg_2_property_data); + SpreaderBookkeepingData::LegData leg_1_data(*_leg_1_property_data); + SpreaderBookkeepingData::LegData leg_2_data(*_leg_2_property_data); - std::vector leg_data_v; - leg_data_v.push_back(LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY)); - leg_data_v.push_back(LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::SELL)); + std::vector leg_data_v; + leg_data_v.push_back(LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY)); + leg_data_v.push_back(LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::SELL)); - bookkeeping_data = new SpreaderBookkeepingData(_spread_security, leg_data_v); - } - bts::orderman::OrderKey send_limit_order(const OrderTemplate&, bts::Price, bts::Quantity) override - { - OrderKey key(1); - return key; - } - // orders are modified through this. order_key uniquely distinguishes orders - void update_order(bts::orderman::OrderKey, bts::Price, bts::Quantity) override - { + bookkeeping_data = new SpreaderBookkeepingData(_spread_security, leg_data_v); + } + bts::orderman::OrderKey send_limit_order(const OrderTemplate&, bts::Price, bts::Quantity) override + { + OrderKey key(1); + return key; + } + // orders are modified through this. order_key uniquely distinguishes orders + void update_order(bts::orderman::OrderKey, bts::Price, bts::Quantity) override + { + + } + // call this to cancel orders + void cancel_order(bts::orderman::OrderKey) override + { + } + // for a leg index, returns the Book in O(1). the caller can hold at + // reference to the returned type forever (the data in the returned + // type can change beneath it) + const orderman::Book& get_book(size_t index) const override + { + SpreaderBookkeepingData::LegData& leg_data = bookkeeping_data->get_leg_data(index); + return leg_data.book; + } + // the caller can keep a reference to the returned type forever. the + // data in the returned type is all const, so nothing will change + // beneath it + const LegPropertyData& get_leg_data(size_t index) const override + { + SpreaderBookkeepingData::LegData& leg_data = bookkeeping_data->get_leg_data(index); + return leg_data.leg_shared_data; + } + // number of legs on the spread + size_t n_legs() const override + { + return 2; + } + }; + + void _fill_book(Book& book, double inside_market, double tick_size, uint16_t* sizes, bts::api::BuySell side) + { + BookSide& bookside = book.side(side); + for (size_t i = 0; i < book.n_levels(); i++) + { + bookside[i] = md2::PriceSize::from_double<2>(inside_market, sizes[i]); + if (side == bts::api::BuySell::BUY) + inside_market -= tick_size; + else + inside_market += tick_size; + } + } + + TEST_CASE("Simple Test", "[spreader]") + { + SECTION("nothing_really") + { + std::vector v; + for (int i = 0; i < 100; i++) + v.push_back(i); + REQUIRE(v.size() == 100); + } + } + + TEST_CASE("Depth Traversal Test", "[spreader]") + { + SECTION("Depth Traversal Test") + { + // fire md update + Book book; + // run 1 + uint16_t book_sizes_1[] = { 10, 30, 100, 5, 5 }; + _fill_book(book, 2500, 0.25, book_sizes_1, api::BuySell::BUY); + Quantity out_quantity; Price out_price; + SpreaderUtils::traverse_depth_for_quantity(book, api::BuySell::BUY, Quantity(100), out_price, out_quantity); + REQUIRE(out_quantity.value()==100); + REQUIRE(out_price.value() == 2499.5); + // run 2 + uint16_t book_sizes_2[] = { 11, 13, 17, 19, 23 }; + _fill_book(book, 2500, 0.25, book_sizes_2, api::BuySell::BUY); + SpreaderUtils::traverse_depth_for_quantity(book, api::BuySell::BUY, Quantity(100), out_price, out_quantity); + REQUIRE(out_quantity.value() == 83); + REQUIRE(out_price.value() == 2499.0); + // run 3 + uint16_t book_sizes_3[] = { 100, 13, 17, 19, 23 }; + _fill_book(book, 2500, 0.25, book_sizes_3, api::BuySell::BUY); + SpreaderUtils::traverse_depth_for_quantity(book, api::BuySell::BUY, Quantity(100), out_price, out_quantity); + REQUIRE(out_quantity.value() == 100); + REQUIRE(out_price.value() == 2500.0); + // run 4 + uint16_t book_sizes_4[] = { 1, 0, 17, 19, 23 }; + _fill_book(book, 2500, 0.25, book_sizes_4, api::BuySell::BUY); + SpreaderUtils::traverse_depth_for_quantity(book, api::BuySell::BUY, Quantity(100), out_price, out_quantity); + REQUIRE(out_quantity.value() == 1); + REQUIRE(out_price.value() == 2500.0); + // run 5 + uint16_t book_sizes_5[] = { 0, 1, 17, 19, 23 }; + _fill_book(book, 2500, 0.25, book_sizes_5, api::BuySell::BUY); + SpreaderUtils::traverse_depth_for_quantity(book, api::BuySell::BUY, Quantity(100), out_price, out_quantity); + REQUIRE(out_quantity.value() == 0); + REQUIRE(out_price.value() == 0); + } + } + + + TEST_CASE("Depth Traversal Perf Test", "[spreader]") + { + SECTION("Depth Traversal Performance Test") + { + for (int t = 0; t < 10; t++) + { + // fire md update + Book book; + // run 1 + uint16_t book_sizes_1[] = { 11, 13, 17, 19, 23 }; + _fill_book(book, 2500, 0.25, book_sizes_1, api::BuySell::BUY); + size_t n_runs = 1000000; + Quantity out_quantity; Price out_price; + auto t0 = Timer::now(); + for (size_t i = 0; i < n_runs; i++) + { + SpreaderUtils::traverse_depth_for_quantity(book, api::BuySell::BUY, Quantity(100), out_price, out_quantity); + } + auto t1 = Timer::now(); + int64_t diff = us_diff(t1, t0); + REQUIRE(diff < 1000000); + } + } + } + + //TEST_CASE("Simple Single Quoter Tester", "[spreader]") + //{ + // SECTION("Start state") + // { + // // create sim spreader + // bts::spreader::SpreaderManagerSim sim; + // // create quoter + // OrderTemplate ord_templ; + // SingleLegQuoter quoter(sim, ord_templ, 0, Price(0.0), Quantity(100)); + // REQUIRE(quoter.get_state() == SingleLegQuoter::QuoterState::START); + + // quoter.init(); + // REQUIRE(quoter.get_state() == SingleLegQuoter::QuoterState::WAITING_FOR_MARKET); + // // fire md update + // Book book; + // uint16_t book_sizes[] = { 10, 30, 100, 5, 5 }; + // _fill_book(book, 2500, 0.25, book_sizes, api::BuySell::BUY); + // sim.bookkeeping_data->get_leg_data(1).set_book(book); + // quoter.update_md(1); + // } + //} } - // call this to cancel orders - void cancel_order(bts::orderman::OrderKey) override - { - } - // for a leg index, returns the Book in O(1). the caller can hold at - // reference to the returned type forever (the data in the returned - // type can change beneath it) - const orderman::Book& get_book(size_t index) const override - { - SpreaderBookkeepingData::LegData& leg_data = bookkeeping_data->get_leg_data(index); - return leg_data.book; - } - // the caller can keep a reference to the returned type forever. the - // data in the returned type is all const, so nothing will change - // beneath it - const LegPropertyData& get_leg_data(size_t index) const override - { - SpreaderBookkeepingData::LegData& leg_data = bookkeeping_data->get_leg_data(index); - return leg_data.leg_shared_data; - } - // number of legs on the spread - size_t n_legs() const override - { - return 2; - } -}; - - //class SpreaderTestHelper - //{ - //public: - // static void test() - // { - // // create sim spreader - // bts::spreader::SpreaderManagerSim sim; - // // create quoter - // OrderTemplate ord_templ; - // SingleLegQuoter quoter(sim, ord_templ, 0, Price(0.0), Quantity(10)); - // quoter.init(); - // // fire md update - // Book book; - // sim.bookkeeping_data->get_leg_data(1).set_book(book); - // quoter.update_md(1); - // } - //}; - -TEST_CASE("Simple Test", "[spreader]") -{ - SECTION("nothing_really") - { - std::vector v; - for (int i = 0; i < 100; i++) - v.push_back(i); - REQUIRE(v.size() == 100); - } -} - - TEST_CASE("Simple Single Quoter Tester", "[spreader]") -{ - SECTION("nothing_really") - { - /*ISpreaderManager* sim = new SpreaderManagerSim(); - OrderTemplate ot; - SingleLegQuoter leg_1_q(*sim, ot, 0, Price(0.0), Quantity(10));*/ - /*std::vector v; - for (int i = 0; i < 100; i++) - v.push_back(i); - REQUIRE(v.size() == 100);*/ - } -} - -}} - - +} \ No newline at end of file diff --git a/src/server/sparkd/spreader/SpreaderUtils.h b/src/server/sparkd/spreader/SpreaderUtils.h index 26b185889..7a1ce0ed8 100644 --- a/src/server/sparkd/spreader/SpreaderUtils.h +++ b/src/server/sparkd/spreader/SpreaderUtils.h @@ -109,26 +109,42 @@ public: void static traverse_depth_for_quantity(const orderman::Book& leg_book, const api::BuySell book_side, Quantity target_quantity, Price& out_price, Quantity& out_quantity) { - double out_price_d = 0.0; - uint32_t out_quantity_u = 0; + uint32_t cum_quantity_u = 0; const size_t n_levels = leg_book.n_levels(); + // we could have kept a running price, updated at each level, + // but to avoid the price() call on PriceSize, we keep a running + // index. (could have piggy backed on the for index, but i think + // this is clearer) + size_t last_nonzero_level = 0; const orderman::BookSide& book_depth = leg_book.side(book_side); for (size_t level = 0; level < n_levels; level++) { md2::PriceSize level_price_qty = book_depth[level]; md2::Size level_qty = level_price_qty.size(); - out_price_d = level_price_qty.price(); - out_quantity_u += level_qty; - if (out_quantity_u >= target_quantity.value()) - { - out_quantity_u = target_quantity.value(); - break; - } if (level_qty == 0) break; + else + { + last_nonzero_level = level; + cum_quantity_u += level_qty; + if (cum_quantity_u >= target_quantity.value()) + { + // early break, we have already accumulted the target + cum_quantity_u = target_quantity.value(); + break; + } + } + } + if (cum_quantity_u == 0) + { + out_quantity = Quantity(0); + out_price = Price(0); + } + else + { + out_quantity = Quantity(cum_quantity_u); + out_price = Price(book_depth[last_nonzero_level].price()); } - out_price = Price(out_price_d); - out_quantity = Quantity(out_quantity_u); } // given the new price, applies the quoting parameters (mute etc) // to see if quote needs to be repriced From f3b22ff6902528fa1339b801ccc8f8cab4037113 Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Thu, 5 Oct 2017 22:26:11 -0400 Subject: [PATCH 13/13] quoter tests --- .../sparkd/spreader/SingleLegQuoter.cpp | 23 +++++++----- src/server/sparkd/spreader/SingleLegQuoter.h | 2 +- src/server/sparkd/spreader/SpreaderTests.cpp | 37 +++++++++++++++++++ src/server/sparkd/spreader/SpreaderUtils.h | 17 +-------- 4 files changed, 52 insertions(+), 27 deletions(-) diff --git a/src/server/sparkd/spreader/SingleLegQuoter.cpp b/src/server/sparkd/spreader/SingleLegQuoter.cpp index 7dd6db8e7..56c26c29f 100644 --- a/src/server/sparkd/spreader/SingleLegQuoter.cpp +++ b/src/server/sparkd/spreader/SingleLegQuoter.cpp @@ -373,14 +373,17 @@ void SingleLegQuoter::_compute_price_quantity(Price& price, Quantity& quantity) { if (idx != _this_leg_index) { - const orderman::Book leg_book = _order_bridge.get_book(idx); - Price leg_price; Quantity leg_quantity, quoter_leg_quantity; - Quantity leg_target_quantity = _price_quantity_state.remaining_to_fill(); - SpreaderUtils::traverse_depth_for_quantity(leg_book, api::BuySell::BUY, Quantity(static_cast(leg_target_quantity.value() * 1.0 /*TODO*/)), leg_price, leg_quantity); - quoter_leg_quantity = Quantity(static_cast(1.0 /*TODOit->lean_ratio*/ * leg_quantity.value())); + const orderman::Book& other_leg_book = _order_bridge.get_book(idx); + const LegPropertyData& other_leg_data = _order_bridge.get_leg_data(idx); + Price other_leg_calc_price; Quantity other_leg_calc_quantity, this_leg_calc_quantity; + Quantity this_leg_target_quantity = _price_quantity_state.remaining_to_fill(); + double other_leg_total_lean_ratio = other_leg_data.leg_params.quote_params().lean_quantity_ratio() * other_leg_data.size_multiplier() / _this_leg_data.size_multiplier(); + double other_leg_target_quantity = this_leg_target_quantity.value() * other_leg_total_lean_ratio; + SpreaderUtils::traverse_depth_for_quantity(other_leg_book, SpreaderUtils::invert_side (other_leg_data.trading_side), Quantity(other_leg_target_quantity), other_leg_calc_price, other_leg_calc_quantity); + this_leg_calc_quantity = Quantity(static_cast(1.0 /*TODOit->lean_ratio*/ * other_leg_calc_quantity.value())); PQPair& leg_price_quantity = _aux_comp_data.at(idx); - leg_price_quantity.set(leg_price, leg_quantity, quoter_leg_quantity); - if (_aux_comp_data.at(min_quoter_leg_quantity_index).quoter_leg_quantity.value() <= quoter_leg_quantity.value()) + leg_price_quantity.set(other_leg_calc_price, other_leg_calc_quantity, this_leg_calc_quantity); + if (_aux_comp_data.at(min_quoter_leg_quantity_index).quoter_leg_quantity.value() <= this_leg_calc_quantity.value()) min_quoter_leg_quantity_index = idx; } } @@ -390,14 +393,14 @@ void SingleLegQuoter::_compute_price_quantity(Price& price, Quantity& quantity) Price SingleLegQuoter::_compute_leg_price(const std::vector& leg_values) { - size_t idx = 0; double sum = 0; - for (auto it = leg_values.begin(); it != leg_values.end(); it++) + for (size_t idx = 0; idx < _order_bridge.n_legs(); idx++) { if (idx != _this_leg_index) { + const PQPair& leg_pq_pair = leg_values[idx]; const LegPropertyData& leg_data = _order_bridge.get_leg_data (idx); - sum += it->leg_price.value() * leg_data.price_multiplier(); + sum += leg_pq_pair.leg_price.value() * leg_data.price_multiplier(); } } double rv = _price_quantity_state.target_spread_price().value() - sum; /// TODO, needs a divisor diff --git a/src/server/sparkd/spreader/SingleLegQuoter.h b/src/server/sparkd/spreader/SingleLegQuoter.h index 4550687aa..b67b18709 100644 --- a/src/server/sparkd/spreader/SingleLegQuoter.h +++ b/src/server/sparkd/spreader/SingleLegQuoter.h @@ -192,7 +192,7 @@ private: // to the size of an other leg. double _get_equivelant_quantity(size_t leg_index, Quantity quantity); // using the market of the other legs, computes the - // quoting price and quantity, and if the quantity > 0 + // quoting price and quantity void _compute_price_quantity(Price& price, Quantity& quantity); Price _compute_leg_price(const std::vector& leg_values); }; diff --git a/src/server/sparkd/spreader/SpreaderTests.cpp b/src/server/sparkd/spreader/SpreaderTests.cpp index 085c84445..ec02767c0 100644 --- a/src/server/sparkd/spreader/SpreaderTests.cpp +++ b/src/server/sparkd/spreader/SpreaderTests.cpp @@ -12,6 +12,7 @@ #include "SpreaderBookkeepingData.h" #include "SpreaderUtils.h" #include "../src/lib/utils/bts_chrono.h" +#include "SpreaderOrderUpdateMessage.h" #include #include @@ -99,12 +100,14 @@ namespace bts { _leg_1_qmz.set_outside_ticks(1); _leg_1_qmz.set_inside_ticks(1); _leg_1_q_params.set_allocated_quote_mute_zone(&_leg_1_qmz); + _leg_1_q_params.set_lean_quantity_ratio(1.0); _leg_1_spr_params.set_allocated_quote_params(&_leg_1_q_params); _leg_1_property_data = new LegPropertyData(0, _leg_1_contract, _leg_1_spr_params, api::BuySell::BUY); _leg_2_qmz.set_outside_ticks(1); _leg_2_qmz.set_inside_ticks(1); _leg_2_q_params.set_allocated_quote_mute_zone(&_leg_2_qmz); + _leg_2_q_params.set_lean_quantity_ratio(1.0); _leg_2_spr_params.set_allocated_quote_params(&_leg_2_q_params); _leg_2_property_data = new LegPropertyData(1, _leg_2_contract, _leg_1_spr_params, api::BuySell::BUY); @@ -266,5 +269,39 @@ namespace bts { // } //} + TEST_CASE("Simple Single Quoter Reprice Perf", "[spreader]") + { + SECTION("Reprice Perf") + { + // create sim spreader + bts::spreader::SpreaderManagerSim sim; + // create quoter + OrderTemplate ord_templ; + SingleLegQuoter quoter(sim, ord_templ, 0, Price(0.0), Quantity(100)); + REQUIRE(quoter.get_state() == SingleLegQuoter::QuoterState::START); + + quoter.init(); + REQUIRE(quoter.get_state() == SingleLegQuoter::QuoterState::WAITING_FOR_MARKET); + // fire md update + Book book; + uint16_t book_sizes[] = { 10, 30, 100, 5, 5 }; + _fill_book(book, 2500, 0.25, book_sizes, api::BuySell::BUY); + sim.bookkeeping_data->get_leg_data(1).set_book(book); + quoter.update_md(1); + quoter.update_md(1); + quoter.update_order_status(SpreaderOrderUpdateMessage(OrderKey(1), api::orderman::OrderStatus::OS_NEW, Quantity(0), Price(0), Quantity(0), Price(0), NULL)); + + size_t n_runs = 10, n_updates = 1000000; + for (size_t t = 0; t < n_runs; t++) + { + auto t0 = Timer::now(); + for (size_t u = 0; u < n_updates; u++) + quoter.update_md(1); + auto t1 = Timer::now(); + int64_t diff = us_diff(t1, t0); + REQUIRE(diff < 10000000); + } + } + } } } \ No newline at end of file diff --git a/src/server/sparkd/spreader/SpreaderUtils.h b/src/server/sparkd/spreader/SpreaderUtils.h index 7a1ce0ed8..4451b826c 100644 --- a/src/server/sparkd/spreader/SpreaderUtils.h +++ b/src/server/sparkd/spreader/SpreaderUtils.h @@ -49,22 +49,7 @@ public: bts_assert_d(out_index < key_to_index_map.size()); return true; } - } - /*static void fill_leg_shared_data(const bts::api::Security& sec, const bts::spark::ExecutionStrategy& execution_strategy, api::BuySell order_side, - std::vector& out_v) - { - bts_assert(sec.has_synthetic()); - size_t index = 0; - for (auto it = sec.synthetic().legs().begin(); it != sec.synthetic().legs().end(); ++it) - { - uint32_t sec_key = it->security().id(); - auto st_it = execution_strategy.leg_params_map().find(sec_key); - bts_assert(st_it != execution_strategy.leg_params_map().end()); - const bts::api::ContractLeg& leg = *it; - api::BuySell leg_order_side = get_leg_side(order_side, leg); - out_v.push_back(LegPropertyData(index, sec, leg, st_it->second, leg_order_side)); - } - }*/ + } const static bts::spark::LegSpreaderParams& find_spread_params(const bts::spark::ExecutionStrategy& exec_strategy, const bts::api::Security& leg_security) {