From 751f22645d5adf0b4a42bc4f5e58d0c10f2a4dfc Mon Sep 17 00:00:00 2001 From: John Colvin Date: Sun, 10 Mar 2019 22:21:53 -0500 Subject: [PATCH] SPARK-2089 [cherry-picked] Strange null ref exception in OrderBook row-selection changed callback during application shutdown --- .../Modules/Trading/OrderBook/OrderBookVM.cs | 24 +++++++++++-------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs index 193e66887..d7e964708 100644 --- a/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs +++ b/src/client/spark/Modules/Trading/OrderBook/OrderBookVM.cs @@ -105,19 +105,23 @@ namespace mbts.spark { } public void row_selection_changed(SelectionChangedEventArgs e) { - if (e.RemovedItems != null) { - foreach (var row_vm in e.RemovedItems.Cast()) { - row_vm.is_selected = false; + try { + if (e.RemovedItems != null) { + foreach (var row_vm in e.RemovedItems.Cast()) { + row_vm.is_selected = false; + } } - } - if (e.AddedItems != null) { - foreach (var row_vm in e.AddedItems.Cast()) { - row_vm.is_selected = true; + if (e.AddedItems != null) { + foreach (var row_vm in e.AddedItems.Cast()) { + row_vm.is_selected = true; + } } + RowSelectionHelper.apply_changes(_selected_rows, e); + selected_order_changed?.Invoke(current_order); + } catch (Exception ex) { + // [John]I observed a strange null-reference exception in this callback when the launcher was shutting down (see https://bluetradesys.atlassian.net/browse/SPARK-2089) + Log.Ui.error($"[{nameof(OrderBookVM)}] Error handling selection change: {ex}"); } - - RowSelectionHelper.apply_changes(_selected_rows, e); - selected_order_changed?.Invoke(current_order); } public OrderBookStartupData create() {