From 73a301192f227201941faf8680cbff361d836ac0 Mon Sep 17 00:00:00 2001 From: taha afzal Date: Wed, 18 May 2022 17:14:33 -0400 Subject: [PATCH] Fixing ExchangePosition's qty (unsigned uint related bug) and exchange --- src/lib/orderman/OrderServiceServer.cpp | 3 ++- src/lib/orderman/gateways/EMExecutionGateway.cpp | 4 ++-- src/lib/orderman/orderman_utils/ExchangePosition.h | 2 +- src/server/sparkd/md/platforms/emumba/EmMDListener.cpp | 7 ++++++- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/lib/orderman/OrderServiceServer.cpp b/src/lib/orderman/OrderServiceServer.cpp index 6fbdd63d7..c94d5edf2 100644 --- a/src/lib/orderman/OrderServiceServer.cpp +++ b/src/lib/orderman/OrderServiceServer.cpp @@ -446,7 +446,8 @@ void OrderServiceServer::_on_exchange_position( ret_pos.set_security_resolved(p.security != nullptr); ret_pos.set_exchange_desc(p.exchange_sec_desc); ret_pos.set_avg_filled_price(p.avg_filled_price.value()); - ret_pos.set_position(p.position.whole_value()); + ret_pos.set_position(p.position); + ret_pos.set_exchange(ev.position.exchange); me->exchange_pos_publisher.add_or_update(ret_pos); LOG(OrderMan, Info, "OrderServiceServer::_on_exchange_position publishing pos id: {} " diff --git a/src/lib/orderman/gateways/EMExecutionGateway.cpp b/src/lib/orderman/gateways/EMExecutionGateway.cpp index eae4e7d39..39787fbc1 100644 --- a/src/lib/orderman/gateways/EMExecutionGateway.cpp +++ b/src/lib/orderman/gateways/EMExecutionGateway.cpp @@ -447,13 +447,13 @@ void EMExecutionGateway::_process_pos_cb_and_fire( return static_cast(nullptr); }; me->exchange_position.total_exchange_positions.clear(); + // TODO: need to fix this whem EM connects to multiple exchanges + me->exchange_position.exchange = api::VENUE_DERIBIT; for (const auto &pos : pos_cb_msg.positions) { const std::string &exch_sec_desc = std::get(pos.sec_id.value()); auto sec = get_sec(exch_sec_desc); double pos_qty = std::get(pos.qty.value()); - if (pos.position_side == emumba::market_data::side::sell) - pos_qty = pos_qty * -1.0; me->exchange_position.total_exchange_positions.push_back( {exch_sec_desc, sec, pos_qty, Price(pos.average_price.to_double())}); } diff --git a/src/lib/orderman/orderman_utils/ExchangePosition.h b/src/lib/orderman/orderman_utils/ExchangePosition.h index b1224ee44..9e679d3ca 100644 --- a/src/lib/orderman/orderman_utils/ExchangePosition.h +++ b/src/lib/orderman/orderman_utils/ExchangePosition.h @@ -16,7 +16,7 @@ class ExchangePosition { public: std::string exchange_sec_desc; api::Security const *security; - Quantity position; + double position; Price avg_filled_price; }; api::Venue exchange; diff --git a/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp b/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp index 989cd58ed..a14669274 100644 --- a/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp +++ b/src/server/sparkd/md/platforms/emumba/EmMDListener.cpp @@ -412,6 +412,11 @@ void EmMDListener::on_get_all_positions( "{}", extract_security_desc(p->sec_id), static_cast(p->position_side), std::get(p->qty.value()), p->average_price.to_double()); + bts_assert( + (p->position_side == emumba::market_data::side::buy && + extract_qty(p->qty) >= 0) || + (p->position_side == emumba::market_data::side::sell && + extract_qty(p->qty) <= 0)); } me->pos_helper.on_new_update(positions); if (!me->pos_helper.pending()) { @@ -652,7 +657,7 @@ void EmMDListener::on_quote( void _log_book( EmumbaSecurityData *s_data, const emumba::market_data::order_book &book) { if (s_data->handle.security().type == api::SECURITYTYPE_OPTION) { - LOG(md, Info, "BookTop sec: {} bid: {}/{} ask: {}/{}", + LOG(md, Diag, "BookTop sec: {} bid: {}/{} ask: {}/{}", std::string(s_data->handle.security().security_desc()), book.bids.level[0].px.to_double(), book.bids.level[0].direct_qty, book.asks.level[0].px.to_double(), book.asks.level[0].direct_qty);