From 705bf5b167d8368372b080a7fc5919cdb80074cd Mon Sep 17 00:00:00 2001 From: Eric Harding Date: Mon, 26 Feb 2018 12:23:11 -0500 Subject: [PATCH] Spark-563 return an error if user requests to create a security which already exists. --- .../api/services/SyntheticSecurityService.proto | 1 + src/lib/md/SyntheticSecurityService.cpp | 14 ++++++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/lib/api/services/SyntheticSecurityService.proto b/src/lib/api/services/SyntheticSecurityService.proto index 120a3d82d..45cf03b63 100644 --- a/src/lib/api/services/SyntheticSecurityService.proto +++ b/src/lib/api/services/SyntheticSecurityService.proto @@ -15,6 +15,7 @@ message CreateResult { ERROR_BAD_VENUE = 3; ERROR_BAD_NAME = 4; ERROR_BAD_SYMBOL = 5; + ERROR_SECURITY_ALREADY_EXISTS = 6; } uint32 key = 1; Error error = 2; diff --git a/src/lib/md/SyntheticSecurityService.cpp b/src/lib/md/SyntheticSecurityService.cpp index db3994e3d..3bef7f075 100644 --- a/src/lib/md/SyntheticSecurityService.cpp +++ b/src/lib/md/SyntheticSecurityService.cpp @@ -117,10 +117,16 @@ void SyntheticSecurityService::create_synthetic( // Assign security key _me->recorder.assign_key(security, [this, reply](const api::Security& security) { // Notify listeners that a new security is added - _me->synthetics.insert(std::make_pair(security.id(), security)); - _me->on_security.publish(security); - // signal success - send_reply(reply, CreateResult::ERROR_OK, security.id()); + auto iter = _me->synthetics.find(SecurityKey(security.id())); + if (iter != _me->synthetics.end()) { + send_reply(reply, CreateResult::ERROR_SECURITY_ALREADY_EXISTS, security.id()); + } + else { + _me->synthetics.insert(std::make_pair(security.id(), security)); + _me->on_security.publish(security); + // signal success + send_reply(reply, CreateResult::ERROR_OK, security.id()); + } }); }