From 6e6b9faa385bede4e5363582001f697b566389b3 Mon Sep 17 00:00:00 2001 From: Taha Afzal Date: Mon, 19 Mar 2018 10:03:24 -0400 Subject: [PATCH] Fixed a bug where if the throttle params were unset, modifications would be sent for no reason --- .../spreader_orders/spreader/SingleFillHedger.cpp | 2 +- .../quoter/quoter_states/QuoterWorkingStateWorker.cpp | 11 ++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/server/sparkd/orderman/orders/spreader_orders/spreader/SingleFillHedger.cpp b/src/server/sparkd/orderman/orders/spreader_orders/spreader/SingleFillHedger.cpp index b2a3dd011..cff983ff9 100644 --- a/src/server/sparkd/orderman/orders/spreader_orders/spreader/SingleFillHedger.cpp +++ b/src/server/sparkd/orderman/orders/spreader_orders/spreader/SingleFillHedger.cpp @@ -27,7 +27,7 @@ SingleFillHedger::SingleFillHedger(ISpreaderManager& spreader_manager, _waiting_for_cancel_ack_state_worker (this), _end_state_worker (this) { - LOG(OrderMan,Diag,"SingleFillHedger cons, sec {} price {} quantity {} order_key {}", leg_property_data.security_key(), hedge_price.value(), hedge_quantity.value(), _key().value()); + LOG(OrderMan, Info, "SingleFillHedger cons, sec {} price {} quantity {} order_key {}", leg_property_data.security_key(), hedge_price.value(), hedge_quantity.value(), _key().value()); transform_to_START (); } SingleFillHedger::SingleFillHedger (SingleFillHedger& other, SpreaderChildOrderState& child_order_state) diff --git a/src/server/sparkd/orderman/orders/spreader_orders/spreader/quoter/quoter_states/QuoterWorkingStateWorker.cpp b/src/server/sparkd/orderman/orders/spreader_orders/spreader/quoter/quoter_states/QuoterWorkingStateWorker.cpp index 6e6c09037..67dbe9e84 100644 --- a/src/server/sparkd/orderman/orders/spreader_orders/spreader/quoter/quoter_states/QuoterWorkingStateWorker.cpp +++ b/src/server/sparkd/orderman/orders/spreader_orders/spreader/quoter/quoter_states/QuoterWorkingStateWorker.cpp @@ -94,8 +94,13 @@ void QuoterWorkingStateWorker::_longpath_analyze_and_act (bts::orderman::TickToT } void QuoterWorkingStateWorker::_modify_order (orderman::TickToTradeCorID , Price price, Quantity quantity) { - _quoter->_price_quantity_state.update_out_price_quantity(price, quantity); - _quoter->_commit_drivers (); - _quoter->_modify_order(price, quantity); + bool same_price_qty = _quoter->_price_quantity_state.out_quantity() == quantity && + bts::securities::test_price_equality(_quoter->_price_quantity_state.out_price().value(), price.value(), _quoter->_this_leg_data.tick_size()); + if (!same_price_qty) + { + _quoter->_price_quantity_state.update_out_price_quantity(price, quantity); + _quoter->_commit_drivers (); + _quoter->_modify_order(price, quantity); + } } }}